[jira] [Commented] (LOGGING-165) Add Automatic-Module-Name Manifest Header for Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

[ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181571#comment-16181571
 ] 

Benedikt Ritter commented on LOGGING-165:
-

{code}
~/w/a/c/commons-logging > svn ci -m "LOGGING-165: Add Automatic-Module-Name 
Manifest Header for Java 9 compatibility."
Sendingpom.xml
Sendingsrc/changes/changes.xml
Transmitting file data ..done
Committing transaction...
Committed revision 1809785.
{code}

Please check out whether the jar build from trunk works for you.

> Add Automatic-Module-Name Manifest Header for Java 9 compatibility
> --
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
> Fix For: 1.2.1
>
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LOGGING-165) Add Automatic-Module-Name Manifest Header for Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter updated LOGGING-165:

Summary: Add Automatic-Module-Name Manifest Header for Java 9 compatibility 
 (was: Java 9 compatibility)

> Add Automatic-Module-Name Manifest Header for Java 9 compatibility
> --
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
> Fix For: 1.2.1
>
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (IO-551) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

 [ 
https://issues.apache.org/jira/browse/IO-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter resolved IO-551.

   Resolution: Fixed
 Assignee: Benedikt Ritter
Fix Version/s: 2.6

{code}
~/w/a/c/commons-io git:(master) 2M > git ci -m "IO-551: Add 
Automatic-Module-Name MANIFEST entry for Java 9 compatibility."
[master af91ffc3] IO-551: Add Automatic-Module-Name MANIFEST entry for Java 9 
compatibility.
 2 files changed, 22 insertions(+)
{code}

> Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
> -
>
> Key: IO-551
> URL: https://issues.apache.org/jira/browse/IO-551
> Project: Commons IO
>  Issue Type: Improvement
>Reporter: Benedikt Ritter
>Assignee: Benedikt Ritter
> Fix For: 2.6
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IO-551) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 
Benedikt Ritter created IO-551:
--

 Summary: Add Automatic-Module-Name MANIFEST entry for Java 9 
compatibility
 Key: IO-551
 URL: https://issues.apache.org/jira/browse/IO-551
 Project: Commons IO
  Issue Type: Improvement
Reporter: Benedikt Ritter






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #290: Added string methods

2017-09-26 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/290
  
I agree with @garydgregory. @chtompki WDYT?


---

[jira] [Commented] (CODEC-239) Allows "look-alike" characters like 0 (digit zero) and 1 (digit one) as aliases for O (uppercase oh) and I (uppercase eye) respectively when decoding

2017-09-26 Thread Christopher Schultz (JIRA) 

[ 
https://issues.apache.org/jira/browse/CODEC-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181333#comment-16181333
 ] 

Christopher Schultz commented on CODEC-239:
---

Aah, I'm happy to use GitHub if that would be better for the community.

> Allows "look-alike" characters like 0 (digit zero) and 1 (digit one) as 
> aliases for O (uppercase oh) and I (uppercase eye) respectively when decoding
> -
>
> Key: CODEC-239
> URL: https://issues.apache.org/jira/browse/CODEC-239
> Project: Commons Codec
>  Issue Type: Improvement
>Affects Versions: 1.10
>Reporter: Christopher Schultz
>Priority: Minor
>  Labels: patch-available
> Attachments: CODEC-239-2.diff, CODEC-239.diff
>
>
> Allowing {{1}} -> {{I}} and {{0}} -> {{O}} can help usability, especially for 
> human users who are entering data expected to be in base32-encoded format.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEXT-101) Move RandomStringUtils to Commons-text

2017-09-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEXT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181254#comment-16181254
 ] 

ASF GitHub Bot commented on TEXT-101:
-

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/62
  
Hi @chtompki , do you see more places to improvement or its good now ?


> Move RandomStringUtils to Commons-text
> --
>
> Key: TEXT-101
> URL: https://issues.apache.org/jira/browse/TEXT-101
> Project: Commons Text
>  Issue Type: Task
>Reporter: Amey Jadiye
> Fix For: 1.2
>
>
> This task contains not just moving but ,
> 1. Keep RandomStringUtils deprecated in commons-lang.
> 2. Move RandomStringUtils class to commons-text.
> 3. Remove all existing code from methods of RandomStringUtils and call our
> brand new RandomStringGenerator in them. to return respective values i.e.
> randomNumeric, randomAlphabetic, randomAlphanumeric etc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOGGING-165) Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

[ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180919#comment-16180919
 ] 

Benedikt Ritter commented on LOGGING-165:
-

This looks like it will get complicated. See 
https://lists.apache.org/thread.html/cc12dd872e25335eda054da2c995672e33ffd9c4764270485d346b4d@%3Cdev.commons.apache.org%3E

> Java 9 compatibility
> 
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
> Fix For: 1.2.1
>
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LOGGING-163) BufferedReader is not closed properly

2017-09-26 Thread Benedikt Ritter (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LOGGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter updated LOGGING-163:

Fix Version/s: (was: Nightly Builds)
   1.2.1

> BufferedReader is not closed properly
> -
>
> Key: LOGGING-163
> URL: https://issues.apache.org/jira/browse/LOGGING-163
> Project: Commons Logging
>  Issue Type: Bug
>Affects Versions: 1.1.1, 1.2
>Reporter: Kaloyan Spiridonov
>Assignee: Gary Gregory
> Fix For: 1.2.1
>
>
> In LogFactory class at line 552 there is BufferedReader that is not closed 
> properly. For example if rd.readLine(); throw an exception then the Reader 
> will remain open.
> {code}
>  BufferedReader rd;
> try {
> rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
>  } catch (java.io.UnsupportedEncodingException e) {
>  rd = new BufferedReader(new InputStreamReader(is));
> }
> String factoryClassName = rd.readLine();
> rd.close();
> {code}
> In SimpleLog class at line 163 there is InputStream that is not closed 
> properly. 
> {code}
> InputStream in = getResourceAsStream("simplelog.properties");
> if(null != in) {
> try {
> simpleLogProps.load(in);
> in.close();
> } catch(java.io.IOException e) {
> // ignored
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOGGING-165) Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

[ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180887#comment-16180887
 ] 

Benedikt Ritter commented on LOGGING-165:
-

I'll add the Automatic-Module-Name header as a first fix and see if that is 
enough to fix this for the reporter.

> Java 9 compatibility
> 
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
> Fix For: 1.2.1
>
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LOGGING-165) Java 9 compatibility

2017-09-26 Thread Benedikt Ritter (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter updated LOGGING-165:

Fix Version/s: 1.2.1

> Java 9 compatibility
> 
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
> Fix For: 1.2.1
>
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #290: Added string methods

2017-09-26 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-lang/pull/290
  
The anagram method belongs in commons-text IMO.


---

[jira] [Closed] (JELLY-293) Accommodate toggling off DTD external entities.

2017-09-26 Thread Rob Tompkins (JIRA) 

 [ 
https://issues.apache.org/jira/browse/JELLY-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Tompkins closed JELLY-293.
--

Released in 1.0.1

> Accommodate toggling off DTD external entities.
> ---
>
> Key: JELLY-293
> URL: https://issues.apache.org/jira/browse/JELLY-293
> Project: Commons Jelly
>  Issue Type: Bug
>  Components: core / taglib.core
>Affects Versions: 1.0
>Reporter: Rob Tompkins
>Assignee: Rob Tompkins
> Fix For: 1.0.1
>
>
> We want the ability to configure whether or not jelly files can be declared 
> such that the doctype definition at the beginning of the XML can call out to 
> external entities under the parsing by SAX in the xerces project.
> The suggested fix is to add
> {code:java}
> if (!allowDtdToCallExternalEntities) {
> 
> reader.setFeature("http://xml.org/sax/features/external-general-entities;, 
> false);
> 
> reader.setFeature("http://xml.org/sax/features/external-parameter-entities;, 
> false);
> 
> reader.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd;,
>  false);
> }
> {code}
> immediately following this line: 
> https://github.com/apache/commons-jelly/blob/commons-jelly-1.0/src/java/org/apache/commons/jelly/parser/XMLParser.java#L496



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang pull request #290: Added string methods

2017-09-26 Thread iashok22 
GitHub user iashok22 opened a pull request:

https://github.com/apache/commons-lang/pull/290

Added string methods

1. indexOfAll - Finds and returns all the indexes of given character
2. isAnagram - Tells whether given string is anagram with another string

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/iashok22/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit 18e4f8173eb6c1ea3cc11548b043e927544be084
Author: Ashok 
Date:   2017-08-31T06:36:55Z

Added string methods




---

[jira] [Updated] (LOGGING-165) Java 9 compatibility

2017-09-26 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

陈宝仪 updated LOGGING-165:

Description: 
 Ading modularity headers so that other module can import it

[My project|https://github.com/leonchen83/redis-replicator] using 
commons-logging as dependency. 
When I use maven build my project. shows following warning:

[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
redis-replicator ---
[WARNING] 

[WARNING] * Required filename-based automodules detected. Please don't publish 
this project to a public artifact repository! *
[WARNING] 


The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
module-info.java). 

Env:
java version "9"
Java(TM) SE Runtime Environment (build 9+181)
Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)

  was: Ading modularity headers so that other module can import it


> Java 9 compatibility
> 
>
> Key: LOGGING-165
> URL: https://issues.apache.org/jira/browse/LOGGING-165
> Project: Commons Logging
>  Issue Type: Improvement
>Affects Versions: 1.2
>Reporter: 陈宝仪
>
>  Ading modularity headers so that other module can import it
> [My project|https://github.com/leonchen83/redis-replicator] using 
> commons-logging as dependency. 
> When I use maven build my project. shows following warning:
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
> redis-replicator ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> The root cause is commons-logging-1.2 is not a standard java 9 module(miss 
> module-info.java). 
> Env:
> java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)