[jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265749#comment-16265749
 ] 

ASF GitHub Bot commented on COMPRESS-430:
-

Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/57
  
Thank you Bruno


> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread Stefan Bodewig (JIRA) 

 [ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved COMPRESS-430.
-
Resolution: Fixed

Good catch, many thanks!

> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265746#comment-16265746
 ] 

ASF GitHub Bot commented on COMPRESS-430:
-

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/57


> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265655#comment-16265655
 ] 

ASF GitHub Bot commented on COMPRESS-430:
-

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/57
  

[![Coverage 
Status](https://coveralls.io/builds/14361284/badge)](https://coveralls.io/builds/14361284)

Coverage increased (+0.05%) to 85.932% when pulling 
**c0499042c2778161d6cecd54357adb6ea9595132 on 
kinow:synchronize-iteration-of-synchronized-list-1** into 
**10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master**.



> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265656#comment-16265656
 ] 

ASF GitHub Bot commented on COMPRESS-430:
-

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/57
  

[![Coverage 
Status](https://coveralls.io/builds/14361284/badge)](https://coveralls.io/builds/14361284)

Coverage increased (+0.05%) to 85.932% when pulling 
**c0499042c2778161d6cecd54357adb6ea9595132 on 
kinow:synchronize-iteration-of-synchronized-list-1** into 
**10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master**.



> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/COMPRESS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265654#comment-16265654
 ] 

ASF GitHub Bot commented on COMPRESS-430:
-

GitHub user kinow opened a pull request:

https://github.com/apache/commons-compress/pull/57

COMPRESS-430: Synchronize iteration of synchronized list

Synchronize the iteration as per Javadocs 
http://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList%28java.util.List

JIRA ticket https://issues.apache.org/jira/browse/COMPRESS-430

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kinow/commons-compress 
synchronize-iteration-of-synchronized-list-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit c0499042c2778161d6cecd54357adb6ea9595132
Author: Bruno P. Kinoshita 
Date:   2017-11-25T09:57:30Z

COMPRESS-430: Synchronize iteration of synchronized list




> Synchronize iteration on synchronized list in ParallelScatterZipCreator
> ---
>
> Key: COMPRESS-430
> URL: https://issues.apache.org/jira/browse/COMPRESS-430
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Archivers
>Affects Versions: 1.15
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>  Labels: concurrency
> Fix For: 1.16
>
>
> Following what is defined in the [Collections 
> javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
>  it might be a good idea to synchronize when iterating the stream list, that 
> is created with Collections.synchronizedList.
> This work originated after the pull request submitted to VALIDATOR-434, and 
> searching other components in commons using similar method to create lists 
> but not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (COMPRESS-430) Synchronize iteration on synchronized list in ParallelScatterZipCreator

2017-11-25 Thread Bruno P. Kinoshita (JIRA) 
Bruno P. Kinoshita created COMPRESS-430:
---

 Summary: Synchronize iteration on synchronized list in 
ParallelScatterZipCreator
 Key: COMPRESS-430
 URL: https://issues.apache.org/jira/browse/COMPRESS-430
 Project: Commons Compress
  Issue Type: Bug
  Components: Archivers
Affects Versions: 1.15
Reporter: Bruno P. Kinoshita
Priority: Minor
 Fix For: 1.16


Following what is defined in the [Collections 
javadoc|https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List)],
 it might be a good idea to synchronize when iterating the stream list, that is 
created with Collections.synchronizedList.

This work originated after the pull request submitted to VALIDATOR-434, and 
searching other components in commons using similar method to create lists but 
not synchronizing the iteration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Merge request merged in 7d061e33e59e23dc4b03378f35f50a7d70f033b3. Alas, I 
forgot to amend the commit to include the alias to close this pull request 
automatically.

@dieb could you close it, please?

Thanks!


---

[jira] [Resolved] (LANG-1370) Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread Bruno P. Kinoshita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita resolved LANG-1370.
--
Resolution: Fixed

> Fix EventCountCircuitBreaker increment batch
> 
>
> Key: LANG-1370
> URL: https://issues.apache.org/jira/browse/LANG-1370
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.concurrent.*
>Affects Versions: 3.7
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 3.8
>
>
> Place holder for https://github.com/apache/commons-lang/pull/309
> Fixes a bug where the increment count is not correctly propagated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LANG-1370) Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread Bruno P. Kinoshita (JIRA) 
Bruno P. Kinoshita created LANG-1370:


 Summary: Fix EventCountCircuitBreaker increment batch
 Key: LANG-1370
 URL: https://issues.apache.org/jira/browse/LANG-1370
 Project: Commons Lang
  Issue Type: Bug
  Components: lang.concurrent.*
Affects Versions: 3.7
Reporter: Bruno P. Kinoshita
Assignee: Bruno P. Kinoshita
Priority: Minor
 Fix For: 3.8


Place holder for https://github.com/apache/commons-lang/pull/309

Fixes a bug where the increment count is not correctly propagated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LANG-1370) Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265615#comment-16265615
 ] 

ASF GitHub Bot commented on LANG-1370:
--

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Ticket created in JIRA https://issues.apache.org/jira/browse/LANG-1370


> Fix EventCountCircuitBreaker increment batch
> 
>
> Key: LANG-1370
> URL: https://issues.apache.org/jira/browse/LANG-1370
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.concurrent.*
>Affects Versions: 3.7
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 3.8
>
>
> Place holder for https://github.com/apache/commons-lang/pull/309
> Fixes a bug where the increment count is not correctly propagated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Ticket created in JIRA https://issues.apache.org/jira/browse/LANG-1370


---