[GitHub] commons-lang issue #312: LANG-1375: defaultString(str) reuses defaultString(...

2018-01-19 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/312
  
Merged. Checked the pull request locally, built the project, ran tests, 
confirmed the diff, and then updated changes.xml.

Thanks again @codingsince1985 !


---

[jira] [Commented] (LANG-1375) defaultString(final String str) in StringUtils to reuse defaultString(final String str, final String defaultStr)

2018-01-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333170#comment-16333170
 ] 

ASF GitHub Bot commented on LANG-1375:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/312


> defaultString(final String str) in StringUtils to reuse defaultString(final 
> String str, final String defaultStr)
> 
>
> Key: LANG-1375
> URL: https://issues.apache.org/jira/browse/LANG-1375
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Jerry Zhao
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> {{defaultString(final String str)}}
> is a special case of
> {{defaultString(final String str, final String defaultStr)}}
> with defaultStr = StringUtils.EMPTY



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang pull request #312: LANG-1375: defaultString(str) reuses default...

2018-01-19 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/312


---

[jira] [Updated] (LANG-1375) defaultString(final String str) in StringUtils to reuse defaultString(final String str, final String defaultStr)

2018-01-19 Thread Bruno P. Kinoshita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita updated LANG-1375:
-
Assignee: Bruno P. Kinoshita

> defaultString(final String str) in StringUtils to reuse defaultString(final 
> String str, final String defaultStr)
> 
>
> Key: LANG-1375
> URL: https://issues.apache.org/jira/browse/LANG-1375
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Jerry Zhao
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> {{defaultString(final String str)}}
> is a special case of
> {{defaultString(final String str, final String defaultStr)}}
> with defaultStr = StringUtils.EMPTY



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LANG-1375) defaultString(final String str) in StringUtils to reuse defaultString(final String str, final String defaultStr)

2018-01-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333137#comment-16333137
 ] 

ASF GitHub Bot commented on LANG-1375:
--

GitHub user codingsince1985 opened a pull request:

https://github.com/apache/commons-lang/pull/312

LANG-1375: defaultString(str) reuses defaultString(str, defaultStr)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/codingsince1985/commons-lang LANG-1375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #312


commit d575057852ab2be41abb39b8de69a35cace5c67d
Author: Jerry Zhao 
Date:   2018-01-19T02:57:30Z

LANG-1375: defaultString(str) reuses defaultString(str, defaultStr)




> defaultString(final String str) in StringUtils to reuse defaultString(final 
> String str, final String defaultStr)
> 
>
> Key: LANG-1375
> URL: https://issues.apache.org/jira/browse/LANG-1375
> Project: Commons Lang
>  Issue Type: Improvement
>Reporter: Jerry Zhao
>Priority: Minor
>
> {{defaultString(final String str)}}
> is a special case of
> {{defaultString(final String str, final String defaultStr)}}
> with defaultStr = StringUtils.EMPTY



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang pull request #312: LANG-1375: defaultString(str) reuses default...

2018-01-19 Thread codingsince1985 
GitHub user codingsince1985 opened a pull request:

https://github.com/apache/commons-lang/pull/312

LANG-1375: defaultString(str) reuses defaultString(str, defaultStr)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/codingsince1985/commons-lang LANG-1375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #312


commit d575057852ab2be41abb39b8de69a35cace5c67d
Author: Jerry Zhao 
Date:   2018-01-19T02:57:30Z

LANG-1375: defaultString(str) reuses defaultString(str, defaultStr)




---

[jira] [Created] (LANG-1375) defaultString(final String str) in StringUtils to reuse defaultString(final String str, final String defaultStr)

2018-01-19 Thread Jerry Zhao (JIRA) 
Jerry Zhao created LANG-1375:


 Summary: defaultString(final String str) in StringUtils to reuse 
defaultString(final String str, final String defaultStr)
 Key: LANG-1375
 URL: https://issues.apache.org/jira/browse/LANG-1375
 Project: Commons Lang
  Issue Type: Improvement
Reporter: Jerry Zhao


{{defaultString(final String str)}}

is a special case of

{{defaultString(final String str, final String defaultStr)}}

with defaultStr = StringUtils.EMPTY



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NET-651) Ip Range Check with Subnte utils provides in correct answer

2018-01-19 Thread Sathyavathy Mohan (JIRA) 
Sathyavathy Mohan created NET-651:
-

 Summary: Ip Range Check with Subnte utils provides in correct 
answer
 Key: NET-651
 URL: https://issues.apache.org/jira/browse/NET-651
 Project: Commons Net
  Issue Type: Bug
Reporter: Sathyavathy Mohan


{code:java}
private static void checkIp() {
 System.out.println(verifyCommonsNet("192.168.0.1", "192.168.0.1/32"));
 System.out.println(verifySpringSecurity("192.168.0.1", "192.168.0.1/32"));
}

private static boolean verifyCommonsNet(String ip, String subnet) {
 SubnetUtils.SubnetInfo subnetInfo = (new SubnetUtils(subnet)).getInfo();
 return subnetInfo.isInRange(ip);
}

private static boolean verifySpringSecurity(String ip, String subnet) {
 IpAddressMatcher ipAddressMatcher = new IpAddressMatcher(subnet);
 return ipAddressMatcher.matches(ip);
}{code}
 

Tried to check Ip range functionality with Subnet Utils. But I get an incorrect 
answer when using mask of 32. The same CIDR with Spring security provides the 
right answer. checking 192.168.0.1 against 192.168.0.1/32 should return true. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RNG-45) Example code (sampling)

2018-01-19 Thread Gilles (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332467#comment-16332467
 ] 

Gilles commented on RNG-45:
---

Java code added to "master" (commit 71f4e2cd252b90bb2ab617b4480fd3f73acc8a63).

> Example code (sampling)
> ---
>
> Key: RNG-45
> URL: https://issues.apache.org/jira/browse/RNG-45
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Trivial
>  Labels: doc, example, usage
> Fix For: 1.1
>
> Attachments: ProbabilityDensityApproximation.java
>
>
> I've added a few figures to the userguide (see commit 
> 5de2d1af79fabca56b5fa8fca159938fa023ae6a).
> The Java code that generates the data is a fairly trivial example of usage of 
> the samplers provided in module {{commons-rng-sampling}}.
> It is attached to this page.
> Do you think it's worth adding it to the repository (in 
> {{commons-rng-examples}})?
> If so, should I also add the script that generated the plots (it calls the 
> "gnuplot" software)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)