[jira] [Resolved] (LANG-1356) Add bypass option for classes to recursive and reflective EqualsBuilder

2018-02-11 Thread Pascal Schumacher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher resolved LANG-1356.
-
   Resolution: Fixed
 Assignee: Pascal Schumacher
Fix Version/s: 3.8

Patch applied. Thanks!

> Add bypass option for classes to recursive and reflective EqualsBuilder
> ---
>
> Key: LANG-1356
> URL: https://issues.apache.org/jira/browse/LANG-1356
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Pascal Schumacher
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
> Attachments: LANG-1356.patch
>
>
> {quote}String are now compared with internal data (hash and char[]). But 
> sometimes hash value is not initialized, this is probably a cache for the 
> hashcode. So the comparison fails even if the char[] content is the same.
> You should add the bypass for basic JRE classes (String, Datetime types, 
> etc.){quote}
> reported at 
> https://github.com/apache/commons-lang/pull/202#issuecomment-333874925



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LANG-1356) Add bypass option for classes to recursive and reflective EqualsBuilder

2018-02-11 Thread Pascal Schumacher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated LANG-1356:

Summary: Add bypass option for classes to recursive and reflective 
EqualsBuilder  (was: Add bypass for basic JRE classes to recursive and 
reflective EqualsBuilder)

> Add bypass option for classes to recursive and reflective EqualsBuilder
> ---
>
> Key: LANG-1356
> URL: https://issues.apache.org/jira/browse/LANG-1356
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Pascal Schumacher
>Priority: Major
> Attachments: LANG-1356.patch
>
>
> {quote}String are now compared with internal data (hash and char[]). But 
> sometimes hash value is not initialized, this is probably a cache for the 
> hashcode. So the comparison fails even if the char[] content is the same.
> You should add the bypass for basic JRE classes (String, Datetime types, 
> etc.){quote}
> reported at 
> https://github.com/apache/commons-lang/pull/202#issuecomment-333874925



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359950#comment-16359950
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/314
  
Thanks!  


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang issue #314: LANG-1060 NumberUtils.isNumber assumes number start...

2018-02-11 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/314
  
Thanks! 👍 


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359949#comment-16359949
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/314


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang pull request #314: LANG-1060 NumberUtils.isNumber assumes numbe...

2018-02-11 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/314


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359945#comment-16359945
 ] 

ASF GitHub Bot commented on LANG-1060:
--

GitHub user piotrkosyoo opened a pull request:

https://github.com/apache/commons-lang/pull/314

LANG-1060 NumberUtils.isNumber assumes number starting with Zero is octal

Add test case

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/piotrkosOpen/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit 6001ce20ac49522cfd6f066b8a8bd29aab74abfb
Author: Piotr Kosmala 
Date:   2018-02-10T14:19:36Z

LANG-1060: NumberUtils.isNumber assumes number starting with Zero is
octal

commit 2626c00e8be29343324c755b0c4a8a56cb7dc71d
Author: Piotr Kosmala 
Date:   2018-02-11T13:32:13Z

LANG-1060: NumberUtils.isNumber assumes number starting with Zero is
octal
Update tests




> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang pull request #314: LANG-1060 NumberUtils.isNumber assumes numbe...

2018-02-11 Thread piotrkosyoo 
GitHub user piotrkosyoo opened a pull request:

https://github.com/apache/commons-lang/pull/314

LANG-1060 NumberUtils.isNumber assumes number starting with Zero is octal

Add test case

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/piotrkosOpen/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit 6001ce20ac49522cfd6f066b8a8bd29aab74abfb
Author: Piotr Kosmala 
Date:   2018-02-10T14:19:36Z

LANG-1060: NumberUtils.isNumber assumes number starting with Zero is
octal

commit 2626c00e8be29343324c755b0c4a8a56cb7dc71d
Author: Piotr Kosmala 
Date:   2018-02-11T13:32:13Z

LANG-1060: NumberUtils.isNumber assumes number starting with Zero is
octal
Update tests




---

[jira] [Resolved] (LANG-1364) ExceptionUtils#getRootCause(Throwable t) should return t if no lower level cause exists

2018-02-11 Thread Pascal Schumacher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher resolved LANG-1364.
-
   Resolution: Fixed
 Assignee: Pascal Schumacher
Fix Version/s: 3.8

> ExceptionUtils#getRootCause(Throwable t) should return t if no lower level 
> cause exists
> ---
>
> Key: LANG-1364
> URL: https://issues.apache.org/jira/browse/LANG-1364
> Project: Commons Lang
>  Issue Type: Bug
>Affects Versions: 3.6
>Reporter: Pascal Schumacher
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> {quote}
> I have found the design of three root cause related methods inconsistent
> when the input Throwable does not wrap up another Throwable.
> These three methods are
>1. getRootCause(Throwable t)
>2. getRootCauseMessage(Throwable t)
>3. getRootCauseStackTrace(Throwable t)
> When the input t has no lower level cause:
>- the first method returns null;
>- the second method returns the message of t, which means the input t is
>considered as the root cause in this method;
>- the third method returns the stack trace of t, which also means this
>method considers t as the root cause.
> Therefore, I consider the design of the first method is not consistent with
> the second and the third.
> I usually write a function myself to get the root cause of an exception;
> and it makes much better sense to me the root cause of a Throwable is
> itself if no more lower level cause exists.
> A request: change the first method to return t itself when there is no more
> 'causes'.
> {quote}
> Reported by Zheng Xie in 
> https://mail-archives.apache.org/mod_mbox/commons-dev/201710.mbox/%3CCAL-LHk7jvQGM9J1SPxLB2qEsXazwwq%2BYKuv29XgWXEcccHUn0w%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LANG-1364) ExceptionUtils#getRootCause(Throwable t) should return t if no lower level cause exists

2018-02-11 Thread Pascal Schumacher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher updated LANG-1364:

Summary: ExceptionUtils#getRootCause(Throwable t) should return t if no 
lower level cause exists  (was: ExceptionUtils#getRootCause* inconsistency)

> ExceptionUtils#getRootCause(Throwable t) should return t if no lower level 
> cause exists
> ---
>
> Key: LANG-1364
> URL: https://issues.apache.org/jira/browse/LANG-1364
> Project: Commons Lang
>  Issue Type: Bug
>Affects Versions: 3.6
>Reporter: Pascal Schumacher
>Priority: Major
>
> {quote}
> I have found the design of three root cause related methods inconsistent
> when the input Throwable does not wrap up another Throwable.
> These three methods are
>1. getRootCause(Throwable t)
>2. getRootCauseMessage(Throwable t)
>3. getRootCauseStackTrace(Throwable t)
> When the input t has no lower level cause:
>- the first method returns null;
>- the second method returns the message of t, which means the input t is
>considered as the root cause in this method;
>- the third method returns the stack trace of t, which also means this
>method considers t as the root cause.
> Therefore, I consider the design of the first method is not consistent with
> the second and the third.
> I usually write a function myself to get the root cause of an exception;
> and it makes much better sense to me the root cause of a Throwable is
> itself if no more lower level cause exists.
> A request: change the first method to return t itself when there is no more
> 'causes'.
> {quote}
> Reported by Zheng Xie in 
> https://mail-archives.apache.org/mod_mbox/commons-dev/201710.mbox/%3CCAL-LHk7jvQGM9J1SPxLB2qEsXazwwq%2BYKuv29XgWXEcccHUn0w%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359928#comment-16359928
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Sure, that is fine!


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Sure, that is fine!


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359921#comment-16359921
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user piotrkosyoo commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
ok in this same issue number ?


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread piotrkosyoo 
Github user piotrkosyoo commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
ok in this same issue number ?


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359903#comment-16359903
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
A pull request with tests for the `float` case would be welcome. 


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
A pull request with tests for the `float` case would be welcome. 


---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread piotrkosyoo 
Github user piotrkosyoo commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
No problem Sir,
Calling Number.to Float also works correctly, and I skip this point.  but 
maybe
 better is add the tests for this case?


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359902#comment-16359902
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user piotrkosyoo commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
No problem Sir,
Calling Number.to Float also works correctly, and I skip this point.  but 
maybe
 better is add the tests for this case?


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread Pascal Schumacher (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pascal Schumacher resolved LANG-1060.
-
   Resolution: Fixed
 Assignee: Pascal Schumacher  (was: Rob Tompkins)
Fix Version/s: (was: 3.x)
   3.8

> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Pascal Schumacher
>Priority: Major
> Fix For: 3.8
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang pull request #313: LANG-1060: NumberUtils.isNumber assumes numb...

2018-02-11 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/313


---

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359895#comment-16359895
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/313


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Rob Tompkins
>Priority: Major
> Fix For: 3.x
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LANG-1060) NumberUtils.isNumber assumes number starting with Zero is octal

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359896#comment-16359896
 ] 

ASF GitHub Bot commented on LANG-1060:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Thanks!  


> NumberUtils.isNumber assumes number starting with Zero is octal
> ---
>
> Key: LANG-1060
> URL: https://issues.apache.org/jira/browse/LANG-1060
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.3.2
>Reporter: James Haugen
>Assignee: Rob Tompkins
>Priority: Major
> Fix For: 3.x
>
>
> The isNumber method assumes, that if the String being passed in doesn't have 
> an 'X' at the second char it is an octal number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

2018-02-11 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Thanks! 👍 


---