[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete.
{code:java}
// code placeholder
public void closeArchiveEntry() throws IOException {
if (this.finished) {
throw new IOException("Stream has already been finished");
} else if (!this.haveUnclosedEntry) {
throw new IOException("No current entry to close");
} else {
this.out.flushBlock();
if (this.currBytes < this.currSize) {
throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written");
} else {
this.recordsWritten = (int)((long)this.recordsWritten +
this.currSize / 512L);
if (0L != this.currSize % 512L) {
++this.recordsWritten;
}
this.haveUnclosedEntry = false;
}
}
}
{code}
I think this is a bug, when closeArchiveEntry() called，should not throw the
follow IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written").
{code:java}
// code placeholder
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
{code}
Please help, thk!!!
was:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete.
{code:java}
// code placeholder
public void closeArchiveEntry() throws IOException {
if (this.finished) {
throw new IOException("Stream has already been finished");
} else if (!this.haveUnclosedEntry) {
throw new IOException("No current entry to close");
} else {
this.out.flushBlock();
if (this.currBytes < this.currSize) {
throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written");
} else {
this.recordsWritten = (int)((long)this.recordsWritten +
this.currSize / 512L);
if (0L != this.currSize % 512L) {
++this.recordsWritten;
}
this.haveUnclosedEntry = false;
}
}
}
{code}
I think this is a bug, when closeArchiveEntry() called，should not throw the
follow the IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written").
{code:java}
// code placeholder
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
{code}
Please help, thk!!!
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete.
> {code:java}
> // code placeholder
> public void closeArchiveEntry() throws IOException {
> if (this.finished) {
> throw new IOException("Stream has already been finished");
> } else if (!this.haveUnclosedEntry) {
> throw new IOException("No current entry to close");
> } else {
> this.out.flushBlock();
> if (this.currBytes < this.currSize) {
> throw new IOException("entry '" + this.currName + "' closed at '"
> +
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete.
{code:java}
// code placeholder
public void closeArchiveEntry() throws IOException {
if (this.finished) {
throw new IOException("Stream has already been finished");
} else if (!this.haveUnclosedEntry) {
throw new IOException("No current entry to close");
} else {
this.out.flushBlock();
if (this.currBytes < this.currSize) {
throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written");
} else {
this.recordsWritten = (int)((long)this.recordsWritten +
this.currSize / 512L);
if (0L != this.currSize % 512L) {
++this.recordsWritten;
}
this.haveUnclosedEntry = false;
}
}
}
{code}
I think this is a bug, when closeArchiveEntry() called，should not throw the
follow the IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written").
{code:java}
// code placeholder
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
{code}
Please help, thk!!!
was:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug, when closeArchiveEntry() called，should not throw the follow the
IOException("entry '" + this.currName + "' closed at '" + this.currBytes + "'
before the '" + this.currSize + "' bytes specified in the header were written").
{code:java}
// code placeholder
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
{code}
Please help, thk!!!
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete.
> {code:java}
> // code placeholder
> public void closeArchiveEntry() throws IOException {
> if (this.finished) {
> throw new IOException("Stream has already been finished");
> } else if (!this.haveUnclosedEntry) {
> throw new IOException("No current entry to close");
> } else {
> this.out.flushBlock();
> if (this.currBytes < this.currSize) {
> throw new IOException("entry '" + this.currName + "' closed at '"
> + this.currBytes + "' before the '" + this.currSize + "' bytes specified in
> the header were written");
> } else {
> this.recordsWritten = (int)((long)this.recordsWritten +
> this.currSize / 512L);
> if (0L != this.currSize % 512L) {
> ++this.recordsWritten;
> }
> this.haveUnclosedEntry = false;
> }
> }
> }
> {code}
> I think this is a bug, when closeArchiveEntry() called，should not throw the
> follow the IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written").
> {code:java}
> // code placeholder
> if (this.currBytes < this.currSize)
> { throw new IOException("entry '" + this.currName + "' closed at '" +
>
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug, when closeArchiveEntry() called，should not throw the follow the
IOException("entry '" + this.currName + "' closed at '" + this.currBytes + "'
before the '" + this.currSize + "' bytes specified in the header were written").
{code:java}
// code placeholder
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
{code}
Please help, thk!!!
was:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug, when closeArchiveEntry() called，should not throw the follow the
IOException("entry '" + this.currName + "' closed at '" + this.currBytes + "'
before the '" + this.currSize + "' bytes specified in the header were written").
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
Please help, thk!!!
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think
> this is a bug, when closeArchiveEntry() called，should not throw the follow
> the IOException("entry '" + this.currName + "' closed at '" + this.currBytes
> + "' before the '" + this.currSize + "' bytes specified in the header were
> written").
>
> {code:java}
> // code placeholder
> if (this.currBytes < this.currSize)
> { throw new IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written"); }
> {code}
>
>
> Please help, thk!!!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug, when closeArchiveEntry() called，should not throw the follow the
IOException("entry '" + this.currName + "' closed at '" + this.currBytes + "'
before the '" + this.currSize + "' bytes specified in the header were written").
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
Please help, thk!!!
was:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug,Please help, thk!!!
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think
> this is a bug, when closeArchiveEntry() called，should not throw the follow
> the IOException("entry '" + this.currName + "' closed at '" + this.currBytes
> + "' before the '" + this.currSize + "' bytes specified in the header were
> written").
>
> if (this.currBytes < this.currSize)
> { throw new IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written"); }
>
> Please help, thk!!!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the archiveEntry use method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug,Please help, thk!!!
if (this.currBytes < this.currSize)
{ throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written"); }
was:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug,Please help, thk!!!
if (this.currBytes < this.currSize) {
throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written");
}
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think
> this is a bug,Please help, thk!!!
> if (this.currBytes < this.currSize)
> { throw new IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written"); }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Fix Version/s: (was: 1.18)
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the archiveEntry use method closeArchiveEntry() of
> the TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think
> this is a bug,Please help, thk!!!
> if (this.currBytes < this.currSize)
> { throw new IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written"); }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
[
https://issues.apache.org/jira/browse/COMPRESS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangxinyue updated COMPRESS-457:
-
Flags: Important
Environment: all are environment can recurring this problems
Description:
When there is no space in the disk，I want to delete the Compressed half file，
in my code，I close the method closeArchiveEntry() of the
TarArchiveOutputStream class，but because follow code
fragments，closeArchiveEntry() is not work，I cannoot close io stream
TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think this
is a bug,Please help, thk!!!
if (this.currBytes < this.currSize) {
throw new IOException("entry '" + this.currName + "' closed at '" +
this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
header were written");
}
was:When there is no space in the disk，I want to delete the Compressed half
file， in my code，I close the method closeArchiveEntry() of the
TarArchiveOutputStream class，but because
> When there is no space in the disk，the method closeArchiveEntry() cannot work
> -
>
> Key: COMPRESS-457
> URL: https://issues.apache.org/jira/browse/COMPRESS-457
> Project: Commons Compress
> Issue Type: Bug
> Components: Compressors
>Affects Versions: 1.16, 1.17
> Environment: all are environment can recurring this problems
>Reporter: zhangxinyue
>Priority: Major
> Fix For: 1.18
>
>
> When there is no space in the disk，I want to delete the Compressed half
> file， in my code，I close the method closeArchiveEntry() of the
> TarArchiveOutputStream class，but because follow code
> fragments，closeArchiveEntry() is not work，I cannoot close io stream
> TarArchiveOutputStream，so that the tmp *.tar.gz cannot be delete, I think
> this is a bug,Please help, thk!!!
> if (this.currBytes < this.currSize) {
> throw new IOException("entry '" + this.currName + "' closed at '" +
> this.currBytes + "' before the '" + this.currSize + "' bytes specified in the
> header were written");
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (COMPRESS-457) When there is no space in the disk，the method closeArchiveEntry() cannot work
zhangxinyue created COMPRESS-457: Summary: When there is no space in the disk，the method closeArchiveEntry() cannot work Key: COMPRESS-457 URL: https://issues.apache.org/jira/browse/COMPRESS-457 Project: Commons Compress Issue Type: Bug Components: Compressors Affects Versions: 1.17, 1.16 Reporter: zhangxinyue Fix For: 1.18 When there is no space in the disk，I want to delete the Compressed half file， in my code，I close the method closeArchiveEntry() of the TarArchiveOutputStream class，but because -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #334: Code refactoring and cleaning
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/334 Thanks! ð ---
[GitHub] commons-lang pull request #334: Code refactoring and cleaning
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/334 ---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/331 @chonton No further review comments by anyone, so I guess this is good to merge? ---
[jira] [Commented] (LANG-1380) FastDateParser too strict on abbreviated short month symbols
[
https://issues.apache.org/jira/browse/LANG-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525434#comment-16525434
]
ASF GitHub Bot commented on LANG-1380:
--
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/331
@chonton No further review comments by anyone, so I guess this is good to
merge?
> FastDateParser too strict on abbreviated short month symbols
>
>
> Key: LANG-1380
> URL: https://issues.apache.org/jira/browse/LANG-1380
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.7
>Reporter: Markus Jelsma
>Priority: Minor
> Fix For: 3.8
>
> Attachments: LANG-1380.patch
>
>
> The date format symbols of the French locale adds a . (dot) when short month
> names are really abbreviated.
> {code}
> janv.
> févr.
> mars
> avr.
> mai
> juin
> juil.
> août
> sept.
> oct.
> nov.
> déc.
> {code}
> But in real world examples, the dot is frequently omitted.
> FastDateParser should be lenient in the case where the dot isn't there, e.g.
> "14 avr 2014".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (JEXL-263) Can't declare Local variables in jexl3
ori marko created JEXL-263:
--
Summary: Can't declare Local variables in jexl3
Key: JEXL-263
URL: https://issues.apache.org/jira/browse/JEXL-263
Project: Commons JEXL
Issue Type: Bug
Affects Versions: 3.1
Reporter: ori marko
I failed to define Local variables
var x;
I got exception:
{{org.apache.commons.jexl3.JexlException$Parsing: @1:1 parsing error in 'var'
at org.apache.commons.jexl3.JexlEngine.createExpression(JexlEngine.java:304)
~[commons-jexl3-3.1.jar:3.1] at
org.apache.jmeter.functions.Jexl3Function.execute(Jexl3Function.java:94)
[ApacheJMeter_functions.jar:4.0 r1823414] at
org.apache.jmeter.engine.util.CompoundVariable.execute(CompoundVariable.java:137)
[ApacheJMeter_core.jar:4.0 r1823414]}}
relevant question:
https://stackoverflow.com/questions/50021110/jmeter-jexl3-function-cant-declare-local-variables
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (DBCP-509) Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource
Bruno P. Kinoshita created DBCP-509: --- Summary: Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource Key: DBCP-509 URL: https://issues.apache.org/jira/browse/DBCP-509 Project: Commons DBCP Issue Type: Improvement Affects Versions: 2.4.0 Reporter: Bruno P. Kinoshita Fix For: 2.5.0 While working on DBCP-504 tests, I wrote a few files to help me automating some of the tests (e.g. https://gist.github.com/kinow/053b6d1f293fdc208a2a14571f246786). In PerUserPooldataSource, I realized I had to change some tests that were failing to handle null values. But not all methods. So I had a look at the methods, and the majority was following a pattern * using primitives * default'ing to the class/parent method getDefaultPropertyZ() whenever Z property was null But three values were using objects instead of primitives, and allowing null's: * defaultAutoCommit * defaultReadOnly * perUserDefaultAutoCommit I prepared a pull request that falls back to the default method's values. It's more of a discussion issue, just to document what I found during DBCP-504. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
