[jira] [Updated] (IO-584) Add a module info descriptor
[ https://issues.apache.org/jira/browse/IO-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated IO-584: -- Summary: Add a module info descriptor (was: Modularize commons-io) > Add a module info descriptor > > > Key: IO-584 > URL: https://issues.apache.org/jira/browse/IO-584 > Project: Commons IO > Issue Type: Improvement > Components: Filters, Streams/Writers, Utilities >Affects Versions: 2.6 >Reporter: Jeff Gullett >Priority: Minor > Fix For: 2.7 > > > Since commons-io is an automatic module, clients are unable to run jlink > against anything that is dependent upon it. Add a module-info.java file, in > order enable using jlink with commons-io. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (VALIDATOR-448) Tests failing on trunk
Eitan Adler created VALIDATOR-448:
-
Summary: Tests failing on trunk
Key: VALIDATOR-448
URL: https://issues.apache.org/jira/browse/VALIDATOR-448
Project: Commons Validator
Issue Type: Bug
Environment: ∴java -version
java version "11" 2018-09-25
Java(TM) SE Runtime Environment 18.9 (build 11+28)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
∴jshell -version
jshell 11
Additionally verified on Java 10 and Java 9.
Hopefully should not matter but worth noting:
∴locale
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL=
Reporter: Eitan Adler
Commons Validator has failing tests on trunk. The failing tests boils down to
this:
{code:java}
jshell> import org.apache.commons.validator.routines.CalendarValidator;
jshell> var cv = new CalendarValidator();
jshell> var i = CalendarValidator.getInstance();
jshell> i.validate("31 Dez 2005", "dd MMM ", Locale.GERMAN);
$9 ==> null{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] commons-lang pull request #299: Add module-info for Java 9
Github user lploom commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r221431119
--- Diff: src/main/java/module-info.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Apache Commons Lang provides utility classes for the core of Java.
+ */
+module org.apache.commons.lang3 {
+
+// see AbstractCircuitBreaker
+requires static java.desktop;
--- End diff --
Isn't the best option to refactor the concurrent package to separate
project? Doesn't seem like a great fit here anyhow.
---
[GitHub] commons-lang issue #359: these 2 links seem to be broken
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/359 [](https://coveralls.io/builds/19261608) Coverage remained the same at 95.253% when pulling **3035e12e557559297deef2b8501f5a0ba88c448d on fanofxiaofeng:patch-1** into **69e843890c09861a168c6fe77d63fc72f0c73195 on apache:master**. ---
[GitHub] commons-lang pull request #359: these 2 links seem to be broken
GitHub user fanofxiaofeng opened a pull request: https://github.com/apache/commons-lang/pull/359 these 2 links seem to be broken These 2 links seem to be broken, just fix them~   You can merge this pull request into a Git repository by running: $ git pull https://github.com/fanofxiaofeng/commons-lang patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #359 commit 3035e12e557559297deef2b8501f5a0ba88c448d Author: é³é³ <260893248@...> Date: 2018-09-29T11:49:03Z these 2 links seem to be broken These 2 links seem to be broken, just fix them~ ---
