[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439889=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439889 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 04:41 Start Date: 02/Jun/20 04:41 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31176899) Coverage increased (+0.005%) to 95.046% when pulling **2a1dc56c6a2c77fc1e26e1962da787d7b0dc48e4 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439889) Time Spent: 2h (was: 1h 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31176899) Coverage increased (+0.005%) to 95.046% when pulling **2a1dc56c6a2c77fc1e26e1962da787d7b0dc48e4 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #128: Add word-wise comparator
kinow commented on pull request #128: URL: https://github.com/apache/commons-text/pull/128#issuecomment-637259210 @aeon-fruit sorry for the delay. The code looks really good from an initial quick look. Will try to review it the next time I have spare time to work on [text], so that we can include it in a next release :+1: Thanks for the pull request! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham
kinow commented on pull request #103: URL: https://github.com/apache/commons-text/pull/103#issuecomment-637259000 @ameyjadiye whenever you have time to update this PR, I will have another look and try to review/merge it :+1: thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity
[ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=439881=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439881 ] ASF GitHub Bot logged work on TEXT-126: --- Author: ASF GitHub Bot Created on: 02/Jun/20 04:07 Start Date: 02/Jun/20 04:07 Worklog Time Spent: 10m Work Description: kinow commented on pull request #103: URL: https://github.com/apache/commons-text/pull/103#issuecomment-637259000 @ameyjadiye whenever you have time to update this PR, I will have another look and try to review/merge it :+1: thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439881) Time Spent: 15.5h (was: 15h 20m) > Dice's Coefficient Algorithm in String similarity > - > > Key: TEXT-126 > URL: https://issues.apache.org/jira/browse/TEXT-126 > Project: Commons Text > Issue Type: Improvement >Reporter: Vicky Chawda >Priority: Major > Time Spent: 15.5h > Remaining Estimate: 0h > > I'd like to propose an extension to the algorithms for string similarity in > *commons-text/src/main/java/org/apache/commons/text/similarity/* > Dice's Coefficient Algorithm can be helpful for many who are looking for > ranking similarities in strings. > *Inspired from* - [http://www.catalysoft.com/articles/StrikeAMatch.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity
[
https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=439880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439880
]
ASF GitHub Bot logged work on TEXT-126:
---
Author: ASF GitHub Bot
Created on: 02/Jun/20 04:06
Start Date: 02/Jun/20 04:06
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #103:
URL: https://github.com/apache/commons-text/pull/103#discussion_r433608502
##
File path:
src/main/java/org/apache/commons/text/similarity/SorensenDiceSimilarity.java
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.similarity;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.function.Function;
+
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * A similarity algorithm indicating the percentage of matched characters
+ * between two character sequences.
+ *
+ *
+ * The Srensen-Dice coefficient is a statistic used for comparing the
+ * similarity of two samples. It was independently developed by the botanists
+ * Thorvald Srensen and Lee Raymond Dice, who published in 1948 and 1945
+ * respectively. The index is known by several other names, especially
+ * Srensen-Dice index, Srensen index and Dice's coefficient. Other
+ * variations include the "similarity coefficient" or "index", such as Dice
+ * similarity coefficient (DSC).
+ *
+ *
+ *
+ * This implementation is based on the Srensen-Dice similarity algorithm
+ * from http://en.wikipedia.org/wiki/S%C3%B8rensen%E2%80%93Dice_coefficient;>
+ * http://en.wikipedia.org/wiki/S%C3%B8rensen%E2%80%93Dice_coefficient.
+ *
+ *
+ *
+ *
+ * @since 1.7
+ */
+public class SorensenDiceSimilarity implements SimilarityScore {
+
+/**
+ * For shifting bigrams to fit in single integer.
+ */
+private static final int SHIFT_NUMBER = 16;
+
+/**
+ * Converter function for conversion of string to bigrams.
+ */
+private final Function> converter = new
SorensenDiceConverter();
+
+/**
+ * Measures the overlap of two sets created from a pair of character
sequences.
+ * {@link OverlapSimilarity}}
+ */
+private final IntersectionSimilarity similarity = new
IntersectionSimilarity<>(this.converter);
+
+/**
+ * Calculates Sorensen-Dice Similarity of two character sequences passed as
+ * input.
+ *
+ *
+ * similarity.apply(null, null) = IllegalArgumentException
+ * similarity.apply("foo", null)= IllegalArgumentException
+ * similarity.apply(null, "foo")= IllegalArgumentException
+ * similarity.apply("night", "nacht") = 0.25
+ * similarity.apply("", "") = 1.0
+ * similarity.apply("foo", "foo") = 1.0
+ * similarity.apply("foo", "foo ") = 0.8
+ * similarity.apply("foo", "foo ") = 0.66
Review comment:
ping @ameyjadiye
Good spotting @mvarela
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 439880)
Time Spent: 15h 20m (was: 15h 10m)
> Dice's Coefficient Algorithm in String similarity
> -
>
> Key: TEXT-126
> URL: https://issues.apache.org/jira/browse/TEXT-126
> Project: Commons Text
> Issue Type: Improvement
>Reporter: Vicky Chawda
>Priority: Major
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> I'd like to propose an extension to the algorithms for string similarity in
> *commons-text/src/main/java/org/apache/commons/text/similarity/*
> Dice's Coefficient Algorithm can be helpful for many who are looking for
> ranking similarities
[GitHub] [commons-text] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham
kinow commented on a change in pull request #103:
URL: https://github.com/apache/commons-text/pull/103#discussion_r433608502
##
File path:
src/main/java/org/apache/commons/text/similarity/SorensenDiceSimilarity.java
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.similarity;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.function.Function;
+
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * A similarity algorithm indicating the percentage of matched characters
+ * between two character sequences.
+ *
+ *
+ * The Srensen-Dice coefficient is a statistic used for comparing the
+ * similarity of two samples. It was independently developed by the botanists
+ * Thorvald Srensen and Lee Raymond Dice, who published in 1948 and 1945
+ * respectively. The index is known by several other names, especially
+ * Srensen-Dice index, Srensen index and Dice's coefficient. Other
+ * variations include the "similarity coefficient" or "index", such as Dice
+ * similarity coefficient (DSC).
+ *
+ *
+ *
+ * This implementation is based on the Srensen-Dice similarity algorithm
+ * from http://en.wikipedia.org/wiki/S%C3%B8rensen%E2%80%93Dice_coefficient;>
+ * http://en.wikipedia.org/wiki/S%C3%B8rensen%E2%80%93Dice_coefficient.
+ *
+ *
+ *
+ *
+ * @since 1.7
+ */
+public class SorensenDiceSimilarity implements SimilarityScore {
+
+/**
+ * For shifting bigrams to fit in single integer.
+ */
+private static final int SHIFT_NUMBER = 16;
+
+/**
+ * Converter function for conversion of string to bigrams.
+ */
+private final Function> converter = new
SorensenDiceConverter();
+
+/**
+ * Measures the overlap of two sets created from a pair of character
sequences.
+ * {@link OverlapSimilarity}}
+ */
+private final IntersectionSimilarity similarity = new
IntersectionSimilarity<>(this.converter);
+
+/**
+ * Calculates Sorensen-Dice Similarity of two character sequences passed as
+ * input.
+ *
+ *
+ * similarity.apply(null, null) = IllegalArgumentException
+ * similarity.apply("foo", null)= IllegalArgumentException
+ * similarity.apply(null, "foo")= IllegalArgumentException
+ * similarity.apply("night", "nacht") = 0.25
+ * similarity.apply("", "") = 1.0
+ * similarity.apply("foo", "foo") = 1.0
+ * similarity.apply("foo", "foo ") = 0.8
+ * similarity.apply("foo", "foo ") = 0.66
Review comment:
ping @ameyjadiye
Good spotting @mvarela
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31175823) Coverage decreased (-0.02%) to 95.02% when pulling **d53bb278a576521ccc800c0303f459978b25dbee on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439871 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 03:27 Start Date: 02/Jun/20 03:27 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31175823) Coverage decreased (-0.02%) to 95.02% when pulling **d53bb278a576521ccc800c0303f459978b25dbee on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439871) Time Spent: 1h 50m (was: 1h 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclusion:** In cases for small content readers, the new function is slightly faster. but in cases for large content, the new function can be 6.5 times faster. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO]
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439866=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439866 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:56 Start Date: 02/Jun/20 02:56 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory **Conclusion:** after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark:
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439867 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 02/Jun/20 02:56 Start Date: 02/Jun/20 02:56 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclusion:** In cases for small content readers, the new function is slightly faster. but in cases for large content, the new function can be 6.5 times faster. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected:
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory **Conclusion:** after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup Iteration 1: 1830971983.333 ns/op # Warmup Iteration 2: 2188674760.000 ns/op # Warmup Iteration 3: 2181211500.000 ns/op # Warmup Iteration 4: 2349953100.000 ns/op # Warmup Iteration 5: 2360081080.000 ns/op Iteration 1: 2212511940.000 ns/op Iteration 2: 2384214220.000 ns/op
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup Iteration 1: 1830971983.333 ns/op # Warmup Iteration 2: 2188674760.000 ns/op # Warmup Iteration 3: 2181211500.000 ns/op # Warmup Iteration 4: 2349953100.000 ns/op # Warmup Iteration 5: 2360081080.000 ns/op Iteration 1: 2212511940.000 ns/op Iteration 2: 2384214220.000 ns/op Iteration 3: 2227561540.000
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439861 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:48 Start Date: 02/Jun/20 02:48 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439862 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:48 Start Date: 02/Jun/20 02:48 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark:
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup Iteration 1: 1830971983.333 ns/op # Warmup Iteration 2: 2188674760.000 ns/op # Warmup Iteration 3: 2181211500.000 ns/op # Warmup Iteration 4: 2349953100.000 ns/op # Warmup Iteration 5: 2360081080.000 ns/op Iteration 1: 2212511940.000 ns/op Iteration 2: 2384214220.000 ns/op Iteration
[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup Iteration 1: 1830971983.333 ns/op # Warmup Iteration 2: 2188674760.000 ns/op # Warmup Iteration 3: 2181211500.000 ns/op # Warmup Iteration 4: 2349953100.000 ns/op # Warmup Iteration 5: 2360081080.000 ns/op Iteration 1: 2212511940.000 ns/op Iteration 2: 2384214220.000 ns/op Iteration 3: 2227561540.000 ns/op Iteration 4: 2312551740.000 ns/op Iteration 5: 2426368360.000 ns/op
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439860 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:46 Start Date: 02/Jun/20 02:46 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31174768) Coverage decreased (-0.008%) to 95.033% when pulling **28d71a13d15420eb268bd86bf3610433a9e9bf80 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439857 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:24 Start Date: 02/Jun/20 02:24 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31174768) Coverage decreased (-0.008%) to 95.033% when pulling **28d71a13d15420eb268bd86bf3610433a9e9bf80 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439857) Time Spent: 1h (was: 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CODEC-289) Base32/64Input/OutputStream to allow optional strict/lenient decoding
[
https://issues.apache.org/jira/browse/CODEC-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121448#comment-17121448
]
venkata ramana reddy L commented on CODEC-289:
--
[~aherbert] - When is the release of 1.15 planned?
> Base32/64Input/OutputStream to allow optional strict/lenient decoding
> -
>
> Key: CODEC-289
> URL: https://issues.apache.org/jira/browse/CODEC-289
> Project: Commons Codec
> Issue Type: Improvement
>Affects Versions: 1.14
>Reporter: Alex Herbert
>Assignee: Alex Herbert
>Priority: Major
> Fix For: 1.15
>
>
> Add the strict decoding option from the Base32/64 decoder to the
> Input/OutputStream versions.
> Requires adding a property to BaseNCodecInputStream and
> BaseNCodecOutputStream to pass through to the underlying decoder:
> {code:java}
> public void setStrictDecoding(boolean strictDecoding) {
>baseNCodec.setStrictDecoding(strictDecoding);
> }
> public boolean isStrictDecoding() {
>return baseNCodec.isStrictDecoding();
> }
> {code}
> This would allow Base32/64 Input/Output streams to use the strict decoding
> mode. Default behaviour would be lenient decoding for backward compatibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31173743) Coverage increased (+0.1%) to 89.845% when pulling **af88ba93e4850fa0abcf4fa7d239c8f5d017d1f7 on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439822 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 02/Jun/20 00:35 Start Date: 02/Jun/20 00:35 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31173743) Coverage increased (+0.1%) to 89.845% when pulling **af88ba93e4850fa0abcf4fa7d239c8f5d017d1f7 on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439822) Time Spent: 2h 40m (was: 2.5h) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Attachments: jmh-result.org.apache.json > > Time Spent: 2h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (BCEL-339) Throw IllegalArgumentException, IllegalStateException, UnsupportedOperationException instead of RuntimeException
[
https://issues.apache.org/jira/browse/BCEL-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved BCEL-339.
--
Fix Version/s: 6.5.0
Resolution: Fixed
> Throw IllegalArgumentException, IllegalStateException,
> UnsupportedOperationException instead of RuntimeException
>
>
> Key: BCEL-339
> URL: https://issues.apache.org/jira/browse/BCEL-339
> Project: Commons BCEL
> Issue Type: Bug
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 6.5.0
>
>
> Throw {{IllegalArgumentException}}, {{IllegalStateException}},
> {{UnsupportedOperationException}} instead of {{RuntimeException}}.
> Throwing {{RuntimeException}} is a code smell.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (BCEL-339) Throw IllegalArgumentException, IllegalStateException, UnsupportedOperationException instead of RuntimeException
Gary D. Gregory created BCEL-339:
Summary: Throw IllegalArgumentException, IllegalStateException,
UnsupportedOperationException instead of RuntimeException
Key: BCEL-339
URL: https://issues.apache.org/jira/browse/BCEL-339
Project: Commons BCEL
Issue Type: Bug
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Throw {{IllegalArgumentException}}, {{IllegalStateException}},
{{UnsupportedOperationException}} instead of {{RuntimeException}}.
Throwing {{RuntimeException}} is a code smell.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (BCEL-338) org.apache.bcel.generic.InstructionFactory.createInvoke() populates its internal ConstantPoolGen on bad input, then throws exception
[
https://issues.apache.org/jira/browse/BCEL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved BCEL-338.
--
Fix Version/s: 6.4.2
Resolution: Fixed
> org.apache.bcel.generic.InstructionFactory.createInvoke() populates its
> internal ConstantPoolGen on bad input, then throws exception
>
>
> Key: BCEL-338
> URL: https://issues.apache.org/jira/browse/BCEL-338
> Project: Commons BCEL
> Issue Type: Bug
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
> Fix For: 6.4.2
>
>
> The method {{org.apache.bcel.generic.InstructionFactory.createInvoke()}}
> populates its internal {{ConstantPoolGen}} on bad input, then throws
> exception.
> Instead it should validate its input first.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (BCEL-338) org.apache.bcel.generic.InstructionFactory.createInvoke() populates its internal ConstantPoolGen on bad input, then throws exception
Gary D. Gregory created BCEL-338:
Summary: org.apache.bcel.generic.InstructionFactory.createInvoke()
populates its internal ConstantPoolGen on bad input, then throws exception
Key: BCEL-338
URL: https://issues.apache.org/jira/browse/BCEL-338
Project: Commons BCEL
Issue Type: Bug
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
The method {{org.apache.bcel.generic.InstructionFactory.createInvoke()}}
populates its internal {{ConstantPoolGen}} on bad input, then throws exception.
Instead it should validate its input first.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] garydgregory merged pull request #40: add attribute name(s) to Code.toString()
garydgregory merged pull request #40: URL: https://github.com/apache/commons-bcel/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-514) SevenZFile fails with encoded header over 2GiB
[
https://issues.apache.org/jira/browse/COMPRESS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121361#comment-17121361
]
A Kelday commented on COMPRESS-514:
---
Thanks [~bodewig] and [~peterlee] for the input. Happy to work on it more at
some point if you choose an option (I'll keep thinking about it anyway and do
some more checks).
Peter explained my concern exactly: that in most cases given corrupt data, we
could expect an exception other than the one triggered by the CRC check to
happen _before_ the end of stream is ever reached (because we aren't just
transferring data, we're branching based on it). That's really a best case,
because worse than that is some garbage filename list being created. What I'm
very conscious of is making the common use case code worse.
> SevenZFile fails with encoded header over 2GiB
> --
>
> Key: COMPRESS-514
> URL: https://issues.apache.org/jira/browse/COMPRESS-514
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.20
>Reporter: A Kelday
>Priority: Minor
> Attachments: HeaderChannelBuffer.java
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When reading what some may call a large encrypted 7zip file (1.2TB with 22
> million files), the read fails at the header stage with the trace below. Is
> this within the spec? I've written some code to handle it, because I did
> actually need to extract the file in java. If that's of any use I can provide
> it (it's a naive wrapper that just pages in a buffer at a time).
>
> {code:java}
> Exception in thread "main" java.io.IOException: Cannot handle
> unpackSize241696
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.assertFitsIntoInt(SevenZFile.java:1523)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readEncodedHeader(SevenZFile.java:622)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.initializeArchive(SevenZFile.java:532)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readHeaders(SevenZFile.java:468)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:337)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:129)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:116)
> {code}
> 7zip itself can also open it (and display/extract etc.), here are the stats:
>
>
> {code:java}
> Size: 2 489 903 580 875
> Packed Size: 1 349 110 308 832
> Folders: 40 005
> Files: 22 073 957
> CRC: E26F6A96
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] garydgregory merged pull request #39: add support for invokestatic of an InterfaceMethodref
garydgregory merged pull request #39: URL: https://github.com/apache/commons-bcel/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637099087 @garydgregory If you look at java.io.InputStream source code - the default is to throw an exception when reset is called if mark is unsupported... so I am just following the defacto Java standard. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] adamretter edited a comment on pull request #119: Add a MarkShieldInputStream
adamretter edited a comment on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637099087 @garydgregory If you look at `java.io.InputStream` source code - the default is to throw an exception when reset is called if mark is unsupported... so I am just following the defacto Java standard. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream
garydgregory commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637090936 Yeah, this gets tricky and arbitrary: the class is called "MarkShield" which reimplements `mark()` as a noop but it also reimplements `reset()` to throw an `IOException`, which feels like a surprise to me (not in a good way.) Why should one method be a noop and the other throw an exception? It seems to be they both should be noops. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121314#comment-17121314
]
Robert Konior commented on LANG-1544:
-
Can I do this ? :)
> MethodUtils.invokeMethod NullPointerException in case of null in args list
> --
>
> Key: LANG-1544
> URL: https://issues.apache.org/jira/browse/LANG-1544
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.10
>Reporter: Peter Nagy
>Priority: Critical
>
> MethodUtils:774
>
> if (classArray[offset].equals(toClassArray[offset])) {
> continue;
> } else if (ClassUtils.isAssignable(classArray[offset], toClassArray[offset],
> true)
>
> cause NPE if classArray[offset] is null. Can you please extend the if
> condition with a null check, like this?
>
> if (classArray[offset] != null &&
> classArray[offset].equals(toClassArray[offset]))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.
[ https://issues.apache.org/jira/browse/LANG-1550?focusedWorklogId=439709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439709 ] ASF GitHub Bot logged work on LANG-1550: Author: ASF GitHub Bot Created on: 01/Jun/20 20:13 Start Date: 01/Jun/20 20:13 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #551: URL: https://github.com/apache/commons-lang/pull/551#issuecomment-637077665 [](https://coveralls.io/builds/31168883) Coverage decreased (-0.0006%) to 95.04% when pulling **2f8f5c22be3fb132eca951ed58505364021e7430 on nstdio:LANG-1550** into **115a6c64bc6dad12edaf3c5deaac7bffa0fa3b86 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439709) Time Spent: 20m (was: 10m) > Method ArrayUtils::isArrayIndexValid not optimized. > --- > > Key: LANG-1550 > URL: https://issues.apache.org/jira/browse/LANG-1550 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.8, 3.9, 3.10 >Reporter: Edgar Asatryan >Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > The *ArrayUtils::isArrayIndexValid* is can retrieve array length 2 times in > some cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #551: [LANG-1550] Optimize ArrayUtils::isArrayIndexValid method.
coveralls commented on pull request #551: URL: https://github.com/apache/commons-lang/pull/551#issuecomment-637077665 [](https://coveralls.io/builds/31168883) Coverage decreased (-0.0006%) to 95.04% when pulling **2f8f5c22be3fb132eca951ed58505364021e7430 on nstdio:LANG-1550** into **115a6c64bc6dad12edaf3c5deaac7bffa0fa3b86 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #74: Use license instead of licence
garydgregory merged pull request #74: URL: https://github.com/apache/commons-csv/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.
[ https://issues.apache.org/jira/browse/LANG-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121307#comment-17121307 ] Gary D. Gregory commented on LANG-1550: --- I do not understand; if you could demonstrate what you mean in a unit test PR on GitHub that would be best. > Method ArrayUtils::isArrayIndexValid not optimized. > --- > > Key: LANG-1550 > URL: https://issues.apache.org/jira/browse/LANG-1550 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.8, 3.9, 3.10 >Reporter: Edgar Asatryan >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The *ArrayUtils::isArrayIndexValid* is can retrieve array length 2 times in > some cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (CSV-195) Parser iterates over the last CSV Record twice.
[
https://issues.apache.org/jira/browse/CSV-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CSV-195.
-
Fix Version/s: (was: Patch Needed)
1.9
Resolution: Fixed
In git master, please verify and close.
> Parser iterates over the last CSV Record twice.
> ---
>
> Key: CSV-195
> URL: https://issues.apache.org/jira/browse/CSV-195
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.4
> Environment: Mac OS X 10.10.5
>Reporter: Rodolfo Duldulao
>Priority: Major
> Fix For: 1.9
>
> Attachments: whitelist.csv
>
>
> {code:java}
> class CSVParserSpecification extends Specification {
>def "TEst CSVParser"() {
> setup:
> URL url = new URL("https://../csv_with_28_lines_header_plus_
> 27_records");
> BufferedReader reader = new BufferedReader(new
> InputStreamReader(url.openStream()));
> def CSVParser parser =
> CSVFormat.RFC4180.withFirstRecordAsHeader().withIgnoreEmptyLines().withTrim().parse(reader);
> when:
> def count = 0
> for (CSVRecord record: parser)
> { println("Processing " + parser.getCurrentLineNumber()) count++ }
> println(count);
> parser.close()
> then:
> count == 27
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.
[ https://issues.apache.org/jira/browse/LANG-1550?focusedWorklogId=439701=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439701 ] ASF GitHub Bot logged work on LANG-1550: Author: ASF GitHub Bot Created on: 01/Jun/20 19:58 Start Date: 01/Jun/20 19:58 Worklog Time Spent: 10m Work Description: nstdio opened a new pull request #551: URL: https://github.com/apache/commons-lang/pull/551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439701) Remaining Estimate: 0h Time Spent: 10m > Method ArrayUtils::isArrayIndexValid not optimized. > --- > > Key: LANG-1550 > URL: https://issues.apache.org/jira/browse/LANG-1550 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.8, 3.9, 3.10 >Reporter: Edgar Asatryan >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The *ArrayUtils::isArrayIndexValid* is can retrieve array length 2 times in > some cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] nstdio opened a new pull request #551: [LANG-1550] Optimize ArrayUtils::isArrayIndexValid method.
nstdio opened a new pull request #551: URL: https://github.com/apache/commons-lang/pull/551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (CSV-149) Line number is not proper at EOF
[ https://issues.apache.org/jira/browse/CSV-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CSV-149. - Fix Version/s: (was: Patch Needed) 1.9 Resolution: Fixed In git master, please verify and close. > Line number is not proper at EOF > > > Key: CSV-149 > URL: https://issues.apache.org/jira/browse/CSV-149 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.1 > Environment: CSV 1.1, Java 1.6, Windows OS >Reporter: Kranthi >Priority: Major > Fix For: 1.9 > > Attachments: csv-145-unit-test.diff > > Time Spent: 2h 50m > Remaining Estimate: 0h > > CSVParser.getCurrentLineNumber() is returning wrong line number (actual line > number - 1) when EOF file is reached without record delimiter (\r\n). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (CSV-149) Line number is not proper at EOF
[ https://issues.apache.org/jira/browse/CSV-149?focusedWorklogId=439699=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439699 ] ASF GitHub Bot logged work on CSV-149: -- Author: ASF GitHub Bot Created on: 01/Jun/20 19:53 Start Date: 01/Jun/20 19:53 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #60: URL: https://github.com/apache/commons-csv/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439699) Time Spent: 2h 50m (was: 2h 40m) > Line number is not proper at EOF > > > Key: CSV-149 > URL: https://issues.apache.org/jira/browse/CSV-149 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.1 > Environment: CSV 1.1, Java 1.6, Windows OS >Reporter: Kranthi >Priority: Major > Fix For: Patch Needed > > Attachments: csv-145-unit-test.diff > > Time Spent: 2h 50m > Remaining Estimate: 0h > > CSVParser.getCurrentLineNumber() is returning wrong line number (actual line > number - 1) when EOF file is reached without record delimiter (\r\n). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-csv] garydgregory merged pull request #60: Fix CSV-149 and CSV-195
garydgregory merged pull request #60: URL: https://github.com/apache/commons-csv/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.
Edgar Asatryan created LANG-1550: Summary: Method ArrayUtils::isArrayIndexValid not optimized. Key: LANG-1550 URL: https://issues.apache.org/jira/browse/LANG-1550 Project: Commons Lang Issue Type: Improvement Components: lang.* Affects Versions: 3.10, 3.9, 3.8 Reporter: Edgar Asatryan The *ArrayUtils::isArrayIndexValid* is can retrieve array length 2 times in some cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439695=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439695 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 19:35 Start Date: 01/Jun/20 19:35 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31168325) Coverage increased (+0.1%) to 89.845% when pulling **fda006373b701538f73f109abaa33ab9e67d81fe on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439695) Time Spent: 2.5h (was: 2h 20m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Attachments: jmh-result.org.apache.json > > Time Spent: 2.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31168325) Coverage increased (+0.1%) to 89.845% when pulling **fda006373b701538f73f109abaa33ab9e67d81fe on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] changbaishan commented on pull request #50: Need *.webp type images reader and writer
changbaishan commented on pull request #50: URL: https://github.com/apache/commons-imaging/pull/50#issuecomment-637058596 Is there way I can release myself from this PR? I witnessed wonderful works you did. However, I opened it just to suggest a useful feature. I had no idea of what it actually meant. I still love your software. Just don't want to prolong a mistake. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] changbaishan closed pull request #50: Need *.webp type images reader and writer
changbaishan closed pull request #50: URL: https://github.com/apache/commons-imaging/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JIN XU updated IO-670: -- Attachment: jmh-result.org.apache.json > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Attachments: jmh-result.org.apache.json > > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439679=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439679 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 18:59 Start Date: 01/Jun/20 18:59 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31167650) Coverage increased (+0.05%) to 89.766% when pulling **a376dd50d6d3d611d51fc764de318587b2434c0b on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439679) Time Spent: 2h 20m (was: 2h 10m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31167650) Coverage increased (+0.05%) to 89.766% when pulling **a376dd50d6d3d611d51fc764de318587b2434c0b on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439677=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439677 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 18:52 Start Date: 01/Jun/20 18:52 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only experiences using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. update: I learned how to use it, thanks for your recommendation. also, need I create more tests for testing wether this function is correct? or tests that already exist, which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439677) Time Spent: 2h 10m (was: 2h) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only experiences using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. update: I learned how to use it, thanks for your recommendation. also, need I create more tests for testing wether this function is correct? or tests that already exist, which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439676=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439676 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 18:52 Start Date: 01/Jun/20 18:52 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only experiences using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. update: I learned how to use it, thanks for your recommendation. also, need I create more tests for testing wether this function is correct? or tests that already exist ,which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439676) Time Spent: 2h (was: 1h 50m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only experiences using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. update: I learned how to use it, thanks for your recommendation. also, need I create more tests for testing wether this function is correct? or tests that already exist ,which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-637036540
result json:
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.io.performance.IOUtilsContentEqualsPerformanceTest.testContentEqualsForFileNew",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 7934046.779660092,
"scoreError" : 644395.8679898068,
"scoreConfidence" : [
7289650.911670285,
8578442.6476499
],
"scorePercentiles" : {
"0.0" : 7241780.811006517,
"50.0" : 7517702.629601804,
"90.0" : 9152312.968421623,
"95.0" : 1.0373390719340876E7,
"99.0" : 1.0726891103965702E7,
"99.9" : 1.0726891103965702E7,
"99.99" : 1.0726891103965702E7,
"99.999" : 1.0726891103965702E7,
"99." : 1.0726891103965702E7,
"100.0" : 1.0726891103965702E7
},
"scoreUnit" : "ns/op",
"rawData" : [
[
7459707.30797912,
8792593.848857645,
1.0726891103965702E7,
8550254.786324786,
8001410.311750599
],
[
7347818.649045521,
7251497.463768116,
7366967.231222386,
7420473.516320474,
7517702.629601804
],
[
7387172.525849335,
7278674.4,
7307894.88677867,
7363340.103016924,
7241780.811006517
],
[
7868122.955974842,
8014526.602564103,
7610742.99847793,
7339908.804108584,
7466605.9701492535
],
[
7641931.603053435,
8134969.268292683,
8823474.603174603,
9548556.488549618,
150.621669628
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.io.performance.IOUtilsContentEqualsPerformanceTest.testContentEqualsNew2",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 3.4456759445822275E8,
"scoreError" : 2.110473359059532E7,
"scoreConfidence" : [
3.2346286086762744E8,
3.6567232804881805E8
],
"scorePercentiles" : {
"0.0" : 3.183939625E8,
"50.0" : 3.3247121612903225E8,
"90.0" : 4.0086423015384614E8,
"95.0" : 4.1518499175E8,
"99.0" : 4.172705625E8,
"99.9" : 4.172705625E8,
"99.99" : 4.172705625E8,
"99.999" : 4.172705625E8,
"99." : 4.172705625E8,
"100.0" : 4.172705625E8
},
"scoreUnit" : "ns/op",
"rawData" : [
[
3.725598037037037E8,
3.7222124E8,
3.945612769230769E8,
4.1031866E8,
4.172705625E8
],
[
3.3457967E8,
3.24313664516129E8,
3.4986420344827586E8,
3.450001724137931E8,
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439674=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439674
]
ASF GitHub Bot logged work on IO-670:
-
Author: ASF GitHub Bot
Created on: 01/Jun/20 18:42
Start Date: 01/Jun/20 18:42
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-637036540
result json:
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.io.performance.IOUtilsContentEqualsPerformanceTest.testContentEqualsForFileNew",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 7934046.779660092,
"scoreError" : 644395.8679898068,
"scoreConfidence" : [
7289650.911670285,
8578442.6476499
],
"scorePercentiles" : {
"0.0" : 7241780.811006517,
"50.0" : 7517702.629601804,
"90.0" : 9152312.968421623,
"95.0" : 1.0373390719340876E7,
"99.0" : 1.0726891103965702E7,
"99.9" : 1.0726891103965702E7,
"99.99" : 1.0726891103965702E7,
"99.999" : 1.0726891103965702E7,
"99." : 1.0726891103965702E7,
"100.0" : 1.0726891103965702E7
},
"scoreUnit" : "ns/op",
"rawData" : [
[
7459707.30797912,
8792593.848857645,
1.0726891103965702E7,
8550254.786324786,
8001410.311750599
],
[
7347818.649045521,
7251497.463768116,
7366967.231222386,
7420473.516320474,
7517702.629601804
],
[
7387172.525849335,
7278674.4,
7307894.88677867,
7363340.103016924,
7241780.811006517
],
[
7868122.955974842,
8014526.602564103,
7610742.99847793,
7339908.804108584,
7466605.9701492535
],
[
7641931.603053435,
8134969.268292683,
8823474.603174603,
9548556.488549618,
150.621669628
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.io.performance.IOUtilsContentEqualsPerformanceTest.testContentEqualsNew2",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 3.4456759445822275E8,
"scoreError" : 2.110473359059532E7,
"scoreConfidence" : [
3.2346286086762744E8,
3.6567232804881805E8
],
"scorePercentiles" : {
"0.0" : 3.183939625E8,
"50.0" : 3.3247121612903225E8,
"90.0" : 4.0086423015384614E8,
"95.0" : 4.1518499175E8,
"99.0" : 4.172705625E8,
"99.9" : 4.172705625E8,
"99.99" : 4.172705625E8,
"99.999" : 4.172705625E8,
"99." : 4.172705625E8,
"100.0" : 4.172705625E8
},
"scoreUnit" : "ns/op",
"rawData" : [
[
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439672=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439672 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 18:41 Start Date: 01/Jun/20 18:41 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclution:** In cases for small content readers, the new function is slightly faster. but in cases for large content, the new function can be 6.5 times faster. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclution:** In cases for small content readers, the new function is slightly faster. but in cases for large content, the new function can be 6.5 times faster. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO]
[GitHub] [commons-beanutils] fborriello closed pull request #20: [BEANUTILS-524] Copy properties improvement
fborriello closed pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] fborriello commented on pull request #20: [BEANUTILS-524] Copy properties improvement
fborriello commented on pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20#issuecomment-637014234 Yes, I agree This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439634=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439634 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 17:53 Start Date: 01/Jun/20 17:53 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637013520 @garydgregory BTW, how can I show the performance result generated? simply paste it here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439634) Time Spent: 1.5h (was: 1h 20m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637013520 @garydgregory BTW, how can I show the performance result generated? simply paste it here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #20: [BEANUTILS-524] Copy properties improvement
melloware commented on pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20#issuecomment-636997754 @fborriello I think this PR can be closed as it is not going to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439615 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 17:18 Start Date: 01/Jun/20 17:18 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636996577 @garydgregory I will use this as example and change its content and add the test into this repo if you don't mind. https://github.com/apache/commons-lang/blob/5cdac9cfd5a74b0a52ebde32798b973c6edbaa79/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439615) Time Spent: 1h 20m (was: 1h 10m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636996577 @garydgregory I will use this as example and change its content and add the test into this repo if you don't mind. https://github.com/apache/commons-lang/blob/5cdac9cfd5a74b0a52ebde32798b973c6edbaa79/src/test/java/org/apache/commons/lang3/HashSetvBitSetTest.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439613 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 17:16 Start Date: 01/Jun/20 17:16 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only performance using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. also, need I create more tests for testing wether this function is correct? or tests that already exist ,which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439613) Time Spent: 1h 10m (was: 1h) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only performance using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. also, need I create more tests for testing wether this function is correct? or tests that already exist ,which for the older function, is good enough and I need not create more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #119: Add a MarkShieldInputStream
coveralls commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636994860 [](https://coveralls.io/builds/31165252) Coverage increased (+0.07%) to 89.791% when pulling **dc199b473acc6766dcad769ad267ec0eb627e61c on adamretter:feature/mark-shield-input-stream** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439612 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 17:13 Start Date: 01/Jun/20 17:13 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only performance using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439612) Time Spent: 1h (was: 50m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only performance using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream
garydgregory commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636991133 We work hard to avoid breaking binary compatibility. Instead, we mark code as deprecated and that code can then be considered for removal for the next major version, which would include a package name change along with a matching Maven coordinate change. Let me poke around later... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
garydgregory commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636989562 @XenoAmess - When you create a PR, please do not leave the description empty. It makes it harder to review. - If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439600=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439600 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 17:06 Start Date: 01/Jun/20 17:06 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636989562 @XenoAmess - When you create a PR, please do not leave the description empty. It makes it harder to review. - If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439600) Time Spent: 50m (was: 40m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] adamretter edited a comment on pull request #119: Add a MarkShieldInputStream
adamretter edited a comment on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636984631 @garydgregory Hmm I had not thought of that. Personally I prefer to have the separate classes... but I can refactor it if that's what is needed? What would happen to the existing `CloseShieldInputStream`? Would it just be removed? I think that could break a lot of existing code! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636984631 @garydgregory Hmm I had not thought of that. Personally I prefer to have the separate classes... but I can refactor it if that's what is needed? What would happen to the existing `CloseShieldInputStream`? Would it just be removed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream
garydgregory commented on pull request #119:
URL: https://github.com/apache/commons-io/pull/119#issuecomment-636981406
Before we need one more and one more shield types of ProxyInputStreams,
shouldn't we consider a more general shield class that takes an enum {CLOSE,
MARK, THIS, THAT} so we can just have a single one?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439599=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439599 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 16:48 Start Date: 01/Jun/20 16:48 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31164655) Coverage decreased (-0.001%) to 89.718% when pulling **73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439599) Time Spent: 40m (was: 0.5h) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
coveralls commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [](https://coveralls.io/builds/31164655) Coverage decreased (-0.001%) to 89.718% when pulling **73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 on XenoAmess:refine_contentEquals** into **cd7787277b170d5f439df03850ca0c574566e539 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] adamretter opened a new pull request #119: Add a MarkShieldInputStream
adamretter opened a new pull request #119: URL: https://github.com/apache/commons-io/pull/119 This is similar to the `CloseShieldInputStream` but it focuses on the mark, markSupported, and reset methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439594=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439594 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 16:36 Start Date: 01/Jun/20 16:36 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636974841 I also want to change other contentEquals functions in IOUtils (using similar way), but I want to listen to your advices first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439594) Time Spent: 0.5h (was: 20m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636974841 I also want to change other contentEquals functions in IOUtils (using similar way), but I want to listen to your advices first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439590 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 16:30 Start Date: 01/Jun/20 16:30 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test case to show the performance? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439590) Time Spent: 20m (was: 10m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JIN XU updated IO-670: -- Description: [https://github.com/apache/commons-io/pull/118] > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439589 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 01/Jun/20 16:30 Start Date: 01/Jun/20 16:30 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439589) Remaining Estimate: 0h Time Spent: 10m > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test case to show the performance? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] XenoAmess opened a new pull request #118: refine IOUtils.contentEquals(Reader, Reader)
XenoAmess opened a new pull request #118: URL: https://github.com/apache/commons-io/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439585 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 01/Jun/20 16:15 Start Date: 01/Jun/20 16:15 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439585) Time Spent: 50m (was: 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to 72 Hour Lazy Consensus rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439584 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 01/Jun/20 16:15 Start Date: 01/Jun/20 16:15 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to 72 Hour Lazy Consensus rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439584) Time Spent: 40m (was: 0.5h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1549) implement TODO in CharSequenceUtils.lastIndexOf : remake it.
[ https://issues.apache.org/jira/browse/LANG-1549?focusedWorklogId=439583=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439583 ] ASF GitHub Bot logged work on LANG-1549: Author: ASF GitHub Bot Created on: 01/Jun/20 16:14 Start Date: 01/Jun/20 16:14 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #535: URL: https://github.com/apache/commons-lang/pull/535#issuecomment-636958642 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means the same functin in indexOf. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439583) Time Spent: 40m (was: 0.5h) > implement TODO in CharSequenceUtils.lastIndexOf : remake it. > > > Key: LANG-1549 > URL: https://issues.apache.org/jira/browse/LANG-1549 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/535] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #535: [LANG-1549] implement TODO in CharSequenceUtils.lastIndexOf : remake it.
XenoAmess commented on pull request #535: URL: https://github.com/apache/commons-lang/pull/535#issuecomment-636958642 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means the same functin in indexOf. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CODEC-280) Base32/64 to allow optional strict/lenient decoding
[
https://issues.apache.org/jira/browse/CODEC-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121119#comment-17121119
]
Valery Tydykov commented on CODEC-280:
--
When version 1.15 will be released?
> Base32/64 to allow optional strict/lenient decoding
> ---
>
> Key: CODEC-280
> URL: https://issues.apache.org/jira/browse/CODEC-280
> Project: Commons Codec
> Issue Type: Improvement
>Affects Versions: 1.14
>Reporter: Alex Herbert
>Assignee: Alex Herbert
>Priority: Minor
> Fix For: 1.15
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Base32 decodes blocks of 8 characters.
> Base64 decodes blocks of 4 characters.
> At the end of decoding some extra characters may be left. They are decoded
> using the appropriate bits. The bits that do not sum to form a byte (i.e.
> less than 8 bits) are discarded.
> Currently if there are more than 8 bits left then the available bytes are
> extracted and the left over bits are validated to check they are zeros. If
> they are not zeros then an exception is raised. This functionality was added
> to ensure that a byte array that is decoded will be re-encoded to the exact
> same byte array (ignoring input padding).
> There are two issues:
> # If the leftover bits are less than 8 then no attempt can be made to obtain
> the last bytes. However an exception is not raised indicating that the
> encoding was invalid (no left-over bits should be unaccounted for).
> # This raising of exceptions for leftover bits is causing reports from users
> that codec is not working as it used to. This is true but only because the
> user has some badly encoded bytes they want to decode. Since other libraries
> allow this then it seems that two options for decoding are required.
> I suggest fixing the encoding so that it operates in two modes: strict and
> lenient.
> * Strict will throw an exception whenever there are unaccounted for bits.
> * Lenient will just discard the extra bits that cannot be used.
> Lenient is the default for backward compatibility restoring functionality of
> the class to versions prior to 1.13.
> Strict is enabled using a method:
> {code:java}
> Base64 codec = new Base64();
> byte[] bytes = new byte{ 'E' };
> Assertions.assertArrayEquals(new byte[0] () -> codec.decode(bytes));
> codec.setStrictDecoding(true);
> Assertions.assertThrows(IllegalArgumentException.class, () -> codec.decode());
> {code}
> Using strict encoding should ensure that a round trip returns the same bytes:
> {code:java}
> byte[] bytes = ...; // Some valid encoding with no padding characters
> Base64 codec = new Base64();
> codec.setStrictDecoding(true);
> Assertions.assertArrayEquals(bytes, codec.encode(codec.decode(bytes)));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
JIN XU created IO-670: - Summary: IOUtils.contentEquals is of low performance. I will refine it. Key: IO-670 URL: https://issues.apache.org/jira/browse/IO-670 Project: Commons IO Issue Type: Improvement Reporter: JIN XU -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1542) ToStringBuilder.reflectionToString - Wrong JSON format when object has a List of Enum
[
https://issues.apache.org/jira/browse/LANG-1542?focusedWorklogId=439545=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439545
]
ASF GitHub Bot logged work on LANG-1542:
Author: ASF GitHub Bot
Created on: 01/Jun/20 14:05
Start Date: 01/Jun/20 14:05
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #530:
URL: https://github.com/apache/commons-lang/pull/530#issuecomment-629603951
[](https://coveralls.io/builds/31160874)
Coverage increased (+0.001%) to 95.042% when pulling
**540dcf0ea0b52bbf62bfff1ab0474afff0494901 on TranNgocKhoa:master** into
**115a6c64bc6dad12edaf3c5deaac7bffa0fa3b86 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 439545)
Time Spent: 3h (was: 2h 50m)
> ToStringBuilder.reflectionToString - Wrong JSON format when object has a List
> of Enum
> -
>
> Key: LANG-1542
> URL: https://issues.apache.org/jira/browse/LANG-1542
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
>Affects Versions: 3.10
> Environment: Open JDK 1.8
>Reporter: Trần Ngọc Khoa
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> I'm trying to log an object to console with JSON style using
> {{ToStringBuilder.reflectionToString}} from {{commons-lang3:3.10}} but it
> seems generated a wrong JSON format.
> Problem happening when I have a list of enums in my field list.
>
> {code:java}
> This is the class:
> public class Person {
> private long id;
> private String name;
> private List listEnums;
> //getter and setter
> public String toString(){
> return ToStringBuilder.reflectionToString(this,
> ToStringStyle.JSON_STYLE);
> }
> }
> {code}
>
> And {{MyEnum}}:
> {code:java}
> public enum MyEnum {
> FOOD,
> SPORT,
> BOOK,
> MUSIC
> }{code}
> When I call {{toString()}} of Person object. It shows like this
> {code:java}
> {
> "id": 1,
> "name": "Karl",
> "listEnums": [FRIDAY, MONDAY, TUESDAY]
> }{code}
>
> What I expected is:
> {code:java}
> {
> "id": 1,
> "name": "Karl",
> "listEnums": ["FRIDAY", "MONDAY", "TUESDAY"]
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #530: LANG-1542: ToStringBuilder.reflectionToString - Wrong JSON format for List
coveralls edited a comment on pull request #530: URL: https://github.com/apache/commons-lang/pull/530#issuecomment-629603951 [](https://coveralls.io/builds/31160874) Coverage increased (+0.001%) to 95.042% when pulling **540dcf0ea0b52bbf62bfff1ab0474afff0494901 on TranNgocKhoa:master** into **115a6c64bc6dad12edaf3c5deaac7bffa0fa3b86 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
