[GitHub] [commons-fileupload] jGauravGupta commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition
jGauravGupta commented on pull request #25: URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-639263436 Thanks @jochenw for adding the Jakarta Servlet support, I will check with Woodstock build and create the issue here, if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jGauravGupta closed pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition
jGauravGupta closed pull request #25: URL: https://github.com/apache/commons-fileupload/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.
coveralls edited a comment on pull request #159: URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511 [](https://coveralls.io/builds/31254268) Coverage decreased (-0.004%) to 90.119% when pulling **90b23d9e10a445efafa4cc61504f1e00901883c7 on dota17:junit5WithExceptions** into **de4b95a7c8f3b78174b7eccd1d6249c812695eea on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441627
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 01:39
Start Date: 05/Jun/20 01:39
Worklog Time Spent: 10m
Work Description: dota17 commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435644787
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
while (tmpLen -- > 0) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441627)
Time Spent: 2h 10m (was: 2h)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] dota17 commented on a change in pull request #534: [LANG-1548] split regionMatches for better performance
dota17 commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435644787
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
while (tmpLen -- > 0) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #110: use System.currentTimeMillis instead of new Date().getTime
PeterAlfredLee commented on pull request #110: URL: https://github.com/apache/commons-compress/pull/110#issuecomment-639205673 LGTM. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #110: use System.currentTimeMillis instead of new Date().getTime
PeterAlfredLee merged pull request #110: URL: https://github.com/apache/commons-compress/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #111: remove unused imports.
PeterAlfredLee merged pull request #111: URL: https://github.com/apache/commons-compress/pull/111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #112: remove `== null` as it is covered by `instance of`
PeterAlfredLee commented on pull request #112: URL: https://github.com/apache/commons-compress/pull/112#issuecomment-639204455 Not sure if this is caused by Sonarqube or some other scans. From my view the null check is not needed here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #111: remove unused imports.
PeterAlfredLee commented on pull request #111: URL: https://github.com/apache/commons-compress/pull/111#issuecomment-639203451 Thank you @XenoAmess. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #109: unitized array styles.
PeterAlfredLee merged pull request #109: URL: https://github.com/apache/commons-compress/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #109: unitized array styles.
PeterAlfredLee commented on pull request #109: URL: https://github.com/apache/commons-compress/pull/109#issuecomment-639203050 LGTM, and thank you. @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] ebourg closed pull request #26: Create Jakarta classifier distribution
ebourg closed pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] coveralls commented on pull request #142: use subList().clear instead of a loop of remove(0)
coveralls commented on pull request #142: URL: https://github.com/apache/commons-math/pull/142#issuecomment-639113152 [](https://coveralls.io/builds/31248052) Coverage remained the same at 90.56% when pulling **5603fb701bf83c49ff2096b99674a738d36319aa on XenoAmess:use_subList().clear** into **715d89d2625b09915feb1dd1b60270842eeffb7a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition
jochenw commented on pull request #25: URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-639102893 @jGauravGupta As a housekeeping issue, please be so kind to close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #26: Create Jakarta classifier distribution
jochenw commented on pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26#issuecomment-639102287 @jGauravGupta From your PR 1407 on eclipse-ee4j/glassfish-woodstock, I deduce that you do consider the topic closed. So, please be so kind to close this PR as well, as I haven't got the necessary permissions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] coveralls commented on pull request #141: use addAll instead of loop.
coveralls commented on pull request #141: URL: https://github.com/apache/commons-math/pull/141#issuecomment-639098866 [](https://coveralls.io/builds/31247451) Coverage increased (+0.0009%) to 90.561% when pulling **8772cb907e206400a1f5b8c2be8c7e12e5e53261 on XenoAmess:use_addAll_instead_of_loop** into **715d89d2625b09915feb1dd1b60270842eeffb7a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #143: use System.arraycopy
XenoAmess opened a new pull request #143: URL: https://github.com/apache/commons-math/pull/143 use System.arraycopy instead of loop. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #142: use subList().clear instead of a loop of remove(0)
XenoAmess opened a new pull request #142: URL: https://github.com/apache/commons-math/pull/142 use subList().clear instead of a loop of remove(0) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #141: use addAll instead of loop.
XenoAmess opened a new pull request #141: URL: https://github.com/apache/commons-math/pull/141 use addAll instead of loop for list (especially ArrayList, as it use System.ArrayCopy internally, thus might improve performance) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #112: remove `== null` as it is covered by `instance of`
coveralls commented on pull request #112: URL: https://github.com/apache/commons-compress/pull/112#issuecomment-639086451 [](https://coveralls.io/builds/31246999) Coverage remained the same at 87.29% when pulling **183816382a376ed22f37204eec6caaa5622a100b on XenoAmess:remove_`==_null`_as_it_is_covered_by_`instance_of`** into **18fb261d08cc52483267213e0d2ef4c43de7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #111: remove unused imports.
coveralls commented on pull request #111: URL: https://github.com/apache/commons-compress/pull/111#issuecomment-639085728 [](https://coveralls.io/builds/31246967) Coverage remained the same at 87.29% when pulling **932fbdbfaf1604e24d2f95028e187c8eea23a7f7 on XenoAmess:remove_unused_imports** into **18fb261d08cc52483267213e0d2ef4c43de7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #109: unitized array styles.
coveralls commented on pull request #109: URL: https://github.com/apache/commons-compress/pull/109#issuecomment-639084825 [](https://coveralls.io/builds/31246931) Coverage increased (+0.02%) to 87.311% when pulling **774f6b41a46fd7ddd2196687115569729646a67a on XenoAmess:array_style** into **18fb261d08cc52483267213e0d2ef4c43de7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #110: use System.currentTimeMillis instead of new Date().getTime
coveralls commented on pull request #110: URL: https://github.com/apache/commons-compress/pull/110#issuecomment-639085299 [](https://coveralls.io/builds/31246959) Coverage increased (+0.04%) to 87.333% when pulling **1cdf4eda2273473a9e046d0f0f9e3a984fedb63a on XenoAmess:use_System_currentTimeMillis_insteadof_Date_getTime** into **18fb261d08cc52483267213e0d2ef4c43de7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess opened a new pull request #112: remove `== null` as it is covered by `instance of`
XenoAmess opened a new pull request #112: URL: https://github.com/apache/commons-compress/pull/112 Or, is it for special optimization strategy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess opened a new pull request #110: use System.currentTimeMillis instead of new Date().getTime
XenoAmess opened a new pull request #110: URL: https://github.com/apache/commons-compress/pull/110 to avoid Date() object creation thus faster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess opened a new pull request #111: remove unused imports.
XenoAmess opened a new pull request #111: URL: https://github.com/apache/commons-compress/pull/111 remove unused imports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess opened a new pull request #109: unitized array styles.
XenoAmess opened a new pull request #109: URL: https://github.com/apache/commons-compress/pull/109 from both `byte a[]` and `byte[] a` to only `byte[] a` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (POOL-385) Java Modularity Automatic-Module
[ https://issues.apache.org/jira/browse/POOL-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Scholz updated POOL-385: - Comment: was deleted (was: Added in commit [5906b78|[https://github.com/apache/commons-pool/commit/5906b788172d3305a92a920923b0673397b60f98]]) > Java Modularity Automatic-Module > > > Key: POOL-385 > URL: https://issues.apache.org/jira/browse/POOL-385 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Paul Scholz >Priority: Minor > Labels: newbie, pull-request-available > > Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. > This makes discovering this library on Module-Path much more standardized. > Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (POOL-385) Java Modularity Automatic-Module
[ https://issues.apache.org/jira/browse/POOL-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Scholz resolved POOL-385. -- Fix Version/s: 2.8.1 Resolution: Fixed Added in commit [5906b78|[https://github.com/apache/commons-pool/commit/5906b788172d3305a92a920923b0673397b60f98]] > Java Modularity Automatic-Module > > > Key: POOL-385 > URL: https://issues.apache.org/jira/browse/POOL-385 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Paul Scholz >Priority: Minor > Labels: newbie, pull-request-available > Fix For: 2.8.1 > > > Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. > This makes discovering this library on Module-Path much more standardized. > Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (POOL-385) Java Modularity Automatic-Module
[ https://issues.apache.org/jira/browse/POOL-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126136#comment-17126136 ] Paul Scholz commented on POOL-385: -- Added in commit [5906b78|[https://github.com/apache/commons-pool/commit/5906b788172d3305a92a920923b0673397b60f98]] > Java Modularity Automatic-Module > > > Key: POOL-385 > URL: https://issues.apache.org/jira/browse/POOL-385 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Paul Scholz >Priority: Minor > Labels: newbie, pull-request-available > > Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. > This makes discovering this library on Module-Path much more standardized. > Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-pool] garydgregory merged pull request #31: Added Automatic-Module-Name to support JPMS
garydgregory merged pull request #31: URL: https://github.com/apache/commons-pool/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] coveralls edited a comment on pull request #31: Added Automatic-Module-Name to support JPMS
coveralls edited a comment on pull request #31: URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638776466 [](https://coveralls.io/builds/31242761) Coverage increased (+0.2%) to 84.246% when pulling **99f921eff44b0bdadcd16b46d40d4dd384cb25ac on scholzi100:POOL-385-Automatic-Module** into **45683c848a241026a9ad04fb5e2494e954593b6a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (VALIDATOR-458) commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the latest one
[ https://issues.apache.org/jira/browse/VALIDATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126046#comment-17126046 ] Lonzak edited comment on VALIDATOR-458 at 6/4/20, 4:16 PM: --- This issue is a duplicate of 437 and fixed in Version 1.7 - maybe some admin can add the target version... [https://github.com/apache/commons-validator/commit/f19a37156f9a3e48439eaa0a1f7ccd4da096694a#diff-600376dffeb79835ede4a0b285078036] was (Author: tom_1st): This issue is a duplicate of 473 and fixed in Version 1.7 - maybe some admin can add the target version... [https://github.com/apache/commons-validator/commit/f19a37156f9a3e48439eaa0a1f7ccd4da096694a#diff-600376dffeb79835ede4a0b285078036] > commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the > latest one > -- > > Key: VALIDATOR-458 > URL: https://issues.apache.org/jira/browse/VALIDATOR-458 > Project: Commons Validator > Issue Type: Bug >Reporter: Shubhankar Singh >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VALIDATOR-458) commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the latest one
[ https://issues.apache.org/jira/browse/VALIDATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126046#comment-17126046 ] Lonzak commented on VALIDATOR-458: -- This issue is fixed in Version 1.7 - maybe some admin can add the target version... https://github.com/apache/commons-validator/commit/f19a37156f9a3e48439eaa0a1f7ccd4da096694a#diff-600376dffeb79835ede4a0b285078036 > commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the > latest one > -- > > Key: VALIDATOR-458 > URL: https://issues.apache.org/jira/browse/VALIDATOR-458 > Project: Commons Validator > Issue Type: Bug >Reporter: Shubhankar Singh >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (VALIDATOR-458) commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the latest one
[ https://issues.apache.org/jira/browse/VALIDATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126046#comment-17126046 ] Lonzak edited comment on VALIDATOR-458 at 6/4/20, 4:15 PM: --- This issue is a duplicate of 473 and fixed in Version 1.7 - maybe some admin can add the target version... [https://github.com/apache/commons-validator/commit/f19a37156f9a3e48439eaa0a1f7ccd4da096694a#diff-600376dffeb79835ede4a0b285078036] was (Author: tom_1st): This issue is fixed in Version 1.7 - maybe some admin can add the target version... https://github.com/apache/commons-validator/commit/f19a37156f9a3e48439eaa0a1f7ccd4da096694a#diff-600376dffeb79835ede4a0b285078036 > commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the > latest one > -- > > Key: VALIDATOR-458 > URL: https://issues.apache.org/jira/browse/VALIDATOR-458 > Project: Commons Validator > Issue Type: Bug >Reporter: Shubhankar Singh >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CLI-285) Multiple Options in Option Group
[
https://issues.apache.org/jira/browse/CLI-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126043#comment-17126043
]
Alexander Schäl commented on CLI-285:
-
My application can work in two different modes {{migrate}} and {{repair}},
which can be selected via the command line option {{--function}}.
Depending on the selected function, two _different_ groups of mandatory and
optional parameters should be used.
Expressed in the above notation, for example
{noformat}
[--function migrate --source --target [--legacy]]|[--function
repair --system [--startDate ]] {noformat}
The {{parse}} method should recognize wrong usage and the {{printHelp}} method
should visualize these combinations in a reasonable way.
_Please_ reactivate this old issue :D
> Multiple Options in Option Group
>
>
> Key: CLI-285
> URL: https://issues.apache.org/jira/browse/CLI-285
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
>Reporter: Richard Kao
>Priority: Major
>
> Allow the creation of multiple Options with in an OptionGroup so something
> like the following can be created:
> [ -a ] [ [ -b ] [ -c ] | [ -d ] | [ -e ]]
> So these would be valid:
> -b
> -c
> -b -c
> -d
> -e
> The "-d", "-e", and "-b -c" are mutually exclusive
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=441348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441348 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot Created on: 04/Jun/20 15:40 Start Date: 04/Jun/20 15:40 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #140: URL: https://github.com/apache/commons-math/pull/140#issuecomment-638931888 [](https://coveralls.io/builds/31240985) Coverage remained the same at 90.56% when pulling **6af45f83ce35b61ce6c9beaa23daa217f17ea811 on XenoAmess:clean_up_in_tests** into **715d89d2625b09915feb1dd1b60270842eeffb7a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441348) Time Spent: 2h 10m (was: 2h) > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] coveralls commented on pull request #140: [MATH-1537] clean-up a test
coveralls commented on pull request #140: URL: https://github.com/apache/commons-math/pull/140#issuecomment-638931888 [](https://coveralls.io/builds/31240985) Coverage remained the same at 90.56% when pulling **6af45f83ce35b61ce6c9beaa23daa217f17ea811 on XenoAmess:clean_up_in_tests** into **715d89d2625b09915feb1dd1b60270842eeffb7a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #108: Performance test for BZip2CompressorOutputStream
coveralls commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638920815 [](https://coveralls.io/builds/31240573) Coverage increased (+0.03%) to 87.318% when pulling **f9c16797a3bbb246ab3e6f04d725073c7052c94b on XenoAmess:performance_test_for_bzip** into **18fb261d08cc52483267213e0d2ef4c43de7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=441333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441333 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot Created on: 04/Jun/20 15:12 Start Date: 04/Jun/20 15:12 Worklog Time Spent: 10m Work Description: XenoAmess opened a new pull request #140: URL: https://github.com/apache/commons-math/pull/140 clean-up a test as discussed on [MATH-1537] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441333) Time Spent: 2h (was: 1h 50m) > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] XenoAmess opened a new pull request #140: [MATH-1537] clean-up a test
XenoAmess opened a new pull request #140: URL: https://github.com/apache/commons-math/pull/140 clean-up a test as discussed on [MATH-1537] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125987#comment-17125987 ] JIN XU commented on MATH-1537: -- [~erans] Yep that is what I mean. Sorry for the delay. I was trying a performance investigation in common-compress yesterday. Will solve this right away. > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638891049 for new commers, the last conversation happened in https://github.com/apache/commons-compress/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108:
URL: https://github.com/apache/commons-compress/pull/108#issuecomment-63981
result json
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOld",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "1000 ms",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "1000 ms",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 1231787.9057171796,
"scoreError" : 60747.12958923382,
"scoreConfidence" : [
1171040.7761279459,
1292535.0353064134
],
"scorePercentiles" : {
"0.0" : 1117403.0066815144,
"50.0" : 1206172.8915662651,
"90.0" : 1357090.8833458365,
"95.0" : 1397579.7860595766,
"99.0" : 1407715.308988764,
"99.9" : 1407715.308988764,
"99.99" : 1407715.308988764,
"99.999" : 1407715.308988764,
"99." : 1407715.308988764,
"100.0" : 1407715.308988764
},
"scoreUnit" : "ns/op",
"rawData" : [
[
1177021.6204465334,
1127303.7109111361,
1258797.7415307402,
1315991.2073490813,
1205418.4115523465
],
[
1117403.0066815144,
1120983.110738255,
1206172.8915662651,
1235757.2839506173,
1288148.2670089859
],
[
1345864.6505376345,
1249905.6097256858,
1229342.455214724,
1174833.6471277843,
1373930.2325581396
],
[
1407715.308988764,
1319910.290237467,
1196952.9916267942,
1191689.535077289,
1191617.3590963138
],
[
1161137.9350348029,
1247206.3354037267,
1329505.9760956175,
1134020.724801812,
1188067.3396674583
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOldWithNonBreak",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "1000 ms",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "1000 ms",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 1232199.7367553925,
"scoreError" : 49896.117650952154,
"scoreConfidence" : [
1182303.6191044403,
1282095.8544063447
],
"scorePercentiles" : {
"0.0" : 1138645.4545454546,
"50.0" : 1220320.2451219512,
"90.0" : 1330014.3934583652,
"95.0" : 1416521.2841356166,
"99.0" : 1447036.6379310344,
"99.9" : 1447036.6379310344,
"99.99" : 1447036.6379310344,
"99.999" : 1447036.6379310344,
"99." : 1447036.6379310344,
"100.0" : 1447036.6379310344
},
"scoreUnit" : "ns/op",
"rawData" : [
[
1219577.6155717762,
1217867.5182481753,
1239696.6530359355,
1345318.7919463087,
1188941.567695962
],
[
1220320.2451219512,
1178962.190812721,
[GitHub] [commons-compress] XenoAmess edited a comment on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess edited a comment on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-63252 result: ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-compress --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 1000 ms each # Measurement: 5 iterations, 1000 ms each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOld # Run progress: 0.00% complete, ETA 00:08:20 # Fork: 1 of 5 # Warmup Iteration 1: 1610496.308 ns/op # Warmup Iteration 2: 1285739.923 ns/op # Warmup Iteration 3: 1319075.659 ns/op # Warmup Iteration 4: 1206658.054 ns/op # Warmup Iteration 5: 1212034.825 ns/op Iteration 1: 1177021.620 ns/op Iteration 2: 1127303.711 ns/op Iteration 3: 1258797.742 ns/op Iteration 4: 1315991.207 ns/op Iteration 5: 1205418.412 ns/op # Run progress: 2.00% complete, ETA 00:08:39 # Fork: 2 of 5 # Warmup Iteration 1: 2294073.057 ns/op # Warmup Iteration 2: 1375517.170 ns/op # Warmup Iteration 3: 1239546.963 ns/op # Warmup Iteration 4: 1351977.974 ns/op # Warmup Iteration 5: 1134073.159 ns/op Iteration 1: 1117403.007 ns/op Iteration 2: 1120983.111 ns/op Iteration 3: 1206172.892 ns/op Iteration 4: 1235757.284 ns/op Iteration 5: 1288148.267 ns/op # Run progress: 4.00% complete, ETA 00:08:27 # Fork: 3 of 5 # Warmup Iteration 1: 1693162.961 ns/op # Warmup Iteration 2: 1167198.016 ns/op # Warmup Iteration 3: 1133606.893 ns/op # Warmup Iteration 4: 1161932.098 ns/op # Warmup Iteration 5: 1535876.687 ns/op Iteration 1: 1345864.651 ns/op Iteration 2: 1249905.610 ns/op Iteration 3: 1229342.455 ns/op Iteration 4: 1174833.647 ns/op Iteration 5: 1373930.233 ns/op # Run progress: 6.00% complete, ETA 00:08:16 # Fork: 4 of 5 # Warmup Iteration 1: 1879272.472 ns/op # Warmup Iteration 2: 1162737.631 ns/op # Warmup Iteration 3: 1181587.721 ns/op # Warmup Iteration 4: 1188449.348 ns/op # Warmup Iteration 5: 1269665.100 ns/op Iteration 1: 1407715.309 ns/op Iteration 2: 1319910.290 ns/op Iteration 3: 1196952.992 ns/op Iteration 4: 1191689.535 ns/op Iteration 5: 1191617.359 ns/op # Run progress: 8.00% complete, ETA 00:08:08 # Fork: 5 of 5 # Warmup Iteration 1: 1853807.299 ns/op # Warmup Iteration 2: 1315560.938 ns/op # Warmup Iteration 3: 1199441.746 ns/op # Warmup Iteration 4: 1204869.112 ns/op # Warmup Iteration 5: 1175004.338 ns/op Iteration 1: 1161137.935 ns/op Iteration 2: 1247206.335 ns/op Iteration 3: 1329505.976 ns/op Iteration 4: 1134020.725 ns/op Iteration 5: 1188067.340 ns/op Result "org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOld": 1231787.906 ?99.9%) 60747.130 ns/op [Average] (min, avg, max) = (1117403.007, 1231787.906, 1407715.309), stdev = 81095.680 CI (99.9%): [1171040.776, 1292535.035] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 1000 ms each # Measurement: 5 iterations, 1000 ms each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOldWithNonBreak # Run progress: 10.00% complete, ETA 00:07:57 # Fork: 1 of 5 # Warmup Iteration 1: 1599017.358 ns/op # Warmup Iteration 2: 1217280.802 ns/op # Warmup Iteration 3: 1371714.522 ns/op # Warmup Iteration 4: 1198214.593 ns/op # Warmup Iteration 5: 1242029.988 ns/op Iteration 1: 1219577.616 ns/op Iteration 2: 1217867.518 ns/op Iteration 3: 1239696.653 ns/op Iteration 4: 1345318.792 ns/op Iteration 5: 1188941.568 ns/op # Run progress: 12.00% complete, ETA 00:07:46 # Fork: 2 of 5 # Warmup Iteration
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-63252 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-compress --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 1000 ms each # Measurement: 5 iterations, 1000 ms each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOld # Run progress: 0.00% complete, ETA 00:08:20 # Fork: 1 of 5 # Warmup Iteration 1: 1610496.308 ns/op # Warmup Iteration 2: 1285739.923 ns/op # Warmup Iteration 3: 1319075.659 ns/op # Warmup Iteration 4: 1206658.054 ns/op # Warmup Iteration 5: 1212034.825 ns/op Iteration 1: 1177021.620 ns/op Iteration 2: 1127303.711 ns/op Iteration 3: 1258797.742 ns/op Iteration 4: 1315991.207 ns/op Iteration 5: 1205418.412 ns/op # Run progress: 2.00% complete, ETA 00:08:39 # Fork: 2 of 5 # Warmup Iteration 1: 2294073.057 ns/op # Warmup Iteration 2: 1375517.170 ns/op # Warmup Iteration 3: 1239546.963 ns/op # Warmup Iteration 4: 1351977.974 ns/op # Warmup Iteration 5: 1134073.159 ns/op Iteration 1: 1117403.007 ns/op Iteration 2: 1120983.111 ns/op Iteration 3: 1206172.892 ns/op Iteration 4: 1235757.284 ns/op Iteration 5: 1288148.267 ns/op # Run progress: 4.00% complete, ETA 00:08:27 # Fork: 3 of 5 # Warmup Iteration 1: 1693162.961 ns/op # Warmup Iteration 2: 1167198.016 ns/op # Warmup Iteration 3: 1133606.893 ns/op # Warmup Iteration 4: 1161932.098 ns/op # Warmup Iteration 5: 1535876.687 ns/op Iteration 1: 1345864.651 ns/op Iteration 2: 1249905.610 ns/op Iteration 3: 1229342.455 ns/op Iteration 4: 1174833.647 ns/op Iteration 5: 1373930.233 ns/op # Run progress: 6.00% complete, ETA 00:08:16 # Fork: 4 of 5 # Warmup Iteration 1: 1879272.472 ns/op # Warmup Iteration 2: 1162737.631 ns/op # Warmup Iteration 3: 1181587.721 ns/op # Warmup Iteration 4: 1188449.348 ns/op # Warmup Iteration 5: 1269665.100 ns/op Iteration 1: 1407715.309 ns/op Iteration 2: 1319910.290 ns/op Iteration 3: 1196952.992 ns/op Iteration 4: 1191689.535 ns/op Iteration 5: 1191617.359 ns/op # Run progress: 8.00% complete, ETA 00:08:08 # Fork: 5 of 5 # Warmup Iteration 1: 1853807.299 ns/op # Warmup Iteration 2: 1315560.938 ns/op # Warmup Iteration 3: 1199441.746 ns/op # Warmup Iteration 4: 1204869.112 ns/op # Warmup Iteration 5: 1175004.338 ns/op Iteration 1: 1161137.935 ns/op Iteration 2: 1247206.335 ns/op Iteration 3: 1329505.976 ns/op Iteration 4: 1134020.725 ns/op Iteration 5: 1188067.340 ns/op Result "org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOld": 1231787.906 ?99.9%) 60747.130 ns/op [Average] (min, avg, max) = (1117403.007, 1231787.906, 1407715.309), stdev = 81095.680 CI (99.9%): [1171040.776, 1292535.035] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 1000 ms each # Measurement: 5 iterations, 1000 ms each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.compress.performance.BZip2CompressorOutputStreamXenoAmessTest.testOldWithNonBreak # Run progress: 10.00% complete, ETA 00:07:57 # Fork: 1 of 5 # Warmup Iteration 1: 1599017.358 ns/op # Warmup Iteration 2: 1217280.802 ns/op # Warmup Iteration 3: 1371714.522 ns/op # Warmup Iteration 4: 1198214.593 ns/op # Warmup Iteration 5: 1242029.988 ns/op Iteration 1: 1219577.616 ns/op Iteration 2: 1217867.518 ns/op Iteration 3: 1239696.653 ns/op Iteration 4: 1345318.792 ns/op Iteration 5: 1188941.568 ns/op # Run progress: 12.00% complete, ETA 00:07:46 # Fork: 2 of 5 # Warmup Iteration 1: 1609769.071
[GitHub] [commons-compress] XenoAmess removed a comment on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess removed a comment on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638870037 wait a minute. some thing might goes wrong. I will have to recheck it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess removed a comment on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess removed a comment on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638867760 Now I will add the `break` and make BZip2CompressorOutputStream equal to what in branch master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] garydgregory commented on pull request #31: Added Automatic-Module-Name to support JPMS
garydgregory commented on pull request #31: URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638885290 The name is fine but you should use a property, see Apache Commons Lang for an example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess closed pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess closed pull request #108: URL: https://github.com/apache/commons-compress/pull/108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638870037 wait a minute. some thing might goes wrong. I will have to recheck it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-638867760 Now I will add the `break` and make BZip2CompressorOutputStream equal to what in branch master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess opened a new pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess opened a new pull request #108: URL: https://github.com/apache/commons-compress/pull/108 So I tried to make a refine for `BZip2CompressorOutputStream` yesterday. for conclusion, 1. adding the break seems at least not letting it slower. so we donot need to revert that change yesterday. 2. the codes right now is really fast. I mean, all of my refine tries seems no significant improvement for performance. 3. the refine method I tried: 3.0 class `BZip2CompressorOutputStream` is the original class without the break I added yesterday. class `BZip2CompressorOutputStreamBreak` is the version with added break. 3.1. class `BZip2CompressorOutputStreamXenoAmessInShort` : aims to use `short` instead of `boolean` in `Data.inUse` array, and use bit operations for copy/change. 3.2. class `BZip2CompressorOutputStreamXenoAmessInBoolean` : aims to inline more, and added some small changes. 3.3 class `BZip2CompressorOutputStreamXenoAmessInBoolean2` : aims to inline at LEAST methods as we can, and wholly trust JIT will give it a good C2. and the result of performance test shows that there are nearly no difference in speed actually, and `BZip2CompressorOutputStreamBreak` runs slightly (very slightly) faster than others. But, as all known, jmh is actually not a stable thing, so as the diffenerce are really small, I think it is the right time for me to surrender and stop trying to refine it using my tricky ways. And the `BZip2CompressorOutputStream` in master now is good. No need to revert the `break`. at least on win10, jdk13. Althought the refining-try failed, maybe the performance test codes and the "refined"(or, variant actually, as they does not refine anything) classes might be useful. I just put them in the test folder, and maybe next time when some guy wanna refine this class, they can at least know in what ways I failed and stop waste time on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] coveralls commented on pull request #31: Added Automatic-Module-Name to support JPMS
coveralls commented on pull request #31: URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638776466 [](https://coveralls.io/builds/31234653) Coverage increased (+0.07%) to 84.146% when pulling **436a8d9eda0a34e524392956f45ba3eac5ca05fd on scholzi100:POOL-385-Automatic-Module** into **45683c848a241026a9ad04fb5e2494e954593b6a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] scholzi100 commented on pull request #31: Added Automatic-Module-Name to support JPMS
scholzi100 commented on pull request #31: URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638765667 @garydgregory can you please review this PR. Is the module name suitable? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (POOL-385) Java Modularity Automatic-Module
[ https://issues.apache.org/jira/browse/POOL-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Scholz updated POOL-385: - Affects Version/s: 2.8.0 > Java Modularity Automatic-Module > > > Key: POOL-385 > URL: https://issues.apache.org/jira/browse/POOL-385 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Paul Scholz >Priority: Minor > Labels: newbie, pull-request-available > > Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. > This makes discovering this library on Module-Path much more standardized. > Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (POOL-385) Java Modularity Automatic-Module
[ https://issues.apache.org/jira/browse/POOL-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Scholz updated POOL-385: - Description: Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. This makes discovering this library on Module-Path much more standardized. Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] was: Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. This makes discovering this library on Module-Path much more standardized. > Java Modularity Automatic-Module > > > Key: POOL-385 > URL: https://issues.apache.org/jira/browse/POOL-385 > Project: Commons Pool > Issue Type: Improvement >Reporter: Paul Scholz >Priority: Minor > Labels: newbie, pull-request-available > > Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. > This makes discovering this library on Module-Path much more standardized. > Pull Request: [Issue 31|https://github.com/apache/commons-pool/pull/31] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-pool] scholzi100 opened a new pull request #31: Added Automatic-Module-Name to support JPMS
scholzi100 opened a new pull request #31: URL: https://github.com/apache/commons-pool/pull/31 Adding Automatic-Module-Name provides a standardized way for the JPMS Module-Path. This makes discovering commons-pool on the Module-Path standardized and keeps support for non JPMS libraries. Jira: [POOL-385 ](https://issues.apache.org/jira/browse/POOL-385) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (POOL-385) Java Modularity Automatic-Module
Paul Scholz created POOL-385: Summary: Java Modularity Automatic-Module Key: POOL-385 URL: https://issues.apache.org/jira/browse/POOL-385 Project: Commons Pool Issue Type: Improvement Reporter: Paul Scholz Support for JPMS, adding Automatic-Module-Name to MANIFEST.MF. This makes discovering this library on Module-Path much more standardized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NET-684) Most images aren't downloaded completely from an FTP server
Julia Ruzicka created NET-684: - Summary: Most images aren't downloaded completely from an FTP server Key: NET-684 URL: https://issues.apache.org/jira/browse/NET-684 Project: Commons Net Issue Type: Bug Components: FTP Affects Versions: 3.6 Environment: Win 10, Java 8, Android Studio 3.6.1, target Android SDK=27 Reporter: Julia Ruzicka Downloading images from an FTP server succeeds but the resulting images are incomplete (black/transparent parts at the bottom) or faulty (wrong colors/visual artifacts) most of the time. You can find examples and full code in [this|http://mail-archives.apache.org/mod_mbox/commons-user/202005.mbox/%3C000b01d6341c%246a66f7f0%243f34e7d0%24%40simutech.at%3E] mailing list thread. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125648#comment-17125648
]
Robert Konior commented on LANG-1544:
-
I'm a newbie also but Gary told to feel free with providing PR, so I do
suppose you can do it without Jira assignment, jest done this according to
these instructions
[https://github.com/apache/commons-lang/blob/master/CONTRIBUTING.md]
> MethodUtils.invokeMethod NullPointerException in case of null in args list
> --
>
> Key: LANG-1544
> URL: https://issues.apache.org/jira/browse/LANG-1544
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.10
>Reporter: Peter Nagy
>Priority: Critical
>
> MethodUtils:774
>
> if (classArray[offset].equals(toClassArray[offset])) {
> continue;
> } else if (ClassUtils.isAssignable(classArray[offset], toClassArray[offset],
> true)
>
> cause NPE if classArray[offset] is null. Can you please extend the if
> condition with a null check, like this?
>
> if (classArray[offset] != null &&
> classArray[offset].equals(toClassArray[offset]))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=441129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441129 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 04/Jun/20 06:32 Start Date: 04/Jun/20 06:32 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638632471 too late, I've already merged this one :-) It is very much possible javac has become better in the fifteen years or so since the code has been written. A while ago I started https://github.com/bodewig/commons-compress-benchmarks as a limited JMH based setup to see how things changed over time. It might be a starting point - or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441129) Time Spent: 1h (was: 50m) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig commented on pull request #106: [COMPRESS-535] maybe we can add a break here
bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638632471 too late, I've already merged this one :-) It is very much possible javac has become better in the fifteen years or so since the code has been written. A while ago I started https://github.com/bodewig/commons-compress-benchmarks as a limited JMH based setup to see how things changed over time. It might be a starting point - or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
