[GitHub] [commons-io] garydgregory commented on pull request #117: Prevent NullPointerException in ReversedLinesFileReader constructor
garydgregory commented on pull request #117: URL: https://github.com/apache/commons-io/pull/117#issuecomment-639968674 I will review tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess edited a comment on pull request #44: refine travis-ci script
XenoAmess edited a comment on pull request #44:
URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639847967
@garydgregory
1. should we change commons-parent directly, thus we do not need to change
every repo's pom.xml?
2. I see you add that plugin in `` in this repo's pom.xml. Is it
really needed? can we simply add/change ` ${commons.felix.version}` and
`${biz.aQute.bndlib.version}` into `` to make a same effect?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess commented on pull request #44: refine travis-ci script
XenoAmess commented on pull request #44:
URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639847967
@garydgregory
1. should we change commons-parent directly, thus we do not need to change
every repo's pom.xml?
2. I see you add that plugin in `` in this repo's pom.xml. Is it
really needed? can we simply change ` ${commons.felix.version}` and
`${biz.aQute.bndlib.version}` to make a same effect?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #44: refine travis-ci script
garydgregory commented on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639842609 @XenoAmess Yes, eventually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess edited a comment on pull request #44: fix travis-ci script
XenoAmess edited a comment on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639839203 > The fix depends on a POM update. @garydgregory I knew it. I mean, should we also update other repos following the same way, to make them can build on ea? Anyway, I will change this out-dated pr first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess edited a comment on pull request #44: fix travis-ci script
XenoAmess edited a comment on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639839203 > The fix depends on a POM update. @garydgregory I knew it. I mean, should we also update other repos following the same way, to make them can build on ea? Anyway, I will change the out-dated prs first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess edited a comment on pull request #44: fix travis-ci script
XenoAmess edited a comment on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639839203 > The fix depends on a POM update. @garydgregory I knew it. I mean, should we also update other repos following the same way, to make them can build on ea? Anyway, I will close the out-dated prs first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess commented on pull request #44: fix travis-ci script
XenoAmess commented on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639839203 > The fix depends on a POM update. I knew it. I mean, should we also update other repos following the same way, to make them can build on ea? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #44: fix travis-ci script
garydgregory commented on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639835361 Look at the recent pom.xml commit. The fix depends on a POM update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess edited a comment on pull request #44: fix travis-ci script
XenoAmess edited a comment on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639833078 > -1 openjdk-ea is fine now. @garydgregory good news. seems they finally fixed that concurrency bug in that plugin? so should we also remove ea from allow failure in other repos (if possible)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] XenoAmess commented on pull request #44: fix travis-ci script
XenoAmess commented on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639833078 > -1 openjdk-ea is fine now. good news. seems they finally fixed that concurrency bug in that plugin? so should we also remove ea from allow failure in other repos (if possible)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #44: fix travis-ci script
garydgregory commented on pull request #44: URL: https://github.com/apache/commons-bcel/pull/44#issuecomment-639831218 -1 openjdk-ea is fine now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter commented on pull request #46: Base16 Input and Output Streams
adamretter commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-639768224 @garydgregory Could I get an update on this please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-639768421 @garydgregory Could I get an update on this please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] mernst commented on pull request #117: Prevent NullPointerException in ReversedLinesFileReader constructor
mernst commented on pull request #117: URL: https://github.com/apache/commons-io/pull/117#issuecomment-639636733 @garydgregory Can this pull request be merged? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=441877=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441877 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 05/Jun/20 15:16 Start Date: 05/Jun/20 15:16 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-639558681 @garydgregory Hi gary. please find some time for this pr. If this pr make sence, then I'll renew other `contentEquals` functions in the same class. thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441877) Time Spent: 3h (was: 2h 50m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Attachments: jmh-result.org.apache.json > > Time Spent: 3h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-639558681 @garydgregory Hi gary. please find some time for this pr. If this pr make sence, then I'll renew other `contentEquals` functions in the same class. thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31265488) Coverage decreased (-0.001%) to 95.039% when pulling **2a1df0d0f7c3f754380f76b7157296eaca5e1a35 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441876 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 05/Jun/20 15:14 Start Date: 05/Jun/20 15:14 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31265488) Coverage decreased (-0.001%) to 95.039% when pulling **2a1df0d0f7c3f754380f76b7157296eaca5e1a35 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441876) Time Spent: 3h (was: 2h 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 3h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441844=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441844
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 14:49
Start Date: 05/Jun/20 14:49
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
@dota17
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441844)
Time Spent: 2h 50m (was: 2h 40m)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
@dota17
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639538491
result json:
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2455031.50487269,
"scoreError" : 82596.43118906298,
"scoreConfidence" : [
2372435.073683627,
2537627.936061753
],
"scorePercentiles" : {
"0.0" : 2299801.7932858127,
"50.0" : 2442310.061050061,
"90.0" : 2638215.5304203783,
"95.0" : 2652540.041246207,
"99.0" : 2653839.453435925,
"99.9" : 2653839.453435925,
"99.99" : 2653839.453435925,
"99.999" : 2653839.453435925,
"99." : 2653839.453435925,
"100.0" : 2653839.453435925
},
"scoreUnit" : "ns/op",
"rawData" : [
[
2461469.0622692592,
2442310.061050061,
2427010.385828682,
2421185.7661583154,
2419471.335268505
],
[
2451503.3578431373,
2598355.2091452326,
2466372.503082614,
2653839.453435925,
2618707.4083769633
],
[
2476611.1906412477,
2419733.68037745,
2508645.0714823175,
2410321.065075922,
2649508.0794701986
],
[
2305189.6752707995,
2347030.7604411077,
2299801.7932858127,
235.214766659,
2303393.0234860694
],
[
2320520.784040826,
2630687.1643871646,
2464871.97044335,
2541760.457433291,
2415263.148756339
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2210111.711287217,
"scoreError" : 61020.04598156867,
"scoreConfidence" : [
2149091.6653056485,
2271131.757268786
],
"scorePercentiles" : {
"0.0" : 2087501.3358380296,
"50.0" : 2180778.613472858,
"90.0" : 2341613.3640486645,
"95.0" : 2410693.9690793087,
"99.0" : 2411927.9893924785,
"99.9" : 2411927.9893924785,
"99.99" : 2411927.9893924785,
"99.999" : 2411927.9893924785,
"99." : 2411927.9893924785,
"100.0" : 2411927.9893924785
},
"scoreUnit" : "ns/op",
"rawData" : [
[
2297479.214515388,
2144106.193527647,
2131691.6240409208,
2154484.8589274175,
2087501.3358380296
],
[
2407814.5883485796,
2256505.0541516244,
2270761.4301929628,
2174536.7389130434,
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441838
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 14:41
Start Date: 05/Jun/20 14:41
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639538491
result json:
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2455031.50487269,
"scoreError" : 82596.43118906298,
"scoreConfidence" : [
2372435.073683627,
2537627.936061753
],
"scorePercentiles" : {
"0.0" : 2299801.7932858127,
"50.0" : 2442310.061050061,
"90.0" : 2638215.5304203783,
"95.0" : 2652540.041246207,
"99.0" : 2653839.453435925,
"99.9" : 2653839.453435925,
"99.99" : 2653839.453435925,
"99.999" : 2653839.453435925,
"99." : 2653839.453435925,
"100.0" : 2653839.453435925
},
"scoreUnit" : "ns/op",
"rawData" : [
[
2461469.0622692592,
2442310.061050061,
2427010.385828682,
2421185.7661583154,
2419471.335268505
],
[
2451503.3578431373,
2598355.2091452326,
2466372.503082614,
2653839.453435925,
2618707.4083769633
],
[
2476611.1906412477,
2419733.68037745,
2508645.0714823175,
2410321.065075922,
2649508.0794701986
],
[
2305189.6752707995,
2347030.7604411077,
2299801.7932858127,
235.214766659,
2303393.0234860694
],
[
2320520.784040826,
2630687.1643871646,
2464871.97044335,
2541760.457433291,
2415263.148756339
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2210111.711287217,
"scoreError" : 61020.04598156867,
"scoreConfidence" : [
2149091.6653056485,
2271131.757268786
],
"scorePercentiles" : {
"0.0" : 2087501.3358380296,
"50.0" : 2180778.613472858,
"90.0" : 2341613.3640486645,
"95.0" : 2410693.9690793087,
"99.0" : 2411927.9893924785,
"99.9" : 2411927.9893924785,
"99.99" : 2411927.9893924785,
"99.999" : 2411927.9893924785,
"99." : 2411927.9893924785,
"100.0" : 2411927.9893924785
},
"scoreUnit" : "ns/op",
"rawData" : [
[
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441837 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 05/Jun/20 14:40 Start Date: 05/Jun/20 14:40 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639537791 I refined the test source, and give it a retest. **result:** ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjd k/jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New # Run progress: 0.00% complete, ETA 01:15:00 # Fork: 1 of 5 # Warmup Iteration 1: 2891811.998 ns/op # Warmup Iteration 2: 2416673.665 ns/op # Warmup Iteration 3: 2446011.030 ns/op # Warmup Iteration 4: 2449321.915 ns/op # Warmup Iteration 5: 2447740.822 ns/op Iteration 1: 2461469.062 ns/op Iteration 2: 2442310.061 ns/op Iteration 3: 2427010.386 ns/op Iteration 4: 2421185.766 ns/op Iteration 5: 2419471.335 ns/op # Run progress: 2.22% complete, ETA 01:13:53 # Fork: 2 of 5 # Warmup Iteration 1: 2273738.841 ns/op # Warmup Iteration 2: 2401915.102 ns/op # Warmup Iteration 3: 2480256.930 ns/op # Warmup Iteration 4: 2456014.980 ns/op # Warmup Iteration 5: 2500686.453 ns/op Iteration 1: 2451503.358 ns/op Iteration 2: 2598355.209 ns/op Iteration 3: 2466372.503 ns/op Iteration 4: 2653839.453 ns/op Iteration 5: 2618707.408 ns/op # Run progress: 4.44% complete, ETA 01:12:09 # Fork: 3 of 5 # Warmup Iteration 1: 2280302.941 ns/op # Warmup Iteration 2: 2384730.465 ns/op # Warmup Iteration 3: 2482601.067 ns/op # Warmup Iteration 4: 2622762.795 ns/op # Warmup Iteration 5: 2478504.832 ns/op Iteration 1: 2476611.191 ns/op Iteration 2: 2419733.680 ns/op Iteration 3: 2508645.071 ns/op Iteration 4: 2410321.065 ns/op Iteration 5: 2649508.079 ns/op # Run progress: 6.67% complete, ETA 01:10:25 # Fork: 4 of 5 # Warmup Iteration 1: 2305637.137 ns/op # Warmup Iteration 2: 2450478.780 ns/op # Warmup Iteration 3: 2397859.012 ns/op # Warmup Iteration 4: 2389567.344 ns/op # Warmup Iteration 5: 2431105.348 ns/op Iteration 1: 2305189.675 ns/op Iteration 2: 2347030.760 ns/op Iteration 3: 2299801.793 ns/op Iteration 4: 235.215 ns/op Iteration 5: 2303393.023 ns/op # Run progress: 8.89% complete, ETA 01:08:45 # Fork: 5 of 5 # Warmup Iteration 1: 2160220.039 ns/op # Warmup Iteration 2: 2265527.588 ns/op # Warmup Iteration 3: 2314211.754 ns/op # Warmup Iteration 4: 2296356.211 ns/op # Warmup Iteration 5: 2309983.141 ns/op Iteration 1: 2320520.784 ns/op Iteration 2: 2630687.164 ns/op Iteration 3: 2464871.970 ns/op Iteration 4: 2541760.457 ns/op Iteration 5: 2415263.149 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New": 2455031.505 ?99.9%) 82596.431 ns/op [Average] (min, avg, max) = (2299801.793, 2455031.505, 2653839.453), stdev = 110263.873 CI (99.9%): [2372435.074, 2537627.936] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline # Run progress: 11.11% complete, ETA 01:07:03 # Fork: 1 of 5 # Warmup Iteration 1: 2033885.418 ns/op # Warmup Iteration 2: 2050448.032 ns/op # Warmup Iteration 3:
[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639537791 I refined the test source, and give it a retest. **result:** ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjd k/jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New # Run progress: 0.00% complete, ETA 01:15:00 # Fork: 1 of 5 # Warmup Iteration 1: 2891811.998 ns/op # Warmup Iteration 2: 2416673.665 ns/op # Warmup Iteration 3: 2446011.030 ns/op # Warmup Iteration 4: 2449321.915 ns/op # Warmup Iteration 5: 2447740.822 ns/op Iteration 1: 2461469.062 ns/op Iteration 2: 2442310.061 ns/op Iteration 3: 2427010.386 ns/op Iteration 4: 2421185.766 ns/op Iteration 5: 2419471.335 ns/op # Run progress: 2.22% complete, ETA 01:13:53 # Fork: 2 of 5 # Warmup Iteration 1: 2273738.841 ns/op # Warmup Iteration 2: 2401915.102 ns/op # Warmup Iteration 3: 2480256.930 ns/op # Warmup Iteration 4: 2456014.980 ns/op # Warmup Iteration 5: 2500686.453 ns/op Iteration 1: 2451503.358 ns/op Iteration 2: 2598355.209 ns/op Iteration 3: 2466372.503 ns/op Iteration 4: 2653839.453 ns/op Iteration 5: 2618707.408 ns/op # Run progress: 4.44% complete, ETA 01:12:09 # Fork: 3 of 5 # Warmup Iteration 1: 2280302.941 ns/op # Warmup Iteration 2: 2384730.465 ns/op # Warmup Iteration 3: 2482601.067 ns/op # Warmup Iteration 4: 2622762.795 ns/op # Warmup Iteration 5: 2478504.832 ns/op Iteration 1: 2476611.191 ns/op Iteration 2: 2419733.680 ns/op Iteration 3: 2508645.071 ns/op Iteration 4: 2410321.065 ns/op Iteration 5: 2649508.079 ns/op # Run progress: 6.67% complete, ETA 01:10:25 # Fork: 4 of 5 # Warmup Iteration 1: 2305637.137 ns/op # Warmup Iteration 2: 2450478.780 ns/op # Warmup Iteration 3: 2397859.012 ns/op # Warmup Iteration 4: 2389567.344 ns/op # Warmup Iteration 5: 2431105.348 ns/op Iteration 1: 2305189.675 ns/op Iteration 2: 2347030.760 ns/op Iteration 3: 2299801.793 ns/op Iteration 4: 235.215 ns/op Iteration 5: 2303393.023 ns/op # Run progress: 8.89% complete, ETA 01:08:45 # Fork: 5 of 5 # Warmup Iteration 1: 2160220.039 ns/op # Warmup Iteration 2: 2265527.588 ns/op # Warmup Iteration 3: 2314211.754 ns/op # Warmup Iteration 4: 2296356.211 ns/op # Warmup Iteration 5: 2309983.141 ns/op Iteration 1: 2320520.784 ns/op Iteration 2: 2630687.164 ns/op Iteration 3: 2464871.970 ns/op Iteration 4: 2541760.457 ns/op Iteration 5: 2415263.149 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New": 2455031.505 ?99.9%) 82596.431 ns/op [Average] (min, avg, max) = (2299801.793, 2455031.505, 2653839.453), stdev = 110263.873 CI (99.9%): [2372435.074, 2537627.936] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline # Run progress: 11.11% complete, ETA 01:07:03 # Fork: 1 of 5 # Warmup Iteration 1: 2033885.418 ns/op # Warmup Iteration 2: 2050448.032 ns/op # Warmup Iteration 3: 2112706.717 ns/op # Warmup Iteration 4: 2028930.365 ns/op # Warmup Iteration 5: 2097623.653 ns/op Iteration 1: 2297479.215 ns/op Iteration 2: 2144106.194 ns/op Iteration 3: 2131691.624 ns/op Iteration 4: 2154484.859 ns/op Iteration 5: 2087501.336 ns/op # Run progress: 13.33% complete, ETA 01:05:22 # Fork: 2 of 5 # Warmup Iteration 1: 2053510.450 ns/op # Warmup
[jira] [Work logged] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?focusedWorklogId=441797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441797 ] ASF GitHub Bot logged work on COMPRESS-404: --- Author: ASF GitHub Bot Created on: 05/Jun/20 12:25 Start Date: 05/Jun/20 12:25 Worklog Time Spent: 10m Work Description: theobisproject commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-639450639 @bodewig @PeterAlfredLee Is there anything left I need to do to get this integrated? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441797) Time Spent: 3h 50m (was: 3h 40m) > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Time Spent: 3h 50m > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] theobisproject commented on pull request #97: COMPRESS-404: Use java.nio.Path in TarArchiveEntry
theobisproject commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-639450639 @bodewig @PeterAlfredLee Is there anything left I need to do to get this integrated? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess closed pull request #143: use System.arraycopy
XenoAmess closed pull request #143: URL: https://github.com/apache/commons-math/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess commented on pull request #143: use System.arraycopy
XenoAmess commented on pull request #143: URL: https://github.com/apache/commons-math/pull/143#issuecomment-639355861 no. pause this pr. please wait for my performance test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess edited a comment on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess edited a comment on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-639323235 > This PR is not intended to be merged but give some explanizations for #106, Indeed. I just have no clue how to show some codes without creating a pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #108: Performance test for BZip2CompressorOutputStream
XenoAmess commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-639323235 > This PR is not intended to be merged but give some explanizations for #106, indeed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] coveralls commented on pull request #143: use System.arraycopy
coveralls commented on pull request #143: URL: https://github.com/apache/commons-math/pull/143#issuecomment-639320701 [](https://coveralls.io/builds/31256715) Coverage increased (+0.003%) to 90.563% when pulling **4a92484dcc6fbe1ebd8b12c0820da23724d6ad7a on XenoAmess:use_System.arraycopy** into **715d89d2625b09915feb1dd1b60270842eeffb7a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #108: Performance test for BZip2CompressorOutputStream
PeterAlfredLee commented on pull request #108: URL: https://github.com/apache/commons-compress/pull/108#issuecomment-639319673 Hey @XenoAmess What is this PR helping? From my view, you are providing some test results for you PR #106. This PR is not intended to be merged but give some explanizations for #106, is it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess closed pull request #143: use System.arraycopy
XenoAmess closed pull request #143: URL: https://github.com/apache/commons-math/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess commented on pull request #142: use subList().clear instead of a loop of remove(0)
XenoAmess commented on pull request #142: URL: https://github.com/apache/commons-math/pull/142#issuecomment-639303187 Well IMO this can improve the speed as: 1. in most times the list is an ArrayList here in your codes. 2. when in original codes, each time you remove(0) it calls a `System.arraycopy`, means the array is copied `extra` times. 3. when use sublist.clear(), it actually called list.removeRange, which do only one `System.arraycopy`, thus far faster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441705=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441705
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 06:37
Start Date: 05/Jun/20 06:37
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441705)
Time Spent: 2h 20m (was: 2h 10m)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
