[GitHub] [commons-compress] bodewig commented on pull request #112: remove `== null` as it is covered by `instance of`
bodewig commented on pull request #112: URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640354810 thanks @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig merged pull request #112: remove `== null` as it is covered by `instance of`
bodewig merged pull request #112: URL: https://github.com/apache/commons-compress/pull/112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127825#comment-17127825 ] Peter Lee commented on COMPRESS-404: Thanks to @theobisproject this is implemented with PR #97. > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Fix For: 1.21 > > Time Spent: 4.5h > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee resolved COMPRESS-404. Fix Version/s: 1.21 Resolution: Fixed > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Fix For: 1.21 > > Time Spent: 4.5h > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?focusedWorklogId=442552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442552 ] ASF GitHub Bot logged work on COMPRESS-404: --- Author: ASF GitHub Bot Created on: 08/Jun/20 01:36 Start Date: 08/Jun/20 01:36 Worklog Time Spent: 10m Work Description: PeterAlfredLee merged pull request #97: URL: https://github.com/apache/commons-compress/pull/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442552) Time Spent: 4.5h (was: 4h 20m) > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Time Spent: 4.5h > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #97: COMPRESS-404: Use java.nio.Path in TarArchiveEntry
PeterAlfredLee commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-640316308 And thank you for your contributions @theobisproject . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?focusedWorklogId=442551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442551 ] ASF GitHub Bot logged work on COMPRESS-404: --- Author: ASF GitHub Bot Created on: 08/Jun/20 01:35 Start Date: 08/Jun/20 01:35 Worklog Time Spent: 10m Work Description: PeterAlfredLee commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-640316308 And thank you for your contributions @theobisproject . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442551) Time Spent: 4h 20m (was: 4h 10m) > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Time Spent: 4h 20m > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] PeterAlfredLee merged pull request #97: COMPRESS-404: Use java.nio.Path in TarArchiveEntry
PeterAlfredLee merged pull request #97: URL: https://github.com/apache/commons-compress/pull/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #112: remove `== null` as it is covered by `instance of`
PeterAlfredLee commented on pull request #112: URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640316012 > are you talking about the decreased coverage Nope, I was just wondering if the null check here is caused by some type of static analysis like FindBugs or Sonarqube. This PR looks good to me - if it's not because of some static analysis tool. > This happens because the builds on different JDKs end with slightly different results and so the coverage fluctuates a bit depending on which JDK's build finishes first. So that's the reason why the coverage varies when no code is changed. Thank you for your explanation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1565) change removeLastFieldSeparator to use endsWith
[ https://issues.apache.org/jira/browse/LANG-1565?focusedWorklogId=442481=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442481 ] ASF GitHub Bot logged work on LANG-1565: Author: ASF GitHub Bot Created on: 07/Jun/20 21:53 Start Date: 07/Jun/20 21:53 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636710503 [](https://coveralls.io/builds/31296651) Coverage decreased (-0.003%) to 95.038% when pulling **16f6c24e29411aa6bab8c389edefabd4c0b2a6de on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442481) Remaining Estimate: 0h Time Spent: 10m > change removeLastFieldSeparator to use endsWith > --- > > Key: LANG-1565 > URL: https://issues.apache.org/jira/browse/LANG-1565 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/550] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
coveralls edited a comment on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-636710503 [](https://coveralls.io/builds/31296651) Coverage decreased (-0.003%) to 95.038% when pulling **16f6c24e29411aa6bab8c389edefabd4c0b2a6de on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127779#comment-17127779 ] Jin Xu commented on IO-670: --- the new (refined) function can work 6.5 times faster in some cases. > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Critical > Attachments: jmh-result.org.apache.json > > Time Spent: 3h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=442475=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442475 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 07/Jun/20 21:45 Start Date: 07/Jun/20 21:45 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclusion:** In cases for small content readers (a File), the new function is slightly faster. but in cases for large content (a String), the new function can be 6.5 times faster. Come to re-think of it, it MIGHT because, the FileReader is slow, so the delay of that function is kindof, hided, But StringReader is faster, so the difference is more significant. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been
[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclusion:** In cases for small content readers (a File), the new function is slightly faster. but in cases for large content (a String), the new function can be 6.5 times faster. Come to re-think of it, it MIGHT because, the FileReader is slow, so the delay of that function is kindof, hided, But StringReader is faster, so the difference is more significant. ``` D:\workspace\commons-io>mvn -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] ---< commons-io:commons-io > [INFO] Building Apache Commons IO 2.7.1-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ commons-io --- [INFO] Deleting D:\workspace\commons-io\target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ commons-io --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-3) @ commons-io --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-io --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-io\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 12 explicit excludes (use -debug for more details). [INFO] 373 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 364 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @ commons-io --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-io --- [INFO] Executing tasks main: [copy] Copying 2 files to D:\workspace\commons-io\target\apidocs\META-INF [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ commons-io --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-io --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-io [INFO] Storing buildNumber: 73dc0ff3e6d79ab88f1ed0d253d52cb6da0dffa5 at timestamp: 1591034434847 [INFO] Storing buildScmBranch: refine_contentEquals [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-io --- [INFO] Using 'iso-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-io\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-io --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 158 source files to D:\workspace\commons-io\target\classes [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Some input files use or override a deprecated API. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java: Recompile with -Xlint:deprecation for details. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: D:\workspace\commons-io\src\main\java\org\apache\commons\io\IOException List.java uses unchecked or unsafe operations. [INFO] /D:/workspace/commons-io/src/main/java/org/apache/commons/io/IOExceptionList.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-io --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-io --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:158: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.limit(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.limit(int) [INFO] D:\workspace\commons-io\src\main\java\org\apache\commons\io\input\TeeReader.java:162: Covariant return type change detected: java.nio.Buffer java.nio.Char Buffer.position(int) has been changed to java.nio.CharBuffer java.nio.CharBuffer.position(int) [INFO]
[jira] [Updated] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated IO-670: -- Priority: Critical (was: Minor) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Critical > Attachments: jmh-result.org.apache.json > > Time Spent: 3h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1548: - Priority: Major (was: Minor) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (BEANUTILS-538) refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType
[ https://issues.apache.org/jira/browse/BEANUTILS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu resolved BEANUTILS-538. -- Resolution: Not A Problem > refine performance of MethodUtils.getPrimitiveWrapper and getPrimitiveType > -- > > Key: BEANUTILS-538 > URL: https://issues.apache.org/jira/browse/BEANUTILS-538 > Project: Commons BeanUtils > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [https://github.com/apache/commons-beanutils/pull/26] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1549) implement TODO in CharSequenceUtils.lastIndexOf : remake it.
[ https://issues.apache.org/jira/browse/LANG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1549: - Priority: Major (was: Minor) > implement TODO in CharSequenceUtils.lastIndexOf : remake it. > > > Key: LANG-1549 > URL: https://issues.apache.org/jira/browse/LANG-1549 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/535] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) Minor improvements
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: original pr : [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > Minor improvements > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > original pr : > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1565) change removeLastFieldSeparator to use endsWith
Jin Xu created LANG-1565: Summary: change removeLastFieldSeparator to use endsWith Key: LANG-1565 URL: https://issues.apache.org/jira/browse/LANG-1565 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/550] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1564) use Collections.singletonList insteadof Arrays.asList when there be only one element.
Jin Xu created LANG-1564: Summary: use Collections.singletonList insteadof Arrays.asList when there be only one element. Key: LANG-1564 URL: https://issues.apache.org/jira/browse/LANG-1564 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/549/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1563) use StandardCharsets.UTF_8
Jin Xu created LANG-1563: Summary: use StandardCharsets.UTF_8 Key: LANG-1563 URL: https://issues.apache.org/jira/browse/LANG-1563 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/548] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127774#comment-17127774 ] Gilles Sadowski commented on MATH-1537: --- "Resolved" is fine. Will be "closed" after the release of the next version. > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1562) use Math.max and min
Jin Xu created LANG-1562: Summary: use Math.max and min Key: LANG-1562 URL: https://issues.apache.org/jira/browse/LANG-1562 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/547/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1561) use List.sort instead of Collection.sort
[ https://issues.apache.org/jira/browse/LANG-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1561: - Priority: Minor (was: Major) > use List.sort instead of Collection.sort > > > Key: LANG-1561 > URL: https://issues.apache.org/jira/browse/LANG-1561 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > > https://github.com/apache/commons-lang/pull/546 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1561) use List.sort instead of Collection.sort
Jin Xu created LANG-1561: Summary: use List.sort instead of Collection.sort Key: LANG-1561 URL: https://issues.apache.org/jira/browse/LANG-1561 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/546 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) Minor improvements
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > Minor improvements > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1560) refine javadoc
Jin Xu created LANG-1560: Summary: refine javadoc Key: LANG-1560 URL: https://issues.apache.org/jira/browse/LANG-1560 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/545/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) Minor improvements
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Summary: Minor improvements (was: fix code smells; fix typos) > Minor improvements > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1559) convert Sting to StringBuilder in some test code.
Jin Xu created LANG-1559: Summary: convert Sting to StringBuilder in some test code. Key: LANG-1559 URL: https://issues.apache.org/jira/browse/LANG-1559 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/544] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1558) simplify if as some conditions are covered by others
Jin Xu created LANG-1558: Summary: simplify if as some conditions are covered by others Key: LANG-1558 URL: https://issues.apache.org/jira/browse/LANG-1558 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/543] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1557) change a Pattern to a static final field, for not letting it compile each time the function invoked.
Jin Xu created LANG-1557: Summary: change a Pattern to a static final field, for not letting it compile each time the function invoked. Key: LANG-1557 URL: https://issues.apache.org/jira/browse/LANG-1557 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1556) use java8 lambda and Map operations.
Jin Xu created LANG-1556: Summary: use java8 lambda and Map operations. Key: LANG-1556 URL: https://issues.apache.org/jira/browse/LANG-1556 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1555) we named a not ignored exception `ignored`, and I changed it to `e`
Jin Xu created LANG-1555: Summary: we named a not ignored exception `ignored`, and I changed it to `e` Key: LANG-1555 URL: https://issues.apache.org/jira/browse/LANG-1555 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1554) fix typos
Jin Xu created LANG-1554: Summary: fix typos Key: LANG-1554 URL: https://issues.apache.org/jira/browse/LANG-1554 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/539] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1553) change array style from `int a[]` to `int[] a`
Jin Xu created LANG-1553: Summary: change array style from `int a[]` to `int[] a` Key: LANG-1553 URL: https://issues.apache.org/jira/browse/LANG-1553 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Description: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] was: [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] -- [https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1547) fix code smells; fix typos
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1547: - Summary: fix code smells; fix typos (was: fix code smells; fix typos; performance refine(trying to)) > fix code smells; fix typos > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1552) change from addAll to constructors for some List.
Jin Xu created LANG-1552: Summary: change from addAll to constructors for some List. Key: LANG-1552 URL: https://issues.apache.org/jira/browse/LANG-1552 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/536/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1547) fix code smells; fix typos; performance refine(trying to)
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127753#comment-17127753 ] Jin Xu edited comment on LANG-1547 at 6/7/20, 8:52 PM: --- OK, I learned about *sub-task* things from [~erans] today, and I will try to convert prs about this to subtasks. I'm new to Jira system so if I do anything wrongly please just tell me. Thanks. was (Author: xenoamess): OK, I learned about *sub-task* thing from [~erans], and I will try to convert prs about this to subtasks. I'm new to Jira system so if I do anything wrongly please just tell me. Thanks. > fix code smells; fix typos; performance refine(trying to) > - > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1547) fix code smells; fix typos; performance refine(trying to)
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127753#comment-17127753 ] Jin Xu commented on LANG-1547: -- OK, I learned about *sub-task* thing from [~erans], and I will try to convert prs about this to subtasks. I'm new to Jira system so if I do anything wrongly please just tell me. Thanks. > fix code smells; fix typos; performance refine(trying to) > - > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- > [https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/539|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/541|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/542|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/543|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/544|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/545|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/546|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/547|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/548|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/549|https://github.com/apache/commons-lang/pull/536] > [https://github.com/apache/commons-lang/pull/550|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127752#comment-17127752 ] Jin Xu commented on MATH-1537: -- [~erans] Hi. I think this problem is already solved right? Should we close it? > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu resolved MATH-1537. -- Resolution: Fixed > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1545) Follow best practice to test ordering in implementation of Comparable
Jin Xu created MATH-1545: Summary: Follow best practice to test ordering in implementation of Comparable Key: MATH-1545 URL: https://issues.apache.org/jira/browse/MATH-1545 Project: Commons Math Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-math/pull/152] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1544) delete a needless (IMO) null for double varargs parameter.
Jin Xu created MATH-1544: Summary: delete a needless (IMO) null for double varargs parameter. Key: MATH-1544 URL: https://issues.apache.org/jira/browse/MATH-1544 Project: Commons Math Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-math/pull/150] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1543) use instanceof check instead of catch ClassCastException in some function.
Jin Xu created MATH-1543: Summary: use instanceof check instead of catch ClassCastException in some function. Key: MATH-1543 URL: https://issues.apache.org/jira/browse/MATH-1543 Project: Commons Math Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-math/pull/149] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1542) remove `== null` as it is covered by `instance of`
Jin Xu created MATH-1542: Summary: remove `== null` as it is covered by `instance of` Key: MATH-1542 URL: https://issues.apache.org/jira/browse/MATH-1542 Project: Commons Math Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-math/pull/148] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1541) break the loop when we can.
Jin Xu created MATH-1541: Summary: break the loop when we can. Key: MATH-1541 URL: https://issues.apache.org/jira/browse/MATH-1541 Project: Commons Math Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-math/pull/147] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1540) Minor improvements
Jin Xu created MATH-1540: Summary: Minor improvements Key: MATH-1540 URL: https://issues.apache.org/jira/browse/MATH-1540 Project: Commons Math Issue Type: Improvement Reporter: Jin Xu Minor improvements about this repo. As discussed in e-mail, I was suggested to create *one* report that will list all suggestions/PRs for small improvements sorted in categories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-vfs] moikeygraham commented on pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times
moikeygraham commented on pull request #82: URL: https://github.com/apache/commons-vfs/pull/82#issuecomment-640256120 Thanks for your time reviewing @garydgregory. Latest changes pushed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] moikeygraham commented on a change in pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times
moikeygraham commented on a change in pull request #82:
URL: https://github.com/apache/commons-vfs/pull/82#discussion_r436386589
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java
##
@@ -69,5 +69,14 @@ default void setBufferSize(final int bufferSize) throws
FileSystemException {
}
OutputStream storeFileStream(String relPath) throws IOException;
-
+
+default boolean features() throws IOException {
Review comment:
It's named the same as the delegate FTPClient method. I've renamed to
`getRemoteFtpFeatures`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.
[
https://issues.apache.org/jira/browse/MATH-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127626#comment-17127626
]
Gilles Sadowski commented on MATH-1538:
---
> I don't think different use-case can affect this.
The rationale for my remark is that although this little loop may be 7% faster,
the overall impact (in realistic calls to the method) might well be negligible.
And then IMHO, readability of the code is an important criterion too: Your way
of filling the array is not obvious (to me), and one could wonder about the
necessity to modify the code.
I would not object however on using a (self-documenting) method (to be defined
e.g. in utility class {{MathArrays}}):
{code:java}
/**
* Fill array with alternate values.
*
* @param arr Array to fill.
* @param x Value to copy to even slots.
* @param y Value to copy to odd slots.
*/
public void fill(double[] arr, double x, double y) {
// ...
}
{code}
> refine some codes dealing with filling an array with its first and second
> elements.
> ---
>
> Key: MATH-1538
> URL: https://issues.apache.org/jira/browse/MATH-1538
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-math/pull/144]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (COMPRESS-537) SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
[
https://issues.apache.org/jira/browse/COMPRESS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frotty resolved COMPRESS-537.
-
Resolution: Fixed
> SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
> ---
>
> Key: COMPRESS-537
> URL: https://issues.apache.org/jira/browse/COMPRESS-537
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Frotty
>Priority: Major
> Attachments: roxpack.atlas
>
>
> I create a 7zip archive and then load files from it. Using LZMA or BZIP2
> works, but when I change it to DEFLATE the files aren't loaded correctly,
> parts of them are missing.
> Example kotlin code:
>
> {code:java}
> public fun test() {
>// SAVE
>val target = File("target.7z")
>val sevenZOutput = SevenZOutputFile(target)
>sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
>val file = File("roxpack.atlas")
>val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
>sevenZOutput.putArchiveEntry(entry)
>sevenZOutput.write(Files.readAllBytes(file.toPath()))
>sevenZOutput.closeArchiveEntry()
>sevenZOutput.close()
>// LOAD
>val s7f = SevenZFile(target)
>s7f.use {
> var nextEntry = it.nextEntry
> do {
> if (nextEntry.name == entry.name) {
> val content = ByteArray(nextEntry.size.toInt())
> s7f.read(content)
> // with DEFLATE content array contains only 0's at the end,
> content string is cut off
> println(String(content))
> return
> }
> nextEntry = it.nextEntry
> } while (nextEntry != null)
>}
> }
> {code}
> When I extract the file using 7zip GUI tool, the file is intact, so the
> problem lies within the decompression. And again, this all works fine with
> LZMA and BZIP2.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-537) SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
[
https://issues.apache.org/jira/browse/COMPRESS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127601#comment-17127601
]
Frotty commented on COMPRESS-537:
-
[~bodewig] Thanks a lot for your quick response. Indeed, that was the problem.
> SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
> ---
>
> Key: COMPRESS-537
> URL: https://issues.apache.org/jira/browse/COMPRESS-537
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Frotty
>Priority: Major
> Attachments: roxpack.atlas
>
>
> I create a 7zip archive and then load files from it. Using LZMA or BZIP2
> works, but when I change it to DEFLATE the files aren't loaded correctly,
> parts of them are missing.
> Example kotlin code:
>
> {code:java}
> public fun test() {
>// SAVE
>val target = File("target.7z")
>val sevenZOutput = SevenZOutputFile(target)
>sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
>val file = File("roxpack.atlas")
>val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
>sevenZOutput.putArchiveEntry(entry)
>sevenZOutput.write(Files.readAllBytes(file.toPath()))
>sevenZOutput.closeArchiveEntry()
>sevenZOutput.close()
>// LOAD
>val s7f = SevenZFile(target)
>s7f.use {
> var nextEntry = it.nextEntry
> do {
> if (nextEntry.name == entry.name) {
> val content = ByteArray(nextEntry.size.toInt())
> s7f.read(content)
> // with DEFLATE content array contains only 0's at the end,
> content string is cut off
> println(String(content))
> return
> }
> nextEntry = it.nextEntry
> } while (nextEntry != null)
>}
> }
> {code}
> When I extract the file using 7zip GUI tool, the file is intact, so the
> problem lies within the decompression. And again, this all works fine with
> LZMA and BZIP2.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] XenoAmess opened a new pull request #152: change == 1 to > 0 for result check of compareTo
XenoAmess opened a new pull request #152: URL: https://github.com/apache/commons-math/pull/152 Though many implementations of Comparable (including BigFraction) returns only [0, -1, 1] for compareTo function, usually we do not use `== 1` to detect the result, but use [>0, ==0, <0], which is defined in javadoc of class Compare. Of course == 1 is correct here, as BigFraction is a final class and nobody can override this compareTo function. But I still think it be better to change it to > 0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.
[ https://issues.apache.org/jira/browse/MATH-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127591#comment-17127591 ] Jin Xu edited comment on MATH-1538 at 6/7/20, 11:00 AM: >Did you benchmark this with a realistic use-case (i.e. within the class where >this change is proposed)? Not yet, but I don't think different use-case can affect this. Though if you can find some codes which like a realistic use-case, I'm willing to do the performance benchmark. >any performance gain would be quite small Yes, it is small. only 7% on my last test. and would be even smaller when array size get smaller. was (Author: xenoamess): >Did you benchmark this with a realistic use-case (i.e. within the class where >this change is proposed)? Not yet, but I don't think different use-case can affect this. >any performance gain would be quite small Yes, it is small. only 7% on my last test. and would be even smaller when array size get smaller. > refine some codes dealing with filling an array with its first and second > elements. > --- > > Key: MATH-1538 > URL: https://issues.apache.org/jira/browse/MATH-1538 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/144] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.
[ https://issues.apache.org/jira/browse/MATH-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127591#comment-17127591 ] Jin Xu commented on MATH-1538: -- >Did you benchmark this with a realistic use-case (i.e. within the class where >this change is proposed)? Not yet, but I don't think different use-case can affect this. >any performance gain would be quite small Yes, it is small. only 7% on my last test. and would be even smaller when array size get smaller. > refine some codes dealing with filling an array with its first and second > elements. > --- > > Key: MATH-1538 > URL: https://issues.apache.org/jira/browse/MATH-1538 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/144] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (COMPRESS-537) SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
[
https://issues.apache.org/jira/browse/COMPRESS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127586#comment-17127586
]
Stefan Bodewig commented on COMPRESS-537:
-
You are ignoring the return value of {{read}}. Juts like the {{read}} method of
{{InputStream}} there is no guarantee the read call will fill the array, it may
read less bytes and another call (or more of them) may be necessary until
{{read}} returns -1.
In your tests you seem to be lucky for some of the compression methods but you
must ensure you really read the contents completely by looping over the
{{read}} method.
> SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
> ---
>
> Key: COMPRESS-537
> URL: https://issues.apache.org/jira/browse/COMPRESS-537
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Frotty
>Priority: Major
> Attachments: roxpack.atlas
>
>
> I create a 7zip archive and then load files from it. Using LZMA or BZIP2
> works, but when I change it to DEFLATE the files aren't loaded correctly,
> parts of them are missing.
> Example kotlin code:
>
> {code:java}
> public fun test() {
>// SAVE
>val target = File("target.7z")
>val sevenZOutput = SevenZOutputFile(target)
>sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
>val file = File("roxpack.atlas")
>val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
>sevenZOutput.putArchiveEntry(entry)
>sevenZOutput.write(Files.readAllBytes(file.toPath()))
>sevenZOutput.closeArchiveEntry()
>sevenZOutput.close()
>// LOAD
>val s7f = SevenZFile(target)
>s7f.use {
> var nextEntry = it.nextEntry
> do {
> if (nextEntry.name == entry.name) {
> val content = ByteArray(nextEntry.size.toInt())
> s7f.read(content)
> // with DEFLATE content array contains only 0's at the end,
> content string is cut off
> println(String(content))
> return
> }
> nextEntry = it.nextEntry
> } while (nextEntry != null)
>}
> }
> {code}
> When I extract the file using 7zip GUI tool, the file is intact, so the
> problem lies within the decompression. And again, this all works fine with
> LZMA and BZIP2.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] XenoAmess closed pull request #151: Why we compare two Integers with == but not equals()?
XenoAmess closed pull request #151: URL: https://github.com/apache/commons-math/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig commented on pull request #97: COMPRESS-404: Use java.nio.Path in TarArchiveEntry
bodewig commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-640195935 Yep, looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-404) Add Path equivalents to TarArchiveEntry, with methods using File delegating to equivalents
[ https://issues.apache.org/jira/browse/COMPRESS-404?focusedWorklogId=442411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442411 ] ASF GitHub Bot logged work on COMPRESS-404: --- Author: ASF GitHub Bot Created on: 07/Jun/20 10:45 Start Date: 07/Jun/20 10:45 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #97: URL: https://github.com/apache/commons-compress/pull/97#issuecomment-640195935 Yep, looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442411) Time Spent: 4h 10m (was: 4h) > Add Path equivalents to TarArchiveEntry, with methods using File delegating > to equivalents > -- > > Key: COMPRESS-404 > URL: https://issues.apache.org/jira/browse/COMPRESS-404 > Project: Commons Compress > Issue Type: Sub-task >Reporter: Simon Spero >Priority: Minor > Time Spent: 4h 10m > Remaining Estimate: 0h > > (This is a reasonable place to start, as Paths give better access to > tar-relevant metadata on unix system). > Symlink info is easier to obtain > Unix based Paths allow access to useful attributes under "unix:*" > - numeric uid and gid > - string owner and group names > - mtime,ctime,atime > - numeric mode > - numeric dev and inode > - numeric rdev > - Linux, Solaris and Windows allow access to extended attributes > (MacOS X xattrs aren't supported as of jdk 9) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] XenoAmess opened a new pull request #151: Why we compare two Integers with == but not equals()?
XenoAmess opened a new pull request #151: URL: https://github.com/apache/commons-math/pull/151 I see codes related to this and cannot find a proof for doing so. If it is specially designed please tell me the reason and close this pr. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #150: well I don't think the null here is needed.
XenoAmess opened a new pull request #150: URL: https://github.com/apache/commons-math/pull/150 after deleting it, it still point to the same constructor IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig commented on pull request #112: remove `== null` as it is covered by `instance of`
bodewig commented on pull request #112: URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640194759 @PeterAlfredLee are you talking about the decreased coverage? This happens because the builds on different JDKs end with slightly different results and so the coverage fluctuates a bit depending on which JDK's build finishes first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #149: refine equals from ClassCastException
XenoAmess opened a new pull request #149: URL: https://github.com/apache/commons-math/pull/149 changed it into an instanceof check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COMPRESS-537) SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
[
https://issues.apache.org/jira/browse/COMPRESS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frotty updated COMPRESS-537:
Description:
I create a 7zip archive and then load files from it. Using LZMA or BZIP2 works,
but when I change it to DEFLATE the files aren't loaded correctly, parts of
them are missing.
Example kotlin code:
{code:java}
public fun test() {
// SAVE
val target = File("target.7z")
val sevenZOutput = SevenZOutputFile(target)
sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
val file = File("roxpack.atlas")
val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
sevenZOutput.putArchiveEntry(entry)
sevenZOutput.write(Files.readAllBytes(file.toPath()))
sevenZOutput.closeArchiveEntry()
sevenZOutput.close()
// LOAD
val s7f = SevenZFile(target)
s7f.use {
var nextEntry = it.nextEntry
do {
if (nextEntry.name == entry.name) {
val content = ByteArray(nextEntry.size.toInt())
s7f.read(content)
// with DEFLATE content array contains only 0's at the end, content
string is cut off
println(String(content))
return
}
nextEntry = it.nextEntry
} while (nextEntry != null)
}
}
{code}
When I extract the file using 7zip GUI tool, the file is intact, so the problem
lies within the decompression. And again, this all works fine with LZMA and
BZIP2.
was:
I create a 7zip archive and then load files from it. Using LZMA or BZIP2 works,
but when I change it to DEFLATE the files aren't loaded correctly, parts of
them are missing.
Example kotlin code:
{code:java}
public fun test() {
// SAVE
val target = File("target.7z")
val sevenZOutput = SevenZOutputFile(target)
sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
val file = File("roxpack.atlas")
val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
sevenZOutput.putArchiveEntry(entry)
sevenZOutput.write(Files.readAllBytes(file.toPath()))
sevenZOutput.closeArchiveEntry()
sevenZOutput.close()
// LOAD
val s7f = SevenZFile(target)
s7f.use {
var nextEntry = it.nextEntry
do {
if (nextEntry.name == entry.name) {
val content = ByteArray(nextEntry.size.toInt())
s7f.read(content)
// with DEFLATE content array contains only 0's at the end, content
string is cut off
println(String(content))
return
}
nextEntry = it.nextEntry
} while (nextEntry != null)
}
}
{code}
When I extract the file using 7zip GUI tool, the file is intact, so the problem
lies within the decompression.
> SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
> ---
>
> Key: COMPRESS-537
> URL: https://issues.apache.org/jira/browse/COMPRESS-537
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Frotty
>Priority: Major
> Attachments: roxpack.atlas
>
>
> I create a 7zip archive and then load files from it. Using LZMA or BZIP2
> works, but when I change it to DEFLATE the files aren't loaded correctly,
> parts of them are missing.
> Example kotlin code:
>
> {code:java}
> public fun test() {
>// SAVE
>val target = File("target.7z")
>val sevenZOutput = SevenZOutputFile(target)
>sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
>val file = File("roxpack.atlas")
>val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
>sevenZOutput.putArchiveEntry(entry)
>sevenZOutput.write(Files.readAllBytes(file.toPath()))
>sevenZOutput.closeArchiveEntry()
>sevenZOutput.close()
>// LOAD
>val s7f = SevenZFile(target)
>s7f.use {
> var nextEntry = it.nextEntry
> do {
> if (nextEntry.name == entry.name) {
> val content = ByteArray(nextEntry.size.toInt())
> s7f.read(content)
> // with DEFLATE content array contains only 0's at the end,
> content string is cut off
> println(String(content))
> return
> }
> nextEntry = it.nextEntry
> } while (nextEntry != null)
>}
> }
> {code}
> When I extract the file using 7zip GUI tool, the file is intact, so the
> problem lies within the decompression. And again, this all works fine with
> LZMA and BZIP2.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-537) SevenZipOutputFile with DEFLATE compression is incorrectly decompressed
Frotty created COMPRESS-537:
---
Summary: SevenZipOutputFile with DEFLATE compression is
incorrectly decompressed
Key: COMPRESS-537
URL: https://issues.apache.org/jira/browse/COMPRESS-537
Project: Commons Compress
Issue Type: Bug
Affects Versions: 1.20
Reporter: Frotty
Attachments: roxpack.atlas
I create a 7zip archive and then load files from it. Using LZMA or BZIP2 works,
but when I change it to DEFLATE the files aren't loaded correctly, parts of
them are missing.
Example kotlin code:
{code:java}
public fun test() {
// SAVE
val target = File("target.7z")
val sevenZOutput = SevenZOutputFile(target)
sevenZOutput.setContentCompression(SevenZMethod.DEFLATE)
val file = File("roxpack.atlas")
val entry = sevenZOutput.createArchiveEntry(file, "roxpack.atlas")
sevenZOutput.putArchiveEntry(entry)
sevenZOutput.write(Files.readAllBytes(file.toPath()))
sevenZOutput.closeArchiveEntry()
sevenZOutput.close()
// LOAD
val s7f = SevenZFile(target)
s7f.use {
var nextEntry = it.nextEntry
do {
if (nextEntry.name == entry.name) {
val content = ByteArray(nextEntry.size.toInt())
s7f.read(content)
// with DEFLATE content array contains only 0's at the end, content
string is cut off
println(String(content))
return
}
nextEntry = it.nextEntry
} while (nextEntry != null)
}
}
{code}
When I extract the file using 7zip GUI tool, the file is intact, so the problem
lies within the decompression.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] XenoAmess opened a new pull request #148: remove `== null` as it is covered by `instance of`
XenoAmess opened a new pull request #148: URL: https://github.com/apache/commons-math/pull/148 Or, is it for special optimization strategy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess opened a new pull request #147: break the loop when we can.
XenoAmess opened a new pull request #147: URL: https://github.com/apache/commons-math/pull/147 or is there any special reason for not break here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] coveralls edited a comment on pull request #143: [MATH-1539] use System.arraycopy instead of loop for better performance.
coveralls edited a comment on pull request #143: URL: https://github.com/apache/commons-math/pull/143#issuecomment-639320701 [](https://coveralls.io/builds/31291106) Coverage increased (+0.007%) to 90.563% when pulling **a6d8853b9988e4a7d0a8aa7bd9ec2ef437494263 on XenoAmess:use_System.arraycopy** into **ba8a26705e7656201951ddc1a4a67c6aaa62d146 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1539) use System.arraycopy instead of loop for better performance.
[ https://issues.apache.org/jira/browse/MATH-1539?focusedWorklogId=442398=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442398 ] ASF GitHub Bot logged work on MATH-1539: Author: ASF GitHub Bot Created on: 07/Jun/20 09:07 Start Date: 07/Jun/20 09:07 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #143: URL: https://github.com/apache/commons-math/pull/143#issuecomment-639320701 [](https://coveralls.io/builds/31291106) Coverage increased (+0.007%) to 90.563% when pulling **a6d8853b9988e4a7d0a8aa7bd9ec2ef437494263 on XenoAmess:use_System.arraycopy** into **ba8a26705e7656201951ddc1a4a67c6aaa62d146 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442398) Time Spent: 1h (was: 50m) > use System.arraycopy instead of loop for better performance. > - > > Key: MATH-1539 > URL: https://issues.apache.org/jira/browse/MATH-1539 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/143] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.
[ https://issues.apache.org/jira/browse/MATH-1538?focusedWorklogId=442383=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442383 ] ASF GitHub Bot logged work on MATH-1538: Author: ASF GitHub Bot Created on: 07/Jun/20 06:08 Start Date: 07/Jun/20 06:08 Worklog Time Spent: 10m Work Description: XenoAmess commented on a change in pull request #144: URL: https://github.com/apache/commons-math/pull/144#discussion_r436328851 ## File path: src/main/java/org/apache/commons/math4/analysis/differentiation/DSCompiler.java ## @@ -1497,11 +1497,11 @@ public void cosh(final double[] operand, final int operandOffset, // create the function value and derivatives double[] function = new double[1 + order]; -function[0] = FastMath.cosh(operand[operandOffset]); +final double function0 = function[0] = FastMath.cosh(operand[operandOffset]); Review comment: @efge > final is useless Yep, if you think it that way. >and not the code style for these files There is final for local variable for class `FieldDenseMatrix` , `TricubicInterpolator` , `UnivariatePeriodicInterpolator` , `FieldDenseMatrix` , `SobolSequenceGenerator`, `GeometryExample`, and several test classes. So I think the `final` I used is not outside of "the code style for these files", thus no need to change. Or if I mis-understand something, please tell me. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442383) Time Spent: 40m (was: 0.5h) > refine some codes dealing with filling an array with its first and second > elements. > --- > > Key: MATH-1538 > URL: https://issues.apache.org/jira/browse/MATH-1538 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/144] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] XenoAmess commented on a change in pull request #144: [MATH-1538] refine some codes dealing with filling an array with its first and second elements.
XenoAmess commented on a change in pull request #144: URL: https://github.com/apache/commons-math/pull/144#discussion_r436328851 ## File path: src/main/java/org/apache/commons/math4/analysis/differentiation/DSCompiler.java ## @@ -1497,11 +1497,11 @@ public void cosh(final double[] operand, final int operandOffset, // create the function value and derivatives double[] function = new double[1 + order]; -function[0] = FastMath.cosh(operand[operandOffset]); +final double function0 = function[0] = FastMath.cosh(operand[operandOffset]); Review comment: @efge > final is useless Yep, if you think it that way. >and not the code style for these files There is final for local variable for class `FieldDenseMatrix` , `TricubicInterpolator` , `UnivariatePeriodicInterpolator` , `FieldDenseMatrix` , `SobolSequenceGenerator`, `GeometryExample`, and several test classes. So I think the `final` I used is not outside of "the code style for these files", thus no need to change. Or if I mis-understand something, please tell me. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1538) refine some codes dealing with filling an array with its first and second elements.
[ https://issues.apache.org/jira/browse/MATH-1538?focusedWorklogId=442382=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442382 ] ASF GitHub Bot logged work on MATH-1538: Author: ASF GitHub Bot Created on: 07/Jun/20 06:07 Start Date: 07/Jun/20 06:07 Worklog Time Spent: 10m Work Description: XenoAmess commented on a change in pull request #144: URL: https://github.com/apache/commons-math/pull/144#discussion_r436328851 ## File path: src/main/java/org/apache/commons/math4/analysis/differentiation/DSCompiler.java ## @@ -1497,11 +1497,11 @@ public void cosh(final double[] operand, final int operandOffset, // create the function value and derivatives double[] function = new double[1 + order]; -function[0] = FastMath.cosh(operand[operandOffset]); +final double function0 = function[0] = FastMath.cosh(operand[operandOffset]); Review comment: > final is useless Yep, if you think it that way. >and not the code style for these files There is final for local variable for class `FieldDenseMatrix` , `TricubicInterpolator` , `UnivariatePeriodicInterpolator` , `FieldDenseMatrix` , `SobolSequenceGenerator`, `GeometryExample`, and several test classes. So I think the `final` I used is not outside of "the code style for these files", thus no need to change. Or if I mis-understand something, please tell me. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442382) Time Spent: 0.5h (was: 20m) > refine some codes dealing with filling an array with its first and second > elements. > --- > > Key: MATH-1538 > URL: https://issues.apache.org/jira/browse/MATH-1538 > Project: Commons Math > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/144] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] XenoAmess commented on a change in pull request #144: [MATH-1538] refine some codes dealing with filling an array with its first and second elements.
XenoAmess commented on a change in pull request #144: URL: https://github.com/apache/commons-math/pull/144#discussion_r436328851 ## File path: src/main/java/org/apache/commons/math4/analysis/differentiation/DSCompiler.java ## @@ -1497,11 +1497,11 @@ public void cosh(final double[] operand, final int operandOffset, // create the function value and derivatives double[] function = new double[1 + order]; -function[0] = FastMath.cosh(operand[operandOffset]); +final double function0 = function[0] = FastMath.cosh(operand[operandOffset]); Review comment: > final is useless Yep, if you think it that way. >and not the code style for these files There is final for local variable for class `FieldDenseMatrix` , `TricubicInterpolator` , `UnivariatePeriodicInterpolator` , `FieldDenseMatrix` , `SobolSequenceGenerator`, `GeometryExample`, and several test classes. So I think the `final` I used is not outside of "the code style for these files", thus no need to change. Or if I mis-understand something, please tell me. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
