[GitHub] [commons-graph] kinow commented on pull request #1: Update Maven settings, gitignore, and add README
kinow commented on pull request #1: URL: https://github.com/apache/commons-graph/pull/1#issuecomment-643693096 @ameyjadiye yup, looks like other files were merged. There's still one change here, which removes the `*~` from gitignore. Is that important @ameyjadiye ? If not we can simply close this one as the other commits were already merged, WDYT? ps: I keep my gitignore settings in `~/.gitignore`, so I don't need to worry about IDE specific files; that's useful for me as each component has a slightly different .gitignore, as well as $work, and other OSS projects This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] kinow merged pull request #554: fix checkstyle.
kinow merged pull request #554: URL: https://github.com/apache/commons-lang/pull/554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #554: fix checkstyle.
kinow commented on pull request #554: URL: https://github.com/apache/commons-lang/pull/554#issuecomment-643692610 Change in a test file and only for formatting. No need to wait other reviewers, nor no need for a JIRA IMO. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #554: fix checkstyle.
XenoAmess edited a comment on pull request #554: URL: https://github.com/apache/commons-lang/pull/554#issuecomment-643689923 update: due to track, that space might be caused by commit 306dbb0cb01f565bf04d8879cad9b413d94d4af5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #554: fix checkstyle.
XenoAmess edited a comment on pull request #554: URL: https://github.com/apache/commons-lang/pull/554#issuecomment-643689923 update: due to track, that space might be caused by commit 306dbb0cb01f565bf04d8879cad9b413d94d4af5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #554: fix checkstyle.
XenoAmess commented on pull request #554: URL: https://github.com/apache/commons-lang/pull/554#issuecomment-643689923 update: due to track, that space is caused by commit 306dbb0cb01f565bf04d8879cad9b413d94d4af5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess opened a new pull request #554: fix checkstyle.
XenoAmess opened a new pull request #554: URL: https://github.com/apache/commons-lang/pull/554 There is a trailing space in one class who blocks the checkstyle. (Which might caused by my pr so I come here to fix it.) Sorry about that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1565) change removeLastFieldSeparator to use endsWith
[ https://issues.apache.org/jira/browse/LANG-1565?focusedWorklogId=445452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445452 ] ASF GitHub Bot logged work on LANG-1565: Author: ASF GitHub Bot Created on: 13/Jun/20 22:49 Start Date: 13/Jun/20 22:49 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643688244 > Please rebase. @garydgregory done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445452) Time Spent: 0.5h (was: 20m) > change removeLastFieldSeparator to use endsWith > --- > > Key: LANG-1565 > URL: https://issues.apache.org/jira/browse/LANG-1565 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/550] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
XenoAmess commented on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643688244 > Please rebase. @garydgregory done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1565) change removeLastFieldSeparator to use endsWith
[ https://issues.apache.org/jira/browse/LANG-1565?focusedWorklogId=445451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445451 ] ASF GitHub Bot logged work on LANG-1565: Author: ASF GitHub Bot Created on: 13/Jun/20 22:38 Start Date: 13/Jun/20 22:38 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643686797 Please rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445451) Time Spent: 20m (was: 10m) > change removeLastFieldSeparator to use endsWith > --- > > Key: LANG-1565 > URL: https://issues.apache.org/jira/browse/LANG-1565 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/550] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #550: [LANG-1565] change removeLastFieldSeparator to use endsWith
garydgregory commented on pull request #550: URL: https://github.com/apache/commons-lang/pull/550#issuecomment-643686797 Please rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (LANG-1556) Use Java 8 lambdas and Map operations
[ https://issues.apache.org/jira/browse/LANG-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1556: -- Summary: Use Java 8 lambdas and Map operations (was: use java8 lambda and Map operations.) > Use Java 8 lambdas and Map operations > - > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1556) Use Java 8 lambdas and Map operations
[ https://issues.apache.org/jira/browse/LANG-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1556. --- Fix Version/s: 3.11 Resolution: Fixed > Use Java 8 lambdas and Map operations > - > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #541: [LANG-1556] Use Java 8 lambdas and Map operations.
garydgregory merged pull request #541: URL: https://github.com/apache/commons-lang/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445450=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445450 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 22:33 Start Date: 13/Jun/20 22:33 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #541: URL: https://github.com/apache/commons-lang/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445450) Time Spent: 1h 10m (was: 1h) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1570) Add JavaVersion enum constants for Java 14 and 15
[ https://issues.apache.org/jira/browse/LANG-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1570: -- Summary: Add JavaVersion enum constants for Java 14 and 15 (was: Add JavaVersion enum constants for Java 14 and 15.) > Add JavaVersion enum constants for Java 14 and 15 > - > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1570) Add JavaVersion enum constants for Java 14 and 15
[ https://issues.apache.org/jira/browse/LANG-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1570. --- Resolution: Fixed > Add JavaVersion enum constants for Java 14 and 15 > - > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1570) Add JavaVersion enum constants for Java 14 and 15.
[ https://issues.apache.org/jira/browse/LANG-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1570: -- Summary: Add JavaVersion enum constants for Java 14 and 15. (was: Add missing JavaVersion enum constatnts) > Add JavaVersion enum constants for Java 14 and 15. > -- > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1570) Add missing JavaVersion enum constatnts
[ https://issues.apache.org/jira/browse/LANG-1570?focusedWorklogId=445449=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445449 ] ASF GitHub Bot logged work on LANG-1570: Author: ASF GitHub Bot Created on: 13/Jun/20 22:30 Start Date: 13/Jun/20 22:30 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #553: URL: https://github.com/apache/commons-lang/pull/553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445449) Time Spent: 0.5h (was: 20m) > Add missing JavaVersion enum constatnts > --- > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #553: [LANG-1570] JavaVersion enum constants for Java 14 and 15.
garydgregory merged pull request #553: URL: https://github.com/apache/commons-lang/pull/553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #69: Change JiraCsv164Test to JiraCsv154Test
garydgregory merged pull request #69: URL: https://github.com/apache/commons-csv/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
garydgregory commented on pull request #69: URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643682732 > The content of this file is the test case of CSV-154. So the name should be modified to JiraCsv154Test. Then say that in the description! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #553: [LANG-1570] JavaVersion enum constants for Java 14 and 15.
coveralls commented on pull request #553: URL: https://github.com/apache/commons-lang/pull/553#issuecomment-643671071 [](https://coveralls.io/builds/31435718) Coverage increased (+0.002%) to 95.024% when pulling **d91ac808add8e7c39ad3e204c36a0bfa6b8acac6 on nstdio:LANG-1570** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1570) Add missing JavaVersion enum constatnts
[ https://issues.apache.org/jira/browse/LANG-1570?focusedWorklogId=445422=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445422 ] ASF GitHub Bot logged work on LANG-1570: Author: ASF GitHub Bot Created on: 13/Jun/20 20:02 Start Date: 13/Jun/20 20:02 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #553: URL: https://github.com/apache/commons-lang/pull/553#issuecomment-643671071 [](https://coveralls.io/builds/31435718) Coverage increased (+0.002%) to 95.024% when pulling **d91ac808add8e7c39ad3e204c36a0bfa6b8acac6 on nstdio:LANG-1570** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445422) Time Spent: 20m (was: 10m) > Add missing JavaVersion enum constatnts > --- > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 20m > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] nstdio opened a new pull request #553: [LANG-1570] JavaVersion enum constants for Java 14 and 15.
nstdio opened a new pull request #553: URL: https://github.com/apache/commons-lang/pull/553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1570) Add missing JavaVersion enum constatnts
[ https://issues.apache.org/jira/browse/LANG-1570?focusedWorklogId=445418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445418 ] ASF GitHub Bot logged work on LANG-1570: Author: ASF GitHub Bot Created on: 13/Jun/20 19:43 Start Date: 13/Jun/20 19:43 Worklog Time Spent: 10m Work Description: nstdio opened a new pull request #553: URL: https://github.com/apache/commons-lang/pull/553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445418) Remaining Estimate: 0h Time Spent: 10m > Add missing JavaVersion enum constatnts > --- > > Key: LANG-1570 > URL: https://issues.apache.org/jira/browse/LANG-1570 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Edgar Asatryan >Priority: Major > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 > and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1570) Add missing JavaVersion enum constatnts
Edgar Asatryan created LANG-1570: Summary: Add missing JavaVersion enum constatnts Key: LANG-1570 URL: https://issues.apache.org/jira/browse/LANG-1570 Project: Commons Lang Issue Type: Improvement Components: lang.* Reporter: Edgar Asatryan Fix For: 3.11 The *org.apache.commons.lang3.JavaVersion* is missing constant for Java 14 and 15. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435229) Coverage decreased (-0.001%) to 95.021% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445411 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:52 Start Date: 13/Jun/20 18:52 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435229) Coverage decreased (-0.001%) to 95.021% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445411) Time Spent: 3h 50m (was: 3h 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445409=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445409 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:44 Start Date: 13/Jun/20 18:44 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. `--` done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445409) Time Spent: 3h 40m (was: 3.5h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. `--` done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445407=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445407 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:43 Start Date: 13/Jun/20 18:43 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435207) Coverage increased (+0.005%) to 95.027% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445407) Time Spent: 3h 20m (was: 3h 10m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445408=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445408 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:43 Start Date: 13/Jun/20 18:43 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445408) Time Spent: 3.5h (was: 3h 20m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435207) Coverage increased (+0.005%) to 95.027% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445405=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445405 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:37 Start Date: 13/Jun/20 18:37 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here. I will try to retrigger it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445405) Time Spent: 3h 10m (was: 3h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here. I will try to retrigger it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #552: (doc): Use ArrayUtils::isArrayIndexValid method in ArrayUtils::get.
garydgregory merged pull request #552: URL: https://github.com/apache/commons-lang/pull/552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on pull request #1: Update Maven settings, gitignore, and add README
ameyjadiye commented on pull request #1: URL: https://github.com/apache/commons-graph/pull/1#issuecomment-643646963 @kinow , fixed conflict. looks like these changes merged. what to do with this PR? maybe you can merge fixed conflict :upside_down_face: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445379=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445379 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 16:15 Start Date: 13/Jun/20 16:15 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-636699330 [](https://coveralls.io/builds/31434245) Coverage decreased (-0.0006%) to 95.021% when pulling **b4004059c4f610bd9a1f74cf59680329852f2fa9 on XenoAmess:java8** into **a9be3ec55bb764f02acf5bb438aee7e1ab660942 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445379) Time Spent: 1h (was: 50m) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #552: (doc): Use ArrayUtils::isArrayIndexValid method in ArrayUtils::get.
coveralls commented on pull request #552: URL: https://github.com/apache/commons-lang/pull/552#issuecomment-643644329 [](https://coveralls.io/builds/31434360) Coverage increased (+0.005%) to 95.022% when pulling **88d987925d15c4bfe915772292e771126a0292e7 on nstdio:arrayutils_get** into **553a3a75dfafbf50d7efd8d6e88da71a637a2aa7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #541: [LANG-1556] use java8 lambda and Map operations.
coveralls edited a comment on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-636699330 [](https://coveralls.io/builds/31434245) Coverage decreased (-0.0006%) to 95.021% when pulling **b4004059c4f610bd9a1f74cf59680329852f2fa9 on XenoAmess:java8** into **a9be3ec55bb764f02acf5bb438aee7e1ab660942 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] nstdio opened a new pull request #552: [doc] Use ArrayUtils::isArrayIndexValid method in ArrayUtils::get.
nstdio opened a new pull request #552: URL: https://github.com/apache/commons-lang/pull/552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SANDBOX-509) Convert commons-graph Multi Module Maven Project
[ https://issues.apache.org/jira/browse/SANDBOX-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134848#comment-17134848 ] Amey Jadiye commented on SANDBOX-509: - [~erans], I have this Jira already created for modularization. I will push my changes against it. > Convert commons-graph Multi Module Maven Project > > > Key: SANDBOX-509 > URL: https://issues.apache.org/jira/browse/SANDBOX-509 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph >Reporter: Amey Jadiye >Priority: Major > > In order to make a further push towards making commons-graph graduate to > proper it's important to make graph multi-module maven project. > based on the common functionality of classes we have to categorize them and > make modules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #541: [LANG-1556] use java8 lambda and Map operations.
XenoAmess commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643639705 @garydgregory done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445376=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445376 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 15:37 Start Date: 13/Jun/20 15:37 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643639705 @garydgregory done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445376) Time Spent: 50m (was: 40m) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1557) change a Pattern to a static final field, for not letting it compile each time the function invoked.
[ https://issues.apache.org/jira/browse/LANG-1557?focusedWorklogId=445375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445375 ] ASF GitHub Bot logged work on LANG-1557: Author: ASF GitHub Bot Created on: 13/Jun/20 15:35 Start Date: 13/Jun/20 15:35 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #542: URL: https://github.com/apache/commons-lang/pull/542#issuecomment-636677473 [](https://coveralls.io/builds/31433880) Coverage decreased (-0.03%) to 95.015% when pulling **53593edc3c57e2afeeabfeec20c7c0ffd0ccec6d on XenoAmess:Pattern_to_static_** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445375) Time Spent: 0.5h (was: 20m) > change a Pattern to a static final field, for not letting it compile each > time the function invoked. > > > Key: LANG-1557 > URL: https://issues.apache.org/jira/browse/LANG-1557 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/542] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
coveralls edited a comment on pull request #542: URL: https://github.com/apache/commons-lang/pull/542#issuecomment-636677473 [](https://coveralls.io/builds/31433880) Coverage decreased (-0.03%) to 95.015% when pulling **53593edc3c57e2afeeabfeec20c7c0ffd0ccec6d on XenoAmess:Pattern_to_static_** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1528) replaceEachRepeatedly gives IllegalStateException
[
https://issues.apache.org/jira/browse/LANG-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-1528.
---
Fix Version/s: 3.11
Resolution: Fixed
> replaceEachRepeatedly gives IllegalStateException
> -
>
> Key: LANG-1528
> URL: https://issues.apache.org/jira/browse/LANG-1528
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
>Affects Versions: 3.8, 3.9, 3.8.1
>Reporter: jimmy
>Priority: Minor
> Labels: easyfix
> Fix For: 3.11
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Â
> ChurchilllaanTest1 fails, ChurchilllaanTest2 doesn't, why?
> Please allow the ttl to be overridden.
> {code:java}
> @Test
> public void ChurchilllaanTest1() {
> String input = "Churchilllaan";
> String[][] replaceMap = new String[][] {
> { "llaan", "laan" },
> };
>
> String output = StringUtils.replaceEachRepeatedly(
> input,
> getColumn(0, replaceMap),
> getColumn(1, replaceMap));
> Assert.assertEquals("Churchilaan", output);
> }
> @Test
> public void ChurchilllaanTest2() {
> String input = "Churchilllaan";
> String[][] replaceMap = new String[][] {
> { "llaan", "laan" },
> { "C", "c" },
> };
>
> String output = StringUtils.replaceEachRepeatedly(
> input,
> getColumn(0, replaceMap),
> getColumn(1, replaceMap));
> Assert.assertEquals("churchilaan", output);
> }
> private String[] getColumn(int colIndex, String[][] from) {
> return Arrays.stream(from).map(x ->
> x[colIndex]).toArray(String[]::new);
> }
> {code}
> Â
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1528) replaceEachRepeatedly gives IllegalStateException
[
https://issues.apache.org/jira/browse/LANG-1528?focusedWorklogId=445374=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445374
]
ASF GitHub Bot logged work on LANG-1528:
Author: ASF GitHub Bot
Created on: 13/Jun/20 15:31
Start Date: 13/Jun/20 15:31
Worklog Time Spent: 10m
Work Description: garydgregory merged pull request #505:
URL: https://github.com/apache/commons-lang/pull/505
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 445374)
Time Spent: 40m (was: 0.5h)
> replaceEachRepeatedly gives IllegalStateException
> -
>
> Key: LANG-1528
> URL: https://issues.apache.org/jira/browse/LANG-1528
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
>Affects Versions: 3.8, 3.9, 3.8.1
>Reporter: jimmy
>Priority: Minor
> Labels: easyfix
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Â
> ChurchilllaanTest1 fails, ChurchilllaanTest2 doesn't, why?
> Please allow the ttl to be overridden.
> {code:java}
> @Test
> public void ChurchilllaanTest1() {
> String input = "Churchilllaan";
> String[][] replaceMap = new String[][] {
> { "llaan", "laan" },
> };
>
> String output = StringUtils.replaceEachRepeatedly(
> input,
> getColumn(0, replaceMap),
> getColumn(1, replaceMap));
> Assert.assertEquals("Churchilaan", output);
> }
> @Test
> public void ChurchilllaanTest2() {
> String input = "Churchilllaan";
> String[][] replaceMap = new String[][] {
> { "llaan", "laan" },
> { "C", "c" },
> };
>
> String output = StringUtils.replaceEachRepeatedly(
> input,
> getColumn(0, replaceMap),
> getColumn(1, replaceMap));
> Assert.assertEquals("churchilaan", output);
> }
> private String[] getColumn(int colIndex, String[][] from) {
> return Arrays.stream(from).map(x ->
> x[colIndex]).toArray(String[]::new);
> }
> {code}
> Â
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #505: [LANG-1528] StringUtils.replaceEachRepeatedly gives IllegalStateException
garydgregory merged pull request #505: URL: https://github.com/apache/commons-lang/pull/505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1559) Convert Sting to StringBuilder in some test code.
[ https://issues.apache.org/jira/browse/LANG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1559. --- Fix Version/s: 3.11 Resolution: Fixed > Convert Sting to StringBuilder in some test code. > - > > Key: LANG-1559 > URL: https://issues.apache.org/jira/browse/LANG-1559 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/544] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1559) Convert Sting to StringBuilder in some test code.
[ https://issues.apache.org/jira/browse/LANG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1559: -- Summary: Convert Sting to StringBuilder in some test code. (was: convert Sting to StringBuilder in some test code.) > Convert Sting to StringBuilder in some test code. > - > > Key: LANG-1559 > URL: https://issues.apache.org/jira/browse/LANG-1559 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/544] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #544: [LANG-1559] convert Sting to StringBuilder in some test code.
garydgregory merged pull request #544: URL: https://github.com/apache/commons-lang/pull/544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1559) convert Sting to StringBuilder in some test code.
[ https://issues.apache.org/jira/browse/LANG-1559?focusedWorklogId=445373=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445373 ] ASF GitHub Bot logged work on LANG-1559: Author: ASF GitHub Bot Created on: 13/Jun/20 15:19 Start Date: 13/Jun/20 15:19 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #544: URL: https://github.com/apache/commons-lang/pull/544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445373) Remaining Estimate: 0h Time Spent: 10m > convert Sting to StringBuilder in some test code. > - > > Key: LANG-1559 > URL: https://issues.apache.org/jira/browse/LANG-1559 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/544] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1558) Simplify if as some conditions are covered by othersÂ
[ https://issues.apache.org/jira/browse/LANG-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1558: -- Summary: Simplify if as some conditions are covered by others (was: simplify if as some conditions are covered by others ) > Simplify if as some conditions are covered by others > - > > Key: LANG-1558 > URL: https://issues.apache.org/jira/browse/LANG-1558 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/543] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1558) Simplify if as some conditions are covered by othersÂ
[ https://issues.apache.org/jira/browse/LANG-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1558. --- Fix Version/s: 3.11 Resolution: Fixed > Simplify if as some conditions are covered by others > - > > Key: LANG-1558 > URL: https://issues.apache.org/jira/browse/LANG-1558 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/543] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1558) simplify if as some conditions are covered by othersÂ
[ https://issues.apache.org/jira/browse/LANG-1558?focusedWorklogId=445372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445372 ] ASF GitHub Bot logged work on LANG-1558: Author: ASF GitHub Bot Created on: 13/Jun/20 15:18 Start Date: 13/Jun/20 15:18 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #543: URL: https://github.com/apache/commons-lang/pull/543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445372) Remaining Estimate: 0h Time Spent: 10m > simplify if as some conditions are covered by others > - > > Key: LANG-1558 > URL: https://issues.apache.org/jira/browse/LANG-1558 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/543] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #543: [LANG-1558] Simplify if as some conditions are covered by others
garydgregory merged pull request #543: URL: https://github.com/apache/commons-lang/pull/543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"
[
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134838#comment-17134838
]
Amey Jadiye commented on SANDBOX-510:
-
{quote}
The error in testSudoku disappears when changing this line to
private Set colors = createColorsList( 13 );
Caveat: I have no idea whether this is the correct fix.
{quote}
Yes, because the greedy algorithm is not so optimized that it will use exactly
9 colors in sudoku, it's able to resolve problem with 13 though.
The backtracking algorithm is optimized to fix sudoku problem with exactly 9
colors, which is expected.
> Unit tests failures in recently migrated "Commons Graph"
>
>
> Key: SANDBOX-510
> URL: https://issues.apache.org/jira/browse/SANDBOX-510
> Project: Commons Sandbox
> Issue Type: Task
> Components: Graph
>Reporter: Gilles Sadowski
>Priority: Major
> Labels: unit-test
>
> Code has not been worked on for more than 7 years.
> A recent spike of interest entailed a move to a [git
> repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git].
> [A few unit tests
> fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (LANG-1555) Ignored exception `ignored`, should not be called so
[ https://issues.apache.org/jira/browse/LANG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1555. --- Fix Version/s: 3.11 Resolution: Fixed > Ignored exception `ignored`, should not be called so > > > Key: LANG-1555 > URL: https://issues.apache.org/jira/browse/LANG-1555 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1555) Ignored exception `ignored`, should not be called so
[ https://issues.apache.org/jira/browse/LANG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1555: -- Summary: Ignored exception `ignored`, should not be called so (was: we named a not ignored exception `ignored`, and I changed it to `e`) > Ignored exception `ignored`, should not be called so > > > Key: LANG-1555 > URL: https://issues.apache.org/jira/browse/LANG-1555 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #540: [LANG-1555] Ignored exception `ignored`, should not be called so
garydgregory merged pull request #540: URL: https://github.com/apache/commons-lang/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1555) we named a not ignored exception `ignored`, and I changed it to `e`
[ https://issues.apache.org/jira/browse/LANG-1555?focusedWorklogId=445371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445371 ] ASF GitHub Bot logged work on LANG-1555: Author: ASF GitHub Bot Created on: 13/Jun/20 15:14 Start Date: 13/Jun/20 15:14 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #540: URL: https://github.com/apache/commons-lang/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445371) Remaining Estimate: 0h Time Spent: 10m > we named a not ignored exception `ignored`, and I changed it to `e` > --- > > Key: LANG-1555 > URL: https://issues.apache.org/jira/browse/LANG-1555 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/540|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1554) Fix typos
[ https://issues.apache.org/jira/browse/LANG-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1554: -- Summary: Fix typos (was: fix typos) > Fix typos > - > > Key: LANG-1554 > URL: https://issues.apache.org/jira/browse/LANG-1554 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/539] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1554) Fix typos
[ https://issues.apache.org/jira/browse/LANG-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1554. --- Fix Version/s: 3.11 Resolution: Fixed > Fix typos > - > > Key: LANG-1554 > URL: https://issues.apache.org/jira/browse/LANG-1554 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/539] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #539: [LANG-1554] Fix typos
garydgregory merged pull request #539: URL: https://github.com/apache/commons-lang/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1557) change a Pattern to a static final field, for not letting it compile each time the function invoked.
[
https://issues.apache.org/jira/browse/LANG-1557?focusedWorklogId=445367=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445367
]
ASF GitHub Bot logged work on LANG-1557:
Author: ASF GitHub Bot
Created on: 13/Jun/20 15:11
Start Date: 13/Jun/20 15:11
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439746094
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String
stripChars) {
return stripEnd(str, stripChars);
}
+private static final Pattern STRIP_ACCENTS_PATTERN =
Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
@garydgregory
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 445367)
Time Spent: 20m (was: 10m)
> change a Pattern to a static final field, for not letting it compile each
> time the function invoked.
>
>
> Key: LANG-1557
> URL: https://issues.apache.org/jira/browse/LANG-1557
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/542]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1554) fix typos
[ https://issues.apache.org/jira/browse/LANG-1554?focusedWorklogId=445370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445370 ] ASF GitHub Bot logged work on LANG-1554: Author: ASF GitHub Bot Created on: 13/Jun/20 15:11 Start Date: 13/Jun/20 15:11 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #539: URL: https://github.com/apache/commons-lang/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445370) Remaining Estimate: 0h Time Spent: 10m > fix typos > - > > Key: LANG-1554 > URL: https://issues.apache.org/jira/browse/LANG-1554 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/539] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
XenoAmess commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439746094
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String
stripChars) {
return stripEnd(str, stripChars);
}
+private static final Pattern STRIP_ACCENTS_PATTERN =
Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
@garydgregory
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (LANG-1552) Change from addAll to constructors for some List.
[ https://issues.apache.org/jira/browse/LANG-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1552. --- Fix Version/s: 3.11 Resolution: Fixed > Change from addAll to constructors for some List. > - > > Key: LANG-1552 > URL: https://issues.apache.org/jira/browse/LANG-1552 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/536/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1552) Change from addAll to constructors for some List.
[ https://issues.apache.org/jira/browse/LANG-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1552: -- Summary: Change from addAll to constructors for some List. (was: change from addAll to constructors for some List.) > Change from addAll to constructors for some List. > - > > Key: LANG-1552 > URL: https://issues.apache.org/jira/browse/LANG-1552 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/536/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #536: [LANG-1552] Change from addAll to constructors for some List
garydgregory merged pull request #536: URL: https://github.com/apache/commons-lang/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1552) change from addAll to constructors for some List.
[ https://issues.apache.org/jira/browse/LANG-1552?focusedWorklogId=445366=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445366 ] ASF GitHub Bot logged work on LANG-1552: Author: ASF GitHub Bot Created on: 13/Jun/20 15:08 Start Date: 13/Jun/20 15:08 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #536: URL: https://github.com/apache/commons-lang/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445366) Remaining Estimate: 0h Time Spent: 10m > change from addAll to constructors for some List. > - > > Key: LANG-1552 > URL: https://issues.apache.org/jira/browse/LANG-1552 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/536/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1553) Change array style from `int a[]` to `int[] a`
[ https://issues.apache.org/jira/browse/LANG-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1553: -- Summary: Change array style from `int a[]` to `int[] a` (was: change array style from `int a[]` to `int[] a`) > Change array style from `int a[]` to `int[] a` > -- > > Key: LANG-1553 > URL: https://issues.apache.org/jira/browse/LANG-1553 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1553) Change array style from `int a[]` to `int[] a`
[ https://issues.apache.org/jira/browse/LANG-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1553. --- Fix Version/s: 3.11 Resolution: Fixed > Change array style from `int a[]` to `int[] a` > -- > > Key: LANG-1553 > URL: https://issues.apache.org/jira/browse/LANG-1553 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1553) change array style from `int a[]` to `int[] a`
[ https://issues.apache.org/jira/browse/LANG-1553?focusedWorklogId=445365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445365 ] ASF GitHub Bot logged work on LANG-1553: Author: ASF GitHub Bot Created on: 13/Jun/20 15:06 Start Date: 13/Jun/20 15:06 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #537: URL: https://github.com/apache/commons-lang/pull/537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445365) Remaining Estimate: 0h Time Spent: 10m > change array style from `int a[]` to `int[] a` > -- > > Key: LANG-1553 > URL: https://issues.apache.org/jira/browse/LANG-1553 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/537|https://github.com/apache/commons-lang/pull/536] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1560) Refine Javadoc
[ https://issues.apache.org/jira/browse/LANG-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1560: -- Summary: Refine Javadoc (was: refine javadoc) > Refine Javadoc > -- > > Key: LANG-1560 > URL: https://issues.apache.org/jira/browse/LANG-1560 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/545/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #537: [LANG-1553] Change array style from `int a[]` to `int[] a`
garydgregory merged pull request #537: URL: https://github.com/apache/commons-lang/pull/537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1560) Refine Javadoc
[ https://issues.apache.org/jira/browse/LANG-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1560. --- Fix Version/s: 3.11 Resolution: Fixed > Refine Javadoc > -- > > Key: LANG-1560 > URL: https://issues.apache.org/jira/browse/LANG-1560 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/545/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1560) refine javadoc
[ https://issues.apache.org/jira/browse/LANG-1560?focusedWorklogId=445364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445364 ] ASF GitHub Bot logged work on LANG-1560: Author: ASF GitHub Bot Created on: 13/Jun/20 15:04 Start Date: 13/Jun/20 15:04 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #545: URL: https://github.com/apache/commons-lang/pull/545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445364) Remaining Estimate: 0h Time Spent: 10m > refine javadoc > -- > > Key: LANG-1560 > URL: https://issues.apache.org/jira/browse/LANG-1560 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/545/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #545: [LANG-1560] Refine Javadoc
garydgregory merged pull request #545: URL: https://github.com/apache/commons-lang/pull/545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445363 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 15:01 Start Date: 13/Jun/20 15:01 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643635259 Please resolve conflicts, rebase on master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445363) Time Spent: 40m (was: 0.5h) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on a change in pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
garydgregory commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439745405
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String
stripChars) {
return stripEnd(str, stripChars);
}
+private static final Pattern STRIP_ACCENTS_PATTERN =
Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
All constants live at the top of the file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #541: [LANG-1556] use java8 lambda and Map operations.
garydgregory commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643635259 Please resolve conflicts, rebase on master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1557) change a Pattern to a static final field, for not letting it compile each time the function invoked.
[
https://issues.apache.org/jira/browse/LANG-1557?focusedWorklogId=445361=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445361
]
ASF GitHub Bot logged work on LANG-1557:
Author: ASF GitHub Bot
Created on: 13/Jun/20 15:00
Start Date: 13/Jun/20 15:00
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439745405
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String
stripChars) {
return stripEnd(str, stripChars);
}
+private static final Pattern STRIP_ACCENTS_PATTERN =
Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
All constants live at the top of the file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 445361)
Remaining Estimate: 0h
Time Spent: 10m
> change a Pattern to a static final field, for not letting it compile each
> time the function invoked.
>
>
> Key: LANG-1557
> URL: https://issues.apache.org/jira/browse/LANG-1557
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/542]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (LANG-1564) Use Collections.singletonList insteadof Arrays.asList when there be only one element.
[ https://issues.apache.org/jira/browse/LANG-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1564. --- Fix Version/s: 3.11 Resolution: Fixed > Use Collections.singletonList insteadof Arrays.asList when there be only one > element. > - > > Key: LANG-1564 > URL: https://issues.apache.org/jira/browse/LANG-1564 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/549/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1564) Use Collections.singletonList insteadof Arrays.asList when there be only one element.
[ https://issues.apache.org/jira/browse/LANG-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1564: -- Summary: Use Collections.singletonList insteadof Arrays.asList when there be only one element. (was: use Collections.singletonList insteadof Arrays.asList when there be only one element.) > Use Collections.singletonList insteadof Arrays.asList when there be only one > element. > - > > Key: LANG-1564 > URL: https://issues.apache.org/jira/browse/LANG-1564 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/549/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1564) use Collections.singletonList insteadof Arrays.asList when there be only one element.
[ https://issues.apache.org/jira/browse/LANG-1564?focusedWorklogId=445360=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445360 ] ASF GitHub Bot logged work on LANG-1564: Author: ASF GitHub Bot Created on: 13/Jun/20 14:58 Start Date: 13/Jun/20 14:58 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #549: URL: https://github.com/apache/commons-lang/pull/549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445360) Remaining Estimate: 0h Time Spent: 10m > use Collections.singletonList insteadof Arrays.asList when there be only one > element. > - > > Key: LANG-1564 > URL: https://issues.apache.org/jira/browse/LANG-1564 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/549/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #549: [LANG-1564] use Collections.singletonList insteadof Arrays.asList when there be only one element.
garydgregory merged pull request #549: URL: https://github.com/apache/commons-lang/pull/549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #541: [LANG-1556] use java8 lambda and Map operations.
garydgregory closed pull request #541: URL: https://github.com/apache/commons-lang/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #541: [LANG-1556] use java8 lambda and Map operations.
garydgregory commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643634563 Rebase on master please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445359 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 14:56 Start Date: 13/Jun/20 14:56 Worklog Time Spent: 10m Work Description: XenoAmess opened a new pull request #541: URL: https://github.com/apache/commons-lang/pull/541 use java8 lambda and Map operations. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445359) Time Spent: 0.5h (was: 20m) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445357 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 14:56 Start Date: 13/Jun/20 14:56 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #541: URL: https://github.com/apache/commons-lang/pull/541#issuecomment-643634563 Rebase on master please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445357) Remaining Estimate: 0h Time Spent: 10m > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1556) use java8 lambda and Map operations.
[ https://issues.apache.org/jira/browse/LANG-1556?focusedWorklogId=445358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445358 ] ASF GitHub Bot logged work on LANG-1556: Author: ASF GitHub Bot Created on: 13/Jun/20 14:56 Start Date: 13/Jun/20 14:56 Worklog Time Spent: 10m Work Description: garydgregory closed pull request #541: URL: https://github.com/apache/commons-lang/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445358) Time Spent: 20m (was: 10m) > use java8 lambda and Map operations. > > > Key: LANG-1556 > URL: https://issues.apache.org/jira/browse/LANG-1556 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/541 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SANDBOX-510) Unit tests failures in recently migrated "Commons Graph"
[ https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134825#comment-17134825 ] Gilles Sadowski commented on SANDBOX-510: - > review I did: See [ML|https://markmail.org/message/54fwe6rk7z63wtjl]. > Unit tests failures in recently migrated "Commons Graph" > > > Key: SANDBOX-510 > URL: https://issues.apache.org/jira/browse/SANDBOX-510 > Project: Commons Sandbox > Issue Type: Task > Components: Graph >Reporter: Gilles Sadowski >Priority: Major > Labels: unit-test > > Code has not been worked on for more than 7 years. > A recent spike of interest entailed a move to a [git > repository|https://gitbox.apache.org/repos/asf?p=commons-graph.git]. > [A few unit tests > fail|https://travis-ci.org/github/apache/commons-graph/builds/697810911]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1562) Use Math.max and min
[ https://issues.apache.org/jira/browse/LANG-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1562: -- Summary: Use Math.max and min (was: use Math.max and min) > Use Math.max and min > > > Key: LANG-1562 > URL: https://issues.apache.org/jira/browse/LANG-1562 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/547/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (LANG-1562) use Math.max and min
[ https://issues.apache.org/jira/browse/LANG-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1562. --- Fix Version/s: 3.11 Resolution: Fixed > use Math.max and min > > > Key: LANG-1562 > URL: https://issues.apache.org/jira/browse/LANG-1562 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 3.11 > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/547/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #547: [LANG-1562] use Math.max and min
garydgregory merged pull request #547: URL: https://github.com/apache/commons-lang/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1562) use Math.max and min
[ https://issues.apache.org/jira/browse/LANG-1562?focusedWorklogId=445356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445356 ] ASF GitHub Bot logged work on LANG-1562: Author: ASF GitHub Bot Created on: 13/Jun/20 14:50 Start Date: 13/Jun/20 14:50 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #547: URL: https://github.com/apache/commons-lang/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445356) Remaining Estimate: 0h Time Spent: 10m > use Math.max and min > > > Key: LANG-1562 > URL: https://issues.apache.org/jira/browse/LANG-1562 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/547/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
