[jira] [Created] (VFS-775) SFTP Uplaod is successfull but getting Exceptions
Akhil Surapuram created VFS-775: --- Summary: SFTP Uplaod is successfull but getting Exceptions Key: VFS-775 URL: https://issues.apache.org/jira/browse/VFS-775 Project: Commons VFS Issue Type: Bug Affects Versions: 2.4 Reporter: Akhil Surapuram ache.commons.vfs2.FileSystemException: Could not determine the type of file "sftp://;. at org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1347) at org.apache.commons.vfs2.provider.AbstractFileObject.exists(AbstractFileObject.java:945) at org.apache.commons.vfs2.util.FileObjectUtils.exists(FileObjectUtils.java:45) at org.apache.commons.vfs2.provider.AbstractFileObject.copyFrom(AbstractFileObject.java:285) Caused by: org.apache.commons.vfs2.FileSystemException: Could not connect to SFTP server at "sftp://259874_U:***@sftp.cdslindia.com/;. at org.apache.commons.vfs2.provider.sftp.SftpFileSystem.getChannel(SftpFileSystem.java:151) at org.apache.commons.vfs2.provider.sftp.SftpFileObject.statSelf(SftpFileObject.java:114) at org.apache.commons.vfs2.provider.sftp.SftpFileObject.doGetType(SftpFileObject.java:76) at org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1341) ... 40 common frames omitted Caused by: com.jcraft.jsch.JSchException: session is down at com.jcraft.jsch.Session.openChannel(Session.java:861) at org.apache.commons.vfs2.provider.sftp.SftpFileSystem.getChannel(SftpFileSystem.java:124) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMPRESS-538) ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64 Extended Information Extra Field' even when zip64 is not required.
[
https://issues.apache.org/jira/browse/COMPRESS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pritesh updated COMPRESS-538:
-
Description:
When creating a zip file using
[ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
constructor each entry get an extra `Zip64ExtendedInformationExtraField`
header which shouldn't be there.
The issue can be reproduced using below code sample
{code:java}
public static void main(String[] args) throws IOException {
// Create file
final File file = File.createTempFile("apache_", ".zip");
try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
zos.closeArchiveEntry();
}
// List Headers File
final ZipFile zipFile = new ZipFile(file);
final Enumeration entries =
zipFile.getEntries();
while (entries.hasMoreElements()) {
final ZipArchiveEntry entry = entries.nextElement();
for (ZipExtraField zipExtraField : entry.getExtraFields()) {
System.out.println("EntryName:" + entry.getName() + " Header:
"+ zipExtraField.getHeaderId().getValue()); // Header shouldn't be present.
}
}
}
{code}
was:
When creating a zip file using
[ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
constructor each entry get an extra `Zip64ExtendedInformationExtraField`
header which shouldn't be there.
{code:java}
public static void main(String[] args) throws IOException {
// Create file
final File file = File.createTempFile("apache_", ".zip");
try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
zos.closeArchiveEntry();
}
// List Headers File
final ZipFile zipFile = new ZipFile(file);
final Enumeration entries =
zipFile.getEntries();
while (entries.hasMoreElements()) {
final ZipArchiveEntry entry = entries.nextElement();
for (ZipExtraField zipExtraField : entry.getExtraFields()) {
System.out.println("EntryName:" + entry.getName() + " Header:
"+ zipExtraField.getHeaderId().getValue());
}
}
}
{code}
> ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64
> Extended Information Extra Field' even when zip64 is not required.
> --
>
> Key: COMPRESS-538
> URL: https://issues.apache.org/jira/browse/COMPRESS-538
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.8
>Reporter: Pritesh
>Priority: Major
>
> When creating a zip file using
> [ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
> constructor each entry get an extra `Zip64ExtendedInformationExtraField`
> header which shouldn't be there.
>
> The issue can be reproduced using below code sample
> {code:java}
> public static void main(String[] args) throws IOException {
> // Create file
> final File file = File.createTempFile("apache_", ".zip");
> try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
> zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
> zos.closeArchiveEntry();
> }
> // List Headers File
> final ZipFile zipFile = new ZipFile(file);
> final Enumeration entries =
> zipFile.getEntries();
> while (entries.hasMoreElements()) {
> final ZipArchiveEntry entry = entries.nextElement();
> for (ZipExtraField zipExtraField : entry.getExtraFields()) {
> System.out.println("EntryName:" + entry.getName() + " Header:
> "+ zipExtraField.getHeaderId().getValue()); // Header shouldn't be present.
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (COMPRESS-538) ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64 Extended Information Extra Field' even when zip64 is not required.
[
https://issues.apache.org/jira/browse/COMPRESS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pritesh updated COMPRESS-538:
-
Summary: ZipEntry created using ZipArchiveOutputStream(File) constructor
adds 'ZIP64 Extended Information Extra Field' even when zip64 is not required.
(was: Zip entry created using ZipArchiveOutputStream(File) constructor adds
Zip64ExtendedInformationExtraField even when zip64 is not required.)
> ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64
> Extended Information Extra Field' even when zip64 is not required.
> --
>
> Key: COMPRESS-538
> URL: https://issues.apache.org/jira/browse/COMPRESS-538
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.8
>Reporter: Pritesh
>Priority: Major
>
> When creating a zip file using
> [ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
> constructor each entry get an extra `Zip64ExtendedInformationExtraField`
> header which shouldn't be there.
> {code:java}
> public static void main(String[] args) throws IOException {
> // Create file
> final File file = File.createTempFile("apache_", ".zip");
> try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
> zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
> zos.closeArchiveEntry();
> }
> // List Headers File
> final ZipFile zipFile = new ZipFile(file);
> final Enumeration entries =
> zipFile.getEntries();
> while (entries.hasMoreElements()) {
> final ZipArchiveEntry entry = entries.nextElement();
> for (ZipExtraField zipExtraField : entry.getExtraFields()) {
> System.out.println("EntryName:" + entry.getName() + " Header:
> "+ zipExtraField.getHeaderId().getValue());
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-538) ZipArchiveOutputStream with File constructor adds Zip64ExtendedInformationExtraField even when zip64 is not required.
Pritesh created COMPRESS-538:
Summary: ZipArchiveOutputStream with File constructor adds
Zip64ExtendedInformationExtraField even when zip64 is not required.
Key: COMPRESS-538
URL: https://issues.apache.org/jira/browse/COMPRESS-538
Project: Commons Compress
Issue Type: Bug
Components: Archivers
Affects Versions: 1.8
Reporter: Pritesh
When creating a zip file using
[ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
constructor each entry get an extra `Zip64ExtendedInformationExtraField`
header which shouldn't be there.
{code:java}
public static void main(String[] args) throws IOException {
// Create file
final File file = File.createTempFile("apache_", ".zip");
try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
zos.closeArchiveEntry();
}
// List Headers File
final ZipFile zipFile = new ZipFile(file);
final Enumeration entries =
zipFile.getEntries();
while (entries.hasMoreElements()) {
final ZipArchiveEntry entry = entries.nextElement();
for (ZipExtraField zipExtraField : entry.getExtraFields()) {
System.out.println("EntryName:" + entry.getName() + " Header:
"+ zipExtraField.getHeaderId().getValue());
}
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (COMPRESS-538) Zip entry created using ZipArchiveOutputStream(File) constructor adds Zip64ExtendedInformationExtraField even when zip64 is not required.
[
https://issues.apache.org/jira/browse/COMPRESS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pritesh updated COMPRESS-538:
-
Summary: Zip entry created using ZipArchiveOutputStream(File) constructor
adds Zip64ExtendedInformationExtraField even when zip64 is not required. (was:
ZipArchiveOutputStream with File constructor adds
Zip64ExtendedInformationExtraField even when zip64 is not required.)
> Zip entry created using ZipArchiveOutputStream(File) constructor adds
> Zip64ExtendedInformationExtraField even when zip64 is not required.
> -
>
> Key: COMPRESS-538
> URL: https://issues.apache.org/jira/browse/COMPRESS-538
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.8
>Reporter: Pritesh
>Priority: Major
>
> When creating a zip file using
> [ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
> constructor each entry get an extra `Zip64ExtendedInformationExtraField`
> header which shouldn't be there.
> {code:java}
> public static void main(String[] args) throws IOException {
> // Create file
> final File file = File.createTempFile("apache_", ".zip");
> try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
> zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
> zos.closeArchiveEntry();
> }
> // List Headers File
> final ZipFile zipFile = new ZipFile(file);
> final Enumeration entries =
> zipFile.getEntries();
> while (entries.hasMoreElements()) {
> final ZipArchiveEntry entry = entries.nextElement();
> for (ZipExtraField zipExtraField : entry.getExtraFields()) {
> System.out.println("EntryName:" + entry.getName() + " Header:
> "+ zipExtraField.getHeaderId().getValue());
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
[
https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135656#comment-17135656
]
chenshuming edited comment on VFS-396 at 6/16/20, 2:50 AM:
---
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
{code:java}
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
{code}
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "afs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
was (Author: csmdev):
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
{code:java}
// code placeholder
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
{code}
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "afs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
> RAM FileSystem allows the file system size to exceed the max size limit.
>
>
> Key: VFS-396
> URL: https://issues.apache.org/jira/browse/VFS-396
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: All
>Reporter: Rupesh Kumar
>Priority: Major
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to
> its outputstream, there is a check in place for ensuring that file system
> size does not exceed the max limit set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call
> file.resize(newSize)
> And in the RamFileObject.resize(), there is a check
> if (fs.size() + newSize - this.size() > maxSize)
> {
> throw new IOException("FileSystem capacity (" + maxSize
> + ") exceeded.");
> }
> This check is wrong.
> Consider this case of a new file system where the file system size is set to
> 5 MB and I am trying to create a file of 10 MB in the RAM file system. the
> file is being written in the chunk of 8 kb. For every resize check, fs.size()
> would be 0 and (newsize - this.size()) would be 8 kb and therefore the check
> never passes.
> It could have been correct if the "old size" was locked down to the size
> that was registered with the file system but the old size (this.size()) keeps
> changing at every write. Thus the difference in newSize and this.size() would
> always be the chunk size (typically 8 kb) and therefore no exception would be
> thrown ever.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (VFS-226) resolving of relative layers does not work correctly
[
https://issues.apache.org/jira/browse/VFS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134616#comment-17134616
]
chenshuming edited comment on VFS-226 at 6/16/20, 2:45 AM:
---
Maybe you can try this :
{code:java}
public void test() throws IOException {
FileSystemManager manager = VFS.getManager();
try (FileObject f1 = manager.resolveFile(new
File("src/test/resources/test-data").getAbsolutePath());
FileObject f2 = f1.resolveFile("test.zip");
FileObject f3 = manager.createFileSystem("zip",f2);
) {
System.out.println(f3.getName());
}
}
{code}
I think the FileObject.resolveFile(String) method don't accept scheme in
parameter.
In this case, I think we can call FileSystemManager.create(String, FileObject)
if we want to open a zip file use "zip" scheme.
was (Author: csmdev):
Maybe you can try this :
{code:java}
public void test() throws IOException {
FileSystemManager manager = VFS.getManager();
try (FileObject f1 = manager.resolveFile(new
File("src/test/resources/test-data").getAbsolutePath());
FileObject f2 = f1.resolveFile("test.zip");
FileObject f3 = manager.createFileSystem("zip",f2);
) {
System.out.println(f3.getName());
}
}
{code}
I think the FileObject.resolveFile(String) method don't accept scheme in
parameter.
In this case, I think we can call FileSystemManager.create(String, FileObject)
if we want to open a zip file use "zip" scheme.
> resolving of relative layers does not work correctly
>
>
> Key: VFS-226
> URL: https://issues.apache.org/jira/browse/VFS-226
> Project: Commons VFS
> Issue Type: Bug
> Environment: Windows XP, Java 1.4
>Reporter: Frank van der Kleij
>Priority: Major
>
> When I try to resolve a relative layered filesystem I get the error
> Could not find file with URI "rules.zip" because it is a relative path, and
> no base URI was provided.
> I used the method StandardFileSystemManager.resolveFile(FileObject, String)
> where the FileObject is the directory where the file rules.zip is located
> (file:///d:/temp) and for the path I use 'zip:rules.zip'.
> Since I pass a base file I would think it should be able to find the zip file.
> When debugging I found the following:
> LayeredFileNameParser.parseUri(VfsComponentContext, FileName, String) does
> one line 54:
> rootUri = context.parseURI(rootUriName);
> I believe that in this call it loses the reference to the base file I passed .
> The context forwards to the FileSystemManager.resolveURI(String)
> which throws the exception because its base file isn't set:
> if (baseFile == null)
> {
> throw new FileSystemException("vfs.impl/find-rel-file.error", uri);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (VFS-226) resolving of relative layers does not work correctly
[
https://issues.apache.org/jira/browse/VFS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134616#comment-17134616
]
chenshuming edited comment on VFS-226 at 6/16/20, 2:45 AM:
---
Maybe you can try this :
{code:java}
public void test() throws IOException {
FileSystemManager manager = VFS.getManager();
try (FileObject f1 = manager.resolveFile(new
File("src/test/resources/test-data").getAbsolutePath());
FileObject f2 = f1.resolveFile("test.zip");
FileObject f3 = manager.createFileSystem("zip",f2);
) {
System.out.println(f3.getName());
}
}
{code}
I think the FileObject.resolveFile(String) method don't accept scheme in
parameter.
In this case, I think we can call FileSystemManager.create(String, FileObject)
if we want to open a zip file use "zip" scheme.
was (Author: csmdev):
Maybe you can try this :
```
public void test() throws IOException {
FileSystemManager manager = VFS.getManager();
try (FileObject f1 = manager.resolveFile(new
File("src/test/resources/test-data").getAbsolutePath());
FileObject f2 = f1.resolveFile("test.zip");
FileObject f3 = manager.createFileSystem("zip",f2);
) {
System.out.println(f3.getName());
}
}
```
I think the FileObject.resolveFile(String) method don't accept scheme in
parameter.
In this case, I think we can call FileSystemManager.create(String, FileObject)
if we want to open a zip file use "zip" scheme.
> resolving of relative layers does not work correctly
>
>
> Key: VFS-226
> URL: https://issues.apache.org/jira/browse/VFS-226
> Project: Commons VFS
> Issue Type: Bug
> Environment: Windows XP, Java 1.4
>Reporter: Frank van der Kleij
>Priority: Major
>
> When I try to resolve a relative layered filesystem I get the error
> Could not find file with URI "rules.zip" because it is a relative path, and
> no base URI was provided.
> I used the method StandardFileSystemManager.resolveFile(FileObject, String)
> where the FileObject is the directory where the file rules.zip is located
> (file:///d:/temp) and for the path I use 'zip:rules.zip'.
> Since I pass a base file I would think it should be able to find the zip file.
> When debugging I found the following:
> LayeredFileNameParser.parseUri(VfsComponentContext, FileName, String) does
> one line 54:
> rootUri = context.parseURI(rootUriName);
> I believe that in this call it loses the reference to the base file I passed .
> The context forwards to the FileSystemManager.resolveURI(String)
> which throws the exception because its base file isn't set:
> if (baseFile == null)
> {
> throw new FileSystemException("vfs.impl/find-rel-file.error", uri);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1546) remove and and use inherited values from commons-parent
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446245 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 02:37 Start Date: 16/Jun/20 02:37 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644495079 @kinow Many thanks for not let this become another 1-year-long pr. (only two more weeks from being that lol) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446245) Time Spent: 2h (was: 1h 50m) > remove and and use inherited values from > commons-parent > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1546) remove and and use inherited values from commons-parent
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446243 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 02:36 Start Date: 16/Jun/20 02:36 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644495079 @kinow Many thanks for not let this become another 1-year-long pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446243) Time Spent: 1h 50m (was: 1h 40m) > remove and and use inherited values from > commons-parent > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #428: [LANG-1546] remove and and use inherited values from commons-parent
XenoAmess commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644495079 @kinow Many thanks for not let this become another 1-year-long pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #428: [LANG-1546] remove and and use inherited values from commons-parent
XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644495079 @kinow Many thanks for not let this become another 1-year-long pr. (only two more weeks from being that lol) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1546) remove and and use inherited values from commons-parent
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved LANG-1546. -- Resolution: Fixed > remove and and use inherited values from > commons-parent > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1546) remove and and use inherited values from commons-parent
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446233=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446233 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 02:23 Start Date: 16/Jun/20 02:23 Worklog Time Spent: 10m Work Description: kinow closed pull request #428: URL: https://github.com/apache/commons-lang/pull/428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446233) Time Spent: 1h 40m (was: 1.5h) > remove and and use inherited values from > commons-parent > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] kinow closed pull request #428: [LANG-1546] remove and and use inherited values from commons-parent
kinow closed pull request #428: URL: https://github.com/apache/commons-lang/pull/428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (LANG-1546) remove and and use inherited values from commons-parent
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1546: - Summary: remove and and use inherited values from commons-parent (was: delete ) > remove and and use inherited values from > commons-parent > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] kinow commented on pull request #428: [LANG-1546] change to
kinow commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644488157 I'll 1. rebase as there are 4 commits in this PR (which is fine in other cases, but here we want to only remove 2 lines, so having less commits makes it easier for devs that need to rollback/rebase changes for debugging/troubleshooting/etc) 2. add changes.xml 3. update JIRA fixed/affected version 4. update JIRA title to match what's been done 5. update this PR title to match what's been done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1546) delete
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446230 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 02:12 Start Date: 16/Jun/20 02:12 Worklog Time Spent: 10m Work Description: kinow commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644488157 I'll 1. rebase as there are 4 commits in this PR (which is fine in other cases, but here we want to only remove 2 lines, so having less commits makes it easier for devs that need to rollback/rebase changes for debugging/troubleshooting/etc) 2. add changes.xml 3. update JIRA fixed/affected version 4. update JIRA title to match what's been done 5. update this PR title to match what's been done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446230) Time Spent: 1.5h (was: 1h 20m) > delete > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1546) delete
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136235#comment-17136235 ] Bruno P. Kinoshita commented on LANG-1546: -- Updated title as the pull request is now removing the docencoding from [lang]'s pom.xml, and using the inherited values from parent. > delete > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1546) delete
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1546: - Summary: delete (was: change to ) > delete > > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1546: - Affects Version/s: 3.10 > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1546: - Fix Version/s: 3.11 > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 3.10 >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 3.11 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1546: - Assignee: Bruno P. Kinoshita > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Assignee: Bruno P. Kinoshita >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-vfs] PeterAlfredLee closed pull request #94: [VFS-769] Fix .tgz and .tbz2 createFileSystem fails
PeterAlfredLee closed pull request #94: URL: https://github.com/apache/commons-vfs/pull/94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1546) change to
[
https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446206
]
ASF GitHub Bot logged work on LANG-1546:
Author: ASF GitHub Bot
Created on: 16/Jun/20 00:49
Start Date: 16/Jun/20 00:49
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #428:
URL: https://github.com/apache/commons-lang/pull/428#discussion_r440523991
##
File path: pom.xml
##
@@ -658,7 +658,7 @@
${maven.compiler.source}
true
utf-8
- utf-8
+ utf-8
Review comment:
@kinow Here is the content I mean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 446206)
Time Spent: 1h 10m (was: 1h)
> change to
> --
>
> Key: LANG-1546
> URL: https://issues.apache.org/jira/browse/LANG-1546
> Project: Commons Lang
> Issue Type: Bug
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/428]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #428: [LANG-1546] change to
XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish @kinow See content in `michael-o requested changes on Jun 3, 2019` That is resolved so hidden. I'll reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446207 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 00:49 Start Date: 16/Jun/20 00:49 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish @kinow See content in `michael-o requested changes on Jun 3, 2019` That is resolved so hidden. I'll reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446207) Time Spent: 1h 20m (was: 1h 10m) > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #428: [LANG-1546] change to
XenoAmess commented on a change in pull request #428:
URL: https://github.com/apache/commons-lang/pull/428#discussion_r440523991
##
File path: pom.xml
##
@@ -658,7 +658,7 @@
${maven.compiler.source}
true
utf-8
- utf-8
+ utf-8
Review comment:
@kinow Here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #428: [LANG-1546] change to
XenoAmess commented on a change in pull request #428:
URL: https://github.com/apache/commons-lang/pull/428#discussion_r440523991
##
File path: pom.xml
##
@@ -658,7 +658,7 @@
${maven.compiler.source}
true
utf-8
- utf-8
+ utf-8
Review comment:
@kinow Here is the content I mean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1546) change to
[
https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446205
]
ASF GitHub Bot logged work on LANG-1546:
Author: ASF GitHub Bot
Created on: 16/Jun/20 00:48
Start Date: 16/Jun/20 00:48
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #428:
URL: https://github.com/apache/commons-lang/pull/428#discussion_r440523991
##
File path: pom.xml
##
@@ -658,7 +658,7 @@
${maven.compiler.source}
true
utf-8
- utf-8
+ utf-8
Review comment:
@kinow Here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 446205)
Time Spent: 1h (was: 50m)
> change to
> --
>
> Key: LANG-1546
> URL: https://issues.apache.org/jira/browse/LANG-1546
> Project: Commons Lang
> Issue Type: Bug
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/428]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446204=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446204 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 00:42 Start Date: 16/Jun/20 00:42 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish @kinow See content in `michael-o requested changes on Jun 3, 2019` That is resolved so hidden. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446204) Time Spent: 50m (was: 40m) > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446203 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 00:42 Start Date: 16/Jun/20 00:42 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish see content in `michael-o requested changes on Jun 3, 2019` that is resolved so hidden. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446203) Time Spent: 40m (was: 0.5h) > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #428: [LANG-1546] change to
XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish @kinow See content in `michael-o requested changes on Jun 3, 2019` That is resolved so hidden. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #428: [LANG-1546] change to
XenoAmess edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish see content in `michael-o requested changes on Jun 3, 2019` that is resolved so hidden. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446202=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446202 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 16/Jun/20 00:41 Start Date: 16/Jun/20 00:41 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish see content in `michael-o requested changes on Jun 3, 2019` that is resolved so hided. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446202) Time Spent: 0.5h (was: 20m) > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #428: [LANG-1546] change to
XenoAmess commented on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141 > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `` to ``. > > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish see content in `michael-o requested changes on Jun 3, 2019` that is resolved so hided. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1546) change to
[ https://issues.apache.org/jira/browse/LANG-1546?focusedWorklogId=446170=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446170 ] ASF GitHub Bot logged work on LANG-1546: Author: ASF GitHub Bot Created on: 15/Jun/20 23:34 Start Date: 15/Jun/20 23:34 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-498049420 [](https://coveralls.io/builds/31472483) Coverage remained the same at 95.026% when pulling **2b246a3c6fd6598108821c08da026bfdbe8e76bc on XenoAmess:typoFix** into **438716a839ff94ef72f7e261e7fb1114e482cb39 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446170) Time Spent: 20m (was: 10m) > change to > -- > > Key: LANG-1546 > URL: https://issues.apache.org/jira/browse/LANG-1546 > Project: Commons Lang > Issue Type: Bug >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/428] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #428: [LANG-1546] change to
coveralls edited a comment on pull request #428: URL: https://github.com/apache/commons-lang/pull/428#issuecomment-498049420 [](https://coveralls.io/builds/31472483) Coverage remained the same at 95.026% when pulling **2b246a3c6fd6598108821c08da026bfdbe8e76bc on XenoAmess:typoFix** into **438716a839ff94ef72f7e261e7fb1114e482cb39 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] XenoAmess removed a comment on pull request #4: add JAVA_1_10_HOME,JAVA_1_11_HOME,JAVA_1_12_HOME into _removeheaders in maven-bundle-plugin
XenoAmess removed a comment on pull request #4: URL: https://github.com/apache/commons-parent/pull/4#issuecomment-498051673 sorry for my mistakes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] LinuxClient commented on a change in pull request #120: Add caching for required charsets
LinuxClient commented on a change in pull request #120:
URL: https://github.com/apache/commons-io/pull/120#discussion_r438293467
##
File path: src/main/java/org/apache/commons/io/Charsets.java
##
@@ -72,15 +83,7 @@
* @since 2.5
*/
public static SortedMap requiredCharsets() {
Review comment:
I have now changed it. Could you look over it again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-graph] ameyjadiye closed pull request #1: Update Maven settings, gitignore, and add README
ameyjadiye closed pull request #1: URL: https://github.com/apache/commons-graph/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on pull request #1: Update Maven settings, gitignore, and add README
ameyjadiye commented on pull request #1: URL: https://github.com/apache/commons-graph/pull/1#issuecomment-644278890 @kinow , now things look good to close this PR :smiley_cat: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-766) SftpClientFactory hangs at FileSystemManager.resolveFile(...)
[
https://issues.apache.org/jira/browse/VFS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136054#comment-17136054
]
Manish Bansal commented on VFS-766:
---
Same issue. I upgraded from 2.2 to 2.6 along with some intricate application
changes. And when we observed sftp hanging, it gave us all mini cardiac arrest.
Luckily the I had an epiphany and tried lower version of library and it worked.
Hi [~texasaggie],
Are you going to work on this? If not, would like to pick it up.
Thanks,
Manish
> SftpClientFactory hangs at FileSystemManager.resolveFile(...)
> -
>
> Key: VFS-766
> URL: https://issues.apache.org/jira/browse/VFS-766
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.5.0, 2.6.0
>Reporter: Jasper Teng
>Priority: Critical
>
> Issue: When trying to sftp, it hangs inside
> FileSystemManager.resolveFile(...).
>
> Libs in classpath used for testing:
> * commons-vfs2-2.6.0.jar / commons-vfs2-2.5.0.jar
> * commons-vfs2-jackrabbit2-2.5.0.jar
> * jackrabbit-webdav-2.20.0.jar
>
> Issue Log file (2.5.0 + Server X):
> {noformat}
> 25 Mar, 20:00:37,825 INFO main [SftpClientFactory$JSchLogger.log()]
> [65017ms] Connection established
> 25 Mar, 20:00:38,013 INFO main [SftpClientFactory$JSchLogger.log()]
> [65205ms] Remote version string: SSH-2.0-ProVide
> 25 Mar, 20:00:38,017 INFO main [SftpClientFactory$JSchLogger.log()]
> [65209ms] Local version string: SSH-2.0-JSCH-0.1.52
> ...snip...
> 25 Mar, 20:01:02,802 INFO main [SftpClientFactory$JSchLogger.log()]
> [89994ms] kex: server->client aes128-ctr hmac-md5 none
> 25 Mar, 20:01:02,809 INFO main [SftpClientFactory$JSchLogger.log()]
> [90001ms] kex: client->server aes128-ctr hmac-md5 none
> 25 Mar, 20:01:06,359 INFO main [SftpClientFactory$JSchLogger.log()]
> [93551ms] SSH_MSG_KEXDH_INIT sent
> 25 Mar, 20:01:06,363 INFO main [SftpClientFactory$JSchLogger.log()]
> [93555ms] expecting SSH_MSG_KEXDH_REPLY
> 25 Mar, 20:01:10,410 INFO main [SftpClientFactory$JSchLogger.log()]
> [97602ms] ssh_rsa_verify: signature true
> 25 Mar, 20:01:10,427 WARN main [SftpClientFactory$JSchLogger.log()]
> [97619ms] Permanently added 'mask.mask.mask' (RSA) to the list of known hosts.
> 25 Mar, 20:01:10,438 INFO main [SftpClientFactory$JSchLogger.log()]
> [97630ms] SSH_MSG_NEWKEYS sent
> 25 Mar, 20:01:10,625 INFO main [SftpClientFactory$JSchLogger.log()]
> [97817ms] SSH_MSG_NEWKEYS received
> 25 Mar, 20:01:10,709 INFO main [SftpClientFactory$JSchLogger.log()]
> [97901ms] SSH_MSG_SERVICE_REQUEST sent
> 25 Mar, 20:01:10,897 INFO main [SftpClientFactory$JSchLogger.log()]
> [98089ms] SSH_MSG_SERVICE_ACCEPT received
> 25 Mar, 20:01:11,098 INFO main [SftpClientFactory$JSchLogger.log()]
> [98290ms] Authentications that can continue:
> publickey,keyboard-interactive,password
> 25 Mar, 20:01:11,102 INFO main [SftpClientFactory$JSchLogger.log()]
> [98294ms] Next authentication method: publickey
> 25 Mar, 20:01:11,114 INFO main [SftpClientFactory$JSchLogger.log()]
> [98306ms] Authentications that can continue: password
> 25 Mar, 20:01:11,119 INFO main [SftpClientFactory$JSchLogger.log()]
> [98311ms] Next authentication method: password
> 25 Mar, 20:01:11,735 INFO main [SftpClientFactory$JSchLogger.log()]
> [98927ms] Authentication succeeded (password).{noformat}
>
> Issue Log file (2.6.0 + Server X):
> {noformat}
> 26 Mar, 09:42:07,781 INFO main [SftpClientFactory$JSchLogger.log()]
> [20400ms] Connection established
> 26 Mar, 09:42:07,971 INFO main [SftpClientFactory$JSchLogger.log()]
> [20590ms] Remote version string: SSH-2.0-ProVide
> 26 Mar, 09:42:07,975 INFO main [SftpClientFactory$JSchLogger.log()]
> [20594ms] Local version string: SSH-2.0-JSCH-0.1.52
> ...snip...
> 26 Mar, 09:42:33,250 INFO main [SftpClientFactory$JSchLogger.log()]
> [45869ms] kex: server->client aes128-ctr hmac-md5 none
> 26 Mar, 09:42:33,258 INFO main [SftpClientFactory$JSchLogger.log()]
> [45877ms] kex: client->server aes128-ctr hmac-md5 none
> 26 Mar, 09:42:36,710 INFO main [SftpClientFactory$JSchLogger.log()]
> [49329ms] SSH_MSG_KEXDH_INIT sent
> 26 Mar, 09:42:36,716 INFO main [SftpClientFactory$JSchLogger.log()]
> [49335ms] expecting SSH_MSG_KEXDH_REPLY
> 26 Mar, 09:42:40,635 INFO main [SftpClientFactory$JSchLogger.log()]
> [53254ms] ssh_rsa_verify: signature true
> 26 Mar, 09:42:40,653 INFO main [SftpClientFactory$JSchLogger.log()]
> [53272ms] Host 'mask.mask.mask' is known and matches the RSA host key
> 26 Mar, 09:42:40,660 INFO main [SftpClientFactory$JSchLogger.log()]
> [53279ms] SSH_MSG_NEWKEYS sent
> 26 Mar, 09:42:40,845 INFO main [SftpClientFactory$JSchLogger.log()]
> [53464ms] SSH_MSG_NEWKEYS received
> 26 Mar, 09:42:40,953 INFO main [SftpClientFactory$JSchLogger.log()]
> [53572ms] SSH_MSG_SERVICE_REQUEST sent
> 26
[GitHub] [commons-csv] melloware commented on pull request #73: Refactor csv format
melloware commented on pull request #73: URL: https://github.com/apache/commons-csv/pull/73#issuecomment-644190969 This does look a lot better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #121: Make some simplifications
coveralls commented on pull request #121: URL: https://github.com/apache/commons-io/pull/121#issuecomment-644153244 [](https://coveralls.io/builds/3146) Coverage increased (+0.05%) to 89.775% when pulling **9fea4ec51634c8940ac532e2908b2dab2a1660f9 on LinuxClient:make-some-simplifications** into **e589115b6443b328c7863b34455ed76f9cec06cc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] singhbaljit opened a new pull request #79: GEOMETRY-63: Fix some SonarQube smells
singhbaljit opened a new pull request #79: URL: https://github.com/apache/commons-geometry/pull/79 https://sonarcloud.io/dashboard?id=commons-geometry This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] PeterAlfredLee commented on pull request #95: [VFS-664] Fix for file names with exclamation mark can not be read
PeterAlfredLee commented on pull request #95: URL: https://github.com/apache/commons-vfs/pull/95#issuecomment-644139617 And it seems the [VFS-225](https://issues.apache.org/jira/projects/VFS/issues/VFS-225?filter=allopenissues) is a duplicate issue with this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] PeterAlfredLee opened a new pull request #95: [VFS-664] Fix for file names with exclamation mark can not be read
PeterAlfredLee opened a new pull request #95: URL: https://github.com/apache/commons-vfs/pull/95 This is a fix for problems that file names with exclamation mark in zip file can not be successfully be read. And this problem also exists in tar, tgz and tbz2. The fix for them are also included in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] LinuxClient opened a new pull request #121: Make some simplifications
LinuxClient opened a new pull request #121: URL: https://github.com/apache/commons-io/pull/121 1. Redundant assignment of local variables removed 2. Lambda expression simplified 3. If-else replaced with `Integer.compare(x, y)` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (LANG-1571) Allow to pass Supplier varargs to getIfNull
[ https://issues.apache.org/jira/browse/LANG-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yeldos Tanikin updated LANG-1571: - Comment: was deleted (was: Hi, what do you think about this change, it will be compatible with the current one and allow us to pass a few suppliers and take the first not null result. Should it have a different name like getFirstIfNull? can I take the task to implement? what should I do to start? Sorry, I'm new here, maybe I should not create task before discuss with you, tell me what should I do If I'm not correct) > Allow to pass Supplier varargs to getIfNull > --- > > Key: LANG-1571 > URL: https://issues.apache.org/jira/browse/LANG-1571 > Project: Commons Lang > Issue Type: Improvement >Reporter: Yeldos Tanikin >Priority: Major > > change > public static T getIfNull(final T object, final Supplier > defaultSupplier) > to > public static T getIfNull(final T object, final Supplier... suppliers) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-vfs] PeterAlfredLee opened a new pull request #94: [VFS-769] Fix .tgz and .tbz2 createFileSystem fails
PeterAlfredLee opened a new pull request #94: URL: https://github.com/apache/commons-vfs/pull/94 This is a fix for failures in `createFileSystem` with extensions of `.tgz` and `.tbz2`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #73: Refactor csv format
coveralls edited a comment on pull request #73: URL: https://github.com/apache/commons-csv/pull/73#issuecomment-633436839 [](https://coveralls.io/builds/31458705) Coverage increased (+0.1%) to 98.623% when pulling **9c48fd81e30c9740077bae0c2a773a66f9ee5e11 on dota17:refactorCSVFormat** into **ab751011e6da0c81ca29b818b125721541db01cc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] dota17 commented on pull request #73: Refactor csv format
dota17 commented on pull request #73: URL: https://github.com/apache/commons-csv/pull/73#issuecomment-644121337 @garydgregory @melloware How about this way of modifying code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] PeterAlfredLee opened a new pull request #93: [VFS-624] Fix for read() in constructors of LocalFileRandomAccessContent and RamFileRandomAccessContent
PeterAlfredLee opened a new pull request #93: URL: https://github.com/apache/commons-vfs/pull/93 As [VFS-624](https://issues.apache.org/jira/projects/VFS/issues/VFS-624?filter=allopenissues) described, the `read`of the inner class in `LocalFileRandomAccessContent` would return `-1` if it's reading a `0xFF` in file. This is a fix for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #73: Refactor csv format
coveralls edited a comment on pull request #73: URL: https://github.com/apache/commons-csv/pull/73#issuecomment-633436839 [](https://coveralls.io/builds/31458296) Coverage increased (+0.1%) to 98.623% when pulling **0c68d6988a2b2c09c9623ccf045bfefe066609a2 on dota17:refactorCSVFormat** into **ab751011e6da0c81ca29b818b125721541db01cc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
[
https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135656#comment-17135656
]
chenshuming edited comment on VFS-396 at 6/15/20, 10:32 AM:
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
{code:java}
// code placeholder
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
{code}
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "afs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
was (Author: csmdev):
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "afs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
> RAM FileSystem allows the file system size to exceed the max size limit.
>
>
> Key: VFS-396
> URL: https://issues.apache.org/jira/browse/VFS-396
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: All
>Reporter: Rupesh Kumar
>Priority: Major
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to
> its outputstream, there is a check in place for ensuring that file system
> size does not exceed the max limit set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call
> file.resize(newSize)
> And in the RamFileObject.resize(), there is a check
> if (fs.size() + newSize - this.size() > maxSize)
> {
> throw new IOException("FileSystem capacity (" + maxSize
> + ") exceeded.");
> }
> This check is wrong.
> Consider this case of a new file system where the file system size is set to
> 5 MB and I am trying to create a file of 10 MB in the RAM file system. the
> file is being written in the chunk of 8 kb. For every resize check, fs.size()
> would be 0 and (newsize - this.size()) would be 8 kb and therefore the check
> never passes.
> It could have been correct if the "old size" was locked down to the size
> that was registered with the file system but the old size (this.size()) keeps
> changing at every write. Thus the difference in newSize and this.size() would
> always be the chunk size (typically 8 kb) and therefore no exception would be
> thrown ever.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMMONSSITE-131) Add EventRouter to apache commons
[ https://issues.apache.org/jira/browse/COMMONSSITE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135663#comment-17135663 ] Manfred Huber commented on COMMONSSITE-131: --- Since this issue is open for 5 months without any response so far I assume there is no interest in adding this project to commons, hence I will close this issue now. > Add EventRouter to apache commons > - > > Key: COMMONSSITE-131 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-131 > Project: Apache Commons All > Issue Type: New Feature > Components: Commons Build >Reporter: Manfred Huber >Priority: Trivial > Labels: features > > I often needed some sort of a tiny "Event Bus" system, but could not find > anything similar in apache commons. > So I coded my own version of what I understand as a "tiny event bus" and I > thought it may be practical to move this to apache-commons. > Maybe someone can have a look at my project on > [GitHub|https://github.com/downdrown/eventrouter] and eventually I could > patch it to fit into apache-commons. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (COMMONSSITE-131) Add EventRouter to apache commons
[ https://issues.apache.org/jira/browse/COMMONSSITE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Huber closed COMMONSSITE-131. - Resolution: Abandoned > Add EventRouter to apache commons > - > > Key: COMMONSSITE-131 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-131 > Project: Apache Commons All > Issue Type: New Feature > Components: Commons Build >Reporter: Manfred Huber >Priority: Trivial > Labels: features > > I often needed some sort of a tiny "Event Bus" system, but could not find > anything similar in apache commons. > So I coded my own version of what I understand as a "tiny event bus" and I > thought it may be practical to move this to apache-commons. > Maybe someone can have a look at my project on > [GitHub|https://github.com/downdrown/eventrouter] and eventually I could > patch it to fit into apache-commons. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VFS-575) org.apache.commons.vfs2.FileSystemException: Could not close the output stream
[ https://issues.apache.org/jira/browse/VFS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135662#comment-17135662 ] Bernd Eckenfels commented on VFS-575: - I think if the bug is not closed it still exists. Can you provide more details and logs, maybe it helps someone to write a fix. > org.apache.commons.vfs2.FileSystemException: Could not close the output stream > -- > > Key: VFS-575 > URL: https://issues.apache.org/jira/browse/VFS-575 > Project: Commons VFS > Issue Type: Bug >Affects Versions: 2.0 > Environment: Linux, Weblogic >Reporter: Arajit >Priority: Major > > Hi Team, > I am using VFS 2.0 for implementing SFTP for my application. I have a single > Thread which actually picks up the file and do SFTP. 98% of the time it > works. But I have observed there are few cases where SFTP is getting failed > with below exception.. > Caused by: org.apache.commons.vfs2.FileSystemException: Could not close the > output stream for file "sftp://***/Test.csv;. > [null,null]at > org.apache.commons.vfs2.provider.DefaultFileContent$FileContentOutputStream.close(DefaultFileContent.java:694) > [null,null]at > org.apache.commons.vfs2.FileUtil.copyContent(FileUtil.java:118) > [null,null]at > org.apache.commons.vfs2.provider.AbstractFileObject.copyFrom(AbstractFileObject.java:1053) > [null,null]... 3 more > Caused by: java.io.IOException: inputstream is closed > [null,null]at com.jcraft.jsch.ChannelSftp.fill(ChannelSftp.java:2884) > [null,null]at com.jcraft.jsch.ChannelSftp.header(ChannelSftp.java:2908) > [null,null]at > com.jcraft.jsch.ChannelSftp.checkStatus(ChannelSftp.java:2446) > [null,null]at > com.jcraft.jsch.ChannelSftp._sendCLOSE(ChannelSftp.java:2465) > [null,null]at > com.jcraft.jsch.ChannelSftp.access$400(ChannelSftp.java:36) > [null,null]at com.jcraft.jsch.ChannelSftp$1.close(ChannelSftp.java:854) > [null,null]at > java.io.FilterOutputStream.close(FilterOutputStream.java:143) > [null,null]at > org.apache.commons.vfs2.util.MonitorOutputStream.close(MonitorOutputStream.java:56) > [null,null]at > java.io.FilterOutputStream.close(FilterOutputStream.java:143) > [null,null]at > org.apache.commons.vfs2.util.MonitorOutputStream.close(MonitorOutputStream.java:56) > [null,null]at > org.apache.commons.vfs2.provider.DefaultFileContent$FileContentOutputStream.close(DefaultFileContent.java:690) > [null,null]... 5 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
[
https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135656#comment-17135656
]
chenshuming edited comment on VFS-396 at 6/15/20, 9:20 AM:
---
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "afs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
was (Author: csmdev):
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "fs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
> RAM FileSystem allows the file system size to exceed the max size limit.
>
>
> Key: VFS-396
> URL: https://issues.apache.org/jira/browse/VFS-396
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: All
>Reporter: Rupesh Kumar
>Priority: Major
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to
> its outputstream, there is a check in place for ensuring that file system
> size does not exceed the max limit set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call
> file.resize(newSize)
> And in the RamFileObject.resize(), there is a check
> if (fs.size() + newSize - this.size() > maxSize)
> {
> throw new IOException("FileSystem capacity (" + maxSize
> + ") exceeded.");
> }
> This check is wrong.
> Consider this case of a new file system where the file system size is set to
> 5 MB and I am trying to create a file of 10 MB in the RAM file system. the
> file is being written in the chunk of 8 kb. For every resize check, fs.size()
> would be 0 and (newsize - this.size()) would be 8 kb and therefore the check
> never passes.
> It could have been correct if the "old size" was locked down to the size
> that was registered with the file system but the old size (this.size()) keeps
> changing at every write. Thus the difference in newSize and this.size() would
> always be the chunk size (typically 8 kb) and therefore no exception would be
> thrown ever.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
[
https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135656#comment-17135656
]
chenshuming edited comment on VFS-396 at 6/15/20, 9:19 AM:
---
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (afs.size() + newSize - this.size() >
maxSize)",
And I can see "fs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
was (Author: csmdev):
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (fs.size() + newSize - this.size() >
maxSize)",
And I can see "fs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
> RAM FileSystem allows the file system size to exceed the max size limit.
>
>
> Key: VFS-396
> URL: https://issues.apache.org/jira/browse/VFS-396
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: All
>Reporter: Rupesh Kumar
>Priority: Major
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to
> its outputstream, there is a check in place for ensuring that file system
> size does not exceed the max limit set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call
> file.resize(newSize)
> And in the RamFileObject.resize(), there is a check
> if (fs.size() + newSize - this.size() > maxSize)
> {
> throw new IOException("FileSystem capacity (" + maxSize
> + ") exceeded.");
> }
> This check is wrong.
> Consider this case of a new file system where the file system size is set to
> 5 MB and I am trying to create a file of 10 MB in the RAM file system. the
> file is being written in the chunk of 8 kb. For every resize check, fs.size()
> would be 0 and (newsize - this.size()) would be 8 kb and therefore the check
> never passes.
> It could have been correct if the "old size" was locked down to the size
> that was registered with the file system but the old size (this.size()) keeps
> changing at every write. Thus the difference in newSize and this.size() would
> always be the chunk size (typically 8 kb) and therefore no exception would be
> thrown ever.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
[
https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135656#comment-17135656
]
chenshuming commented on VFS-396:
-
I can't see this problem in my test. The RamFileSystem can detect the file's
size become too large and throw Exception.
I notice this issue's description says :
```
there is a check
if (fs.size() + newSize - this.size() > maxSize)
For every resize check, fs.size() would be 0
```
In current VFS project, the check is "if (fs.size() + newSize - this.size() >
maxSize)",
And I can see "fs.size()" is the file system current size instead of 0 .
So I think this check work and maybe this issue should close.
> RAM FileSystem allows the file system size to exceed the max size limit.
>
>
> Key: VFS-396
> URL: https://issues.apache.org/jira/browse/VFS-396
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: All
>Reporter: Rupesh Kumar
>Priority: Major
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to
> its outputstream, there is a check in place for ensuring that file system
> size does not exceed the max limit set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call
> file.resize(newSize)
> And in the RamFileObject.resize(), there is a check
> if (fs.size() + newSize - this.size() > maxSize)
> {
> throw new IOException("FileSystem capacity (" + maxSize
> + ") exceeded.");
> }
> This check is wrong.
> Consider this case of a new file system where the file system size is set to
> 5 MB and I am trying to create a file of 10 MB in the RAM file system. the
> file is being written in the chunk of 8 kb. For every resize check, fs.size()
> would be 0 and (newsize - this.size()) would be 8 kb and therefore the check
> never passes.
> It could have been correct if the "old size" was locked down to the size
> that was registered with the file system but the old size (this.size()) keeps
> changing at every write. Thus the difference in newSize and this.size() would
> always be the chunk size (typically 8 kb) and therefore no exception would be
> thrown ever.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-575) org.apache.commons.vfs2.FileSystemException: Could not close the output stream
[ https://issues.apache.org/jira/browse/VFS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135573#comment-17135573 ] Akhil Surapuram commented on VFS-575: - Hi [~b.eckenfels] , I am facing this issue in version 2.4 . for this issue fix version is mentioned as None. is this fixed or still open?? > org.apache.commons.vfs2.FileSystemException: Could not close the output stream > -- > > Key: VFS-575 > URL: https://issues.apache.org/jira/browse/VFS-575 > Project: Commons VFS > Issue Type: Bug >Affects Versions: 2.0 > Environment: Linux, Weblogic >Reporter: Arajit >Priority: Major > > Hi Team, > I am using VFS 2.0 for implementing SFTP for my application. I have a single > Thread which actually picks up the file and do SFTP. 98% of the time it > works. But I have observed there are few cases where SFTP is getting failed > with below exception.. > Caused by: org.apache.commons.vfs2.FileSystemException: Could not close the > output stream for file "sftp://***/Test.csv;. > [null,null]at > org.apache.commons.vfs2.provider.DefaultFileContent$FileContentOutputStream.close(DefaultFileContent.java:694) > [null,null]at > org.apache.commons.vfs2.FileUtil.copyContent(FileUtil.java:118) > [null,null]at > org.apache.commons.vfs2.provider.AbstractFileObject.copyFrom(AbstractFileObject.java:1053) > [null,null]... 3 more > Caused by: java.io.IOException: inputstream is closed > [null,null]at com.jcraft.jsch.ChannelSftp.fill(ChannelSftp.java:2884) > [null,null]at com.jcraft.jsch.ChannelSftp.header(ChannelSftp.java:2908) > [null,null]at > com.jcraft.jsch.ChannelSftp.checkStatus(ChannelSftp.java:2446) > [null,null]at > com.jcraft.jsch.ChannelSftp._sendCLOSE(ChannelSftp.java:2465) > [null,null]at > com.jcraft.jsch.ChannelSftp.access$400(ChannelSftp.java:36) > [null,null]at com.jcraft.jsch.ChannelSftp$1.close(ChannelSftp.java:854) > [null,null]at > java.io.FilterOutputStream.close(FilterOutputStream.java:143) > [null,null]at > org.apache.commons.vfs2.util.MonitorOutputStream.close(MonitorOutputStream.java:56) > [null,null]at > java.io.FilterOutputStream.close(FilterOutputStream.java:143) > [null,null]at > org.apache.commons.vfs2.util.MonitorOutputStream.close(MonitorOutputStream.java:56) > [null,null]at > org.apache.commons.vfs2.provider.DefaultFileContent$FileContentOutputStream.close(DefaultFileContent.java:690) > [null,null]... 5 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1571) Allow to pass Supplier varargs to getIfNull
[ https://issues.apache.org/jira/browse/LANG-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135285#comment-17135285 ] Yeldos Tanikin edited comment on LANG-1571 at 6/15/20, 6:22 AM: Hi, what do you think about this change, it will be compatible with the current one and allow us to pass a few suppliers and take the first not null result. Should it have a different name like getFirstIfNull? can I take the task to implement? what should I do to start? Sorry, I'm new here, maybe I should not create task before discuss with you, tell me what should I do If I'm not correct was (Author: ytanikin): Hi, what do you think about this change, it will be compatible with previous one and allow us to pass a few suppliers and take the first not null result. Should it have a different name like getFirstIfNull? can I take the task to implement? what should I do to start? Sorry, I'm new here, maybe I should not create task before discuss with you, tell me what should I do If I'm not correct > Allow to pass Supplier varargs to getIfNull > --- > > Key: LANG-1571 > URL: https://issues.apache.org/jira/browse/LANG-1571 > Project: Commons Lang > Issue Type: Improvement >Reporter: Yeldos Tanikin >Priority: Major > > change > public static T getIfNull(final T object, final Supplier > defaultSupplier) > to > public static T getIfNull(final T object, final Supplier... suppliers) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1571) Allow to pass Supplier varargs to getIfNull
[ https://issues.apache.org/jira/browse/LANG-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135285#comment-17135285 ] Yeldos Tanikin edited comment on LANG-1571 at 6/15/20, 6:15 AM: Hi, what do you think about this change, it will be compatible with previous one and allow us to pass a few suppliers and take the first not null result. Should it have a different name like getFirstIfNull? can I take the task to implement? what should I do to start? Sorry, I'm new here, maybe I should not create task before discuss with you, tell me what should I do If I'm not correct was (Author: ytanikin): Hi, what do you think about this change, it will be compatible with previous one and allow us to pass a few suppliers and take the first not null result. Should it have a different name like getFirstIfNull? can I take the task to implement? what should I do to start? Sorry, I'm new here, maybe I should not create task before discuss with you, tell me what should I do If I'm not correct > Allow to pass Supplier varargs to getIfNull > --- > > Key: LANG-1571 > URL: https://issues.apache.org/jira/browse/LANG-1571 > Project: Commons Lang > Issue Type: Improvement >Reporter: Yeldos Tanikin >Priority: Major > > change > public static T getIfNull(final T object, final Supplier > defaultSupplier) > to > public static T getIfNull(final T object, final Supplier... suppliers) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1571) Allow to pass Supplier varargs to getIfNull
[ https://issues.apache.org/jira/browse/LANG-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yeldos Tanikin updated LANG-1571: - Summary: Allow to pass Supplier varargs to getIfNull (was: Allow to pass Supplier arrays to getIfNull) > Allow to pass Supplier varargs to getIfNull > --- > > Key: LANG-1571 > URL: https://issues.apache.org/jira/browse/LANG-1571 > Project: Commons Lang > Issue Type: Improvement >Reporter: Yeldos Tanikin >Priority: Major > > change > public static T getIfNull(final T object, final Supplier > defaultSupplier) > to > public static T getIfNull(final T object, final Supplier... suppliers) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
