[jira] [Work logged] (COMPRESS-542) Corrupt 7z allocates huge amount of SevenZEntries
[
https://issues.apache.org/jira/browse/COMPRESS-542?focusedWorklogId=468430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468430
]
ASF GitHub Bot logged work on COMPRESS-542:
---
Author: ASF GitHub Bot
Created on: 10/Aug/20 05:58
Start Date: 10/Aug/20 05:58
Worklog Time Spent: 10m
Work Description: theobisproject commented on pull request #120:
URL: https://github.com/apache/commons-compress/pull/120#issuecomment-671175522
The test files @akelday attached to the jira issue are replicating the
issue. Since this issue is dependend on the available Java heap it could be
difficult to add this as unit test since I don't know a way to force the Java
heap for a single test in JUnit. As far as I know it could only be set at the
maven-surefire-plugin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468430)
Time Spent: 1h 50m (was: 1h 40m)
> Corrupt 7z allocates huge amount of SevenZEntries
> -
>
> Key: COMPRESS-542
> URL: https://issues.apache.org/jira/browse/COMPRESS-542
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Robin Schimpf
>Priority: Major
> Attachments:
> Reduced_memory_allocation_for_corrupted_7z_archives.patch,
> endheadercorrupted.7z, endheadercorrupted2.7z
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We ran into a problem where a 1.43GB corrupt 7z file tried to allocate about
> 138 million SevenZArchiveEntries which will use about 12GB of memory. Sadly
> I'm unable to share the file. If you have enough Memory available the
> following exception is thrown.
> {code:java}
> java.io.IOException: Start header corrupt and unable to guess end Header
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.tryToLocateEndHeader(SevenZFile.java:511)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readHeaders(SevenZFile.java:470)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:336)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:128)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:369)
> {code}
> 7z itself aborts really quick when I'm trying to list the content of the file.
> {code:java}
> 7z l "corrupt.7z"
> 7-Zip 18.01 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-01-28
> Scanning the drive for archives:
> 1 file, 1537752212 bytes (1467 MiB)
> Listing archive: corrupt.7z
> ERROR: corrupt.7z : corrupt.7z
> Open ERROR: Can not open the file as [7z] archive
> ERRORS:
> Is not archive
> Errors: 1
> {code}
> I hacked together the attached patch which will reduce the memory allocation
> to about 1GB. So lazy instantiation of the entries could be a good solution
> to the problem. Optimal would be to only create the entries if the headers
> could be parsed correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-671175522 The test files @akelday attached to the jira issue are replicating the issue. Since this issue is dependend on the available Java heap it could be difficult to add this as unit test since I don't know a way to force the Java heap for a single test in JUnit. As far as I know it could only be set at the maven-surefire-plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] coveralls commented on pull request #23: Bump actions/checkout from v2.3.1 to v2.3.2
coveralls commented on pull request #23: URL: https://github.com/apache/commons-dbutils/pull/23#issuecomment-671175093 [](https://coveralls.io/builds/32638686) Coverage remained the same at 64.939% when pulling **c3342df25a2142fa1783a62729032c7cd5d9411f on dependabot/github_actions/actions/checkout-v2.3.2** into **e34a958f5fc305af8dc0f3ceee6b667c853ecd6f on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #56: Bump actions/checkout from v2.3.1 to v2.3.2
coveralls commented on pull request #56: URL: https://github.com/apache/commons-codec/pull/56#issuecomment-671175206 [](https://coveralls.io/builds/32638689) Coverage remained the same at 93.976% when pulling **f8cb386d07803fdf1ebcde0a2909248d4873262f on dependabot/github_actions/actions/checkout-v2.3.2** into **32e85c8953a9076ce6e57adc4fc0419839a4e255 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] opened a new pull request #15: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #15: URL: https://github.com/apache/commons-parent/pull/15 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request #140: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #140: URL: https://github.com/apache/commons-io/pull/140 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] opened a new pull request #33: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #33: URL: https://github.com/apache/commons-beanutils/pull/33 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] opened a new pull request #62: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #62: URL: https://github.com/apache/commons-configuration/pull/62 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] opened a new pull request #173: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #173: URL: https://github.com/apache/commons-collections/pull/173 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] opened a new pull request #17: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #17: URL: https://github.com/apache/commons-exec/pull/17 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request #25: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/commons-email/pull/25 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request #109: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #109: URL: https://github.com/apache/commons-vfs/pull/109 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] dependabot[bot] opened a new pull request #46: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #46: URL: https://github.com/apache/commons-cli/pull/46 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #146: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #146: URL: https://github.com/apache/commons-text/pull/146 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] dependabot[bot] opened a new pull request #15: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #15: URL: https://github.com/apache/commons-logging/pull/15 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #124: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #124: URL: https://github.com/apache/commons-compress/pull/124 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] opened a new pull request #8: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #8: URL: https://github.com/apache/commons-release-plugin/pull/8 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #51: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #51: URL: https://github.com/apache/commons-dbcp/pull/51 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] opened a new pull request #56: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #56: URL: https://github.com/apache/commons-net/pull/56 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] dependabot[bot] opened a new pull request #92: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #92: URL: https://github.com/apache/commons-csv/pull/92 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] dependabot[bot] opened a new pull request #38: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #38: URL: https://github.com/apache/commons-validator/pull/38 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] opened a new pull request #23: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #23: URL: https://github.com/apache/commons-dbutils/pull/23 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] opened a new pull request #91: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #91: URL: https://github.com/apache/commons-imaging/pull/91 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] opened a new pull request #59: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #59: URL: https://github.com/apache/commons-bcel/pull/59 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #9: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #9: URL: https://github.com/apache/commons-build-plugin/pull/9 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] dependabot[bot] opened a new pull request #56: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #56: URL: https://github.com/apache/commons-codec/pull/56 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] opened a new pull request #601: Bump actions/checkout from v2.3.1 to v2.3.2
dependabot[bot] opened a new pull request #601: URL: https://github.com/apache/commons-lang/pull/601 Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.1 to v2.3.2. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/2036a08e25fa78bbd946711a407b529a0a1204bf;>2036a08 Add Third Party License Information to Dist Files (https://github-redirect.dependabot.com/actions/checkout/issues/320;>#320) https://github.com/actions/checkout/commit/592cf69a223b04e75ddf345919130b91010eb2a6;>592cf69 Update README.md https://github.com/actions/checkout/commit/a4b69b48862e969425d8dc115dcb965f288ea29b;>a4b69b4 Update README.md https://github.com/actions/checkout/commit/1433f62caac9c18949f9a498f6f28c05388ea443;>1433f62 update default branch (https://github-redirect.dependabot.com/actions/checkout/issues/305;>#305) https://github.com/actions/checkout/commit/61b9e3751b92087fd0b06925ba6dd6314e06f089;>61b9e37 improve description for fetch-depth (https://github-redirect.dependabot.com/actions/checkout/issues/301;>#301) See full diff in https://github.com/actions/checkout/compare/v2.3.1...2036a08e25fa78bbd946711a407b529a0a1204bf;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468426 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 10/Aug/20 05:26 Start Date: 10/Aug/20 05:26 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32638166) Coverage decreased (-0.0003%) to 94.665% when pulling **ab0c42774b1bc5dc5b060ec3d48f73726d960955 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468426) Time Spent: 5h 40m (was: 5.5h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32638166) Coverage decreased (-0.0003%) to 94.665% when pulling **ab0c42774b1bc5dc5b060ec3d48f73726d960955 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468406=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468406 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 10/Aug/20 04:52 Start Date: 10/Aug/20 04:52 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-671160146 Hi. I re-changed some codes and run a performance test. In short, ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.751 ? 0.091 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.767 ? 0.182 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.687 ? 2.040 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.221 ? 0.070 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.757 ? 0.249 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.718 ? 0.171 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.780 ? 0.362 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.829 ? 0.456 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.466 ? 0.550 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.506 ? 0.441 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 4.035 ? 1.104 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.780 ? 0.239 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 18.910 ? 2.074 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 19.492 ? 1.942 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.429 ? 1.860 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 22.080 ? 6.952 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 22.026 ? 2.968 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.868 ? 1.075 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.068 ? 0.168 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 3.896 ? 0.361 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.723 ? 0.809 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 19.235 ? 0.502 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 21.363 ? 1.176 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 21.182 ? 1.029 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 21.532 ? 1.032 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 21.420 ? 2.569 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 70565.068 ?2096.854 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 77950.673 ?2115.093 ns/op ``` detailed report at https://pastebin.ubuntu.com/p/bTNkPGpSpV/ @sebbASF yes, the performance test shows the original condition struction is not bad as I thought at beginning, and revert to original condition struction will not harm performance. so according to the "minimal change" principle, I changed the codes to looks more likely to original. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468406) Time Spent: 5.5h (was: 5h 20m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor >
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-671160146 Hi. I re-changed some codes and run a performance test. In short, ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.751 ? 0.091 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.767 ? 0.182 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.687 ? 2.040 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.221 ? 0.070 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.757 ? 0.249 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.718 ? 0.171 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.780 ? 0.362 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.829 ? 0.456 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.466 ? 0.550 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.506 ? 0.441 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 4.035 ? 1.104 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.780 ? 0.239 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 18.910 ? 2.074 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 19.492 ? 1.942 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.429 ? 1.860 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 22.080 ? 6.952 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 22.026 ? 2.968 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.868 ? 1.075 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.068 ? 0.168 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 3.896 ? 0.361 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.723 ? 0.809 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 19.235 ? 0.502 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 21.363 ? 1.176 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 21.182 ? 1.029 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 21.532 ? 1.032 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 21.420 ? 2.569 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 70565.068 ?2096.854 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 77950.673 ?2115.093 ns/op ``` detailed report at https://pastebin.ubuntu.com/p/bTNkPGpSpV/ @sebbASF yes, the performance test shows the original condition struction is not bad as I thought at beginning, and revert to original condition struction will not harm performance. so according to the "minimal change" principle, I changed the codes to looks more likely to original. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468403=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468403 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 10/Aug/20 04:48 Start Date: 10/Aug/20 04:48 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-671160146 Hi. I re-changed some codes and run a performance test. In short, ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.751 ? 0.091 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.767 ? 0.182 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.687 ? 2.040 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.221 ? 0.070 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.757 ? 0.249 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.718 ? 0.171 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.780 ? 0.362 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.829 ? 0.456 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.466 ? 0.550 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.506 ? 0.441 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 4.035 ? 1.104 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.780 ? 0.239 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 18.910 ? 2.074 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 19.492 ? 1.942 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.429 ? 1.860 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 22.080 ? 6.952 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 22.026 ? 2.968 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.868 ? 1.075 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.068 ? 0.168 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 3.896 ? 0.361 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.723 ? 0.809 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 19.235 ? 0.502 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 21.363 ? 1.176 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 21.182 ? 1.029 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 21.532 ? 1.032 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 21.420 ? 2.569 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 70565.068 ?2096.854 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 77950.673 ?2115.093 ns/op ``` detailed report at https://pastebin.ubuntu.com/p/bTNkPGpSpV/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468403) Time Spent: 5h 20m (was: 5h 10m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467686209
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server", "-Xms512M", "-Xmx512M"})
+public class StringUtilsChompTest {
+// Different code paths with no chomp
+private static final String string1 = "";
+private static final String string2 = "a";
+private static final String string3 = "aa";
+
+// Single char chomp
+private static final String string4 = "\r";
+private static final String string5 = "\n";
+
+// Multi-char chomp
+private static final String string6 = "\r\n";
+private static final String string7 = "a\n";
+private static final String string8 = "a\r";
+private static final String string9 = "a\r\n";
+
+private static final String[] strings = buildStrings();
+
+private static String[] buildStrings() {
+String[] res = new String[128 * 128];
+for (int i = 0; i < 128; i++) {
+for (int j = 0; j < 128; j++) {
+StringBuilder stringBuilder = new StringBuilder();
+stringBuilder.append((char) i);
+stringBuilder.append((char) j);
+res[i * 128 + j] = stringBuilder.toString();
+}
+}
+return res;
+}
+
+@Benchmark
+public String test1_Empty_Old() {
+return chompOld(string1);
+}
+
+@Benchmark
+public String test1_Empty_New() {
+return chompNew(string1);
+}
+
+@Benchmark
+public String test2_No_Chomp_Old() {
+return chompOld(string2);
+}
+
+@Benchmark
+public String test2_No_Chomp_New() {
+return chompNew(string2);
+}
+
+@Benchmark
+public String test3_No_Chomp_Old() {
+return chompOld(string3);
+}
+
+@Benchmark
+public String test3_No_Chomp_New() {
+return chompNew(string3);
+}
+
+@Benchmark
+public String test4_R_Old() {
+return chompOld(string4);
+}
+
+@Benchmark
+public String test4_R_New() {
+return chompNew(string4);
+}
+
+@Benchmark
+public String test5_N_Old() {
+return chompOld(string5);
+}
+
+@Benchmark
+public String test5_N_New() {
+return chompNew(string5);
+}
+
+@Benchmark
+public String test6_R_N_Old() {
+return chompOld(string6);
+}
+
+@Benchmark
+public String test6_R_N_New() {
+return chompNew(string6);
+}
+
+@Benchmark
+public String test7_a_N_Old() {
+return chompOld(string7);
+}
+
+@Benchmark
+public String test7_a_N_New() {
+return chompNew(string7);
+}
+
+@Benchmark
+public String test8_a_N_Old() {
Review comment:
@aherbert
Thanks for the example.
Will learn from it when writing other jmh tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468402
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 10/Aug/20 04:47
Start Date: 10/Aug/20 04:47
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467686209
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server", "-Xms512M", "-Xmx512M"})
+public class StringUtilsChompTest {
+// Different code paths with no chomp
+private static final String string1 = "";
+private static final String string2 = "a";
+private static final String string3 = "aa";
+
+// Single char chomp
+private static final String string4 = "\r";
+private static final String string5 = "\n";
+
+// Multi-char chomp
+private static final String string6 = "\r\n";
+private static final String string7 = "a\n";
+private static final String string8 = "a\r";
+private static final String string9 = "a\r\n";
+
+private static final String[] strings = buildStrings();
+
+private static String[] buildStrings() {
+String[] res = new String[128 * 128];
+for (int i = 0; i < 128; i++) {
+for (int j = 0; j < 128; j++) {
+StringBuilder stringBuilder = new StringBuilder();
+stringBuilder.append((char) i);
+stringBuilder.append((char) j);
+res[i * 128 + j] = stringBuilder.toString();
+}
+}
+return res;
+}
+
+@Benchmark
+public String test1_Empty_Old() {
+return chompOld(string1);
+}
+
+@Benchmark
+public String test1_Empty_New() {
+return chompNew(string1);
+}
+
+@Benchmark
+public String test2_No_Chomp_Old() {
+return chompOld(string2);
+}
+
+@Benchmark
+public String test2_No_Chomp_New() {
+return chompNew(string2);
+}
+
+@Benchmark
+public String test3_No_Chomp_Old() {
+return chompOld(string3);
+}
+
+@Benchmark
+public String test3_No_Chomp_New() {
+return chompNew(string3);
+}
+
+@Benchmark
+public String test4_R_Old() {
+return chompOld(string4);
+}
+
+@Benchmark
+public String test4_R_New() {
+return chompNew(string4);
+}
+
+@Benchmark
+public String test5_N_Old() {
+return chompOld(string5);
+}
+
+@Benchmark
+public String test5_N_New() {
+return chompNew(string5);
+}
+
+@Benchmark
+public String test6_R_N_Old() {
+return chompOld(string6);
+}
+
+@Benchmark
+public String test6_R_N_New() {
+return chompNew(string6);
+}
+
+@Benchmark
+public String test7_a_N_Old() {
+return chompOld(string7);
+}
+
+@Benchmark
+public String test7_a_N_New() {
+return chompNew(string7);
+}
+
+@Benchmark
+
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-671160146 Hi. I re-changed some codes and run a performance test. In short, ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.751 ? 0.091 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.767 ? 0.182 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.687 ? 2.040 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.221 ? 0.070 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.757 ? 0.249 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.718 ? 0.171 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.780 ? 0.362 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.829 ? 0.456 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.466 ? 0.550 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.506 ? 0.441 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 4.035 ? 1.104 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.780 ? 0.239 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 18.910 ? 2.074 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 19.492 ? 1.942 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.429 ? 1.860 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 22.080 ? 6.952 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 22.026 ? 2.968 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.868 ? 1.075 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.068 ? 0.168 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 3.896 ? 0.361 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.723 ? 0.809 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 19.235 ? 0.502 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 21.363 ? 1.176 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 21.182 ? 1.029 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 21.532 ? 1.032 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 21.420 ? 2.569 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 70565.068 ?2096.854 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 77950.673 ?2115.093 ns/op ``` detailed report at https://pastebin.ubuntu.com/p/bTNkPGpSpV/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468397=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468397
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 10/Aug/20 04:44
Start Date: 10/Aug/20 04:44
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467685564
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
+return str;
}
-} else if (last != CharUtils.CR) {
-lastIdx++;
+} else if (str.charAt(lastIdx - 1) == CharUtils.CR) {
+--lastIdx;
Review comment:
> Better to use lastIdx-- here - don't make unnecessary changes
@sebbASF OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468397)
Time Spent: 5h (was: 4h 50m)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467685564
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
+return str;
}
-} else if (last != CharUtils.CR) {
-lastIdx++;
+} else if (str.charAt(lastIdx - 1) == CharUtils.CR) {
+--lastIdx;
Review comment:
> Better to use lastIdx-- here - don't make unnecessary changes
@sebbASF OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IO-676) Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
[
https://issues.apache.org/jira/browse/IO-676?focusedWorklogId=468382=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468382
]
ASF GitHub Bot logged work on IO-676:
-
Author: ASF GitHub Bot
Created on: 10/Aug/20 03:27
Start Date: 10/Aug/20 03:27
Worklog Time Spent: 10m
Work Description: Isira-Seneviratne commented on a change in pull request
#124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r467672456
##
File path: src/main/java/org/apache/commons/io/FileUtils.java
##
@@ -1603,93 +1598,272 @@ public static boolean isFileNewer(final File file,
final File reference) {
}
/**
- * Tests if the specified File is newer than the specified
- * time reference.
+ * Tests if the specified {@code File} is newer than the specified time
reference.
*
- * @param file the File of which the modification date
must
- * be compared, must not be {@code null}
+ * @param file the {@code File} of which the modification date must
be compared
* @param timeMillis the time reference measured in milliseconds since the
* epoch (00:00:00 GMT, January 1, 1970)
- * @return true if the File exists and has been modified after
- * the given time reference.
- * @throws IllegalArgumentException if the file is {@code null}
+ * @return true if the {@code File} exists and has been modified after the
given time reference.
+ * @throws NullPointerException if the file is {@code null}
*/
public static boolean isFileNewer(final File file, final long timeMillis) {
-if (file == null) {
-throw new IllegalArgumentException("No specified file");
-}
+Objects.requireNonNull(file, "file");
if (!file.exists()) {
return false;
}
return file.lastModified() > timeMillis;
}
/**
- * Tests if the specified File is older than the specified
- * Date.
+ * Tests if the specified {@code File} is newer than the specified {@code
Instant}.
+ *
+ * @param filethe {@code File} of which the modification date must be
compared
+ * @param instant the date reference
+ * @return true if the {@code File} exists and has been modified after the
given {@code Instant}.
+ * @throws NullPointerException if the file or instant is {@code null}
+ *
+ * @since 2.8
+ */
+public static boolean isFileNewer(final File file, final Instant instant) {
Review comment:
@garydgregory My bad, I'll do so now.
@chtompki Thanks for the suggestion, I'll update the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468382)
Time Spent: 5h (was: 4h 50m)
> Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time
> API.
> --
>
> Key: IO-676
> URL: https://issues.apache.org/jira/browse/IO-676
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
>Reporter: Isira Seneviratne
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] Isira-Seneviratne commented on a change in pull request #124: [IO-676] Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
Isira-Seneviratne commented on a change in pull request #124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r467672456
##
File path: src/main/java/org/apache/commons/io/FileUtils.java
##
@@ -1603,93 +1598,272 @@ public static boolean isFileNewer(final File file,
final File reference) {
}
/**
- * Tests if the specified File is newer than the specified
- * time reference.
+ * Tests if the specified {@code File} is newer than the specified time
reference.
*
- * @param file the File of which the modification date
must
- * be compared, must not be {@code null}
+ * @param file the {@code File} of which the modification date must
be compared
* @param timeMillis the time reference measured in milliseconds since the
* epoch (00:00:00 GMT, January 1, 1970)
- * @return true if the File exists and has been modified after
- * the given time reference.
- * @throws IllegalArgumentException if the file is {@code null}
+ * @return true if the {@code File} exists and has been modified after the
given time reference.
+ * @throws NullPointerException if the file is {@code null}
*/
public static boolean isFileNewer(final File file, final long timeMillis) {
-if (file == null) {
-throw new IllegalArgumentException("No specified file");
-}
+Objects.requireNonNull(file, "file");
if (!file.exists()) {
return false;
}
return file.lastModified() > timeMillis;
}
/**
- * Tests if the specified File is older than the specified
- * Date.
+ * Tests if the specified {@code File} is newer than the specified {@code
Instant}.
+ *
+ * @param filethe {@code File} of which the modification date must be
compared
+ * @param instant the date reference
+ * @return true if the {@code File} exists and has been modified after the
given {@code Instant}.
+ * @throws NullPointerException if the file or instant is {@code null}
+ *
+ * @since 2.8
+ */
+public static boolean isFileNewer(final File file, final Instant instant) {
Review comment:
@garydgregory My bad, I'll do so now.
@chtompki Thanks for the suggestion, I'll update the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IO-676) Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
[
https://issues.apache.org/jira/browse/IO-676?focusedWorklogId=468380=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468380
]
ASF GitHub Bot logged work on IO-676:
-
Author: ASF GitHub Bot
Created on: 10/Aug/20 03:24
Start Date: 10/Aug/20 03:24
Worklog Time Spent: 10m
Work Description: Isira-Seneviratne commented on a change in pull request
#124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r467672456
##
File path: src/main/java/org/apache/commons/io/FileUtils.java
##
@@ -1603,93 +1598,272 @@ public static boolean isFileNewer(final File file,
final File reference) {
}
/**
- * Tests if the specified File is newer than the specified
- * time reference.
+ * Tests if the specified {@code File} is newer than the specified time
reference.
*
- * @param file the File of which the modification date
must
- * be compared, must not be {@code null}
+ * @param file the {@code File} of which the modification date must
be compared
* @param timeMillis the time reference measured in milliseconds since the
* epoch (00:00:00 GMT, January 1, 1970)
- * @return true if the File exists and has been modified after
- * the given time reference.
- * @throws IllegalArgumentException if the file is {@code null}
+ * @return true if the {@code File} exists and has been modified after the
given time reference.
+ * @throws NullPointerException if the file is {@code null}
*/
public static boolean isFileNewer(final File file, final long timeMillis) {
-if (file == null) {
-throw new IllegalArgumentException("No specified file");
-}
+Objects.requireNonNull(file, "file");
if (!file.exists()) {
return false;
}
return file.lastModified() > timeMillis;
}
/**
- * Tests if the specified File is older than the specified
- * Date.
+ * Tests if the specified {@code File} is newer than the specified {@code
Instant}.
+ *
+ * @param filethe {@code File} of which the modification date must be
compared
+ * @param instant the date reference
+ * @return true if the {@code File} exists and has been modified after the
given {@code Instant}.
+ * @throws NullPointerException if the file or instant is {@code null}
+ *
+ * @since 2.8
+ */
+public static boolean isFileNewer(final File file, final Instant instant) {
Review comment:
@garydgregory My bad, I'll do so now.
@chtompki How should the conversion be done?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468380)
Time Spent: 4h 50m (was: 4h 40m)
> Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time
> API.
> --
>
> Key: IO-676
> URL: https://issues.apache.org/jira/browse/IO-676
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
>Reporter: Isira Seneviratne
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] Isira-Seneviratne commented on a change in pull request #124: [IO-676] Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
Isira-Seneviratne commented on a change in pull request #124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r467672456
##
File path: src/main/java/org/apache/commons/io/FileUtils.java
##
@@ -1603,93 +1598,272 @@ public static boolean isFileNewer(final File file,
final File reference) {
}
/**
- * Tests if the specified File is newer than the specified
- * time reference.
+ * Tests if the specified {@code File} is newer than the specified time
reference.
*
- * @param file the File of which the modification date
must
- * be compared, must not be {@code null}
+ * @param file the {@code File} of which the modification date must
be compared
* @param timeMillis the time reference measured in milliseconds since the
* epoch (00:00:00 GMT, January 1, 1970)
- * @return true if the File exists and has been modified after
- * the given time reference.
- * @throws IllegalArgumentException if the file is {@code null}
+ * @return true if the {@code File} exists and has been modified after the
given time reference.
+ * @throws NullPointerException if the file is {@code null}
*/
public static boolean isFileNewer(final File file, final long timeMillis) {
-if (file == null) {
-throw new IllegalArgumentException("No specified file");
-}
+Objects.requireNonNull(file, "file");
if (!file.exists()) {
return false;
}
return file.lastModified() > timeMillis;
}
/**
- * Tests if the specified File is older than the specified
- * Date.
+ * Tests if the specified {@code File} is newer than the specified {@code
Instant}.
+ *
+ * @param filethe {@code File} of which the modification date must be
compared
+ * @param instant the date reference
+ * @return true if the {@code File} exists and has been modified after the
given {@code Instant}.
+ * @throws NullPointerException if the file or instant is {@code null}
+ *
+ * @since 2.8
+ */
+public static boolean isFileNewer(final File file, final Instant instant) {
Review comment:
@garydgregory My bad, I'll do so now.
@chtompki How should the conversion be done?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1504) StopWatch: steps feature
[
https://issues.apache.org/jira/browse/LANG-1504?focusedWorklogId=468360=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468360
]
ASF GitHub Bot logged work on LANG-1504:
Author: ASF GitHub Bot
Created on: 10/Aug/20 01:10
Start Date: 10/Aug/20 01:10
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #482:
URL: https://github.com/apache/commons-lang/pull/482#issuecomment-671126821
[](https://coveralls.io/builds/32635377)
Coverage decreased (-0.4%) to 94.655% when pulling
**667a71347e9f4ab5a167bfad749d67c6555cac8d on
topera:LANG-1504-steps-on-stopwatch** into
**a606a0328ba4b3061c5bc810a31418fa4251ea16 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468360)
Time Spent: 3h (was: 2h 50m)
> StopWatch: steps feature
>
>
> Key: LANG-1504
> URL: https://issues.apache.org/jira/browse/LANG-1504
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.time.*
>Reporter: Topera
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Would be great if we could use StopWatch to track times on many places of our
> code.
> I created a new feature called "*steps*".
>
> With this feature we can add label to each step and then get a report with
> time between each step.
>
> Example:
> {code:java}
> final StopWatch watch = new StopWatch();
> watch.step("starting");
> exampleGoSleep();
> watch.step("sleeping");
> exampleGoWalk();
> watch.step("walking ");
> exampleGoDance();
> watch.step("dancing ");
> System.out.println(watch.getStepsReport());
> {code}
> The output would be:
> {noformat}
> [starting] 0ms
> [sleeping] 235ms
> [walking ] 20ms
> [dancing ] 458ms
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #482: LANG-1504 - Adding labels to split StopWatch feature
coveralls commented on pull request #482: URL: https://github.com/apache/commons-lang/pull/482#issuecomment-671126821 [](https://coveralls.io/builds/32635377) Coverage decreased (-0.4%) to 94.655% when pulling **667a71347e9f4ab5a167bfad749d67c6555cac8d on topera:LANG-1504-steps-on-stopwatch** into **a606a0328ba4b3061c5bc810a31418fa4251ea16 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1504) StopWatch: steps feature
[
https://issues.apache.org/jira/browse/LANG-1504?focusedWorklogId=468359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468359
]
ASF GitHub Bot logged work on LANG-1504:
Author: ASF GitHub Bot
Created on: 10/Aug/20 01:00
Start Date: 10/Aug/20 01:00
Worklog Time Spent: 10m
Work Description: topera commented on a change in pull request #482:
URL: https://github.com/apache/commons-lang/pull/482#discussion_r467651878
##
File path: src/main/java/org/apache/commons/lang3/time/StopWatch.java
##
@@ -606,4 +681,175 @@ public void unsplit() {
this.splitState = SplitState.UNSPLIT;
}
+/**
+ * Stops the watch and returns the list of splits with duration on each
split
+ * @return list of splits
+ */
+public List getProcessedSplits() {
+return getProcessedSplits(false);
+}
+
+/**
+ * Stops the watch and returns the list of splits with duration on each
split (using milliseconds)
+ * @return list of splits
+ */
+public List getNanoProcessedSplits() {
+return getProcessedSplits(true);
+}
+
+/**
+ * Stops the watch and returns the list of splits with duration on each
split
+ *
+ * @param useNanos if must use nanoseconds precision
+ * @return list of splits
+ */
+public List getProcessedSplits(boolean useNanos) {
Review comment:
Good idea, since it makes the code more clear. I'll change here. Thank
you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468359)
Time Spent: 2h 50m (was: 2h 40m)
> StopWatch: steps feature
>
>
> Key: LANG-1504
> URL: https://issues.apache.org/jira/browse/LANG-1504
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.time.*
>Reporter: Topera
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Would be great if we could use StopWatch to track times on many places of our
> code.
> I created a new feature called "*steps*".
>
> With this feature we can add label to each step and then get a report with
> time between each step.
>
> Example:
> {code:java}
> final StopWatch watch = new StopWatch();
> watch.step("starting");
> exampleGoSleep();
> watch.step("sleeping");
> exampleGoWalk();
> watch.step("walking ");
> exampleGoDance();
> watch.step("dancing ");
> System.out.println(watch.getStepsReport());
> {code}
> The output would be:
> {noformat}
> [starting] 0ms
> [sleeping] 235ms
> [walking ] 20ms
> [dancing ] 458ms
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] topera commented on a change in pull request #482: LANG-1504 - Adding labels to split StopWatch feature
topera commented on a change in pull request #482:
URL: https://github.com/apache/commons-lang/pull/482#discussion_r467651878
##
File path: src/main/java/org/apache/commons/lang3/time/StopWatch.java
##
@@ -606,4 +681,175 @@ public void unsplit() {
this.splitState = SplitState.UNSPLIT;
}
+/**
+ * Stops the watch and returns the list of splits with duration on each
split
+ * @return list of splits
+ */
+public List getProcessedSplits() {
+return getProcessedSplits(false);
+}
+
+/**
+ * Stops the watch and returns the list of splits with duration on each
split (using milliseconds)
+ * @return list of splits
+ */
+public List getNanoProcessedSplits() {
+return getProcessedSplits(true);
+}
+
+/**
+ * Stops the watch and returns the list of splits with duration on each
split
+ *
+ * @param useNanos if must use nanoseconds precision
+ * @return list of splits
+ */
+public List getProcessedSplits(boolean useNanos) {
Review comment:
Good idea, since it makes the code more clear. I'll change here. Thank
you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-crypto] coveralls commented on pull request #106: Standardizing Release Build Process with Docker
coveralls commented on pull request #106: URL: https://github.com/apache/commons-crypto/pull/106#issuecomment-671121672 [](https://coveralls.io/builds/32635154) Coverage decreased (-0.5%) to 82.317% when pulling **9d2b081593b6c45390de3ee7e95a6db97b605e7c on aremily:dockerize** into **a2bc3a41e10fb367d6d5e3a16a29c18d1b7bb3f9 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] aremily opened a new pull request #106: Standardizing Release Build Process with Docker
aremily opened a new pull request #106: URL: https://github.com/apache/commons-crypto/pull/106 This PR replaces a previous closed PR and has a cleaner commit history. It provides a Dockerfile that automates the build for the following architectures: Linux-x86_64 Linux-arm Linux-armhf LInux-aarch64 Win64 Per previous reviews, it leverages Ubuntu 14.04 as the base image. If the Dockerfile is run from a Mac following a successful build, it will include the Mac build by virtue of copying the build directory into the Docker image. Also included for convenience is a Maven profile that provides an option for running the Dockerfile from Maven. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (BCEL-341) Incorrectly reads and writes class version <= 45.2 (oak) class file.
[ https://issues.apache.org/jira/browse/BCEL-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hippo updated BCEL-341: --- Comment: was deleted (was: Created a patch here https://github.com/Hippo/commons-bcel/tree/BCEL-341) > Incorrectly reads and writes class version <= 45.2 (oak) class file. > > > Key: BCEL-341 > URL: https://issues.apache.org/jira/browse/BCEL-341 > Project: Commons BCEL > Issue Type: Bug > Components: Parser >Affects Versions: unspecified >Reporter: Hippo >Priority: Major > Labels: easyfix > Fix For: unspecified > > > Whenever you attempt to parse a class file (version <= 45.2) the parser will > crash due to the code attribute's maxStack, maxLocals, and codeLength being > half the size. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173949#comment-17173949 ] Phil Steitz edited comment on DBCP-559 at 8/9/20, 6:44 PM: --- PR is [here|https://github.com/apache/commons-dbcp/pull/50]. * One thing missing in the list above, but made clear in javadoc is that connections checked out when restart is invoked don't count in the "new" pool's metrics. So for example if there are 3 out when restart or close - start is called, there may be as many as maxTotal + 3 out until the old ones get returned. It would be a little complicated to try to keep those connections in the post-restart counts. * I included no-op defaults for start (called "open" above) and restart in the interface spec to preserve backward compatibility. Any better ideas on how to handle that welcome. * I did not include eviction timer leak tests or much else to verify no side effects. More tests would be good. * Checkstyle now says BDS is too big. was (Author: psteitz): PR is [here|https://github.com/apache/commons-dbcp/pull/50]. * One thing missing in the list above, but made clear in javadoc is that connections checked out when restart is invoked don't count in the "new" pool's metrics. So for example if there are 3 out when restart or close - start is called, they may be as many as maxTotal + 3 out until the old ones get returned. It would be a little complicated to try to keep those connections in the post-restart counts. * I included no-op defaults for start (called "open" above) and restart in the interface spec to preserve backward compatibility. Any better ideas on how to handle that welcome. * I did not include eviction timer leak tests or much else to verify no side effects. More tests would be good. * Checkstyle now says BDS is too big. > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173949#comment-17173949 ] Phil Steitz commented on DBCP-559: -- PR is [here|https://github.com/apache/commons-dbcp/pull/50]. * One thing missing in the list above, but made clear in javadoc is that connections checked out when restart is invoked don't count in the "new" pool's metrics. So for example if there are 3 out when restart or close - start is called, they may be as many as maxTotal + 3 out until the old ones get returned. It would be a little complicated to try to keep those connections in the post-restart counts. * I included no-op defaults for start (called "open" above) and restart in the interface spec to preserve backward compatibility. Any better ideas on how to handle that welcome. * I did not include eviction timer leak tests or much else to verify no side effects. More tests would be good. * Checkstyle now says BDS is too big. > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?focusedWorklogId=468343=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468343 ] ASF GitHub Bot logged work on DBCP-559: --- Author: ASF GitHub Bot Created on: 09/Aug/20 18:26 Start Date: 09/Aug/20 18:26 Worklog Time Spent: 10m Work Description: psteitz opened a new pull request #50: URL: https://github.com/apache/commons-dbcp/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468343) Remaining Estimate: 50m (was: 1h) Time Spent: 10m > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-dbcp] psteitz opened a new pull request #50: Add start, restart methods to BasicDataSource. JIRA: DBCP-559.
psteitz opened a new pull request #50: URL: https://github.com/apache/commons-dbcp/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468339=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468339
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 09/Aug/20 16:49
Start Date: 09/Aug/20 16:49
Worklog Time Spent: 10m
Work Description: sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467604760
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
+return str;
}
-} else if (last != CharUtils.CR) {
-lastIdx++;
+} else if (str.charAt(lastIdx - 1) == CharUtils.CR) {
+--lastIdx;
Review comment:
Better to use lastIdx-- here - don't make unnecessary changes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468339)
Time Spent: 4h 50m (was: 4h 40m)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] sebbASF commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467604760
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
+return str;
}
-} else if (last != CharUtils.CR) {
-lastIdx++;
+} else if (str.charAt(lastIdx - 1) == CharUtils.CR) {
+--lastIdx;
Review comment:
Better to use lastIdx-- here - don't make unnecessary changes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468338
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 09/Aug/20 16:47
Start Date: 09/Aug/20 16:47
Worklog Time Spent: 10m
Work Description: sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467604598
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
Review comment:
The changes would be clearer if the original condition had been kept.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468338)
Time Spent: 4h 40m (was: 4.5h)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] sebbASF commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r467604598
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -697,27 +697,29 @@ public static String center(String str, final int size,
String padStr) {
* @return String without newline, {@code null} if null String input
*/
public static String chomp(final String str) {
-if (isEmpty(str)) {
+final int length = length(str);
+
+if (length == 0) {
return str;
}
-if (str.length() == 1) {
+if (length == 1) {
final char ch = str.charAt(0);
if (ch == CharUtils.CR || ch == CharUtils.LF) {
return EMPTY;
}
return str;
}
-int lastIdx = str.length() - 1;
+int lastIdx = length - 1;
final char last = str.charAt(lastIdx);
-if (last == CharUtils.LF) {
-if (str.charAt(lastIdx - 1) == CharUtils.CR) {
-lastIdx--;
+if (last != CharUtils.LF) {
+if (last != CharUtils.CR) {
Review comment:
The changes would be clearer if the original condition had been kept.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] sebbASF merged pull request #116: refine travis-ci scripts
sebbASF merged pull request #116: URL: https://github.com/apache/commons-io/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] asfgit merged pull request #98: GEOMETRY-63: Reduce method complexity
asfgit merged pull request #98: URL: https://github.com/apache/commons-geometry/pull/98 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r opened a new pull request #98: GEOMETRY-63: Reduce method complexity
darkma773r opened a new pull request #98: URL: https://github.com/apache/commons-geometry/pull/98 Reducing the complexity of several methods based on SonarQube recommendations. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-601) requesting 2.6 tag for Commons IO's release version 2.6
[ https://issues.apache.org/jira/browse/IO-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-601. - Resolution: Fixed https://github.com/apache/commons-io/tree/commons-io-2.6 Sorry for the delay > requesting 2.6 tag for Commons IO's release version 2.6 > --- > > Key: IO-601 > URL: https://issues.apache.org/jira/browse/IO-601 > Project: Commons IO > Issue Type: Task > Components: Utilities >Affects Versions: 2.6 >Reporter: Jianfeng Tai >Priority: Major > > Hi, For release 2.6, I can see only RC builds are there, Could you please > create tag for official 2.6 release. Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IO-624) IOUtils.writeLines updating incompatible issue
[
https://issues.apache.org/jira/browse/IO-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved IO-624.
-
Resolution: Information Provided
> IOUtils.writeLines updating incompatible issue
> --
>
> Key: IO-624
> URL: https://issues.apache.org/jira/browse/IO-624
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.6
>Reporter: xia0c
>Priority: Major
>
> Hi,
> The following code snippets throw an incompatible issue when I try to rolling
> update Commons-io from 2.2 to 2.6.
> {code:java}
> @Test
> public void test() throws IOException{
>
> File TestFile = new File( "test.txt" );
> OutputStream out = null;
> List lines = Arrays.asList("a","b","c");
> try {
> out = new FileOutputStream(TestFile, true);
> IOUtils.writeLines(lines, null, out, null);
> } finally {
> IOUtils.closeQuietly(out);
> }
> {code}
> It throws an error:
> {code:java}
> error: reference to writeLines is ambiguous
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (IO-623) IOUtils.lineIterator updating incompatible issue
[
https://issues.apache.org/jira/browse/IO-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved IO-623.
-
Resolution: Information Provided
> IOUtils.lineIterator updating incompatible issue
>
>
> Key: IO-623
> URL: https://issues.apache.org/jira/browse/IO-623
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.6
>Reporter: xia0c
>Priority: Major
> Labels: performance
>
> Hi,
> The following code snippets throw an incompatible issue when I try to rolling
> update Commons-io from 2.1 to 2.6.
> {code:java}
> // Some comments here
> @Test
> public void Test() throws IOException{
> LineIterator iter = IOUtils.lineIterator (getClass
> ().getResourceAsStream ("/tmp/test.txt"), null);
> }
> {code}
> It throws an error:
> {code:java}
> reference to lineIterator is ambiguous
> [ERROR] both method
> lineIterator(java.io.InputStream,java.nio.charset.Charset) in
> org.apache.commons.io.IOUtils and method
> lineIterator(java.io.InputStream,java.lang.String) in
> org.apache.commons.io.IOUtils match
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (IO-655) Upgrade Hamcrest v2.2
[ https://issues.apache.org/jira/browse/IO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-655. - Resolution: Won't Do Project does not use Hamcrest > Upgrade Hamcrest v2.2 > - > > Key: IO-655 > URL: https://issues.apache.org/jira/browse/IO-655 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 2, update to hamcrest v2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] sebbASF commented on pull request #106: IO-655 add hamcrest v2.2
sebbASF commented on pull request #106: URL: https://github.com/apache/commons-io/pull/106#issuecomment-671054343 Won't do This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] sebbASF closed pull request #106: IO-655 add hamcrest v2.2
sebbASF closed pull request #106: URL: https://github.com/apache/commons-io/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-655) Upgrade Hamcrest v2.2
[ https://issues.apache.org/jira/browse/IO-655?focusedWorklogId=468332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468332 ] ASF GitHub Bot logged work on IO-655: - Author: ASF GitHub Bot Created on: 09/Aug/20 13:49 Start Date: 09/Aug/20 13:49 Worklog Time Spent: 10m Work Description: sebbASF commented on pull request #106: URL: https://github.com/apache/commons-io/pull/106#issuecomment-671054343 Won't do This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468332) Time Spent: 40m (was: 0.5h) > Upgrade Hamcrest v2.2 > - > > Key: IO-655 > URL: https://issues.apache.org/jira/browse/IO-655 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 2, update to hamcrest v2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-655) Upgrade Hamcrest v2.2
[ https://issues.apache.org/jira/browse/IO-655?focusedWorklogId=468333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468333 ] ASF GitHub Bot logged work on IO-655: - Author: ASF GitHub Bot Created on: 09/Aug/20 13:49 Start Date: 09/Aug/20 13:49 Worklog Time Spent: 10m Work Description: sebbASF closed pull request #106: URL: https://github.com/apache/commons-io/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468333) Time Spent: 50m (was: 40m) > Upgrade Hamcrest v2.2 > - > > Key: IO-655 > URL: https://issues.apache.org/jira/browse/IO-655 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 2, update to hamcrest v2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IO-657) Update to Jacoco v0.8.5
[ https://issues.apache.org/jira/browse/IO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-657. - Fix Version/s: 2.8 Resolution: Fixed Jacoco is already at 0.8.5 > Update to Jacoco v0.8.5 > --- > > Key: IO-657 > URL: https://issues.apache.org/jira/browse/IO-657 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Fix For: 2.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 4, update maven-dependencies to latest for compiler, jar, install -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IO-656) Upgrade to JUnit v5.6.0
[ https://issues.apache.org/jira/browse/IO-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-656. - Fix Version/s: 2.8 Resolution: Fixed Junit is already at 5.6.2 > Upgrade to JUnit v5.6.0 > --- > > Key: IO-656 > URL: https://issues.apache.org/jira/browse/IO-656 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Fix For: 2.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 3, update to junit v5.6 (jupiter and vintage) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CRYPTO-149) testGcmTamperedData() in GCMCipherTest Intermittent Failure
[ https://issues.apache.org/jira/browse/CRYPTO-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173727#comment-17173727 ] Alex Remily edited comment on CRYPTO-149 at 8/9/20, 1:44 PM: - This is the PR with the fix: https://github.com/apache/commons-crypto/pull/105 was (Author: aremily): This is the PR with the fix: https://github.com/apache/commons-crypto/pull/103 > testGcmTamperedData() in GCMCipherTest Intermittent Failure > --- > > Key: CRYPTO-149 > URL: https://issues.apache.org/jira/browse/CRYPTO-149 > Project: Commons Crypto > Issue Type: Bug > Components: Cipher >Affects Versions: 1.0.0, 1.1.0 >Reporter: Alex Remily >Priority: Major > Fix For: 1.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Gary Gregory > Aug 5, 2020, 10:53 PM (20 hours ago) > to Commons > Hi All: > I am seeing what may be a random AEADBadTagException in GcmCipherTest? > For example: > [ERROR] testGcmTamperedData(org.apache.commons.crypto.cipher.GcmCipherTest) > Time elapsed: 0.015 s <<< ERROR! > 881java.lang.Exception: Unexpected exception, > expected but > was > 882 at > org.apache.commons.crypto.cipher.GcmCipherTest.testGcmTamperedData(GcmCipherTest.java:224) > 883 > 884 > Any thoughts? > The above is from > https://travis-ci.org/github/apache/commons-crypto/jobs/715348986 > Gary > Alex Remily > 8:10 AM (11 hours ago) > to Commons > That is an intermittent issue that I haven't been able to reliably reproduce. > As I recall, the test that's failing is supposed to fail, but in a different > way. I think it's supposed to fail because of a short buffer but > occasionally fails because of an internal error, and when that happens this > test fails. I don't know when it was introduced. We should probably > document it in jira and or realese notes. > Matt Sicker > 10:33 AM (8 hours ago) > to Commons > Now I hope we don't have unit tests depending on non-static state for > its random number generator! ;) I'd expect a crypto library's test > suites to include several hard-coded known-good and known-bad > ciphertexts with static keys/IVs similar to the test cases presented > in their RFCs (especially since said tests are typically small enough > to copy/paste the binary data fairly easily). > -- > Matt Sicker > Rob Tompkins > 10:37 AM (8 hours ago) > to Commons > We actually do have a considerable number of those in our projects where we > use probabilistic epsilons on the output. See commons-rng. Note, Gilles is > quite good at writing such tests. > -Rob > Matt Sicker > 10:42 AM (8 hours ago) > to Commons > Well, for testing RNGs, I can understand using property testing, yes. > It would also be useful for testing fuzzing scenarios like making sure > the GCM tag is invalid for any random input data (giving a near zero > probability of valid data) or that an elliptic curve implementation > doesn't leak out information about points outside the curve or respond > to invalid inputs improperly or things like that. > Rob Tompkins > 10:50 AM (8 hours ago) > to Commons > +1 - the elliptic curve stuff I’ll have to defer to you on as I’m less a > number theorist and more of a logician. > -Rob > Gary Gregory > 10:56 AM (8 hours ago) > to Commons > This is all fine and good but how would you fix the test such that it does > not fail randomly. PR anyone? > Gary > Rob Tompkins > 10:57 AM (8 hours ago) > to Commons > Either static inputs for determinism, or putting a probabilistic boundary in > which the solution can fall. > -Rob > Matt Sicker > 11:00 AM (8 hours ago) > to Commons > Choose a seed value for the `new Random()` constructor and the tests > will be deterministic. > Matt Sicker > 11:02 AM (8 hours ago) > to Commons > Or alternatively, if using random values each time, have it retry the > test with a different value. It's typically better to use an actual > property testing library for these types of tests anyways. One example > library I found is https://jqwik.net/ (these types of testing > libraries are more common in functional programming like in Scala). > Rob Tompkins > 11:03 AM (8 hours ago) > to Commons > Precisely. That’s another technique we’ve used in rng. > -Ropb -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (CRYPTO-149) testGcmTamperedData() in GCMCipherTest Intermittent Failure
[ https://issues.apache.org/jira/browse/CRYPTO-149?focusedWorklogId=468330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468330 ] ASF GitHub Bot logged work on CRYPTO-149: - Author: ASF GitHub Bot Created on: 09/Aug/20 13:33 Start Date: 09/Aug/20 13:33 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #105: URL: https://github.com/apache/commons-crypto/pull/105#issuecomment-671052746 [](https://coveralls.io/builds/32630758) Coverage remained the same at 82.867% when pulling **470fa02c3b0e27bfa74247ded793f8ab0758f799 on aremily:gcmtestfix** into **a2bc3a41e10fb367d6d5e3a16a29c18d1b7bb3f9 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468330) Time Spent: 20m (was: 10m) > testGcmTamperedData() in GCMCipherTest Intermittent Failure > --- > > Key: CRYPTO-149 > URL: https://issues.apache.org/jira/browse/CRYPTO-149 > Project: Commons Crypto > Issue Type: Bug > Components: Cipher >Affects Versions: 1.0.0, 1.1.0 >Reporter: Alex Remily >Priority: Major > Fix For: 1.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Gary Gregory > Aug 5, 2020, 10:53 PM (20 hours ago) > to Commons > Hi All: > I am seeing what may be a random AEADBadTagException in GcmCipherTest? > For example: > [ERROR] testGcmTamperedData(org.apache.commons.crypto.cipher.GcmCipherTest) > Time elapsed: 0.015 s <<< ERROR! > 881java.lang.Exception: Unexpected exception, > expected but > was > 882 at > org.apache.commons.crypto.cipher.GcmCipherTest.testGcmTamperedData(GcmCipherTest.java:224) > 883 > 884 > Any thoughts? > The above is from > https://travis-ci.org/github/apache/commons-crypto/jobs/715348986 > Gary > Alex Remily > 8:10 AM (11 hours ago) > to Commons > That is an intermittent issue that I haven't been able to reliably reproduce. > As I recall, the test that's failing is supposed to fail, but in a different > way. I think it's supposed to fail because of a short buffer but > occasionally fails because of an internal error, and when that happens this > test fails. I don't know when it was introduced. We should probably > document it in jira and or realese notes. > Matt Sicker > 10:33 AM (8 hours ago) > to Commons > Now I hope we don't have unit tests depending on non-static state for > its random number generator! ;) I'd expect a crypto library's test > suites to include several hard-coded known-good and known-bad > ciphertexts with static keys/IVs similar to the test cases presented > in their RFCs (especially since said tests are typically small enough > to copy/paste the binary data fairly easily). > -- > Matt Sicker > Rob Tompkins > 10:37 AM (8 hours ago) > to Commons > We actually do have a considerable number of those in our projects where we > use probabilistic epsilons on the output. See commons-rng. Note, Gilles is > quite good at writing such tests. > -Rob > Matt Sicker > 10:42 AM (8 hours ago) > to Commons > Well, for testing RNGs, I can understand using property testing, yes. > It would also be useful for testing fuzzing scenarios like making sure > the GCM tag is invalid for any random input data (giving a near zero > probability of valid data) or that an elliptic curve implementation > doesn't leak out information about points outside the curve or respond > to invalid inputs improperly or things like that. > Rob Tompkins > 10:50 AM (8 hours ago) > to Commons > +1 - the elliptic curve stuff I’ll have to defer to you on as I’m less a > number theorist and more of a logician. > -Rob > Gary Gregory > 10:56 AM (8 hours ago) > to Commons > This is all fine and good but how would you fix the test such that it does > not fail randomly. PR anyone? > Gary > Rob Tompkins > 10:57 AM (8 hours ago) > to Commons > Either static inputs for determinism, or putting a probabilistic boundary in > which the solution can fall. > -Rob > Matt Sicker > 11:00 AM (8 hours ago) > to Commons > Choose a seed value for the `new Random()` constructor and the tests > will be deterministic. > Matt Sicker > 11:02 AM (8 hours ago) > to Commons > Or alternatively, if using random values each time, have it retry the > test with a different value. It's typically better to use an actual > property testing library for these types of tests anyways. One example > library I
[GitHub] [commons-crypto] coveralls commented on pull request #105: Addresses https://issues.apache.org/jira/browse/CRYPTO-149
coveralls commented on pull request #105: URL: https://github.com/apache/commons-crypto/pull/105#issuecomment-671052746 [](https://coveralls.io/builds/32630758) Coverage remained the same at 82.867% when pulling **470fa02c3b0e27bfa74247ded793f8ab0758f799 on aremily:gcmtestfix** into **a2bc3a41e10fb367d6d5e3a16a29c18d1b7bb3f9 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] aremily opened a new pull request #105: Addresses https://issues.apache.org/jira/browse/CRYPTO-149
aremily opened a new pull request #105: URL: https://github.com/apache/commons-crypto/pull/105 Fixes the test bug by restricting the initialization vector length to only valid values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CRYPTO-149) testGcmTamperedData() in GCMCipherTest Intermittent Failure
[ https://issues.apache.org/jira/browse/CRYPTO-149?focusedWorklogId=468329=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468329 ] ASF GitHub Bot logged work on CRYPTO-149: - Author: ASF GitHub Bot Created on: 09/Aug/20 13:27 Start Date: 09/Aug/20 13:27 Worklog Time Spent: 10m Work Description: aremily opened a new pull request #105: URL: https://github.com/apache/commons-crypto/pull/105 Fixes the test bug by restricting the initialization vector length to only valid values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468329) Remaining Estimate: 0h Time Spent: 10m > testGcmTamperedData() in GCMCipherTest Intermittent Failure > --- > > Key: CRYPTO-149 > URL: https://issues.apache.org/jira/browse/CRYPTO-149 > Project: Commons Crypto > Issue Type: Bug > Components: Cipher >Affects Versions: 1.0.0, 1.1.0 >Reporter: Alex Remily >Priority: Major > Fix For: 1.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Gary Gregory > Aug 5, 2020, 10:53 PM (20 hours ago) > to Commons > Hi All: > I am seeing what may be a random AEADBadTagException in GcmCipherTest? > For example: > [ERROR] testGcmTamperedData(org.apache.commons.crypto.cipher.GcmCipherTest) > Time elapsed: 0.015 s <<< ERROR! > 881java.lang.Exception: Unexpected exception, > expected but > was > 882 at > org.apache.commons.crypto.cipher.GcmCipherTest.testGcmTamperedData(GcmCipherTest.java:224) > 883 > 884 > Any thoughts? > The above is from > https://travis-ci.org/github/apache/commons-crypto/jobs/715348986 > Gary > Alex Remily > 8:10 AM (11 hours ago) > to Commons > That is an intermittent issue that I haven't been able to reliably reproduce. > As I recall, the test that's failing is supposed to fail, but in a different > way. I think it's supposed to fail because of a short buffer but > occasionally fails because of an internal error, and when that happens this > test fails. I don't know when it was introduced. We should probably > document it in jira and or realese notes. > Matt Sicker > 10:33 AM (8 hours ago) > to Commons > Now I hope we don't have unit tests depending on non-static state for > its random number generator! ;) I'd expect a crypto library's test > suites to include several hard-coded known-good and known-bad > ciphertexts with static keys/IVs similar to the test cases presented > in their RFCs (especially since said tests are typically small enough > to copy/paste the binary data fairly easily). > -- > Matt Sicker > Rob Tompkins > 10:37 AM (8 hours ago) > to Commons > We actually do have a considerable number of those in our projects where we > use probabilistic epsilons on the output. See commons-rng. Note, Gilles is > quite good at writing such tests. > -Rob > Matt Sicker > 10:42 AM (8 hours ago) > to Commons > Well, for testing RNGs, I can understand using property testing, yes. > It would also be useful for testing fuzzing scenarios like making sure > the GCM tag is invalid for any random input data (giving a near zero > probability of valid data) or that an elliptic curve implementation > doesn't leak out information about points outside the curve or respond > to invalid inputs improperly or things like that. > Rob Tompkins > 10:50 AM (8 hours ago) > to Commons > +1 - the elliptic curve stuff I’ll have to defer to you on as I’m less a > number theorist and more of a logician. > -Rob > Gary Gregory > 10:56 AM (8 hours ago) > to Commons > This is all fine and good but how would you fix the test such that it does > not fail randomly. PR anyone? > Gary > Rob Tompkins > 10:57 AM (8 hours ago) > to Commons > Either static inputs for determinism, or putting a probabilistic boundary in > which the solution can fall. > -Rob > Matt Sicker > 11:00 AM (8 hours ago) > to Commons > Choose a seed value for the `new Random()` constructor and the tests > will be deterministic. > Matt Sicker > 11:02 AM (8 hours ago) > to Commons > Or alternatively, if using random values each time, have it retry the > test with a different value. It's typically better to use an actual > property testing library for these types of tests anyways. One example > library I found is https://jqwik.net/ (these types of testing > libraries are more common in functional programming like in Scala). > Rob Tompkins > 11:03 AM (8 hours ago) > to Commons > Precisely. That’s another technique
[GitHub] [commons-crypto] aremily closed pull request #100: Add support for Java 11
aremily closed pull request #100: URL: https://github.com/apache/commons-crypto/pull/100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] aremily closed pull request #103: Standardize the release build process with Docker.
aremily closed pull request #103: URL: https://github.com/apache/commons-crypto/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] coveralls edited a comment on pull request #103: Standardize the release build process with Docker.
coveralls edited a comment on pull request #103: URL: https://github.com/apache/commons-crypto/pull/103#issuecomment-667682795 [](https://coveralls.io/builds/32630541) Coverage decreased (-0.2%) to 82.867% when pulling **591434cbe1f3e4ff4b9589ea53634094f9d59df1 on aremily:build** into **c2b0e6e736c3d7f8379671ddfb9175f7c7f68283 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-682) Add lines() methods for InputStream and Reader.
[ https://issues.apache.org/jira/browse/IO-682?focusedWorklogId=468326=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468326 ] ASF GitHub Bot logged work on IO-682: - Author: ASF GitHub Bot Created on: 09/Aug/20 12:55 Start Date: 09/Aug/20 12:55 Worklog Time Spent: 10m Work Description: sebbASF commented on pull request #139: URL: https://github.com/apache/commons-io/pull/139#issuecomment-671048723 Thanks, but the extra code is not worth the minimal reduction in user code (see the JIRA issue) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468326) Time Spent: 50m (was: 40m) > Add lines() methods for InputStream and Reader. > --- > > Key: IO-682 > URL: https://issues.apache.org/jira/browse/IO-682 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Reporter: Isira Seneviratne >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Add lines() methods that return a Stream object for InputStream and Reader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-682) Add lines() methods for InputStream and Reader.
[ https://issues.apache.org/jira/browse/IO-682?focusedWorklogId=468325=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468325 ] ASF GitHub Bot logged work on IO-682: - Author: ASF GitHub Bot Created on: 09/Aug/20 12:55 Start Date: 09/Aug/20 12:55 Worklog Time Spent: 10m Work Description: sebbASF closed pull request #139: URL: https://github.com/apache/commons-io/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468325) Time Spent: 40m (was: 0.5h) > Add lines() methods for InputStream and Reader. > --- > > Key: IO-682 > URL: https://issues.apache.org/jira/browse/IO-682 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Reporter: Isira Seneviratne >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Add lines() methods that return a Stream object for InputStream and Reader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] sebbASF closed pull request #139: [IO-682] Add lines() methods for InputStream and Reader.
sebbASF closed pull request #139: URL: https://github.com/apache/commons-io/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] sebbASF commented on pull request #139: [IO-682] Add lines() methods for InputStream and Reader.
sebbASF commented on pull request #139: URL: https://github.com/apache/commons-io/pull/139#issuecomment-671048723 Thanks, but the extra code is not worth the minimal reduction in user code (see the JIRA issue) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-682) Add lines() methods for InputStream and Reader.
[ https://issues.apache.org/jira/browse/IO-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-682. - Fix Version/s: (was: 2.8) Resolution: Won't Do > Add lines() methods for InputStream and Reader. > --- > > Key: IO-682 > URL: https://issues.apache.org/jira/browse/IO-682 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Reporter: Isira Seneviratne >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Add lines() methods that return a Stream object for InputStream and Reader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-682) Add lines() methods for InputStream and Reader.
[ https://issues.apache.org/jira/browse/IO-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173846#comment-17173846 ] Sebb commented on IO-682: - Thanks for the suggestion, however AFAICT the requirement is already supported by the following code: IOUtils.buffer(Reader).lines() I'm not sure it's worth the extra methods and ongoing maintenance effort to reduce this to IOUtils.lines(Reader) > Add lines() methods for InputStream and Reader. > --- > > Key: IO-682 > URL: https://issues.apache.org/jira/browse/IO-682 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Reporter: Isira Seneviratne >Priority: Major > Fix For: 2.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Add lines() methods that return a Stream object for InputStream and Reader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173844#comment-17173844
]
Sebb commented on IO-552:
-
The '~' prefix is shell convention, and handled by the shell itself.
The string ~username is replaced by the home directory for the pathname.
The prefix ~/ is replaced by the current user directory.
Note that one can create a file/directory ~username by quoting it:
touch '~username'
mkdir '~username'
Also Java can create a directory as follows:
(new File("~username").mkdir();
It looks like FileNameUtils tries to emulate the behaviour of the shell.
If there are discrepancies, I guess the code should be adjusted to match the
behaviour of the shell.
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (LOGGING-171) Config "[%file:%line] %ndc" leads to unexpected output "[?:?] (null)"
Daniel Gschößer created LOGGING-171:
---
Summary: Config "[%file:%line] %ndc" leads to unexpected output
"[?:?] (null)"
Key: LOGGING-171
URL: https://issues.apache.org/jira/browse/LOGGING-171
Project: Commons Logging
Issue Type: Bug
Affects Versions: 2.0
Environment: dotnet --version
3.1.301
Microsoft™ Windows© Server 2019 Standard
Version 1809
Bestriebssystembuild 17763.720
Reporter: Daniel Gschößer
Hello, I got an issue with "[%file:%line] %ndc".
I assembled in my Program.cs
{code:java}
[assembly: log4net.Config.XmlConfigurator(Watch = true, ConfigFile =
"log4net.config")]{code}
My log4net.config works pretty fine except the "[%file:%line] %ndc" settings.
{code:java}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671021527 Note: All test pass with mvn clean verify This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] Hippo opened a new pull request #58: BCEL-341: Oak class file patch
Hippo opened a new pull request #58: URL: https://github.com/apache/commons-bcel/pull/58 Patches a bug when parsing oak class files (versions <= 45.2) The code attribute's maxStack, maxLocals, codeLength is half the size (u2 -> u1, u4 -> u2) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (BCEL-341) Incorrectly reads and writes class version <= 45.2 (oak) class file.
[ https://issues.apache.org/jira/browse/BCEL-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173769#comment-17173769 ] Hippo commented on BCEL-341: Created a patch here https://github.com/Hippo/commons-bcel/tree/BCEL-341 > Incorrectly reads and writes class version <= 45.2 (oak) class file. > > > Key: BCEL-341 > URL: https://issues.apache.org/jira/browse/BCEL-341 > Project: Commons BCEL > Issue Type: Bug > Components: Parser >Affects Versions: unspecified >Reporter: Hippo >Priority: Major > Labels: easyfix > Fix For: unspecified > > > Whenever you attempt to parse a class file (version <= 45.2) the parser will > crash due to the code attribute's maxStack, maxLocals, and codeLength being > half the size. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (BCEL-341) Incorrectly reads and writes class version <= 45.2 (oak) class file.
Hippo created BCEL-341: -- Summary: Incorrectly reads and writes class version <= 45.2 (oak) class file. Key: BCEL-341 URL: https://issues.apache.org/jira/browse/BCEL-341 Project: Commons BCEL Issue Type: Bug Components: Parser Affects Versions: unspecified Reporter: Hippo Fix For: unspecified Whenever you attempt to parse a class file (version <= 45.2) the parser will crash due to the code attribute's maxStack, maxLocals, and codeLength being half the size. -- This message was sent by Atlassian Jira (v8.3.4#803005)
