[GitHub] [commons-compress] PeterAlfredLee commented on pull request #127: COMPRESS-550 : add writePreamble to ZipArchiveInputStream
PeterAlfredLee commented on pull request #127: URL: https://github.com/apache/commons-compress/pull/127#issuecomment-682278860 Hi all. I'm merging this PR these days. WDYT? @garydgregory @bodewig This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-550) Support writing self-extracting preamble data to a zip archive
[
https://issues.apache.org/jira/browse/COMPRESS-550?focusedWorklogId=475636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475636
]
ASF GitHub Bot logged work on COMPRESS-550:
---
Author: ASF GitHub Bot
Created on: 28/Aug/20 01:48
Start Date: 28/Aug/20 01:48
Worklog Time Spent: 10m
Work Description: PeterAlfredLee commented on pull request #127:
URL: https://github.com/apache/commons-compress/pull/127#issuecomment-682278860
Hi all. I'm merging this PR these days. WDYT? @garydgregory @bodewig
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 475636)
Time Spent: 1h 20m (was: 1h 10m)
> Support writing self-extracting preamble data to a zip archive
> --
>
> Key: COMPRESS-550
> URL: https://issues.apache.org/jira/browse/COMPRESS-550
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
>Affects Versions: 1.20
>Reporter: Scott Frederick
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> On Linux, it is possible to create a self-extracting zip file by prepending a
> script or other executable to the zip file. For example, this can be done
> from the command line with the following commands:
> {code:bash}
> $ echo "test file text" > test.txt
> $ zip test.zip test.txt
> adding: test.txt (stored 0%)
> $ cat /usr/bin/unzipsfx test.zip > test
> $ zipinfo test
> Archive: test
> Zip file size: 101568 bytes, number of entries: 1
> warning [test]: 101392 extra bytes at beginning or within zipfile
> (attempting to process anyway)
> -rw-r--r-- 3.0 unx 10 tx stor 20-Jul-30 15:43 test.txt
> 1 file, 10 bytes uncompressed, 10 bytes compressed: 0.0%
> $ zip --adjust-sfx test.zip
> Zip entry offsets appear off by 101392 bytes - correcting...
> $ zipinfo test
> Archive: test
> Zip file size: 101568 bytes, number of entries: 1
> -rw-r--r-- 3.0 unx 10 tx stor 20-Jul-30 15:43 test.txt
> 1 file, 10 bytes uncompressed, 10 bytes compressed: 0.0%
> $ chmod 755 test
> {code}
> Note that the first invocation of "zipinfo" reports that the central
> directory is invalid because of extra bytes at the beginning of the zip file.
> "zip --adjust-sfx" can be used to adjust the central directory to account for
> the self-extracting preamble bytes.
> It would be nice to be able to prepend this kind of self-extracting preamble
> to a zip using Apache Commons Compress.
> A method like the following on ZipArchiveOutputStream seems to provide this
> behavior:
> {code:java}
> public void writePreamble(byte[] preamble) throws IOException {
> if (entry != null) {
> throw new IllegalStateException("Preamble must be written before
> creating an entry");
> }
> this.streamCompressor.writeCounted(preamble);
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved NUMBERS-149. -- Resolution: Implemented Added to master in commit da53215163ac0e53f16e0d70756d00815602cb87 > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Affects Versions: 1.0-beta1 >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert updated NUMBERS-149: - Affects Version/s: 1.0-beta1 > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Affects Versions: 1.0-beta1 >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475472=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475472 ] ASF GitHub Bot logged work on NUMBERS-149: -- Author: ASF GitHub Bot Created on: 27/Aug/20 18:39 Start Date: 27/Aug/20 18:39 Worklog Time Spent: 10m Work Description: asfgit merged pull request #82: URL: https://github.com/apache/commons-numbers/pull/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475472) Time Spent: 5h 20m (was: 5h 10m) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-numbers] asfgit merged pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
asfgit merged pull request #82: URL: https://github.com/apache/commons-numbers/pull/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475412=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475412 ] ASF GitHub Bot logged work on NUMBERS-149: -- Author: ASF GitHub Bot Created on: 27/Aug/20 16:55 Start Date: 27/Aug/20 16:55 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-680561210 [](https://coveralls.io/builds/33050215) Coverage remained the same at 99.636% when pulling **da53215163ac0e53f16e0d70756d00815602cb87 on XenoAmess:port_commons_lang_Fraction** into **674f6da2d495031d3ea054dddad2818500b9728c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475412) Time Spent: 5h 10m (was: 5h) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-numbers] coveralls edited a comment on pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
coveralls edited a comment on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-680561210 [](https://coveralls.io/builds/33050215) Coverage remained the same at 99.636% when pulling **da53215163ac0e53f16e0d70756d00815602cb87 on XenoAmess:port_commons_lang_Fraction** into **674f6da2d495031d3ea054dddad2818500b9728c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475389=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475389 ] ASF GitHub Bot logged work on NUMBERS-149: -- Author: ASF GitHub Bot Created on: 27/Aug/20 16:12 Start Date: 27/Aug/20 16:12 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-682046367 @aherbert sqruashed. please wait for travis-ci & recheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475389) Time Spent: 5h (was: 4h 50m) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 5h > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[
https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475388
]
ASF GitHub Bot logged work on NUMBERS-149:
--
Author: ASF GitHub Bot
Created on: 27/Aug/20 16:11
Start Date: 27/Aug/20 16:11
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478535081
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+
[GitHub] [commons-numbers] XenoAmess commented on pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
XenoAmess commented on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-682046367 @aherbert sqruashed. please wait for travis-ci & recheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-numbers] XenoAmess commented on a change in pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
XenoAmess commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478535081
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+assertEquals(15, f.getDenominator());
+
+// improper
+f = Fraction.of(22, 7);
+assertEquals(22, f.getNumerator());
+assertEquals(7, f.getDenominator());
+
+// negatives
+f = Fraction.of(-6, 10);
+assertEquals(-3, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f = Fraction.of(6, -10);
+assertEquals(3, f.getNumerator());
+
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[
https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475381
]
ASF GitHub Bot logged work on NUMBERS-149:
--
Author: ASF GitHub Bot
Created on: 27/Aug/20 16:03
Start Date: 27/Aug/20 16:03
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478530080
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+
[GitHub] [commons-numbers] aherbert commented on a change in pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478530080
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+assertEquals(15, f.getDenominator());
+
+// improper
+f = Fraction.of(22, 7);
+assertEquals(22, f.getNumerator());
+assertEquals(7, f.getDenominator());
+
+// negatives
+f = Fraction.of(-6, 10);
+assertEquals(-3, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f = Fraction.of(6, -10);
+assertEquals(3, f.getNumerator());
+
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475303 ] ASF GitHub Bot logged work on NUMBERS-149: -- Author: ASF GitHub Bot Created on: 27/Aug/20 13:36 Start Date: 27/Aug/20 13:36 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-680561210 [](https://coveralls.io/builds/33044971) Coverage increased (+0.002%) to 99.636% when pulling **80efbb7975580909da6e3977d110836db9c464aa on XenoAmess:port_commons_lang_Fraction** into **c3d173ae9cf25329644b87b8e064f56a2c31ea53 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475303) Time Spent: 4.5h (was: 4h 20m) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 4.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-numbers] coveralls edited a comment on pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
coveralls edited a comment on pull request #82: URL: https://github.com/apache/commons-numbers/pull/82#issuecomment-680561210 [](https://coveralls.io/builds/33044971) Coverage increased (+0.002%) to 99.636% when pulling **80efbb7975580909da6e3977d110836db9c464aa on XenoAmess:port_commons_lang_Fraction** into **c3d173ae9cf25329644b87b8e064f56a2c31ea53 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-numbers] XenoAmess commented on a change in pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
XenoAmess commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478417612
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+assertEquals(15, f.getDenominator());
+
+// improper
+f = Fraction.of(22, 7);
+assertEquals(22, f.getNumerator());
+assertEquals(7, f.getDenominator());
+
+// negatives
+f = Fraction.of(-6, 10);
+assertEquals(-3, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f = Fraction.of(6, -10);
+assertEquals(3, f.getNumerator());
+
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[
https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475300
]
ASF GitHub Bot logged work on NUMBERS-149:
--
Author: ASF GitHub Bot
Created on: 27/Aug/20 13:26
Start Date: 27/Aug/20 13:26
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478417612
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+
[jira] [Updated] (NET-687) FTP data connection error Unsupported or unrecognized SSL message. Probably another ssl_reuse session error ?
[
https://issues.apache.org/jira/browse/NET-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikael updated NET-687:
---
Description:
After adding the self signed polynesie.cer certificate to JVM security
(_jdk-x.x.x/lib/security_) :
{code:java}
keytool.exe -import -storepass "changeit" -keystore "./cacerts" -alias
polynesie.cer -file ./polynesie.cer -noprompt{code}
polynesie.cer obtained by copying certificate part from this command line
result :
{code:java}
openssl s_client -connect ftp0.gov.pf:21 -starttls ftp{code}
Trying to retrieve a file with ftpes :
{code:java}
java -cp commons-net-examples-3.5.jar;commons-net-3.5.jar
examples/ftp/FTPClientExample -A -p TLS,false -e -b ftp0.gov.pf
DataVRS/fiche_Station_VRS_VAI1.pdf fiche_Station_VRS_VAI1.pdf{code}
Produce this exception :
{code:java}
javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
at
java.base/sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketInputRecord.decode(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at
java.base/sun.security.ssl.SSLSocketImpl.performInitialHandshake(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at
org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:642)
at
org.apache.commons.net.ftp.FTPClient._retrieveFile(FTPClient.java:1907)
at
org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1893)
at testFTP2.FTPClientExample.main(FTPClientExample.java:513)
{code}
It is probably the same error of ssl_reuse session as NET-408.
Same try with ftp4j library reports this error :
{code:java}
code=522, message= SSL connection failed; session reuse required: see
require_ssl_reuse option in vsftpd.conf man page
{code}
was:
After adding the self signed polynesie.cer certificate to JVM security
(_jdk-x.x.x/lib/security_) :
{code:java}
keytool.exe -import -storepass "changeit" -keystore "./cacerts" -alias
polynesie.cer -file ./polynesie.cer -noprompt{code}
polynesie.cer obtained by copying certificate part from this command line
result :
{{}}
{code:java}
openssl s_client -connect ftp0.gov.pf:21 -starttls ftp{code}
Trying to retrieve a file with ftpes :
{code:java}
java -cp commons-net-examples-3.5.jar;commons-net-3.5.jar
examples/ftp/FTPClientExample -A -p TLS,false -e -b ftp0.gov.pf
DataVRS/fiche_Station_VRS_VAI1.pdf fiche_Station_VRS_VAI1.pdf{code}
Produce this exception :
{code:java}
javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
at
java.base/sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketInputRecord.decode(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at
java.base/sun.security.ssl.SSLSocketImpl.performInitialHandshake(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at
org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:642)
at
org.apache.commons.net.ftp.FTPClient._retrieveFile(FTPClient.java:1907)
at
org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1893)
at testFTP2.FTPClientExample.main(FTPClientExample.java:513)
{code}
It is probably the same error of ssl_reuse session as NET-408.
Same try with ftp4j library reports this error :
{code:java}
code=522, message= SSL connection failed; session reuse required: see
require_ssl_reuse option in vsftpd.conf man page
{code}
> FTP data connection error Unsupported or unrecognized SSL message. Probably
> another ssl_reuse session error ?
> -
>
> Key: NET-687
> URL: https://issues.apache.org/jira/browse/NET-687
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 3.7
> Environment: Tested with JDK 8, 11, 13, 14
>Reporter: Mikael
>Priority: Major
>
> After adding the self signed polynesie.cer certificate to JVM security
> (_jdk-x.x.x/lib/security_) :
> {code:java}
> keytool.exe -import -storepass "changeit" -keystore "./cacerts" -alias
> polynesie.cer -file ./polynesie.cer -noprompt{code}
> polynesie.cer obtained by copying certificate part from this command line
> result :
> {code:java}
> openssl s_client
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[
https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475278=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475278
]
ASF GitHub Bot logged work on NUMBERS-149:
--
Author: ASF GitHub Bot
Created on: 27/Aug/20 12:34
Start Date: 27/Aug/20 12:34
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478379873
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+
[GitHub] [commons-numbers] aherbert commented on a change in pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478379873
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+assertEquals(15, f.getDenominator());
+
+// improper
+f = Fraction.of(22, 7);
+assertEquals(22, f.getNumerator());
+assertEquals(7, f.getDenominator());
+
+// negatives
+f = Fraction.of(-6, 10);
+assertEquals(-3, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f = Fraction.of(6, -10);
+assertEquals(3, f.getNumerator());
+
[jira] [Work logged] (NUMBERS-149) port tests in commons-lang for Fraction.
[
https://issues.apache.org/jira/browse/NUMBERS-149?focusedWorklogId=475272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475272
]
ASF GitHub Bot logged work on NUMBERS-149:
--
Author: ASF GitHub Bot
Created on: 27/Aug/20 12:21
Start Date: 27/Aug/20 12:21
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478376559
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+
[GitHub] [commons-numbers] aherbert commented on a change in pull request #82: [NUMBERS-149] port tests in commons-lang for Fraction.
aherbert commented on a change in pull request #82:
URL: https://github.com/apache/commons-numbers/pull/82#discussion_r478376559
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/CommonsLangPortedFractionTest.java
##
@@ -0,0 +1,1148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.numbers.fraction;
+
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Test cases for the {@link Fraction} class.
+ *
+ * This class is ported from commons lang to demonstrate interoperability of
+ * the Fraction class in numbers.
+ */
+public class CommonsLangPortedFractionTest {
+
+private static final int SKIP = 500; //53
+
+
//--
+@Test
+public void testConstants() {
+assertEquals(0, Fraction.ZERO.getNumerator());
+assertEquals(1, Fraction.ZERO.getDenominator());
+
+assertEquals(1, Fraction.ONE.getNumerator());
+assertEquals(1, Fraction.ONE.getDenominator());
+
+/*
+ * All these constants need not be supported.
+ * Users can create whatever constants they require.
+ * The special constants ZERO and ONE are for the additive and
multiplicative identity.
+ *
+ * assertEquals(1, Fraction.ONE_HALF.getNumerator());
+ * assertEquals(2, Fraction.ONE_HALF.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_THIRD.getNumerator());
+ * assertEquals(3, Fraction.ONE_THIRD.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_THIRDS.getNumerator());
+ * assertEquals(3, Fraction.TWO_THIRDS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_QUARTER.getNumerator());
+ * assertEquals(4, Fraction.ONE_QUARTER.getDenominator());
+ *
+ * assertEquals(1, Fraction.TWO_QUARTERS.getNumerator());
+ * assertEquals(2, Fraction.TWO_QUARTERS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_QUARTERS.getNumerator());
+ * assertEquals(4, Fraction.THREE_QUARTERS.getDenominator());
+ *
+ * assertEquals(1, Fraction.ONE_FIFTH.getNumerator());
+ * assertEquals(5, Fraction.ONE_FIFTH.getDenominator());
+ *
+ * assertEquals(2, Fraction.TWO_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.TWO_FIFTHS.getDenominator());
+ *
+ * assertEquals(3, Fraction.THREE_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.THREE_FIFTHS.getDenominator());
+ *
+ * assertEquals(4, Fraction.FOUR_FIFTHS.getNumerator());
+ * assertEquals(5, Fraction.FOUR_FIFTHS.getDenominator());
+ */
+}
+
+@Test
+public void testFactory_int_int() {
+Fraction f = null;
+
+// zero
+f = Fraction.of(0, 1);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(0, 2);
+assertEquals(0, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+// normal
+f = Fraction.of(1, 1);
+assertEquals(1, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(2, 1);
+assertEquals(2, f.getNumerator());
+assertEquals(1, f.getDenominator());
+
+f = Fraction.of(23, 345);
+assertEquals(1, f.getNumerator());
+assertEquals(15, f.getDenominator());
+
+// improper
+f = Fraction.of(22, 7);
+assertEquals(22, f.getNumerator());
+assertEquals(7, f.getDenominator());
+
+// negatives
+f = Fraction.of(-6, 10);
+assertEquals(-3, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f = Fraction.of(6, -10);
+assertEquals(3, f.getNumerator());
+
[jira] [Work logged] (NUMBERS-151) Performance refinement for ArithmeticUtils.pow
[ https://issues.apache.org/jira/browse/NUMBERS-151?focusedWorklogId=475269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475269 ] ASF GitHub Bot logged work on NUMBERS-151: -- Author: ASF GitHub Bot Created on: 27/Aug/20 12:12 Start Date: 27/Aug/20 12:12 Worklog Time Spent: 10m Work Description: asfgit merged pull request #84: URL: https://github.com/apache/commons-numbers/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475269) Time Spent: 2.5h (was: 2h 20m) > Performance refinement for ArithmeticUtils.pow > -- > > Key: NUMBERS-151 > URL: https://issues.apache.org/jira/browse/NUMBERS-151 > Project: Commons Numbers > Issue Type: Improvement > Components: core >Affects Versions: 1.0-beta1 >Reporter: Jin Xu >Priority: Minor > Time Spent: 2.5h > Remaining Estimate: 0h > > Hi. > right now ArithmeticUtils.pow(0,0) = 1, but not throw an Exception, which I > think not quite right... > Is it a bug? > Anyway, we found a way to faster the calculate, so at least we can get an > performance refine pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NUMBERS-151) Performance refinement for ArithmeticUtils.pow
[ https://issues.apache.org/jira/browse/NUMBERS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved NUMBERS-151. -- Fix Version/s: 1.0 Resolution: Fixed Added in commit 42ebc644ff46e0cef75a59512390c9b78fa16a04 > Performance refinement for ArithmeticUtils.pow > -- > > Key: NUMBERS-151 > URL: https://issues.apache.org/jira/browse/NUMBERS-151 > Project: Commons Numbers > Issue Type: Improvement > Components: core >Affects Versions: 1.0-beta1 >Reporter: Jin Xu >Priority: Minor > Fix For: 1.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > Hi. > right now ArithmeticUtils.pow(0,0) = 1, but not throw an Exception, which I > think not quite right... > Is it a bug? > Anyway, we found a way to faster the calculate, so at least we can get an > performance refine pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-numbers] asfgit merged pull request #84: [NUMBERS-151] performance refine for ArithmeticUtils.pow
asfgit merged pull request #84: URL: https://github.com/apache/commons-numbers/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NET-687) FTP data connection error Unsupported or unrecognized SSL message. Probably another ssl_reuse session error ?
Mikael created NET-687:
--
Summary: FTP data connection error Unsupported or unrecognized SSL
message. Probably another ssl_reuse session error ?
Key: NET-687
URL: https://issues.apache.org/jira/browse/NET-687
Project: Commons Net
Issue Type: Bug
Components: FTP
Affects Versions: 3.7
Environment: Tested with JDK 8, 11, 13, 14
Reporter: Mikael
After adding the self signed polynesie.cer certificate to JVM security
(_jdk-x.x.x/lib/security_) :
{code:java}
keytool.exe -import -storepass "changeit" -keystore "./cacerts" -alias
polynesie.cer -file ./polynesie.cer -noprompt{code}
polynesie.cer obtained by copying certificate part from this command line
result :
{{}}
{code:java}
openssl s_client -connect ftp0.gov.pf:21 -starttls ftp{code}
Trying to retrieve a file with ftpes :
{code:java}
java -cp commons-net-examples-3.5.jar;commons-net-3.5.jar
examples/ftp/FTPClientExample -A -p TLS,false -e -b ftp0.gov.pf
DataVRS/fiche_Station_VRS_VAI1.pdf fiche_Station_VRS_VAI1.pdf{code}
Produce this exception :
{code:java}
javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
at
java.base/sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketInputRecord.decode(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
at
java.base/sun.security.ssl.SSLSocketImpl.performInitialHandshake(Unknown Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
Source)
at
org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:642)
at
org.apache.commons.net.ftp.FTPClient._retrieveFile(FTPClient.java:1907)
at
org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1893)
at testFTP2.FTPClientExample.main(FTPClientExample.java:513)
{code}
It is probably the same error of ssl_reuse session as NET-408.
Same try with ftp4j library reports this error :
{code:java}
code=522, message= SSL connection failed; session reuse required: see
require_ssl_reuse option in vsftpd.conf man page
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?focusedWorklogId=475150=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475150 ] ASF GitHub Bot logged work on COLLECTIONS-766: -- Author: ASF GitHub Bot Created on: 27/Aug/20 06:11 Start Date: 27/Aug/20 06:11 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-680709554 the third and later commit solved a problem that `--no-transfer-progress` is not usable on openjdk8 at ppc64le . so I added a condition select in travis.yml. will see if it can work correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475150) Time Spent: 20m (was: 10m) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?focusedWorklogId=475151=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475151 ] ASF GitHub Bot logged work on COLLECTIONS-766: -- Author: ASF GitHub Bot Created on: 27/Aug/20 06:11 Start Date: 27/Aug/20 06:11 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-681398369 @kinow Hi. After search in docs / try by self, I can find NO way to get ARCH variable from travis-ci. So we MIGHT either use if condition to JDK_NAME (see c302eea above), or delete `--no-transfer-progress`. (see 379e4b5 above). Both can pass ci, and acceptable. Personally I slightly prefer deleting `--no-transfer-progress`, because seems it is added not to solve an build error, but to slightly reduce travis-ci's pressure. Aynway, please choose one for the final choice, and then I will rebase / sqruash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475151) Time Spent: 0.5h (was: 20m) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] XenoAmess edited a comment on pull request #178: [COLLECTIONS-766] fix ci build (or to say, fix everything that wrongly blocked the ci build.)
XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-681398369 @kinow Hi. After search in docs / try by self, I can find NO way to get ARCH variable from travis-ci. So we MIGHT either use if condition to JDK_NAME (see c302eea above), or delete `--no-transfer-progress`. (see 379e4b5 above). Both can pass ci, and acceptable. Personally I slightly prefer deleting `--no-transfer-progress`, because seems it is added not to solve an build error, but to slightly reduce travis-ci's pressure. Aynway, please choose one for the final choice, and then I will rebase / sqruash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] XenoAmess edited a comment on pull request #178: [COLLECTIONS-766] fix ci build (or to say, fix everything that wrongly blocked the ci build.)
XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-680709554 the third and later commit solved a problem that `--no-transfer-progress` is not usable on openjdk8. so I added a condition select in travis.yml. will see if it can work correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] XenoAmess edited a comment on pull request #178: [COLLECTIONS-766] fix ci build (or to say, fix everything that wrongly blocked the ci build.)
XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-680709554 the third and later commit solved a problem that `--no-transfer-progress` is not usable on openjdk8 at ppc64le . so I added a condition select in travis.yml. will see if it can work correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?focusedWorklogId=475149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475149 ] ASF GitHub Bot logged work on COLLECTIONS-766: -- Author: ASF GitHub Bot Created on: 27/Aug/20 06:10 Start Date: 27/Aug/20 06:10 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-680709554 the third and later commit solved a problem that `--no-transfer-progress` is not usable on openjdk8. so I added a condition select in travis.yml. will see if it can work correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475149) Remaining Estimate: 0h Time Spent: 10m > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COLLECTIONS-766: --- Priority: Major (was: Critical) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COLLECTIONS-766: --- Priority: Critical (was: Major) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Critical > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
Jin Xu created COLLECTIONS-766: -- Summary: fix ci build (or to say, fix everything that wrongly blocked the ci build.) Key: COLLECTIONS-766 URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 Project: Commons Collections Issue Type: Bug Reporter: Jin Xu Hi. The current ci build fails for 3 reasons. I fixed them all in https://github.com/apache/commons-collections/pull/178 please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] XenoAmess edited a comment on pull request #178: fix ci builds
XenoAmess edited a comment on pull request #178: URL: https://github.com/apache/commons-collections/pull/178#issuecomment-681398369 @kinow Hi. After search in docs / try by self, I can find NO way to get ARCH variable from travis-ci. So we MIGHT either use if condition to JDK_NAME (see c302eea above), or delete `--no-transfer-progress`. (see 379e4b5 above). Both can pass ci, and acceptable. Personally I slightly prefer deleting `--no-transfer-progress`, because seems it is added not to solve an build error, but to slightly reduce travis-ci's pressure. So please choose one for the final choice, and then I will rebase / sqruash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #613: Bump jmh.version from 1.21 to 1.25.1
coveralls commented on pull request #613: URL: https://github.com/apache/commons-lang/pull/613#issuecomment-681587755 [](https://coveralls.io/builds/33035255) Coverage remained the same at 94.704% when pulling **fef0707a5335a5b739d89fa3a74c3edd5ce598fc on dependabot/maven/jmh.version-1.25.1** into **31dc5c700e1a08f4af33d94301ff06790533099b on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
