[GitHub] [commons-net] arturobernalg opened a new pull request #77: Simplify Statement
arturobernalg opened a new pull request #77: URL: https://github.com/apache/commons-net/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-726) Add MemoryMappedInputStream
[
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=570668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570668
]
ASF GitHub Bot logged work on IO-726:
-
Author: ASF GitHub Bot
Created on: 23/Mar/21 17:34
Start Date: 23/Mar/21 17:34
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-805093521
[](https://coveralls.io/builds/38182956)
Coverage increased (+0.05%) to 89.309% when pulling
**005eb02ba0f0aa2dccb84266b1f7344880a056c5 on shollander:mmap_inputStream**
into **c1ee77787f74ce9b660bf377462059d084458fef on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 570668)
Time Spent: 20m (was: 10m)
> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of
> memory mapped files. I propose an {{InputStream}} that provides a bridge
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream
> provided a 25% increase in throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] coveralls commented on pull request #215: IO-726 Add MemoryMappedInputStream.
coveralls commented on pull request #215: URL: https://github.com/apache/commons-io/pull/215#issuecomment-805093521 [](https://coveralls.io/builds/38182956) Coverage increased (+0.05%) to 89.309% when pulling **005eb02ba0f0aa2dccb84266b1f7344880a056c5 on shollander:mmap_inputStream** into **c1ee77787f74ce9b660bf377462059d084458fef on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #169: Bump spotbugs-maven-plugin from 4.2.0 to 4.2.2
garydgregory merged pull request #169: URL: https://github.com/apache/commons-vfs/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory removed a comment on pull request #168: [VFS-798] IllegalArgumentException: Bad escape for Chinese characters in FileObject path
garydgregory removed a comment on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804974735 https://issues.apache.org/jira/browse/VFS-798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (VFS-798) IllegalArgumentException: Bad escape for Chinese characters in FileObject path
[ https://issues.apache.org/jira/browse/VFS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated VFS-798: Summary: IllegalArgumentException: Bad escape for Chinese characters in FileObject path (was: [bug] find a bug about chinese characters in FileObject path then call toFile) > IllegalArgumentException: Bad escape for Chinese characters in FileObject path > -- > > Key: VFS-798 > URL: https://issues.apache.org/jira/browse/VFS-798 > Project: Commons VFS > Issue Type: Improvement > Environment: linux >Reporter: Jin Xu >Priority: Major > > https://github.com/apache/commons-vfs/pull/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory commented on pull request #168: [VFS-798] IllegalArgumentException: Bad escape for Chinese characters in FileObject path
garydgregory commented on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804974735 https://issues.apache.org/jira/browse/VFS-798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #168: [VFS-798][bug] find a bug about Chinese characters in FileObject path then call toFile
garydgregory commented on pull request #168:
URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804973081
You will find that this JDK code fails on macOs (adapt your path, the file
exists):
```
FileSystems.getDefault().provider().getPath(new
URI("file:///Users/garydgregory/git/commons-vfs/commons-vfs2/src/test/resources/test-data/好.txt"));
```
with:
```
java.lang.IllegalArgumentException: Bad escape
at sun.nio.fs.UnixUriUtils.fromUri(UnixUriUtils.java:87)
at
sun.nio.fs.UnixFileSystemProvider.getPath(UnixFileSystemProvider.java:98)
at java.nio.file.Paths.get(Paths.java:138)
at org.apache.commons.vfs2.FileObject.getPath(FileObject.java:320)
at
org.apache.commons.vfs2.FileObjectTest.lambda$0(FileObjectTest.java:57)
at
org.apache.commons.vfs2.FileObjectTest.testToFile(FileObjectTest.java:74)
at
org.apache.commons.vfs2.FileObjectTest.testToFile(FileObjectTest.java:57)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:541)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:768)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess commented on pull request #168: [VFS-798][bug] find a bug about chinese characters in FileObject path then call toFile
XenoAmess commented on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804968195 > > @garydgregory > > I finally found out where wrong. > > Seems URI protocol in vfs2 is not 100% equal in URL protocol in JDK. > > So.. > > I can only modify it on getPath() to make sure the Path got is correct. > > Anyway, I think I fixed the bug already, and please review. > > Thanks. > > I'll take a look... @garydgregory OK. let's do it... My game engine is still waiting for using this lol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #168: [VFS-798][bug] find a bug about chinese characters in FileObject path then call toFile
garydgregory commented on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804947953 > > > @garydgregory > I finally found out where wrong. > Seems URI protocol in vfs2 is not 100% equal in URL protocol in JDK. > So.. > I can only modify it on getPath() to make sure the Path got is correct. > Anyway, I think I fixed the bug already, and please review. > Thanks. I'll take a look... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GEOMETRY-116) OSGi Headers Incorrect
[
https://issues.apache.org/jira/browse/GEOMETRY-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307080#comment-17307080
]
Matt Juntunen commented on GEOMETRY-116:
Fixed in commit 8c82ce96797ef7402c6c41ba5bead3d4fa4beb5f.
> OSGi Headers Incorrect
> --
>
> Key: GEOMETRY-116
> URL: https://issues.apache.org/jira/browse/GEOMETRY-116
> Project: Apache Commons Geometry
> Issue Type: Bug
>Reporter: Matt Juntunen
>Priority: Major
>
> The OSGi headers are not correct and prevent export of several required
> packages. For example, the commons-geometry-core module only exports the
> {{o.a.c.geometry.core}} package and not any of the {{partitioning}},
> {{partitioning.bsp}}, or {{precision}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEOMETRY-116) OSGi Headers Incorrect
[
https://issues.apache.org/jira/browse/GEOMETRY-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Juntunen resolved GEOMETRY-116.
Resolution: Fixed
> OSGi Headers Incorrect
> --
>
> Key: GEOMETRY-116
> URL: https://issues.apache.org/jira/browse/GEOMETRY-116
> Project: Apache Commons Geometry
> Issue Type: Bug
>Reporter: Matt Juntunen
>Priority: Major
>
> The OSGi headers are not correct and prevent export of several required
> packages. For example, the commons-geometry-core module only exports the
> {{o.a.c.geometry.core}} package and not any of the {{partitioning}},
> {{partitioning.bsp}}, or {{precision}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEOMETRY-116) OSGi Headers Incorrect
[
https://issues.apache.org/jira/browse/GEOMETRY-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Juntunen closed GEOMETRY-116.
--
> OSGi Headers Incorrect
> --
>
> Key: GEOMETRY-116
> URL: https://issues.apache.org/jira/browse/GEOMETRY-116
> Project: Apache Commons Geometry
> Issue Type: Bug
>Reporter: Matt Juntunen
>Priority: Major
>
> The OSGi headers are not correct and prevent export of several required
> packages. For example, the commons-geometry-core module only exports the
> {{o.a.c.geometry.core}} package and not any of the {{partitioning}},
> {{partitioning.bsp}}, or {{precision}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-geometry] asfgit merged pull request #138: GEOMETRY-116: updating OSGi headers to export subpackages
asfgit merged pull request #138: URL: https://github.com/apache/commons-geometry/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (VFS-798) [bug] find a bug about chinese characters in FileObject path then call toFile
Jin Xu created VFS-798: -- Summary: [bug] find a bug about chinese characters in FileObject path then call toFile Key: VFS-798 URL: https://issues.apache.org/jira/browse/VFS-798 Project: Commons VFS Issue Type: Improvement Environment: linux Reporter: Jin Xu https://github.com/apache/commons-vfs/pull/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-net] arturobernalg opened a new pull request #76: Use lambda and method reference
arturobernalg opened a new pull request #76: URL: https://github.com/apache/commons-net/pull/76 - Use lambda and method reference - Use primitive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess commented on pull request #168: [bug] find a bug about chinese characters in FileObject path then call toFile
XenoAmess commented on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-804654519 @garydgregory I finally found out where wrong. Seems URI protocol in vfs2 is not 100% equal in URL protocol in JDK. So.. I can only modify it on getPath() to make sure the Path got is correct. Anyway, I think I fixed the bug already, and please review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
