[GitHub] [commons-vfs] dependabot[bot] opened a new pull request #178: Bump mockito-core from 3.8.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #178:
URL: https://github.com/apache/commons-vfs/pull/178


   Bumps [mockito-core](https://github.com/mockito/mockito) from 3.8.0 to 3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-compress] dependabot[bot] opened a new pull request #185: Bump mockito-core from 3.8.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #185:
URL: https://github.com/apache/commons-compress/pull/185


   Bumps [mockito-core](https://github.com/mockito/mockito) from 3.8.0 to 3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-csv] dependabot[bot] commented on pull request #134: Bump mockito-core from 3.7.7 to 3.8.0

2021-04-07 Thread GitBox


dependabot[bot] commented on pull request #134:
URL: https://github.com/apache/commons-csv/pull/134#issuecomment-815460286


   Superseded by #141.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-dbutils] dependabot[bot] closed pull request #59: Bump mockito-core from 3.7.0 to 3.8.0

2021-04-07 Thread GitBox


dependabot[bot] closed pull request #59:
URL: https://github.com/apache/commons-dbutils/pull/59


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-dbutils] dependabot[bot] opened a new pull request #65: Bump mockito-core from 3.7.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #65:
URL: https://github.com/apache/commons-dbutils/pull/65


   Bumps [mockito-core](https://github.com/mockito/mockito) from 3.7.0 to 3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-csv] dependabot[bot] closed pull request #134: Bump mockito-core from 3.7.7 to 3.8.0

2021-04-07 Thread GitBox


dependabot[bot] closed pull request #134:
URL: https://github.com/apache/commons-csv/pull/134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-csv] dependabot[bot] opened a new pull request #141: Bump mockito-core from 3.7.7 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #141:
URL: https://github.com/apache/commons-csv/pull/141


   Bumps [mockito-core](https://github.com/mockito/mockito) from 3.7.7 to 3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #59: Bump mockito-core from 3.7.0 to 3.8.0

2021-04-07 Thread GitBox


dependabot[bot] commented on pull request #59:
URL: https://github.com/apache/commons-dbutils/pull/59#issuecomment-815460260


   Superseded by #65.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-io] dependabot[bot] opened a new pull request #220: Bump mockito-inline from 3.8.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #220:
URL: https://github.com/apache/commons-io/pull/220


   Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.8.0 to 
3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #95: Bump mockito-core from 3.8.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #95:
URL: https://github.com/apache/commons-dbcp/pull/95


   Bumps [mockito-core](https://github.com/mockito/mockito) from 3.8.0 to 3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[GitHub] [commons-text] dependabot[bot] opened a new pull request #213: Bump mockito-inline from 3.8.0 to 3.9.0

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #213:
URL: https://github.com/apache/commons-text/pull/213


   Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.8.0 to 
3.9.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-inline's 
releases.
   
   v3.9.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.9.0
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.9.0;>4 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.25
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.25
   
   2021-04-07 - https://github.com/mockito/mockito/compare/v3.8.22...v3.8.25;>3 
commit(s) by Tim van der Lippe, dependabot[bot]
   But invoked here lists the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2259;>#2259)](https://github-redirect.dependabot.com/mockito/mockito/pull/2259;>mockito/mockito#2259)
   Bump auto-service from 1.0-rc7 to 1.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2258;>#2258)](https://github-redirect.dependabot.com/mockito/mockito/pull/2258;>mockito/mockito#2258)
   Bump actions/setup-java from v1 to v2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2255;>#2255)](https://github-redirect.dependabot.com/mockito/mockito/pull/2255;>mockito/mockito#2255)
   But invoked here should list the invocation parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>#2058)](https://github-redirect.dependabot.com/mockito/mockito/issues/2058;>mockito/mockito#2058)
   
   v3.8.22
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.22
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.22;>2 
commit(s) by Tim van der Lippe
   Fix thread race condition [(https://github-redirect.dependabot.com/mockito/mockito/issues/2248;>#2248)](https://github-redirect.dependabot.com/mockito/mockito/pull/2248;>mockito/mockito#2248)
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.21
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.21
   
   2021-04-05 - https://github.com/mockito/mockito/compare/v3.8.20...v3.8.21;>1 
commit(s) by Tim van der Lippe
   Add missing Deprecated annotation [(https://github-redirect.dependabot.com/mockito/mockito/issues/2227;>#2227)](https://github-redirect.dependabot.com/mockito/mockito/pull/2227;>mockito/mockito#2227)
   
   v3.8.20
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   3.8.20
   
   2021-04-01 - https://github.com/mockito/mockito/compare/v3.8.17...v3.8.20;>3 
commit(s) by Paul Klauser, dependabot[bot]
   Bump google-java-format from 1.9 to 1.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2251;>#2251)](https://github-redirect.dependabot.com/mockito/mockito/pull/2251;>mockito/mockito#2251)
   Bump versions.errorprone from 2.5.1 to 2.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2250;>#2250)](https://github-redirect.dependabot.com/mockito/mockito/pull/2250;>mockito/mockito#2250)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Update objenesis dep to 3.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2249;>#2249)](https://github-redirect.dependabot.com/mockito/mockito/pull/2249;>mockito/mockito#2249)
   Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2007;>#2007
 : Downgrade objenesis version for mockito-android [(https://github-redirect.dependabot.com/mockito/mockito/issues/2024;>#2024)](https://github-redirect.dependabot.com/mockito/mockito/pull/2024;>mockito/mockito#2024)
   Android instrumentation test packaging fails for mockito-android 3.5.0 
with minSdk  26 

[jira] [Commented] (GEOMETRY-119) Vector normalizeOrDefault() method

2021-04-07 Thread Matt Juntunen (Jira)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316809#comment-17316809
 ] 

Matt Juntunen commented on GEOMETRY-119:


We also still have GEOMETRY-13 for moving the norm methods in general into 
commons-numbers. This would probably fall under that.

[~aherbert], I've updated the PR based on your feedback. I'll plan on merging 
it sometime tomorrow unless there are any objections.



> Vector normalizeOrDefault() method
> --
>
> Key: GEOMETRY-119
> URL: https://issues.apache.org/jira/browse/GEOMETRY-119
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> A frequent use case when working with vectors, especially vectors coming from 
> external data, is attempting to normalize the vector, and if this is not 
> possible, to use an alternative value. For example, the 
> {{QuaternionRotation}} code 
> [here|https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java#L86]
>  does exactly this; it attempts to normalize a vector and failing that (ie, 
> if the vector is exactly zero), it returns a substitute value. The 
> {{QuaternionRotation}} class is able to take advantage of our internal 
> {{Vectors.tryNormalize()}} but callers outside of the library are not able to 
> do so and so are left with 2 choices:
> 1. wrap the {{normalize()}} call in a try-catch and handle the exception 
> thrown on illegal norm values, or
> 2. compute and test the norm prior to calling {{normalize()}} to ensure that 
> the call won't fail, resulting in 2 computations of the norm.
> Neither of these options are very good.
> I propose adding a new method to the Euclidean Vector classes to handle this 
> situation: {{normalizeOrDefault()}}. The method would accept a default value 
> (possibly null) to return if the vector cannot be normalized. The normal 
> would then only need to be computed once and an exception would not need to 
> be thrown in case of failure. The behavior of the current {{normalize}} 
> method would be the same.
> Examples:
> {code:java}
> // get some kind of normal, preferably vec but +z will also do
> Vector3D.Unit norm = vec.normalizeOrDefault(Vector3D.Unit.PLUS_Z);
> {code}
> {code:java}
> // throw a very use-case specific error message
> Vector3D norm = vec.normalizeOrDefault(null);
> if (norm == null) {
> throw new Exception("Invalid triangle at index " + i + ": cannot compute 
> normal.");
> } 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-geometry] darkma773r commented on pull request #143: GEOMETRY-119: adding Vector.normalizeOrNull() method

2021-04-07 Thread GitBox


darkma773r commented on pull request #143:
URL: https://github.com/apache/commons-geometry/pull/143#issuecomment-815374918


   Updated. Thanks, @aherbert!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-vfs] dependabot[bot] commented on pull request #176: Bump actions/setup-java from v1.4.3 to v2

2021-04-07 Thread GitBox


dependabot[bot] commented on pull request #176:
URL: https://github.com/apache/commons-vfs/pull/176#issuecomment-815255660


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-vfs] garydgregory merged pull request #177: Update `actions/setup-java` to v2

2021-04-07 Thread GitBox


garydgregory merged pull request #177:
URL: https://github.com/apache/commons-vfs/pull/177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-vfs] garydgregory closed pull request #176: Bump actions/setup-java from v1.4.3 to v2

2021-04-07 Thread GitBox


garydgregory closed pull request #176:
URL: https://github.com/apache/commons-vfs/pull/176


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Work logged] (LANG-1655) Fixed an issue where characters were separated in the NFD system

2021-04-07 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?focusedWorklogId=578516=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578516
 ]

ASF GitHub Bot logged work on LANG-1655:


Author: ASF GitHub Bot
Created on: 07/Apr/21 17:58
Start Date: 07/Apr/21 17:58
Worklog Time Spent: 10m 
  Work Description: coveralls edited a comment on pull request #741:
URL: https://github.com/apache/commons-lang/pull/741#issuecomment-815080365


   
   [![Coverage 
Status](https://coveralls.io/builds/38609112/badge)](https://coveralls.io/builds/38609112)
   
   Coverage increased (+0.0003%) to 94.939% when pulling 
**d67dfc9c1d0d5883a621d747ee797424409e2b64 on dhmin5693:feature/LANG-1655** 
into **d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 578516)
Time Spent: 0.5h  (was: 20m)

> Fixed an issue where characters were separated in the NFD system
> 
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-lang] coveralls edited a comment on pull request #741: [LANG-1655] fixed an issue where characters were separated in the NFD…

2021-04-07 Thread GitBox


coveralls edited a comment on pull request #741:
URL: https://github.com/apache/commons-lang/pull/741#issuecomment-815080365


   
   [![Coverage 
Status](https://coveralls.io/builds/38609112/badge)](https://coveralls.io/builds/38609112)
   
   Coverage increased (+0.0003%) to 94.939% when pulling 
**d67dfc9c1d0d5883a621d747ee797424409e2b64 on dhmin5693:feature/LANG-1655** 
into **d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Work logged] (LANG-1655) Fixed an issue where characters were separated in the NFD system

2021-04-07 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?focusedWorklogId=578487=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578487
 ]

ASF GitHub Bot logged work on LANG-1655:


Author: ASF GitHub Bot
Created on: 07/Apr/21 17:11
Start Date: 07/Apr/21 17:11
Worklog Time Spent: 10m 
  Work Description: coveralls commented on pull request #741:
URL: https://github.com/apache/commons-lang/pull/741#issuecomment-815080365


   
   [![Coverage 
Status](https://coveralls.io/builds/38607621/badge)](https://coveralls.io/builds/38607621)
   
   Coverage increased (+0.0003%) to 94.939% when pulling 
**74c0f0585b0f89e62cf6e7dfe04d8bb90bcac364 on dhmin5693:feature/LANG-1655** 
into **d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 578487)
Time Spent: 20m  (was: 10m)

> Fixed an issue where characters were separated in the NFD system
> 
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-lang] coveralls commented on pull request #741: [LANG-1655] fixed an issue where characters were separated in the NFD…

2021-04-07 Thread GitBox


coveralls commented on pull request #741:
URL: https://github.com/apache/commons-lang/pull/741#issuecomment-815080365


   
   [![Coverage 
Status](https://coveralls.io/builds/38607621/badge)](https://coveralls.io/builds/38607621)
   
   Coverage increased (+0.0003%) to 94.939% when pulling 
**74c0f0585b0f89e62cf6e7dfe04d8bb90bcac364 on dhmin5693:feature/LANG-1655** 
into **d1e9e598c9bcbf91afa174fa9b6c2ef30bbc8157 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (IMAGING-285) Decoding of Rational Numbers broken when large values present

2021-04-07 Thread John Andrade (Jira)
John Andrade created IMAGING-285:


 Summary: Decoding of Rational Numbers broken when large values 
present
 Key: IMAGING-285
 URL: https://issues.apache.org/jira/browse/IMAGING-285
 Project: Commons Imaging
  Issue Type: Bug
  Components: imaging.common.*
Affects Versions: 1.0-alpha2
Reporter: John Andrade
 Attachments: DJI_0267 cropped.JPG

Decoding Lat/Long EXIF data from JPEGs does not work for some values.  I have 
attached a file where the conversion fails.  I used the 
getLatitudeAsDegreesNorth and getLongitudeAsDegreesEast methods from the 
TiffImageMetaData.GPSInfo class.  The values are close, but seemingly off by a 
few miles.

I've traced the source and I believe the issue is with how the RationalNumber 
class uses two 32-bit signed integers for the numerator and denominator.  The 
definition of a RATIONAL data type uses 32-bit unsigned numbers.  It seems as 
if the RationalNumber class already expects this as it has a non-public static 
method called factoryMethod to create a RationalNumber from two 64-bit numbers.

This error is introduced in the ByteConversions class, specifically the 
toRational method where it uses the regular RationalNumber constructor and thus 
ensures any rational numbers that have numerator or denominator greater than 
the max signed 32-bit value will produce invalid values.

I am attaching a JPEG that has this problem.  I had to crop it to reduce the 
size, but the EXIF data was preserved.

The EXIF GPS data contained in the JPEG is:

GpsLatitudeRef: "N"

GpsLatitude: 38, 1, 36, 1, 4120083230, 7000

GpsLongitudeRef: "W"

GpsLongitude: 90, 1, 12, 1, 2379156648, 7000

According to the properties of the image (right-clicking on Windows 10), the 
L/L of the image is:

Latitude: 38: 36: 58.85833

Longitude: 90: 12: 33.98795... (Windows doesn't show E/W)

These values convert to:

38.616349536627

-90.2094410978095

When I use the getLatitudeAsDegreesNorth  and getLongitudeAsDegreesEast 
methods, I get the following values:

38.5993060156

-90.19239757679365

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (NET-408) problem connecting to ProFTPD with FTPES

2021-04-07 Thread David Kocher (Jira)


[ 
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263125#comment-17263125
 ] 

David Kocher edited comment on NET-408 at 4/7/21, 3:37 PM:
---

Additionally on JDK14 or later 
{{System.setProperty("jdk.tls.client.enableSessionTicketExtension", 
String.valueOf(false))}} is required.


was (Author: dkoc...@sudo.ch):
Additionally on JD14 or later 
{{System.setProperty("jdk.tls.client.enableSessionTicketExtension", 
String.valueOf(false))}} is required.

> problem connecting to ProFTPD with FTPES
> 
>
> Key: NET-408
> URL: https://issues.apache.org/jira/browse/NET-408
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.2, 3.0
> Environment: ProFTPD 1.3.3d on SUSE Linux Enterprise Server 10.1 
> 32bit, Kernel 2.6.16.46-0.12-default (config file attached)
> ProFTPD 1.3.3d on OpenSUSE 64bit Linux 2.6.34.8-0.2-desktop
> Java 1.5
>Reporter: Michael Voigt
>Priority: Major
> Attachments: BCFTPSClient.java, FTPSClientWithTLSResumption.zip, 
> PTFTPSClient.java, ftpes.jpg, proftpd.conf
>
>
> I have a problem with the FTPClient connecting to a ProFTPD server.
> If the server uses the configuration option "TLSProtocol TLSv1", I
> cannot connect to it at all. I recieve the following error message:
> - javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection
> On the server side I see in the log:
> unable to accept TLS connection: protocol error:
> -  (1) error:14094416:SSL routines:SSL3_READ_BYTES:sslv3 alert
> certificate unknown
> - TLS/TLS-C negotiation failed on control channel
> If the server uses the configuration option "TLSProtocol SSLv23", I
> can connect to it but I cant transfer any files. In the server log I
> see:
> - starting TLS negotiation on data connection
> - TLSv1/SSLv3 renegotiation accepted, using cipher RC4-MD5 (128 bits)
> - client did not reuse SSL session, rejecting data connection (see
> TLSOption NoSessionReuseRequired)
> - unable to open data connection: TLS negotiation failed
> If I add the NoSessionReuseRequired parameter to the ProFTPD config
> everything works fine.
> Here is my code:
>FTPClient ftpClient = new FTPClient();
>ftpClient = new FTPSClient("TLS");
>// this throws an exception with TLSProtocol TLSv1
>ftpClient.connect(host, port);
>int reply = ftpClient.getReplyCode();
>if (!FTPReply.isPositiveCompletion(reply)) {
>ftpClient.disconnect();
>log.error("The FTP Server did not return a positive 
> completion reply!");
>throw new 
> FtpTransferException(ECCUtils.ERROR_FTP_CONNECTION);
>}
>boolean loginSuccessful = ftpClient.login(userName, password);
>if (!loginSuccessful) {
>log.error("Login to the FTP Server failed! The 
> credentials are not valid.");
>throw new 
> FtpTransferException(ECCUtils.ERROR_FTP_LOGIN);
>}
>ftpClient.execPBSZ(0);
>ftpClient.execPROT("P");
>boolean success = ftpClient.storeFile(fileName, fis);
>if (!success) {
>// this is false if "NoSessionReuseRequired" is not set
>}
> Now my question is if it is generally possible to connect to a server
> with "TLSProtocol TLSv1" or "TLSProtocol SSLv23" without the
> "NoSessionReuseRequired" parameter? Could someone provide a piece of
> example code for this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (GEOMETRY-119) Vector normalizeOrDefault() method

2021-04-07 Thread Alex Herbert (Jira)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316430#comment-17316430
 ] 

Alex Herbert edited comment on GEOMETRY-119 at 4/7/21, 3:33 PM:


I think there is a case for:
{code:java}
public final class SafeNorm {
public static double value(double x, double y, double z);
}
{code}
Currently there is only the generic:
{code:java}
public static double value(double[] v);
{code}
The two argument version is provided by Math.hypot(double, double). Adding a 
specialisation for 3D coordinates is a common use case. At the moment SafeNorm 
can take an array of any length and appears to use constants for dwarf and 
giant number that are based around single precision:
{code:java}
/** Constant. Roughly 2^-66 */
private static final double R_DWARF = 3.834e-20;
/** Constant. Roughly 2^63 */
private static final double R_GIANT = 1.304e+19;
{code}
So R_DWARF^2 and R_GIANT^2 may fit in single precision (float), but I have not 
checked.

A simple (not checked) version based on the above normalisation code would be:
{code:java}
private static Unit value(final double x, final double y, final double z) {
final double max = Math.max(Math.max(Math.abs(x), Math.abs(y)), 
Math.abs(z));
double scale = 1.0;
if (max > 0x1.0p500) {
// Scale down
x *= 0x1.0p-600;
y *= 0x1.0p-600;
z *= 0x1.0p-600;
scale = 0x1.0p600;
} else if (max < 0x1.0p-500) {
// Scale up
x *= 0x1.0p600;
y *= 0x1.0p600;
z *= 0x1.0p600;
scale = 0x1.0p-600;
}
return Math.sqrt(x * x + y * y + z * z) * scale;
}
{code}
This does not handle edge cases with infinite or NaN. It could be updated to 
use a similar method to Math.hypot:
 * If any argument is infinite, then the result is positive infinity.
 * If any argument is NaN and no other argument is infinite, then the result is 
NaN.

I also think that hypot(x, y) must equal hypot(y, x). In the case of a 3 
argument version this would be achieved by a partial sort of XYZ. Summing from 
small to high would create the best accuracy to carry smaller bits up to the 
final total sum. It would also make permutations of XYZ return the same result.

 


was (Author: alexherbert):
I think there is a case for:
{code:java}
public final class SafeNorm {
public static double norm(double x, double y, double z);
}
{code}
Currently there is only the generic:
{code:java}
public static double value(double[] v);
{code}
The two argument version is is provided by Math.hypot(double, double). Adding a 
specialisation for 3D coordinates is a common use case. At the moment SafeNorm 
can take an array of any length and appears to use constants for dwarf and 
giant number that are based around single precision:
{code:java}
/** Constant. Roughly 2^-66 */
private static final double R_DWARF = 3.834e-20;
/** Constant. Roughly 2^63 */
private static final double R_GIANT = 1.304e+19;
{code}
So R_DWARF^2 and R_GIANT^2 may fit in single precision (float), but I have not 
checked.

A simple (not checked) version based on the above normalisation code would be:
{code:java}
private static Unit norm(final double x, final double y, final double z) {
final double max = Math.max(Math.max(Math.abs(x), Math.abs(y)), 
Math.abs(z));
double scale = 1.0;
if (max > 0x1.0p500) {
// Scale down
x *= 0x1.0p-600;
y *= 0x1.0p-600;
z *= 0x1.0p-600;
scale = 0x1.0p600;
} else if (max < 0x1.0p-500) {
// Scale up
x *= 0x1.0p600;
y *= 0x1.0p600;
z *= 0x1.0p600;
scale = 0x1.0p-600;
}
return Math.sqrt(x * x + y * y + z * z) * scale;
}
{code}
This does not handle edge cases with infinite or NaN. It could be updated to 
use a similar method to Math.hypot:
 * If any argument is infinite, then the result is positive infinity.
 * If any argument is NaN and no other argument is infinite, then the result is 
NaN.

I also think that hypot(x, y) must equal hypot(y, x). In the case of a 3 
argument version this would be achieved by a partial sort of XYZ. Summing from 
small to high would create the best accuracy to carry smaller bits up to the 
final total sum. It would also make permutations of XYZ return the same result.

 

> Vector normalizeOrDefault() method
> --
>
> Key: GEOMETRY-119
> URL: https://issues.apache.org/jira/browse/GEOMETRY-119
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> A frequent use case when working with vectors, especially vectors coming from 
> external data, is attempting to normalize the vector, and if this is not 
> possible, to use an alternative value. For example, the 
> {{QuaternionRotation}} code 
> 

[jira] [Commented] (GEOMETRY-119) Vector normalizeOrDefault() method

2021-04-07 Thread Alex Herbert (Jira)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316430#comment-17316430
 ] 

Alex Herbert commented on GEOMETRY-119:
---

I think there is a case for:
{code:java}
public final class SafeNorm {
public static double norm(double x, double y, double z);
}
{code}
Currently there is only the generic:
{code:java}
public static double value(double[] v);
{code}
The two argument version is is provided by Math.hypot(double, double). Adding a 
specialisation for 3D coordinates is a common use case. At the moment SafeNorm 
can take an array of any length and appears to use constants for dwarf and 
giant number that are based around single precision:
{code:java}
/** Constant. Roughly 2^-66 */
private static final double R_DWARF = 3.834e-20;
/** Constant. Roughly 2^63 */
private static final double R_GIANT = 1.304e+19;
{code}
So R_DWARF^2 and R_GIANT^2 may fit in single precision (float), but I have not 
checked.

A simple (not checked) version based on the above normalisation code would be:
{code:java}
private static Unit norm(final double x, final double y, final double z) {
final double max = Math.max(Math.max(Math.abs(x), Math.abs(y)), 
Math.abs(z));
double scale = 1.0;
if (max > 0x1.0p500) {
// Scale down
x *= 0x1.0p-600;
y *= 0x1.0p-600;
z *= 0x1.0p-600;
scale = 0x1.0p600;
} else if (max < 0x1.0p-500) {
// Scale up
x *= 0x1.0p600;
y *= 0x1.0p600;
z *= 0x1.0p600;
scale = 0x1.0p-600;
}
return Math.sqrt(x * x + y * y + z * z) * scale;
}
{code}
This does not handle edge cases with infinite or NaN. It could be updated to 
use a similar method to Math.hypot:
 * If any argument is infinite, then the result is positive infinity.
 * If any argument is NaN and no other argument is infinite, then the result is 
NaN.

I also think that hypot(x, y) must equal hypot(y, x). In the case of a 3 
argument version this would be achieved by a partial sort of XYZ. Summing from 
small to high would create the best accuracy to carry smaller bits up to the 
final total sum. It would also make permutations of XYZ return the same result.

 

> Vector normalizeOrDefault() method
> --
>
> Key: GEOMETRY-119
> URL: https://issues.apache.org/jira/browse/GEOMETRY-119
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> A frequent use case when working with vectors, especially vectors coming from 
> external data, is attempting to normalize the vector, and if this is not 
> possible, to use an alternative value. For example, the 
> {{QuaternionRotation}} code 
> [here|https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java#L86]
>  does exactly this; it attempts to normalize a vector and failing that (ie, 
> if the vector is exactly zero), it returns a substitute value. The 
> {{QuaternionRotation}} class is able to take advantage of our internal 
> {{Vectors.tryNormalize()}} but callers outside of the library are not able to 
> do so and so are left with 2 choices:
> 1. wrap the {{normalize()}} call in a try-catch and handle the exception 
> thrown on illegal norm values, or
> 2. compute and test the norm prior to calling {{normalize()}} to ensure that 
> the call won't fail, resulting in 2 computations of the norm.
> Neither of these options are very good.
> I propose adding a new method to the Euclidean Vector classes to handle this 
> situation: {{normalizeOrDefault()}}. The method would accept a default value 
> (possibly null) to return if the vector cannot be normalized. The normal 
> would then only need to be computed once and an exception would not need to 
> be thrown in case of failure. The behavior of the current {{normalize}} 
> method would be the same.
> Examples:
> {code:java}
> // get some kind of normal, preferably vec but +z will also do
> Vector3D.Unit norm = vec.normalizeOrDefault(Vector3D.Unit.PLUS_Z);
> {code}
> {code:java}
> // throw a very use-case specific error message
> Vector3D norm = vec.normalizeOrDefault(null);
> if (norm == null) {
> throw new Exception("Invalid triangle at index " + i + ": cannot compute 
> normal.");
> } 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES

2021-04-07 Thread Eduardo (Jira)


[ 
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316424#comment-17316424
 ] 

Eduardo commented on NET-408:
-

[~dkoc...@sudo.ch] the code above works in java 14, using 
System.setProperty("jdk.tls.client.enableSessionTicketExtension", 
String.valueOf(false))

but this does not work in java 16, I get the following:

org.apache.commons.net.ftp.FTPConnectionClosedException: Connection closed 
without indication.

Any idea what may be necessary here ?

> problem connecting to ProFTPD with FTPES
> 
>
> Key: NET-408
> URL: https://issues.apache.org/jira/browse/NET-408
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.2, 3.0
> Environment: ProFTPD 1.3.3d on SUSE Linux Enterprise Server 10.1 
> 32bit, Kernel 2.6.16.46-0.12-default (config file attached)
> ProFTPD 1.3.3d on OpenSUSE 64bit Linux 2.6.34.8-0.2-desktop
> Java 1.5
>Reporter: Michael Voigt
>Priority: Major
> Attachments: BCFTPSClient.java, FTPSClientWithTLSResumption.zip, 
> PTFTPSClient.java, ftpes.jpg, proftpd.conf
>
>
> I have a problem with the FTPClient connecting to a ProFTPD server.
> If the server uses the configuration option "TLSProtocol TLSv1", I
> cannot connect to it at all. I recieve the following error message:
> - javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection
> On the server side I see in the log:
> unable to accept TLS connection: protocol error:
> -  (1) error:14094416:SSL routines:SSL3_READ_BYTES:sslv3 alert
> certificate unknown
> - TLS/TLS-C negotiation failed on control channel
> If the server uses the configuration option "TLSProtocol SSLv23", I
> can connect to it but I cant transfer any files. In the server log I
> see:
> - starting TLS negotiation on data connection
> - TLSv1/SSLv3 renegotiation accepted, using cipher RC4-MD5 (128 bits)
> - client did not reuse SSL session, rejecting data connection (see
> TLSOption NoSessionReuseRequired)
> - unable to open data connection: TLS negotiation failed
> If I add the NoSessionReuseRequired parameter to the ProFTPD config
> everything works fine.
> Here is my code:
>FTPClient ftpClient = new FTPClient();
>ftpClient = new FTPSClient("TLS");
>// this throws an exception with TLSProtocol TLSv1
>ftpClient.connect(host, port);
>int reply = ftpClient.getReplyCode();
>if (!FTPReply.isPositiveCompletion(reply)) {
>ftpClient.disconnect();
>log.error("The FTP Server did not return a positive 
> completion reply!");
>throw new 
> FtpTransferException(ECCUtils.ERROR_FTP_CONNECTION);
>}
>boolean loginSuccessful = ftpClient.login(userName, password);
>if (!loginSuccessful) {
>log.error("Login to the FTP Server failed! The 
> credentials are not valid.");
>throw new 
> FtpTransferException(ECCUtils.ERROR_FTP_LOGIN);
>}
>ftpClient.execPBSZ(0);
>ftpClient.execPROT("P");
>boolean success = ftpClient.storeFile(fileName, fis);
>if (!success) {
>// this is false if "NoSessionReuseRequired" is not set
>}
> Now my question is if it is generally possible to connect to a server
> with "TLSProtocol TLSv1" or "TLSProtocol SSLv23" without the
> "NoSessionReuseRequired" parameter? Could someone provide a piece of
> example code for this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (NET-408) problem connecting to ProFTPD with FTPES

2021-04-07 Thread Eduardo (Jira)


[ 
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316422#comment-17316422
 ] 

Eduardo edited comment on NET-408 at 4/7/21, 3:23 PM:
--

 

For anyone interested: 

the code above was not working for me in java 14, (I think 11 too), because the 
"getHost" method is not available anymore, but the cyberduck code helped here 
(specifically getPeerHost()) : 

[https://github.com/iterate-ch/cyberduck/blob/master/ftp/src/main/java/ch/cyberduck/core/ftp/FTPClient.java]

 
{code:java}
// @Override
protected void _prepareDataSocket_(final Socket socket) {
if(preferences.getBoolean("ftp.tls.session.requirereuse")) {
if(socket instanceof SSLSocket) {
// Control socket is SSL
final SSLSession session = ((SSLSocket) _socket_).getSession();
if(session.isValid()) {
final SSLSessionContext context = 
session.getSessionContext();

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));
try {
final Field sessionHostPortCache = 
context.getClass().getDeclaredField("sessionHostPortCache");
sessionHostPortCache.setAccessible(true);
final Object cache = sessionHostPortCache.get(context);
final Method putMethod = 
cache.getClass().getDeclaredMethod("put", Object.class, Object.class);
putMethod.setAccessible(true);
Method getHostMethod;
try {
getHostMethod = 
socket.getClass().getMethod("getPeerHost");
}
catch(NoSuchMethodException e) {
// Running in IKVM
getHostMethod = 
socket.getClass().getDeclaredMethod("getHost");
}
getHostMethod.setAccessible(true);
Object peerHost = getHostMethod.invoke(socket);
putMethod.invoke(cache, String.format("%s:%s", 
peerHost, socket.getPort()).toLowerCase(Locale.ROOT), session);
}
catch(NoSuchFieldException e) {
// Not running in expected JRE
log.warn("No field sessionHostPortCache in 
SSLSessionContext", e);
}
catch(Exception e) {
// Not running in expected JRE
log.warn(e.getMessage());
}
}
else {
log.warn(String.format("SSL session %s for socket %s is not 
rejoinable", session, socket));
}
}
}
}
{code}
 

 

I had to uncomment this though: 

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));

Any idea what can be replaced here? Is this necessary anyhow? it seems to work 
out with 

// 
context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));


was (Author: eduardo-rs):
 

For anyone interested: 

the code above was not working for me in java 14 or 16, (I think 11 too), 
because the "getHost" method is not available anymore, but the cyberduck code 
helped here (specifically getPeerHost()) : 

[https://github.com/iterate-ch/cyberduck/blob/master/ftp/src/main/java/ch/cyberduck/core/ftp/FTPClient.java]

 
{code:java}
// @Override
protected void _prepareDataSocket_(final Socket socket) {
if(preferences.getBoolean("ftp.tls.session.requirereuse")) {
if(socket instanceof SSLSocket) {
// Control socket is SSL
final SSLSession session = ((SSLSocket) _socket_).getSession();
if(session.isValid()) {
final SSLSessionContext context = 
session.getSessionContext();

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));
try {
final Field sessionHostPortCache = 
context.getClass().getDeclaredField("sessionHostPortCache");
sessionHostPortCache.setAccessible(true);
final Object cache = sessionHostPortCache.get(context);
final Method putMethod = 
cache.getClass().getDeclaredMethod("put", Object.class, Object.class);
putMethod.setAccessible(true);
Method getHostMethod;
try {
getHostMethod = 
socket.getClass().getMethod("getPeerHost");
}
catch(NoSuchMethodException e) {
// Running in IKVM
getHostMethod = 
socket.getClass().getDeclaredMethod("getHost");
  

[jira] [Comment Edited] (NET-408) problem connecting to ProFTPD with FTPES

2021-04-07 Thread Eduardo (Jira)


[ 
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316422#comment-17316422
 ] 

Eduardo edited comment on NET-408 at 4/7/21, 3:22 PM:
--

 

For anyone interested: 

the code above was not working for me in java 14 or 16, (I think 11 too), 
because the "getHost" method is not available anymore, but the cyberduck code 
helped here (specifically getPeerHost()) : 

[https://github.com/iterate-ch/cyberduck/blob/master/ftp/src/main/java/ch/cyberduck/core/ftp/FTPClient.java]

 
{code:java}
// @Override
protected void _prepareDataSocket_(final Socket socket) {
if(preferences.getBoolean("ftp.tls.session.requirereuse")) {
if(socket instanceof SSLSocket) {
// Control socket is SSL
final SSLSession session = ((SSLSocket) _socket_).getSession();
if(session.isValid()) {
final SSLSessionContext context = 
session.getSessionContext();

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));
try {
final Field sessionHostPortCache = 
context.getClass().getDeclaredField("sessionHostPortCache");
sessionHostPortCache.setAccessible(true);
final Object cache = sessionHostPortCache.get(context);
final Method putMethod = 
cache.getClass().getDeclaredMethod("put", Object.class, Object.class);
putMethod.setAccessible(true);
Method getHostMethod;
try {
getHostMethod = 
socket.getClass().getMethod("getPeerHost");
}
catch(NoSuchMethodException e) {
// Running in IKVM
getHostMethod = 
socket.getClass().getDeclaredMethod("getHost");
}
getHostMethod.setAccessible(true);
Object peerHost = getHostMethod.invoke(socket);
putMethod.invoke(cache, String.format("%s:%s", 
peerHost, socket.getPort()).toLowerCase(Locale.ROOT), session);
}
catch(NoSuchFieldException e) {
// Not running in expected JRE
log.warn("No field sessionHostPortCache in 
SSLSessionContext", e);
}
catch(Exception e) {
// Not running in expected JRE
log.warn(e.getMessage());
}
}
else {
log.warn(String.format("SSL session %s for socket %s is not 
rejoinable", session, socket));
}
}
}
}
{code}
 

 

I had to uncomment this though: 

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));

Any idea what can be replaced here? Is this necessary anyhow? it seems to work 
out with 

// 
context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));


was (Author: eduardo-rs):
 

For anyone interested: 

the code above was not working for me in java 14 or 16, (I think 11 too), 
because the "getHost" method is not available anymore, but the cyberduck code 
helped here: 

[https://github.com/iterate-ch/cyberduck/blob/master/ftp/src/main/java/ch/cyberduck/core/ftp/FTPClient.java]

 
{code:java}
// @Override
protected void _prepareDataSocket_(final Socket socket) {
if(preferences.getBoolean("ftp.tls.session.requirereuse")) {
if(socket instanceof SSLSocket) {
// Control socket is SSL
final SSLSession session = ((SSLSocket) _socket_).getSession();
if(session.isValid()) {
final SSLSessionContext context = 
session.getSessionContext();

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));
try {
final Field sessionHostPortCache = 
context.getClass().getDeclaredField("sessionHostPortCache");
sessionHostPortCache.setAccessible(true);
final Object cache = sessionHostPortCache.get(context);
final Method putMethod = 
cache.getClass().getDeclaredMethod("put", Object.class, Object.class);
putMethod.setAccessible(true);
Method getHostMethod;
try {
getHostMethod = 
socket.getClass().getMethod("getPeerHost");
}
catch(NoSuchMethodException e) {
// Running in IKVM
getHostMethod = 
socket.getClass().getDeclaredMethod("getHost");
}

[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES

2021-04-07 Thread Eduardo (Jira)


[ 
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316422#comment-17316422
 ] 

Eduardo commented on NET-408:
-

 

For anyone interested: 

the code above was not working for me in java 14 or 16, (I think 11 too), 
because the "getHost" method is not available anymore, but the cyberduck code 
helped here: 

[https://github.com/iterate-ch/cyberduck/blob/master/ftp/src/main/java/ch/cyberduck/core/ftp/FTPClient.java]

 
{code:java}
// @Override
protected void _prepareDataSocket_(final Socket socket) {
if(preferences.getBoolean("ftp.tls.session.requirereuse")) {
if(socket instanceof SSLSocket) {
// Control socket is SSL
final SSLSession session = ((SSLSocket) _socket_).getSession();
if(session.isValid()) {
final SSLSessionContext context = 
session.getSessionContext();

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));
try {
final Field sessionHostPortCache = 
context.getClass().getDeclaredField("sessionHostPortCache");
sessionHostPortCache.setAccessible(true);
final Object cache = sessionHostPortCache.get(context);
final Method putMethod = 
cache.getClass().getDeclaredMethod("put", Object.class, Object.class);
putMethod.setAccessible(true);
Method getHostMethod;
try {
getHostMethod = 
socket.getClass().getMethod("getPeerHost");
}
catch(NoSuchMethodException e) {
// Running in IKVM
getHostMethod = 
socket.getClass().getDeclaredMethod("getHost");
}
getHostMethod.setAccessible(true);
Object peerHost = getHostMethod.invoke(socket);
putMethod.invoke(cache, String.format("%s:%s", 
peerHost, socket.getPort()).toLowerCase(Locale.ROOT), session);
}
catch(NoSuchFieldException e) {
// Not running in expected JRE
log.warn("No field sessionHostPortCache in 
SSLSessionContext", e);
}
catch(Exception e) {
// Not running in expected JRE
log.warn(e.getMessage());
}
}
else {
log.warn(String.format("SSL session %s for socket %s is not 
rejoinable", session, socket));
}
}
}
}
{code}
 

 

I had to uncomment this though: 

context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));

Any idea what can be replaced here? Is this necessary anyhow? it seems to work 
out with 

// 
context.setSessionCacheSize(preferences.getInteger("ftp.ssl.session.cache.size"));

> problem connecting to ProFTPD with FTPES
> 
>
> Key: NET-408
> URL: https://issues.apache.org/jira/browse/NET-408
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.2, 3.0
> Environment: ProFTPD 1.3.3d on SUSE Linux Enterprise Server 10.1 
> 32bit, Kernel 2.6.16.46-0.12-default (config file attached)
> ProFTPD 1.3.3d on OpenSUSE 64bit Linux 2.6.34.8-0.2-desktop
> Java 1.5
>Reporter: Michael Voigt
>Priority: Major
> Attachments: BCFTPSClient.java, FTPSClientWithTLSResumption.zip, 
> PTFTPSClient.java, ftpes.jpg, proftpd.conf
>
>
> I have a problem with the FTPClient connecting to a ProFTPD server.
> If the server uses the configuration option "TLSProtocol TLSv1", I
> cannot connect to it at all. I recieve the following error message:
> - javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection
> On the server side I see in the log:
> unable to accept TLS connection: protocol error:
> -  (1) error:14094416:SSL routines:SSL3_READ_BYTES:sslv3 alert
> certificate unknown
> - TLS/TLS-C negotiation failed on control channel
> If the server uses the configuration option "TLSProtocol SSLv23", I
> can connect to it but I cant transfer any files. In the server log I
> see:
> - starting TLS negotiation on data connection
> - TLSv1/SSLv3 renegotiation accepted, using cipher RC4-MD5 (128 bits)
> - client did not reuse SSL session, rejecting data connection (see
> TLSOption NoSessionReuseRequired)
> - unable to open data connection: TLS negotiation failed
> If I add the NoSessionReuseRequired parameter to the ProFTPD config
> everything works fine.
> Here is my code:
>FTPClient ftpClient = new FTPClient();
>

[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators

2021-04-07 Thread Alex Herbert (Jira)


[ 
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316415#comment-17316415
 ] 

Alex Herbert commented on RNG-127:
--

Without having a full view of the java.util.random package it is not clear if 
RandomGenerators will have public constructors or have to be loaded via the 
service API, i.e. is creating by name the only mechanism to obtain a specific 
generator. If we support the service API then commons RNG will be available via 
that mechanism. It does not exclude the current mechanism. Adding wrappers to 
bridge the two APIs is a good addition. For example this will allow any 
RandomGenerator to be wrapped as a UniformRandomProvider so it can be used with 
all the functionality in the sampling module.

Whether the UniformRandomProvider eventually extends RandomGenerator or the 
sampling module is updated to be coded against the RandomGenerator interface is 
a decision to made when this JDK implementation is generally adopted. 
UniformRandomProvider is a subset of RandomGenerator and so may become 
deprecated at some point.

> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number 
> Generators 
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
>  Issue Type: Task
>  Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is 
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number 
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
>  * SplittableRandomGenerator extends RandomGenerator and also provides
>  methods named split and splits. Splittability allows the user to spawn a new 
> RandomGenerator from an existing RandomGenerator that will generally produce 
> statistically independent results.
>  * JumpableRandomGenerator extends RandomGenerator and also provides
>  methods named jump and jumps. Jumpability allows a user to jump ahead a 
> moderate number of draws.
>  * LeapableRandomGenerator extends RandomGenerator and also provides
>  methods named leap and leaps. Leapability allows a user to jump ahead a 
> large number of draws.
>  * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and 
> also provides additional variations of jump and jumps that allow an arbitrary 
> jump distance to be specified.
> The specification describes the development of abstract classes that would 
> allow different algorithms to be easily implemented by developers and used 
> with a Java application through a common interface. This would replicate the 
> functionality of the Common RNG API and core modules within the JDK.
> The JDK interfaces should be compared with the current client API in Commons 
> RNG with the aim to assess:
>  # Compatibility
>  # Potential to back-port functionality
> JEP 356 also mentions the implementation of the LXM family of RNGs and a 
> change to the algorithm used by SplittableRandom to address two weaknesses 
> identified in 2016. These could be included in the current codebase pending 
> license compatibility checks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (LANG-1655) Fixed an issue where characters were separated in the NFD system

2021-04-07 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?focusedWorklogId=578398=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578398
 ]

ASF GitHub Bot logged work on LANG-1655:


Author: ASF GitHub Bot
Created on: 07/Apr/21 14:59
Start Date: 07/Apr/21 14:59
Worklog Time Spent: 10m 
  Work Description: dhmin5693 opened a new pull request #741:
URL: https://github.com/apache/commons-lang/pull/741


   https://issues.apache.org/jira/browse/LANG-1655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 578398)
Remaining Estimate: 0h
Time Spent: 10m

> Fixed an issue where characters were separated in the NFD system
> 
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-lang] dhmin5693 opened a new pull request #741: [LANG-1655] fixed an issue where characters were separated in the NFD…

2021-04-07 Thread GitBox


dhmin5693 opened a new pull request #741:
URL: https://github.com/apache/commons-lang/pull/741


   https://issues.apache.org/jira/browse/LANG-1655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (LANG-1655) Fixed an issue where characters were separated in the NFD system

2021-04-07 Thread Donghwi Min (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donghwi Min updated LANG-1655:
--
Summary: Fixed an issue where characters were separated in the NFD system  
(was: Fix issue where characters were separated in the NFD system)

> Fixed an issue where characters were separated in the NFD system
> 
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (LANG-1655) Fix issue where characters were separated in the NFD system

2021-04-07 Thread Donghwi Min (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donghwi Min updated LANG-1655:
--
Summary: Fix issue where characters were separated in the NFD system  (was: 
Fix an error where characters were separated in the NFD system)

> Fix issue where characters were separated in the NFD system
> ---
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (LANG-1655) Fix an error where characters were separated in the NFD system

2021-04-07 Thread Donghwi Min (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donghwi Min updated LANG-1655:
--
Description: 
String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";

*String.stripAccents(origin)* is expected to return *origin*,

but it returns this.

"ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"

The above string is a separate consonant and vowel of korean.

This issue happens on NFD systems. (linux, windows)

 

  was:
String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";

String.stripAccents(origin) is expected to return origin,

but it returns the string below.

"ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"

This happens on systems that do not support NFC. (linux, windows)


> Fix an error where characters were separated in the NFD system
> --
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> *String.stripAccents(origin)* is expected to return *origin*,
> but it returns this.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> The above string is a separate consonant and vowel of korean.
> This issue happens on NFD systems. (linux, windows)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (LANG-1655) fix an error where characters were separated in the NFD system

2021-04-07 Thread Donghwi Min (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donghwi Min updated LANG-1655:
--
Summary: fix an error where characters were separated in the NFD system  
(was: support StripAccents composite language on NFD systems)

> fix an error where characters were separated in the NFD system
> --
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> String.stripAccents(origin) is expected to return origin,
> but it returns the string below.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> This happens on systems that do not support NFC. (linux, windows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (LANG-1655) Fix an error where characters were separated in the NFD system

2021-04-07 Thread Donghwi Min (Jira)


 [ 
https://issues.apache.org/jira/browse/LANG-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donghwi Min updated LANG-1655:
--
Summary: Fix an error where characters were separated in the NFD system  
(was: fix an error where characters were separated in the NFD system)

> Fix an error where characters were separated in the NFD system
> --
>
> Key: LANG-1655
> URL: https://issues.apache.org/jira/browse/LANG-1655
> Project: Commons Lang
>  Issue Type: Bug
>  Components: General
>Reporter: Donghwi Min
>Priority: Minor
>
> String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";
> String.stripAccents(origin) is expected to return origin,
> but it returns the string below.
> "ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"
> This happens on systems that do not support NFC. (linux, windows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (LANG-1655) support StripAccents composite language on NFD systems

2021-04-07 Thread Donghwi Min (Jira)
Donghwi Min created LANG-1655:
-

 Summary: support StripAccents composite language on NFD systems
 Key: LANG-1655
 URL: https://issues.apache.org/jira/browse/LANG-1655
 Project: Commons Lang
  Issue Type: Bug
  Components: General
Reporter: Donghwi Min


String origin = "잊지마 넌 흐린 어둠사이 왼손으로 그린 별 하나";

String.stripAccents(origin) is expected to return origin,

but it returns the string below.

"ㅇㅣㅈㅈㅣㅁㅏ ㄴㅓㄴ ㅎㅡㄹㅣㄴ ㅇㅓㄷㅜㅁ ㅅㅏㅇㅣ ㅇㅗㅣㄴㅅㅗㄴㅇㅡㄹㅗ ㄱㅡㄹㅣㄴ ㅂㅕㄹ ㅎㅏ ㄴㅏ"

This happens on systems that do not support NFC. (linux, windows)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators

2021-04-07 Thread Gilles Sadowski (Jira)


[ 
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316329#comment-17316329
 ] 

Gilles Sadowski commented on RNG-127:
-

bq. adding to UniformRandomProvider is noise.

So IIUC your idea is to only provide access to Commons RNG through the by-name 
loader (and not provide a wrapper as in my code excerpt).

bq. wait for a release

+1

> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number 
> Generators 
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
>  Issue Type: Task
>  Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is 
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number 
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
>  * SplittableRandomGenerator extends RandomGenerator and also provides
>  methods named split and splits. Splittability allows the user to spawn a new 
> RandomGenerator from an existing RandomGenerator that will generally produce 
> statistically independent results.
>  * JumpableRandomGenerator extends RandomGenerator and also provides
>  methods named jump and jumps. Jumpability allows a user to jump ahead a 
> moderate number of draws.
>  * LeapableRandomGenerator extends RandomGenerator and also provides
>  methods named leap and leaps. Leapability allows a user to jump ahead a 
> large number of draws.
>  * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and 
> also provides additional variations of jump and jumps that allow an arbitrary 
> jump distance to be specified.
> The specification describes the development of abstract classes that would 
> allow different algorithms to be easily implemented by developers and used 
> with a Java application through a common interface. This would replicate the 
> functionality of the Common RNG API and core modules within the JDK.
> The JDK interfaces should be compared with the current client API in Commons 
> RNG with the aim to assess:
>  # Compatibility
>  # Potential to back-port functionality
> JEP 356 also mentions the implementation of the LXM family of RNGs and a 
> change to the algorithm used by SplittableRandom to address two weaknesses 
> identified in 2016. These could be included in the current codebase pending 
> license compatibility checks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEOMETRY-119) Vector normalizeOrDefault() method

2021-04-07 Thread Gilles Sadowski (Jira)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316323#comment-17316323
 ] 

Gilles Sadowski commented on GEOMETRY-119:
--

{quote}Any more thoughts on this?
{quote}
Could the logic be implemented in general enough a way in Commons Numbers (in 
module {{commons-numbers-array}} perhaps) and reused wherever needed?

> Vector normalizeOrDefault() method
> --
>
> Key: GEOMETRY-119
> URL: https://issues.apache.org/jira/browse/GEOMETRY-119
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> A frequent use case when working with vectors, especially vectors coming from 
> external data, is attempting to normalize the vector, and if this is not 
> possible, to use an alternative value. For example, the 
> {{QuaternionRotation}} code 
> [here|https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java#L86]
>  does exactly this; it attempts to normalize a vector and failing that (ie, 
> if the vector is exactly zero), it returns a substitute value. The 
> {{QuaternionRotation}} class is able to take advantage of our internal 
> {{Vectors.tryNormalize()}} but callers outside of the library are not able to 
> do so and so are left with 2 choices:
> 1. wrap the {{normalize()}} call in a try-catch and handle the exception 
> thrown on illegal norm values, or
> 2. compute and test the norm prior to calling {{normalize()}} to ensure that 
> the call won't fail, resulting in 2 computations of the norm.
> Neither of these options are very good.
> I propose adding a new method to the Euclidean Vector classes to handle this 
> situation: {{normalizeOrDefault()}}. The method would accept a default value 
> (possibly null) to return if the vector cannot be normalized. The normal 
> would then only need to be computed once and an exception would not need to 
> be thrown in case of failure. The behavior of the current {{normalize}} 
> method would be the same.
> Examples:
> {code:java}
> // get some kind of normal, preferably vec but +z will also do
> Vector3D.Unit norm = vec.normalizeOrDefault(Vector3D.Unit.PLUS_Z);
> {code}
> {code:java}
> // throw a very use-case specific error message
> Vector3D norm = vec.normalizeOrDefault(null);
> if (norm == null) {
> throw new Exception("Invalid triangle at index " + i + ": cannot compute 
> normal.");
> } 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators

2021-04-07 Thread Alex Herbert (Jira)


[ 
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316317#comment-17316317
 ] 

Alex Herbert commented on RNG-127:
--

I think adding to UniformRandomProvider is noise. It could go into the 
RandomSource enum which already has isJumpable and isLongJumpable. Or the 
current API can be left clean and all the information is added to the service 
created in a dedicated JDK 17 module. That can be subject to API changes until 
the feature is in a mature JDK release. 
{quote}What would one write in order to load one of the Commons RNG's 
implementations?
{quote}
I presume it must match what is returned by the RandomGeneratorFactory name() 
method. Here is the full API for the RandomGeneratorFactory class:
{code:java}
// Returns a non-empty stream of available RandomGeneratorFactory(s).
static Stream> all()
// Create an instance of RandomGenerator based on algorithm chosen.
T create()
// Create an instance of RandomGenerator based on algorithm chosen providing a 
starting byte[] seed.
T create​(byte[] seed)
// Create an instance of RandomGenerator based on algorithm chosen providing a 
starting long seed.
T create​(long seed)
// Returns the equidistribution of the algorithm.
int equidistribution()
// Returns a RandomGeneratorFactory meeting the minimal requirement of having 
an algorithm
// whose state bits are greater than or equal 64.
static RandomGeneratorFactory getDefault()
// Return the group name of the algorithm used by the random number generator.
String group()
// Return true if random generator can jump an arbitrarily specified distant 
point in the state cycle.
boolean isArbitrarilyJumpable()
// Return true if the implementation of RandomGenerator (algorithm) has been 
marked for deprecation.
boolean isDeprecated()
// Return true if random generator uses a hardware device (HRNG) to produce 
entropic input.
boolean isHardware()
// Return true if random generator can jump a specified distant point in the 
state cycle.
boolean isJumpable()
// Return true if random generator is jumpable and can leap to a very distant 
point in the state cycle.
boolean isLeapable()
// Return true if random generator can be cloned into a separate object with 
the same properties
// but positioned further in the state cycle.
boolean isSplittable()
// Return true if random generator is computed using an arithmetic algorithm 
and is statistically deterministic.
boolean isStatistical()
// Return true if random generator is computed using external or entropic 
sources as inputs.
boolean isStochastic()
// Return true if random generator can be used to create Streams of random 
numbers.
boolean isStreamable()
// Return the name of the algorithm used by the random number generator.
String name()
// Returns a RandomGeneratorFactory that can produce instances of 
RandomGenerator that utilize the name algorithm.
static RandomGeneratorFactory of​(String name)
// Return the period of the algorithm used by the random number generator.
BigInteger period()
// Returns number of bits used by the algorithm to maintain state of seed.
int stateBits()
{code}
At present the JDK 17 EA and the openjdk source on github do not have the 
java.util.random package. So we will have to wait for a release to be made 
before knowing exactly how to integrate with the code.

> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number 
> Generators 
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
>  Issue Type: Task
>  Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is 
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number 
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
>  * SplittableRandomGenerator extends RandomGenerator and also provides
>  methods named split and splits. Splittability allows the user to spawn a new 
> RandomGenerator from an existing RandomGenerator that will generally produce 
> statistically independent results.
>  * JumpableRandomGenerator extends RandomGenerator and also provides
>  methods named jump and jumps. Jumpability allows a user to jump ahead a 
> moderate number of draws.
>  * LeapableRandomGenerator extends RandomGenerator and also provides
>  methods named leap and leaps. Leapability allows a user to jump ahead a 
> large number of draws.
>  * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and 
> also provides additional variations of jump and jumps that allow an arbitrary 
> jump distance to be specified.
> The specification describes the development of abstract 

[jira] [Commented] (NET-697) problem while transferring an Ascii file containing COMP-3 values from Windows to Z\os

2021-04-07 Thread Itay Itzhak (Jira)


[ 
https://issues.apache.org/jira/browse/NET-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316297#comment-17316297
 ] 

Itay Itzhak commented on NET-697:
-

Hi,
Sorry for the late response.
We need it to work in ASCII.

Itay



> problem while transferring an Ascii file containing COMP-3 values from 
> Windows to Z\os
> --
>
> Key: NET-697
> URL: https://issues.apache.org/jira/browse/NET-697
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Reporter: Itay Itzhak
>Priority: Major
>
> For instance, consider a file with only 1 record x’4D320A0C0D0A’ 6 bytes: “M” 
> + “2” + x’0A0C’ (COMP-3 x’250C’) + x’0D0A’ (indicator for end of record) 
>  
> We expect to receive only one record EBCDIC x’D4F2250C’ but instead I get two 
> records since x’0A’ is converted to x’25’ which is EBCDIC newline character 
> (LF) 
>  
> Record 1: X’D4F2’ 
> Record 2: x’0C’ 
>  
> In Windows, the delimiter is X’0D0A’. As a matter of fact, when I transfer 
> the exact same file using Windows FTP, then I get the expected result which 
> is a single record with EBCDIC x’D4F2250C’



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-geometry] aherbert commented on a change in pull request #143: GEOMETRY-119: adding Vector.normalizeOrNull() method

2021-04-07 Thread GitBox


aherbert commented on a change in pull request #143:
URL: https://github.com/apache/commons-geometry/pull/143#discussion_r608603343



##
File path: 
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
##
@@ -828,5 +826,88 @@ public Vector3D withNorm(final double mag) {
 public Unit negate() {
 return new Unit(-getX(), -getY(), -getZ());
 }
+
+/** Create a normalized vector.
+ * @param x Vector coordinate.
+ * @param y Vector coordinate.
+ * @param z Vector coordinate.
+ * @return a vector whose norm is 1.
+ * @throws IllegalArgumentException if the norm of the given value is 
zero, NaN,
+ *  or infinite
+ */
+public static Unit from(final double x, final double y, final double 
z) {
+return tryCreateNormalized(x, y, z, true);
+}
+
+/** Create a normalized vector.
+ * @param v Vector.
+ * @return a vector whose norm is 1.
+ * @throws IllegalArgumentException if the norm of the given value is 
zero, NaN,
+ *  or infinite
+ */
+public static Unit from(final Vector3D v) {
+return v instanceof Unit ?
+(Unit) v :
+from(v.getX(), v.getY(), v.getZ());
+}
+
+/** Attempt to create a normalized vector from the given coordinate 
values. If {@code throwOnFailure}
+ * is true, an exception is thrown if a normalized vector cannot be 
created. Otherwise, null
+ * is returned.
+ * @param x x coordinate
+ * @param y y coordinate
+ * @param z z coordinate
+ * @param throwOnFailure if true, an exception will be thrown if a 
normalized vector cannot be created
+ * @return normalized vector or null if one cannot be created and 
{@code throwOnFailure}
+ *  is false
+ * @throws IllegalArgumentException if the computed norm is zero, NaN, 
or infinite
+ */
+private static Unit tryCreateNormalized(final double x, final double 
y, final double z,
+final boolean throwOnFailure) {
+
+// Compute the inverse norm directly. If the result is a non-zero 
real number,
+// then we can go ahead and construct the unit vector immediately. 
If not,
+// we'll do some extra work for edge cases.
+final double norm = Math.sqrt((x * x) + (y * y) + (z * z));

Review comment:
   Handling the common case first is a better solution than checking for 
scaling immediately.

##
File path: 
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
##
@@ -760,6 +766,21 @@ public static Vector3D linearCombination(final double a1, 
final Vector3D v1,
 /** Negation of unit vector (coordinates: 0, 0, -1). */
 public static final Unit MINUS_Z = new Unit(0d, 0d, -1d);
 
+/** Maximum coordinate value for computing normalized vectors
+ * with raw, unscaled values.
+ */
+private static final double UNSCALED_MAX = 0x1.0p+500;
+
+/** Factor used to scale up coordinate values in order to produce
+ * normalized coordinates without overflow or underflow.
+ */
+private static final double SCALE_UP_FACTOR = 0x1.0p600;

Review comment:
   For consistency use a '+' here before the 600 or drop it from the 
UNSCALED_MAX constant.

##
File path: 
commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
##
@@ -396,16 +395,40 @@ public void testNormalize() {
 checkVector(Vector3D.of(2, 2, 2).normalize(), invSqrt3, invSqrt3, 
invSqrt3);
 checkVector(Vector3D.of(-2, -2, -2).normalize(), -invSqrt3, -invSqrt3, 
-invSqrt3);
 
+checkVector(Vector3D.of(Double.MIN_VALUE, 0, 0).normalize(), 1, 0, 0);
+checkVector(Vector3D.of(0, Double.MIN_VALUE, 0).normalize(), 0, 1, 0);
+checkVector(Vector3D.of(0, 0, Double.MIN_VALUE).normalize(), 0, 0, 1);
+
+checkVector(Vector3D.of(Double.MIN_VALUE, Double.MIN_VALUE, 
Double.MIN_VALUE).normalize(),
+invSqrt3, invSqrt3, invSqrt3);
+
+checkVector(Vector3D.of(Double.MIN_NORMAL, 0, 0).normalize(), 1, 0, 0);
+checkVector(Vector3D.of(0, Double.MIN_NORMAL, 0).normalize(), 0, 1, 0);
+checkVector(Vector3D.of(0, 0, Double.MIN_NORMAL).normalize(), 0, 0, 1);
+
+checkVector(Vector3D.of(Double.MIN_NORMAL, Double.MIN_NORMAL, 
Double.MIN_NORMAL).normalize(),

Review comment:
   Use a negative here for one of the values (as done using MAX_VALUE 
below).

##
File path: 
commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
##
@@ -419,6 +442,42 @@ public void testNormalize_isIdempotent() {
 checkVector(v.normalize(), invSqrt3, invSqrt3, 

[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators

2021-04-07 Thread Gilles Sadowski (Jira)


[ 
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316291#comment-17316291
 ] 

Gilles Sadowski commented on RNG-127:
-

As you've mentioned already, my first impression is that runtime selection of 
an RNG based on state size (or for that matter, any other property) is a toy 
feature (it would be interesting to know of a use-case where that feature is 
needed).
Nevertheless, in order to comply with the upcoming JDK API, it seems easy to 
add the {{stateBits()}} method to the {{UniformRandomProvider}} interface.

bq. {code}RandomGenerator rng = RandomGenerator.of("Random");{code}

What would one write in order to load one of the Commons RNG's implementations?


> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number 
> Generators 
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
>  Issue Type: Task
>  Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is 
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number 
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
>  * SplittableRandomGenerator extends RandomGenerator and also provides
>  methods named split and splits. Splittability allows the user to spawn a new 
> RandomGenerator from an existing RandomGenerator that will generally produce 
> statistically independent results.
>  * JumpableRandomGenerator extends RandomGenerator and also provides
>  methods named jump and jumps. Jumpability allows a user to jump ahead a 
> moderate number of draws.
>  * LeapableRandomGenerator extends RandomGenerator and also provides
>  methods named leap and leaps. Leapability allows a user to jump ahead a 
> large number of draws.
>  * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and 
> also provides additional variations of jump and jumps that allow an arbitrary 
> jump distance to be specified.
> The specification describes the development of abstract classes that would 
> allow different algorithms to be easily implemented by developers and used 
> with a Java application through a common interface. This would replicate the 
> functionality of the Common RNG API and core modules within the JDK.
> The JDK interfaces should be compared with the current client API in Commons 
> RNG with the aim to assess:
>  # Compatibility
>  # Potential to back-port functionality
> JEP 356 also mentions the implementation of the LXM family of RNGs and a 
> change to the algorithm used by SplittableRandom to address two weaknesses 
> identified in 2016. These could be included in the current codebase pending 
> license compatibility checks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEOMETRY-119) Vector normalizeOrDefault() method

2021-04-07 Thread Matt Juntunen (Jira)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316279#comment-17316279
 ] 

Matt Juntunen commented on GEOMETRY-119:


I was able to get the best performance using the following code. It tries the 
unscaled norm first (which should be the majority of cases in actual usage) and 
then, failing that, attempts to scale the coordinate values.
{code:java}
private static Unit tryCreateNormalized(final double x, final double y, final 
double z,
final boolean throwOnFailure) {

// Compute the inverse norm directly. If the result is a non-zero 
real number,
// then we can go ahead and construct the unit vector immediately. 
If not,
// we'll do some extra work for edge cases.
final double norm = Math.sqrt((x * x) + (y * y) + (z * z));
final double normInv = 1.0 / norm;
if (Vectors.isRealNonZero(normInv)) {
return new Unit(
x * normInv,
y * normInv,
z * normInv);
}

// Direct computation did not work. Try scaled versions of the 
coordinates
// to handle overflow and underflow.
final double scaledX;
final double scaledY;
final double scaledZ;

final double maxCoord = Math.max(Math.max(Math.abs(x), 
Math.abs(y)), Math.abs(z));
if (maxCoord > UNSCALED_MAX) {
scaledX = x * SCALE_DOWN_FACTOR;
scaledY = y * SCALE_DOWN_FACTOR;
scaledZ = z * SCALE_DOWN_FACTOR;
} else {
scaledX = x * SCALE_UP_FACTOR;
scaledY = y * SCALE_UP_FACTOR;
scaledZ = z * SCALE_UP_FACTOR;
}

final double scaledNormInv = 1.0 / Math.sqrt(
(scaledX * scaledX) +
(scaledY * scaledY) +
(scaledZ * scaledZ));

if (Vectors.isRealNonZero(scaledNormInv)) {
return new Unit(
scaledX * scaledNormInv,
scaledY * scaledNormInv,
scaledZ * scaledNormInv);
} else if (throwOnFailure) {
throw Vectors.illegalNorm(norm);
}
return null;
}
{code}

I also ran some performance metrics on using {{Optional}} vs just returning 
null. The two approaches are virtually the same with small numbers of inputs 
but there is a consistent penalty for large numbers of inputs. The table below 
shows scores averaged over 5 benchmark runs with an input of 1 vectors.

||method||score (ns)||
|optional|426715.7478|
|null|407998.161|

Based on this, I believe the best approach is to skip using {{Optional}} and 
just use {{normalizeOrNull}}. Calllers can easily use {{Optional}} in their own 
code and accept the performance penalty by just calling 
{{Optional.ofNullable(v.normalizeOrNull)}}. However, if we returned 
{{Optional}} from the vector method, there would be no way for calllers to opt 
out of the penalty.

I've updated the [PR|https://github.com/apache/commons-geometry/pull/143] with 
these changes. Any more thoughts on this?


> Vector normalizeOrDefault() method
> --
>
> Key: GEOMETRY-119
> URL: https://issues.apache.org/jira/browse/GEOMETRY-119
> Project: Apache Commons Geometry
>  Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
>
> A frequent use case when working with vectors, especially vectors coming from 
> external data, is attempting to normalize the vector, and if this is not 
> possible, to use an alternative value. For example, the 
> {{QuaternionRotation}} code 
> [here|https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java#L86]
>  does exactly this; it attempts to normalize a vector and failing that (ie, 
> if the vector is exactly zero), it returns a substitute value. The 
> {{QuaternionRotation}} class is able to take advantage of our internal 
> {{Vectors.tryNormalize()}} but callers outside of the library are not able to 
> do so and so are left with 2 choices:
> 1. wrap the {{normalize()}} call in a try-catch and handle the exception 
> thrown on illegal norm values, or
> 2. compute and test the norm prior to calling {{normalize()}} to ensure that 
> the call won't fail, resulting in 2 computations of the norm.
> Neither of these options are very good.
> I propose adding a new method to the Euclidean Vector classes to handle this 
> situation: {{normalizeOrDefault()}}. The method would accept a default value 
> (possibly null) to return if the vector cannot be normalized. The normal 
> would 

[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators

2021-04-07 Thread Alex Herbert (Jira)


[ 
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316263#comment-17316263
 ] 

Alex Herbert commented on RNG-127:
--

bq. Does this amount to providing instantiation by name (as a String)?

With integration into the service provider API you will be able to instantiate 
by name. The example on JDK-8255395 is:

{code:java}
RandomGenerator rng = RandomGenerator.of("Random");
{code}

The support for loading via the service allows query of the types of provider 
and selection from those available. The example given selects a RNG with at 
least 128 bits of state (although nothing in the API can help select the 
fastest or most secure generator):

{code:java}
RandomGeneratorFactory factory =
RandomGenerator.all()
   .filter(f -> 128 <= g.stateBits())
   .sorted((f, g) -> Integer.compare(g.stateBits(), 
f.stateBits()))
   .findFirst()
   .orElseThrow();
{code}

You can for example select from those that are jumpable, leapable or hardware 
supported.


> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number 
> Generators 
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
>  Issue Type: Task
>  Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is 
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number 
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
>  * SplittableRandomGenerator extends RandomGenerator and also provides
>  methods named split and splits. Splittability allows the user to spawn a new 
> RandomGenerator from an existing RandomGenerator that will generally produce 
> statistically independent results.
>  * JumpableRandomGenerator extends RandomGenerator and also provides
>  methods named jump and jumps. Jumpability allows a user to jump ahead a 
> moderate number of draws.
>  * LeapableRandomGenerator extends RandomGenerator and also provides
>  methods named leap and leaps. Leapability allows a user to jump ahead a 
> large number of draws.
>  * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and 
> also provides additional variations of jump and jumps that allow an arbitrary 
> jump distance to be specified.
> The specification describes the development of abstract classes that would 
> allow different algorithms to be easily implemented by developers and used 
> with a Java application through a common interface. This would replicate the 
> functionality of the Common RNG API and core modules within the JDK.
> The JDK interfaces should be compared with the current client API in Commons 
> RNG with the aim to assess:
>  # Compatibility
>  # Potential to back-port functionality
> JEP 356 also mentions the implementation of the LXM family of RNGs and a 
> change to the algorithm used by SplittableRandom to address two weaknesses 
> identified in 2016. These could be included in the current codebase pending 
> license compatibility checks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [commons-jcs] dependabot[bot] opened a new pull request #57: Bump tomcat-coyote from 7.0.72 to 10.0.5

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #57:
URL: https://github.com/apache/commons-jcs/pull/57


   Bumps tomcat-coyote from 7.0.72 to 10.0.5.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat:tomcat-coyote=maven=7.0.72=10.0.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-jcs] dependabot[bot] commented on pull request #51: Bump tomcat-catalina from 7.0.72 to 8.5.64

2021-04-07 Thread GitBox


dependabot[bot] commented on pull request #51:
URL: https://github.com/apache/commons-jcs/pull/51#issuecomment-814679206


   Superseded by #56.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-jcs] dependabot[bot] closed pull request #51: Bump tomcat-catalina from 7.0.72 to 8.5.64

2021-04-07 Thread GitBox


dependabot[bot] closed pull request #51:
URL: https://github.com/apache/commons-jcs/pull/51


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-jcs] dependabot[bot] opened a new pull request #56: Bump tomcat-catalina from 7.0.72 to 8.5.65

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #56:
URL: https://github.com/apache/commons-jcs/pull/56


   Bumps tomcat-catalina from 7.0.72 to 8.5.65.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat:tomcat-catalina=maven=7.0.72=8.5.65)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-jcs] dependabot[bot] opened a new pull request #55: Bump tomcat-jasper from 7.0.72 to 10.0.5

2021-04-07 Thread GitBox


dependabot[bot] opened a new pull request #55:
URL: https://github.com/apache/commons-jcs/pull/55


   Bumps tomcat-jasper from 7.0.72 to 10.0.5.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat:tomcat-jasper=maven=7.0.72=10.0.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [commons-vfs] boris-petrov opened a new pull request #177: Update `actions/setup-java`

2021-04-07 Thread GitBox


boris-petrov opened a new pull request #177:
URL: https://github.com/apache/commons-vfs/pull/177


   Closes #176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org