[GitHub] [commons-ognl] lukaszlenart commented on a change in pull request #46: Minor Changes:
lukaszlenart commented on a change in pull request #46:
URL: https://github.com/apache/commons-ognl/pull/46#discussion_r655877580
##
File path: src/main/java/org/apache/commons/ognl/ASTVarRef.java
##
@@ -124,7 +124,7 @@ public String toGetSourceString( OgnlContext context,
Object target )
post = ")";
}
-if ( parent != null && ASTAssign.class.isInstance( parent ) )
+if (ASTAssign.class.isInstance(parent))
Review comment:
Why not to use `isinstanceof`?
##
File path: src/main/java/org/apache/commons/ognl/ASTAdd.java
##
@@ -129,13 +129,6 @@ boolean isWider( NodeType type, NodeType lastType )
{
return false;
}
-
-if ( Float.class.isAssignableFrom( type.getGetterClass() )
-&& Integer.class.isAssignableFrom( lastType.getGetterClass() ) )
-{
-return true;
-}
Review comment:
Why did you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #45: Redundant calls of java.lang.Class methods.
lukaszlenart merged pull request #45: URL: https://github.com/apache/commons-ognl/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #209: Bump mockito-core from 3.11.1 to 3.11.2
coveralls commented on pull request #209: URL: https://github.com/apache/commons-compress/pull/209#issuecomment-865511825 [](https://coveralls.io/builds/40765660) Coverage remained the same at 86.812% when pulling **28b52d50d148296880d2a856ffcd04958e553715 on dependabot/maven/org.mockito-mockito-core-3.11.2** into **7c79a748a5626149606608742a0c4e958c01cb96 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #208: Bump org.apache.felix.framework from 7.0.0 to 7.0.1
coveralls commented on pull request #208: URL: https://github.com/apache/commons-compress/pull/208#issuecomment-865511741 [](https://coveralls.io/builds/40765661) Coverage remained the same at 86.812% when pulling **b9b1d548d22471b5243e475d57cba7caa2b4a8a8 on dependabot/maven/org.apache.felix-org.apache.felix.framework-7.0.1** into **7c79a748a5626149606608742a0c4e958c01cb96 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] closed pull request #114: Bump mockito-core from 3.11.0 to 3.11.1
dependabot[bot] closed pull request #114: URL: https://github.com/apache/commons-dbcp/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #116: Bump mockito-core from 3.11.0 to 3.11.2
dependabot[bot] opened a new pull request #116: URL: https://github.com/apache/commons-dbcp/pull/116 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.11.0 to 3.11.2. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v3.11.2 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.2 2021-06-21 - https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>5 commit(s) by dependabot[bot] Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333)](https://github-redirect.dependabot.com/mockito/mockito/pull/2333";>mockito/mockito#2333) Bump assertj-core from 3.20.0 to 3.20.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332)](https://github-redirect.dependabot.com/mockito/mockito/pull/2332";>mockito/mockito#2332) Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330)](https://github-redirect.dependabot.com/mockito/mockito/pull/2330";>mockito/mockito#2330) Bump assertj-core from 3.19.0 to 3.20.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329)](https://github-redirect.dependabot.com/mockito/mockito/pull/2329";>mockito/mockito#2329) Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328)](https://github-redirect.dependabot.com/mockito/mockito/pull/2328";>mockito/mockito#2328) v3.11.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.1 2021-06-11 - https://github.com/mockito/mockito/compare/v3.11.0...v3.11.1";>3 commit(s) by Charles Munger, dependabot[bot] Bump versions.bytebuddy from 1.11.1 to 1.11.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2322";>#2322)](https://github-redirect.dependabot.com/mockito/mockito/pull/2322";>mockito/mockito#2322) Check package-privacy of method params [(https://github-redirect.dependabot.com/mockito/mockito/issues/2318";>#2318)](https://github-redirect.dependabot.com/mockito/mockito/pull/2318";>mockito/mockito#2318) Bump shipkit-auto-version from 1.1.16 to 1.1.17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2317";>#2317)](https://github-redirect.dependabot.com/mockito/mockito/pull/2317";>mockito/mockito#2317) Commits https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0";>2be3fcf Bump versions.bytebuddy from 1.11.2 to 1.11.3 (https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333) https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8";>566cfa5 Bump assertj-core from 3.20.0 to 3.20.1 (https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332) https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df";>a8164ea Bump shipkit-auto-version from 1.1.17 to 1.1.19 (https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328) https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440";>163629c Bump assertj-core from 3.19.0 to 3.20.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329) https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0";>441e556 Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330) https://github.com/mockito/mockito/commit/ef34307383da5a27fff23f7310787d262fbb4cfd";>ef34307 Bump versions.bytebuddy from 1.11.1 to 1.11.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2322";>#2322) https://github.com/mockito/mockito/commit/41e445c1f7029a8635283428f1f02846ba95f241";>41e445c Check for non-public type references in methods (https://github-redirect.dependabot.com/mockito/mockito/issues/2318";>#2318) https://github.com/mockito/mockito/commit/07951e90c82d194f65821ff809247ea819264ea2";>07951e9 Bump shipkit-auto-version from 1.1.16 to 1.1.17 (https://github-redirect.dependabot.com/mockito/mockito/issues/2317";>#2317) See full diff in https://github.com/mockito/mockito/compare/v3.11.0...v3.11.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start)
[GitHub] [commons-dbcp] dependabot[bot] commented on pull request #114: Bump mockito-core from 3.11.0 to 3.11.1
dependabot[bot] commented on pull request #114: URL: https://github.com/apache/commons-dbcp/pull/114#issuecomment-865509919 Superseded by #116. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #209: Bump mockito-core from 3.11.1 to 3.11.2
dependabot[bot] opened a new pull request #209: URL: https://github.com/apache/commons-compress/pull/209 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.11.1 to 3.11.2. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v3.11.2 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.2 2021-06-21 - https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>5 commit(s) by dependabot[bot] Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333)](https://github-redirect.dependabot.com/mockito/mockito/pull/2333";>mockito/mockito#2333) Bump assertj-core from 3.20.0 to 3.20.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332)](https://github-redirect.dependabot.com/mockito/mockito/pull/2332";>mockito/mockito#2332) Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330)](https://github-redirect.dependabot.com/mockito/mockito/pull/2330";>mockito/mockito#2330) Bump assertj-core from 3.19.0 to 3.20.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329)](https://github-redirect.dependabot.com/mockito/mockito/pull/2329";>mockito/mockito#2329) Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328)](https://github-redirect.dependabot.com/mockito/mockito/pull/2328";>mockito/mockito#2328) Commits https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0";>2be3fcf Bump versions.bytebuddy from 1.11.2 to 1.11.3 (https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333) https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8";>566cfa5 Bump assertj-core from 3.20.0 to 3.20.1 (https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332) https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df";>a8164ea Bump shipkit-auto-version from 1.1.17 to 1.1.19 (https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328) https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440";>163629c Bump assertj-core from 3.19.0 to 3.20.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329) https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0";>441e556 Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330) See full diff in https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.or
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #208: Bump org.apache.felix.framework from 7.0.0 to 7.0.1
dependabot[bot] opened a new pull request #208: URL: https://github.com/apache/commons-compress/pull/208 Bumps org.apache.felix.framework from 7.0.0 to 7.0.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
dependabot[bot] commented on pull request #244: URL: https://github.com/apache/commons-text/pull/244#issuecomment-865462594 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
kinow closed pull request #244: URL: https://github.com/apache/commons-text/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls edited a comment on pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
coveralls edited a comment on pull request #244: URL: https://github.com/apache/commons-text/pull/244#issuecomment-865367844 [](https://coveralls.io/builds/40763649) Coverage remained the same at 97.961% when pulling **7f57668ee2810137c8548feeabd3371c723a5752 on dependabot/maven/org.assertj-assertj-core-3.20.2** into **fc175c17d2ffe0e403d91c4870aa742d6dbd3b14 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
kinow commented on pull request #244: URL: https://github.com/apache/commons-text/pull/244#issuecomment-865454794 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #243: Bump mockito-inline from 3.11.1 to 3.11.2
kinow closed pull request #243: URL: https://github.com/apache/commons-text/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #243: Bump mockito-inline from 3.11.1 to 3.11.2
dependabot[bot] commented on pull request #243: URL: https://github.com/apache/commons-text/pull/243#issuecomment-865454623 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #247: Bump mockito-inline from 3.11.0 to 3.11.2
coveralls commented on pull request #247: URL: https://github.com/apache/commons-io/pull/247#issuecomment-865430570 [](https://coveralls.io/builds/40762659) Coverage increased (+0.1%) to 89.384% when pulling **846b2ce370876a9ef03d529cb5dd2454aec2cc13 on dependabot/maven/org.mockito-mockito-inline-3.11.2** into **021879c4e8a80da4d814d6777d9dcbb215357e67 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request #247: Bump mockito-inline from 3.11.0 to 3.11.2
dependabot[bot] opened a new pull request #247: URL: https://github.com/apache/commons-io/pull/247 Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.11.0 to 3.11.2. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-inline's releases. v3.11.2 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.2 2021-06-21 - https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>5 commit(s) by dependabot[bot] Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333)](https://github-redirect.dependabot.com/mockito/mockito/pull/2333";>mockito/mockito#2333) Bump assertj-core from 3.20.0 to 3.20.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332)](https://github-redirect.dependabot.com/mockito/mockito/pull/2332";>mockito/mockito#2332) Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330)](https://github-redirect.dependabot.com/mockito/mockito/pull/2330";>mockito/mockito#2330) Bump assertj-core from 3.19.0 to 3.20.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329)](https://github-redirect.dependabot.com/mockito/mockito/pull/2329";>mockito/mockito#2329) Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328)](https://github-redirect.dependabot.com/mockito/mockito/pull/2328";>mockito/mockito#2328) v3.11.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.1 2021-06-11 - https://github.com/mockito/mockito/compare/v3.11.0...v3.11.1";>3 commit(s) by Charles Munger, dependabot[bot] Bump versions.bytebuddy from 1.11.1 to 1.11.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2322";>#2322)](https://github-redirect.dependabot.com/mockito/mockito/pull/2322";>mockito/mockito#2322) Check package-privacy of method params [(https://github-redirect.dependabot.com/mockito/mockito/issues/2318";>#2318)](https://github-redirect.dependabot.com/mockito/mockito/pull/2318";>mockito/mockito#2318) Bump shipkit-auto-version from 1.1.16 to 1.1.17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2317";>#2317)](https://github-redirect.dependabot.com/mockito/mockito/pull/2317";>mockito/mockito#2317) Commits https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0";>2be3fcf Bump versions.bytebuddy from 1.11.2 to 1.11.3 (https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333) https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8";>566cfa5 Bump assertj-core from 3.20.0 to 3.20.1 (https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332) https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df";>a8164ea Bump shipkit-auto-version from 1.1.17 to 1.1.19 (https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328) https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440";>163629c Bump assertj-core from 3.19.0 to 3.20.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329) https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0";>441e556 Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330) https://github.com/mockito/mockito/commit/ef34307383da5a27fff23f7310787d262fbb4cfd";>ef34307 Bump versions.bytebuddy from 1.11.1 to 1.11.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2322";>#2322) https://github.com/mockito/mockito/commit/41e445c1f7029a8635283428f1f02846ba95f241";>41e445c Check for non-public type references in methods (https://github-redirect.dependabot.com/mockito/mockito/issues/2318";>#2318) https://github.com/mockito/mockito/commit/07951e90c82d194f65821ff809247ea819264ea2";>07951e9 Bump shipkit-auto-version from 1.1.16 to 1.1.17 (https://github-redirect.dependabot.com/mockito/mockito/issues/2317";>#2317) See full diff in https://github.com/mockito/mockito/compare/v3.11.0...v3.11.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-star
[GitHub] [commons-io] dependabot[bot] closed pull request #246: Bump mockito-inline from 3.11.0 to 3.11.1
dependabot[bot] closed pull request #246: URL: https://github.com/apache/commons-io/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] commented on pull request #246: Bump mockito-inline from 3.11.0 to 3.11.1
dependabot[bot] commented on pull request #246: URL: https://github.com/apache/commons-io/pull/246#issuecomment-865424266 Superseded by #247. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-163) Summation and LinearCombination Accumulators
[
https://issues.apache.org/jira/browse/NUMBERS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366851#comment-17366851
]
Matt Juntunen commented on NUMBERS-163:
---
bq. Do you want to support this?
I do not. I'm of the opinion that we add a bit more documentation, per [~erans]
comments above, and then stick a fork in it.
On a related note, I just made a PR for GEOMETRY-126, which updates
commons-geometry to use the new {{Sum}} class instead of {{LinearCombination}}.
I also removed the {{VectorXD.linearCombination()}} methods there and replaced
them with {{VectorXD.Sum}} classes following the pattern we just used here.
> Summation and LinearCombination Accumulators
>
>
> Key: NUMBERS-163
> URL: https://issues.apache.org/jira/browse/NUMBERS-163
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: FMA.java, Sum.java
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It would be useful to have simple accumulator classes in {{Summation}} and
> {{LinearCombination}} to perform extended precision operations on arbitrary
> collections of values without requiring conversion to {{double[]}}. Ex:
> {code:java}
> Summation.Accumulator sum= Summation.accumulator(1d);
> sum.add(x)
> .add(y)
> .add(z)
>.add(w);
> double sumResult = sum.get();
> LinearCombination.Accumulator comb = LinearCombination.accumulator(1d);
> comb.add(x, scale)
> .add(y, scale)
> .add(z, scale)
> .add(w, scale);
> double combResult = comb.get();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEOMETRY-126) Replace LinearCombination with Sum
[
https://issues.apache.org/jira/browse/GEOMETRY-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366848#comment-17366848
]
Matt Juntunen commented on GEOMETRY-126:
PR is here: https://github.com/apache/commons-geometry/pull/174
> Replace LinearCombination with Sum
> --
>
> Key: GEOMETRY-126
> URL: https://issues.apache.org/jira/browse/GEOMETRY-126
> Project: Apache Commons Geometry
> Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Major
>
> NUMBERS-163 replaced the {{LinearCombination}} class with {{Sum}} is
> commons-numbers. The code needs to be updated to use this new class. We
> should also remove the {{VectorXD.linearCombination()}} methods in favor of
> {{VectorXD.Sum}} class, following the pattern from commons-numbers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-geometry] darkma773r opened a new pull request #174: GEOMETRY-126: VectorXD.Sum classes
darkma773r opened a new pull request #174: URL: https://github.com/apache/commons-geometry/pull/174 - replacing usage of commons-numbers LinearCombination, which has been removed, with commons-numbers Sum class - replacing VectorXD.linearCombination() methods with VectorXD.Sum classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (GEOMETRY-126) Replace LinearCombination with Sum
Matt Juntunen created GEOMETRY-126:
--
Summary: Replace LinearCombination with Sum
Key: GEOMETRY-126
URL: https://issues.apache.org/jira/browse/GEOMETRY-126
Project: Apache Commons Geometry
Issue Type: Task
Reporter: Matt Juntunen
NUMBERS-163 replaced the {{LinearCombination}} class with {{Sum}} is
commons-numbers. The code needs to be updated to use this new class. We should
also remove the {{VectorXD.linearCombination()}} methods in favor of
{{VectorXD.Sum}} class, following the pattern from commons-numbers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] coveralls commented on pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
coveralls commented on pull request #244: URL: https://github.com/apache/commons-text/pull/244#issuecomment-865367844 [](https://coveralls.io/builds/40759874) Coverage remained the same at 97.961% when pulling **0f1b170f3948de5118436360cd74478bf06e77d5 on dependabot/maven/org.assertj-assertj-core-3.20.2** into **38eb80048863b58135783040072696c31537afd3 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #241: Bump assertj-core from 3.19.0 to 3.20.1
dependabot[bot] commented on pull request #241: URL: https://github.com/apache/commons-text/pull/241#issuecomment-865306593 Superseded by #244. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] closed pull request #241: Bump assertj-core from 3.19.0 to 3.20.1
dependabot[bot] closed pull request #241: URL: https://github.com/apache/commons-text/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #244: Bump assertj-core from 3.19.0 to 3.20.2
dependabot[bot] opened a new pull request #244: URL: https://github.com/apache/commons-text/pull/244 Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.19.0 to 3.20.2. Commits https://github.com/assertj/assertj-core/commit/089086c5f013582a1c81a76f9c5eaa4a240e5ad3";>089086c [maven-release-plugin] prepare release assertj-core-3.20.2 https://github.com/assertj/assertj-core/commit/0fff0ce98611d4b74a6badc0ac710dafd4be36a0";>0fff0ce Restore explicit version for pitest-github-maven-plugin https://github.com/assertj/assertj-core/commit/9df530d4b375b42e7007ae6470604532d435a5cd";>9df530d Revert "[Breaking change] Align return types across assertions / assumptions ... https://github.com/assertj/assertj-core/commit/e3d9e070dfe11465d1fd30b705f8ba66224424bb";>e3d9e07 Restore deep equality comparison for map containsOnly assertions (https://github-redirect.dependabot.com/assertj/assertj-core/issues/2265";>#2265) https://github.com/assertj/assertj-core/commit/f8ee3f36ecccdfb49adb9e24b8bebc44db46a3db";>f8ee3f3 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj-core/commit/fc6c3b5b2e7dd8d3f1049efa366bb2878acaac3e";>fc6c3b5 [maven-release-plugin] prepare release assertj-core-3.20.1 https://github.com/assertj/assertj-core/commit/f3398db102423a4acc5f0e803f0b6af1683b5b90";>f3398db Fix array comparison with null values (https://github-redirect.dependabot.com/assertj/assertj-core/issues/2261";>#2261) https://github.com/assertj/assertj-core/commit/8e33c97216b70e78c3d230cd61420bb00e926135";>8e33c97 Bump assertj-parent-pom from 2.2.10 to 2.2.13 (https://github-redirect.dependabot.com/assertj/assertj-core/issues/2260";>#2260) https://github.com/assertj/assertj-core/commit/ddff1fcd2d8d55450ab7161b48fdf18cfb54c419";>ddff1fc Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (https://github-redirect.dependabot.com/assertj/assertj-core/issues/2259";>#2259) https://github.com/assertj/assertj-core/commit/c4cee17df45b42375f8bc52334c9829cbcc0fa9e";>c4cee17 Move pitest-github-maven-plugin declaration to POM plugin management Additional commits viewable in https://github.com/assertj/assertj-core/compare/assertj-core-3.19.0...assertj-core-3.20.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #243: Bump mockito-inline from 3.11.1 to 3.11.2
dependabot[bot] opened a new pull request #243: URL: https://github.com/apache/commons-text/pull/243 Bumps [mockito-inline](https://github.com/mockito/mockito) from 3.11.1 to 3.11.2. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-inline's releases. v3.11.2 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 3.11.2 2021-06-21 - https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>5 commit(s) by dependabot[bot] Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333)](https://github-redirect.dependabot.com/mockito/mockito/pull/2333";>mockito/mockito#2333) Bump assertj-core from 3.20.0 to 3.20.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332)](https://github-redirect.dependabot.com/mockito/mockito/pull/2332";>mockito/mockito#2332) Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330)](https://github-redirect.dependabot.com/mockito/mockito/pull/2330";>mockito/mockito#2330) Bump assertj-core from 3.19.0 to 3.20.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329)](https://github-redirect.dependabot.com/mockito/mockito/pull/2329";>mockito/mockito#2329) Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328)](https://github-redirect.dependabot.com/mockito/mockito/pull/2328";>mockito/mockito#2328) Commits https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0";>2be3fcf Bump versions.bytebuddy from 1.11.2 to 1.11.3 (https://github-redirect.dependabot.com/mockito/mockito/issues/2333";>#2333) https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8";>566cfa5 Bump assertj-core from 3.20.0 to 3.20.1 (https://github-redirect.dependabot.com/mockito/mockito/issues/2332";>#2332) https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df";>a8164ea Bump shipkit-auto-version from 1.1.17 to 1.1.19 (https://github-redirect.dependabot.com/mockito/mockito/issues/2328";>#2328) https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440";>163629c Bump assertj-core from 3.19.0 to 3.20.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2329";>#2329) https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0";>441e556 Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (https://github-redirect.dependabot.com/mockito/mockito/issues/2330";>#2330) See full diff in https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.
[GitHub] [commons-ognl] arturobernalg opened a new pull request #46: Minor Changes:
arturobernalg opened a new pull request #46: URL: https://github.com/apache/commons-ognl/pull/46 * Simplify conditions. * Remove unnecessary 'null' check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] arturobernalg commented on pull request #45: Redundant calls of java.lang.Class methods.
arturobernalg commented on pull request #45: URL: https://github.com/apache/commons-ognl/pull/45#issuecomment-865257835 HI @lukaszlenart I think we don't need check dynamic if are assignment-compatible. IMO `isInstance` should be use when are using reflection. Off course this can be subjective :) TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-163) Summation and LinearCombination Accumulators
[
https://issues.apache.org/jira/browse/NUMBERS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366760#comment-17366760
]
Alex Herbert commented on NUMBERS-163:
--
I think that allowing the addition of a BigDecimal in the API would have
problems ensuring accuracy. Either you convert the BigDecimal to a double (loss
of precision) or you convert it to a series of overlapping double values and
add each one. This will be slow.
Untested...
{code:java}
// Addend
BigDecimal x;
if (x.abs().compareTo(new BigDecimal(Double.MAX_VALUE)) > 0) {
// Throw or just make the sum infinity
throw new IllegalArgumentException("Too big");
}
while (true) {
double d = x.toDouble();
if (d == 0) {
// Because BigDecimal can be below Double.MIN_VALUE
break;
}
// Add the double d to our sum
// Get the rest of the number
x = x.subtract(new BigDecimal(d));
}
{code}
Do you want to support this?
> Summation and LinearCombination Accumulators
>
>
> Key: NUMBERS-163
> URL: https://issues.apache.org/jira/browse/NUMBERS-163
> Project: Commons Numbers
> Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: FMA.java, Sum.java
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It would be useful to have simple accumulator classes in {{Summation}} and
> {{LinearCombination}} to perform extended precision operations on arbitrary
> collections of values without requiring conversion to {{double[]}}. Ex:
> {code:java}
> Summation.Accumulator sum= Summation.accumulator(1d);
> sum.add(x)
> .add(y)
> .add(z)
>.add(w);
> double sumResult = sum.get();
> LinearCombination.Accumulator comb = LinearCombination.accumulator(1d);
> comb.add(x, scale)
> .add(y, scale)
> .add(z, scale)
> .add(w, scale);
> double combResult = comb.get();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-724) FileUtils.deleteDirectory javadoc is inaccurate for nonexistent directory
[
https://issues.apache.org/jira/browse/IO-724?focusedWorklogId=612740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612740
]
ASF GitHub Bot logged work on IO-724:
-
Author: ASF GitHub Bot
Created on: 21/Jun/21 15:54
Start Date: 21/Jun/21 15:54
Worklog Time Spent: 10m
Work Description: liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843
> > @XenoAmess @garydgregory thank you, can you then please review and merge
this PR ?
>
> I should be able to look at this later today, AFK ATM.
@garydgregory thanks, will wait for your review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 612740)
Time Spent: 1h 50m (was: 1h 40m)
> FileUtils.deleteDirectory javadoc is inaccurate for nonexistent directory
> -
>
> Key: IO-724
> URL: https://issues.apache.org/jira/browse/IO-724
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.8.0
>Reporter: Henry Tung
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> FileUtils.deleteDirectory javadoc claims:
> {code:java}
> @throws IllegalArgumentException if {@code directory} does not exist or is
> not a directory{code}
> but the first two lines of the code are:
> {code:java}
> Objects.requireNonNull(directory, "directory");
> if (!directory.exists()) {
> return;
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
liran2000 commented on pull request #245: URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843 > > @XenoAmess @garydgregory thank you, can you then please review and merge this PR ? > > I should be able to look at this later today, AFK ATM. @garydgregory thanks, will wait for your review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (POOL-396) Exceptions in validation can cause an object's lifecycle to be stuck in EVICTION state
[
https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366675#comment-17366675
]
Jeremy Kong commented on POOL-396:
--
No worries! That's good to hear. Yep, rethrowing seems reasonable - I've added
that.
> Exceptions in validation can cause an object's lifecycle to be stuck in
> EVICTION state
> --
>
> Key: POOL-396
> URL: https://issues.apache.org/jira/browse/POOL-396
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 2.4.2, 2.9.0
>Reporter: Jeremy Kong
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, if validation of an object throws an exception when testing an
> idle object during eviction, an exception will be thrown from the evict()
> method. This causes the object to be left in the EVICTION state, but still be
> present in the idleObjects queue.
> Future runs of the eviction thread will run into an infinite loop, because
> they pick up the afflicted object from the queue, fail to set its state to
> EVICTION, don't count it as a test, and repeat ad infinitum. This infinite
> loop means that no further evictions will take place; it also causes
> increases in garbage collection owing to allocation of the EvictionIterator
> on each loop iteration.
> This test added to TestGenericObjectPool (plus a small change allowing
> exceptions to be thrown from the validateObject method of SimpleFactory)
> reproduces the issue.
> {code:java}
> @Test
> @Timeout(value = 6, unit = TimeUnit.MILLISECONDS)
> public void testExceptionInValidationDuringEviction() throws Exception {
> genericObjectPool.setMaxIdle(1);
> genericObjectPool.setMaxTotal(2);
> genericObjectPool.setNumTestsPerEvictionRun(1);
> genericObjectPool.setMinEvictableIdleTime(Duration.ofMillis(0));
> genericObjectPool.setTestWhileIdle(true);
> String active = genericObjectPool.borrowObject();
> genericObjectPool.returnObject(active);
> simpleFactory.setThrowExceptionOnValidate(true);
> try {
> genericObjectPool.evict();
> } catch (Exception e) {
> // OK that a given run fails. But the object should still be evicted.
> }
> genericObjectPool.evict(); // currently fails: causes an infinite loop!
> assertEquals(0, genericObjectPool.getNumActive());
> assertEquals(0, genericObjectPool.getNumIdle());
> }
> {code}
> It seems that protection against exceptions thrown by validation code exist
> elsewhere (e.g. in borrowObject()); similarly, protections against exceptions
> thrown by user eviction policy code exist in evict(). So it looks like the
> testWhileIdle() portion of evict() needs to similarly be protected.
> Thanks!
> Jeremy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-validator] homebeaver commented on pull request #58: fix ci
homebeaver commented on pull request #58: URL: https://github.com/apache/commons-validator/pull/58#issuecomment-864953075 fixes **build (16, ...)** 👍 , see https://github.com/siom79/japicmp/issues/275 `Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on project commons-validator: Execution default-cli of goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp failed: An API incompatibility was encountered while executing com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp: java.lang.ExceptionInInitializerError: null` thkx @XenoAmess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-165) Norm of empty array
[
https://issues.apache.org/jira/browse/NUMBERS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366473#comment-17366473
]
Gilles Sadowski commented on NUMBERS-165:
-
Does it make sense to not make the additional check, leaving it to the caller
to ensure proper usage? Or would the (supposed) performance gain be too
marginal wrt the risk of some error going unnoticed?
> Norm of empty array
> ---
>
> Key: NUMBERS-165
> URL: https://issues.apache.org/jira/browse/NUMBERS-165
> Project: Commons Numbers
> Issue Type: Bug
> Components: core
>Reporter: Gilles Sadowski
>Assignee: Gilles Sadowski
>Priority: Major
> Fix For: 1.0
>
>
> {code}
> double n = Norm.L1.of(new double[0]); // n == 0
> {code}
> I think that an exception should be raised.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
