[GitHub] [commons-configuration] NingZhang-e commented on pull request #36: [CONFIGURATION-764] Default date lookup can not work for some specific
NingZhang-e commented on pull request #36: URL: https://github.com/apache/commons-configuration/pull/36#issuecomment-869280607 @garydgregory Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #248: Bump checkstyle from 8.43 to 8.44
coveralls commented on pull request #248: URL: https://github.com/apache/commons-io/pull/248#issuecomment-869251375 [](https://coveralls.io/builds/40915132) Coverage remained the same at 89.25% when pulling **1981422ecbed34923709f9e07643b271904ce23a on dependabot/maven/com.puppycrawl.tools-checkstyle-8.44** into **369e45fe3b179bd44af9f19bc22187b3fa5a7fd3 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request #248: Bump checkstyle from 8.43 to 8.44
dependabot[bot] opened a new pull request #248: URL: https://github.com/apache/commons-io/pull/248 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.43 to 8.44. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.44 https://checkstyle.org/releasenotes.html#Release_8.44;>https://checkstyle.org/releasenotes.html#Release_8.44 Commits https://github.com/checkstyle/checkstyle/commit/c32a729001aebe12741ad9881c7a36cdba0075c4;>c32a729 [maven-release-plugin] prepare release checkstyle-8.44 https://github.com/checkstyle/checkstyle/commit/94b60c17b5214cb4700b8dce0344577bc98283d0;>94b60c1 doc: erlease notes 8.44 https://github.com/checkstyle/checkstyle/commit/28fe68362d6d177b7add72ceebe09d3636f54084;>28fe683 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9142;>#9142: Migrate to Truth in AutomaticBeanTest https://github.com/checkstyle/checkstyle/commit/0d9b3afe600b247eaccf758a0c6ae2bc8409a268;>0d9b3af config: bump sevntu to 1.40.0 https://github.com/checkstyle/checkstyle/commit/6f2ce0991dbf65522194d08f3a2f4e155e532112;>6f2ce09 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10174;>#10174: Updated inputs for AnnotationLocationCheckTest https://github.com/checkstyle/checkstyle/commit/8bd7b36c963b5b9c65a79aeb5f1c1204ce1b049b;>8bd7b36 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10175;>#10175: Updated inputs for ArrayTypeStyleCheckTest https://github.com/checkstyle/checkstyle/commit/d9ebde55f07fce2fd541cf6d10d35806c2b3ff4d;>d9ebde5 minor: fix IDEA violations https://github.com/checkstyle/checkstyle/commit/f6068e04e8388c30cb5d98397fb623b0b445d690;>f6068e0 minor: remove old files from circleci config https://github.com/checkstyle/checkstyle/commit/b3ddc70feafc7cbe317f5eddc7c51b4a606b8dcc;>b3ddc70 infra: remove Jenkins file as it is too stale https://github.com/checkstyle/checkstyle/commit/c4e4eecf5ed04515bfea52b2db745c0c10f1;>c4e4eec minor: fixed TeamCity violation Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.43...checkstyle-8.44;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (COMPRESS-542) Corrupt 7z allocates huge amount of SevenZEntries
[
https://issues.apache.org/jira/browse/COMPRESS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig resolved COMPRESS-542.
-
Fix Version/s: 1.21
Resolution: Fixed
And with current master your broken archives will be rejected even earlier as
we now hide recovering a certain type of broken archive introduced with
COMPRESS-497 behind a new option that is off by default.
I think we can close this as fixed in 1.21 by now.
> Corrupt 7z allocates huge amount of SevenZEntries
> -
>
> Key: COMPRESS-542
> URL: https://issues.apache.org/jira/browse/COMPRESS-542
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Robin Schimpf
>Priority: Major
> Fix For: 1.21
>
> Attachments:
> Reduced_memory_allocation_for_corrupted_7z_archives.patch,
> endheadercorrupted.7z, endheadercorrupted2.7z
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We ran into a problem where a 1.43GB corrupt 7z file tried to allocate about
> 138 million SevenZArchiveEntries which will use about 12GB of memory. Sadly
> I'm unable to share the file. If you have enough Memory available the
> following exception is thrown.
> {code:java}
> java.io.IOException: Start header corrupt and unable to guess end Header
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.tryToLocateEndHeader(SevenZFile.java:511)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readHeaders(SevenZFile.java:470)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:336)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:128)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:369)
> {code}
> 7z itself aborts really quick when I'm trying to list the content of the file.
> {code:java}
> 7z l "corrupt.7z"
> 7-Zip 18.01 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-01-28
> Scanning the drive for archives:
> 1 file, 1537752212 bytes (1467 MiB)
> Listing archive: corrupt.7z
> ERROR: corrupt.7z : corrupt.7z
> Open ERROR: Can not open the file as [7z] archive
> ERRORS:
> Is not archive
> Errors: 1
> {code}
> I hacked together the attached patch which will reduce the memory allocation
> to about 1GB. So lazy instantiation of the entries could be a good solution
> to the problem. Optimal would be to only create the entries if the headers
> could be parsed correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-542) Corrupt 7z allocates huge amount of SevenZEntries
[
https://issues.apache.org/jira/browse/COMPRESS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370314#comment-17370314
]
Stefan Bodewig commented on COMPRESS-542:
-
OK, my benchmarks
https://github.com/bodewig/commons-compress-benchmarks/wiki/COMPRESS-542 show
there is a certain performance hit if there are very many entries - then again
I believe this is acceptable as we need to do the checks anyway and it is
better to perform them before we allocate too much memory.
> Corrupt 7z allocates huge amount of SevenZEntries
> -
>
> Key: COMPRESS-542
> URL: https://issues.apache.org/jira/browse/COMPRESS-542
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Robin Schimpf
>Priority: Major
> Attachments:
> Reduced_memory_allocation_for_corrupted_7z_archives.patch,
> endheadercorrupted.7z, endheadercorrupted2.7z
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We ran into a problem where a 1.43GB corrupt 7z file tried to allocate about
> 138 million SevenZArchiveEntries which will use about 12GB of memory. Sadly
> I'm unable to share the file. If you have enough Memory available the
> following exception is thrown.
> {code:java}
> java.io.IOException: Start header corrupt and unable to guess end Header
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.tryToLocateEndHeader(SevenZFile.java:511)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readHeaders(SevenZFile.java:470)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:336)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:128)
> at
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:369)
> {code}
> 7z itself aborts really quick when I'm trying to list the content of the file.
> {code:java}
> 7z l "corrupt.7z"
> 7-Zip 18.01 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-01-28
> Scanning the drive for archives:
> 1 file, 1537752212 bytes (1467 MiB)
> Listing archive: corrupt.7z
> ERROR: corrupt.7z : corrupt.7z
> Open ERROR: Can not open the file as [7z] archive
> ERRORS:
> Is not archive
> Errors: 1
> {code}
> I hacked together the attached patch which will reduce the memory allocation
> to about 1GB. So lazy instantiation of the entries could be a good solution
> to the problem. Optimal would be to only create the entries if the headers
> could be parsed correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (POOL-395) Improve exception thrown in GenericObjectPool.borrowObject when pool is exhausted
[
https://issues.apache.org/jira/browse/POOL-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370235#comment-17370235
]
Gary D. Gregory edited comment on POOL-395 at 6/27/21, 2:52 PM:
In order to not overwhelm users with long messages, you enable statistics for
these exception messages with
{{BaseGenericObjectPool#setMessagesStatistics(true)}}.
was (Author: garydgregory):
In order to not overwhelm users with long messages, you enable statistics for
these exception messages with
{{BaseGenericObjectPool.setMessagesStatistics(true)}}.
> Improve exception thrown in GenericObjectPool.borrowObject when pool is
> exhausted
> -
>
> Key: POOL-395
> URL: https://issues.apache.org/jira/browse/POOL-395
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Arash Nikoo
>Priority: Minor
> Fix For: 2.11.0
>
>
> It would be really nice to include some additional information for the
> following exception:
> {code:java}
> org.apache.commons.pool2.impl.GenericObjectPool.borrowObject
> java.util.NoSuchElementException: Pool exhausted{code}
>
> I suggest showing the following parameters in the exception message:
> Min=x, Max=x, MinIdle=x, MaxIdle=x, Current=x
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (POOL-395) Improve exception thrown in GenericObjectPool.borrowObject when pool is exhausted
[
https://issues.apache.org/jira/browse/POOL-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370235#comment-17370235
]
Gary D. Gregory edited comment on POOL-395 at 6/27/21, 2:51 PM:
In order to not overwhelm users with long messages, you enable statistics for
these exception messages with
{{BaseGenericObjectPool.setMessagesStatistics(true)}}.
was (Author: garydgregory):
In order to not overwhelm users with long messages, you enable statistics for
these exception messages with
{{BaseGenericObjectPool.setMessagesStatistics(boolean)}}.
> Improve exception thrown in GenericObjectPool.borrowObject when pool is
> exhausted
> -
>
> Key: POOL-395
> URL: https://issues.apache.org/jira/browse/POOL-395
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Arash Nikoo
>Priority: Minor
> Fix For: 2.11.0
>
>
> It would be really nice to include some additional information for the
> following exception:
> {code:java}
> org.apache.commons.pool2.impl.GenericObjectPool.borrowObject
> java.util.NoSuchElementException: Pool exhausted{code}
>
> I suggest showing the following parameters in the exception message:
> Min=x, Max=x, MinIdle=x, MaxIdle=x, Current=x
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (POOL-395) Improve exception thrown in GenericObjectPool.borrowObject when pool is exhausted
[
https://issues.apache.org/jira/browse/POOL-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved POOL-395.
--
Fix Version/s: 2.11.0
Resolution: Fixed
> Improve exception thrown in GenericObjectPool.borrowObject when pool is
> exhausted
> -
>
> Key: POOL-395
> URL: https://issues.apache.org/jira/browse/POOL-395
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Arash Nikoo
>Priority: Minor
> Fix For: 2.11.0
>
>
> It would be really nice to include some additional information for the
> following exception:
> {code:java}
> org.apache.commons.pool2.impl.GenericObjectPool.borrowObject
> java.util.NoSuchElementException: Pool exhausted{code}
>
> I suggest showing the following parameters in the exception message:
> Min=x, Max=x, MinIdle=x, MaxIdle=x, Current=x
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (POOL-395) Improve exception thrown in GenericObjectPool.borrowObject when pool is exhausted
[
https://issues.apache.org/jira/browse/POOL-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370235#comment-17370235
]
Gary D. Gregory commented on POOL-395:
--
In order to not overwhelm users with long messages, you enable statistics for
these exception messages with
{{BaseGenericObjectPool.setMessagesStatistics(boolean)}}.
> Improve exception thrown in GenericObjectPool.borrowObject when pool is
> exhausted
> -
>
> Key: POOL-395
> URL: https://issues.apache.org/jira/browse/POOL-395
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Arash Nikoo
>Priority: Minor
>
> It would be really nice to include some additional information for the
> following exception:
> {code:java}
> org.apache.commons.pool2.impl.GenericObjectPool.borrowObject
> java.util.NoSuchElementException: Pool exhausted{code}
>
> I suggest showing the following parameters in the exception message:
> Min=x, Max=x, MinIdle=x, MaxIdle=x, Current=x
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
