[GitHub] [commons-imaging] gwlucastrig commented on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-949231787 This PR is now obsolete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig closed pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig closed pull request #173: URL: https://github.com/apache/commons-imaging/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-311. Resolution: Fixed > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h 50m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668753=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668753 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 02:07 Start Date: 22/Oct/21 02:07 Worklog Time Spent: 10m Work Description: kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949215527 Not a problem @gwlucastrig , it took me some time to get used to `git` too, and it has features that I am not familiar with :) merging now, thanks!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668753) Time Spent: 2h 40m (was: 2.5h) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h 40m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668754=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668754 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 02:07 Start Date: 22/Oct/21 02:07 Worklog Time Spent: 10m Work Description: kinow merged pull request #179: URL: https://github.com/apache/commons-imaging/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668754) Time Spent: 2h 50m (was: 2h 40m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h 50m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on pull request #179: IMAGING-311 revised support for multivariable rasters
kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949215527 Not a problem @gwlucastrig , it took me some time to get used to `git` too, and it has features that I am not familiar with :) merging now, thanks!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #179: IMAGING-311 revised support for multivariable rasters
kinow merged pull request #179: URL: https://github.com/apache/commons-imaging/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668751=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668751 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 02:01 Start Date: 22/Oct/21 02:01 Worklog Time Spent: 10m Work Description: gwlucastrig commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949208280 Thanks for fixing this. Sorry to have caused you extra work. I went over the changes and I think this PR is done. There were a few remaining whitespace differences that I might have fixed, but I don't want to risk making any more modifications to this PR. In answer to your questions about how I create a branch, my general approach is to follow the procedures described in the web article [The beginner's guide to contributing to a GitHub project](https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/). I've actually made some progress with git in that I think I almost understand what all the commands given in the article are supposed to do... Though I still don't think I could remember them without having the guide handy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668751) Time Spent: 2.5h (was: 2h 20m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2.5h > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig commented on pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949208280 Thanks for fixing this. Sorry to have caused you extra work. I went over the changes and I think this PR is done. There were a few remaining whitespace differences that I might have fixed, but I don't want to risk making any more modifications to this PR. In answer to your questions about how I create a branch, my general approach is to follow the procedures described in the web article [The beginner's guide to contributing to a GitHub project](https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/). I've actually made some progress with git in that I think I almost understand what all the commands given in the article are supposed to do... Though I still don't think I could remember them without having the guide handy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668721=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668721 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 00:46 Start Date: 22/Oct/21 00:46 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-948112471 [](https://coveralls.io/builds/43686138) Coverage increased (+0.1%) to 77.129% when pulling **819b5864ff06b8e4c7e021496d35953e7532f835 on gwlucastrig:ISSUE-311-1** into **f3bd32cee3325408021863b4615b83716f65972d on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668721) Time Spent: 2h 20m (was: 2h 10m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h 20m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] coveralls edited a comment on pull request #179: IMAGING-311 revised support for multivariable rasters
coveralls edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-948112471 [](https://coveralls.io/builds/43686138) Coverage increased (+0.1%) to 77.129% when pulling **819b5864ff06b8e4c7e021496d35953e7532f835 on gwlucastrig:ISSUE-311-1** into **f3bd32cee3325408021863b4615b83716f65972d on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668720=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668720 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 00:41 Start Date: 22/Oct/21 00:41 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-948112471 [](https://coveralls.io/builds/43686087) Coverage increased (+0.1%) to 77.129% when pulling **3819473f17cf780f930a5696d8c9172fb773b40d on gwlucastrig:ISSUE-311-1** into **f3bd32cee3325408021863b4615b83716f65972d on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668720) Time Spent: 2h 10m (was: 2h) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h 10m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] coveralls edited a comment on pull request #179: IMAGING-311 revised support for multivariable rasters
coveralls edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-948112471 [](https://coveralls.io/builds/43686087) Coverage increased (+0.1%) to 77.129% when pulling **3819473f17cf780f930a5696d8c9172fb773b40d on gwlucastrig:ISSUE-311-1** into **f3bd32cee3325408021863b4615b83716f65972d on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668719=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668719 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 00:40 Start Date: 22/Oct/21 00:40 Worklog Time Spent: 10m Work Description: kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949116229 Added `changes.xml` entry too. Ready to be merged once @gwlucastrig has reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668719) Time Spent: 2h (was: 1h 50m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 2h > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on pull request #179: IMAGING-311 revised support for multivariable rasters
kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949116229 Added `changes.xml` entry too. Ready to be merged once @gwlucastrig has reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668718=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668718 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 00:36 Start Date: 22/Oct/21 00:36 Worklog Time Spent: 10m Work Description: kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949112050 @gwlucastrig this branch was much easier to fix the conflicts. I just had to edit the files manually during the rebase, then `git push -f`. Can you check if my `git push -f` didn't mess with your previous work, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668718) Time Spent: 1h 50m (was: 1h 40m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 1h 50m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on pull request #179: IMAGING-311 revised support for multivariable rasters
kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949112050 @gwlucastrig this branch was much easier to fix the conflicts. I just had to edit the files manually during the rebase, then `git push -f`. Can you check if my `git push -f` didn't mess with your previous work, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668717 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 22/Oct/21 00:33 Start Date: 22/Oct/21 00:33 Worklog Time Spent: 10m Work Description: kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949109047 > did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) All your process above sounds correct to me. Here you were probably presented with a text editor, where you replaced the `pick` by either `fixup`, or left it as is? >The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code. Also, I can't figure out how to do the merge... Also, git basically destroyed some of my classes, inserting text into it that must be related to the merge. So now it won't even compile. @gwlucastrig when you started the new branch, did you create it off `master`? If you did something like: ```bash git checkout master git checkout -b ISSUE-311-1 ``` then it might be worth making sure that your `master` is up to date to the Apache `master` branch: ```bash git fetch --all git checkout master git rebase origin/master (origin or any other name you gave to the apache remote repo) OR git reset --hard origin/master ``` Then after that `git checkout -b ISSUE-311-1`. I'm syncing my repo to take a look and investigate what happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668717) Time Spent: 1h 40m (was: 1.5h) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 1h 40m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on pull request #179: IMAGING-311 revised support for multivariable rasters
kinow commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949109047 > did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) All your process above sounds correct to me. Here you were probably presented with a text editor, where you replaced the `pick` by either `fixup`, or left it as is? >The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code. Also, I can't figure out how to do the merge... Also, git basically destroyed some of my classes, inserting text into it that must be related to the merge. So now it won't even compile. @gwlucastrig when you started the new branch, did you create it off `master`? If you did something like: ```bash git checkout master git checkout -b ISSUE-311-1 ``` then it might be worth making sure that your `master` is up to date to the Apache `master` branch: ```bash git fetch --all git checkout master git rebase origin/master (origin or any other name you gave to the apache remote repo) OR git reset --hard origin/master ``` Then after that `git checkout -b ISSUE-311-1`. I'm syncing my repo to take a look and investigate what happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[
https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668716=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668716
]
ASF GitHub Bot logged work on IMAGING-311:
--
Author: ASF GitHub Bot
Created on: 22/Oct/21 00:28
Start Date: 22/Oct/21 00:28
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734131317
##
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
##
@@ -68,7 +68,11 @@
* available. When implementing extensions to this logic, developers are
* reminded that image processing requires the handling of literally millions
of
* pixels, so attention to performance is essential to a successful
+<<< HEAD
+ * implementation (please see the notes in {@link DataReaderStrips} for more
+===
Review comment:
This happens when conflicts are fixed, but accidentally the git comments
are left behind :grimacing:
##
File path:
src/test/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataTest.java
##
@@ -120,10 +120,13 @@ public void testGetValue2() {
}
}
+<<< HEAD
+===
Review comment:
:arrow_up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 668716)
Time Spent: 1.5h (was: 1h 20m)
> Read TIFFs with multiple floating-point samples
> ---
>
> Key: IMAGING-311
> URL: https://issues.apache.org/jira/browse/IMAGING-311
> Project: Commons Imaging
> Issue Type: New Feature
> Components: Format: TIFF
>Affects Versions: 1.0-alpha2
> Environment:
> [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251]
>Reporter: Gary Lucas
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Attachments: NBS_Example.jpg
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I propose to extend Commons Imaging to support reading TIFF files that
> contain floating-point formats that feature more than one sample. The
> ability to support floating-point samples was introduced in
> [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that
> implementation was limited to only those files that provided a single sample
> per raster cell (e.g. "a single sample per pixel"). The ability to read files
> with multiple samples per raster cell would extend the usefulness of the
> Commons Imaging API, particularly for geophysical applications.
> If anyone knows of good sources for test TIFF files that use this format,
> please let me know.
> *Background*
> In addition to conventional image data, TIFF files can provide floating-point
> numerical information. This feature is often used for geophysical data (in
> GeoTIFF files), but can also be applied to other uses. Although the existing
> implementation can support files which give a single value per raster cell,
> there are some products that carry multiple samples per cell. Examples
> include products that give both a measured value and a corresponding accuracy
> estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical
> products give vectors (gravitational potential, wind vectors, ocean currents,
> etc.).
> Changes would involve extensions to the classes in the TIFF datareader
> package as well as the TiffRasterData class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on a change in pull request #179: IMAGING-311 revised support for multivariable rasters
kinow commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734131317
##
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
##
@@ -68,7 +68,11 @@
* available. When implementing extensions to this logic, developers are
* reminded that image processing requires the handling of literally millions
of
* pixels, so attention to performance is essential to a successful
+<<< HEAD
+ * implementation (please see the notes in {@link DataReaderStrips} for more
+===
Review comment:
This happens when conflicts are fixed, but accidentally the git comments
are left behind :grimacing:
##
File path:
src/test/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataTest.java
##
@@ -120,10 +120,13 @@ public void testGetValue2() {
}
}
+<<< HEAD
+===
Review comment:
:arrow_up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668703=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668703 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 21/Oct/21 23:38 Start Date: 21/Oct/21 23:38 Worklog Time Spent: 10m Work Description: gwlucastrig edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949078115 Sigh. And it was going so well... My repository is broken again and I think I'm going to have to start from scratch, again... What I did was: went to same directory as yesterday (my current git working directory) made changes did a git add . did a git commit -m etc. did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) attempted a git push The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code.Also, I can't figure out how to do the merge... Also, git basically destroyed some of my classes, inserting text into it that must be related to the merge. So now it won't even compile. Was my mistake not pushing between the commit and the rebase attempt? So, I guess it is necessary delete this PR, yet again. I will try again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668703) Time Spent: 1h 20m (was: 1h 10m) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 1h 20m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig edited a comment on pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig edited a comment on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949078115 Sigh. And it was going so well... My repository is broken again and I think I'm going to have to start from scratch, again... What I did was: went to same directory as yesterday (my current git working directory) made changes did a git add . did a git commit -m etc. did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) attempted a git push The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code.Also, I can't figure out how to do the merge... Also, git basically destroyed some of my classes, inserting text into it that must be related to the merge. So now it won't even compile. Was my mistake not pushing between the commit and the rebase attempt? So, I guess it is necessary delete this PR, yet again. I will try again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668701=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668701 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 21/Oct/21 23:33 Start Date: 21/Oct/21 23:33 Worklog Time Spent: 10m Work Description: gwlucastrig commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949078115 Sigh. And it was going so well... My repository is broken again and I think I'm going to have to start from scratch, again... What I did was: went to same directory as yesterday (my current git working directory) made changes did a git add . did a git commit -m etc. did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) attempted a git push The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code.Also, I can't figure out how to do the merge... So, I guess it is necessary delete this PR, yet again. I will try again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668701) Time Spent: 1h 10m (was: 1h) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 1h 10m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig commented on pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig commented on pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#issuecomment-949078115 Sigh. And it was going so well... My repository is broken again and I think I'm going to have to start from scratch, again... What I did was: went to same directory as yesterday (my current git working directory) made changes did a git add . did a git commit -m etc. did a git rebase -i HEAD~2 to try to squash the commits (there were 2 commits then, there's 3 now) attempted a git push The push failed, telling me I had merge conflicts. Which I can accept as true, except I cannot see how that could possibly be the case since I did no other work on my code.Also, I can't figure out how to do the merge... So, I guess it is necessary delete this PR, yet again. I will try again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[
https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668684=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668684
]
ASF GitHub Bot logged work on IMAGING-311:
--
Author: ASF GitHub Bot
Created on: 21/Oct/21 23:01
Start Date: 21/Oct/21 23:01
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734100614
##
File path:
src/test/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataTest.java
##
@@ -84,6 +85,45 @@ public void testGetValue() {
}
}
+/**
+ * Test of setValue method, of class TiffRasterData.
+ */
+@Test
+public void testSetValue2() {
+final TiffRasterData instance = new TiffRasterDataFloat(width, height,
2);
+for (int y = 0; y < height; y++) {
+for (int x = 0; x < width; x++) {
+final int index = y * width + height;
+instance.setValue(x, y, 1, index);
+final int test = (int) instance.getValue(x, y, 1);
+assertEquals(index, test, "Set/get value test failed at (" + x
+ "," + y + ")");
+instance.setIntValue(x, y, 1, index);
+final int iTest = instance.getIntValue(x, y, 1);
+assertEquals(index, iTest, "Get/set value test failed at (" +
x + "," + y + ")");
+}
+}
+}
+
+/**
+ * Test of getValue method, of class TiffRasterData.
+ */
+@Test
+public void testGetValue2() {
+for (int y = 0; y < height; y++) {
+for (int x = 0; x < width; x++) {
+final int index = y * width + x;
+final int test = (int) raster.getValue(x, y, 0);
+assertEquals(index, test, "Get into source data test failed at
(" + x + "," + y + ")");
+final int iTest = raster.getIntValue(x, y, 0);
+assertEquals(index, iTest, "Get into source data test failed
at (" + x + "," + y + ")");
+}
+}
+}
+
+
+
+
+
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 668684)
Time Spent: 1h (was: 50m)
> Read TIFFs with multiple floating-point samples
> ---
>
> Key: IMAGING-311
> URL: https://issues.apache.org/jira/browse/IMAGING-311
> Project: Commons Imaging
> Issue Type: New Feature
> Components: Format: TIFF
>Affects Versions: 1.0-alpha2
> Environment:
> [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251]
>Reporter: Gary Lucas
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Attachments: NBS_Example.jpg
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I propose to extend Commons Imaging to support reading TIFF files that
> contain floating-point formats that feature more than one sample. The
> ability to support floating-point samples was introduced in
> [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that
> implementation was limited to only those files that provided a single sample
> per raster cell (e.g. "a single sample per pixel"). The ability to read files
> with multiple samples per raster cell would extend the usefulness of the
> Commons Imaging API, particularly for geophysical applications.
> If anyone knows of good sources for test TIFF files that use this format,
> please let me know.
> *Background*
> In addition to conventional image data, TIFF files can provide floating-point
> numerical information. This feature is often used for geophysical data (in
> GeoTIFF files), but can also be applied to other uses. Although the existing
> implementation can support files which give a single value per raster cell,
> there are some products that carry multiple samples per cell. Examples
> include products that give both a measured value and a corresponding accuracy
> estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical
> products give vectors (gravitational potential, wind vectors, ocean currents,
> etc.).
> Changes would involve extensions to the classes in the TIFF datareader
> package as well as the TiffRasterData class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734100614
##
File path:
src/test/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataTest.java
##
@@ -84,6 +85,45 @@ public void testGetValue() {
}
}
+/**
+ * Test of setValue method, of class TiffRasterData.
+ */
+@Test
+public void testSetValue2() {
+final TiffRasterData instance = new TiffRasterDataFloat(width, height,
2);
+for (int y = 0; y < height; y++) {
+for (int x = 0; x < width; x++) {
+final int index = y * width + height;
+instance.setValue(x, y, 1, index);
+final int test = (int) instance.getValue(x, y, 1);
+assertEquals(index, test, "Set/get value test failed at (" + x
+ "," + y + ")");
+instance.setIntValue(x, y, 1, index);
+final int iTest = instance.getIntValue(x, y, 1);
+assertEquals(index, iTest, "Get/set value test failed at (" +
x + "," + y + ")");
+}
+}
+}
+
+/**
+ * Test of getValue method, of class TiffRasterData.
+ */
+@Test
+public void testGetValue2() {
+for (int y = 0; y < height; y++) {
+for (int x = 0; x < width; x++) {
+final int index = y * width + x;
+final int test = (int) raster.getValue(x, y, 0);
+assertEquals(index, test, "Get into source data test failed at
(" + x + "," + y + ")");
+final int iTest = raster.getIntValue(x, y, 0);
+assertEquals(index, iTest, "Get into source data test failed
at (" + x + "," + y + ")");
+}
+}
+}
+
+
+
+
+
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[
https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668683
]
ASF GitHub Bot logged work on IMAGING-311:
--
Author: ASF GitHub Bot
Created on: 21/Oct/21 22:59
Start Date: 21/Oct/21 22:59
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734099977
##
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
##
@@ -382,53 +413,91 @@ protected void applyPredictorToBlock(final int width,
final int height, final in
final int height,
final int scanSize,
final byte[] bytes,
-final int predictor,
-final int bitsPerSample,
+final int bitsPerPixel,
final ByteOrder byteOrder)
throws ImageReadException {
+final int bitsPerSample = bitsPerPixel / samplesPerPixel;
final int bytesPerSample = bitsPerSample / 8;
-final int nBytes = bytesPerSample * scanSize * height;
-final int length = bytes.length < nBytes ? nBytes / scanSize : height;
-
-final int[] samples = new int[scanSize * height];
+final int bytesPerScan = scanSize * samplesPerPixel * bytesPerSample;
+final int nBytes = bytesPerScan * height;
+final int length = bytes.length < nBytes ? nBytes / bytesPerScan :
height;
+final int[] samples = new int[scanSize * samplesPerPixel * height];
// floating-point differencing is indicated by a predictor value of 3.
if (predictor ==
TiffTagConstants.PREDICTOR_VALUE_FLOATING_POINT_DIFFERENCING) {
// at this time, this class supports the 32-bit format. The
// main reason for this is that we have not located sample data
// that can be used for testing and analysis.
-if (bitsPerSample != 32) {
+if (bitsPerPixel / samplesPerPixel != 32) {
throw new ImageReadException(
"Imaging does not yet support floating-point data"
+ " with predictor type 3 for "
-+ bitsPerSample + " bits per sample");
++ bitsPerPixel + " bits per sample");
}
-final int bytesInRow = scanSize * 4;
-for (int i = 0; i < length; i++) {
-final int aOffset = i * bytesInRow;
-final int bOffset = aOffset + scanSize;
-final int cOffset = bOffset + scanSize;
-final int dOffset = cOffset + scanSize;
-// in this loop, the source bytes give delta values.
-// we adjust them to give true values. This operation is
-// done on a row-by-row basis.
-for (int j = 1; j < bytesInRow; j++) {
-bytes[aOffset + j] += bytes[aOffset + j - 1];
+
+if (planarConfiguration == TiffPlanarConfiguration.CHUNKY) {
+final int bytesInRow = scanSize * 4 * samplesPerPixel;
+for (int i = 0; i < length; i++) {
+final int aOffset = i * bytesInRow;
+final int bOffset = aOffset + scanSize * samplesPerPixel;
+final int cOffset = bOffset + scanSize * samplesPerPixel;
+final int dOffset = cOffset + scanSize * samplesPerPixel;
+// in this loop, the source bytes give delta values.
+// we adjust them to give true values. This operation is
+// done on a row-by-row basis.
+for (int j = 1; j < bytesInRow; j++) {
+bytes[aOffset + j] += bytes[aOffset + j - 1];
+}
+// pack the bytes into the integer bit-equivalent of
+// floating point values
+int index = i * scanSize;
+for (int j = 0; j < width * samplesPerPixel; j++) {
+final int a = bytes[aOffset + j];
+final int b = bytes[bOffset + j];
+final int c = bytes[cOffset + j];
+final int d = bytes[dOffset + j];
+// Pack the 4 byte components into a single integer
+// in the byte order used by the TIFF standard
+samples[index++] = ((a & 0xff) << 24)
+| ((b & 0xff) << 16)
+| ((c & 0xff) << 8)
+| (d & 0xff);
+}
}
-// pack the bytes into the integer bit-equivalent of
-// floating point values
-int index = i * scanSize;
-for (int j = 0;
[jira] [Work logged] (IMAGING-311) Read TIFFs with multiple floating-point samples
[ https://issues.apache.org/jira/browse/IMAGING-311?focusedWorklogId=668682=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668682 ] ASF GitHub Bot logged work on IMAGING-311: -- Author: ASF GitHub Bot Created on: 21/Oct/21 22:59 Start Date: 21/Oct/21 22:59 Worklog Time Spent: 10m Work Description: gwlucastrig commented on a change in pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734099804 ## File path: src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java ## @@ -62,15 +63,15 @@ * Unfortunately, the TIFF floating-point format allows for a lot of different * variations. At this time, only the most widely used of these are supported. * When this code was written, only a small set of test data products were - * available. Thus it is likely that developers will wish to extend the - * range of floating-point data that can be processed as - * additional test data become available. When implementing extensions to this - * logic, developers are reminded that image processing requires - * the handling of literally millions of pixels, so attention to performance - * is essential to a successful implementation (please see the notes in - * DataReaderStrips.java for more information). + * available. Thus it is likely that developers will wish to extend the range of + * floating-point data that can be processed as additional test data become + * available. When implementing extensions to this logic, developers are + * reminded that image processing requires the handling of literally millions of + * pixels, so attention to performance is essential to a successful + * implementation (please see the notes in DataReaderStrips.java for more Review comment: Wow. That link annotation actually worked. I've got a new favorite technique -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668682) Time Spent: 40m (was: 0.5h) > Read TIFFs with multiple floating-point samples > --- > > Key: IMAGING-311 > URL: https://issues.apache.org/jira/browse/IMAGING-311 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha2 > Environment: > [IMAGING-251|https://issues.apache.org/jira/browse/IMAGING-251] >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Major > Fix For: 1.0-alpha3 > > Attachments: NBS_Example.jpg > > Time Spent: 40m > Remaining Estimate: 0h > > I propose to extend Commons Imaging to support reading TIFF files that > contain floating-point formats that feature more than one sample. The > ability to support floating-point samples was introduced in > [ISSUE-251|https://issues.apache.org/jira/browse/IMAGING-251]. But that > implementation was limited to only those files that provided a single sample > per raster cell (e.g. "a single sample per pixel"). The ability to read files > with multiple samples per raster cell would extend the usefulness of the > Commons Imaging API, particularly for geophysical applications. > If anyone knows of good sources for test TIFF files that use this format, > please let me know. > *Background* > In addition to conventional image data, TIFF files can provide floating-point > numerical information. This feature is often used for geophysical data (in > GeoTIFF files), but can also be applied to other uses. Although the existing > implementation can support files which give a single value per raster cell, > there are some products that carry multiple samples per cell. Examples > include products that give both a measured value and a corresponding accuracy > estimate (i.e. 245.6 meters plus or minus 0.5 meters). Some geophysical > products give vectors (gravitational potential, wind vectors, ocean currents, > etc.). > Changes would involve extensions to the classes in the TIFF datareader > package as well as the TiffRasterData class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig commented on a change in pull request #179:
URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734099977
##
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
##
@@ -382,53 +413,91 @@ protected void applyPredictorToBlock(final int width,
final int height, final in
final int height,
final int scanSize,
final byte[] bytes,
-final int predictor,
-final int bitsPerSample,
+final int bitsPerPixel,
final ByteOrder byteOrder)
throws ImageReadException {
+final int bitsPerSample = bitsPerPixel / samplesPerPixel;
final int bytesPerSample = bitsPerSample / 8;
-final int nBytes = bytesPerSample * scanSize * height;
-final int length = bytes.length < nBytes ? nBytes / scanSize : height;
-
-final int[] samples = new int[scanSize * height];
+final int bytesPerScan = scanSize * samplesPerPixel * bytesPerSample;
+final int nBytes = bytesPerScan * height;
+final int length = bytes.length < nBytes ? nBytes / bytesPerScan :
height;
+final int[] samples = new int[scanSize * samplesPerPixel * height];
// floating-point differencing is indicated by a predictor value of 3.
if (predictor ==
TiffTagConstants.PREDICTOR_VALUE_FLOATING_POINT_DIFFERENCING) {
// at this time, this class supports the 32-bit format. The
// main reason for this is that we have not located sample data
// that can be used for testing and analysis.
-if (bitsPerSample != 32) {
+if (bitsPerPixel / samplesPerPixel != 32) {
throw new ImageReadException(
"Imaging does not yet support floating-point data"
+ " with predictor type 3 for "
-+ bitsPerSample + " bits per sample");
++ bitsPerPixel + " bits per sample");
}
-final int bytesInRow = scanSize * 4;
-for (int i = 0; i < length; i++) {
-final int aOffset = i * bytesInRow;
-final int bOffset = aOffset + scanSize;
-final int cOffset = bOffset + scanSize;
-final int dOffset = cOffset + scanSize;
-// in this loop, the source bytes give delta values.
-// we adjust them to give true values. This operation is
-// done on a row-by-row basis.
-for (int j = 1; j < bytesInRow; j++) {
-bytes[aOffset + j] += bytes[aOffset + j - 1];
+
+if (planarConfiguration == TiffPlanarConfiguration.CHUNKY) {
+final int bytesInRow = scanSize * 4 * samplesPerPixel;
+for (int i = 0; i < length; i++) {
+final int aOffset = i * bytesInRow;
+final int bOffset = aOffset + scanSize * samplesPerPixel;
+final int cOffset = bOffset + scanSize * samplesPerPixel;
+final int dOffset = cOffset + scanSize * samplesPerPixel;
+// in this loop, the source bytes give delta values.
+// we adjust them to give true values. This operation is
+// done on a row-by-row basis.
+for (int j = 1; j < bytesInRow; j++) {
+bytes[aOffset + j] += bytes[aOffset + j - 1];
+}
+// pack the bytes into the integer bit-equivalent of
+// floating point values
+int index = i * scanSize;
+for (int j = 0; j < width * samplesPerPixel; j++) {
+final int a = bytes[aOffset + j];
+final int b = bytes[bOffset + j];
+final int c = bytes[cOffset + j];
+final int d = bytes[dOffset + j];
+// Pack the 4 byte components into a single integer
+// in the byte order used by the TIFF standard
+samples[index++] = ((a & 0xff) << 24)
+| ((b & 0xff) << 16)
+| ((c & 0xff) << 8)
+| (d & 0xff);
+}
}
-// pack the bytes into the integer bit-equivalent of
-// floating point values
-int index = i * scanSize;
-for (int j = 0; j < width; j++) {
-final int a = bytes[aOffset + j];
-final int b = bytes[bOffset + j];
-final int c = bytes[cOffset + j];
-final int d = bytes[dOffset + j];
-// Pack the 4 byte components into a single integer
-// in the byte order used by the TIFF standard
-samples[index++] = ((a &
[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #179: IMAGING-311 revised support for multivariable rasters
gwlucastrig commented on a change in pull request #179: URL: https://github.com/apache/commons-imaging/pull/179#discussion_r734099804 ## File path: src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java ## @@ -62,15 +63,15 @@ * Unfortunately, the TIFF floating-point format allows for a lot of different * variations. At this time, only the most widely used of these are supported. * When this code was written, only a small set of test data products were - * available. Thus it is likely that developers will wish to extend the - * range of floating-point data that can be processed as - * additional test data become available. When implementing extensions to this - * logic, developers are reminded that image processing requires - * the handling of literally millions of pixels, so attention to performance - * is essential to a successful implementation (please see the notes in - * DataReaderStrips.java for more information). + * available. Thus it is likely that developers will wish to extend the range of + * floating-point data that can be processed as additional test data become + * available. When implementing extensions to this logic, developers are + * reminded that image processing requires the handling of literally millions of + * pixels, so attention to performance is essential to a successful + * implementation (please see the notes in DataReaderStrips.java for more Review comment: Wow. That link annotation actually worked. I've got a new favorite technique -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r merged pull request #187: Minor Changes:
darkma773r merged pull request #187: URL: https://github.com/apache/commons-geometry/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow merged pull request #80: Bump spotbugs from 4.4.1 to 4.4.2
kinow merged pull request #80: URL: https://github.com/apache/commons-release-plugin/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #278: Bump spotbugs-maven-plugin from 4.4.2.1 to 4.4.2.2
kinow merged pull request #278: URL: https://github.com/apache/commons-text/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls commented on pull request #278: Bump spotbugs-maven-plugin from 4.4.2.1 to 4.4.2.2
coveralls commented on pull request #278: URL: https://github.com/apache/commons-text/pull/278#issuecomment-949025496 [](https://coveralls.io/builds/43683277) Coverage remained the same at 97.865% when pulling **a5db9d1e9b1765e252b2b72e54e18896b02316fd on dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.4.2.2** into **4cebe88432c69b2a3f97515b16de0aa83fb0b4e5 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #278: Bump spotbugs-maven-plugin from 4.4.2.1 to 4.4.2.2
dependabot[bot] opened a new pull request #278: URL: https://github.com/apache/commons-text/pull/278 Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.4.2.1 to 4.4.2.2. Release notes Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's releases. Spotbugs-maven-plugin 4.4.2.2 Use new base-parent pom with removal of undocumented maven url attributes that cause issues for users of older jfrog artifactory installations. Commits https://github.com/spotbugs/spotbugs-maven-plugin/commit/a00e29d56997b9f4247748355a549e837c304629;>a00e29d [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.2 https://github.com/spotbugs/spotbugs-maven-plugin/commit/8c16d9704f00193c736d385b599496b64bb86880;>8c16d97 [pom] Update base parent without maven url attributes that break older artifa... https://github.com/spotbugs/spotbugs-maven-plugin/commit/7e4d513d8b6605dbdcd6edf7da8c05a34017654d;>7e4d513 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/366;>#366 from spotbugs/dependabot/maven/org.apache.ant-ant-1.1... https://github.com/spotbugs/spotbugs-maven-plugin/commit/cdcecc47ac78d4efa1f0beedc139e11b45ca4168;>cdcecc4 Bump ant from 1.10.11 to 1.10.12 https://github.com/spotbugs/spotbugs-maven-plugin/commit/2b57e82ca7c5eadcde1f4479436ef53a1317f685;>2b57e82 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.4.2.1...spotbugs-maven-plugin-4.4.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] coveralls commented on pull request #141: Avoid redundant operations:
coveralls commented on pull request #141: URL: https://github.com/apache/commons-crypto/pull/141#issuecomment-948956482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] arturobernalg opened a new pull request #141: Avoid redundant operations:
arturobernalg opened a new pull request #141: URL: https://github.com/apache/commons-crypto/pull/141 * Avoid redundant toString. * Avoid redundant initializer. * Make final var. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #124: Bump spotbugs-maven-plugin from 4.4.2.1 to 4.4.2.2
coveralls commented on pull request #124: URL: https://github.com/apache/commons-fileupload/pull/124#issuecomment-948884243 [](https://coveralls.io/builds/43678338) Coverage remained the same at 77.585% when pulling **a763ac3c5eafcabeb4f6e8ea12f47d68324baca1 on dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.4.2.2** into **55f485d8436578a3f0b89a753043311e93b3849a on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #124: Bump spotbugs-maven-plugin from 4.4.2.1 to 4.4.2.2
dependabot[bot] opened a new pull request #124: URL: https://github.com/apache/commons-fileupload/pull/124 Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.4.2.1 to 4.4.2.2. Release notes Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's releases. Spotbugs-maven-plugin 4.4.2.2 Use new base-parent pom with removal of undocumented maven url attributes that cause issues for users of older jfrog artifactory installations. Commits https://github.com/spotbugs/spotbugs-maven-plugin/commit/a00e29d56997b9f4247748355a549e837c304629;>a00e29d [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.2 https://github.com/spotbugs/spotbugs-maven-plugin/commit/8c16d9704f00193c736d385b599496b64bb86880;>8c16d97 [pom] Update base parent without maven url attributes that break older artifa... https://github.com/spotbugs/spotbugs-maven-plugin/commit/7e4d513d8b6605dbdcd6edf7da8c05a34017654d;>7e4d513 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/366;>#366 from spotbugs/dependabot/maven/org.apache.ant-ant-1.1... https://github.com/spotbugs/spotbugs-maven-plugin/commit/cdcecc47ac78d4efa1f0beedc139e11b45ca4168;>cdcecc4 Bump ant from 1.10.11 to 1.10.12 https://github.com/spotbugs/spotbugs-maven-plugin/commit/2b57e82ca7c5eadcde1f4479436ef53a1317f685;>2b57e82 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.4.2.1...spotbugs-maven-plugin-4.4.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CLI-287) HelpFormatter doesn't display header consisting of only whitespaces
[ https://issues.apache.org/jira/browse/CLI-287?focusedWorklogId=668569=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668569 ] ASF GitHub Bot logged work on CLI-287: -- Author: ASF GitHub Bot Created on: 21/Oct/21 17:44 Start Date: 21/Oct/21 17:44 Worklog Time Spent: 10m Work Description: MrQubo commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-948859179 @garydgregory I've fixed the tests, these new tests are more implementation-agnostic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 668569) Time Spent: 50m (was: 40m) > HelpFormatter doesn't display header consisting of only whitespaces > --- > > Key: CLI-287 > URL: https://issues.apache.org/jira/browse/CLI-287 > Project: Commons CLI > Issue Type: Bug > Components: Help formatter >Affects Versions: 1.0, 1.4 >Reporter: Jakub Nowak >Priority: Trivial > Labels: easyfix > Time Spent: 50m > Remaining Estimate: 0h > > If header or footer passed to HelpFormatter::printHelp consists of only > whitespaces it is not displayed. > It prevents users from adding additional newlines. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-cli] MrQubo commented on pull request #26: [CLI-287] Allow whitespace-only header and footer
MrQubo commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-948859179 @garydgregory I've fixed the tests, these new tests are more implementation-agnostic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] garydgregory merged pull request #135: Minor changes
garydgregory merged pull request #135: URL: https://github.com/apache/commons-crypto/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] commented on pull request #820: Bump spotbugs-maven-plugin from 4.4.1 to 4.4.2.1
dependabot[bot] commented on pull request #820: URL: https://github.com/apache/commons-lang/pull/820#issuecomment-948717699 Superseded by #822. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] closed pull request #820: Bump spotbugs-maven-plugin from 4.4.1 to 4.4.2.1
dependabot[bot] closed pull request #820: URL: https://github.com/apache/commons-lang/pull/820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] opened a new pull request #822: Bump spotbugs-maven-plugin from 4.4.1 to 4.4.2.2
dependabot[bot] opened a new pull request #822: URL: https://github.com/apache/commons-lang/pull/822 Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.4.1 to 4.4.2.2. Release notes Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's releases. Spotbugs-maven-plugin 4.4.2.2 Use new base-parent pom with removal of undocumented maven url attributes that cause issues for users of older jfrog artifactory installations. Spotbugs-maven-plugin 4.4.2.1 Release Reworked version string to account for any patches we need to make to plugin that would otherwise case a diverge from spotbugs or require us to wait. This is similar to how other plugins approach this such as lombok. The first 3 positions are reserved for the alignment with spotbugs. The last position is for our patch revision level. Normally this would be '0' but given we released 4.4.2 already, it made sense to denote '1' so that it was clear there was a difference. This patch release addresses issues with resolution of the maven dependencies that resulted in a few regression libraries that had vulnerabilities. This patch further changed lowest maven from 3.2.5 to 3.3.9 but reality is that even 3.3.9 likely doesn't work. Since all maven before 3.8.1 are vulnerable, most should be there. If not, let us know. Future releases will raise that revision number up. Spotbugs-maven-plugin 4.4.2 Release Added support for spotbugs 4.4.2 Now running github actions on jdk 17 and 18-ea to show this works there Now running against maven 3.8.3 Updated a number of plugins and dependencies Commits https://github.com/spotbugs/spotbugs-maven-plugin/commit/a00e29d56997b9f4247748355a549e837c304629;>a00e29d [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.2 https://github.com/spotbugs/spotbugs-maven-plugin/commit/8c16d9704f00193c736d385b599496b64bb86880;>8c16d97 [pom] Update base parent without maven url attributes that break older artifa... https://github.com/spotbugs/spotbugs-maven-plugin/commit/7e4d513d8b6605dbdcd6edf7da8c05a34017654d;>7e4d513 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/366;>#366 from spotbugs/dependabot/maven/org.apache.ant-ant-1.1... https://github.com/spotbugs/spotbugs-maven-plugin/commit/cdcecc47ac78d4efa1f0beedc139e11b45ca4168;>cdcecc4 Bump ant from 1.10.11 to 1.10.12 https://github.com/spotbugs/spotbugs-maven-plugin/commit/2b57e82ca7c5eadcde1f4479436ef53a1317f685;>2b57e82 [maven-release-plugin] prepare for next development iteration https://github.com/spotbugs/spotbugs-maven-plugin/commit/20bbdd5e9630f423d9943a8ef46879c4b9a0efac;>20bbdd5 [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.1 https://github.com/spotbugs/spotbugs-maven-plugin/commit/ea259b0fe3334a6ddc297218c710ef258728e462;>ea259b0 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/365;>#365 from hazendaz/spotbugs https://github.com/spotbugs/spotbugs-maven-plugin/commit/9e2368119da25f2edcbd820bb25f18c716ddd5b5;>9e23681 [pom] Formatting https://github.com/spotbugs/spotbugs-maven-plugin/commit/bc67d6b48ef142b108395728ccda0e1b9588f057;>bc67d6b [pom] Override maven shared utils to 3.3.4 https://github.com/spotbugs/spotbugs-maven-plugin/commit/06a2e8b83a5649c3c3d087d66f541895e0fd5414;>06a2e8b [pom] Override commons lang2 to 2.6 Additional commits viewable in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.4.1...spotbugs-maven-plugin-4.4.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it.
[GitHub] [commons-csv] garydgregory merged pull request #189: Bump commons.pmd-impl.version from 6.37.0 to 6.39.0
garydgregory merged pull request #189: URL: https://github.com/apache/commons-csv/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #190: Bump checkstyle from 9.0 to 9.0.1
garydgregory merged pull request #190: URL: https://github.com/apache/commons-csv/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] garydgregory merged pull request #140: Bump maven-pmd-plugin from 3.14.0 to 3.15.0
garydgregory merged pull request #140: URL: https://github.com/apache/commons-crypto/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #190: Bump checkstyle from 9.0 to 9.0.1
coveralls commented on pull request #190: URL: https://github.com/apache/commons-csv/pull/190#issuecomment-948574302 [](https://coveralls.io/builds/43668344) Coverage remained the same at 98.323% when pulling **2364faeed8c2f76189aad3668b9b2a041142e86e on dependabot/maven/com.puppycrawl.tools-checkstyle-9.0.1** into **3fff72e495673933483df6ee45b5a562a45e5221 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] dependabot[bot] opened a new pull request #190: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] opened a new pull request #190: URL: https://github.com/apache/commons-csv/pull/190 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.0 to 9.0.1. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-9.0.1 https://checkstyle.org/releasenotes.html#Release_9.0.1;>https://checkstyle.org/releasenotes.html#Release_9.0.1 Commits https://github.com/checkstyle/checkstyle/commit/32050d65beb5851d5b0cf58a536a9df1261403b2;>32050d6 [maven-release-plugin] prepare release checkstyle-9.0.1 https://github.com/checkstyle/checkstyle/commit/ce18437f284a26d3ed50458adfa51df0d7fe625b;>ce18437 doc: release notes 9.0.1 https://github.com/checkstyle/checkstyle/commit/77e4a32a8dd31f24522bc36f114fb89e3ca39ee8;>77e4a32 config: update to 9.0.1-SNAPSHOT https://github.com/checkstyle/checkstyle/commit/55b4cbe3c4da3826b8a39f7653cd34eff8b8fc47;>55b4cbe Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9396;>#9396: Add example of AST for TokenTypes.AT https://github.com/checkstyle/checkstyle/commit/c83d823fa9791e6ac14fbc15e97f06671254f6e0;>c83d823 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10057;>#10057: add sections with additional checks to main page https://github.com/checkstyle/checkstyle/commit/9fcd1e0a9663846ccb8336d7df6035ea26d5846a;>9fcd1e0 Pull https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10827;>#10827: changes InlineConfigParser to respect fully qualified name https://github.com/checkstyle/checkstyle/commit/9c1297efd1d2972fad7c0df823f236c19e144954;>9c1297e Pull https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10827;>#10827: reworks JavadocMetadataScrapperTest to make more sense https://github.com/checkstyle/checkstyle/commit/0da7491600e2d8c1a164b9a58d4ac12725149e88;>0da7491 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10828;>#10828: Fix up messages - mojibake, lone apostrophes and accidental apo... https://github.com/checkstyle/checkstyle/commit/c6c340c166aa8f69d3fe6a43ef245df7f93e2adf;>c6c340c infra: turn off curl's verification of the certificate for test-spelling-unkn... https://github.com/checkstyle/checkstyle/commit/e401fb5260616da07e33070d0be2182b22b4c83d;>e401fb5 dependency: bump pmd.version from 6.38.0 to 6.39.0 Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.0...checkstyle-9.0.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] coveralls commented on pull request #140: Bump maven-pmd-plugin from 3.14.0 to 3.15.0
coveralls commented on pull request #140: URL: https://github.com/apache/commons-crypto/pull/140#issuecomment-948533866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] dependabot[bot] opened a new pull request #140: Bump maven-pmd-plugin from 3.14.0 to 3.15.0
dependabot[bot] opened a new pull request #140: URL: https://github.com/apache/commons-crypto/pull/140 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.14.0 to 3.15.0. Commits https://github.com/apache/maven-pmd-plugin/commit/7a738884d38c3f7baee4d493940bdd063c06ca80;>7a73888 [maven-release-plugin] prepare release maven-pmd-plugin-3.15.0 https://github.com/apache/maven-pmd-plugin/commit/3ffd4d3762028b1b0a8f714297a21de37d0c5649;>3ffd4d3 [MPMD-308] Set Maven 3.1.0 as minimum version https://github.com/apache/maven-pmd-plugin/commit/5ae53f135b46102e7b749c834173cdc97678f834;>5ae53f1 [MPMD-283] Create a real aggregate goal https://github.com/apache/maven-pmd-plugin/commit/995edef0572010eb126a1e6a0b2982b60ad01d1f;>995edef (doc) Add example Using a different ruleset for tests https://github.com/apache/maven-pmd-plugin/commit/45a5e545ba3f53ccbe61dc5971ee5b623fa75cf7;>45a5e54 [MPMD-322] Display when PMD/CPD is skipped https://github.com/apache/maven-pmd-plugin/commit/b8fc018ef11b72bfa1306f0a85eea7370902079e;>b8fc018 [MPMD-321] Display PMD version that is being used also for pmd:pmd and https://github.com/apache/maven-pmd-plugin/commit/251f954faf6201efc4bed6396026fd0a59b8c5d1;>251f954 [MPMD-320] Correctly decode filename paths in classpath for toolchain https://github.com/apache/maven-pmd-plugin/commit/38701dab48b91e9a44611b7cf5b586a7778a6439;>38701da [MPMD-312] The rule BooleanInstantiation is deprecated https://github.com/apache/maven-pmd-plugin/commit/bf682a7db1d183662974885774819226c38222e8;>bf682a7 [MPMD-312] Upgrade to PMD 6.38.0 https://github.com/apache/maven-pmd-plugin/commit/89ce9fe4151dbf891ae677a21d019322fd90017e;>89ce9fe [MPMD-312] Upgrade to PMD 6.37.0 Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.14.0...maven-pmd-plugin-3.15.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CLI-310) Purge release version 20040117.000000 from Maven Central
[
https://issues.apache.org/jira/browse/CLI-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432390#comment-17432390
]
Markus Spann commented on CLI-310:
--
{quote}[~b.eckenfels], I highly favorize an issue with OSSRH.
{quote}
Do we have a volunteer to do that? :)
I do not have an account with OSS Repository Hosting.
> Purge release version 20040117.00 from Maven Central
>
>
> Key: CLI-310
> URL: https://issues.apache.org/jira/browse/CLI-310
> Project: Commons CLI
> Issue Type: Task
>Reporter: Markus Spann
>Priority: Minor
>
> How did commons-cli "release version" 20040117.00 make it into Maven
> Central?
> It's been there for as long as I can remember.
> It would not bother any of us if this version did not always show up as the
> most recent/latest/bleeding edge release. Even though it's ancient and noone
> would want to use it of course.
> This effect is due to this version not following the commons-cli version
> scheme and due to the way Maven sorts version strings.
> A small use case to illustrate:
>
> {code:java}
> mvn versions:display-dependency-updates
> {code}
>
> {code:java}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] commons-cli:commons-cli ... 1.4 -> 20040117.00
> {code}
> I understand that purging release artifacts from Central may not be simple.
> Yet it would be so much appreciated if someone with the corresponding
> know-how and access could take care of it. Thanks a million!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-release-plugin] coveralls commented on pull request #80: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #80: URL: https://github.com/apache/commons-release-plugin/pull/80#issuecomment-948448535 [](https://coveralls.io/builds/43664826) Coverage remained the same at 75.0% when pulling **3fa3d38eb993c6e3f3f56f3763910c05296b4721 on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **7e22583dd0d28a1babfcd8df2cedb779f1aaa5ca on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NUMBERS-172) Update the Erf function to use the Boost rational function approximtion
[
https://issues.apache.org/jira/browse/NUMBERS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved NUMBERS-172.
--
Fix Version/s: 1.1
Resolution: Implemented
Added in commit:
a0e56e1fd241d9fd77973c137c0608dc12ff44f0
> Update the Erf function to use the Boost rational function approximtion
> ---
>
> Key: NUMBERS-172
> URL: https://issues.apache.org/jira/browse/NUMBERS-172
> Project: Commons Numbers
> Issue Type: Improvement
> Components: gamma
>Affects Versions: 1.0
>Reporter: Alex Herbert
>Priority: Major
> Fix For: 1.1
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The error function (erf) and complementary error function (erfc) are
> implemented using the continued fraction evaluation performed in the
> regularized gamma P and Q implementation. This is a generic function called
> with a fixed argument of 0.5:
> {noformat}
> erf(x) = gammap(0.5, x*x)
> erfc(x) = gammaq(0.5, x*x)
> {noformat}
> These functions have an implementation in the Boost c++ library using a
> rational function approximation.
> NUMBERS-171 ported the inverse erf functions from Boost with an improvement
> in accuracy and speed. Investigate the use of the corresponding forward erf
> and erfc functions from Boost as replacements for the use of the regularized
> gamma function to evaluate the error function.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (NUMBERS-172) Update the Erf function to use the Boost rational function approximtion
[
https://issues.apache.org/jira/browse/NUMBERS-172?focusedWorklogId=668158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668158
]
ASF GitHub Bot logged work on NUMBERS-172:
--
Author: ASF GitHub Bot
Created on: 21/Oct/21 08:41
Start Date: 21/Oct/21 08:41
Worklog Time Spent: 10m
Work Description: asfgit merged pull request #108:
URL: https://github.com/apache/commons-numbers/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 668158)
Time Spent: 1h (was: 50m)
> Update the Erf function to use the Boost rational function approximtion
> ---
>
> Key: NUMBERS-172
> URL: https://issues.apache.org/jira/browse/NUMBERS-172
> Project: Commons Numbers
> Issue Type: Improvement
> Components: gamma
>Affects Versions: 1.0
>Reporter: Alex Herbert
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The error function (erf) and complementary error function (erfc) are
> implemented using the continued fraction evaluation performed in the
> regularized gamma P and Q implementation. This is a generic function called
> with a fixed argument of 0.5:
> {noformat}
> erf(x) = gammap(0.5, x*x)
> erfc(x) = gammaq(0.5, x*x)
> {noformat}
> These functions have an implementation in the Boost c++ library using a
> rational function approximation.
> NUMBERS-171 ported the inverse erf functions from Boost with an improvement
> in accuracy and speed. Investigate the use of the corresponding forward erf
> and erfc functions from Boost as replacements for the use of the regularized
> gamma function to evaluate the error function.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-numbers] asfgit merged pull request #108: NUMBERS-172: Use Boost Error function implementation
asfgit merged pull request #108: URL: https://github.com/apache/commons-numbers/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] opened a new pull request #80: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] opened a new pull request #80: URL: https://github.com/apache/commons-release-plugin/pull/80 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 Changelog Sourced from https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md;>spotbugs's changelog.
[jira] [Commented] (CLI-310) Purge release version 20040117.000000 from Maven Central
[
https://issues.apache.org/jira/browse/CLI-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432271#comment-17432271
]
Michael Osipov commented on CLI-310:
[~b.eckenfels], I highly favorize an issue with OSSRH.
> Purge release version 20040117.00 from Maven Central
>
>
> Key: CLI-310
> URL: https://issues.apache.org/jira/browse/CLI-310
> Project: Commons CLI
> Issue Type: Task
>Reporter: Markus Spann
>Priority: Minor
>
> How did commons-cli "release version" 20040117.00 make it into Maven
> Central?
> It's been there for as long as I can remember.
> It would not bother any of us if this version did not always show up as the
> most recent/latest/bleeding edge release. Even though it's ancient and noone
> would want to use it of course.
> This effect is due to this version not following the commons-cli version
> scheme and due to the way Maven sorts version strings.
> A small use case to illustrate:
>
> {code:java}
> mvn versions:display-dependency-updates
> {code}
>
> {code:java}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] commons-cli:commons-cli ... 1.4 -> 20040117.00
> {code}
> I understand that purging release artifacts from Central may not be simple.
> Yet it would be so much appreciated if someone with the corresponding
> know-how and access could take care of it. Thanks a million!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] waso opened a new pull request #74: added more unit tests
waso opened a new pull request #74: URL: https://github.com/apache/commons-cli/pull/74 Hi @garydgregory I have added more unit tests to recently update Option.builder(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CLI-310) Purge release version 20040117.000000 from Maven Central
[
https://issues.apache.org/jira/browse/CLI-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432266#comment-17432266
]
Bernd Eckenfels commented on CLI-310:
-
Normally I would agree that central can’t be modified, but in this case there
is no signature present, so it’s really risky that it gets preferred by maven
resolver. Should we raise a sonatype-ops issue and ask for their oppinion.
Having said that.. should maven have a device for centrally managed deny-lists?
> Purge release version 20040117.00 from Maven Central
>
>
> Key: CLI-310
> URL: https://issues.apache.org/jira/browse/CLI-310
> Project: Commons CLI
> Issue Type: Task
>Reporter: Markus Spann
>Priority: Minor
>
> How did commons-cli "release version" 20040117.00 make it into Maven
> Central?
> It's been there for as long as I can remember.
> It would not bother any of us if this version did not always show up as the
> most recent/latest/bleeding edge release. Even though it's ancient and noone
> would want to use it of course.
> This effect is due to this version not following the commons-cli version
> scheme and due to the way Maven sorts version strings.
> A small use case to illustrate:
>
> {code:java}
> mvn versions:display-dependency-updates
> {code}
>
> {code:java}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] commons-cli:commons-cli ... 1.4 -> 20040117.00
> {code}
> I understand that purging release artifacts from Central may not be simple.
> Yet it would be so much appreciated if someone with the corresponding
> know-how and access could take care of it. Thanks a million!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CLI-310) Purge release version 20040117.000000 from Maven Central
[
https://issues.apache.org/jira/browse/CLI-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432257#comment-17432257
]
Markus Spann commented on CLI-310:
--
{quote}If this is for convenience because some apps and UI sort versions blindly
{quote}
Rather than purging this ancient good-for-nothing release, Maven itself and
artifact managers should be "fixed"?
I think it is safe to say the artifact is broken:
The class files date from January 1st 2003 yet the "version" is named 20040117,
there are no Maven descriptors in META-INF, the MANIFEST.MF is non-sense, the
POM looks broken (no schema, no parent etc), the class files' magic is 45 (0x2D
hex) JDK 1.1
> Purge release version 20040117.00 from Maven Central
>
>
> Key: CLI-310
> URL: https://issues.apache.org/jira/browse/CLI-310
> Project: Commons CLI
> Issue Type: Task
>Reporter: Markus Spann
>Priority: Minor
>
> How did commons-cli "release version" 20040117.00 make it into Maven
> Central?
> It's been there for as long as I can remember.
> It would not bother any of us if this version did not always show up as the
> most recent/latest/bleeding edge release. Even though it's ancient and noone
> would want to use it of course.
> This effect is due to this version not following the commons-cli version
> scheme and due to the way Maven sorts version strings.
> A small use case to illustrate:
>
> {code:java}
> mvn versions:display-dependency-updates
> {code}
>
> {code:java}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] commons-cli:commons-cli ... 1.4 -> 20040117.00
> {code}
> I understand that purging release artifacts from Central may not be simple.
> Yet it would be so much appreciated if someone with the corresponding
> know-how and access could take care of it. Thanks a million!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
