[jira] [Commented] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[
https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467514#comment-17467514
]
Gary D. Gregory commented on IO-663:
Hi [~elh...@metalab.unc.edu]
Does it matter if the file is open with write access or read-only access?
> FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
> ---
>
> Key: IO-663
> URL: https://issues.apache.org/jira/browse/IO-663
> Project: Commons IO
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Priority: Critical
>
> This bug is shared (likely because of code copied from one place to another)
> between the similar methods in commons IO, codehaus-plexus-utils, and
> maven-shared-utils.
> I don't have an isolated test case because this bug is platform specific and
> I've only seen it in Jenkins CI builds on Windows using JDK 7 through 15. I
> don't have a Windows system handy to test it. However it is reproducible.
> Typical code that triggers it is in RestoreBackupPomsPhaseTest in
> maven-release:
> {{// copy poms so tests are valid without clean}}
> {{ File sourceDir = getTestFile( "src/test/resources" + projectPath );}}
> {{ File testDir = getTestFile( "target/test-classes" + projectPath );}}
> {{ FileUtils.copyDirectoryStructure( sourceDir, testDir );}}
> I don't know whether there might be something weird in the setup of those two
> directories that's involved.
> Typical error message is:
> Caused by: java.nio.file.FileSystemException:
>
> F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml:
> The process cannot access the file because it is being used by another
> process
> "The process cannot access the file because it is being used by another
> process" I think points to the root of the bug. This is a Windows file system
> error message.
> Some history is here where I noticed it:
> [https://github.com/apache/maven-release/pull/42]
> In this case, I started with plexus-utils 3.1.0 which worked, upgraded to
> plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory
> from both maven-shared-utils and commons-io, all of which failed in the same
> way.
> I think this is caused by the use of NIO, which doesn't work quite the same
> when copying files on Windows as on Linux and Mac OS X.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[
https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467512#comment-17467512
]
elharo commented on IO-663:
---
Further work in maven suggests it might happen when a file is left open,
possibly in the source directory. So arguably it is a bug in client code and
yet:
1. Only on Windows. Linux can copy open files just fine.
2. Non-NIO based solutions were more robust against open files.
> FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
> ---
>
> Key: IO-663
> URL: https://issues.apache.org/jira/browse/IO-663
> Project: Commons IO
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Priority: Critical
>
> This bug is shared (likely because of code copied from one place to another)
> between the similar methods in commons IO, codehaus-plexus-utils, and
> maven-shared-utils.
> I don't have an isolated test case because this bug is platform specific and
> I've only seen it in Jenkins CI builds on Windows using JDK 7 through 15. I
> don't have a Windows system handy to test it. However it is reproducible.
> Typical code that triggers it is in RestoreBackupPomsPhaseTest in
> maven-release:
> {{// copy poms so tests are valid without clean}}
> {{ File sourceDir = getTestFile( "src/test/resources" + projectPath );}}
> {{ File testDir = getTestFile( "target/test-classes" + projectPath );}}
> {{ FileUtils.copyDirectoryStructure( sourceDir, testDir );}}
> I don't know whether there might be something weird in the setup of those two
> directories that's involved.
> Typical error message is:
> Caused by: java.nio.file.FileSystemException:
>
> F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml:
> The process cannot access the file because it is being used by another
> process
> "The process cannot access the file because it is being used by another
> process" I think points to the root of the bug. This is a Windows file system
> error message.
> Some history is here where I noticed it:
> [https://github.com/apache/maven-release/pull/42]
> In this case, I started with plexus-utils 3.1.0 which worked, upgraded to
> plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory
> from both maven-shared-utils and commons-io, all of which failed in the same
> way.
> I think this is caused by the use of NIO, which doesn't work quite the same
> when copying files on Windows as on Linux and Mac OS X.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-vfs] XenoAmess closed pull request #234: try to upgrade sshd to 2.8.0
XenoAmess closed pull request #234: URL: https://github.com/apache/commons-vfs/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory edited a comment on pull request #234: try to upgrade sshd to 2.8.0
garydgregory edited a comment on pull request #234: URL: https://github.com/apache/commons-vfs/pull/234#issuecomment-1003576258 @XenoAmess An alternative would be to migrate to a lesser version, just to get us out of the 0.x version range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #234: try to upgrade sshd to 2.8.0
garydgregory commented on pull request #234: URL: https://github.com/apache/commons-vfs/pull/234#issuecomment-1003576258 @XenoAmess An alternative would be to migrate to a lesser version, just to get is out of the 0.x version range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess commented on pull request #234: try to upgrade sshd to 2.8.0
XenoAmess commented on pull request #234: URL: https://github.com/apache/commons-vfs/pull/234#issuecomment-1003575634 > Hi @XenoAmess Don't get discouraged. I asked for help on the mailing list because updating 'sshd' and 'ftp-core' seem like non-trivial efforts based on my past experiences. If it had been trivial, I would have done it. In fact, I've already done work like you have in this very PR a long time ago, but did not take the time to figure out the bugs, and so, I moved on to other more pressing issues. Getting the code to compile is trivial compared to getting the tests to pass. Some tasks take a few hours, other days, and sometimes weeks. Good luck, whatever path you chose to take. (sigh) this is out of my ability... pr closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NET-708) Use yyyy instead of YYYY in SimpleDateFormat #97
[ https://issues.apache.org/jira/browse/NET-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated NET-708: Summary: Use instead of in SimpleDateFormat #97 (was: should use instead of in SimpleDateFormat) > Use instead of in SimpleDateFormat #97 > > > Key: NET-708 > URL: https://issues.apache.org/jira/browse/NET-708 > Project: Commons Net > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > Fix For: 3.9.0 > > > should use instead of in SimpleDateFormat > https://github.com/apache/commons-net/pull/97 > represents the year of the week > I don't think we should use it in those 2 usecases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (NET-708) should use yyyy instead of YYYY in SimpleDateFormat
[ https://issues.apache.org/jira/browse/NET-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved NET-708. - Fix Version/s: 3.9.0 Resolution: Fixed > should use instead of in SimpleDateFormat > --- > > Key: NET-708 > URL: https://issues.apache.org/jira/browse/NET-708 > Project: Commons Net > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > Fix For: 3.9.0 > > > should use instead of in SimpleDateFormat > https://github.com/apache/commons-net/pull/97 > represents the year of the week > I don't think we should use it in those 2 usecases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-net] garydgregory commented on pull request #97: [NET-708] should use yyyy instead of YYYY in SimpleDateFormat
garydgregory commented on pull request #97: URL: https://github.com/apache/commons-net/pull/97#issuecomment-1003560241 https://issues.apache.org/jira/browse/NET-708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory merged pull request #97: [NET-708] should use yyyy instead of YYYY in SimpleDateFormat
garydgregory merged pull request #97: URL: https://github.com/apache/commons-net/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NET-708) should use yyyy instead of YYYY in SimpleDateFormat
Jin Xu created NET-708: -- Summary: should use instead of in SimpleDateFormat Key: NET-708 URL: https://issues.apache.org/jira/browse/NET-708 Project: Commons Net Issue Type: Bug Reporter: Jin Xu should use instead of in SimpleDateFormat https://github.com/apache/commons-net/pull/97 represents the year of the week I don't think we should use it in those 2 usecases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-net] garydgregory closed pull request #94: Bump ftpserver-core from 1.1.1 to 1.1.2
garydgregory closed pull request #94: URL: https://github.com/apache/commons-net/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] commented on pull request #94: Bump ftpserver-core from 1.1.1 to 1.1.2
dependabot[bot] commented on pull request #94: URL: https://github.com/apache/commons-net/pull/94#issuecomment-1003554485 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #94: Bump ftpserver-core from 1.1.1 to 1.1.2
garydgregory commented on pull request #94: URL: https://github.com/apache/commons-net/pull/94#issuecomment-1003554482 Updated in a different PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory merged pull request #96: upgrade ftpserver to 1.1.2
garydgregory merged pull request #96: URL: https://github.com/apache/commons-net/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
