[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: [~erans] I'm sorry I can't help you with this, I've too many higher priority tasks on my plate. I'm signing out of this topic. I already regret of my 1st reply in this topic, at that time I didn't know who you are, well ... lesson learned ... ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294427#comment-16294427 ] OlgaK edited comment on RNG-37 at 12/18/17 4:33 AM: [~erans] I'm sorry I can't help you with this, I've too many higher priority tasks on my plate. I'm signing out of this topic. I already regret of my 1st reply in this topic, at that time I didn't know who you are, well ... lesson learned ... was (Author: cur4so): [~erans] I'm sorry I can't help you with this, I've too many higher priority tasks on my plate. I'm signing out of this topic. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: thanks [~kinow] for your reply and comments. I've made a new [pull request|https://github.com/apache/commons-rng/pull/5] from the fork of commons-rng and implemented your suggestions in the last commit. Regarding +public class ZigguratGaussianSampler +extends SamplerBase Not sure which checkstyle rule will be used, but normally these are kept in a single line, unless it breaks the other rule of the maximum number of chars per line" I've checked, all samplers in commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution except one have this format. So, I assume it's how it's expected, I've left it as is. ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
OlgaK updated RNG-37:
-
Comment: was deleted
(was: {quote}Then it looks like the whole procedure needs to be adapted, not
only the tail.
Indeed generating a single 32-bits value (nextInt(), at line 98) won't return
any of the double values (64-bits) that would require a different setting of
any one of the missing 32-bits.{quote}
I think missing 32-bits contribute to the precision (having 7 decimal digits vs
having 16). For Gaussian in high density area having 8th and after digits
doesn't make a notable effect, while in the low density are it does indeed.
I'm fairly sure it's just the tail. Besides when one tries to increase
precision switching from float to double but still keeps the same number of
fitting blocks...
Overall the fit is so to say good enough to pass the test. But it's not a big
deal to switch to Long. Moreover, it has been my original thought to make the
calcs in long and I've even added the missing long random in the main codebase
but then I switched to int.
Actually as you may notice in the paper there is another application of the
algorithm - to fit exponential distribution. I've tried to add this one as well
but there was severe test failure and since it has not been requested, I
decided to skip it. But there indeed all numbers need to be recalculated.
{quote}Then, I wonder how to make sure that no holes remain. Is it possible to
set up a unit test? If not, a last resort idea might be to make a plot of many
generated values, superimposed with a plot of a uniform sampling, and look for
anomalies (empty regions). {quote} The rng has a very well done testing module.
It allows people, coming from street or bb, to test their code adding just a
single line in the test suite. I was really impressed. I didn't get into
details by what criteria it assesses the quality of generated distribution but
it definitely more than just a single number pick (based on what I recall how
the 2d distribution test failed). If you think it doesn't make a check for the
wholes, it definitely would be a great idea to add it (not just for Ziggurat
test but for all distributions). The person who had written the testing module,
definitely could do it better and faster. For a "side person" imho it'd require
substantial time and efforts. One can make it as a task for "Help wanted" bb
but don't have over expectations :).
I'll do switch int -> long. Try to do it to the nearest weekend.
I didn't get your last message"Fix Version/s" ?? )
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Fix For: 1.1
>
> Attachments: ziggurat.buggy.png
>
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: Hi [~erans], yes, you're right for higher (64 bits) precision the tail (low probability values) needs to be adjusted. All parameters values has been taken from the paper and are for 32 bits. But from the top of my head I can't say how to make the adjustment. ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
OlgaK updated RNG-37:
-
Comment: was deleted
(was: Gilles, are you trying to pull it from
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
* branchHEAD -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts.
I've changed `fixes` on `Javadoc`
)
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Fix For: 1.1
>
> Attachments: ziggurat.buggy.png
>
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: Hi [~erans], I understand that you have many things on your agenda, but it's almost a week has past. Any updates? ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: Hi [~erans], I've made the changes as you requested. Regarding the performance, I've added a test into your tests suite, just that, I'm not an inventor of the algorithm, so rely on words of the authors. ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] OlgaK updated RNG-37: - Comment: was deleted (was: [~erans], [~eyal] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. ) > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294427#comment-16294427 ] OlgaK commented on RNG-37: -- [~erans] I'm sorry I can't help you with this, I've too many higher priority tasks on my plate. I'm signing out of this topic. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Fix For: 1.1 > > Attachments: ziggurat.buggy.png > > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290342#comment-16290342
]
OlgaK commented on RNG-37:
--
{quote}Then it looks like the whole procedure needs to be adapted, not only the
tail.
Indeed generating a single 32-bits value (nextInt(), at line 98) won't return
any of the double values (64-bits) that would require a different setting of
any one of the missing 32-bits.{quote}
I think missing 32-bits contribute to the precision (having 7 decimal digits vs
having 16). For Gaussian in high density area having 8th and after digits
doesn't make a notable effect, while in the low density are it does indeed.
I'm fairly sure it's just the tail. Besides when one tries to increase
precision switching from float to double but still keeps the same number of
fitting blocks...
Overall the fit is so to say good enough to pass the test. But it's not a big
deal to switch to Long. Moreover, it has been my original thought to make the
calcs in long and I've even added the missing long random in the main codebase
but then I switched to int.
Actually as you may notice in the paper there is another application of the
algorithm - to fit exponential distribution. I've tried to add this one as well
but there was severe test failure and since it has not been requested, I
decided to skip it. But there indeed all numbers need to be recalculated.
{quote}Then, I wonder how to make sure that no holes remain. Is it possible to
set up a unit test? If not, a last resort idea might be to make a plot of many
generated values, superimposed with a plot of a uniform sampling, and look for
anomalies (empty regions). {quote} The rng has a very well done testing module.
It allows people, coming from street or bb, to test their code adding just a
single line in the test suite. I was really impressed. I didn't get into
details by what criteria it assesses the quality of generated distribution but
it definitely more than just a single number pick (based on what I recall how
the 2d distribution test failed). If you think it doesn't make a check for the
wholes, it definitely would be a great idea to add it (not just for Ziggurat
test but for all distributions). The person who had written the testing module,
definitely could do it better and faster. For a "side person" imho it'd require
substantial time and efforts. One can make it as a task for "Help wanted" bb
but don't have over expectations :).
I'll do switch int -> long. Try to do it to the nearest weekend.
I didn't get your last message"Fix Version/s" ??
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Fix For: 1.1
>
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285525#comment-16285525 ] OlgaK commented on RNG-37: -- Hi [~erans], yes, you're right for higher (64 bits) precision the tail (low probability values) needs to be adjusted. All parameters values has been taken from the paper and are for 32 bits. But from the top of my head I can't say how to make the adjustment. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
]
OlgaK edited comment on RNG-37 at 10/10/17 11:28 PM:
-
Gilles, are you trying to pull it from
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
* branchHEAD -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts.
I've changed `fixes` on `Javadoc`
was (Author: cur4so):
Gilles, are you trying to pull it from
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
\* branchHEAD -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts.
I've changed `fixes` on `Javadoc`
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
]
OlgaK edited comment on RNG-37 at 10/10/17 11:28 PM:
-
Gilles, are you trying to pull it from
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
\* branchHEAD -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts.
I've changed `fixes` on `Javadoc`
was (Author: cur4so):
Gilles, are you trying to pull it from
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case
it works smoothly, no conflicts
```
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
\* branchHEAD -> FETCH_HEAD
Already up-to-date.
```
and on the github site it points that there are no conflicts.
I've changed `fixes` on `Javadoc`
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556 ] OlgaK edited comment on RNG-37 at 10/10/17 11:26 PM: - Gilles, are you trying to pull it from https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case it works smoothly, no conflicts ``` git pull https://github.com/cur4so/commons-rng.git >From https://github.com/cur4so/commons-rng \* branchHEAD -> FETCH_HEAD Already up-to-date. ``` and on the github site it points that there are no conflicts. I've changed `fixes` on `Javadoc` was (Author: cur4so): Gilles, are you trying to pull it from https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case it works smoothly, no conflicts ```git pull https://github.com/cur4so/commons-rng.git >From https://github.com/cur4so/commons-rng \* branchHEAD -> FETCH_HEAD Already up-to-date.``` and on the github site it points that there are no conflicts. I've changed `fixes` on `Javadoc` > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556 ] OlgaK edited comment on RNG-37 at 10/10/17 11:25 PM: - Gilles, are you trying to pull it from https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case it works smoothly, no conflicts ```git pull https://github.com/cur4so/commons-rng.git >From https://github.com/cur4so/commons-rng \* branchHEAD -> FETCH_HEAD Already up-to-date.``` and on the github site it points that there are no conflicts. I've changed `fixes` on `Javadoc` was (Author: cur4so): Gilles, are you trying to pull it from https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case it works smoothly, no conflicts ```git pull https://github.com/cur4so/commons-rng.git >From https://github.com/cur4so/commons-rng * branchHEAD -> FETCH_HEAD Already up-to-date.``` and on the github site it points that there are no conflicts. I've changed `fixes` on `Javadoc` > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556 ] OlgaK commented on RNG-37: -- Gilles, are you trying to pull it from https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case it works smoothly, no conflicts ```git pull https://github.com/cur4so/commons-rng.git >From https://github.com/cur4so/commons-rng * branchHEAD -> FETCH_HEAD Already up-to-date.``` and on the github site it points that there are no conflicts. I've changed `fixes` on `Javadoc` > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197495#comment-16197495 ] OlgaK commented on RNG-37: -- thanks [~kinow] for your reply and comments. I've made a new [pull request|https://github.com/apache/commons-rng/pull/5] from the fork of commons-rng and implemented your suggestions in the last commit. Regarding +public class ZigguratGaussianSampler +extends SamplerBase Not sure which checkstyle rule will be used, but normally these are kept in a single line, unless it breaks the other rule of the maximum number of chars per line" I've checked, all samplers in commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution except one have this format. So, I assume it's how it's expected, I've left it as is. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196396#comment-16196396 ] OlgaK commented on RNG-37: -- Hi [~erans], I understand that you have many things on your agenda, but it's almost a week has past. Any updates? > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190708#comment-16190708 ] OlgaK commented on RNG-37: -- Hi [~erans], I've made the changes as you requested. Regarding the performance, I've added a test into your tests suite, just that, I'm not an inventor of the algorithm, so rely on words of the authors. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189108#comment-16189108 ] OlgaK edited comment on RNG-37 at 10/3/17 12:38 AM: [~erans], [~eyal] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. was (Author: cur4so): [~erans] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189108#comment-16189108 ] OlgaK edited comment on RNG-37 at 10/3/17 12:28 AM: [~erans] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. was (Author: cur4so): [~webcomponents] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189108#comment-16189108 ] OlgaK commented on RNG-37: -- [~webcomponents] and others, here is a [pull request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm implementation. I can't commit to apache-commons, therefore I've made a mirror in my github account. Let me know if you have any questions. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
