[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/390
  
Thanks!


---

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/390
  
Thank for the contribution.

Could you please squash to the commits? Then I will merge the pull request.


---

[GitHub] commons-lang pull request #384: Travis: Stop building with Java 9 and 10, as...

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/384

Travis: Stop building with Java 9 and 10, as these are superseded by …

…Java 11 and not supported anymore.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
travis_drop_java9_and_10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit c035de97504a9ba721e5617584e08f1b1f66d455
Author: pascalschumacher 
Date:   2018-11-20T17:42:57Z

Travis: Stop building with Java 9 and 10, as these are superseded by Java 
11 and not supported anymore.




---

[GitHub] commons-lang issue #381: LANG-1406 StringIndexOutOfBoundsException in String...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/381
  
@kinow What do you think is this a better solution than #340?


---

[GitHub] commons-lang pull request #383: Make whitespace use after tokens consistent ...

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/383

Make whitespace use after tokens consistent and add checkstyle rule t…

…o enforce it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
consistent_whitespace_after_formatting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #383


commit 869a26c5e71256e16b51727e717150ba4c5e8dfb
Author: pascalschumacher 
Date:   2018-11-18T10:59:34Z

Make whitespace use after tokens consistent and add checkstyle rule to 
enforce it.




---

[GitHub] commons-lang issue #376: Test cleanup

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/376
  
Thanks! 👍 


---

[GitHub] commons-lang issue #376: Test cleanup

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/376
  
Looks great, thank you very much! 👍 

There are just some checkstyle errors related to unused imports left to fix 
(see failed travis build).


---

[GitHub] commons-lang issue #375: JUnit Jupiter migration completion

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/375
  
Thank you very much for this massive effort! 👍 


---

[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/374
  
Thanks! 👍 


---

[GitHub] commons-lang pull request #374: Update time tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/374#discussion_r224137193
  
--- Diff: pom.xml ---
@@ -543,6 +543,11 @@
   junit-vintage-engine
   test
 
+
+  org.junit-pioneer
+  junit-pioneer
+  0.2.0
--- End diff --

This dependency should have `test` scope.


---

[GitHub] commons-lang issue #373: Update mutable tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/373
  
Thanks! 👍 


---

[GitHub] commons-lang issue #372: Update math tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/372
  
Thanks! 👍 


---

[GitHub] commons-lang issue #371: Update tuple tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/371
  
Thanks! 👍 


---

[GitHub] commons-lang issue #370: Update text tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/370
  
Thanks! 👍 


---

[GitHub] commons-lang issue #369: Update reflect tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/369
  
Thanks! 👍 


---

[GitHub] commons-lang issue #368: Update exception tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/368
  
Thanks! 👍 


---

[GitHub] commons-lang issue #367: Update event tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/367
  
Thanks! 👍 


---

[GitHub] commons-lang issue #366: Update concurrent tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/366
  
Thanks! 👍 


---

[GitHub] commons-lang pull request #365: Travis: Also build with openjdk-ea

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/365

Travis: Also build with openjdk-ea



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
travis_openjdk_ea

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #365


commit a3a1904e5964a97a20d5132569beb2901d2cd919
Author: pascalschumacher 
Date:   2018-10-06T08:30:32Z

Travis: Also build with openjdk-ea




---

[GitHub] commons-lang issue #363: Update builder tests to JUnit Jupiter

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/363
  
Thanks! 👍 

Merged in 
https://github.com/apache/commons-lang/commit/729adb624d3e720afb8686093814ab2bcc2d2f13

Not sure why this pull request was not auto-closed even-though I 
fast-forward merged the branch.

Could you please close the pull request?

Thanks!


---

[GitHub] commons-lang issue #359: these 2 links seem to be broken

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/359
  
Thanks! 👍 


---

[GitHub] commons-lang issue #354: Convert tests for Validate.isTrue overloads to @Nes...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/354
  
+1


---

[GitHub] commons-lang pull request #350: Replace FindBugs with SpotBugs

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/350

Replace FindBugs with SpotBugs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang spotbugs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #350


commit 82fd2516d6c018e46ef290e05551349a9ed82ca8
Author: pascalschumacher 
Date:   2018-08-28T17:00:09Z

Replace FindBugs with SpotBugs




---

[GitHub] commons-lang issue #334: Code refactoring and cleaning

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/334
  
Thanks! 👍


---

[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/331
  
@chonton No further review comments by anyone, so I guess this is good to 
merge?


---

[GitHub] commons-lang issue #334: Code refactoring and cleaning

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/334
  
@kinow Changes to throws declaration are binary compatible (see: 
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.21). 
Removing checked exceptions from a throws declaration is source incompatible, 
but removing unchecked exceptions is source compatible.

This confirmed by this pull request passing the clirr check (see: 
https://travis-ci.org/apache/commons-lang/jobs/394527557#L3097)


---

[GitHub] commons-lang issue #275: LANG-1339: replace java.beans.PropertyListener by j...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/275
  
+1


---

[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/325
  
Thanks! 👍 


---

[GitHub] commons-lang issue #333: (doc) Fix typos in classes of tuple package

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/333
  
Thanks! :+1:


---

[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/331
  
+1


---

[GitHub] commons-lang issue #330: LANG-1397: WordUtils.wrap throws StringIndexOutOfBo...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/330
  
Thanks for the pull request!

I would be nice if you could amend the commit to add the issue id and 
description at the beginning of the commit message.

Thanks!


---

[GitHub] commons-lang issue #329: Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK"...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/329
  
I updated the pull request to allow failures on Java 11.


---

[GitHub] commons-lang issue #329: Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK"...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/329
  
When using Java 11 the following test failures occur:

```
[ERROR] Failures: 
[ERROR]   
FastDateFormat_ParserTest>FastDateParserTest.testLocales_LongNoEra_AD:303->FastDateParserTest.testLocales:341
 Locale zh_TW failed with /////ss// era AD
java.text.ParseException: Unparseable date: 
2003/二月/0010/0012//00/上午/星期一
[ERROR]   
FastDateFormat_ParserTest>FastDateParserTest.testLocales_LongNoEra_BC:308->FastDateParserTest.testLocales:341
 Locale zh_TW failed with /////ss// era BC
java.text.ParseException: Unparseable date: 
2003/二月/0010/0012//00/上午/星期六
[ERROR]   
FastDateFormat_ParserTest>FastDateParserTest.testLocales_Long_AD:283->FastDateParserTest.testLocales:341
 Locale zh_TW failed with //////ss// era AD
java.text.ParseException: Unparseable date: 西å…
ƒ/2003/二月/0010/0012//00/上午/星期一
[ERROR]   
FastDateFormat_ParserTest>FastDateParserTest.testLocales_Long_BC:288->FastDateParserTest.testLocales:341
 Locale zh_TW failed with //////ss// era BC
java.text.ParseException: Unparseable date: 西å…
ƒå‰/2003/二月/0010/0012//00/上午/星期六
[ERROR]   FastDateFormat_ParserTest>FastDateParserTest.testTzParses:275 
tz:America/New_York locale:Norwegian Nynorsk expected: but was:
[ERROR]   FastDateParserTest.testLocales_LongNoEra_AD:303->testLocales:341 
Locale zh_TW failed with /////ss// era AD
java.text.ParseException: Unparseable date: 
2003/二月/0010/0012//00/上午/星期一
[ERROR]   FastDateParserTest.testLocales_LongNoEra_BC:308->testLocales:341 
Locale zh_TW failed with /////ss// era BC
java.text.ParseException: Unparseable date: 
2003/二月/0010/0012//00/上午/星期六
[ERROR]   FastDateParserTest.testLocales_Long_AD:283->testLocales:341 
Locale zh_TW failed with //////ss// era AD
java.text.ParseException: Unparseable date: 西å…
ƒ/2003/二月/0010/0012//00/上午/星期一
[ERROR]   FastDateParserTest.testLocales_Long_BC:288->testLocales:341 
Locale zh_TW failed with //////ss// era BC
java.text.ParseException: Unparseable date: 西å…
ƒå‰/2003/二月/0010/0012//00/上午/星期六
[ERROR]   FastDateParserTest.testTzParses:275 tz:America/New_York 
locale:Norwegian Nynorsk expected: but was:
[ERROR] Errors: 
[ERROR]   
FastDateFormat_ParserTest>FastDateParserTest.testParses:251->FastDateParserTest.validateSdfFormatFdpParseEquality:227
 » Parse
[ERROR]   
FastDateParserTest.testParses:251->validateSdfFormatFdpParseEquality:227 » 
Parse
```


---

[GitHub] commons-lang pull request #329: Travis: Add Java 10 "Oracle JDK", Java 10 "O...

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/329

Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle …

…JDK"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
travis_add_latest_jdks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #329


commit 389965d1161e3b3fdaad35a1f4fb03765409d88b
Author: pascalschumacher <pascalschumacher@...>
Date:   2018-05-04T19:32:56Z

Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle JDK"




---

[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/327
  
Thanks! 👍 


---

[GitHub] commons-lang issue #322: (doc) Update GitHub PR help link

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/322
  
Thanks! 👍

The file was original generated out of 
https://github.com/apache/commons-build-plugin/blob/master/src/main/resources/commons-xdoc-templates/contributing-md-template.md.
 I updated this file too.




---

[GitHub] commons-lang issue #321: SerializationUtilsTest cleanup

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/321
  
Thanks! 👍 


---

[GitHub] commons-lang issue #314: LANG-1060 NumberUtils.isNumber assumes number start...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/314
  
Thanks! 👍 


---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Sure, that is fine!


---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
A pull request with tests for the `float` case would be welcome. 


---

[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/313
  
Thanks! 👍 


---

[GitHub] commons-lang issue #281: LANG-1372: Add ToStringSummary annotation

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/281
  
Thanks! 👍 


---

[GitHub] commons-lang issue #286: LANG-1352 EnumUtils.getEnumIgnoreCase and isValidEn...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/286
  
Thanks! 👍 


---

[GitHub] commons-lang issue #307: Fix TypeUtils.parameterize to work correctly with n...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/307
  
Thanks! 👍 

Sorry for the delay in merging.


---

[GitHub] commons-lang issue #307: Fix TypeUtils.parameterize to work correctly with n...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/307
  
created https://issues.apache.org/jira/browse/LANG-1371 to track this


---

[GitHub] commons-lang issue #310: A small mistake in javadoc description.

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/310
  
Thanks! 👍 


---

[GitHub] commons-lang issue #305: Remove unnecessary testing comments

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/305
  
Thanks!


---

[GitHub] commons-lang issue #306: .travis: add IBM JDK 8

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/306
  
Looks like the IBM JDK is not yet supported by the travis jdk-switcher, so 
let's wait some time.


---

[GitHub] commons-lang pull request #306: .travis: add IBM JDK 8

[PascalSchumacher]

Github user PascalSchumacher closed the pull request at:

https://github.com/apache/commons-lang/pull/306


---

[GitHub] commons-lang pull request #306: .travis: add IBM JDK 8

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/306

.travis: add IBM JDK 8



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
travis_add_ibm_jdk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit 7af80077e4d547dfe6da1f961dfaf4673abec285
Author: pascalschumacher <pascalschumac...@gmx.net>
Date:   2017-11-07T19:18:23Z

.travis: add IBM JDK 8




---

[GitHub] commons-lang issue #304: Fix DateUtilsTest to work reliably on Java 9

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/304
  
@garydgregory For me too and the build on travis with java 9 has been 
sucessfully running for months now. 

This seems to be a locale related thing. I can replicated the 8 test 
failures by adding `-Duser.country=GB -Duser.language=en` to surefire `argLine`.


---

[GitHub] commons-lang pull request #299: Add module-info for Java 9

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/299#discussion_r147560886
  
--- Diff: .travis.yml ---
@@ -21,8 +21,19 @@ jdk:
   - oraclejdk8
   - oraclejdk9
 
+cache:
+  directories:
+- "$HOME/.m2/repository"
+
+before_cache:
+  - rm -rf $HOME/.m2/repository/org/apache/commons/commons-lang3
+
+install:
+  - mvn --version
+
 script:
-  - mvn
+  - mvn -e -B
 
 after_success:
-  - mvn clean cobertura:cobertura coveralls:report -Ptravis-cobertura
+  - if [ $TRAVIS_JDK_VERSION == "openjdk7" ] || [ $TRAVIS_JDK_VERSION == 
"oraclejdk8" ]; then mvn -e -B clean cobertura:cobertura coveralls:report 
-Ptravis-cobertura; fi
+  - if [ $TRAVIS_JDK_VERSION == "oraclejdk9" ]; then mvn -e -B clean 
cobertura:cobertura -Ptravis-cobertura; fi
--- End diff --

Nitpick: I think we can remove this line, because running `cobertura` 
without uploading to `coveralls` mostly just wastes cpu cycles.


---

[GitHub] commons-lang pull request #209: LANG-1164: allow ToStringStyle to omitNulls

[PascalSchumacher]

Github user PascalSchumacher closed the pull request at:

https://github.com/apache/commons-lang/pull/209


---

[GitHub] commons-lang pull request #204: LANG-1268: Add methods for comparing numbers...

[PascalSchumacher]

Github user PascalSchumacher closed the pull request at:

https://github.com/apache/commons-lang/pull/204


---

[GitHub] commons-lang issue #303: doc: remove escape SQL references from javadoc

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/303
  
Thanks! 👍 


---

[GitHub] commons-lang issue #300: Improve StringUtils#replace throughput

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/300
  
Thanks! 👍 


---

[GitHub] commons-lang pull request #:

[PascalSchumacher]

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/c56b87d6efe530590b6d9a07e41ca00af208ce37#commitcomment-24901481
  
Travis build fails:

```
Failed tests: 

  FieldUtilsTest.testGetAllFields:167 array lengths differed, 
expected.length=12 actual.length=11

  FieldUtilsTest.testGetAllFieldsList:179 expected:<[public static final 
int java.lang.Integer.MIN_VALUE, public static final int 
java.lang.Integer.MAX_VALUE, public static final java.lang.Class 
java.lang.Integer.TYPE, static final char[] java.lang.Integer.digits, static 
final char[] java.lang.Integer.DigitTens, static final char[] 
java.lang.Integer.DigitOnes, static final int[] java.lang.Integer.sizeTable, 
private final int java.lang.Integer.value, public static final int 
java.lang.Integer.SIZE, private static final long 
java.lang.Integer.serialVersionUID, static final boolean 
java.lang.Integer.$assertionsDisabled, private static final long 
java.lang.Number.serialVersionUID]> but was:<[public static final int 
java.lang.Integer.MIN_VALUE, public static final int 
java.lang.Integer.MAX_VALUE, public static final java.lang.Class 
java.lang.Integer.TYPE, static final char[] java.lang.Integer.digits, static 
final char[] java.lang.Integer.DigitTens, static final char[] java.lang.Integer
 .DigitOnes, static final int[] java.lang.Integer.sizeTable, private final int 
java.lang.Integer.value, public static final int java.lang.Integer.SIZE, 
private static final long java.lang.Integer.serialVersionUID, private static 
final long java.lang.Number.serialVersionUID]>
```

see: https://travis-ci.org/apache/commons-lang/jobs/286344083


---

[GitHub] commons-lang pull request #296: LANG-1355: Add FastTimeZone to decrease Time...

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/296#discussion_r143781416
  
--- Diff: src/main/java/org/apache/commons/lang3/time/FastTimeZone.java ---
@@ -39,10 +43,11 @@ public static TimeZone getGmtTimeZone() {
 
 /**
  * Get a TimeZone, looking first for GMT custom ids, then falling back 
to Olson ids.
- * A GMT custom id has an optional prefix of GMT, followed by sign, 
hours digit(s), optional
- * colon(':'), and optional minutes digits: [GMT] (+|-) Hours [[:] 
Minutes]
+ * A GMT custom id can be 'Z', or 'UTC', or has an optional prefix of 
GMT,
+ * followed by sign, hours digit(s), optional colon(':'), and optional 
minutes digits.
+ * i.e. [GMT] (+|-) Hours [[:] Minutes]
  *
- * @param id A GMT custom id or Olsen id
+ * @param id A GMT custom id (or Olson id
--- End diff --

Nitpick: either a superfluous `(` or a missing `)`


---

[GitHub] commons-lang issue #296: LANG-1355: Add FastTimeZone to decrease TimeZone.ge...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/296
  
Looks good imho. 👍 


---

[GitHub] commons-lang pull request #:

[PascalSchumacher]

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-lang/commit/d848328a7aa54f73117b8f13ce6e67049dc9502e#commitcomment-24866834
  
`3.6` already requires java 7.

Also the builds on travis fail with:

```There are 8 errors reported by Checkstyle 6.11.2 with 
/home/travis/build/apache/commons-lang/checkstyle.xml ruleset.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[959] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[971] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[980] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/main/java/org/apache/commons/lang3/time/FastDateParser.java:[987] (regexp) 
RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[427]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[441]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[452]
 (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] 
src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java:[462]
 (regexp) RegexpSingleline: Line has trailing spaces.```


---

[GitHub] commons-lang pull request #297: Add a rule of Locale.ENGLISH to String.toUpp...

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/297#discussion_r143555903
  
--- Diff: src/main/java/org/apache/commons/lang3/time/FormatCache.java ---
@@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
 // Eliminate the usual boilerplate because
 // this inner static class is only used in a generic 
ConcurrentHashMap
 // which will not compare against other Object types
-return Arrays.equals(keys, ((MultipartKey)obj).keys);
+return obj instanceof MultipartKey && Arrays.equals(keys, 
((MultipartKey)obj).keys);
--- End diff --

Please do not include unrelated changes in a single pull request. Thanks!


---

[GitHub] commons-lang issue #298: Add an instanceof test in the implementation of equ...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/298
  
The comment above the statement explains why it is done this way.

In case this is merged the comment should be removed.


---

[GitHub] commons-lang issue #295: ExtendedMessageFormatTest integers

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/295
  
Thanks!


---

[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/202
  
@douddle I created https://issues.apache.org/jira/browse/LANG-1356 to track 
the bypass issue.


---

[GitHub] commons-lang issue #292: LANG-1348 - StackOverflowError on TypeUtils.toStrin...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/292
  
Great pull request! Thanks! :+1: 

merged in 
https://github.com/apache/commons-lang/commit/cc6beb2d05347fba64d933906ae2b712b1a43302


---

[GitHub] commons-lang issue #295: ExtendedMessageFormatTest integers

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/295
  
Can you close the pull request? (I messed up the commit comment.)


---

[GitHub] commons-lang issue #295: ExtendedMessageFormatTest integers

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/295
  
Thanks!


---

[GitHub] commons-lang issue #293: Char utils test

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/293
  
Thanks! :+1: 


---

[GitHub] commons-lang issue #289: Boolean comparisons in CharRange

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/289
  
Thanks!


---

[GitHub] commons-lang issue #287: Clean up findbugs exclusions for old XYZRange class...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/287
  
Thanks! :+1: 


---

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/282
  
I added a test. Thanks for the pull request! :+1: 


---

[GitHub] commons-lang issue #284: remove redundant modifiers (support recent checksty...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/284
  
Thanks! :+1:


---

[GitHub] commons-lang issue #283: LANG-1350: Fix varargs array invokeConstructor

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/283
  
Thanks for the pull request! :+1: 

It was merged by @garydgregory in 
https://github.com/apache/commons-lang/commit/cc94767e7eabdfcf9d1cab1d8d1d8556864394c6

It would be nice if you could close the pull request.

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/282
  
created https://issues.apache.org/jira/browse/LANG-1349 to track this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #280: .travis.yml: add oraclejdk9

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/280

.travis.yml: add oraclejdk9



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
add_jdk9_to_travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit f55112579ecb6551658ae160e0377c974f33e6f0
Author: pascalschumacher <pascalschumac...@gmx.net>
Date:   2017-05-25T19:43:20Z

.travis.yml: add oraclejdk9




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #273: add lastIndexOfAnyChar method just like indexOfAny

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/273
  
@Abrasha  Thank you very much for the offer, but I think you should give 
@qxo some more time (a few days) to fix it himself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #273: add lastIndexOfAnyChar method just like indexOfAny

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/273
  
@Abrasha You can create a pull request for @qxo fork. If he merges it, it 
will be added to this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #273: add lastIndexOfAnyChar method just like indexOfAny

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/273
  
Thanks for the pull request, but the build fails because of checkstyle 
violations, see: https://travis-ci.org/apache/commons-lang/jobs/248359934 for 
details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #274: Fix ExceptionUtils#getStackFrame(String) javadoc

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/274
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #268: .travis.yml: add oraclejdk9

[PascalSchumacher]

Github user PascalSchumacher closed the pull request at:

https://github.com/apache/commons-lang/pull/268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #268: .travis.yml: add oraclejdk9

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/268
  
The build works using java 9 locally. I guess its only a few months at most 
until jdk 9 will be officially supported on travis, so I won't invest any more 
time into this for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #271: LANG-1340: Add ibmjdk8 support for travis-ci

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/271
  
Not (yet) ready to merge, see my comments at 
https://github.com/apache/commons-text/pull/45 for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #268: .travis.yml: add oraclejdk9

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/268
  
It is not officially supported, but it is possible.

For example https://github.com/jacoco/jacoco and 
https://github.com/apache/logging-log4j2 use jdk 9 on travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #268: .travis.yml: add oraclejdk9

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/268
  
Another problem is that the maven version used by travis does not work with 
jdk 9 as far as I know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #268: .travis.yml: add oraclejdk9

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/268

.travis.yml: add oraclejdk9



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang 
add_jdk9_to_travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #268


commit 791d1a582867d30bc705c4dc7db83565566bc199
Author: pascalschumacher <pascalschumac...@gmx.net>
Date:   2017-05-25T19:43:20Z

.travis.yml: add oraclejdk9




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #223: [LANG-1304] StringUtils method to check for mixed c...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/223
  
Thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #209: LANG-1164: allow ToStringStyle to omitNulls

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/209
  
Thanks. :smile: 

You won't need this to exclude `null` values when using 
`ReflectionToStringBuilder`, see https://github.com/apache/commons-lang/pull/259

This will only be useful for custom `ToStringBuilder` implementations. I'm 
not sure that is is still worth adding given 
ReflectionToStringBuilder#excludeNullValues`. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/223#discussion_r114111595
  
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -7193,6 +7193,45 @@ public static boolean isAllUpperCase(final 
CharSequence cs) {
 return true;
 }
 
+/**
+ * Checks if the CharSequence contains mixed casing of both 
uppercase and lowercase characters.
+ *
+ * {@code null} will return {@code false}.
+ * An empty String (length()=0) will return {@code false}.
+ *
+ * 
+ * StringUtils.isMixedCase(null)= false
+ * StringUtils.isMixedCase("")  = false
+ * StringUtils.isMixedCase("aBc")   = true
+ * StringUtils.isMixedCase("ABC")   = false
+ * StringUtils.isMixedCase("abc")   = false
+ * StringUtils.isMixedCase("A c")   = false
+ * StringUtils.isMixedCase("A1c")   = false
+ * StringUtils.isMixedCase("a/C")   = false
+ * 
+ *
+ * @param cs the CharSequence to check, may be null
+ * @return {@code true} if contains both uppercase and lowercase 
characters, and is non-null
+ */
+public static boolean isMixedCase(final CharSequence cs) {
+if (cs == null || isEmpty(cs)) {
+return false;
+}
+boolean containsUppercase = false;
+boolean containsLowercase = false;
+final int sz = cs.length();
+for (int i = 0; i < sz; i++) {
--- End diff --

@arbasha I believe you requested this feature, what is your opinion on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #225: [LANG-1307] - Add getDigits method to StringUtils

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/225
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #264: HashSetvBitSetTest diamond operator

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/264
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/182
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #191: ToStringExcludeNullValue

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/191
  
Support for excluding `null` values was added in 
https://github.com/apache/commons-lang/commit/8147cc5b3de5fa7a3a3e8116355efa44367dc3c5

@gabriel-amaral Thanks for the pull request and sorry that it was not 
merged. Can you please close it? Thanks!




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #263: Use String#contains where possible

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/263
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #261: LANG-1317 Adds MethodUtils#findAnnotation and exten...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Merged. Thank you very much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #261: LANG-1317 Adds MethodUtils#findAnnotation and exten...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@yasserzamani Thanks!

No need to apologize. It is just that we try to be conservative with new 
additions (If we add a public method we have to support it for a long time and 
can not do any incompatible changes.). If the method is deemed generally useful 
it can always be moved and made public later on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
If I'm not mistaken the list returned by `getAllSuperclassesAndInterfaces` 
can contain the same interface multiple times if it is implemented by more than 
one super class. To prevent this the result should be collected in 
`LinkedHashSet` first (similar to 
https://github.com/yasserzamani/commons-lang/blob/90e252f571377cac39f5e2a3fc73749f589c24de/src/main/java/org/apache/commons/lang3/ClassUtils.java#L448).
 What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
Created https://issues.apache.org/jira/browse/LANG-1321 for the 
`ClassUtils#getAllSuperclassesAndInterfaces` addition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/261#discussion_r112563123
  
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String 
className, final int len) {
 }
 
 /**
+ * Gets a combination of {@link #getAllSuperclasses}(Class)} and
+ * {@link #getAllInterfaces}(Class)}, one from superclasses, one
+ * from interfaces, and so on in a breadth first way.
+ *
+ * @param cls  the class to look up, may be {@code null}
+ * @return the {@code List} of superclasses in order going up from 
this one
--- End diff --

This should also mention Interfaces.

Can you add a since tag to this method?

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/259
  
@chtompki Sorry for the delay, other open source projects and vacations 
interfered.

As the ToStringStyle implementations are singletons, I do not see a save 
way to use #209 as a basis for this pull request. Maybe I'm missing something?

I think #209 and this can coexists (as long as the naming is aligned).

@MarkDacek Thanks for creating this pull request. I think it would be great 
to have this feature in commons-lang. :+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/261
  
@yasserzamani Sorry for the delay, other open source projects and vacations 
interfered.

I'm not sure if the priority parameter of `getAllSuperclassesAndInterfaces` 
is necessary? Are you aware of any use-cases where it is necessary? Maybe we 
should keep things simple and remove it?

Otherwise the pull request is fine. :=) :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---