[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/202 @douddle I created https://issues.apache.org/jira/browse/LANG-1356 to track the bypass issue. ---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user douddle commented on the issue: https://github.com/apache/commons-lang/pull/202 I start to use your feature and I discover a bug. String are now compared with internal data (hash and char[]). But sometimes hash value is not initialized, this is probably a cache for the hashcode. So the comparison fails even if the char[] content is the same. ---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/202 [](https://coveralls.io/builds/8467444) Coverage decreased (-0.04%) to 93.442% when pulling **f4cf194decebba1b6aad156b8a0d146195708676 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **89afbb0c3eaa2d074dc1ef46d09675f24da0e120 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/202 I haven't locked at this in-depth yet, but seems like a useful enhancement. I would remove the support for including transient fields, because that seems like a bad practice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/202 [](https://coveralls.io/builds/8467369) Coverage decreased (-0.02%) to 93.438% when pulling **b6eee76036d4e44f89f029aa3d45b6842598e69b on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **eb2b89efbe15ab0b70fd94f0ecd0aa03866fb4d2 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
