[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...

2017-04-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/259
  
@chtompki Sorry for the delay, other open source projects and vacations 
interfered.

As the ToStringStyle implementations are singletons, I do not see a save 
way to use #209 as a basis for this pull request. Maybe I'm missing something?

I think #209 and this can coexists (as long as the naming is aligned).

@MarkDacek Thanks for creating this pull request. I think it would be great 
to have this feature in commons-lang. :+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...

2017-03-31 Thread chtompki
Github user chtompki commented on the issue:

https://github.com/apache/commons-lang/pull/259
  
@PascalSchumacher - Do you think we should take this approach, or the 
approach you went after in 
[LANG-1164](https://issues.apache.org/jira/browse/LANG-1164).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...

2017-03-18 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/259
  

[![Coverage 
Status](https://coveralls.io/builds/10664090/badge)](https://coveralls.io/builds/10664090)

Coverage increased (+0.01%) to 94.559% when pulling 
**e423b0bc2dea4167ad98fffc1afd9243ba73aad6 on MarkDacek:LANG-1167** into 
**bf80b9e2803aa277047951a7251267bfb7097c3b on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---