[GitHub] commons-lang issue #265: LANG-1325: Increase test coverage of ToStringBuilde...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/265 [](https://coveralls.io/builds/11303110) Coverage increased (+0.4%) to 95.074% when pulling **9766e22b42b7b3f3923cb9c2502dfc2dd5d0a5b0 on arbasha:inc_cov** into **c8e648b92cc133a604b5e1f4da1ced943788e64b on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #265: LANG-1325: Increase test coverage of ToStringBuilde...
Github user arbasha commented on the issue: https://github.com/apache/commons-lang/pull/265 @kinow done! thanks for looking :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #265: LANG-1325: Increase test coverage of ToStringBuilde...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/265 [](https://coveralls.io/builds/11302939) Coverage increased (+0.4%) to 95.074% when pulling **ece2f255eed8ad9eff6e236152de65e804c6adb5 on arbasha:inc_cov** into **c8e648b92cc133a604b5e1f4da1ced943788e64b on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #265: LANG-1325: Increase test coverage of ToStringBuilde...
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/265 That looks good, thanks! The coveralls bot normally tells us here if the coverage increased or decreased. However, looks like you have added tabs to your code, and that caused Travis CI build bot to fail (click on Details on the link above for details): ``` #https://travis-ci.org/apache/commons-lang/jobs/227134274 INFO] There is 1 error reported by Checkstyle 6.11.2 with /home/travis/build/apache/commons-lang/checkstyle.xml ruleset. [ERROR] src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java:[617,1] (whitespace) FileTabCharacter: File contains tab characters (this is the first instance). [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 01:00 min [INFO] Finished at: 2017-04-29T13:20:38+00:00 [INFO] Final Memory: 39M/431M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on project commons-lang3: You have 1 Checkstyle violation. -> [Help 1] ``` If you remove tabs by spaces it should pass the build and we will see the coverage report here. Thanks! Bruno --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
