[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-10-01 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
There is a lot of complexity in commons-parent and commons generally. 
Getting a build to work for Joda was hard enough, and there I am willing to 
insist on releases being done on Java 9 or later. There needs to be a lot more 
work on the commons build before `module-info` should be considered, however at 
the moment its not clear as to whether doing that work would be positive (due 
to Android, Jakarta EE issues etc)


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-09-30 Thread johnou 
Github user johnou commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@jodastephen can you be more specific?


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-07-12 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Its not just compiling, there are issues at runtime still AFAIK, especially 
with Java EE and older bytecode libraries.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-07-12 Thread johnou 
Github user johnou commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@jodastephen have you checked out https://github.com/moditect/moditect ? 

Moditect uses Objweb-ASM to compile the module-info.class which means you 
can support Java 1.7 / 1.8 for Android.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-07-12 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Adding `module-info` causes some older/Android projects to fail as they 
can't handle the class format. So, projects are left with the choice of moving 
forwards or breaking these older/Android projects.

This issue is also tied up in the need to modernise the commons parent 
pom.xml for Java 9 and later.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2018-07-02 Thread sigursoft 
Github user sigursoft commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Hi guys,
What's the status on this pull request? 😄 



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-31 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@namannigam You need to check it out and run `mvn clean install site` on 
Java 9.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-30 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13963478/badge)](https://coveralls.io/builds/13963478)

Coverage decreased (-0.02%) to 95.163% when pulling 
**313723da37a87a683683ff5edab139cf10612573 on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-30 Thread namannigam 
Github user namannigam commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@jodastephen What's the error that you get with site? Any links to the 
build?


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-30 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
`mvn install` works fine on each JDK version AFAICT. `mvn site` still 
breaks on cobertura on Java 9 and I'm not sure I can work around it without 
removing it from the parent pom.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-28 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
I'll bring this up a last time on the ML to make sure nobody has objections 
against merging this.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-27 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13919900/badge)](https://coveralls.io/builds/13919900)

Coverage decreased (-0.02%) to 95.163% when pulling 
**8362e24c2edd5a7cb88fd9b74c71475462e2fb64 on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-27 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13919900/badge)](https://coveralls.io/builds/13919900)

Coverage decreased (-0.02%) to 95.163% when pulling 
**8362e24c2edd5a7cb88fd9b74c71475462e2fb64 on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-23 Thread michaelsavich 
Github user michaelsavich commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Ah, gotcha. That makes sense.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-23 Thread jodastephen 
Github user jodastephen commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@michaelsavich , this PR does not create a full dependency on 
`java.desktop`. The dependency is expressed as `requires static`, which means 
that it will not be pulled in by default. Users that want to use the two broken 
classes on Java 9 in module mode (a very small percentage of commons-lang 
users) will need to manually include the `java.desktop` dependency. As such, 
there is no urgency to get `AbstractCircuitBreaker` removed.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-22 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@michaelsavich I have a proposal in a branch, submitted some months ago 
https://github.com/apache/commons-lang/pull/275

Waiting for feedback to prepare deprecated annotations in place, and merge 
in a major release (I believe it breaks BC)


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-22 Thread michaelsavich 
Github user michaelsavich commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Is there any way to rewrite AbstractCircuitBreaker to eliminate the 
dependency on java.desktop? Java.desktop is quite a large dependency to have 
for the sake of one class.


---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-18 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13771842/badge)](https://coveralls.io/builds/13771842)

Coverage increased (+0.01%) to 95.199% when pulling 
**886b26aa09efc1a4bfca3470e33b952399f18f6d on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-18 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13771246/badge)](https://coveralls.io/builds/13771246)

Coverage increased (+0.01%) to 95.199% when pulling 
**07c0c408e72836231ef262f565761778e3e9e103 on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-17 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/299
  

[![Coverage 
Status](https://coveralls.io/builds/13758874/badge)](https://coveralls.io/builds/13758874)

Coverage increased (+0.01%) to 95.199% when pulling 
**cb5a17949bf941118a80ef05ccd5a77717779792 on jodastephen:module-info** into 
**1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---

[GitHub] commons-lang issue #299: Add module-info for Java 9

2017-10-10 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
Awesome! Would be create if you could create and reference a JIRA ticket as 
described in CONTRIBUTING.md, so this will show up in our release notes.


---