[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-26 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Thank you for taking your time to submit the pull request, and for closing 
it now :-) 


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-26 Thread dieb 
Github user dieb commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Thanks @kinow !


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Merge request merged in 7d061e33e59e23dc4b03378f35f50a7d70f033b3. Alas, I 
forgot to amend the commit to include the alias to close this pull request 
automatically.

@dieb could you close it, please?

Thanks!


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-25 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Ticket created in JIRA https://issues.apache.org/jira/browse/LANG-1370


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
I'll leave the ticket open for a while other to be able to review it too. 
And before merging I'll have to create a place holder ticket in JIRA. Or if you 
have time and would like to do that :-) otherwise I'll do as it takes just a 
couple of minutes to create and link to this PR.


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread dieb 
Github user dieb commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Should be good now. Thanks!


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/309
  

[![Coverage 
Status](https://coveralls.io/builds/14330917/badge)](https://coveralls.io/builds/14330917)

Coverage remained the same at 95.168% when pulling 
**835432cec0687668abe8aedf186e99e414dc20e3 on 
dieb:dieb/fix-count-cb-bigger-increment** into 
**6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.



---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread dieb 
Github user dieb commented on the issue:

https://github.com/apache/commons-lang/pull/309
  
Hey @kinow, thank you for reviewing. Can you hold it off for a moment? Just 
realized the javadoc is incomplete, updating it right now.


---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/309
  

[![Coverage 
Status](https://coveralls.io/builds/14329426/badge)](https://coveralls.io/builds/14329426)

Coverage remained the same at 95.168% when pulling 
**f00803140ee53875da470a2ffaf5928d66f3f1fb on 
dieb:dieb/fix-count-cb-bigger-increment** into 
**6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.



---

[GitHub] commons-lang issue #309: Fix EventCountCircuitBreaker increment batch

2017-11-22 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/309
  

[![Coverage 
Status](https://coveralls.io/builds/14329343/badge)](https://coveralls.io/builds/14329343)

Coverage remained the same at 95.168% when pulling 
**f9a4bef179887b032c9338af42ea697f457d4e14 on 
dieb:dieb/fix-count-cb-bigger-increment** into 
**6049e77fdcd021544a60651fc6de4d80e2ef1c2d on apache:master**.



---