[GitHub] commons-lang issue #318: clean code

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/commons-lang/pull/318
  
@JiangYongKang, thanks for your contribution.

Even though the behaviour is the same, in my opinion, the other code is 
easier to read, and fewer code doesn't necessarily mean better or more clean 
code.

Checking if a number if even or odd, for example, can be done with bit 
operation, or with a `if/else`. While the former is shorter, not all developers 
immediately understand it, nor know how to maintain/change it.


---

[GitHub] commons-lang issue #318: clean code

[JiangYongKang]

Github user JiangYongKang commented on the issue:

https://github.com/apache/commons-lang/pull/318
  
@stokito thinks


---

[GitHub] commons-lang issue #318: clean code

[stokito]

Github user stokito commented on the issue:

https://github.com/apache/commons-lang/pull/318
  
Changes are ok


---

[GitHub] commons-lang issue #318: clean code

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/318
  

[![Coverage 
Status](https://coveralls.io/builds/15755250/badge)](https://coveralls.io/builds/15755250)

Coverage decreased (-0.01%) to 95.249% when pulling 
**0580fe794d27bfaccb0bd0159b2e633a9fc32384 on JiangYongKang:master** into 
**415eb9ebb755cea4753d6191b166b88192de5b41 on apache:master**.



---