[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/325 Thanks! ð ---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/325 Your proposal is fine, my suggestion currently falls in the YAGNI category. ---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Github user jeffnelson commented on the issue: https://github.com/apache/commons-lang/pull/325 @garydgregory - if you want me to refactor as such, I can. But I modeled the implementations of these 2 new methods after the existing `ObjectUtils.firstNonNull(Object T ... values)` https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/ObjectUtils.java#L125-L134 What I've submitted so far seemed like an obvious implementation choice since it is consistent with other similar existing code. ---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/325 Thank you for your PR. It feels to me like this new API should be built on top of a more generate "getting Nth non empty or non blank value" ---
[GitHub] commons-lang issue #325: LANG-1392 methods for getting first non empty or no...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/325 [](https://coveralls.io/builds/16623905) Coverage decreased (-0.01%) to 95.131% when pulling **40ed18e6065811af60125257fa5c8d3b7208aff8 on jeffnelson:first-non-empty-blank-string-utils** into **8e3ec1722bc5c70ea932b13ec1b564950c623e77 on apache:master**. ---
