[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread printfcoder
Github user printfcoder commented on the issue:

https://github.com/apache/commons-lang/pull/327
  
@fedochet Oh ! base on your explaining, it is ok. But the param `startPos ` 
means `start`, I’m totally confused, I think it should be renamed as 
`endPos`, aHa ?.


---


[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread fedochet
Github user fedochet commented on the issue:

https://github.com/apache/commons-lang/pull/327
  
@printfcoder according to 
[docs](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html),
 
```
(lastIndexOf) Returns the index within seq of the last occurrence 
of the specified character, searching backward starting 
at the specified index. 
```
So `b` will be searched in range of positions `[0, 1]`, and there's no `b`s 
in there


---


[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-06-08 Thread printfcoder
Github user printfcoder commented on the issue:

https://github.com/apache/commons-lang/pull/327
  
 `StringUtils.lastIndexOf("aabaabaa", "b", 1)  = -1`

Could you please explain why the result is `1`,please? I see it shoud be 2, 
because that `to search starts at 1 position and b is at 2 idx`.


---


[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-04-29 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/327
  
Thanks! 👍 


---


[GitHub] commons-lang issue #327: (doc) Remove invalid example of `lastIndexOf` from ...

2018-04-28 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/327
  

[![Coverage 
Status](https://coveralls.io/builds/16746292/badge)](https://coveralls.io/builds/16746292)

Coverage remained the same at 95.14% when pulling 
**5c570fba5d4e4e1bece48c14b516ccff6f045a26 on fedochet:patch-2** into 
**38cf0c68d577b46b506f75d896cbb5a4b186c6a6 on apache:master**.



---