[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter

2018-10-10 Thread PascalSchumacher 
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/374
  
Thanks! 👍 


---

[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter

2018-10-10 Thread mureinik 
Github user mureinik commented on the issue:

https://github.com/apache/commons-lang/pull/374
  
Updated the patch to fix the scoping issue in `pom.xml` @PascalSchumacher 
commented about.


---

[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter

2018-10-09 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/374
  

[![Coverage 
Status](https://coveralls.io/builds/19434867/badge)](https://coveralls.io/builds/19434867)

Coverage remained the same at 95.253% when pulling 
**74a18ce4c6ff7e7f5db9ed788d5f4999f7213cfe on mureinik:junit-jupiter-time** 
into **94beded83960af2a15992f6cec8f1f59d1f3c051 on apache:master**.



---

[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter

2018-10-09 Thread mureinik 
Github user mureinik commented on the issue:

https://github.com/apache/commons-lang/pull/374
  
@britter I was half way through rewriting the `SystemDefaultsSwitch` as a 
JUnit Jupiter extension when I remembered your tweet from earlier this month 
and figured out that you already did this work in JUnit Pioneer. I hope I'm not 
stepping on any toes here, but if this conflicts with anything you had planned, 
I'd gladly abandon this PR.


---