[GitHub] commons-lang issue #376: Test cleanup

2018-10-13 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/376
  
Thanks! 👍 


---


[GitHub] commons-lang issue #376: Test cleanup

2018-10-13 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/376
  

[![Coverage 
Status](https://coveralls.io/builds/19506146/badge)](https://coveralls.io/builds/19506146)

Coverage decreased (-0.02%) to 95.233% when pulling 
**142a40b9188b3710a4a15298f82460ab51bc90dd on mureinik:test-cleanup** into 
**46ea7e5e963b09b63d6a54cddd7fe391d0d5b6f4 on apache:master**.



---


[GitHub] commons-lang issue #376: Test cleanup

2018-10-13 Thread mureinik
Github user mureinik commented on the issue:

https://github.com/apache/commons-lang/pull/376
  
> Looks great, thank you very much! 👍
> 
> There are just some checkstyle errors related to unused imports left to 
fix (see failed travis build).

Missed a couple of unused import statements after I cleaned up the usages 
of `assertTrue` and `assertFalse`. I removed them, and the build should pass 
now.


---


[GitHub] commons-lang issue #376: Test cleanup

2018-10-13 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/376
  
Looks great, thank you very much! 👍 

There are just some checkstyle errors related to unused imports left to fix 
(see failed travis build).


---