[GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...

[PascalSchumacher]

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/261#discussion_r112563123
  
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String 
className, final int len) {
 }
 
 /**
+ * Gets a combination of {@link #getAllSuperclasses}(Class)} and
+ * {@link #getAllInterfaces}(Class)}, one from superclasses, one
+ * from interfaces, and so on in a breadth first way.
+ *
+ * @param cls  the class to look up, may be {@code null}
+ * @return the {@code List} of superclasses in order going up from 
this one
--- End diff --

This should also mention Interfaces.

Can you add a since tag to this method?

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...

[yasserzamani]

GitHub user yasserzamani opened a pull request:

https://github.com/apache/commons-lang/pull/261

LANG-1317: Add findAnnotation and findMethodsWithAnnotation

In order to fix [WW-4744](https://issues.apache.org/jira/browse/WW-4744) ,

findAnnotation will be an extension for Method.getAnnotation that also 
searches interfaces and super classes.

findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
that also supports non public methods, super class and interface methods.

NOTES:
To keep changes simple, currently no cache provided. Let's do that when 
needed 😃 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yasserzamani/commons-lang LANG-1317

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 74241a7cd79f2dda723f07948c7925f9b6511989
Author: Yasser Zamani 
Date:   2017-03-25T21:19:46Z

LANG-1317: Add findAnnotation and findMethodsWithAnnotation to MethodUtils




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---