Re: [PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
educhastenier commented on PR #351: URL: https://github.com/apache/commons-dbcp/pull/351#issuecomment-1966207854 > -1 this will break binary compatibility. > > This type of worked is planned but will be done very differently: we will split the project into a multi-module project to allow support for both javax and Jakarta. But we might complete the pool2 to 3 work first. Ok, I understand. I definitely should have read the discussion before starting coding . Thx for the feedbacks. Closing this PR, then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
educhastenier closed pull request #351: chore(javax2jakarta): update transaction api to jakarta URL: https://github.com/apache/commons-dbcp/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
garydgregory commented on PR #351: URL: https://github.com/apache/commons-dbcp/pull/351#issuecomment-1955780903 -1 this will break binary compatibility. This type of worked is planned but will be done very differently: we will split the project into a multi-module project to allow support for both javax and Jakarta. But we might complete the pool2 to 3 work first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
educhastenier commented on code in PR #351: URL: https://github.com/apache/commons-dbcp/pull/351#discussion_r1496642412 ## pom.xml: ## @@ -319,7 +315,7 @@ 12310469 2.12.0 - javax.transaction;version="1.1.0",javax.transaction.xa;version="1.1.0";partial=true;mandatory:=partial,* + jakarta.transaction;version="2.0.1",javax.transaction.xa;version="1.1.0";partial=true;mandatory:=partial,* Review Comment: I am not sure how this osgi stuff works, so maybe there is something more to change here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
educhastenier commented on code in PR #351: URL: https://github.com/apache/commons-dbcp/pull/351#discussion_r1496641615 ## pom.xml: ## @@ -239,19 +239,15 @@ - org.apache.geronimo.modules + org.apache.geronimo.components geronimo-transaction - 2.2.1 + 4.0.0 test org.junit.jupiter junit-jupiter - - commons-logging - commons-logging - Review Comment: This module is not a dependency of geronimo-transaction anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(javax2jakarta): update transaction api to jakarta [commons-dbcp]
educhastenier opened a new pull request, #351: URL: https://github.com/apache/commons-dbcp/pull/351 Update jakarta.transaction:jakarta.transaction-api from 1.3.1 (packages javax.) to 2.0.1 (packages jakarta.) This requires to update also: * narayana to a version using jakarta.transaction-api (for tests only) * geronimo to a version using jakarta.transaction-api (for tests only) Those packages also needed to update the minimum java version used to 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
