[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-12-19 Thread Greg Stein (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291809#comment-16291809
 ] 

Greg Stein edited comment on RNG-37 at 12/19/17 9:48 PM:
-

GitHub user cur4so opened a pull request:

https://github.com/apache/commons-rng/pull/6

RNG-37 make KN table long

switch from into to long in auxiliary table KN calculation, plus 
calculation `uni` constant with higher precision  

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cur4so/commons-rng feature-RNG-37

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 6c3f060081e73d0d678c43396e7d82d567d25246
Author: Olga Kirillova <...>
Date:   2017-12-14T23:48:58Z

RNG-37 make KN table long





was (Author: githubbot):
GitHub user cur4so opened a pull request:

https://github.com/apache/commons-rng/pull/6

RNG-37 make KN table long

switch from into to long in auxiliary table KN calculation, plus 
calculation `uni` constant with higher precision  

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cur4so/commons-rng feature-RNG-37

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 6c3f060081e73d0d678c43396e7d82d567d25246
Author: Olga Kirillova 
Date:   2017-12-14T23:48:58Z

RNG-37 make KN table long




> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Fix For: 1.1
>
> Attachments: ziggurat.buggy.png
>
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-12-17 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294427#comment-16294427
 ] 

OlgaK edited comment on RNG-37 at 12/18/17 4:33 AM:


[~erans] I'm sorry I can't help you with this, I've too many higher priority 
tasks on my plate. I'm signing out of this topic.
I already regret of my 1st reply in this topic, at that time I didn't know who 
you are, well ... lesson learned ... 


was (Author: cur4so):
[~erans] I'm sorry I can't help you with this, I've too many higher priority 
tasks on my plate. I'm signing out of this topic.

> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Fix For: 1.1
>
> Attachments: ziggurat.buggy.png
>
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-10 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
 ] 

OlgaK edited comment on RNG-37 at 10/10/17 11:28 PM:
-

Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 * branchHEAD   -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`



was (Author: cur4so):
Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-10 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
 ] 

OlgaK edited comment on RNG-37 at 10/10/17 11:28 PM:
-

Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
{noformat}
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.
{noformat}
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`



was (Author: cur4so):
Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
```
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.
```
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-10 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
 ] 

OlgaK edited comment on RNG-37 at 10/10/17 11:26 PM:
-

Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
```
git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.
```
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`



was (Author: cur4so):
Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
```git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.```
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-10 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199556#comment-16199556
 ] 

OlgaK edited comment on RNG-37 at 10/10/17 11:25 PM:
-

Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
```git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 \* branchHEAD   -> FETCH_HEAD
Already up-to-date.```
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`



was (Author: cur4so):
Gilles, are you trying to pull it from 
https://github.com/apache/commons-rng/pull/5 (this is the last one)? In my case 
it works smoothly, no conflicts
```git pull https://github.com/cur4so/commons-rng.git
>From https://github.com/cur4so/commons-rng
 * branchHEAD   -> FETCH_HEAD
Already up-to-date.```
and on the github site it points that there are no conflicts. 
I've changed `fixes` on `Javadoc`


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-08 Thread Bruno P. Kinoshita (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196425#comment-16196425
 ] 

Bruno P. Kinoshita edited comment on RNG-37 at 10/9/17 1:23 AM:


Hi [~cur4so]

>but it's almost a week has past. Any updates? 

As the project is maintained by volunteers, it is normal that some issues have 
a long delay to have a response. This delay may be hours, days, weeks, or 
months. Depends mostly on the schedule of each volunteer.

I was on vacation with limited Internet for the past three and half weeks, 
coming back today, and first reviewing things at $work, then seeing 
family/friends, re-organizing life, and only then going to have fun again as a 
volunteer with Open Source.

So don't feel bad to bump issues if there's no activity, but don't expect a 
response as fast as in projects where we have a maintainer being paid to work 
and reply on issues :-)

[~erans] has managed most issues in math and rng, so he can get quite busy when 
working on OSS and ASF. I will try to help reviewing the pull request this 
week, but without spending much time on the actual implementation as I'm not 
familiar with the algorithm or its use cases. I will look at the points Giles 
pointed before, and the normal ASF standards (test regressions, code style, 
etc).

Cheers
Bruno


was (Author: kinow):
Hi [~cur4so]

>but it's almost a week has past. Any updates? 

As the project is maintained by volunteers, it is normal that some issues have 
a long delay to have a response. This delay may be hours, days, weeks, or 
months. Depends mostly on the schedule of each volunteer.

I was on vacation with limited Internet for the past three and half weeks, 
coming back today, and first reviewing things at $work, then seeing 
family/friends, re-organizing life, and only then going to have fun again as a 
volunteer with Open Source.

So don't feel bad to bump issues if there's no activity, but don't expect a 
response as fast as in projects where we have a maintainer being paid to work 
and reply on issues :-)

[~erans] has managed most issues in math and rng. I will try to review the pull 
request this week, but without spending much time on the actual implementation 
as I'm not familiar with the algorithm or its use cases. I will look at the 
points Giles pointed before, and the normal ASF standards (test regressions, 
code style, etc).

Cheers
Bruno

> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-02 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189108#comment-16189108
 ] 

OlgaK edited comment on RNG-37 at 10/3/17 12:38 AM:


[~erans], [~eyal] and others, here is a [pull 
request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm 
implementation. I can't commit to apache-commons, therefore I've made a mirror 
in my github account. Let me know if you have any questions.



was (Author: cur4so):
[~erans] and others, here is a [pull 
request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm 
implementation. I can't commit to apache-commons, therefore I've made a mirror 
in my github account. Let me know if you have any questions.


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (RNG-37) Ziggurat algorithm

2017-10-02 Thread OlgaK (JIRA) 

[ 
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189108#comment-16189108
 ] 

OlgaK edited comment on RNG-37 at 10/3/17 12:28 AM:


[~erans] and others, here is a [pull 
request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm 
implementation. I can't commit to apache-commons, therefore I've made a mirror 
in my github account. Let me know if you have any questions.



was (Author: cur4so):
[~webcomponents] and others, here is a [pull 
request|https://github.com/cur4so/apache/pull/1] with Ziggurat algorithm 
implementation. I can't commit to apache-commons, therefore I've made a mirror 
in my github account. Let me know if you have any questions.


> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
>  Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution: 
> https://en.wikipedia.org/wiki/Ziggurat_algorithm



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)