[jira] [Commented] (CODEC-240) Support Percent-Encoding (described in RFC3986 and RFC7578)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CODEC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241782#comment-16241782
 ] 

ASF GitHub Bot commented on CODEC-240:
--

GitHub user sermojohn opened a pull request:

https://github.com/apache/commons-codec/pull/11

CODEC-240 Percent-Encoding codec proposal

@garydgregory thank you for the advice, I really appreciate your feedback.

Re-based from trunk, so had to delete and recreate the feature branch, 
which resulted in closing the initial PR. Please let me know if another process 
should be followed when merging changes from the trunk.

The changes of the last commit increase of test coverage and decrease 
slightly the complexity. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sermojohn/commons-codec CODEC-240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-codec/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 33aaa7a44a17b674a4bd4ebc3fd163afb7666815
Author: Ioannis Sermetziadis 
Date:   2017-10-02T19:34:52Z

CODEC-240 Percent-Encoding codec proposal. Due to the requirement of 
supporting a dynamic set of characters to always encode (apart from the 
non-ASCII that are always encoded), I added a constructor that takes an array 
of characters to force encode. This is useful because different encoding 
requirements apply in different parts of the HTTP 1.1 protocol (e.g. for URL, 
Multipart entity fields, etc.)

commit 67f97973a9442a98f96a2c420e976cbe7c35ecb1
Author: Ioannis Sermetziadis 
Date:   2017-10-13T20:23:10Z

CODEC-240 Refactored PercentCodec to optimize encoding and decoding in 
regard to performance. Also implemented support for space to '+' conversion.

commit f4a04da253fdf659389e4cb2163b53d695129d68
Author: Ioannis Sermetziadis 
Date:   2017-11-07T09:49:09Z

CODEC-240 Increased test coverage and did minor modification to decrease 
complexity.




> Support Percent-Encoding (described in RFC3986 and RFC7578)
> ---
>
> Key: CODEC-240
> URL: https://issues.apache.org/jira/browse/CODEC-240
> Project: Commons Codec
>  Issue Type: New Feature
>Reporter: Ioannis Sermetziadis
>Priority: Minor
>
> Similar but more generic than the URLCodec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CODEC-240) Support Percent-Encoding (described in RFC3986 and RFC7578)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CODEC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241754#comment-16241754
 ] 

ASF GitHub Bot commented on CODEC-240:
--

Github user sermojohn closed the pull request at:

https://github.com/apache/commons-codec/pull/9


> Support Percent-Encoding (described in RFC3986 and RFC7578)
> ---
>
> Key: CODEC-240
> URL: https://issues.apache.org/jira/browse/CODEC-240
> Project: Commons Codec
>  Issue Type: New Feature
>Reporter: Ioannis Sermetziadis
>Priority: Minor
>
> Similar but more generic than the URLCodec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CODEC-240) Support Percent-Encoding (described in RFC3986 and RFC7578)

[Ioannis Sermetziadis (JIRA)]

[ 
https://issues.apache.org/jira/browse/CODEC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240223#comment-16240223
 ] 

Ioannis Sermetziadis commented on CODEC-240:


Could someone review this pull-request? Thank you.

> Support Percent-Encoding (described in RFC3986 and RFC7578)
> ---
>
> Key: CODEC-240
> URL: https://issues.apache.org/jira/browse/CODEC-240
> Project: Commons Codec
>  Issue Type: New Feature
>Reporter: Ioannis Sermetziadis
>Priority: Minor
>
> Similar but more generic than the URLCodec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CODEC-240) Support Percent-Encoding (described in RFC3986 and RFC7578)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CODEC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188691#comment-16188691
 ] 

ASF GitHub Bot commented on CODEC-240:
--

GitHub user sermojohn opened a pull request:

https://github.com/apache/commons-codec/pull/9

CODEC-240 Percent-Encoding codec proposal



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sermojohn/commons-codec CODEC-240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-codec/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit cdde0085266245dacbe66ed42dab3c4604069012
Author: Ioannis Sermetziadis 
Date:   2017-10-02T19:34:52Z

CODEC-240 Percent-Encoding codec proposal. Due to the requirement of 
supporting a dynamic set of characters to always encode (apart from the 
non-ASCII that are always encoded), I added a constructor that takes an array 
of characters to force encode. This is useful because different encoding 
requirements apply in different parts of the HTTP 1.1 protocol (e.g. for URL, 
Multipart entity fields, etc.)




> Support Percent-Encoding (described in RFC3986 and RFC7578)
> ---
>
> Key: CODEC-240
> URL: https://issues.apache.org/jira/browse/CODEC-240
> Project: Commons Codec
>  Issue Type: New Feature
>Reporter: Ioannis Sermetziadis
>Priority: Minor
>
> Similar but more generic than the URLCodec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)