[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238848#comment-13238848
 ] 

Emmanuel Bourg commented on CSV-83:
---

For what concrete purpose would this be useful?

 Provide a header encapsulator class
 ---

 Key: CSV-83
 URL: https://issues.apache.org/jira/browse/CSV-83
 Project: Commons CSV
  Issue Type: Improvement
Reporter: Sebb

 Might be useful to have a class to encapsulate the headers, rather than 
 assuming they are stored as a map.
 This would allow more a more flexible implementation if required.
 Methods which it would be useful to have:
 - getIndex(name) - could return -1 for unknown name?
 - iterator()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Sebb (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238876#comment-13238876
 ] 

Sebb commented on CSV-83:
-

bq. This would allow more a more flexible implementation if required.

 Provide a header encapsulator class
 ---

 Key: CSV-83
 URL: https://issues.apache.org/jira/browse/CSV-83
 Project: Commons CSV
  Issue Type: Improvement
Reporter: Sebb

 Might be useful to have a class to encapsulate the headers, rather than 
 assuming they are stored as a map.
 This would allow more a more flexible implementation if required.
 Methods which it would be useful to have:
 - getIndex(name) - could return -1 for unknown name?
 - iterator()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Emmanuel Bourg (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238966#comment-13238966
 ] 

Emmanuel Bourg commented on CSV-83:
---

Sorry but without a real use case this tends to light up the overengineered 
warning in my mind.

Would this affect the public API?

 Provide a header encapsulator class
 ---

 Key: CSV-83
 URL: https://issues.apache.org/jira/browse/CSV-83
 Project: Commons CSV
  Issue Type: Improvement
Reporter: Sebb

 Might be useful to have a class to encapsulate the headers, rather than 
 assuming they are stored as a map.
 This would allow more a more flexible implementation if required.
 Methods which it would be useful to have:
 - getIndex(name) - could return -1 for unknown name?
 - iterator()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Sebb (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239032#comment-13239032
 ] 

Sebb commented on CSV-83:
-

It looks as though the header Map is not part of the public API.
If that is the case then using a separate encapsulator class is not necessary.
We could change the headers to be (e.g.) a sorted list - if that were more 
efficient - without affecting the API.

It's not good to over-engineer, but IMO it's worse to expose internal 
implementation details in the public API, which is why I raised the issue 
initially.

 Provide a header encapsulator class
 ---

 Key: CSV-83
 URL: https://issues.apache.org/jira/browse/CSV-83
 Project: Commons CSV
  Issue Type: Improvement
Reporter: Sebb

 Might be useful to have a class to encapsulate the headers, rather than 
 assuming they are stored as a map.
 This would allow more a more flexible implementation if required.
 Methods which it would be useful to have:
 - getIndex(name) - could return -1 for unknown name?
 - iterator()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira