[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2016-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15600293#comment-15600293
 ] 

ASF GitHub Bot commented on LANG-1143:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/201
  

[![Coverage 
Status](https://coveralls.io/builds/8468379/badge)](https://coveralls.io/builds/8468379)

Coverage increased (+0.0002%) to 93.541% when pulling 
**f2726339e75dc94f3a11b3797a0162c24cd8bd5e on PascalSchumacher:LANG-1143** into 
**383bc8eefae7e17d0bb0349ab2300488c655ec42 on apache:master**.



> StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
> ---
>
> Key: LANG-1143
> URL: https://issues.apache.org/jira/browse/LANG-1143
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Sebb
> Fix For: Review Patch
>
> Attachments: LANG-1143.patch
>
>
> The Javadoc for Character#toTitleCase(char) recommends using 
> Character#toTitleCase(int) instead. This method was added in Java 1.5 which 
> is perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2016-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1550#comment-1550
 ] 

ASF GitHub Bot commented on LANG-1143:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/201
  

[![Coverage 
Status](https://coveralls.io/builds/8467115/badge)](https://coveralls.io/builds/8467115)

Coverage increased (+0.02%) to 93.57% when pulling 
**fc0f62597b8f0284413ea35c1d958e30fe20392f on PascalSchumacher:LANG-1143** into 
**65ed41ff7a8cfb0bbc03620e186382a16e23db56 on apache:master**.



> StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
> ---
>
> Key: LANG-1143
> URL: https://issues.apache.org/jira/browse/LANG-1143
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Sebb
> Fix For: Review Patch
>
> Attachments: LANG-1143.patch
>
>
> The Javadoc for Character#toTitleCase(char) recommends using 
> Character#toTitleCase(int) instead. This method was added in Java 1.5 which 
> is perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2016-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15599983#comment-15599983
 ] 

ASF GitHub Bot commented on LANG-1143:
--

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-lang/pull/201

LANG-1143: StringUtils should use toXxxxCase(int) rather than toXxxxC…

…ase(char)

based on patch by Sebb

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-lang LANG-1143

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #201


commit fc0f62597b8f0284413ea35c1d958e30fe20392f
Author: pascalschumacher 
Date:   2016-10-23T17:07:04Z

LANG-1143: StringUtils should use toXxxxCase(int) rather than 
toXxxxCase(char)

based on patch by Sebb




> StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
> ---
>
> Key: LANG-1143
> URL: https://issues.apache.org/jira/browse/LANG-1143
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Sebb
> Fix For: Review Patch
>
> Attachments: LANG-1143.patch
>
>
> The Javadoc for Character#toTitleCase(char) recommends using 
> Character#toTitleCase(int) instead. This method was added in Java 1.5 which 
> is perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2015-07-23 Thread Henri Yandell (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639758#comment-14639758
 ] 

Henri Yandell commented on LANG-1143:
-

Same style of change needs to be applied to uncapitalize and I guess to 
swapCase (though I wonder how useful swapCase really is as a function). 

Note javadoc also needs changing for capitalize as it refers to 
toTitleCase(char).

 StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
 ---

 Key: LANG-1143
 URL: https://issues.apache.org/jira/browse/LANG-1143
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.*
Reporter: Sebb
 Fix For: 3.5

 Attachments: LANG-1143.patch


 The Javadoc for Character#toTitleCase(char) recommends using 
 Character#toTitleCase(int) instead. This method was added in Java 1.5 which 
 is perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2015-07-19 Thread Henri Yandell (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632739#comment-14632739
 ] 

Henri Yandell commented on LANG-1143:
-

Seems fair.

Started to poke on this, but means we need a getCodePoints(int, int, int[], 
int) to replace getChars(int, int, char[], int). Which appears to be in Java 8 
(CharSequence.codepoints();IntStream). 

 StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
 ---

 Key: LANG-1143
 URL: https://issues.apache.org/jira/browse/LANG-1143
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.*
Reporter: Sebb

 The Javadoc for String#toTitleCase(char) recommends using 
 String#toTitleCase(int) instead. This method was added in Java 1.5 which is 
 perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1143) StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)

2015-07-19 Thread Henri Yandell (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632867#comment-14632867
 ] 

Henri Yandell commented on LANG-1143:
-

Looks good to me. Passes tests. 

 StringUtils should use toXxxxCase(int) rather than toXxxxCase(char)
 ---

 Key: LANG-1143
 URL: https://issues.apache.org/jira/browse/LANG-1143
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.*
Reporter: Sebb
 Fix For: 3.5

 Attachments: LANG-1143.patch


 The Javadoc for Character#toTitleCase(char) recommends using 
 Character#toTitleCase(int) instead. This method was added in Java 1.5 which 
 is perhaps is why it was not used originally; maybe we should use it now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)