[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453767#comment-13453767 ] Henri Yandell commented on LANG-777: Noticing we have two release-notes.vm files since r1342642. Not sure what the plan is. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build Fix For: 3.2 The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221899#comment-13221899 ] Thomas Neidhart commented on LANG-777: -- The parent pom version 23 defines as default location for the release-notes template: src/changes/release-notes.vm src/changes/changes.xml So the templates can not slip into the resulting jar. CM3 for example already follows this scheme. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156617#comment-13156617 ] Sebb commented on LANG-777: --- The file changes.xml is used to create the changes-report.html file, so needs to be kept up to date anyway. Using the same file for the release notes means that they are consistent. Note: one can select the required version for the release notes as follows: mvn changes:announcement-generate -Dchanges.version=3.1 This overrides the default, which is taken from the POM version. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156914#comment-13156914 ] Henri Yandell commented on LANG-777: Seems much simpler to edit changes.xml and then copy to the release notes before release. The template approach sounds overly complex. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156919#comment-13156919 ] Sebb commented on LANG-777: --- You don't often need to edit the template, especially now it does not have a fixed version in it. Mostly you only need to edit changes.xml and then run mvn changes:announcement-generate -Dchanges.version=x.x Check that the new file looks OK, and check it in. That's it. Try it and see. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156549#comment-13156549 ] Henri Yandell commented on LANG-777: Yeah, I forgot all about the template. It was so simple to write the release notes by hand (changes.xml, then update release notes). Is there any value in the velocity approach? I know I added it back in August but I've no idea why. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155054#comment-13155054 ] Sebb commented on LANG-777: --- It looks like the RM used a different method for generating the release notes Ideally the .vm file is updated, and and then can run mvn changes:announcement-generate mv target/announcement/RELEASE-NOTES.txt RELEASE-NOTES.txt Commons Parent 22 has a profile for this: mvn changes:announcement-generate -Prelease-notes but this requires the vm file to be located under src/changes rather than arc/main/resources/templates OK to move the file accordingly? jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LANG-777) jar contains velocity template of release notes
[ https://issues.apache.org/jira/browse/LANG-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155088#comment-13155088 ] Sebb commented on LANG-777: --- Alternatively, I suppose one could override the CP release-notes profile to fix the location. jar contains velocity template of release notes --- Key: LANG-777 URL: https://issues.apache.org/jira/browse/LANG-777 Project: Commons Lang Issue Type: Bug Components: General Affects Versions: 3.1 Reporter: Joerg Schaible Priority: Trivial Labels: build The released Java archive of 3.1 contains the velocity template release-notes.vm (claiming to be for 3.0.1 anyway) in the Java package templates. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
