[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-11-16 Thread Vamsi Pavan Kumar Sanka (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444742#comment-17444742
 ] 

Vamsi Pavan Kumar Sanka commented on POOL-394:
--

added test case to PR. Thanks.

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-11-15 Thread Vamsi Pavan Kumar Sanka (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443810#comment-17443810
 ] 

Vamsi Pavan Kumar Sanka commented on POOL-394:
--

[https://github.com/paonethestar/commons-pool/pull/1]  PR created.

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-11-13 Thread Gary D. Gregory (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443187#comment-17443187
 ] 

Gary D. Gregory commented on POOL-394:
--

I am happy to review a PR, with tests ;)

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-11-13 Thread Phil Steitz (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443182#comment-17443182
 ] 

Phil Steitz commented on POOL-394:
--

I have not run into this requirement in my own apps, but I can see how it would 
be convenient for users.  It is in fact already indirectly available via 
``listAllObjects.getKeys()``.   I see no reason not to expose it directly with 
the same semantics / disclaimer - you get a copy that does not necessarily 
represent a valid snapshot at any point in time.

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-04-06 Thread Mark Thomas (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315327#comment-17315327
 ] 

Mark Thomas commented on POOL-394:
--

What are the use cases for getKeys() ?

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (POOL-394) GenericKeyedObjectPool doesn't have getKeys() implemented

2021-04-05 Thread Gary D. Gregory (Jira)


[ 
https://issues.apache.org/jira/browse/POOL-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314819#comment-17314819
 ] 

Gary D. Gregory commented on POOL-394:
--

You should really consider using the current version 2.9.0, we can't do 
anything to update old versions, but we can address issues in upcoming versions.

> GenericKeyedObjectPool doesn't have getKeys() implemented
> -
>
> Key: POOL-394
> URL: https://issues.apache.org/jira/browse/POOL-394
> Project: Commons Pool
>  Issue Type: Bug
>Affects Versions: 2.4.2
>Reporter: Vamsi Pavan Kumar Sanka
>Priority: Major
>
> getKeys() not really implemented as specified here:
> [https://commons.apache.org/proper/commons-pool2/apidocs/org/apache/commons/pool2/impl/GenericKeyedObjectPool.html#getKeys(])
> This API is needed in various scenarios. Current Jira is to expose this API. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)