[jira] Commented: (CODEC-81) Base64's new constructor parameters ignored

2009-07-26 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735485#action_12735485
 ] 

Gary Gregory commented on CODEC-81:
---

The patch line:

desiredResult = desiredResult.replace("=", ""); // url-safe has no == padding.

uses a Java 1.5 String API, we are not on 1.5 yet, but we just moved to 1.4. 

Can you please re-patch? 

Thank you.

> Base64's new constructor parameters ignored
> ---
>
> Key: CODEC-81
> URL: https://issues.apache.org/jira/browse/CODEC-81
> Project: Commons Codec
>  Issue Type: Bug
>Affects Versions: 1.4
>Reporter: Julius Davies
>Priority: Trivial
> Fix For: 1.4
>
> Attachments: codec81-fix.patch, codec81-junit.patch
>
>
> Base64's new constructor parameters are ignored (e.g. chunkSize and 
> chunkSeparator) when using the Encoder interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CODEC-81) Base64's new constructor parameters ignored

2009-07-26 Thread Julius Davies (JIRA)

[ 
https://issues.apache.org/jira/browse/CODEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735429#action_12735429
 ] 

Julius Davies commented on CODEC-81:


FYI:  the "codec81-fix.patch" fix moves all the logic in the two main "public 
static" methods into member methods instead.

> Base64's new constructor parameters ignored
> ---
>
> Key: CODEC-81
> URL: https://issues.apache.org/jira/browse/CODEC-81
> Project: Commons Codec
>  Issue Type: Bug
>Affects Versions: 1.4
>Reporter: Julius Davies
>Priority: Trivial
> Fix For: 1.4
>
> Attachments: codec81-fix.patch, codec81-junit.patch
>
>
> Base64's new constructor parameters are ignored (e.g. chunkSize and 
> chunkSeparator) when using the Encoder interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.