[jira] [Created] (CB-7356) mobilespec's localXHR test #6 fails on WP8
Vladimir Kotikov created CB-7356: Summary: mobilespec's localXHR test #6 fails on WP8 Key: CB-7356 URL: https://issues.apache.org/jira/browse/CB-7356 Project: Apache Cordova Issue Type: Bug Components: mobile-spec Reporter: Vladimir Kotikov -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6763) Simultaneous local XHRs on WP8 returns incorrect result
[
https://issues.apache.org/jira/browse/CB-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105236#comment-14105236
]
Vladimir Kotikov commented on CB-6763:
--
Seems that problem is it test. It changes window.location (probably, it's a bad
practice), and this cleans XHR callbacks cache, so callbacks for any pending
XHR's are never called.
I've cretaed an issue to track this:
https://issues.apache.org/jira/browse/CB-7356
Simultaneous local XHRs on WP8 returns incorrect result
---
Key: CB-6763
URL: https://issues.apache.org/jira/browse/CB-6763
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.4.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Labels: wp8, xhr, xhrhelper
When try to get content of multiple local files via XHR, all requests return
responses with same content. E.g. following code (using jQuery)
{noformat}
function loadTemplates (views) {
var deferreds = [];
$.each(views, function (index, view) {
var vURL = 'tpl/' + view + '.html';
deferreds.push($.get(vURL, function (data) {
console.log(data)
}, 'html'));
})
}
loadTemplates([HomeView, ContactView, ShellView, EmployeeView,
EmployeeSummaryView, EmployeeListItemView]);
{noformat}
will print contents of {{tpl/EmployeeListItemView.html}} 6 times.
The problem is when new local XHR is sent, it overrides
{{__onXHRLocalCallback}} callback, already created by previous request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6763) Simultaneous local XHRs on WP8 returns incorrect result
[
https://issues.apache.org/jira/browse/CB-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105237#comment-14105237
]
Vladimir Kotikov commented on CB-6763:
--
Hey, Julien. This should be released at 3.6.0, which is coming soon.
Simultaneous local XHRs on WP8 returns incorrect result
---
Key: CB-6763
URL: https://issues.apache.org/jira/browse/CB-6763
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.4.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Labels: wp8, xhr, xhrhelper
When try to get content of multiple local files via XHR, all requests return
responses with same content. E.g. following code (using jQuery)
{noformat}
function loadTemplates (views) {
var deferreds = [];
$.each(views, function (index, view) {
var vURL = 'tpl/' + view + '.html';
deferreds.push($.get(vURL, function (data) {
console.log(data)
}, 'html'));
})
}
loadTemplates([HomeView, ContactView, ShellView, EmployeeView,
EmployeeSummaryView, EmployeeListItemView]);
{noformat}
will print contents of {{tpl/EmployeeListItemView.html}} 6 times.
The problem is when new local XHR is sent, it overrides
{{__onXHRLocalCallback}} callback, already created by previous request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-7356:
-
Description:
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156 make
spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6 should
be able to load the current page with hash-part added) failing.
Seems that problem is in test itself.
{{window.location}} has been changed inside of test (probably, it's a bad
practice), and this cleans XHR callbacks cache, so callbacks for any pending
XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself.
{{window.location}} has been changed inside of test (probably, it's a bad
practice), and this cleans XHR callbacks cache, so callbacks for any pending
XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov updated CB-7356:
-
Description:
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156 make
spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6 should
be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
was:
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156 make
spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6 should
be able to load the current page with hash-part added) failing.
Seems that problem is in test itself.
{{window.location}} has been changed inside of test (probably, it's a bad
practice), and this cleans XHR callbacks cache, so callbacks for any pending
XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105246#comment-14105246
]
ASF GitHub Bot commented on CB-7356:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/104
CB-7356 Fix spec.6 failing on WP8
Fix for https://issues.apache.org/jira/browse/CB-7356
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-7356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
commit 52c7b1a551444bc2f7b7290a20b7bfa9a1f4ec77
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2014-08-21T09:13:50Z
CB-7356 Fix spec.6 failing on WP8
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6763) Simultaneous local XHRs on WP8 returns incorrect result
[
https://issues.apache.org/jira/browse/CB-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105250#comment-14105250
]
Julien Carnec commented on CB-6763:
---
Thank you Vladimir
Simultaneous local XHRs on WP8 returns incorrect result
---
Key: CB-6763
URL: https://issues.apache.org/jira/browse/CB-6763
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.4.0
Reporter: Vladimir Kotikov
Assignee: Jesse MacFadyen
Labels: wp8, xhr, xhrhelper
When try to get content of multiple local files via XHR, all requests return
responses with same content. E.g. following code (using jQuery)
{noformat}
function loadTemplates (views) {
var deferreds = [];
$.each(views, function (index, view) {
var vURL = 'tpl/' + view + '.html';
deferreds.push($.get(vURL, function (data) {
console.log(data)
}, 'html'));
})
}
loadTemplates([HomeView, ContactView, ShellView, EmployeeView,
EmployeeSummaryView, EmployeeListItemView]);
{noformat}
will print contents of {{tpl/EmployeeListItemView.html}} 6 times.
The problem is when new local XHR is sent, it overrides
{{__onXHRLocalCallback}} callback, already created by previous request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7357) Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR
Vladimir Kotikov created CB-7357: Summary: Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR Key: CB-7357 URL: https://issues.apache.org/jira/browse/CB-7357 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Environment: Windows 8.1, Windows Phone 8.1 device/emulator Reporter: Vladimir Kotikov Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR Repro steps: 1. Create mobilespec app with latest contacts plugin included 2. Run mobilespec app on wp8.1 device/emulator and navigate to New-style tests - Manual tests - contact tests. 3. Click on Get phone's contacts Expected: Contacts data shown in status box. or 'No contacts found' if no contacts exists on device Actual: 'Error 3' message shown in status box. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7357) Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR
[ https://issues.apache.org/jira/browse/CB-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105328#comment-14105328 ] ASF GitHub Bot commented on CB-7357: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/43 CB-7357 Adds missing 'capability' element to phone's appxmanifest. https://issues.apache.org/jira/browse/CB-7357 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-7357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit a18a369a327a5ffbaf402f55336eaec570c71af1 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-08-21T12:08:03Z CB-7357 Adds missing 'capability' element to phone's appxmanifest. Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR Key: CB-7357 URL: https://issues.apache.org/jira/browse/CB-7357 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Environment: Windows 8.1, Windows Phone 8.1 device/emulator Reporter: Vladimir Kotikov Labels: contacts, windows-phone-81, wp8.1 Contact plugin's find method fails on WP8.1 with PENDING_OPERATION_ERROR Repro steps: 1. Create mobilespec app with latest contacts plugin included 2. Run mobilespec app on wp8.1 device/emulator and navigate to New-style tests - Manual tests - contact tests. 3. Click on Get phone's contacts Expected: Contacts data shown in status box. or 'No contacts found' if no contacts exists on device Actual: 'Error 3' message shown in status box. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7318) platform support doc still show globalization is not supported by bb10
[ https://issues.apache.org/jira/browse/CB-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105416#comment-14105416 ] ASF GitHub Bot commented on CB-7318: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-docs/pull/228 CB-7318 platform support doc show globalization is supported by bb10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-docs cb_7318 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit 2506d4c3059083b2f197b3b041e2510cc32499b2 Author: Josh Soref jso...@blackberry.com Date: 2014-08-19T16:08:19Z CB-7318 platform support doc show globalization is supported by bb10 platform support doc still show globalization is not supported by bb10 -- Key: CB-7318 URL: https://issues.apache.org/jira/browse/CB-7318 Project: Apache Cordova Issue Type: Bug Components: Docs Affects Versions: 3.5.0 Reporter: Jenny Gee Priority: Minor http://cordova.apache.org/docs/en/edge/guide_support_index.md.html#Platform%20Support Platform support page still show that globalization is not supported by BB10. Supporting email announcement: http://cordova.apache.org/news/2014/08/11/plugins-release.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105492#comment-14105492
]
Martin Gonzalez commented on CB-7356:
-
Yes I did that yesterday, I was about to deliver the same fix.
window.location it's a read-only object, I agree try to modify its value, it's
a bad practice.
Thanks Vlad.
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7318) platform support doc still show globalization is not supported by bb10
[ https://issues.apache.org/jira/browse/CB-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105595#comment-14105595 ] ASF GitHub Bot commented on CB-7318: Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/228 platform support doc still show globalization is not supported by bb10 -- Key: CB-7318 URL: https://issues.apache.org/jira/browse/CB-7318 Project: Apache Cordova Issue Type: Bug Components: Docs Affects Versions: 3.5.0 Reporter: Jenny Gee Priority: Minor http://cordova.apache.org/docs/en/edge/guide_support_index.md.html#Platform%20Support Platform support page still show that globalization is not supported by BB10. Supporting email announcement: http://cordova.apache.org/news/2014/08/11/plugins-release.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7318) platform support doc still show globalization is not supported by bb10
[ https://issues.apache.org/jira/browse/CB-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105594#comment-14105594 ] ASF subversion and git services commented on CB-7318: - Commit 2506d4c3059083b2f197b3b041e2510cc32499b2 in cordova-docs's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=2506d4c ] CB-7318 platform support doc show globalization is supported by bb10 platform support doc still show globalization is not supported by bb10 -- Key: CB-7318 URL: https://issues.apache.org/jira/browse/CB-7318 Project: Apache Cordova Issue Type: Bug Components: Docs Affects Versions: 3.5.0 Reporter: Jenny Gee Priority: Minor http://cordova.apache.org/docs/en/edge/guide_support_index.md.html#Platform%20Support Platform support page still show that globalization is not supported by BB10. Supporting email announcement: http://cordova.apache.org/news/2014/08/11/plugins-release.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-7358) [CLI] [tests]
[
https://issues.apache.org/jira/browse/CB-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorin Beer reassigned CB-7358:
--
Assignee: Lorin Beer
[CLI] [tests]
-
Key: CB-7358
URL: https://issues.apache.org/jira/browse/CB-7358
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
Assignee: Lorin Beer
cordova-cli test suite outputs jank while running tests
jank includes multiple repetitions of the help string.
solution: mock or redirect console.log to avoid polluting output
{code}
Synopsis
cordova command [options]
Global Commands
create . Create a project
help ... Get help for a command
Project Commands
info ... Generate project information
platform ... Manage project platforms
plugin . Manage project plugins
prepare Copy files into platform(s) for
building
compile Build platform(s)
run Run project
(including prepare compile)
serve .. Run project with a local webserver
(including prepare)
aliases:
build - cordova prepare cordova compile
emulate - cordova run --emulator
Experimental Commands
These commands require the --experimental flag.
save ... Save installed platforms/plugins
restore Restore saved platforms/plugins
Command-line Flags/Options
-v, --version .. prints out this utility's version
-d, --verbose .. debug mode produces verbose log
output for all activity,
including output of sub-commands
cordova invokes
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7358) [CLI] [tests]
Lorin Beer created CB-7358:
--
Summary: [CLI] [tests]
Key: CB-7358
URL: https://issues.apache.org/jira/browse/CB-7358
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
cordova-cli test suite outputs jank while running tests
jank includes multiple repetitions of the help string.
solution: mock or redirect console.log to avoid polluting output
{code}
Synopsis
cordova command [options]
Global Commands
create . Create a project
help ... Get help for a command
Project Commands
info ... Generate project information
platform ... Manage project platforms
plugin . Manage project plugins
prepare Copy files into platform(s) for
building
compile Build platform(s)
run Run project
(including prepare compile)
serve .. Run project with a local webserver
(including prepare)
aliases:
build - cordova prepare cordova compile
emulate - cordova run --emulator
Experimental Commands
These commands require the --experimental flag.
save ... Save installed platforms/plugins
restore Restore saved platforms/plugins
Command-line Flags/Options
-v, --version .. prints out this utility's version
-d, --verbose .. debug mode produces verbose log output
for all activity,
including output of sub-commands
cordova invokes
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7358) [CLI] [tests]
[
https://issues.apache.org/jira/browse/CB-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105746#comment-14105746
]
ASF subversion and git services commented on CB-7358:
-
Commit 131123348544ec8cc2ecb8e2b8800c94cd643c75 in cordova-cli's branch
refs/heads/master from [~lorin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=1311233 ]
[CB-7358] cli spec mocks console log to avoid polluting test output while
testing
[CLI] [tests]
-
Key: CB-7358
URL: https://issues.apache.org/jira/browse/CB-7358
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
Assignee: Lorin Beer
cordova-cli test suite outputs jank while running tests
jank includes multiple repetitions of the help string.
solution: mock or redirect console.log to avoid polluting output
{code}
Synopsis
cordova command [options]
Global Commands
create . Create a project
help ... Get help for a command
Project Commands
info ... Generate project information
platform ... Manage project platforms
plugin . Manage project plugins
prepare Copy files into platform(s) for
building
compile Build platform(s)
run Run project
(including prepare compile)
serve .. Run project with a local webserver
(including prepare)
aliases:
build - cordova prepare cordova compile
emulate - cordova run --emulator
Experimental Commands
These commands require the --experimental flag.
save ... Save installed platforms/plugins
restore Restore saved platforms/plugins
Command-line Flags/Options
-v, --version .. prints out this utility's version
-d, --verbose .. debug mode produces verbose log
output for all activity,
including output of sub-commands
cordova invokes
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7250) bin/test/cordova/integration/target.js risks destroying blackberry10.json
[
https://issues.apache.org/jira/browse/CB-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105751#comment-14105751
]
ASF GitHub Bot commented on CB-7250:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/174
bin/test/cordova/integration/target.js risks destroying blackberry10.json
-
Key: CB-7250
URL: https://issues.apache.org/jira/browse/CB-7250
Project: Apache Cordova
Issue Type: Bug
Components: BlackBerry
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
I ran the test suite recently.
Unfortunately, for unknown reasons, I'm now left with:
{quote}
$ cat ~/.cordova/blackberry10.json
\{
targets: \{
z10: \{
ip: 169.254.0.1,
type: device,
password: pass,
pin: DEADBEEF
}
}
}
{quote}
Tests should not do this. They should instead change their HOME / USERPROFILE
environment variables to a directory w/in their own test directory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7250) bin/test/cordova/integration/target.js risks destroying blackberry10.json
[
https://issues.apache.org/jira/browse/CB-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105750#comment-14105750
]
ASF subversion and git services commented on CB-7250:
-
Commit faf0735070efb3cf3369c32f2b9dde732e8c4dee in cordova-blackberry's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=faf0735 ]
CB-7250 test/cordova/integration/target use private home
This prevents the test from destroying blackberry10.json
bin/test/cordova/integration/target.js risks destroying blackberry10.json
-
Key: CB-7250
URL: https://issues.apache.org/jira/browse/CB-7250
Project: Apache Cordova
Issue Type: Bug
Components: BlackBerry
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
I ran the test suite recently.
Unfortunately, for unknown reasons, I'm now left with:
{quote}
$ cat ~/.cordova/blackberry10.json
\{
targets: \{
z10: \{
ip: 169.254.0.1,
type: device,
password: pass,
pin: DEADBEEF
}
}
}
{quote}
Tests should not do this. They should instead change their HOME / USERPROFILE
environment variables to a directory w/in their own test directory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7358) [CLI] [tests] unnecessary output when running tests
[
https://issues.apache.org/jira/browse/CB-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorin Beer updated CB-7358:
---
Summary: [CLI] [tests] unnecessary output when running tests (was: [CLI]
[tests])
[CLI] [tests] unnecessary output when running tests
---
Key: CB-7358
URL: https://issues.apache.org/jira/browse/CB-7358
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
Assignee: Lorin Beer
cordova-cli test suite outputs jank while running tests
jank includes multiple repetitions of the help string.
solution: mock or redirect console.log to avoid polluting output
{code}
Synopsis
cordova command [options]
Global Commands
create . Create a project
help ... Get help for a command
Project Commands
info ... Generate project information
platform ... Manage project platforms
plugin . Manage project plugins
prepare Copy files into platform(s) for
building
compile Build platform(s)
run Run project
(including prepare compile)
serve .. Run project with a local webserver
(including prepare)
aliases:
build - cordova prepare cordova compile
emulate - cordova run --emulator
Experimental Commands
These commands require the --experimental flag.
save ... Save installed platforms/plugins
restore Restore saved platforms/plugins
Command-line Flags/Options
-v, --version .. prints out this utility's version
-d, --verbose .. debug mode produces verbose log
output for all activity,
including output of sub-commands
cordova invokes
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7210) cleanup create remove clean/copyJavascript
[
https://issues.apache.org/jira/browse/CB-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105755#comment-14105755
]
ASF subversion and git services commented on CB-7210:
-
Commit 5ca51b77066b293389fb7c189e7add86e66bdcd3 in cordova-blackberry's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=5ca51b7 ]
CB-7210 cleanup create remove clean/copyJavascript
cleanup create remove clean/copyJavascript
--
Key: CB-7210
URL: https://issues.apache.org/jira/browse/CB-7210
Project: Apache Cordova
Issue Type: Bug
Components: BlackBerry
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
I suspect that at some point the cordova.js script was built by create.
These days, it's just a file, and not particularly interesting. The current
code does a number of odd things in order to construct cordova.js.
Unfortunately, those things aren't safe for people who are running create
multiple times concurrently (either because they're using
{{jasmine-isolated.js}} or some CI which happens to like to run things
concurrently). Creating and deleting directories at fixed locations is
hazardous to such tasks.
I'd like to simplify the code...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7211) jshint: force to see all errors
[ https://issues.apache.org/jira/browse/CB-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105760#comment-14105760 ] ASF subversion and git services commented on CB-7211: - Commit 3b71bac2b5764f31870369705a210ed985ba2cd5 in cordova-blackberry's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;h=3b71bac ] CB-7211 jshint: force to see all errors jshint: force to see all errors --- Key: CB-7211 URL: https://issues.apache.org/jira/browse/CB-7211 Project: Apache Cordova Issue Type: Bug Components: BlackBerry Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Minor Sometimes jshint will not show all its warnings, I'd rather show them all by default... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7211) jshint: force to see all errors
[ https://issues.apache.org/jira/browse/CB-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105761#comment-14105761 ] ASF GitHub Bot commented on CB-7211: Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/173 jshint: force to see all errors --- Key: CB-7211 URL: https://issues.apache.org/jira/browse/CB-7211 Project: Apache Cordova Issue Type: Bug Components: BlackBerry Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Minor Sometimes jshint will not show all its warnings, I'd rather show them all by default... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7210) cleanup create remove clean/copyJavascript
[
https://issues.apache.org/jira/browse/CB-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105757#comment-14105757
]
ASF GitHub Bot commented on CB-7210:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/172
cleanup create remove clean/copyJavascript
--
Key: CB-7210
URL: https://issues.apache.org/jira/browse/CB-7210
Project: Apache Cordova
Issue Type: Bug
Components: BlackBerry
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
I suspect that at some point the cordova.js script was built by create.
These days, it's just a file, and not particularly interesting. The current
code does a number of odd things in order to construct cordova.js.
Unfortunately, those things aren't safe for people who are running create
multiple times concurrently (either because they're using
{{jasmine-isolated.js}} or some CI which happens to like to run things
concurrently). Creating and deleting directories at fixed locations is
hazardous to such tasks.
I'd like to simplify the code...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7359) Update Versioning and release policy doc
Steve Gill created CB-7359: -- Summary: Update Versioning and release policy doc Key: CB-7359 URL: https://issues.apache.org/jira/browse/CB-7359 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7355) [CLI] removing unit tests which depend on external libraries
[
https://issues.apache.org/jira/browse/CB-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105764#comment-14105764
]
ASF subversion and git services commented on CB-7355:
-
Commit a3f374b6aa36688ac2050ee8dbd876ff2f31ea95 in cordova-cli's branch
refs/heads/master from [~lorin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=a3f374b ]
[CB-7355] removed create tests which test behaviour of downstream dependencies
the test pass/fail condition relies on specific output from external libraries
(cordova-lib).
[CLI] removing unit tests which depend on external libraries
Key: CB-7355
URL: https://issues.apache.org/jira/browse/CB-7355
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Reporter: Lorin Beer
Assignee: Lorin Beer
The cordova-cli has vestigial unit tests which now trigger on external
dependencies (example below)
These should be removed from the cli, and migrated to the appropriate lib if
necessary.
{code}
-it(will NOT allow copy-from starting with 'http', function () {
-var threwAnException = false;
-try {
-cli([node, cordova, create, a, b , c,
--copy-from, http://www.somesite.com;]);
-}
-catch(e) {
-threwAnException = true;
-}
-expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only
local paths for custom www assets are supported.');
-expect(threwAnException).toBe(true);
-});
-
-it(will allow link-to with ':' char, function () {
{code}
in the example above, the behaviour is not implemented within the cordova cli
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7349) Tell users to run npm install
[ https://issues.apache.org/jira/browse/CB-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105769#comment-14105769 ] ASF GitHub Bot commented on CB-7349: Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/78 Tell users to run npm install - Key: CB-7349 URL: https://issues.apache.org/jira/browse/CB-7349 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref I'm trying to get cordova-mobile-spec/createmobilespec to be friendly. One of the many things which doesn't work well is the lack of an instruction to run npm install from cordova-js at the proper time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7360) [CLI] event emitter memory leak
Lorin Beer created CB-7360:
--
Summary: [CLI] event emitter memory leak
Key: CB-7360
URL: https://issues.apache.org/jira/browse/CB-7360
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
refactor causes node warning, fix the issue causing the warning
{code}
(node) warning: possible EventEmitter memory leak detected. 11 listeners added.
Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:69:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
(node) warning: possible EventEmitter memory leak detected. 11 listeners added.
Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:70:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
(node) warning: possible EventEmitter memory leak detected. 11 listeners added.
Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:71:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7349) Tell users to run npm install
[ https://issues.apache.org/jira/browse/CB-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105768#comment-14105768 ] ASF subversion and git services commented on CB-7349: - Commit 58e9d6cd0b5ff63e6ba566a49cdedcaea897c3db in cordova-js's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=58e9d6c ] CB-7349 Tell users to run npm install when browserify/jasmine-node are missing Tell users to run npm install - Key: CB-7349 URL: https://issues.apache.org/jira/browse/CB-7349 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref I'm trying to get cordova-mobile-spec/createmobilespec to be friendly. One of the many things which doesn't work well is the lack of an instruction to run npm install from cordova-js at the proper time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7361) Modify create-release-bug to do one repo at a time
Steve Gill created CB-7361: -- Summary: Modify create-release-bug to do one repo at a time Key: CB-7361 URL: https://issues.apache.org/jira/browse/CB-7361 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7362) Add Please run npm install from this directory code
Josh Soref created CB-7362:
--
Summary: Add Please run npm install from this directory code
Key: CB-7362
URL: https://issues.apache.org/jira/browse/CB-7362
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Most of Cordova now has code to output:
{quote}
Please run npm install from this directory:
{quote}
plugman is missing this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7363) Do not insist on precise version of cordova-lib
Josh Soref created CB-7363:
--
Summary: Do not insist on precise version of cordova-lib
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105943#comment-14105943
]
ASF GitHub Bot commented on CB-7363:
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-cli/pull/190
CB-7363 Do not insist on precise version of cordova-lib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-cli cb_7363
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
commit d4898e769a6e4bc0efff4d7acb7e755b8356ba3b
Author: Josh Soref jso...@blackberry.com
Date: 2014-08-21T20:51:05Z
CB-7363 Do not insist on precise version of cordova-lib
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105945#comment-14105945
]
ASF GitHub Bot commented on CB-7363:
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-plugman/pull/78
CB-7363 Do not insist on precise version of cordova-lib
CB-7362 Add Please run npm install from this directory code
Remove package.json:scripts.test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-plugman cb_7363
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
commit c0e57a8f09094014b4674ca5eaa7c6329bbbf0ce
Author: Josh Soref jso...@blackberry.com
Date: 2014-08-21T20:08:16Z
Remove package.json:scripts.test
The spec directory was removed with eefdf68 / bea01b3, but this file was
not updated
commit 8eff249e4188c0f616d428d791d9b0c935cdeb50
Author: Josh Soref jso...@blackberry.com
Date: 2014-08-21T20:04:42Z
CB-7362 Add Please run npm install from this directory code
commit 8a9835493441050003cab442091190127e8c4fda
Author: Josh Soref jso...@blackberry.com
Date: 2014-08-21T20:51:45Z
CB-7363 Do not insist on precise version of cordova-lib
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105950#comment-14105950
]
ASF subversion and git services commented on CB-7363:
-
Commit d4898e769a6e4bc0efff4d7acb7e755b8356ba3b in cordova-cli's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=d4898e7 ]
CB-7363 Do not insist on precise version of cordova-lib
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7362) Add Please run npm install from this directory code
[
https://issues.apache.org/jira/browse/CB-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105948#comment-14105948
]
ASF subversion and git services commented on CB-7362:
-
Commit 8eff249e4188c0f616d428d791d9b0c935cdeb50 in cordova-plugman's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=8eff249 ]
CB-7362 Add Please run npm install from this directory code
Add Please run npm install from this directory code
---
Key: CB-7362
URL: https://issues.apache.org/jira/browse/CB-7362
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Most of Cordova now has code to output:
{quote}
Please run npm install from this directory:
{quote}
plugman is missing this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105951#comment-14105951
]
ASF GitHub Bot commented on CB-7363:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugman/pull/78
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105952#comment-14105952
]
ASF GitHub Bot commented on CB-7363:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/190
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105949#comment-14105949
]
ASF subversion and git services commented on CB-7363:
-
Commit 8a9835493441050003cab442091190127e8c4fda in cordova-plugman's branch
refs/heads/master from [~jsoref]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=8a98354 ]
CB-7363 Do not insist on precise version of cordova-lib
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105955#comment-14105955
]
Marcel Kinard commented on CB-7363:
---
So in the case of CB-7267 this would break the ability to pull in an updated
platform version, correct?
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105962#comment-14105962
]
Josh Soref commented on CB-7363:
Dunno.
a hypothetical cordova-cli 3.7.9 which wants cordova-lib ~3.7.8 would be happy
w/ ~3.7.1000 (whereas before this change, it would have rejected it and
retrieved 3.7.8), it wouldn't be any happier with 3.8 than it was before this
change.
Mostly it depends on how we make version numbers. Given our current tendencies,
this change is the minimal change necessary to not cause me hell. If we wanted
to be looser, we could use {{=}} instead of {{~}}, in which case 3.8 or 4.0
would also be allowed. Making that change would require an actual discussion,
whereas, what we had now was fundamentally broken and interfering with my
ability to fix mobilespec.
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106013#comment-14106013
]
Steve Gill commented on CB-7363:
I'm not a fan of adding a dev version dependency in package.json for the
cli/plugman on master. IMO package.json should only include versions that are
released! If someone checks out the cli from master, and runs npm install, it
will fail now. This can't happen! It needs to be fixed asap!
CLI package.json has cordova-lib dependency set to ~0.21.8-dev, The released
version is 0.21.7. npm install will fail!
I am fine with adding ~ or = though instead of exact matching.
The way I handle working with unreleased versions for all of the repos and I
think is the optimal way to do it:
cd cordova-js
npm install
npm link
cd cordova-lib/cordova-lib
npm install
npm link
cd node-modules
npm link cordova-js (this will use the linked version from above)
cd cordova-plugman
npm install
npm link
cd node-modules
npm link cordova-lib
npm link cordova-js
cd cordova-cli
npm install
npm link
cd node-modules
npm link cordova-lib
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106017#comment-14106017
]
Steve Gill edited comment on CB-7363 at 8/21/14 9:51 PM:
-
going back into cli after my enviroment is setup from above, and running npm
install will not nuke my linked modules.
EX:
Stevens-MacBook-Air-2:cordova-cli stevengill$ npm install
Stevens-MacBook-Air-2:cordova-cli stevengill$ cd node_modules/
Stevens-MacBook-Air-2:node_modules stevengill$ ls -al
total 24
drwxr-xr-x 10 stevengill staff 340 Aug 21 14:46 .
drwxr-xr-x 21 stevengill staff 714 Aug 21 14:46 ..
drwxr-xr-x 4 stevengill staff 136 Jul 22 16:33 .bin
lrwxr-xr-x 1 stevengill staff39 Jul 30 15:04 cordova-lib -
/usr/local/lib/node_modules/cordova-lib
drwxr-xr-x 16 stevengill staff 544 Jul 22 16:33 jasmine-node
drwxr-xr-x 11 stevengill staff 374 Jul 22 16:33 nopt
-rw-r--r-- 1 stevengill staff 4298 Aug 21 14:46 npm-debug.log
drwxr-xr-x 10 stevengill staff 340 May 23 16:59 optimist
drwxr-xr-x 9 stevengill staff 306 May 23 16:59 q
drwxr-xr-x 14 stevengill staff 476 May 23 16:59 underscore
As you can see, my npm link cordova-lib survived the npm install
was (Author: stevegill):
going back into cli after my enviroment is setup from above, and running npm
install will not nuke my linked modules.
EX:
Stevens-MacBook-Air-2:cordova-cli stevengill$ npm install
Stevens-MacBook-Air-2:cordova-cli stevengill$ cd node_modules/
Stevens-MacBook-Air-2:node_modules stevengill$ ls -al
total 24
drwxr-xr-x 10 stevengill staff 340 Aug 21 14:46 .
drwxr-xr-x 21 stevengill staff 714 Aug 21 14:46 ..
drwxr-xr-x 4 stevengill staff 136 Jul 22 16:33 .bin
lrwxr-xr-x 1 stevengill staff39 Jul 30 15:04 cordova-lib -
/usr/local/lib/node_modules/cordova-lib
drwxr-xr-x 16 stevengill staff 544 Jul 22 16:33 jasmine-node
drwxr-xr-x 11 stevengill staff 374 Jul 22 16:33 nopt
-rw-r--r-- 1 stevengill staff 4298 Aug 21 14:46 npm-debug.log
drwxr-xr-x 10 stevengill staff 340 May 23 16:59 optimist
drwxr-xr-x 9 stevengill staff 306 May 23 16:59 q
drwxr-xr-x 14 stevengill staff 476 May 23 16:59 underscore
As you ca see, my npm link cordova-lib survived the npm install
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106017#comment-14106017
]
Steve Gill commented on CB-7363:
going back into cli after my enviroment is setup from above, and running npm
install will not nuke my linked modules.
EX:
Stevens-MacBook-Air-2:cordova-cli stevengill$ npm install
Stevens-MacBook-Air-2:cordova-cli stevengill$ cd node_modules/
Stevens-MacBook-Air-2:node_modules stevengill$ ls -al
total 24
drwxr-xr-x 10 stevengill staff 340 Aug 21 14:46 .
drwxr-xr-x 21 stevengill staff 714 Aug 21 14:46 ..
drwxr-xr-x 4 stevengill staff 136 Jul 22 16:33 .bin
lrwxr-xr-x 1 stevengill staff39 Jul 30 15:04 cordova-lib -
/usr/local/lib/node_modules/cordova-lib
drwxr-xr-x 16 stevengill staff 544 Jul 22 16:33 jasmine-node
drwxr-xr-x 11 stevengill staff 374 Jul 22 16:33 nopt
-rw-r--r-- 1 stevengill staff 4298 Aug 21 14:46 npm-debug.log
drwxr-xr-x 10 stevengill staff 340 May 23 16:59 optimist
drwxr-xr-x 9 stevengill staff 306 May 23 16:59 q
drwxr-xr-x 14 stevengill staff 476 May 23 16:59 underscore
As you ca see, my npm link cordova-lib survived the npm install
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106019#comment-14106019
]
Josh Soref commented on CB-7363:
I didn't put in the {{0.21.8-dev}}, it was already there. All I did was add the
{{~}}
[~cmarcelk] changed it for CB-7260
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106021#comment-14106021
]
Josh Soref commented on CB-7363:
Note that {{npm link}} isn't acceptable to me.
It might be fine for you if you only do dev work. But I need to be able to do
both dev work, and testing with a different version.
I can't have npm pulling in my dev version of things when I'm trying to use an
official version.
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Fix For: 3.6.0
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Soref closed CB-7363.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Fix For: 3.6.0
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7221) Independent Platform Releases
[ https://issues.apache.org/jira/browse/CB-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref updated CB-7221: --- Summary: Independent Platform Releases (was: Indy Platform Releases) Independent Platform Releases - Key: CB-7221 URL: https://issues.apache.org/jira/browse/CB-7221 Project: Apache Cordova Issue Type: Improvement Reporter: Jesse MacFadyen Collect all tasks related to independent platform releases. Google doc on the subject is here: https://docs.google.com/document/d/1OmK_fezEiv-LIPIw242kAdKhThqfD39xbSfvjWFOmjM/edit and email thread discussions: http://markmail.org/message/lrfxrjtnspc3n7b2 http://markmail.org/message/2cfkjrgqy62p4fs2 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7362) Add Please run npm install from this directory code
[
https://issues.apache.org/jira/browse/CB-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Soref closed CB-7362.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Add Please run npm install from this directory code
---
Key: CB-7362
URL: https://issues.apache.org/jira/browse/CB-7362
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Fix For: 3.6.0
Most of Cordova now has code to output:
{quote}
Please run npm install from this directory:
{quote}
plugman is missing this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7363) Do not insist on precise version of cordova-lib
[
https://issues.apache.org/jira/browse/CB-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106063#comment-14106063
]
Steve Gill commented on CB-7363:
Was merely giving you different workflow ideas by showing you mine. It isn't
going to be acceptable for everyone's use cases.
If I want to test official releases:
cd cordova-cli/node-modules
git checkout SOMETAG
npm unlink cordova-lib
npm install
or
cd cordova-cli/node-modules
npm install cordova-lib
or
cd cordova-lib
git checkout SOMETAG (if it is npm linked in cli, it will use the version i
just checked out now)
I'm sure pros and cons exist for many of these workflows. Just thought I'd
share in hopes that it would help you with your workflow woes.
Do not insist on precise version of cordova-lib
---
Key: CB-7363
URL: https://issues.apache.org/jira/browse/CB-7363
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Josh Soref
Assignee: Josh Soref
Fix For: 3.6.0
Currently plugman's {{package.json}} has:
{quote}
cordova-lib : 0.21.6,
{quote}
Unfortunately, my git repo (from coho) of {{cordova-lib}} has {{0.21.8-dev}},
which means that if I do {{npm install}} in {{cordova-plugman}}, and I have a
_symlink_ to {{cordova-lib}} in its {{node_modules}}, the _symlink_ is
*obliterated*. This isn't desirable and makes a totally mess out of git
repositories.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Deleted] (CB-7361) Modify create-release-bug to do one repo at a time
[ https://issues.apache.org/jira/browse/CB-7361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill deleted CB-7361: --- Modify create-release-bug to do one repo at a time -- Key: CB-7361 URL: https://issues.apache.org/jira/browse/CB-7361 Project: Apache Cordova Issue Type: Sub-task Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7364) cordova-cli results c are being triplicated
Josh Soref created CB-7364: -- Summary: cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref updated CB-7364: --- Priority: Blocker (was: Major) cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106116#comment-14106116 ] Lorin Beer commented on CB-7364: I am aware of the issue, it has to do with multiple registration of listeners. My bad for letting this in, and will be fixed momentarily. cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorin Beer reassigned CB-7364: -- Assignee: Lorin Beer (was: Josh Soref) cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Lorin Beer Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106120#comment-14106120 ] ASF subversion and git services commented on CB-7364: - Commit 2f42501bb0980981aace939ccd70bcaab2b65f6d in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=2f42501 ] CB-7364 remove duplicate logging initialization for cordova/plugman a4d941f merged events, cordova, and plugman to share a common events implementation, but it left cli registering them three times cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Lorin Beer Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref reassigned CB-7364: -- Assignee: Josh Soref (was: Lorin Beer) cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7364. -- Resolution: Fixed cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106140#comment-14106140 ] ASF GitHub Bot commented on CB-7350: Github user jsoref commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/103#issuecomment-52998657 @clelland : ok, I think this is pretty good now... Android, BlackBerry 10, and iOS are all able to work w/ and w/o `--plugman` In most of the cases I can imagine, I'm given clear instructions about what to do next if I'm missing something. @jengee if you could try using this pull request with createmobilespec.js, that'd be great. I can try to get some other QA to try it too. But, I'd really like to close this pull request tomorrow. Make createmobilespec friendlier Key: CB-7350 URL: https://issues.apache.org/jira/browse/CB-7350 Project: Apache Cordova Issue Type: Bug Components: mobile-spec Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref * Don't assume that the people running mobilespec are developers -- In my experience, they aren't * The READMEs needed a refresh * Asking people to install grunt-cli globally is silly, we have npm dependencies, we can use them. * The pushd/popd spam is really not helpful afaict * Provide information about how to use coho to get the right things more or less at the right time * Fix the __dirname output to be correct ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7350) Make createmobilespec friendlier
[ https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106141#comment-14106141 ] ASF GitHub Bot commented on CB-7350: Github user jsoref commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/103#issuecomment-52998710 -- And by close it, I mean, that I intend to fold all of my commits into 2 or so commits with pretty commit messages and then push that into `apache/master` Make createmobilespec friendlier Key: CB-7350 URL: https://issues.apache.org/jira/browse/CB-7350 Project: Apache Cordova Issue Type: Bug Components: mobile-spec Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref * Don't assume that the people running mobilespec are developers -- In my experience, they aren't * The READMEs needed a refresh * Asking people to install grunt-cli globally is silly, we have npm dependencies, we can use them. * The pushd/popd spam is really not helpful afaict * Provide information about how to use coho to get the right things more or less at the right time * Fix the __dirname output to be correct ... some other stuff... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7364) cordova-cli results c are being triplicated
[ https://issues.apache.org/jira/browse/CB-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106150#comment-14106150 ] Lorin Beer commented on CB-7364: thanks for fixing this, Josh. cordova-cli results c are being triplicated Key: CB-7364 URL: https://issues.apache.org/jira/browse/CB-7364 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.6.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Blocker a4d941f by [~lorin.beer] was a crash landing. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7360) [CLI] event emitter memory leak
[
https://issues.apache.org/jira/browse/CB-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorin Beer resolved CB-7360.
Resolution: Fixed
issue was resolved by [~jsoref] in CB-7364
In the future [~jsoref] please check that your issue is not a duplicate. This
was a minor issue, but indicates a pointless duplication of effort on your part.
You tagged me by name in your bug report, I indicated within minutes I was
aware of the problem and would patch it momentarily.
[CLI] event emitter memory leak
---
Key: CB-7360
URL: https://issues.apache.org/jira/browse/CB-7360
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
refactor causes node warning, fix the issue causing the warning
{code}
(node) warning: possible EventEmitter memory leak detected. 11 listeners
added. Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:69:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
(node) warning: possible EventEmitter memory leak detected. 11 listeners
added. Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:70:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
(node) warning: possible EventEmitter memory leak detected. 11 listeners
added. Use emitter.setMaxListeners() to increase limit.
Trace
at EventEmitter.addListener (events.js:160:15)
at initLogHandlers (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:71:17)
at cli (/Users/lorin/dev/cordova/cdv-cli/src/cli.js:122:5)
at null.anonymous
(/Users/lorin/dev/cordova/cdv-cli/spec/cli.spec.js:118:13)
at jasmine.Block.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:1145:17)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
at jasmine.Spec.execute
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2458:14)
at jasmine.Queue.next_
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2177:31)
at jasmine.Queue.start
(/Users/lorin/dev/cordova/cdv-cli/node_modules/jasmine-node/lib/jasmine-node/jasmine-1.3.1.js:2130:8)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7355) [CLI] removing unit tests which depend on external libraries
[
https://issues.apache.org/jira/browse/CB-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106178#comment-14106178
]
ASF subversion and git services commented on CB-7355:
-
Commit bb2337af774f9e9aa3fe30e6baa5d7adfc80 in cordova-cli's branch
refs/heads/master from [~lorin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=bb2337a ]
[CB-7355] re added single test to test call through to cordova-lib cordova raw
create
[CLI] removing unit tests which depend on external libraries
Key: CB-7355
URL: https://issues.apache.org/jira/browse/CB-7355
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Reporter: Lorin Beer
Assignee: Lorin Beer
The cordova-cli has vestigial unit tests which now trigger on external
dependencies (example below)
These should be removed from the cli, and migrated to the appropriate lib if
necessary.
{code}
-it(will NOT allow copy-from starting with 'http', function () {
-var threwAnException = false;
-try {
-cli([node, cordova, create, a, b , c,
--copy-from, http://www.somesite.com;]);
-}
-catch(e) {
-threwAnException = true;
-}
-expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only
local paths for custom www assets are supported.');
-expect(threwAnException).toBe(true);
-});
-
-it(will allow link-to with ':' char, function () {
{code}
in the example above, the behaviour is not implemented within the cordova cli
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-7355) [CLI] removing unit tests which depend on external libraries
[
https://issues.apache.org/jira/browse/CB-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorin Beer resolved CB-7355.
Resolution: Fixed
tests still need additional tweaking, but removed create tests which depended
behaviour of external libs
[CLI] removing unit tests which depend on external libraries
Key: CB-7355
URL: https://issues.apache.org/jira/browse/CB-7355
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Reporter: Lorin Beer
Assignee: Lorin Beer
The cordova-cli has vestigial unit tests which now trigger on external
dependencies (example below)
These should be removed from the cli, and migrated to the appropriate lib if
necessary.
{code}
-it(will NOT allow copy-from starting with 'http', function () {
-var threwAnException = false;
-try {
-cli([node, cordova, create, a, b , c,
--copy-from, http://www.somesite.com;]);
-}
-catch(e) {
-threwAnException = true;
-}
-expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only
local paths for custom www assets are supported.');
-expect(threwAnException).toBe(true);
-});
-
-it(will allow link-to with ':' char, function () {
{code}
in the example above, the behaviour is not implemented within the cordova cli
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6457) [CLI] Experimental Refactor - CLI Create Command
[ https://issues.apache.org/jira/browse/CB-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106184#comment-14106184 ] Lorin Beer commented on CB-6457: movement on this: pushed from the wrong branch, commits not tagged with issue relevant commits: 7aef391bdfefeab8945387aa6207dab9ce74a9e4 eeaca77c99a1816d770af5992613ad5b17b48b70 [CLI] Experimental Refactor - CLI Create Command Key: CB-6457 URL: https://issues.apache.org/jira/browse/CB-6457 Project: Apache Cordova Issue Type: Sub-task Components: CLI Reporter: Lorin Beer Assignee: Lorin Beer Priority: Minor stub module for cli build, which pulls in cordova/build.js. With tests. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7358) [CLI] [tests] unnecessary output when running tests
[
https://issues.apache.org/jira/browse/CB-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lorin Beer resolved CB-7358.
Resolution: Fixed
commit in comments, mocked console.log to avoid needless logging during tests
[CLI] [tests] unnecessary output when running tests
---
Key: CB-7358
URL: https://issues.apache.org/jira/browse/CB-7358
Project: Apache Cordova
Issue Type: Bug
Reporter: Lorin Beer
Assignee: Lorin Beer
cordova-cli test suite outputs jank while running tests
jank includes multiple repetitions of the help string.
solution: mock or redirect console.log to avoid polluting output
{code}
Synopsis
cordova command [options]
Global Commands
create . Create a project
help ... Get help for a command
Project Commands
info ... Generate project information
platform ... Manage project platforms
plugin . Manage project plugins
prepare Copy files into platform(s) for
building
compile Build platform(s)
run Run project
(including prepare compile)
serve .. Run project with a local webserver
(including prepare)
aliases:
build - cordova prepare cordova compile
emulate - cordova run --emulator
Experimental Commands
These commands require the --experimental flag.
save ... Save installed platforms/plugins
restore Restore saved platforms/plugins
Command-line Flags/Options
-v, --version .. prints out this utility's version
-d, --verbose .. debug mode produces verbose log
output for all activity,
including output of sub-commands
cordova invokes
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7365) coho print-tags seems to be giving the wrong output
Steve Gill created CB-7365: -- Summary: coho print-tags seems to be giving the wrong output Key: CB-7365 URL: https://issues.apache.org/jira/browse/CB-7365 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill coho print-tags -r android gives 2.5.0 reference. Might be something I did wrong -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7224) Update Cadence release process document
[ https://issues.apache.org/jira/browse/CB-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106206#comment-14106206 ] ASF subversion and git services commented on CB-7224: - Commit 90316b9a93f8f88e1855791555c68e6125e1dedc in cordova-coho's branch refs/heads/cb-7224 from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=90316b9 ] CB-7224 Updated platforms-release-process.md Update Cadence release process document --- Key: CB-7224 URL: https://issues.apache.org/jira/browse/CB-7224 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill Assignee: Steve Gill Rename https://github.com/apache/cordova-coho/blob/master/docs/cadence-release-process.md doc to platforms-release-process and update the content for independent release process. Tag cordova-js for each platform release with PLATFORM-VERSION -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7224) Create Platforms release process
[ https://issues.apache.org/jira/browse/CB-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106208#comment-14106208 ] Steve Gill commented on CB-7224: You can view my work at https://github.com/stevengill/cordova-coho/tree/cb-7224. Please review and leave comments. Create Platforms release process Key: CB-7224 URL: https://issues.apache.org/jira/browse/CB-7224 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill Assignee: Steve Gill Rename https://github.com/apache/cordova-coho/blob/master/docs/cadence-release-process.md doc to platforms-release-process and update the content for independent release process. Tag cordova-js for each platform release with PLATFORM-VERSION -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7224) Create Platforms release process
[ https://issues.apache.org/jira/browse/CB-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-7224: --- Summary: Create Platforms release process (was: Update Cadence release process document) Create Platforms release process Key: CB-7224 URL: https://issues.apache.org/jira/browse/CB-7224 Project: Apache Cordova Issue Type: Sub-task Components: Coho Reporter: Steve Gill Assignee: Steve Gill Rename https://github.com/apache/cordova-coho/blob/master/docs/cadence-release-process.md doc to platforms-release-process and update the content for independent release process. Tag cordova-js for each platform release with PLATFORM-VERSION -- This message was sent by Atlassian JIRA (v6.2#6252)
