[jira] [Commented] (CB-8352) Need some way to expand an activity's functions, or relay them to a plugin.
[ https://issues.apache.org/jira/browse/CB-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295170#comment-14295170 ] Andreas Vourkos commented on CB-8352: - hello, You do not have to touch the activity. Why don't you use Pollfish function: public void init( Activity act, String apiKey, Position p, int indPadding, PollfishSurveyReceivedListener pollfishSurveyReceivedListener, PollfishSurveyNotAvailableListener pollfishSurveyNotAvailableListener, PollfishSurveyCompletedListener pollfishSurveyCompletedListener, PollfishOpenedListener pollfishOpenedListener, PollfishClosedListener pollfishClosedListener, PollfishUserNotEligibleListener pollfishUserNotEligibleListener); to listen to the listeners you want without dealing with the activity? Need some way to expand an activity's functions, or relay them to a plugin. --- Key: CB-8352 URL: https://issues.apache.org/jira/browse/CB-8352 Project: Apache Cordova Issue Type: Improvement Components: Android, CordovaJS Reporter: Michael Romanovsky Labels: cordova, cordova-lib There is already startActivityForResult, which helps me run onActivityResult. I am having trouble integrating this: http://tinyurl.com/kptdph5 as a plugin, however. It calls for extending the main Activity to run the events, but as far as I know, only onActivityResult will forward back to a plugin. Some ideas: 1) A pre-processing step that rewrites the main Activity and adds functions from a specific class into the Activity. 2) ??? 3) PROFIT. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8367) [org.apache.cordova.dialogs] Add Prompt support on Windows
Sergey Grebnov created CB-8367: -- Summary: [org.apache.cordova.dialogs] Add Prompt support on Windows Key: CB-8367 URL: https://issues.apache.org/jira/browse/CB-8367 Project: Apache Cordova Issue Type: Improvement Components: Plugin Dialogs Reporter: Sergey Grebnov Assignee: Sergey Grebnov Priority: Minor Prompt method is not currently supported on Windows. There is no such native api, but we could add html-based popup. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294978#comment-14294978 ] ASF GitHub Bot commented on CB-5059: Github user crissi commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-71813597 +1 The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager --- Key: CB-5059 URL: https://issues.apache.org/jira/browse/CB-5059 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: Master Environment: cordova-android, git branch 3.0.x Reporter: Junmin Fix For: Master The android implementation of file transfer plugin leverages the class android.webkit.CookieManager, which depends on the concrete web infrastructure android.webkit.WebView. This dependence ruins the portability of the plugin. For example, it could not run on a substantial implementation of CordovaWebView which based on a android third party component(such as chromium for android). Following is the crash log when initializing the CookieManager without android.webkit.WebView: I/dalvikvm(5006): java.lang.IllegalStateException: Call CookieSyncManager::createInstance() or create a webview before using this class I/dalvikvm(5006): at android.webkit.JniUtil.checkInitialized(JniUtil.java:44) I/dalvikvm(5006): at android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) I/dalvikvm(5006): at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7947) pauseTimers() called too aggressively on Android
[ https://issues.apache.org/jira/browse/CB-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295233#comment-14295233 ] ASF subversion and git services commented on CB-7947: - Commit b59705bed4101e075e95bd01d616f617429091c4 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=b59705b ] CB-7947 Don't force-pauseTimers() for startActivityForResult pauseTimers() called too aggressively on Android Key: CB-7947 URL: https://issues.apache.org/jira/browse/CB-7947 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve ML discussion: http://markmail.org/thread/dhs7lnnrhq6z24vb Couple of issues: 1. pauseTimers(), although an instance method, actually applies to all webviews 2. pauseTimers() is always being called during startActivityForResult(), even though there's no reason to do this. Proposed changes: - Pause timers during a startActivityForResult only when KeepRunning preference is false (this should happen anyways, since the activity's onPause is fired in this case) - 4.0.x branch: Create a setGloballyPauseTimers(boolean) on CordovaWebview interface in 4.0.x that is documented to have the same semantics as WebView.pause/resume timers. - 4.0.x branch: Move the pausing resuming into CordovaActivity, rather than passing it as a boolean to the onPause() function -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4914) Cordova CLI cannot build Android project when the path contains spaces
[ https://issues.apache.org/jira/browse/CB-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295234#comment-14295234 ] ASF GitHub Bot commented on CB-4914: Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/147 Cordova CLI cannot build Android project when the path contains spaces -- Key: CB-4914 URL: https://issues.apache.org/jira/browse/CB-4914 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 3.0.0 Environment: Platform: Windows 7 Cordova CLI Version: 3.0.9 Reporter: Simon Fisher Assignee: Lorin Beer Fix For: 3.2.0 When attempting to use the CLI to compile/build an android project, if the path contains spaces then the command fails. Example: C:\my pathcordova create HelloWorld com.test.helloworld HelloWorld (success) C:\my path cd helloworld C:\my path\helloworldcordova platform add android (success) C:\my path\helloworldcordova prepare android (success) C:\my path\helloworldcordova compile android [Error: An error occurred while building the android project. 'C:\my' is not recognized as an internal or external command, operable program or batch file. ] The same error occurs if I manually run platforms/android/cordova/build.bat However if I manually run platforms/android/ant debug then the build appears to succeed (at least, it gives no errors and generates an .APK file) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8182) cordova run browser will serve app files over http
[ https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295456#comment-14295456 ] ASF GitHub Bot commented on CB-8182: Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878798 `cordova serve` is potentially usable by `cordova-android` or `cordova-ios` or `cordova-blackberry`, so, no, please don't just fork it or hand wave and pray that forcing people to use `cordova-browser` will somehow work. cordova run browser will serve app files over http -- Key: CB-8182 URL: https://issues.apache.org/jira/browse/CB-8182 Project: Apache Cordova Issue Type: Improvement Components: Browser Reporter: Kirk Shoop -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8182) cordova run browser will serve app files over http
[ https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295458#comment-14295458 ] ASF GitHub Bot commented on CB-8182: Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878896 Specifically, it in theory allows one to live(-ish) edit an application instead of constantly republishing it to the device. cordova run browser will serve app files over http -- Key: CB-8182 URL: https://issues.apache.org/jira/browse/CB-8182 Project: Apache Cordova Issue Type: Improvement Components: Browser Reporter: Kirk Shoop -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295471#comment-14295471 ] ASF GitHub Bot commented on CB-5059: Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-71879606 @agrieve Thanks, updated The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager --- Key: CB-5059 URL: https://issues.apache.org/jira/browse/CB-5059 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: Master Environment: cordova-android, git branch 3.0.x Reporter: Junmin Fix For: Master The android implementation of file transfer plugin leverages the class android.webkit.CookieManager, which depends on the concrete web infrastructure android.webkit.WebView. This dependence ruins the portability of the plugin. For example, it could not run on a substantial implementation of CordovaWebView which based on a android third party component(such as chromium for android). Following is the crash log when initializing the CookieManager without android.webkit.WebView: I/dalvikvm(5006): java.lang.IllegalStateException: Call CookieSyncManager::createInstance() or create a webview before using this class I/dalvikvm(5006): at android.webkit.JniUtil.checkInitialized(JniUtil.java:44) I/dalvikvm(5006): at android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) I/dalvikvm(5006): at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8371) Ubuntu node is installed as nodejs
Josh Soref created CB-8371: -- Summary: Ubuntu node is installed as nodejs Key: CB-8371 URL: https://issues.apache.org/jira/browse/CB-8371 Project: Apache Cordova Issue Type: Bug Components: BlackBerry, CLI Affects Versions: Master Reporter: Josh Soref {quote} $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 14.04.1 LTS Release:14.04 Codename: trusty $ env node env: node: No such file or directory $ env nodejs {quote} {quote} $ node The program 'node' can be found in the following packages: * node * nodejs-legacy Try: sudo apt-get install selected package {quote} {{cordova-blackberry}} fails spectacularly on *Ubuntu*, but {{cordova}} itself also seems to fail nicely. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8372) Captured Image is not shown sometimes.
Simon Agostini created CB-8372: -- Summary: Captured Image is not shown sometimes. Key: CB-8372 URL: https://issues.apache.org/jira/browse/CB-8372 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Capture Affects Versions: 3.6.3 Environment: build.phonegap.com Reporter: Simon Agostini Using the device capture for video, audio and images I only see this issue for images. So if i start capturing a image (tap event on button) the camera opens and i can take the image, then the success callback is called. In the success callback i wanted to show the image and then allow to upload it. It now can appear sometimes that the image is not displayed (question mark sign), and also the upload with the file plugin fails. It looks for me like the file cannot be found at the fullPath which is returned in the callback. So please have a look at it. Device: Android 4.1.2 Wiko Darkmoon Cordova: 3.6.3 capture plugin 0.3.5 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295779#comment-14295779 ] ASF GitHub Bot commented on CB-8123: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847 Very cool Tim! Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform --- Key: CB-8123 URL: https://issues.apache.org/jira/browse/CB-8123 Project: Apache Cordova Issue Type: Improvement Components: Plugins, Windows Reporter: Tim Barham Original Estimate: 72h Remaining Estimate: 72h Because Cordova's windows platform can target multiple target platforms, projects and frameworks referenced by the plugin may need to target only a subset of those platforms. To enable this, support the following attributes on the lib-file and framework elements: 1. device - indicates the reference is specific to a target device. Supported values are phone, windows or all (default is all). 2. versions - specify platform versions the reference supports (node semantic version ranges supported). Default is to support all versions. 3. arch - indicates the reference is specific to a particular chip architecture (x86 or x64). The arch attribute should result in a Condition='$(Platform)'=='XXX attribute on the reference. The other attributes will impact which generated jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8371) Ubuntu node is installed as nodejs
[ https://issues.apache.org/jira/browse/CB-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295809#comment-14295809 ] Andrew Grieve commented on CB-8371: --- Yikes! Wonder what others are doing about this... Maybe use a #!/bin/sh shebang and sub-shell to `nodejs` or `node` depending on what's installed? Ubuntu node is installed as nodejs -- Key: CB-8371 URL: https://issues.apache.org/jira/browse/CB-8371 Project: Apache Cordova Issue Type: Bug Components: BlackBerry, CLI Affects Versions: Master Reporter: Josh Soref {quote} $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 14.04.1 LTS Release:14.04 Codename: trusty $ env node env: node: No such file or directory $ env nodejs {quote} {quote} $ node The program 'node' can be found in the following packages: * node * nodejs-legacy Try: sudo apt-get install selected package {quote} {{cordova-blackberry}} fails spectacularly on *Ubuntu*, but {{cordova}} itself also seems to fail nicely. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8373) android platform update loses all framework type=gradleReference/ entries
[ https://issues.apache.org/jira/browse/CB-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295891#comment-14295891 ] ASF subversion and git services commented on CB-8373: - Commit 7e7dc7694c0a08dc270f41420c1d98fa76fc59eb in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=7e7dc76 ] CB-8373 Add gradle plugin includes based on project.properties (where plugman now puts them) android platform update loses all framework type=gradleReference/ entries - Key: CB-8373 URL: https://issues.apache.org/jira/browse/CB-8373 Project: Apache Cordova Issue Type: Bug Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Blocker for Android 4.0. 1. Create a plugin with a gradleReference framework 2. add it to your project 3. run update script on the project Notice the reference is gone. As a solution, I'm going to have plugman put these references into project.properties instead of editing the build.gradle file. Rationale: * project.properties is already used by plugman for sublibrary projects * This will make it so that build.gradle is untouched by plugman -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8373) android platform update loses all framework type=gradleReference/ entries
[ https://issues.apache.org/jira/browse/CB-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8373. --- Resolution: Fixed Fixed with cordova-lib@4.2.1-dev and cordova-android@4.0.0-dev android platform update loses all framework type=gradleReference/ entries - Key: CB-8373 URL: https://issues.apache.org/jira/browse/CB-8373 Project: Apache Cordova Issue Type: Bug Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Blocker for Android 4.0. 1. Create a plugin with a gradleReference framework 2. add it to your project 3. run update script on the project Notice the reference is gone. As a solution, I'm going to have plugman put these references into project.properties instead of editing the build.gradle file. Rationale: * project.properties is already used by plugman for sublibrary projects * This will make it so that build.gradle is untouched by plugman -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8373) android platform update loses all framework type=gradleReference/ entries
Andrew Grieve created CB-8373: - Summary: android platform update loses all framework type=gradleReference/ entries Key: CB-8373 URL: https://issues.apache.org/jira/browse/CB-8373 Project: Apache Cordova Issue Type: Bug Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Blocker for Android 4.0. 1. Create a plugin with a gradleReference framework 2. add it to your project 3. run update script on the project Notice the reference is gone. As a solution, I'm going to have plugman put these references into project.properties instead of editing the build.gradle file. Rationale: * project.properties is already used by plugman for sublibrary projects * This will make it so that build.gradle is untouched by plugman -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8370) Plugman 0.22.18-dev fails to publish with ugly path.join error
[ https://issues.apache.org/jira/browse/CB-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295909#comment-14295909 ] ASF subversion and git services commented on CB-8370: - Commit dbde18b8f0f0e009e01a4a77c15b4360ee5d5640 in cordova-plugman's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=dbde18b ] CB-8370 Update documentation for `plugman publish` without args Plugman 0.22.18-dev fails to publish with ugly path.join error -- Key: CB-8370 URL: https://issues.apache.org/jira/browse/CB-8370 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Josh Soref {quote} $ plugman publish --debug Error Code: undefined Arguments to path.join must be strings TypeError: Arguments to path.join must be strings at path.js:360:15 at Array.filter (native) at Object.exports.join (path.js:358:36) at new PluginInfo (cordova-lib/src/PluginInfo.js:285:26) at cordova-lib/src/plugman/registry/manifest.js:43:26 at _fulfilled (cordova-lib/node_modules/q/q.js:787:54) at self.promiseDispatch.done (cordova-lib/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (cordova-lib/node_modules/q/q.js:749:13) at cordova-lib/node_modules/q/q.js:810:14 at flush (cordova-lib/node_modules/q/q.js:108:17) {quote} If you must provide a path to publish, then when you don't, there should be a pretty error message that says so, e.g. the usage message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8373) android platform update loses all framework type=gradleReference/ entries
[ https://issues.apache.org/jira/browse/CB-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295889#comment-14295889 ] ASF subversion and git services commented on CB-8373: - Commit c6255be7753a19bf8ab34be9a692b520ee8d9eb2 in cordova-lib's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c6255be ] CB-8373 android: Add gradle references to project.properties rather than build.gradle android platform update loses all framework type=gradleReference/ entries - Key: CB-8373 URL: https://issues.apache.org/jira/browse/CB-8373 Project: Apache Cordova Issue Type: Bug Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Blocker for Android 4.0. 1. Create a plugin with a gradleReference framework 2. add it to your project 3. run update script on the project Notice the reference is gone. As a solution, I'm going to have plugman put these references into project.properties instead of editing the build.gradle file. Rationale: * project.properties is already used by plugman for sublibrary projects * This will make it so that build.gradle is untouched by plugman -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8375) cordova-coho for-each doesnt support windows
[ https://issues.apache.org/jira/browse/CB-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296097#comment-14296097 ] ASF GitHub Bot commented on CB-8375: GitHub user muratsu opened a pull request: https://github.com/apache/cordova-coho/pull/62 CB-8375 Improve windows support for for-each This improvement makes coho for-each work on Windows without issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-8375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit d1d8d687430292afd85e79a584f618cd28e265a8 Author: Murat Sutunc mura...@microsoft.com Date: 2015-01-28T23:56:09Z CB-8375 Improve windows support for for-each cordova-coho for-each doesnt support windows Key: CB-8375 URL: https://issues.apache.org/jira/browse/CB-8375 Project: Apache Cordova Issue Type: Bug Components: Coho Environment: Windows Reporter: Murat Sutunc When using for-each, coho looks for SHELL environment value or launches 'sh'. Both defaults are not good for windows. On windows it should use cmd instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8375) cordova-coho for-each doesnt support windows
Murat Sutunc created CB-8375: Summary: cordova-coho for-each doesnt support windows Key: CB-8375 URL: https://issues.apache.org/jira/browse/CB-8375 Project: Apache Cordova Issue Type: Bug Components: Coho Environment: Windows Reporter: Murat Sutunc When using for-each, coho looks for SHELL environment value or launches 'sh'. Both defaults are not good for windows. On windows it should use cmd instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295265#comment-14295265 ] ASF GitHub Bot commented on CB-5059: Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/151 The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager --- Key: CB-5059 URL: https://issues.apache.org/jira/browse/CB-5059 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: Master Environment: cordova-android, git branch 3.0.x Reporter: Junmin Fix For: Master The android implementation of file transfer plugin leverages the class android.webkit.CookieManager, which depends on the concrete web infrastructure android.webkit.WebView. This dependence ruins the portability of the plugin. For example, it could not run on a substantial implementation of CordovaWebView which based on a android third party component(such as chromium for android). Following is the crash log when initializing the CookieManager without android.webkit.WebView: I/dalvikvm(5006): java.lang.IllegalStateException: Call CookieSyncManager::createInstance() or create a webview before using this class I/dalvikvm(5006): at android.webkit.JniUtil.checkInitialized(JniUtil.java:44) I/dalvikvm(5006): at android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) I/dalvikvm(5006): at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5059) The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager
[ https://issues.apache.org/jira/browse/CB-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295264#comment-14295264 ] ASF subversion and git services commented on CB-5059: - Commit 8cf8da57767af1efbfe3a153e0eb2fc42bdb6a71 in cordova-android's branch refs/heads/master from [~dpogue] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=8cf8da5 ] CB-5059 Adds CookieManager abstraction for pluggable webviews (close #151) Crosswalk and GeckoView implementations of CordovaWebView can provide their own ICordovaCookieManager implementation for plugins to use. The android implementation of file transfer plugin should not depend on the concrete class android.webkit.CookieManager --- Key: CB-5059 URL: https://issues.apache.org/jira/browse/CB-5059 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: Master Environment: cordova-android, git branch 3.0.x Reporter: Junmin Fix For: Master The android implementation of file transfer plugin leverages the class android.webkit.CookieManager, which depends on the concrete web infrastructure android.webkit.WebView. This dependence ruins the portability of the plugin. For example, it could not run on a substantial implementation of CordovaWebView which based on a android third party component(such as chromium for android). Following is the crash log when initializing the CookieManager without android.webkit.WebView: I/dalvikvm(5006): java.lang.IllegalStateException: Call CookieSyncManager::createInstance() or create a webview before using this class I/dalvikvm(5006): at android.webkit.JniUtil.checkInitialized(JniUtil.java:44) I/dalvikvm(5006): at android.webkit.JniUtil.getDatabaseDirectory(JniUtil.java:65) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.nativeGetCookie(Native Method) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:109) I/dalvikvm(5006): at android.webkit.CookieManagerClassic.getCookie(CookieManagerClassic.java:96) I/dalvikvm(5006): at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:747) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8352) Need some way to expand an activity's functions, or relay them to a plugin.
[ https://issues.apache.org/jira/browse/CB-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295321#comment-14295321 ] Michael Romanovsky commented on CB-8352: Hi! I did not know that was available. Thanks, it works! I'm only using command line and Notepad++, and was only seeing what was in the documentation... Need some way to expand an activity's functions, or relay them to a plugin. --- Key: CB-8352 URL: https://issues.apache.org/jira/browse/CB-8352 Project: Apache Cordova Issue Type: Improvement Components: Android, CordovaJS Reporter: Michael Romanovsky Labels: cordova, cordova-lib There is already startActivityForResult, which helps me run onActivityResult. I am having trouble integrating this: http://tinyurl.com/kptdph5 as a plugin, however. It calls for extending the main Activity to run the events, but as far as I know, only onActivityResult will forward back to a plugin. Some ideas: 1) A pre-processing step that rewrites the main Activity and adds functions from a specific class into the Activity. 2) ??? 3) PROFIT. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8374) Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml
Holly Schinsky created CB-8374: -- Summary: Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml Key: CB-8374 URL: https://issues.apache.org/jira/browse/CB-8374 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.7.0 Environment: ios Reporter: Holly Schinsky Priority: Minor If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8374) Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml
[ https://issues.apache.org/jira/browse/CB-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-8374: - Description: If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: {code} [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; {code} was: If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml Key: CB-8374 URL: https://issues.apache.org/jira/browse/CB-8374 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.7.0 Environment: ios Reporter: Holly Schinsky Priority: Minor If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: {code} [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8332) Memory leak in loading files from disk with file plugin
[ https://issues.apache.org/jira/browse/CB-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296010#comment-14296010 ] Patrick Richards commented on CB-8332: -- I added the @autoreleasepool to the NSData creation code as mentioned but still seeing the issue with the sample code unfortunately. The best way to test it is to try the project with the auto refresh, and use the instruments built into Xcode (just the ones in Xcode itself are enough to look at) and the memory growing over time. It might not fail on some devices with this particular test but does for me on both an iPhone 6 and iPhone 6+. (The storage space shouldn’t affect things as we’re looking at RAM usage here, but one is 16GB and one is 128GB). Here is a of Xcode screenshot from one run today: https://www.dropbox.com/s/d3wxj0k9g4jy8w2/Screen%20Shot%202015-01-29%20at%208.18.07%20am.png?dl=0 Could you elaborate by what you mean by the VM problem? Also, are you aware of any memory issues related to using iframes? Memory leak in loading files from disk with file plugin --- Key: CB-8332 URL: https://issues.apache.org/jira/browse/CB-8332 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Environment: iOS Reporter: Patrick Richards Assignee: Shazron Abdullah When loading files from disk, the file plugin appears to leak memory. Using instruments it can be narrowed down to -[CDVFilesystemURLProtocol startLoading], which is in CDVFile.m on line 150. (https://github.com/apache/cordova-plugin-file/blob/967ca4d848d6bea0bad5a0d334b8d9f1ea2c4680/src/ios/CDVFile.m#L150) To reproduce: • have the iOS app download a file using plugin-file-transfer • store that file to persistent storage • load that file from disk and the app will leak We have a very simple proof of concept that downloads a large photo, then constantly refreshes an iFrame which triggers loading the photo from persistent storage. The memory usage of the app climbs over time (with various dips at memory warnings), then crashes due to memory pressure. We can upload this sample project/provide a link if needed – there doesn’t appear to be a way to attach files. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8374) Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml
[ https://issues.apache.org/jira/browse/CB-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296011#comment-14296011 ] Shazron Abdullah commented on CB-8374: -- Which means that https://github.com/apache/cordova-ios/blob/fd941c3c7bbf7705087be7c2ecc23ca432036a56/CordovaLib/Classes/CDVWhitelist.m#L244 will never be nil. I think the intent is If the access tag was removed, the default will kick in (i.e. wildcard)? Any comment on this behaviour [~iclelland]? Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml Key: CB-8374 URL: https://issues.apache.org/jira/browse/CB-8374 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.7.0 Environment: ios Reporter: Holly Schinsky Priority: Minor If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: {code} [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8374) Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml
[ https://issues.apache.org/jira/browse/CB-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-8374: - Component/s: (was: CordovaLib) iOS Access origin/whitelist for iOS doesn't default to all if access element missing from config.xml Key: CB-8374 URL: https://issues.apache.org/jira/browse/CB-8374 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.7.0 Environment: ios Reporter: Holly Schinsky Priority: Minor If the access origin=*/ element is left out of the config.xml, the default does not allow all URLs as it should, instead it is set only to the following in the CDVConfigParser.m class: [self.whitelistHosts addObject:@file:///*]; [self.whitelistHosts addObject:@content:///*]; [self.whitelistHosts addObject:@data:///*]; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8376) StatusBar plugin breaks when platform/ios is recreated
Daniel Holth created CB-8376: Summary: StatusBar plugin breaks when platform/ios is recreated Key: CB-8376 URL: https://issues.apache.org/jira/browse/CB-8376 Project: Apache Cordova Issue Type: Bug Components: Plugin Statusbar Affects Versions: Master Environment: XCode Reporter: Daniel Holth I'm using the statusbar plugin on iOS to keep the status bar from overlaying the webview. preference name=StatusBarOverlaysWebView value=false / I put this preference in plugins/ios.json's munge section and in config.xml. If I remove the platforms/ directory and then add the ios platform back in, the statusbar plugin does not load. The status bar is now transparent instead of my preference. The only way to get it reconfigured properly seems to be to remove and re-add the plugin but even this fix does not seem to be completely reliable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7143) OSX platform cannot be installed as described
[ https://issues.apache.org/jira/browse/CB-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296434#comment-14296434 ] Martin Reinhardt commented on CB-7143: -- thats really frustrating ... OSX platform cannot be installed as described - Key: CB-7143 URL: https://issues.apache.org/jira/browse/CB-7143 Project: Apache Cordova Issue Type: Bug Components: OSX Affects Versions: 3.5.0 Environment: OSX 10.9.4 Reporter: Tim Stewart Following instructions as per: https://github.com/apache/cordova-osx Add the Cordova OSX Platform the a CLI project [sic] does not work. I checked out cordova from master, completed all the npm linking as described in the linked instructions and checked cordova version: 3.5.0-0.2.7-dev I then tried to follow this instruction: patch the 2 projects with the patches provided in the patches directory to enable the osx platform. I expected to be able to download and git apply these patches in the git root for each of the two node modules - cordova-cli and cordova-plugman. However, they are not set up correctly for this, and produced errors: error: platforms.js: No such file or directory error: src/platform.js: No such file or directory Indeed, the path locations in each patch do not seem to be vaild for any given location within either module. I thus ended up finding all files named platform.js and platforms.js (there are many, spread throughout the cordova-lib module within both cordova-cli and cordova-plugman), eyeballing them to see which files matched the patch changes, and copy/pasting the changes manually. (8 files in total, as the 4 patched files appear under cordova-lib in each cordova module.) When running cordova platform add osx, I then got an error about an invaild location for the ios-parser. I found the incorrect line in the patched cordova/platform.js and changed it as follows: parser : './metadata/ios_parser', Following this I was able to add the osx platform and run the app. Needless to say, this is a frustrating developer experience. I don't know why the osx platform information code is not included in cordova by default - it would seem to be fairly well isolated from effects on any other platform - but if it is going to be upgradable in this fashion, then the git patches should at least work. If they were designed to work (and ever did work) with a specific version of the cordova modules, or in a different location other than the git root, then that should be stated, instead of instructing the hapless developer to clone cordova from master and providing no further clues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8369) Escaped html markup in plugman npm page
Josh Soref created CB-8369: -- Summary: Escaped html markup in plugman npm page Key: CB-8369 URL: https://issues.apache.org/jira/browse/CB-8369 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Josh Soref Load: https://www.npmjs.com/package/plugman#node-module-usage Actual results: {quote} node amp;gt; require(amp;apos;plugmanamp;apos;\) \{ install: \[Function: installPlugin], uninstall: \[Function: uninstallPlugin], fetch: \[Function: fetchPlugin], search: \[Function: search], publish: \[Function: publish], unpublish: \[Function: unpublish], adduser: \[Function: adduser], prepare: \[Function: handlePrepare], create: \[Function: create], platform: \[Function: platform] } {quote} Expected results: No *amp;gt;* / *amp;apos;* -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-7979) Each plugin doc should have a ## Installation section
[ https://issues.apache.org/jira/browse/CB-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7979. -- Resolution: Fixed Each plugin doc should have a ## Installation section - Key: CB-7979 URL: https://issues.apache.org/jira/browse/CB-7979 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera, Plugin Statusbar Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref It'd be nice if we consistently had a ## Installation section (nearly every does) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8212) update coho verify-archive refs for SetUpGpg
[ https://issues.apache.org/jira/browse/CB-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-8212. -- Resolution: Fixed update coho verify-archive refs for SetUpGpg Key: CB-8212 URL: https://issues.apache.org/jira/browse/CB-8212 Project: Apache Cordova Issue Type: Bug Components: Coho Reporter: Josh Soref Assignee: Josh Soref The current code spits out: {quote} Refer to https://wiki.apache.org/cordova/SetUpGpg for how to set up gpg {quote} That page just says: {quote} Moved to: https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md {quote} For those of us who occasionally live with metered bandwidth, it's really frustrating (and expensive) to be sent on a wild goose chase. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8306) parseUri mishandles http://foo/bar?a...@b.comwhatever
[ https://issues.apache.org/jira/browse/CB-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-8306. -- Resolution: Fixed parseUri mishandles http://foo/bar?a...@b.comwhatever --- Key: CB-8306 URL: https://issues.apache.org/jira/browse/CB-8306 Project: Apache Cordova Issue Type: Bug Components: BlackBerry Affects Versions: 3.7.0 Reporter: Josh Soref Assignee: Josh Soref A user hit this while making an XMLHttpRequest with some whitelist stuff... -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-7033) cordova platform check command not working
[ https://issues.apache.org/jira/browse/CB-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7033. -- Resolution: Fixed cordova platform check command not working -- Key: CB-7033 URL: https://issues.apache.org/jira/browse/CB-7033 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Victor Adrian Sosa Herrera Assignee: Josh Soref Priority: Minor I have an app with Android installed and I know it was created with Cordova 3.3.1-0.1.2. After running this command with a 3.4.1-1.0. CLI I get the following {{$ cordova platform check}} {{All platforms are up-to-date.}} But after running cordova platform ls I get the following {{$ cordova platform ls}} {{Installed platforms: android broken}} {{Available platforms: amazon-fireos, blackberry10, firefoxos, ubuntu}} Using _platform check_ arguments I don't get the result I'm looking for (a platform out-of-date), while using _platform ls_ it's not very clear, but I presume the _broken_ platform is like an out-of-date message -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-7859) coho foreach should provide help when no command is specified
[ https://issues.apache.org/jira/browse/CB-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7859. -- Resolution: Fixed coho foreach should provide help when no command is specified - Key: CB-7859 URL: https://issues.apache.org/jira/browse/CB-7859 Project: Apache Cordova Issue Type: Bug Components: Coho Affects Versions: Master Reporter: Josh Soref Assignee: Josh Soref currently you get an amusing error: {quote} $ coho foreach Running from ~/Cordova cordova-android/ === Executing: /bin/bash -c /bin/bash: undefined: command not found cordova-ios/ === Executing: /bin/bash -c /bin/bash: undefined: command not found ... {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6418) Remove copyright statements
[ https://issues.apache.org/jira/browse/CB-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295354#comment-14295354 ] ASF GitHub Bot commented on CB-6418: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/181 CB-6418 Remove copyright statements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry cb_6418 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #181 commit 84f8f5d3eb097c1e383374201d183ceceacc292c Author: Josh Soref jso...@blackberry.com Date: 2015-01-28T16:29:44Z CB-6418 Remove copyright statements Remove copyright statements --- Key: CB-6418 URL: https://issues.apache.org/jira/browse/CB-6418 Project: Apache Cordova Issue Type: Task Components: BlackBerry Affects Versions: 3.4.0 Reporter: Martin Gonzalez Assignee: Josh Soref Labels: blackberry, copyright, legal Fix For: 3.6.0 There are several copyright statements in 'cordova-blackberry' that it shouldn't be there. https://github.com/blackberry/cordova-blackberry/blob/cb_6398/blackberry10/bin/templates/project/cordova/lib/params.js#L2 https://github.com/blackberry/cordova-blackberry/blob/cb_6398/blackberry10/bin/templates/project/cordova/lib/debugtoken-helper.js#L2 According to https://www.apache.org/legal/src-headers.html#headers It is required remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-6418) Remove copyright statements
[ https://issues.apache.org/jira/browse/CB-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-6418. -- Resolution: Fixed Fix Version/s: (was: 3.6.0) Remove copyright statements --- Key: CB-6418 URL: https://issues.apache.org/jira/browse/CB-6418 Project: Apache Cordova Issue Type: Task Components: BlackBerry Affects Versions: 3.4.0 Reporter: Martin Gonzalez Assignee: Josh Soref Labels: blackberry, copyright, legal There are several copyright statements in 'cordova-blackberry' that it shouldn't be there. https://github.com/blackberry/cordova-blackberry/blob/cb_6398/blackberry10/bin/templates/project/cordova/lib/params.js#L2 https://github.com/blackberry/cordova-blackberry/blob/cb_6398/blackberry10/bin/templates/project/cordova/lib/debugtoken-helper.js#L2 According to https://www.apache.org/legal/src-headers.html#headers It is required remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8065) update cordova-js docs
[ https://issues.apache.org/jira/browse/CB-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-8065. -- Resolution: Fixed update cordova-js docs -- Key: CB-8065 URL: https://issues.apache.org/jira/browse/CB-8065 Project: Apache Cordova Issue Type: Bug Components: CordovaJS Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Priority: Minor The documentation mentions old versions of node/npm, but the code requires newer versions... -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-7977) mention deviceready in plugin docs
[ https://issues.apache.org/jira/browse/CB-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref updated CB-7977: --- Description: for a in cordova-plugin-\*; do test -f $a/doc/index.md grep -l deviceready $a/doc/index.md || (grep -L deviceready $a/doc/index.md |sed -e 's/^/no deviceready in: /'; grep -lr decideready $a/*); done 2/dev/null |sort cordova-plugin-battery-status/doc/index.md cordova-plugin-device/doc/index.md cordova-plugin-network-information/doc/index.md cordova-plugin-splashscreen/doc/index.md no deviceready in: cordova-plugin-camera/doc/index.md no deviceready in: cordova-plugin-console/doc/index.md no deviceready in: cordova-plugin-contacts/doc/index.md no deviceready in: cordova-plugin-device-motion/doc/index.md no deviceready in: cordova-plugin-device-orientation/doc/index.md no deviceready in: cordova-plugin-dialogs/doc/index.md no deviceready in: cordova-plugin-file-transfer/doc/index.md no deviceready in: cordova-plugin-file/doc/index.md no deviceready in: cordova-plugin-geolocation/doc/index.md no deviceready in: cordova-plugin-globalization/doc/index.md no deviceready in: cordova-plugin-inappbrowser/doc/index.md no deviceready in: cordova-plugin-media-capture/doc/index.md no deviceready in: cordova-plugin-media/doc/index.md no deviceready in: cordova-plugin-statusbar/doc/index.md no deviceready in: cordova-plugin-vibration/doc/index.md was: for a in cordova-plugin-*; do test -f $a/doc/index.md grep -l deviceready $a/doc/index.md || (grep -L deviceready $a/doc/index.md |sed -e 's/^/no deviceready in: /'; grep -lr decideready $a/*); done 2/dev/null |sort cordova-plugin-battery-status/doc/index.md cordova-plugin-device/doc/index.md cordova-plugin-network-information/doc/index.md cordova-plugin-splashscreen/doc/index.md no deviceready in: cordova-plugin-camera/doc/index.md no deviceready in: cordova-plugin-console/doc/index.md no deviceready in: cordova-plugin-contacts/doc/index.md no deviceready in: cordova-plugin-device-motion/doc/index.md no deviceready in: cordova-plugin-device-orientation/doc/index.md no deviceready in: cordova-plugin-dialogs/doc/index.md no deviceready in: cordova-plugin-file-transfer/doc/index.md no deviceready in: cordova-plugin-file/doc/index.md no deviceready in: cordova-plugin-geolocation/doc/index.md no deviceready in: cordova-plugin-globalization/doc/index.md no deviceready in: cordova-plugin-inappbrowser/doc/index.md no deviceready in: cordova-plugin-media-capture/doc/index.md no deviceready in: cordova-plugin-media/doc/index.md no deviceready in: cordova-plugin-statusbar/doc/index.md no deviceready in: cordova-plugin-vibration/doc/index.md mention deviceready in plugin docs -- Key: CB-7977 URL: https://issues.apache.org/jira/browse/CB-7977 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera, Plugin Console, Plugin Device Motion, Plugin Device Orientation, Plugin Dialogs, Plugin File, Plugin File Transfer, Plugin Geolocation, Plugin Globalization, Plugin InAppBrowser, Plugin Media, Plugin Media Capture, Plugin Statusbar, Plugin Vibration Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref for a in cordova-plugin-\*; do test -f $a/doc/index.md grep -l deviceready $a/doc/index.md || (grep -L deviceready $a/doc/index.md |sed -e 's/^/no deviceready in: /'; grep -lr decideready $a/*); done 2/dev/null |sort cordova-plugin-battery-status/doc/index.md cordova-plugin-device/doc/index.md cordova-plugin-network-information/doc/index.md cordova-plugin-splashscreen/doc/index.md no deviceready in: cordova-plugin-camera/doc/index.md no deviceready in: cordova-plugin-console/doc/index.md no deviceready in: cordova-plugin-contacts/doc/index.md no deviceready in: cordova-plugin-device-motion/doc/index.md no deviceready in: cordova-plugin-device-orientation/doc/index.md no deviceready in: cordova-plugin-dialogs/doc/index.md no deviceready in: cordova-plugin-file-transfer/doc/index.md no deviceready in: cordova-plugin-file/doc/index.md no deviceready in: cordova-plugin-geolocation/doc/index.md no deviceready in: cordova-plugin-globalization/doc/index.md no deviceready in: cordova-plugin-inappbrowser/doc/index.md no deviceready in: cordova-plugin-media-capture/doc/index.md no deviceready in: cordova-plugin-media/doc/index.md no deviceready in: cordova-plugin-statusbar/doc/index.md no deviceready in: cordova-plugin-vibration/doc/index.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-7860) Fix help
[ https://issues.apache.org/jira/browse/CB-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Soref closed CB-7860. -- Resolution: Fixed Fix help Key: CB-7860 URL: https://issues.apache.org/jira/browse/CB-7860 Project: Apache Cordova Issue Type: Bug Components: Coho Affects Versions: Master Reporter: Josh Soref Assignee: Josh Soref 1. coho help repo-clone suggests coho clone as a command, but that doesn't work. 2. some commands suggest -r foo, some --repo=foo, some don't suggest anything. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8370) Plugman 0.22.18-dev fails to publish with ugly path.join error
Josh Soref created CB-8370: -- Summary: Plugman 0.22.18-dev fails to publish with ugly path.join error Key: CB-8370 URL: https://issues.apache.org/jira/browse/CB-8370 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Josh Soref {quote} $ plugman publish --debug Error Code: undefined Arguments to path.join must be strings TypeError: Arguments to path.join must be strings at path.js:360:15 at Array.filter (native) at Object.exports.join (path.js:358:36) at new PluginInfo (cordova-lib/src/PluginInfo.js:285:26) at cordova-lib/src/plugman/registry/manifest.js:43:26 at _fulfilled (cordova-lib/node_modules/q/q.js:787:54) at self.promiseDispatch.done (cordova-lib/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (cordova-lib/node_modules/q/q.js:749:13) at cordova-lib/node_modules/q/q.js:810:14 at flush (cordova-lib/node_modules/q/q.js:108:17) {quote} If you must provide a path to publish, then when you don't, there should be a pretty error message that says so, e.g. the usage message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8370) Plugman 0.22.18-dev fails to publish with ugly path.join error
[ https://issues.apache.org/jira/browse/CB-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295560#comment-14295560 ] ASF subversion and git services commented on CB-8370: - Commit 89795f21f1465c3f3c74d64c416684337d50d320 in cordova-lib's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=89795f2 ] CB-8370 Make plugman publish without args default to CWD Plugman 0.22.18-dev fails to publish with ugly path.join error -- Key: CB-8370 URL: https://issues.apache.org/jira/browse/CB-8370 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Josh Soref {quote} $ plugman publish --debug Error Code: undefined Arguments to path.join must be strings TypeError: Arguments to path.join must be strings at path.js:360:15 at Array.filter (native) at Object.exports.join (path.js:358:36) at new PluginInfo (cordova-lib/src/PluginInfo.js:285:26) at cordova-lib/src/plugman/registry/manifest.js:43:26 at _fulfilled (cordova-lib/node_modules/q/q.js:787:54) at self.promiseDispatch.done (cordova-lib/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (cordova-lib/node_modules/q/q.js:749:13) at cordova-lib/node_modules/q/q.js:810:14 at flush (cordova-lib/node_modules/q/q.js:108:17) {quote} If you must provide a path to publish, then when you don't, there should be a pretty error message that says so, e.g. the usage message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8370) Plugman 0.22.18-dev fails to publish with ugly path.join error
[ https://issues.apache.org/jira/browse/CB-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-8370. --- Resolution: Fixed Fixed in 0.22.18-dev Plugman 0.22.18-dev fails to publish with ugly path.join error -- Key: CB-8370 URL: https://issues.apache.org/jira/browse/CB-8370 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Josh Soref {quote} $ plugman publish --debug Error Code: undefined Arguments to path.join must be strings TypeError: Arguments to path.join must be strings at path.js:360:15 at Array.filter (native) at Object.exports.join (path.js:358:36) at new PluginInfo (cordova-lib/src/PluginInfo.js:285:26) at cordova-lib/src/plugman/registry/manifest.js:43:26 at _fulfilled (cordova-lib/node_modules/q/q.js:787:54) at self.promiseDispatch.done (cordova-lib/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (cordova-lib/node_modules/q/q.js:749:13) at cordova-lib/node_modules/q/q.js:810:14 at flush (cordova-lib/node_modules/q/q.js:108:17) {quote} If you must provide a path to publish, then when you don't, there should be a pretty error message that says so, e.g. the usage message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-4904) Implement Globalization for Windows8
[ https://issues.apache.org/jira/browse/CB-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-4904. - Resolution: Fixed https://github.com/apache/cordova-plugin-globalization/blob/master/doc/index.md Implement Globalization for Windows8 Key: CB-4904 URL: https://issues.apache.org/jira/browse/CB-4904 Project: Apache Cordova Issue Type: Bug Components: Plugin Globalization, Windows 8 Affects Versions: 3.0.0 Reporter: Jesse MacFadyen Assignee: Jesse MacFadyen Not yet implemented on Windows 8. Align this platform with the others. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-2617) readAsBinaryString and readAsArrayBuffer for WP
[ https://issues.apache.org/jira/browse/CB-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen reopened CB-2617: - readAsBinaryString and readAsArrayBuffer for WP --- Key: CB-2617 URL: https://issues.apache.org/jira/browse/CB-2617 Project: Apache Cordova Issue Type: Sub-task Components: WP8 Affects Versions: 2.6.0 Reporter: Braden Shepherdson Assignee: Jesse MacFadyen Priority: Minor Fix For: 3.6.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-2617) readAsBinaryString and readAsArrayBuffer for WP
[ https://issues.apache.org/jira/browse/CB-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-2617. - Resolution: Fixed readAsBinaryString and readAsArrayBuffer for WP --- Key: CB-2617 URL: https://issues.apache.org/jira/browse/CB-2617 Project: Apache Cordova Issue Type: Sub-task Components: WP8 Affects Versions: 2.6.0 Reporter: Braden Shepherdson Assignee: Jesse MacFadyen Priority: Minor Fix For: 3.6.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7641) [iOS 8][Camera] Newly Taken Picture Previews are Black
[ https://issues.apache.org/jira/browse/CB-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295580#comment-14295580 ] Justin Noel commented on CB-7641: - FYI: Issue still presents in latest iOS update 8.1.3 [iOS 8][Camera] Newly Taken Picture Previews are Black -- Key: CB-7641 URL: https://issues.apache.org/jira/browse/CB-7641 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Camera Affects Versions: 3.3.0 Environment: iOS 8 on an iPhone 6 Reporter: Nathan Beigel When making the following call using iOS 8 on an iPhone 6 then taking a new picture, the XCode console display the error *Snapshotting a view that has not been rendered results in an empty snapshot. Ensure your view has been rendered at least once before snapshotting or snapshot after screen updates.* and the image preview screen becomes completely black: {noformat} navigator.camera.getPicture( function() { ... }, function() { ... }, { quality: 40, destinationType: Camera.DestinationType.DATA_URL, sourceType : Camera.PictureSourceType.CAMERA, allowEdit : false, encodingType: Camera.EncodingType.JPEG, correctOrientation: true, targetWidth: 600, targetHeight: 800, saveToPhotoAlbum: true } ); {noformat} The Re-Take and Use Photo buttons at the bottom of the screen appear and function properly though. I'm using the latest camera plugin code base located at: https://github.com/apache/cordova-plugin-camera This behavior is not occurring using the same code with iOS 7.1 on an iPhone 5. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8182) cordova run browser will serve app files over http
[ https://issues.apache.org/jira/browse/CB-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295615#comment-14295615 ] ASF GitHub Bot commented on CB-8182: Github user kirkshoop commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71892622 no prayer was involved. As I said, if there are good scenarios for `cordova serve` then it should continue to exist. You have explained that it should exist and I agree with you. The scenarios for `cordova run browser` are different and require that the project be hosted over http in the browser platform as well. Currently, a file url is used which causes issues with CORS headers and other effects that cause `cordova run browser` with a file url to behave completely differently than it will when actually hosted as a web site. These differences need to be minimized to ensure that more bugs can be reproduced and fixed locally. cordova run browser will serve app files over http -- Key: CB-8182 URL: https://issues.apache.org/jira/browse/CB-8182 Project: Apache Cordova Issue Type: Improvement Components: Browser Reporter: Kirk Shoop -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295698#comment-14295698 ] ASF GitHub Bot commented on CB-8123: GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/155 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms. Also adds support for `src` attribute as an alias for the `Include` attribute on the `lib-file` element (since `src` is documented, but `Include` is used by existing plugins). Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform). As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8123-final Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit 8b6f7b9b443fe6b35e070bd1ad8ff81df53f559f Author: Tim Barham tim.bar...@microsoft.com Date: 2015-01-28T19:15:39Z CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms. Also adds support for `src` attribute as an alias for the `Include` attribute on the `lib-file` element (since `src` is documented, but `Include` is used by existing plugins). Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform). As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files. Note that I plan to rename some windows8 files and folders to windows, and jsproj.js to jsprojManager.js in a subsequent commit. commit 48852eefb20840149fa9ada28082e6cb0a2ff208 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-01-28T19:30:27Z CB-8123 Rename windows platform related files. Renames `windows8` plugin platform folders in tests to `windows`. Renames `jsproj.js` to `jsprojManager.js`. commit 22a214f217014b8c2df0348025d734cdf03580a7 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-01-28T19:31:48Z CB-8123 Rename further windows platform related files. Renames `windows8.spec.js` to `windows.spec.js`. Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform --- Key: CB-8123 URL: https://issues.apache.org/jira/browse/CB-8123 Project: Apache Cordova Issue Type: Improvement Components: Plugins, Windows Reporter: Tim Barham Original Estimate: 72h Remaining Estimate: 72h Because Cordova's windows platform can target multiple target platforms, projects and frameworks referenced by the plugin may need to target only a subset of those platforms. To enable this, support the following attributes on the lib-file and framework elements: 1. device - indicates the reference is specific to a target device. Supported values are phone, windows or all (default is all). 2. versions - specify platform versions the reference supports (node semantic version ranges supported). Default is to support all versions. 3. arch - indicates the reference is specific to a particular chip architecture (x86 or x64). The arch attribute should result in a Condition='$(Platform)'=='XXX attribute on the reference. The other attributes will impact which generated jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8123) Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform
[ https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295701#comment-14295701 ] ASF GitHub Bot commented on CB-8123: GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-docs/pull/263 CB-8123 Plugin references can target specific windows platforms. Adds documentation for the new `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the `windows` platform of `plugin.xml`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-8123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit 85ca7c92b18c59f1071c9a5d588c0744343b1a50 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-01-20T00:55:04Z CB-8123 Plugin references can target specific windows platforms. Adds documentation for the new target, versions and arch attributes on lib-file and framework elements in the windows platform of plugin.xml. Enable version, device, and chip arch specific library / dll / winmd references in plugins for the Windows platform --- Key: CB-8123 URL: https://issues.apache.org/jira/browse/CB-8123 Project: Apache Cordova Issue Type: Improvement Components: Plugins, Windows Reporter: Tim Barham Original Estimate: 72h Remaining Estimate: 72h Because Cordova's windows platform can target multiple target platforms, projects and frameworks referenced by the plugin may need to target only a subset of those platforms. To enable this, support the following attributes on the lib-file and framework elements: 1. device - indicates the reference is specific to a target device. Supported values are phone, windows or all (default is all). 2. versions - specify platform versions the reference supports (node semantic version ranges supported). Default is to support all versions. 3. arch - indicates the reference is specific to a particular chip architecture (x86 or x64). The arch attribute should result in a Condition='$(Platform)'=='XXX attribute on the reference. The other attributes will impact which generated jsproj files the reference is actually added to. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org