[jira] [Updated] (CB-10797) WKWebView CSS Position:Fixed Moves
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Summary: WKWebView CSS Position:Fixed Moves (was: WKWebView Engine CSS Fixed Position Bugs) > WKWebView CSS Position:Fixed Moves > -- > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to resolve a > similar problem in Android we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView if the latter. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when > you scroll down, the header adds a class to position-fix the navigation at > the top, broken in WKWebView) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView if the latter. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView if the latter. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to address a > similar problem in Android we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView if the latter. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when > you scroll down, the header adds a class to position-fix the navigation at > the top, broken in WKWebView) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to resolve a similar problem in Android we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView if the latter. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView if the latter. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to resolve a > similar problem in Android we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView if the latter. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when > you scroll down, the header adds a class to position-fix the navigation at > the top, broken in WKWebView) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView in the latter case. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView in the latter case. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to address a > similar problem in Android (among other issues) we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView in the latter case. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when > you scroll down, the header adds a class to position-fix the navigation at > the top, broken in WKWebView) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView if the latter. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView in the latter case. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when you scroll down, the header adds a class to position-fix the navigation at the top, broken in WKWebView) > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to address a > similar problem in Android (among other issues) we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView if the latter. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 (when > you scroll down, the header adds a class to position-fix the navigation at > the top, broken in WKWebView) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView in the latter case. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to address a > similar problem in Android (among other issues) we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk since support for iOS is coming soon. Not sure if this is an Apple > or Cordova bug; I'd prefer to stick with WKWebView in the latter case. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They move and often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They can often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They move and often break the layout -- to address a > similar problem in Android (among other issues) we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk as we did with Android, since support for iOS is coming soon. Not > sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They can often break the layout -- to address a similar problem in Android (among other issues) we had to go with Crosswalk. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. Not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. Example of affected app: https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 was: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They can sometimes break the layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They can often break the layout -- to address a similar > problem in Android (among other issues) we had to go with Crosswalk. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk as we did with Android, since support for iOS is coming soon. Not > sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView. > Example of affected app: > https://itunes.apple.com/en/app/apex-online-racing/id1087710643?mt=8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine -- they are not fixed. They can sometimes break the layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. was: CSS fixed position elements exhibit major problems in the WKWebView Engine. Sometimes they don't appear, move around, other times they break a page's layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine -- > they are not fixed. They can sometimes break the layout. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk as we did with Android, since support for iOS is coming soon. > I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with > WKWebView and not inflate the IPA size. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
[ https://issues.apache.org/jira/browse/CB-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vB Results, LLC. updated CB-10797: -- Description: CSS fixed position elements exhibit major problems in the WKWebView Engine. Sometimes they don't appear, move around, other times they break a page's layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. was: CSS fixed position elements exhibit major problems in the WKWebView Engine. Sometimes they don't appear, other times they break a page's layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. > WKWebView Engine CSS Fixed Position Bugs > > > Key: CB-10797 > URL: https://issues.apache.org/jira/browse/CB-10797 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Affects Versions: 6.0.0, 5.4.1 > Environment: iOS 9 > Cordova 6.0.0 > Cordova-iOS 4.1.0 > Cordova-Plugin-WkWebView-Engine 1.0.1 >Reporter: vB Results, LLC. > > CSS fixed position elements exhibit major problems in the WKWebView Engine. > Sometimes they don't appear, move around, other times they break a page's > layout. > This isn't present in Mobile Safari so we've been looking at moving to > Crosswalk as we did with Android, since support for iOS is coming soon. > I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with > WKWebView and not inflate the IPA size. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10797) WKWebView Engine CSS Fixed Position Bugs
vB Results, LLC. created CB-10797: - Summary: WKWebView Engine CSS Fixed Position Bugs Key: CB-10797 URL: https://issues.apache.org/jira/browse/CB-10797 Project: Apache Cordova Issue Type: Bug Components: Plugin WKWebViewEngine Affects Versions: 6.0.0, 5.4.1 Environment: iOS 9 Cordova 6.0.0 Cordova-iOS 4.1.0 Cordova-Plugin-WkWebView-Engine 1.0.1 Reporter: vB Results, LLC. CSS fixed position elements exhibit major problems in the WKWebView Engine. Sometimes they don't appear, other times they break a page's layout. This isn't present in Mobile Safari so we've been looking at moving to Crosswalk as we did with Android, since support for iOS is coming soon. I'm not sure if this is an Apple or Cordova bug; I'd prefer to stick with WKWebView and not inflate the IPA size. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView
[ https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181965#comment-15181965 ] vB Results, LLC. commented on CB-10228: --- There is only a fix for iOS 9; for iOS 8 there is no way to set it > AppendUserAgent not working with WKWebView > -- > > Key: CB-10228 > URL: https://issues.apache.org/jira/browse/CB-10228 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: vB Results, LLC. >Assignee: Shazron Abdullah > Labels: triaged, wkwebview-1.0.2 > > Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 > and AppendUserAgent is the most lightweight way to detect whether or not we > are in the app on a remote site. Please fix, the lack of this means we > cannot benefit from using WKWebView :( -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10709) Allow-navigation rule for iFrame urls on cordova-ios
[ https://issues.apache.org/jira/browse/CB-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181952#comment-15181952 ] Harsha Kiran commented on CB-10709: --- Yes Android allows external urls if loaded in an iframe, without being whitelisted. > Allow-navigation rule for iFrame urls on cordova-ios > > > Key: CB-10709 > URL: https://issues.apache.org/jira/browse/CB-10709 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Whitelist >Affects Versions: 6.0.0 >Reporter: Harsha Kiran >Priority: Critical > Labels: cordova-ios-4.1.1, triaged > > Currently with Whitelist plugin set to
[jira] [Commented] (CB-10752) ios 6 lost 20px in the statusbar when rotate the device (portrait mode)
[ https://issues.apache.org/jira/browse/CB-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181900#comment-15181900 ] jcesarmobile commented on CB-10752: --- I've found the issue and I will fix it tomorrow > ios 6 lost 20px in the statusbar when rotate the device (portrait mode) > --- > > Key: CB-10752 > URL: https://issues.apache.org/jira/browse/CB-10752 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: phone 3gs, ios 6 >Reporter: Jorge Chávez >Assignee: jcesarmobile >Priority: Minor > > when the app its fixed on portrait and you rotate the device lost the 20px in > the top and the webview stay under the statusbar. this bug its just in ios 6 > It happens to if you execute location.reload(); > > > > StatusBar.show(); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10709) Allow-navigation rule for iFrame urls on cordova-ios
[ https://issues.apache.org/jira/browse/CB-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181899#comment-15181899 ] jcesarmobile commented on CB-10709: --- Thanks, the iOS part it's clearer now. But you mean that android apps can load external sites even if they are not whitelisted with the allow-navigation? I don't think they should work > Allow-navigation rule for iFrame urls on cordova-ios > > > Key: CB-10709 > URL: https://issues.apache.org/jira/browse/CB-10709 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Whitelist >Affects Versions: 6.0.0 >Reporter: Harsha Kiran >Priority: Critical > Labels: cordova-ios-4.1.1, triaged > > Currently with Whitelist plugin set to
[jira] [Commented] (CB-10631) device is not populated in iOS 5.1.1
[ https://issues.apache.org/jira/browse/CB-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181893#comment-15181893 ] jcesarmobile commented on CB-10631: --- Did you send the mail as I told you? I haven't seen it. BTW, on cordova 4.x.x the apps crash on ios 6 and older, that's another reason to not add this. But send the mail so it can be discussed > device is not populated in iOS 5.1.1 > > > Key: CB-10631 > URL: https://issues.apache.org/jira/browse/CB-10631 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Device > Environment: iOS 5.1.1 >Reporter: Thomas Allen >Priority: Minor > Labels: iOS, pendingPR, triaged > Original Estimate: 0h > Remaining Estimate: 0h > > The device plugin doesn't work in iOS 5.1.1 because the unique device > identifier uses identifierForVendor to get the device uuid. However this is > not valid in iOS older than 6.0. > In the method uniqueAppInstanceIdentifier, there is a reference to > maintaining backward compatibility for versions that didn't use > identiferForVendor. Unfortunately the code only works if the app had > previously been installed on that device (because it looks for the CDVUUID > that was previously stored on the device). If the install is new, this > app_uuid is nil and it tries to use identifierForVendor. > I realize that iOS 5 is no longer supported in Cordova, but since the code > attempts to be backward compatible (based on the inline comments), I figured > this could be fixed with a few lines of code (which I have done and will > submit shortly). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10709) Allow-navigation rule for iFrame urls on cordova-ios
[ https://issues.apache.org/jira/browse/CB-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181889#comment-15181889 ] Harsha Kiran commented on CB-10709: --- [~jcesarmobile] I've updated, let me know if that works. I have a fix for this, will create a PR by tomorrow. > Allow-navigation rule for iFrame urls on cordova-ios > > > Key: CB-10709 > URL: https://issues.apache.org/jira/browse/CB-10709 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Whitelist >Affects Versions: 6.0.0 >Reporter: Harsha Kiran >Priority: Critical > Labels: cordova-ios-4.1.1, triaged > > Currently with Whitelist plugin set to
[jira] [Updated] (CB-10709) Allow-navigation rule for iFrame urls on cordova-ios
[ https://issues.apache.org/jira/browse/CB-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsha Kiran updated CB-10709: -- Description: Currently with Whitelist plugin set to
[jira] [Updated] (CB-10752) ios 6 lost 20px in the statusbar when rotate the device (portrait mode)
[ https://issues.apache.org/jira/browse/CB-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-10752: -- Description: when the app its fixed on portrait and you rotate the device lost the 20px in the top and the webview stay under the statusbar. this bug its just in ios 6 It happens to if you execute location.reload(); StatusBar.show(); was: when the app its fixed on portrait and you rotate the device lost the 20px in the top and the webview stay under the statusbar. this bug its just in ios 6 StatusBar.show(); > ios 6 lost 20px in the statusbar when rotate the device (portrait mode) > --- > > Key: CB-10752 > URL: https://issues.apache.org/jira/browse/CB-10752 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: phone 3gs, ios 6 >Reporter: Jorge Chávez >Assignee: jcesarmobile >Priority: Minor > > when the app its fixed on portrait and you rotate the device lost the 20px in > the top and the webview stay under the statusbar. this bug its just in ios 6 > It happens to if you execute location.reload(); > > > > StatusBar.show(); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10772) ios 6 lost 20px in the statusbar when location.reload()
[ https://issues.apache.org/jira/browse/CB-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-10772. - Resolution: Duplicate The problem is the same as CB-10752, just another way of reproducing the issue. Closing this and adding the details there > ios 6 lost 20px in the statusbar when location.reload() > --- > > Key: CB-10772 > URL: https://issues.apache.org/jira/browse/CB-10772 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: ios 6 >Reporter: Jorge Chávez >Assignee: jcesarmobile >Priority: Minor > > when you use location.reload() for restart the app, the statusbar overlay the > webview (lost the 20px in the top). im using ios 6 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10752) ios 6 lost 20px in the statusbar when rotate the device (portrait mode)
[ https://issues.apache.org/jira/browse/CB-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181873#comment-15181873 ] Jorge Chávez commented on CB-10752: --- Hello, im using cli-5.2.0 (ios 3.9.1 / android 4.1.1) compiling with phonegap build. > ios 6 lost 20px in the statusbar when rotate the device (portrait mode) > --- > > Key: CB-10752 > URL: https://issues.apache.org/jira/browse/CB-10752 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: phone 3gs, ios 6 >Reporter: Jorge Chávez >Assignee: jcesarmobile >Priority: Minor > > when the app its fixed on portrait and you rotate the device lost the 20px in > the top and the webview stay under the statusbar. this bug its just in ios 6 > > > > StatusBar.show(); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10752) ios 6 lost 20px in the statusbar when rotate the device (portrait mode)
[ https://issues.apache.org/jira/browse/CB-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181870#comment-15181870 ] jcesarmobile commented on CB-10752: --- Which CLI version are you using? I can't run latest cordova on my iOS 6 device > ios 6 lost 20px in the statusbar when rotate the device (portrait mode) > --- > > Key: CB-10752 > URL: https://issues.apache.org/jira/browse/CB-10752 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: phone 3gs, ios 6 >Reporter: Jorge Chávez >Assignee: jcesarmobile >Priority: Minor > > when the app its fixed on portrait and you rotate the device lost the 20px in > the top and the webview stay under the statusbar. this bug its just in ios 6 > > > > StatusBar.show(); -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10753) InAppBrowser will not work with iframe embedded
[ https://issues.apache.org/jira/browse/CB-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181845#comment-15181845 ] Timo Ernst commented on CB-10753: - Nah, I tried using a link with target=_blank and it works except if the link is within an iframe. Also, I tried to use window.open(url, '_blank') within the iframe but that also doesn't work. I don't have control of the content within the iframe anyway, so replacing the link with something else is not possible. > InAppBrowser will not work with iframe embedded > --- > > Key: CB-10753 > URL: https://issues.apache.org/jira/browse/CB-10753 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin InAppBrowser >Reporter: Timo Ernst > > When a Cordova app has an iframe within its index.html page and this iframe > has a link with target set to "_blank", then InAppBrowser will not open a new > webview layer. Instead, the whole root webview of the app will be redirected > to the url set in the link and there is no way back! This is a true nightmare > and needs to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10709) Allow-navigation rule for iFrame urls on cordova-ios
[ https://issues.apache.org/jira/browse/CB-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181840#comment-15181840 ] jcesarmobile commented on CB-10709: --- Can you reword the description? It seems to me that what you tell is contradictory, sometimes you say that allow-navigation works on iframes and then you say that it doesn't > Allow-navigation rule for iFrame urls on cordova-ios > > > Key: CB-10709 > URL: https://issues.apache.org/jira/browse/CB-10709 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Whitelist >Affects Versions: 6.0.0 >Reporter: Harsha Kiran >Priority: Critical > Labels: cordova-ios-4.1.1, triaged > > Currently with Whitelist plugin set to
[jira] [Commented] (CB-10753) InAppBrowser will not work with iframe embedded
[ https://issues.apache.org/jira/browse/CB-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181839#comment-15181839 ] jcesarmobile commented on CB-10753: --- links with target set to "_blank" don't open the inAppBrowser, you have to use the inAppBrowser API to open the link {code} cordova.InAppBrowser.open('http://apache.org', '_blank'); {code} > InAppBrowser will not work with iframe embedded > --- > > Key: CB-10753 > URL: https://issues.apache.org/jira/browse/CB-10753 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin InAppBrowser >Reporter: Timo Ernst > > When a Cordova app has an iframe within its index.html page and this iframe > has a link with target set to "_blank", then InAppBrowser will not open a new > webview layer. Instead, the whole root webview of the app will be redirected > to the url set in the link and there is no way back! This is a true nightmare > and needs to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181833#comment-15181833 ] jcesarmobile commented on CB-10796: --- Yes, I fully understand the problem and saw the video. I think it's you who doesn't fully understand how the statusbar plugin works, do some tests with this code to understand how it's supposed to work, click the overlay and don't overlay buttons a few times with and without the in-call status bar. https://gist.github.com/jcesarmobile/114fdb8b771837440752 The thing is, it wasn't working fine in 1.0.1 and it was fixed, and now it works as it's supposed. So, according to you, if you have the StatusBarOverlaysWebView set to true, what means that the statusbar is over your app covering it, if the in-call statusbar appears, your content should be pushed 20 points down? why? Why do you use the statusbar plugin? if you don't use it, the app will behave as you want. > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byoungro So resolved CB-10328. -- Resolution: Fixed > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byoungro So closed CB-10328. > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byoungro So resolved CB-10314. -- Resolution: Fixed > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byoungro So closed CB-10314. > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181814#comment-15181814 ] ASF GitHub Bot commented on CB-10328: - Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/402#issuecomment-192706126 Thanks for merging, @vladimir-kotikov > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181811#comment-15181811 ] ASF GitHub Bot commented on CB-10314: - Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-192706090 Thank you for merging, @vladimir-kotikov > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Baker reopened CB-10796: --- I tried that but it creates another problem in that my black status bar suddenly pops in while the splash screen is showing which looks ugly. I think you're not fully understanding the problem. Did you watch the video I attached? Why should this work as expected in 1.0.1 but then change in 2.0.0? > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Issue Comment Deleted] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Baker updated CB-10796: -- Comment: was deleted (was: I tried that but it creates another problem in that my black status bar suddenly pops in while the splash screen is showing which looks ugly. I think you're not fully understanding the problem. Did you watch the video I attached? Why should this work as expected in 1.0.1 but then change in 2.0.0?) > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181805#comment-15181805 ] Martin Baker commented on CB-10796: --- I tried that but it creates another problem in that my black status bar suddenly pops in while the splash screen is showing which looks ugly. I think you're not fully understanding the problem. Did you watch the video I attached? Why should this work as expected in 1.0.1 but then change in 2.0.0? > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-10796. - Resolution: Not A Problem The expected behaviour is that the statusbar partially covers the webview because the default value of StatusBarOverlaysWebView is true {quote} StatusBarOverlaysWebView (boolean, defaults to true). On iOS 7, make the statusbar overlay or not overlay the WebView at startup. {quote} If you don't want the statusbar to cover your app you should add this line to your config.xml {code} {code} > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Baker updated CB-10796: -- Attachment: statusbar-jump.m4v > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Baker updated CB-10796: -- Description: Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 Create a new Cordova project. Add statusbar, device and console plugins. Run in iOS simulator and press Command-Y to toggle the enlarged "in-call status bar". The page content slides down as expected but then immediately jumps back up, so it is partially covered by the status bar. See attached screen capture. was: Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 Create a new Cordova project. Add statusbar, device and console plugins. Run in iOS simulator and press Command-Y to toggle the enlarged "in-call status bar". The page content slides down as expected but then immediately jumps back up, so it is partially covered by the status bar. > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > Attachments: statusbar-jump.m4v > > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. > See attached screen capture. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
[ https://issues.apache.org/jira/browse/CB-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Baker updated CB-10796: -- Affects Version/s: 3.8.0 > In-call status bar causes content to shift down (as expected) then jump up > again > > > Key: CB-10796 > URL: https://issues.apache.org/jira/browse/CB-10796 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.8.0 >Reporter: Martin Baker > Labels: ios > > Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 > Create a new Cordova project. Add statusbar, device and console plugins. > Run in iOS simulator and press Command-Y to toggle the enlarged "in-call > status bar". > The page content slides down as expected but then immediately jumps back up, > so it is partially covered by the status bar. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-10796) In-call status bar causes content to shift down (as expected) then jump up again
Martin Baker created CB-10796: - Summary: In-call status bar causes content to shift down (as expected) then jump up again Key: CB-10796 URL: https://issues.apache.org/jira/browse/CB-10796 Project: Apache Cordova Issue Type: Bug Components: Plugin Statusbar Reporter: Martin Baker Issue happens with 2.0.0, 2.1.0 and 2.1.1 but works correctly in 1.0.1 Create a new Cordova project. Add statusbar, device and console plugins. Run in iOS simulator and press Command-Y to toggle the enlarged "in-call status bar". The page content slides down as expected but then immediately jumps back up, so it is partially covered by the status bar. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181686#comment-15181686 ] ASF GitHub Bot commented on CB-10328: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/402 > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181685#comment-15181685 ] ASF subversion and git services commented on CB-10328: -- Commit 114de6cd532e2218c1b302ae61bf8e3f50ec749d in cordova-lib's branch refs/heads/master from [~bso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=114de6c ] CB-10328 set top-level property when adding new platforms This closes #402 > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10328) dependency plugins are not removed even if not top-level
[ https://issues.apache.org/jira/browse/CB-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181680#comment-15181680 ] ASF GitHub Bot commented on CB-10328: - Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/402#discussion_r55119960 --- Diff: cordova-lib/src/plugman/install.js --- @@ -71,7 +71,8 @@ module.exports = function installPlugin(platform, project_dir, id, plugins_dir, project_dir = cordovaUtil.convertToRealPathSafe(project_dir); plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir); options = options || {}; -options.is_top_level = true; +if (options.is_top_level === undefined) --- End diff -- I meant that IMO the purpose of this check is to validate id someone already specified this value, and in this case it's beter to use `hasOwnProperty` which does exactly what it means > dependency plugins are not removed even if not top-level > > > Key: CB-10328 > URL: https://issues.apache.org/jira/browse/CB-10328 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So > Labels: triaged > > Some plugins fetch and install dependency plugins. > These dependency plugins should be removed when the top-level depender plugin > is removed. > However, this is not happening. > For example, cordova-plugin-media brings cordova-plugin-file as a dependency. > When, cordova-plugin-media is removed cordova-plugin-file should be removed > together. > I figured that this is caused by resetting the top-level property of plugins > when adding a new platform. > Here is how to reproduce the bug. > {code} > [test] cordova create test > Creating a new cordova project. > [test] cd test > [test] cordova plugin add cordova-plugin-media > Fetching plugin "cordova-plugin-media@~2.1.0" via npm > [test] cordova platform add ios > Adding ios project... > iOS project created with cordova-ios@4.0.1 > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for ios > Installing "cordova-plugin-media" for ios > Fetching plugin "cordova-plugin-file" via npm > Installing "cordova-plugin-file" for ios > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-media 2.1.0 "Media" > cordova-plugin-whitelist 1.2.1 "Whitelist" > [test] cordova platform add android > Adding android project... > Creating Cordova project for the Android platform: > Path: platforms/android > Package: io.cordova.hellocordova > Name: HelloCordova > Activity: MainActivity > Android target: android-23 > Android project created with cordova-android@5.1.0 > Installing "cordova-plugin-file" for android > Installing "cordova-plugin-media" for android > Dependent plugin "cordova-plugin-file" already installed on android. > Installing "cordova-plugin-whitelist" for android >This plugin is only applicable for versions of cordova-android > greater than 4.0. If you have a previous platform version, you do *not* need > this plugin since the whitelist will be built in. > [test] cordova plugin rm cordova-plugin-media > Uninstalling cordova-plugin-media from android > Uninstalling 1 dependent plugins. > Uninstalling cordova-plugin-file from ios > Uninstalling cordova-plugin-media from ios > Removing "cordova-plugin-media" > [test] cordova plugin > cordova-plugin-file 4.1.1 "File" > cordova-plugin-whitelist 1.2.1 "Whitelist" > {code} > If you see the following error when adding the ios platform, I already fixed > that issue in CB-10659. > {code} > Failed to install 'cordova-plugin-whitelist':Error: ENOENT, no such file or > directory > '/Users/bso/cordova/test/temp/platforms/ios/HelloCordova.xcodeproj/project.pbxproj' > {code} > You don't need to use ios to reproduce this issue. Use windows instead if you > can't add ios. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181676#comment-15181676 ] ASF subversion and git services commented on CB-10314: -- Commit 618eeca9583defa81054158ac456674fe5c5b1d0 in cordova-lib's branch refs/heads/master from [~bso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=618eeca ] CB-10314 avoid fetching plugins when oldId is already fetched This closes #396 > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181678#comment-15181678 ] ASF GitHub Bot commented on CB-10314: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/396 > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10314) avoid fetching newId when oldId is already fetched
[ https://issues.apache.org/jira/browse/CB-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181675#comment-15181675 ] ASF GitHub Bot commented on CB-10314: - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/396#issuecomment-192624166 Sorry for delay, @bso-intel. Merging > avoid fetching newId when oldId is already fetched > -- > > Key: CB-10314 > URL: https://issues.apache.org/jira/browse/CB-10314 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Byoungro So >Assignee: Byoungro So >Priority: Minor > Labels: triaged > > As of Cordova 5.4.0, an old plugin id is automatically converted to a new id > using the corodva-registry-mapper. > This causes a new id to be fetched even if an old id is already fetched in > the plugins directory (at cordova-lib/src/plugman/install.js) > However, plugman/fetch.js/copyPlugin() checks if the alias id is already in > the plugins directory, and skips installing the fetched newId plugin. > This causes unnecessary overhead. > It is better to check if the oldId is already fetched, and skips fetching the > newId from the beginning. > {code} > [t6.0.1] cordova plugins > cordova-plugin-whitelist 1.2.1 "Whitelist" > org.apache.cordova.device 0.3.0 "Device" > [t6.0.1] cordova plugin add org.apache.cordova.device > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device to be fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Notice: org.apache.cordova.device has been automatically converted to > cordova-plugin-device and fetched from npm. This is due to our old plugins > registry shutting down. > Fetching plugin "cordova-plugin-device" via npm > cordova-plugin-device" will not install due to > "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being > installed. > Plugin "org.apache.cordova.device" already installed on ios. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10773) Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from plugin.xml
[ https://issues.apache.org/jira/browse/CB-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181672#comment-15181672 ] Vladimir Kotikov commented on CB-10773: --- Please also see https://github.com/alunny/node-xcode/pull/81/files > Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from > plugin.xml > > > Key: CB-10773 > URL: https://issues.apache.org/jira/browse/CB-10773 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Environment: iOS >Reporter: Edna Morales >Assignee: Vladimir Kotikov > > When an iOS project is created and a plugin with custom frameworks is added > on Windows, the path separator in FRAMEWORK_SEARCH_PATHS of the pbxproj file > is incorrect. It has the Windows path separator. This causes build issues > when the project is moved to OSX and built in Xcode. > This is ultimately coming from the xcode npm package. I have opened up an > issue with that module with a suggested solution: > https://github.com/alunny/node-xcode/issues/80 > Once it is fixed there, we will need to refresh our version of the xcode npm > package in our node_modules for cordova-ios -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10773) Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from plugin.xml
[ https://issues.apache.org/jira/browse/CB-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181671#comment-15181671 ] ASF GitHub Bot commented on CB-10773: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/201 CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32 This is a fix https://issues.apache.org/jira/browse/CB-10773 Similar PR to `node-xcode`: https://github.com/alunny/node-xcode/pull/81/files You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-10773 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #201 commit 5dd92a61b20e81ee5c98287b3173ee61d93a07c5 Author: Vladimir KotikovDate: 2016-03-05T10:22:10Z CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32 > Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from > plugin.xml > > > Key: CB-10773 > URL: https://issues.apache.org/jira/browse/CB-10773 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Environment: iOS >Reporter: Edna Morales >Assignee: Vladimir Kotikov > > When an iOS project is created and a plugin with custom frameworks is added > on Windows, the path separator in FRAMEWORK_SEARCH_PATHS of the pbxproj file > is incorrect. It has the Windows path separator. This causes build issues > when the project is moved to OSX and built in Xcode. > This is ultimately coming from the xcode npm package. I have opened up an > issue with that module with a suggested solution: > https://github.com/alunny/node-xcode/issues/80 > Once it is fixed there, we will need to refresh our version of the xcode npm > package in our node_modules for cordova-ios -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10730) Plugin handlers tests for Windows should be kept in platform's repo
[ https://issues.apache.org/jira/browse/CB-10730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov closed CB-10730. - Resolution: Done > Plugin handlers tests for Windows should be kept in platform's repo > --- > > Key: CB-10730 > URL: https://issues.apache.org/jira/browse/CB-10730 > Project: Apache Cordova > Issue Type: Task >Reporter: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10730) Plugin handlers tests for Windows should be kept in platform's repo
[ https://issues.apache.org/jira/browse/CB-10730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181633#comment-15181633 ] ASF GitHub Bot commented on CB-10730: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/155 > Plugin handlers tests for Windows should be kept in platform's repo > --- > > Key: CB-10730 > URL: https://issues.apache.org/jira/browse/CB-10730 > Project: Apache Cordova > Issue Type: Task >Reporter: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10730) Plugin handlers tests for Windows should be kept in platform's repo
[ https://issues.apache.org/jira/browse/CB-10730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181631#comment-15181631 ] ASF subversion and git services commented on CB-10730: -- Commit 60cca717a5ea8c0c8ababadd32258728a7880aac in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=60cca71 ] CB-10730 Move plugin handlers tests for into platform's repo This closes #155 > Plugin handlers tests for Windows should be kept in platform's repo > --- > > Key: CB-10730 > URL: https://issues.apache.org/jira/browse/CB-10730 > Project: Apache Cordova > Issue Type: Task >Reporter: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10769) Plugin handlers tests for iOS should be kept in platform's repo
[ https://issues.apache.org/jira/browse/CB-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181626#comment-15181626 ] ASF GitHub Bot commented on CB-10769: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/200 CB-10769 Move plugin handlers tests into platform's repo JIRA: https://issues.apache.org/jira/browse/CB-10769 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-10769 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #200 commit 72f11f5410ebf28ac864e69d8fc4933304233f98 Author: Vladimir KotikovDate: 2016-03-03T14:06:19Z CB-10769 Copy raw pluginHandler tests from cordova-lib Update tests structure and npm tasks Copying related fixtures from cordova-lib commit f5a92d1056aa27f928928111dbe63d96f9bcd667 Author: Vladimir Kotikov Date: 2016-03-02T13:44:09Z CB-10769 Update specs according to actual implementation > Plugin handlers tests for iOS should be kept in platform's repo > --- > > Key: CB-10769 > URL: https://issues.apache.org/jira/browse/CB-10769 > Project: Apache Cordova > Issue Type: Task >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org