[jira] [Created] (CB-11321) Cordova Splashscreen Plugin

[Atif Gulzar (JIRA)]

Atif Gulzar created CB-11321:


 Summary: Cordova Splashscreen Plugin
 Key: CB-11321
 URL: https://issues.apache.org/jira/browse/CB-11321
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android, iOS
Affects Versions: 3.5.0
 Environment: IOS
Reporter: Atif Gulzar


AtifMacPro:cordova wison$ cordova plugin add 
https://github.com/apache/cordova-plugin-splashscreen.git
Fetching plugin "https://github.com/apache/cordova-plugin-splashscreen.git; via 
git clone
Installing "cordova-plugin-splashscreen" for ios
TypeError: Cannot call method 'indexOf' of undefined
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:232:55
at Array.forEach (native)
at getEngines 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:211:13)
at runInstall 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:281:22)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:81:16
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:810:14
at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301479#comment-15301479
 ] 

ASF GitHub Bot commented on CB-7:
-

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/174#discussion_r64688561
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
 AppxManifest.purgeCache();
 
 // Update own www dir with project's www assets and plugins' assets 
and js-files
-return Q.when(updateWwwFrom(cordovaProject, this.locations))
+return Q.when(updateWww(cordovaProject, this.locations))
 .then(function () {
 // update project according to config.xml changes.
 return updateProjectAccordingTo(self._config, self.locations);
 })
 .then(function () {
-copyImages(cordovaProject.projectConfig, self.root);
+copyImages(cordovaProject, self.locations);
 })
 .then(function () {
 events.emit('verbose', 'Prepared windows project successfully');
 });
 };
 
+module.exports.clean = function (options) {
+// A cordovaProject isn't passed into the clean() function, because it 
might have
+// been called from the platform shell script rather than the CLI. 
Check for the
+// noPrepare option passed in by the non-CLI clean script. If that's 
present, or if
+// there's no config.xml found at the project root, then don't clean 
prepared files.
+var projectRoot = path.resolve(this.root, '../..');
+var projectConfigFile = path.join(projectRoot, 'config.xml');
--- End diff --

That's a reasonable question. I didn't want the clean function to depend on 
a previous prepare having completed successfully (so that the platform 
config.xml was merged). But I'm not sure that's best, and maybe it would be 
cleaner just to use that file.

I did this the same way for the other 2 platforms, so this discussion would 
apply there also.


> Preparing platforms should skip copying files which haven't changed
> ---
>
> Key: CB-7
> URL: https://issues.apache.org/jira/browse/CB-7
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, iOS, Windows
>Reporter: Jason Ginchereau
>Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova 
> build', 'cordova run', 'cordova plugin add', and more. Every time each of 
> those commands runs, the target platform is "prepared", which involves 
> copying all files from the [/www, 
> /platforms//platform_www, /merges/] to 
> the platform's target www folder, as well as copying a bunch of icons and 
> splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. 
> But most of the time after that most of the files being copied have not 
> changed and therefore don't really need to be copied again. So the typical 
> developer inner loop (edit a few source files, build and run the app, repeat) 
> is a lot slower than it could be for a Cordova project, especially one that 
> includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't 
> changed, based on their last-modified timestamp. (But also there should still 
> be a way to force a clean/full/non-incremental build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301269#comment-15301269
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:29 AM:
---

[~daserge] Another question to ask you, why I cannot see this issue in *My Open 
Issues*?

And, I think I mistook you yesterday.
This code 
{code:javascript}
window.resolveLocalFileSystemURL(cordova.file.applicationDirectory, function 
(assetsRoot) {
assetsRoot.getFile('www/img/logo.png', null, function (image) {
document.getElementById('imageFileCdv').src = image.toInternalURL();
{code}
doesn't work on Android like "cdvfile://localhost/assets/path" do.


was (Author: zyf0330):
[~daserge] Another question to ask you, why I cannot see this issue in *My Open 
Issues*?

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301269#comment-15301269
 ] 

zhuisui commented on CB-11305:
--

[~daserge] Another question to ask you, why I cannot see this issue in *My Open 
Issues*?

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:06 AM:
---

thanks for the text effects.
About {code}toInternalURL{code}, I know it. I just don't know what it returns 
in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

Also, I use "code" in Text Formatting Notation, but it breaks line. What do you 
do?


was (Author: zyf0330):
thanks for the text effects.
About {code}toInternalURL{code}, I know it. I just don't know what it returns 
in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:05 AM:
---

thanks for the text effects.
About {code}toInternalURL{code}, I know it. I just don't know what it returns 
in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.


was (Author: zyf0330):
thanks for the text effects.
About ^toInternalURL^, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:04 AM:
---

thanks for the text effects.
About ^toInternalURL^, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.


was (Author: zyf0330):
thanks for the text effects.
About {code:javascript}toInternalURL{code}, I know it. I just don't know what 
it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:02 AM:
---

thanks for the text effects.
About {code:javascript}toInternalURL{code}, I know it. I just don't know what 
it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.


was (Author: zyf0330):
thanks for the text effects.
About ~toInternalURL~, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui commented on CB-11305:
--

thanks for the text effects.
About toInternalURL, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhuisui updated CB-11305:
-
Comment: was deleted

(was: thanks for the text effects.
About toInternalURL, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

On Wed, May 25, 2016, 20:56 Sergey Shakhnazarov (JIRA) 

-- 

追随
)

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301238#comment-15301238
 ] 

zhuisui edited comment on CB-11305 at 5/26/16 1:01 AM:
---

thanks for the text effects.
About ~toInternalURL~, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.


was (Author: zyf0330):
thanks for the text effects.
About toInternalURL, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301237#comment-15301237
 ] 

ASF GitHub Bot commented on CB-7:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/174#discussion_r64677748
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
 AppxManifest.purgeCache();
 
 // Update own www dir with project's www assets and plugins' assets 
and js-files
-return Q.when(updateWwwFrom(cordovaProject, this.locations))
+return Q.when(updateWww(cordovaProject, this.locations))
 .then(function () {
 // update project according to config.xml changes.
 return updateProjectAccordingTo(self._config, self.locations);
 })
 .then(function () {
-copyImages(cordovaProject.projectConfig, self.root);
+copyImages(cordovaProject, self.locations);
 })
 .then(function () {
 events.emit('verbose', 'Prepared windows project successfully');
 });
 };
 
+module.exports.clean = function (options) {
+// A cordovaProject isn't passed into the clean() function, because it 
might have
+// been called from the platform shell script rather than the CLI. 
Check for the
+// noPrepare option passed in by the non-CLI clean script. If that's 
present, or if
+// there's no config.xml found at the project root, then don't clean 
prepared files.
+var projectRoot = path.resolve(this.root, '../..');
+var projectConfigFile = path.join(projectRoot, 'config.xml');
--- End diff --

I see you are invoking `getIcons('windows')` and this should do the right 
thing. Is there a reason why you do not use the config.xml in the platform 
directory?


> Preparing platforms should skip copying files which haven't changed
> ---
>
> Key: CB-7
> URL: https://issues.apache.org/jira/browse/CB-7
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, iOS, Windows
>Reporter: Jason Ginchereau
>Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova 
> build', 'cordova run', 'cordova plugin add', and more. Every time each of 
> those commands runs, the target platform is "prepared", which involves 
> copying all files from the [/www, 
> /platforms//platform_www, /merges/] to 
> the platform's target www folder, as well as copying a bunch of icons and 
> splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. 
> But most of the time after that most of the files being copied have not 
> changed and therefore don't really need to be copied again. So the typical 
> developer inner loop (edit a few source files, build and run the app, repeat) 
> is a lot slower than it could be for a Cordova project, especially one that 
> includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't 
> changed, based on their last-modified timestamp. (But also there should still 
> be a way to force a clean/full/non-incremental build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301230#comment-15301230
 ] 

ASF GitHub Bot commented on CB-7:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/174#discussion_r64677389
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
 AppxManifest.purgeCache();
 
 // Update own www dir with project's www assets and plugins' assets 
and js-files
-return Q.when(updateWwwFrom(cordovaProject, this.locations))
+return Q.when(updateWww(cordovaProject, this.locations))
 .then(function () {
 // update project according to config.xml changes.
 return updateProjectAccordingTo(self._config, self.locations);
 })
 .then(function () {
-copyImages(cordovaProject.projectConfig, self.root);
+copyImages(cordovaProject, self.locations);
 })
 .then(function () {
 events.emit('verbose', 'Prepared windows project successfully');
 });
 };
 
+module.exports.clean = function (options) {
+// A cordovaProject isn't passed into the clean() function, because it 
might have
+// been called from the platform shell script rather than the CLI. 
Check for the
+// noPrepare option passed in by the non-CLI clean script. If that's 
present, or if
+// there's no config.xml found at the project root, then don't clean 
prepared files.
+var projectRoot = path.resolve(this.root, '../..');
+var projectConfigFile = path.join(projectRoot, 'config.xml');
--- End diff --

@vladimir-kotikov  to help review - as far as I remember platforms never 
parse the root config. In particular, the root config can have conditional 
elements - 
```xml
 
 

```


> Preparing platforms should skip copying files which haven't changed
> ---
>
> Key: CB-7
> URL: https://issues.apache.org/jira/browse/CB-7
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, iOS, Windows
>Reporter: Jason Ginchereau
>Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova 
> build', 'cordova run', 'cordova plugin add', and more. Every time each of 
> those commands runs, the target platform is "prepared", which involves 
> copying all files from the [/www, 
> /platforms//platform_www, /merges/] to 
> the platform's target www folder, as well as copying a bunch of icons and 
> splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. 
> But most of the time after that most of the files being copied have not 
> changed and therefore don't really need to be copied again. So the typical 
> developer inner loop (edit a few source files, build and run the app, repeat) 
> is a lot slower than it could be for a Cordova project, especially one that 
> includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't 
> changed, based on their last-modified timestamp. (But also there should still 
> be a way to force a clean/full/non-incremental build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11288) shouldOverrideUrlLoading not called

[vontio (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301213#comment-15301213
 ] 

vontio commented on CB-11288:
-

v4.4.2, model: G808 3G Oc

> shouldOverrideUrlLoading not called
> ---
>
> Key: CB-11288
> URL: https://issues.apache.org/jira/browse/CB-11288
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 6.0.0
> Environment: windows
>Reporter: vontio
>  Labels: plugin
>
> reproduce:
> in cordova plugin initialize:
> (WebView)(webView.getEngine().getView()).setWebViewClient(new 
> SystemWebViewClient((SystemWebViewEngine) webView.getEngine()){
> @Override
> public boolean shouldOverrideUrlLoading(WebView view, String url) {
> Log.v(TAG,"shouldOverrideUrlLoading request " + url);
> return super.shouldOverrideUrlLoading(view, url);
> }
> @Override
> public WebResourceResponse shouldInterceptRequest (WebView view, 
> String url)
> {
> Log.v(TAG,"shouldInterceptRequest request " + url);
> return super.shouldInterceptRequest(view,url);
> }
> });
> only shouldInterceptRequest called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-10096) Update Gradle Version to work with Instant Run

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-10096.
-
Resolution: Fixed

> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11292) calling loadUrl more than once breaks messageChannel

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-11292.
-
Resolution: Fixed

Confirmed that the test runs, and merged into master.

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11292) calling loadUrl more than once breaks messageChannel

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300930#comment-15300930
 ] 

ASF GitHub Bot commented on CB-11292:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/307


> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10096) Update Gradle Version to work with Instant Run

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300931#comment-15300931
 ] 

ASF GitHub Bot commented on CB-10096:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/306


> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10096) Update Gradle Version to work with Instant Run

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300929#comment-15300929
 ] 

ASF subversion and git services commented on CB-10096:
--

Commit d125ece9e9598f6b4f52e2148e8005f0fbabc5c8 in cordova-android's branch 
refs/heads/master from [~tony--]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=d125ece ]

CB-10096: Upgrade test project to Gradle Plugin 2.1.0

This closes #306


> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10096) Update Gradle Version to work with Instant Run

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300932#comment-15300932
 ] 

ASF GitHub Bot commented on CB-10096:
-

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/306#issuecomment-221718552
  
OK, this is a pre-req of #307, so I merged them both together.


> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11292) calling loadUrl more than once breaks messageChannel

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300928#comment-15300928
 ] 

ASF subversion and git services commented on CB-11292:
--

Commit ecb99c963df2281bd02fa42184f48952ed0fcf84 in cordova-android's branch 
refs/heads/master from [~tony--]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=ecb99c9 ]

CB-11292 fix broken MessageChannel after plugins are recreated

This closes #307


> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11292) calling loadUrl more than once breaks messageChannel

[Tony Homer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tony Homer updated CB-11292:

Assignee: Joe Bowser  (was: Tony Homer)

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11292) calling loadUrl more than once breaks messageChannel

[Tony Homer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300804#comment-15300804
 ] 

Tony Homer commented on CB-11292:
-

Thanks Joe, that would be great.  I was afraid the test was overkill, so glad 
you view it as a positive.  Reassigning now.

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Tony Homer
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11282) Chrome inspector connection lost, detached from target - large files

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300779#comment-15300779
 ] 

Joe Bowser edited comment on CB-11282 at 5/25/16 8:19 PM:
--

Well, if it's not Cordova-specific, I'm going to close this since we can really 
only say "You should try Crosswalk".

BTW: Have you tried Crosswalk? ;) The main advantage is that you know which 
Chromium your users are going to be using, so you can avoid these errors.  It 
does work with Chrome Inspector. 


was (Author: bowserj):
Well, if it's not Cordova-specific, I'm going to close this since we can really 
only say "You should try Crosswalk".

BTW: Have you tried Crosswalk? The main advantage is that you know which 
Chromium your users are going to be using, so you can avoid these errors.  It 
does work with Chrome Inspector. 

> Chrome inspector connection lost, detached from target - large files
> 
>
> Key: CB-11282
> URL: https://issues.apache.org/jira/browse/CB-11282
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 6.1.1
> Environment: Android, Linux
>Reporter: Simon Williams
>  Labels: debugging, inspector, triaged, wfc
>
> Hi. I am having issues with using the Chrome remote inspector 
> (chrome://inspect) with Android.
> The WebView appears in the list and selecting to inspect attaches and shows 
> some console messages, but within half a second it loses the connection, 
> saying "Detached from the target, reason: Connection lost".
> In the adb logcat it shows the following:
> {code}
> E/chromium(15597): [ERROR:http_connection.cc(35)] Too large read data is 
> pending: capacity=1048576, max_buffer_size=1048576, read=1048576
> {code}
> This seems to be due to the size of the source file (I am bundling everything 
> into a single file with browserify). If I run uglify on the bundle (taking it 
> from 2.2Mb to 330K) then it works fine.
> I should also mention that this is definitely Cordova specific. The Chrome 
> remote inspector works fine for other WebViews/browsers regardless of size.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11282) Chrome inspector connection lost, detached from target - large files

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-11282.
-
Resolution: Won't Fix

Well, if it's not Cordova-specific, I'm going to close this since we can really 
only say "You should try Crosswalk".

BTW: Have you tried Crosswalk? The main advantage is that you know which 
Chromium your users are going to be using, so you can avoid these errors.  It 
does work with Chrome Inspector. 

> Chrome inspector connection lost, detached from target - large files
> 
>
> Key: CB-11282
> URL: https://issues.apache.org/jira/browse/CB-11282
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 6.1.1
> Environment: Android, Linux
>Reporter: Simon Williams
>  Labels: debugging, inspector, triaged, wfc
>
> Hi. I am having issues with using the Chrome remote inspector 
> (chrome://inspect) with Android.
> The WebView appears in the list and selecting to inspect attaches and shows 
> some console messages, but within half a second it loses the connection, 
> saying "Detached from the target, reason: Connection lost".
> In the adb logcat it shows the following:
> {code}
> E/chromium(15597): [ERROR:http_connection.cc(35)] Too large read data is 
> pending: capacity=1048576, max_buffer_size=1048576, read=1048576
> {code}
> This seems to be due to the size of the source file (I am bundling everything 
> into a single file with browserify). If I run uglify on the bundle (taking it 
> from 2.2Mb to 330K) then it works fine.
> I should also mention that this is definitely Cordova specific. The Chrome 
> remote inspector works fine for other WebViews/browsers regardless of size.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11291) Update capped to 1Hz when in background

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-11291:

   Priority: Minor  (was: Major)
Component/s: (was: Android)

Do you have any documentation to support this? For example, which devices are 
exhibiting this behaviour?  It's well known that different versions of Android, 
and different versions of Android System WebView behave in very different ways, 
so finding this bug could be near impossible.

Also, it doesn't really make sense for the WebView to be running on the 
background this way, and I really don't see us being able to support this if 
this is in fact true.

> Update capped to 1Hz when in background
> ---
>
> Key: CB-11291
> URL: https://issues.apache.org/jira/browse/CB-11291
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Device Motion
>Reporter: Zeph Davies
>Priority: Minor
>
> Due to the way Android's WebBrowser handles setInterval, when the "tab" is in 
> the background (ie when used in conjunction with backgroundMode plugin), 
> setInterval (used to send the latest value to the application) is capped to 
> 1Hz (once per second).
> This makes the plugin update at a completely different interval to that set 
> by the application.
> One solution is to use a WebWorker to hold the setInterval timer, as it is 
> not limited by the browser.
> The tricky bit is loading the script into the WebWorker, as it requires the 
> "Content-Security-Policy" to allow local files or blobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11292) calling loadUrl more than once breaks messageChannel

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300770#comment-15300770
 ] 

ASF GitHub Bot commented on CB-11292:
-

Github user tony-- commented on the pull request:

https://github.com/apache/cordova-android/pull/307#issuecomment-221693379
  
AppVeyor timed out, not a failure related to the PR.


> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Tony Homer
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11301) Android Media Buttons only signalled after release

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300766#comment-15300766
 ] 

Joe Bowser edited comment on CB-11301 at 5/25/16 8:12 PM:
--

Key events have been screwed up ever since we decided to do third party 
webviews, because it's unclear who owns what key event, and how the key events 
map.  The good news is that you can at least hook into this with a third-party 
plugin, but the bad news is that keypads, headphones and other peripherals get 
a lower priority because testing will be INSANE with different hardware combos, 
so while we could throw something over the fence, we don't  because we get 
burned pretty hard when we do that.



was (Author: bowserj):
Key events have been screwed up ever since we decided to do third party 
webviews, because it's unclear who owns what key event, and how the key events 
map.  The good news is that you can at least hook into this with a third-party 
plugin, but the bad news is that keypads, headphones and other peripherals get 
a lower priority because testing will be INSANE with different hardware combos, 
so while we could throw something over the fence, we don't  because we get 
burned pretty hard when we do that.


> Android Media Buttons only signalled after release
> --
>
> Key: CB-11301
> URL: https://issues.apache.org/jira/browse/CB-11301
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Ruediger Jungbeck
>Priority: Minor
>  Labels: features
>
> The media button (on  Android headsets) issue events when pressed or 
> released. There is a Cordova plugin that installs a BroadcastReceiver for 
> Media Button intents. But this intents occur after the physical button has 
> already been released (to distinguish short and long presses). This prevenets 
> the use of the media button as a PTT (push to talk) kery. So there should be 
> a handling for the media button that is similar to the handling of the 
> volumeup/volumedown In onDispatchKeyEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11301) Android Media Buttons only signalled after release

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-11301:

Priority: Minor  (was: Major)

Key events have been screwed up ever since we decided to do third party 
webviews, because it's unclear who owns what key event, and how the key events 
map.  The good news is that you can at least hook into this with a third-party 
plugin, but the bad news is that keypads, headphones and other peripherals get 
a lower priority because testing will be INSANE with different hardware combos, 
so while we could throw something over the fence, we don't  because we get 
burned pretty hard when we do that.


> Android Media Buttons only signalled after release
> --
>
> Key: CB-11301
> URL: https://issues.apache.org/jira/browse/CB-11301
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Ruediger Jungbeck
>Priority: Minor
>  Labels: features
>
> The media button (on  Android headsets) issue events when pressed or 
> released. There is a Cordova plugin that installs a BroadcastReceiver for 
> Media Button intents. But this intents occur after the physical button has 
> already been released (to distinguish short and long presses). This prevenets 
> the use of the media button as a PTT (push to talk) kery. So there should be 
> a handling for the media button that is similar to the handling of the 
> volumeup/volumedown In onDispatchKeyEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11292) calling loadUrl more than once breaks messageChannel

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300761#comment-15300761
 ] 

Joe Bowser commented on CB-11292:
-

If you want me to look at the pull request/bug combo, assign them to me and 
I'll take a look at it.  I know that someone else did this exact pull request 
but didn't have a test, so I'm fine with this being added.

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11318) mailto: is not working in Android after adding ''

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300757#comment-15300757
 ] 

Joe Bowser commented on CB-11318:
-

[~vinbtechdf] Because Android has intents and intents can access various things 
on the device they're not supposed to if they're not properly secured.

> mailto: is not working in Android after adding ' href="mailto:*; />'
> -
>
> Key: CB-11318
> URL: https://issues.apache.org/jira/browse/CB-11318
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
>Reporter: Vinoth Kumar
>
> In Android, mailto is not working after adding  href="mailto:*; />
> If I only use mailto:*; />, mailto is 
> working in Android but to make it work in iOS i added  href="mailto:*; />. Then it stopped working on Android.
> Currently my config has the following 
> mailto:*; />
> mailto:*; />
> I am using a combined config for both Android and iOS.
> Cordova CLI version is 6.1.0 and Android version is 5.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11292) calling loadUrl more than once breaks messageChannel

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser reassigned CB-11292:
---

Assignee: Joe Bowser  (was: Tony Homer)

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Joe Bowser
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11307) Can't create file with cordova.file.dataDirectory or cordova.file.cacheDirectory

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300754#comment-15300754
 ] 

Sergey Shakhnazarov commented on CB-11307:
--

[~decagon], I believe this is an application/WebView issue related to the 
{{Blob}} constructor and here is a workaround:
http://stackoverflow.com/questions/15293694/blob-constructor-browser-compatibility
Let me know if this helps.

> Can't create file with cordova.file.dataDirectory or 
> cordova.file.cacheDirectory
> 
>
> Key: CB-11307
> URL: https://issues.apache.org/jira/browse/CB-11307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: Visual studio 2015 with cordova, Android 4.4.2
>Reporter: decagon
>Assignee: Sergey Shakhnazarov
>  Labels: triaged, wfc
>
> I'm trying to create and write to a file in cordova.file.dataDirectory
> (file:///data/data//files/) or cordova.file.cacheDirectory.
> But without success on android 4.4.2 .
> The code fails on :
> or using : 
> fs.root.getFile("myfile.txt", { create: true, exclusive: false }, function () 
> {}, function () {});
> Example of code :
> window.resolveLocalFileSystemURL(cordova.file.dataDirectory,
>   function (directoryEntry) { // success
>   directoryEntry.getFile('myfile.txt', { create: true },
>   function (fileEntry) { //success
>   fileEntry.createWriter(
>   function (fileWriter) { // success
>   fileWriter.onwriteend = 
> function () {
>   console.log("OK");
>   };
>   fileWriter.onerror = function 
> (e) {
>   console.log("Not OK");
>   };
>   // If data object is not passed 
> in,
>   // create a new Blob instead.
>   if (!data) {
>   data = new Blob([' '], 
> { type: 'text/plain' });
>   }
>   data = JSON.stringify(data);
>   var blob = new Blob([data], { 
> type: 'text/plain' });
>   fileWriter.write(blob);
>   },
>   function (e) { // error
>   console.log(e);
>   }
>   );
>   },
>   function (e) { // error
>   console.log(e);
>   }
>   );
>   },
>   function (e) { // error
>   console.log(e);
>   }
> );
> directoryEntry.getFile doesn't work.
> However, it works on Android 6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11288) shouldOverrideUrlLoading not called

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300755#comment-15300755
 ] 

Joe Bowser commented on CB-11288:
-

Can you provide more details, like which device and which version of Android 
you're running?

> shouldOverrideUrlLoading not called
> ---
>
> Key: CB-11288
> URL: https://issues.apache.org/jira/browse/CB-11288
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 6.0.0
> Environment: windows
>Reporter: vontio
>  Labels: plugin
>
> reproduce:
> in cordova plugin initialize:
> (WebView)(webView.getEngine().getView()).setWebViewClient(new 
> SystemWebViewClient((SystemWebViewEngine) webView.getEngine()){
> @Override
> public boolean shouldOverrideUrlLoading(WebView view, String url) {
> Log.v(TAG,"shouldOverrideUrlLoading request " + url);
> return super.shouldOverrideUrlLoading(view, url);
> }
> @Override
> public WebResourceResponse shouldInterceptRequest (WebView view, 
> String url)
> {
> Log.v(TAG,"shouldInterceptRequest request " + url);
> return super.shouldInterceptRequest(view,url);
> }
> });
> only shouldInterceptRequest called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11307) Can't create file with cordova.file.dataDirectory or cordova.file.cacheDirectory

[Sergey Shakhnazarov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Shakhnazarov updated CB-11307:
-
Labels: triaged wfc  (was: triaged)

> Can't create file with cordova.file.dataDirectory or 
> cordova.file.cacheDirectory
> 
>
> Key: CB-11307
> URL: https://issues.apache.org/jira/browse/CB-11307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
> Environment: Visual studio 2015 with cordova, Android 4.4.2
>Reporter: decagon
>Assignee: Sergey Shakhnazarov
>  Labels: triaged, wfc
>
> I'm trying to create and write to a file in cordova.file.dataDirectory
> (file:///data/data//files/) or cordova.file.cacheDirectory.
> But without success on android 4.4.2 .
> The code fails on :
> or using : 
> fs.root.getFile("myfile.txt", { create: true, exclusive: false }, function () 
> {}, function () {});
> Example of code :
> window.resolveLocalFileSystemURL(cordova.file.dataDirectory,
>   function (directoryEntry) { // success
>   directoryEntry.getFile('myfile.txt', { create: true },
>   function (fileEntry) { //success
>   fileEntry.createWriter(
>   function (fileWriter) { // success
>   fileWriter.onwriteend = 
> function () {
>   console.log("OK");
>   };
>   fileWriter.onerror = function 
> (e) {
>   console.log("Not OK");
>   };
>   // If data object is not passed 
> in,
>   // create a new Blob instead.
>   if (!data) {
>   data = new Blob([' '], 
> { type: 'text/plain' });
>   }
>   data = JSON.stringify(data);
>   var blob = new Blob([data], { 
> type: 'text/plain' });
>   fileWriter.write(blob);
>   },
>   function (e) { // error
>   console.log(e);
>   }
>   );
>   },
>   function (e) { // error
>   console.log(e);
>   }
>   );
>   },
>   function (e) { // error
>   console.log(e);
>   }
> );
> directoryEntry.getFile doesn't work.
> However, it works on Android 6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11292) calling loadUrl more than once breaks messageChannel

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser reassigned CB-11292:
---

Assignee: Tony Homer  (was: Joe Bowser)

> calling loadUrl more than once breaks messageChannel
> 
>
> Key: CB-11292
> URL: https://issues.apache.org/jira/browse/CB-11292
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Tony Homer
>Assignee: Tony Homer
>
> CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid 
> plugin instance. This plugin manages Cordova's messageChannel. One of the 
> things messageChannel is used for is sending system events from native to JS, 
> for example backbutton events.
> By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side 
> effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid 
> stale. That is, a new instance is created and bound to a new messageChannel 
> callback.
> After this happens, when CordovaWebViewImpl sends messages to JS, the 
> callback id has changed and the messages are not handled.
> There are at least 2 approaches that should fix this.
> 1. (tested) do not cache the CoreAndroid instance. If 
> CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager 
> every time, it will not become stale.
> 2. (not tested, but better encapsulated) when plugins are recreated, clear 
> the cached reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10096) Update Gradle Version to work with Instant Run

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300762#comment-15300762
 ] 

ASF GitHub Bot commented on CB-10096:
-

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/306#issuecomment-221691227
  
Why did this break travis???


> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11318) mailto: is not working in Android after adding ''

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-11318.
-
Resolution: Won't Fix

> mailto: is not working in Android after adding ' href="mailto:*; />'
> -
>
> Key: CB-11318
> URL: https://issues.apache.org/jira/browse/CB-11318
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
>Reporter: Vinoth Kumar
>
> In Android, mailto is not working after adding  href="mailto:*; />
> If I only use mailto:*; />, mailto is 
> working in Android but to make it work in iOS i added  href="mailto:*; />. Then it stopped working on Android.
> Currently my config has the following 
> mailto:*; />
> mailto:*; />
> I am using a combined config for both Android and iOS.
> Cordova CLI version is 6.1.0 and Android version is 5.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10096) Update Gradle Version to work with Instant Run

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300763#comment-15300763
 ] 

ASF GitHub Bot commented on CB-10096:
-

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/306#issuecomment-221691711
  
This looks completely unrelated to the pull request itself.  We should just 
merge this in.


> Update Gradle Version to work with Instant Run
> --
>
> Key: CB-10096
> URL: https://issues.apache.org/jira/browse/CB-10096
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>
> Android Studio 2.0.0 has instant run which works really well with Cordova 
> projects, but the templates still use an old Gradle version, and it takes a 
> long time to resolve all the issues, we should make sure we're using a good 
> Gradle version to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11067) Content-Length missing in multipart form upload header on Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300640#comment-15300640
 ] 

ASF GitHub Bot commented on CB-11067:
-

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221670591
  
@oddcb, thanks for the contribution!
This is not an issue though as the `Content-Length` header is set by 
[`setFixedLengthStreamingMode`](https://developer.android.com/reference/java/net/HttpURLConnection.html?hl=ru#setFixedLengthStreamingMode%28int%29)
 in 
https://github.com/apache/cordova-plugin-file-transfer/blob/9347606dd33fe07ea36799b4dd28804019c68835/src/android/FileTransfer.java#L438.
I've recently added 
[tests](https://github.com/apache/cordova-plugin-file-transfer/commit/9347606dd33fe07ea36799b4dd28804019c68835#diff-2a8a5fef3397df87ab538f028a5c6b50R1494)
 verifying `Content-Length`, `Content-Type` and `Transfer-Encoding` for 
multipart/non-multipart & chunked/non-chunked modes - and they are passing for 
Android and iOS.


> Content-Length missing in multipart form upload header on Android
> -
>
> Key: CB-11067
> URL: https://issues.apache.org/jira/browse/CB-11067
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File Transfer
> Environment: Plugin version 1.5.0
> chunked = false
>Reporter: Odd Christer Brovig
>  Labels: Android, triaged
>
> On iOS Content-Length is sent as part of header for multipart form. On 
> Android only Content-Disposition and Content-Type is sent.
> Is there a special reason for this? I see that the file size is read after 
> the beforeData is converted to bytes.
> From FileTransfer.java:
> {code:java}
> 
> beforeData.append(LINE_START).append(BOUNDARY).append(LINE_END);
> beforeData.append("Content-Disposition: form-data; 
> name=\"").append(fileKey).append("\";");
> beforeData.append(" 
> filename=\"").append(fileName).append('"').append(LINE_END);
> beforeData.append("Content-Type: 
> ").append(mimeType).append(LINE_END).append(LINE_END);
> byte[] beforeDataBytes = 
> beforeData.toString().getBytes("UTF-8");
> byte[] tailParamsBytes = (LINE_END + LINE_START + 
> BOUNDARY + LINE_START + LINE_END).getBytes("UTF-8");
> {code}
> From CDVFileTransfer.m:
> {code}
> [postBodyBeforeFile appendData:formBoundaryData];
> [postBodyBeforeFile appendData:[[NSString 
> stringWithFormat:@"Content-Disposition: form-data; name=\"%@\"; 
> filename=\"%@\"\r\n", fileKey, fileName] 
> dataUsingEncoding:NSUTF8StringEncoding]];
> if (mimeType != nil) {
> [postBodyBeforeFile appendData:[[NSString 
> stringWithFormat:@"Content-Type: %@\r\n", mimeType] 
> dataUsingEncoding:NSUTF8StringEncoding]];
> }
> [postBodyBeforeFile appendData:[[NSString 
> stringWithFormat:@"Content-Length: %ld\r\n\r\n", (long)[fileData length]] 
> dataUsingEncoding:NSUTF8StringEncoding]];
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11317) show if platform is in debug mode

[Mathieu Gagnon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Gagnon updated CB-11317:

Priority: Minor  (was: Major)

> show if platform is in debug mode
> -
>
> Key: CB-11317
> URL: https://issues.apache.org/jira/browse/CB-11317
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Device
>Reporter: Mathieu Gagnon
>Priority: Minor
>  Labels: features
>
> If cordova is built in debug, device.isDebug is set to true
> else if cordova is built in release, set to false.
> It can be very useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Environment: cordova 6.1.1, cordova-android 5.1.1  (was: Windows 7, cordova 
6.1.1, cordova-android 5.1.1)

> Security: a malicious cross origin iframe can kill the app
> --
>
> Key: CB-11320
> URL: https://issues.apache.org/jira/browse/CB-11320
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Browser
> Environment: cordova 6.1.1, cordova-android 5.1.1
>Reporter: jakub-g
>  Labels: security
>
> It is written in Cordova security guide that generally one should avoid 
> iframes, unless they are fully in control of their contents:
> https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism
> However not everyone might be familiar with this.
> In general the iframe seems to follow the Single Origin Policy and does not 
> allow doing actions in the context of the top frame (main cordova app frame) 
> from the third party iframe, but I found the following issue:
> 1. Create a sample cordova project, and embed a third-party iframe in it:
> {code}
> cordova create foobar
> cd foobar
> cordova platform add android
> vim www/index.html
> {code}
> 2. Insert the following in the `index.html`
> {code}
>   http://www.example.com;>
>   http://www.example.com/evil-iframe.html;>
> {code}
> 3. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame) 
from the third party iframe, but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

{code}
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
{code}

2. Insert the following in the `index.html`

{code}
  http://www.example.com;>
  http://www.example.com/evil-iframe.html;>
{code}

3. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

{code}
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
# insert the following in the `index.html`
#  http://www.example.com;>
#  http://www.example.com/evil-iframe.html;>
{code}

2. Put one of the commands like below is that external iframe in a 

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1530#comment-1530
 ] 

zhuisui commented on CB-11305:
--

thanks for the text effects.
About toInternalURL, I know it. I just don't know what it returns in this
situation. If it is effective as cdvfile protocol, why can't put it into
src of img directly.

On Wed, May 25, 2016, 20:56 Sergey Shakhnazarov (JIRA) 

-- 

追随


> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
# insert the following in the `index.html`
#  http://www.example.com;>
#  http://www.example.com/evil-iframe.html;>


2. Put one of the commands like below is that external iframe in a 

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1524#comment-1524
 ] 

Sergey Shakhnazarov commented on CB-11305:
--

I believe the introducing a generic fs root for 
{{cordova.file.applicationDirectory}} is a separate task - it's fine to fix the 
current issue of {{cdvfile://localhost/assets}} non resolving on Android in DOM 
with the one line you have mentioned.
I can send the PR if you want.

Regarding the {{toInternalURL()}} - see the snippet above + [file plugin 
docs|https://github.com/apache/cordova-plugin-file#cdvfile-protocol].

Regarding the Jira text effects:
https://issues.apache.org/jira/secure/WikiRendererHelpAction.jspa?section=texteffects

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Labels: security  (was: )

> Security: a malicious cross origin iframe can kill the app
> --
>
> Key: CB-11320
> URL: https://issues.apache.org/jira/browse/CB-11320
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Browser
> Environment: Windows 7, cordova 6.1.1, cordova-android 5.1.1
>Reporter: jakub-g
>  Labels: security
>
> It is written in Cordova security guide that generally one should avoid 
> iframes, unless they are fully in control of their contents:
> https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism
> However not everyone might be familiar with this.
> In general the iframe seems to follow the Single Origin Policy and does not 
> allow doing actions in the context of the top frame (main cordova app frame), 
> but I found the following issue:
> 1. Create a sample cordova project, and embed a third-party iframe in it:
> {code}
> cordova create foobar
> cd foobar
> cordova platform add android
> vim www/index.html
> {code}
> 2. Insert the following in the `index.html`
> {code}
>   http://www.example.com;>
>   http://www.example.com/evil-iframe.html;>
> {code}
> 3. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

{code}
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html

# insert the following in the `index.html`
#  http://www.example.com;>
#  http://www.example.com/evil-iframe.html;>
{code}

2. Put one of the commands like below is that external iframe in a 

[jira] [Created] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

jakub-g created CB-11320:


 Summary: Security: a malicious cross origin iframe can kill the app
 Key: CB-11320
 URL: https://issues.apache.org/jira/browse/CB-11320
 Project: Apache Cordova
  Issue Type: Bug
 Environment: Windows 7, cordova 6.1.1, cordova-android 5.1.1
Reporter: jakub-g


It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

```
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
# insert the following in the `index.html`
#  http://www.example.com;>
#  http://www.example.com/evil-iframe.html;>
```

2. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

{code}
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
{code}

2. Insert the following in the `index.html`

{code}
  http://www.example.com;>
  http://www.example.com/evil-iframe.html;>
{code}

3. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Description: 
It is written in Cordova security guide that generally one should avoid 
iframes, unless they are fully in control of their contents:

https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism

However not everyone might be familiar with this.
In general the iframe seems to follow the Single Origin Policy and does not 
allow doing actions in the context of the top frame (main cordova app frame), 
but I found the following issue:

1. Create a sample cordova project, and embed a third-party iframe in it:

[code]
cordova create foobar
cd foobar
cordova platform add android
vim www/index.html
# insert the following in the `index.html`
#  http://www.example.com;>
#  http://www.example.com/evil-iframe.html;>
[code]

2. Put one of the commands like below is that external iframe in a 

[jira] [Updated] (CB-11320) Security: a malicious cross origin iframe can kill the app

[jakub-g (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jakub-g updated CB-11320:
-
Component/s: Browser

> Security: a malicious cross origin iframe can kill the app
> --
>
> Key: CB-11320
> URL: https://issues.apache.org/jira/browse/CB-11320
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Browser
> Environment: Windows 7, cordova 6.1.1, cordova-android 5.1.1
>Reporter: jakub-g
>
> It is written in Cordova security guide that generally one should avoid 
> iframes, unless they are fully in control of their contents:
> https://cordova.apache.org/docs/en/latest/guide/appdev/security/#iframes-and-the-callback-id-mechanism
> However not everyone might be familiar with this.
> In general the iframe seems to follow the Single Origin Policy and does not 
> allow doing actions in the context of the top frame (main cordova app frame), 
> but I found the following issue:
> 1. Create a sample cordova project, and embed a third-party iframe in it:
> {code}
> cordova create foobar
> cd foobar
> cordova platform add android
> vim www/index.html
> {code}
> 2. Insert the following in the `index.html`
> {code}
>   http://www.example.com;>
>   http://www.example.com/evil-iframe.html;>
> {code}
> 3. Put one of the commands like below is that external iframe in a 

[jira] [Comment Edited] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299957#comment-15299957
 ] 

zhuisui edited comment on CB-11305 at 5/25/16 12:13 PM:


I agree with you. Maybe we need a generic fs root mapped to 
"cordova.file.applicationDirectory". So before I send a PR, I think we should 
consider it more.
Also, I touched Cordova and Android before less than two weeks. I am afraid I 
cannot qualified for this job.
Finally, you mention that "image.toInternalURL()" works well on Android if I 
don't mistake. Then, I'm interested in what it is really like. I will see it 
another day.

[~daserge] Could you tell me how to use MarkDown here?


was (Author: zyf0330):
I agree with you. Maybe we need a generic fs root mapped to 
`cordova.file.applicationDirectory`. So before I send a PR, I think we should 
consider it more.
Also, I touched Cordova and Android before less than two weeks. I am afraid I 
cannot qualified for this job.
Finally, you mention that `image.toInternalURL()` works well on Android if I 
don't mistake. Then, I'm interested in what it is really like. I will see it 
another day.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299957#comment-15299957
 ] 

zhuisui commented on CB-11305:
--

I agree with you. Maybe we need a generic fs root mapped to 
`cordova.file.applicationDirectory`. So before I send a PR, I think we should 
consider it more.
Also, I touched Cordova and Android before less than two weeks. I am afraid I 
cannot qualified for this job.
Finally, you mention that `image.toInternalURL()` works well on Android if I 
don't mistake. Then, I'm interested in what it is really like. I will see it 
another day.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11309) Platform specific plugins install to all platforms

[Trevor Brindle (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299916#comment-15299916
 ] 

Trevor Brindle commented on CB-11309:
-

Per our conversation on twitter [~shazron] here is the ticket. Let me know if 
you have any issues reproducing. 

> Platform specific plugins install to all platforms
> --
>
> Key: CB-11309
> URL: https://issues.apache.org/jira/browse/CB-11309
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, Plugman
>Affects Versions: 1.1.0, 6.1.1
>Reporter: Trevor Brindle
>
> CLI: 6.1.1
> Plugman: 1.2.1
> Node: 5.11.1
> npm: 3.9.2
> Steps to reproduce:
> 1. cordova create ~/Developer/plugmantest com.cordova.test plugmantest
> 2. cordova platform add ios android (4.1.1, 5.1.1)
> 3. cordova plugin add cordova-plugin-applepay-payeezy
> Resulted in: 
> Fetching plugin "cordova-plugin-applepay-payeezy" via npm
> Installing "cordova-plugin-applepay-payeezy" for android
> Installing "cordova-plugin-applepay-payeezy" for ios
> cordova-plugin-applepay-payeezy in android.json
> cordova-plugin-applepay-payeezy in platform_www
> Same result for 
> cordova plugin add https://github.com/shazron/KeychainPlugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11305) use cdvfile: cannot import image or js

[Sergey Shakhnazarov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Shakhnazarov updated CB-11305:
-
Labels: android reproduced triaged wfc  (was: android reproduced triaged)

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299904#comment-15299904
 ] 

Sergey Shakhnazarov commented on CB-11305:
--

[~zyf0330], can you send a PR with this fix?

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11305) use cdvfile: cannot import image or js

[Sergey Shakhnazarov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Shakhnazarov updated CB-11305:
-
Labels: android reproduced triaged  (was: )

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>  Labels: android, reproduced, triaged
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11305) use cdvfile: cannot import image or js

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299902#comment-15299902
 ] 

Sergey Shakhnazarov commented on CB-11305:
--

I confirm the issue and that the solution provided works.
With the current file plugin state it is possible to achieve the same using 
this code:
{code}
window.resolveLocalFileSystemURL(cordova.file.applicationDirectory, function 
(assetsRoot) {
assetsRoot.getFile('www/img/logo.png', null, function (image) {
document.getElementById('imageFileCdv').src = image.toInternalURL();
{code}

The same code works on iOS although the cdvfile fs root is inconsistent with 
Android - it's {{cdvfile://localhost/bundle}}.

Also the issue described is not present on iOS - i.e. 
{{cdvfile://localhost/bundle/path}} works as a DOM src.

It probably makes sense to introduce a crossplatform cdvfile fs root for 
{{cordova.file.applicationDirectory}} mapping to {{assets}} on Android, 
{{bundle}} on iOS and {{ms-appx}} on Windows.

> use cdvfile: cannot import image or js
> --
>
> Key: CB-11305
> URL: https://issues.apache.org/jira/browse/CB-11305
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.2.0
> Environment: cordova 6.6.1
> android 5.1.1
>Reporter: zhuisui
>
> I use cdvfile://localhost/assets/path to show img and import js, and it 
> doesn't work. I haven't seen anything about using with assets, but 
> window.resolveLocalFileSystemURL can handle it to native URL 
> file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11288) shouldOverrideUrlLoading not called

[vontio (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vontio updated CB-11288:

Labels: plugin  (was: )

> shouldOverrideUrlLoading not called
> ---
>
> Key: CB-11288
> URL: https://issues.apache.org/jira/browse/CB-11288
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 6.0.0
> Environment: windows
>Reporter: vontio
>  Labels: plugin
>
> reproduce:
> in cordova plugin initialize:
> (WebView)(webView.getEngine().getView()).setWebViewClient(new 
> SystemWebViewClient((SystemWebViewEngine) webView.getEngine()){
> @Override
> public boolean shouldOverrideUrlLoading(WebView view, String url) {
> Log.v(TAG,"shouldOverrideUrlLoading request " + url);
> return super.shouldOverrideUrlLoading(view, url);
> }
> @Override
> public WebResourceResponse shouldInterceptRequest (WebView view, 
> String url)
> {
> Log.v(TAG,"shouldInterceptRequest request " + url);
> return super.shouldInterceptRequest(view,url);
> }
> });
> only shouldInterceptRequest called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7958) touchend event not firing when released outside webview

[Eddy Verbruggen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299867#comment-15299867
 ] 

Eddy Verbruggen commented on CB-7958:
-

Hey guys,

I ran into the same issue today when embedding a webview in a native app. The 
native app has a native header so the 'touchend' event isn't called on the 
webview when your finger is released when over the header.

This gist solves my particular usecase: 
https://gist.github.com/EddyVerbruggen/70b96fce47fa7bf7a34f03e3a2ecb85f

Thought I'd share for others trying to fix a similar scenario.

Cheers,
Eddy

> touchend event not firing when released outside webview
> ---
>
> Key: CB-7958
> URL: https://issues.apache.org/jira/browse/CB-7958
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 3.6.3
> Environment: iOS 8, iPhone 6
>Reporter: Knut Eirik Leira Hjelle
>
> When starting a touch event inside of webview, it is possible to slowly slide 
> the finger to (and off) the edge of the screen and never get the touchend 
> event. Making the webview fullscreen seems to remove the issue.
> The only information I have found about this issue is a stack overflow post 
> (http://stackoverflow.com/questions/26721447/ios-no-touchend-event-for-not-fullscreen-webview),
>  which is why I tried to replicate the problem with a fullscreen webview.
> I have not been able to reproduce this problem on any devices except the 
> iPhone6 on iOS 8.
> Created a small cordova project which makes the bug reproducible.
> https://github.com/hjellek/cordova-ios-touch-issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11319) CLONE - Orientation preference is ignored on iOS

[Roman Kisilenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Kisilenko updated CB-11319:
-
Description: 
This issue is similar to https://issues.apache.org/jira/browse/CB-6026

[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.

-- Cordova CLI: 6.1.1

  was:
[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.

-- Cordova CLI: 6.1.1


> CLONE - Orientation preference is ignored on iOS
> 
>
> Key: CB-11319
> URL: https://issues.apache.org/jira/browse/CB-11319
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, iOS
>Reporter: Roman Kisilenko
>Priority: Minor
>
> This issue is similar to https://issues.apache.org/jira/browse/CB-6026
> [Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say 
> that this should work:
> {quote}
>  
> {quote}
> But it doesn't.
> -- Cordova CLI: 6.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11319) CLONE - Orientation preference is ignored on iOS

[Roman Kisilenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Kisilenko updated CB-11319:
-
Description: 
This issue is similar to CB-6026

[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.

-- Cordova CLI: 6.1.1

  was:
This issue is similar to https://issues.apache.org/jira/browse/CB-6026

[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.

-- Cordova CLI: 6.1.1


> CLONE - Orientation preference is ignored on iOS
> 
>
> Key: CB-11319
> URL: https://issues.apache.org/jira/browse/CB-11319
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, iOS
>Reporter: Roman Kisilenko
>Priority: Minor
>
> This issue is similar to CB-6026
> [Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say 
> that this should work:
> {quote}
>  
> {quote}
> But it doesn't.
> -- Cordova CLI: 6.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11319) CLONE - Orientation preference is ignored on iOS

[Roman Kisilenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Kisilenko updated CB-11319:
-
Description: 
[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.

-- Cordova CLI: 6.1.1

  was:
[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.



> CLONE - Orientation preference is ignored on iOS
> 
>
> Key: CB-11319
> URL: https://issues.apache.org/jira/browse/CB-11319
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, iOS
>Reporter: Roman Kisilenko
>Priority: Minor
>
> [Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say 
> that this should work:
> {quote}
>  
> {quote}
> But it doesn't.
> -- Cordova CLI: 6.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11319) CLONE - Orientation preference is ignored on iOS

[Roman Kisilenko (JIRA)]

Roman Kisilenko created CB-11319:


 Summary: CLONE - Orientation preference is ignored on iOS
 Key: CB-11319
 URL: https://issues.apache.org/jira/browse/CB-11319
 Project: Apache Cordova
  Issue Type: Bug
  Components: CLI, iOS
Reporter: Roman Kisilenko
Priority: Minor


[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11319) CLONE - Orientation preference is ignored on iOS

[Roman Kisilenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Kisilenko updated CB-11319:
-
Description: 
[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.


  was:
[Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say that 
this should work:
{quote}
 
{quote}
But it doesn't.



> CLONE - Orientation preference is ignored on iOS
> 
>
> Key: CB-11319
> URL: https://issues.apache.org/jira/browse/CB-11319
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, iOS
>Reporter: Roman Kisilenko
>Priority: Minor
>
> [Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say 
> that this should work:
> {quote}
>  
> {quote}
> But it doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11318) mailto: is not working in Android after adding ''

[Vinoth Kumar (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299560#comment-15299560
 ] 

Vinoth Kumar edited comment on CB-11318 at 5/25/16 8:14 AM:


I solved the problem by adding platform specific config but I still don't 
understand why we need to have different whitelist config for iOS and Android 
for 'mailto'


was (Author: vinbtechdf):
I solved the problem by adding platform specific config but I still don't 
understand we need to have different whitelist config for iOS and Android for 
'mailto'

> mailto: is not working in Android after adding ' href="mailto:*; />'
> -
>
> Key: CB-11318
> URL: https://issues.apache.org/jira/browse/CB-11318
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
>Reporter: Vinoth Kumar
>
> In Android, mailto is not working after adding  href="mailto:*; />
> If I only use mailto:*; />, mailto is 
> working in Android but to make it work in iOS i added  href="mailto:*; />. Then it stopped working on Android.
> Currently my config has the following 
> mailto:*; />
> mailto:*; />
> I am using a combined config for both Android and iOS.
> Cordova CLI version is 6.1.0 and Android version is 5.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7891) platform update wp8 Does not save ProductID

[Sergey (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299563#comment-15299563
 ] 

Sergey commented on CB-7891:


Related CB-8889, if it works fine, issue can close

> platform update wp8  Does not save ProductID
> 
>
> Key: CB-7891
> URL: https://issues.apache.org/jira/browse/CB-7891
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 4.0.0
> Environment: NodeJS 0.10.33, Windows 8.1 x64 Pro
>Reporter: Sergey
>
> cordova platform update wp8 
> Does not save ProductID in WMAppManifest.xml so its looks like new app and 
> clear project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11318) mailto: is not working in Android after adding ''

[Vinoth Kumar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinoth Kumar updated CB-11318:
--
Priority: Major  (was: Critical)

I solved the problem by adding platform specific config but I still don't 
understand we need to have different whitelist config for iOS and Android for 
'mailto'

> mailto: is not working in Android after adding ' href="mailto:*; />'
> -
>
> Key: CB-11318
> URL: https://issues.apache.org/jira/browse/CB-11318
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
>Reporter: Vinoth Kumar
>
> In Android, mailto is not working after adding  href="mailto:*; />
> If I only use mailto:*; />, mailto is 
> working in Android but to make it work in iOS i added  href="mailto:*; />. Then it stopped working on Android.
> Currently my config has the following 
> mailto:*; />
> mailto:*; />
> I am using a combined config for both Android and iOS.
> Cordova CLI version is 6.1.0 and Android version is 5.1.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org