date:20160727

[jira] [Updated] (CB-11635) Passing object to navigator.notification.alert crashes iOS app

2016-07-27 Thread Don Coleman (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Don Coleman updated CB-11635:
-
Description: 
Create  new project

{noformat}
$ cordova create foo
$ cd foo
$ cordova plugin add cordova-plugin-dialogs
$ cordova platform add ios
{noformat}

Edit www/js/index.js and replace onDeviceReady with 

{code:title=www/js/index.js}
onDeviceReady: function() {
app.receivedEvent('deviceready');

// this crashes the app on iOS
var dictionary = { error: 'notification plugin is expecting a string'};
navigator.notification.alert(dictionary);
},
{code}

Run the app

{noformat}
$ cordova run ios
{noformat}

RESULT: This crashed the app on a device and on the simulator
EXPECTED RESULT: String or \[Object object\] in the dialog box or perhaps an 
error

{noformat}
$ cordova -v
6.3.0
$ cordova platform ls
Installed platforms:
  ios 4.2.0
$ cordova plugin list
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-whitelist 1.2.2 "Whitelist"
{noformat}


  was:
Create  new project

$ cordova create foo
$ cd foo
$ cordova plugin add cordova-plugin-dialogs
$ cordova platform add ios

Edit www/js/index.js and replace onDeviceReady with 

onDeviceReady: function() {
app.receivedEvent('deviceready');

// this crashes the app on iOS
var dictionary = { error: 'notification plugin is expecting a string'};
navigator.notification.alert(dictionary);
},

Run the app

$ cordova run ios

RESULT: This crashed the app on a device and on the simulator
EXPECTED RESULT: String or [Object object] in the dialog box or some error

$ cordova -v
6.3.0
$ cordova platform ls
Installed platforms:
  ios 4.2.0
$ cordova plugin list
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-whitelist 1.2.2 "Whitelist"




> Passing object to navigator.notification.alert crashes iOS app
> --
>
> Key: CB-11635
> URL: https://issues.apache.org/jira/browse/CB-11635
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs
>Affects Versions: 6.3.0
>Reporter: Don Coleman
>
> Create  new project
> {noformat}
> $ cordova create foo
> $ cd foo
> $ cordova plugin add cordova-plugin-dialogs
> $ cordova platform add ios
> {noformat}
> Edit www/js/index.js and replace onDeviceReady with 
> {code:title=www/js/index.js}
> onDeviceReady: function() {
> app.receivedEvent('deviceready');
> // this crashes the app on iOS
> var dictionary = { error: 'notification plugin is expecting a 
> string'};
> navigator.notification.alert(dictionary);
> },
> {code}
> Run the app
> {noformat}
> $ cordova run ios
> {noformat}
> RESULT: This crashed the app on a device and on the simulator
> EXPECTED RESULT: String or \[Object object\] in the dialog box or perhaps an 
> error
> {noformat}
> $ cordova -v
> 6.3.0
> $ cordova platform ls
> Installed platforms:
>   ios 4.2.0
> $ cordova plugin list
> cordova-plugin-dialogs 1.2.1 "Notification"
> cordova-plugin-whitelist 1.2.2 "Whitelist"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11635) Passing object to navigator.notification.alert crashes iOS app

2016-07-27 Thread Don Coleman (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Don Coleman updated CB-11635:
-
Description: 
Create  new project

$ cordova create foo
$ cd foo
$ cordova plugin add cordova-plugin-dialogs
$ cordova platform add ios

Edit www/js/index.js and replace onDeviceReady with 

onDeviceReady: function() {
app.receivedEvent('deviceready');

// this crashes the app on iOS
var dictionary = { error: 'notification plugin is expecting a string'};
navigator.notification.alert(dictionary);
},

Run the app

$ cordova run ios

RESULT: This crashed the app on a device and on the simulator
EXPECTED RESULT: String or [Object object] in the dialog box or some error

$ cordova -v
6.3.0
$ cordova platform ls
Installed platforms:
  ios 4.2.0
$ cordova plugin list
cordova-plugin-dialogs 1.2.1 "Notification"
cordova-plugin-whitelist 1.2.2 "Whitelist"



> Passing object to navigator.notification.alert crashes iOS app
> --
>
> Key: CB-11635
> URL: https://issues.apache.org/jira/browse/CB-11635
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs
>Affects Versions: 6.3.0
>Reporter: Don Coleman
>
> Create  new project
> $ cordova create foo
> $ cd foo
> $ cordova plugin add cordova-plugin-dialogs
> $ cordova platform add ios
> Edit www/js/index.js and replace onDeviceReady with 
> onDeviceReady: function() {
> app.receivedEvent('deviceready');
> // this crashes the app on iOS
> var dictionary = { error: 'notification plugin is expecting a 
> string'};
> navigator.notification.alert(dictionary);
> },
> Run the app
> $ cordova run ios
> RESULT: This crashed the app on a device and on the simulator
> EXPECTED RESULT: String or [Object object] in the dialog box or some error
> $ cordova -v
> 6.3.0
> $ cordova platform ls
> Installed platforms:
>   ios 4.2.0
> $ cordova plugin list
> cordova-plugin-dialogs 1.2.1 "Notification"
> cordova-plugin-whitelist 1.2.2 "Whitelist"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11635) Passing object to navigator.notification.alert crashes iOS app

2016-07-27 Thread Don Coleman (JIRA)

Don Coleman created CB-11635:


 Summary: Passing object to navigator.notification.alert crashes 
iOS app
 Key: CB-11635
 URL: https://issues.apache.org/jira/browse/CB-11635
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Dialogs
Affects Versions: 6.3.0
Reporter: Don Coleman






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396772#comment-15396772
 ] 

ASF GitHub Bot commented on CB-8978:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/468
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) is 80.62% 
(diff: 100%)
> Merging [#468](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #468   diff @@
==
  Files68 68  
  Lines  5394   5394  
  Methods 855855  
  Messages  0  0  
  Branches   1040   1040  
==
  Hits   4349   4349  
  Misses 1045   1045  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[29382ca...02c558f](https://codecov.io/gh/apache/cordova-lib/compare/29382ca2bf67e17337845feb4360980df99fe3d2...02c558f6abd09b13066740a43dc711a464dd017e?src=pr)


> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11634) cordova-plugin-vibration not installing on PhoneGap Build cli-6.3.0

2016-07-27 Thread Benjamin Omasanuwa (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Omasanuwa updated CB-11634:

Description: 
When I have my config.xml file set up as:
 
  
 
 

I get the below error:
Installing "cordova-plugin-vibration" at "2.1.1" for windows
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
at Object.jsprojManager.addProjectReference 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
at handlers.framework.install 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
at Object.ActionStack.process 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
at PluginManager.doOperation 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:117:20)
at PluginManager.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:147:17)
at Api.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'

I get the same error when:
 


  was:
When I have my config.xml file set up as:
 
  
 
 

I get the below error:
Installing "cordova-plugin-vibration" at "2.1.1" for windows
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
at Object.jsprojManager.addProjectReference 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
at handlers.framework.install 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
at Object.ActionStack.process 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
at PluginManager.doOperation 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:117:20)
at PluginManager.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:147:17)
at Api.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'


> cordova-plugin-vibration not installing on PhoneGap Build cli-6.3.0
> ---
>
> Key: CB-11634
> URL: https://issues.apache.org/jira/browse/CB-11634
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Vibration
>Affects Versions: 2.1.1
> Environment: PhoneGap Build
>Reporter: Benjamin Omasanuwa
>  Labels: build, phonegap, phonegap-build, windows
>
> When I have my config.xml file set up as:
>  
>   
>  
>  
> I get the below error:
> Installing "cordova-plugin-vibration" at "2.1.1" for windows
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-vibration':Error: Uh oh!
> ENOENT: no such file or directory, open 
> 'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
> at Error (native)
> at Object.fs.openSync (fs.js:549:18)
> at Object.fs.readFileSync (fs.js:397:15)
> at Object.module.exports.parseElementtreeSync 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
> at Object.jsprojManager.addProjectReference 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
> at handlers.framework.install 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
> at Object.ActionStack.process 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
> at

[jira] [Updated] (CB-11634) cordova-plugin-vibration not installing on PhoneGap Build cli-6.3.0

2016-07-27 Thread Benjamin Omasanuwa (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Omasanuwa updated CB-11634:

Description: 
When I have my config.xml file set up as:
 
  
 
 

I get the below error:
Installing "cordova-plugin-vibration" at "2.1.1" for windows
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
at Object.jsprojManager.addProjectReference 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
at handlers.framework.install 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
at Object.ActionStack.process 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
at PluginManager.doOperation 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:117:20)
at PluginManager.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:147:17)
at Api.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'

  was:
When I have my config.xml file set up as:
 
  
 
 

I get the below error:
Installing "cordova-plugin-vibration" at "2.1.1" for windows
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
at Object.jsprojManager.addProjectReference 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
at handlers.framework.install 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
at Object.ActionStack.process 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
at PluginManager.doOperation 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:117:20)
at PluginManager.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:147:17)
at Api.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'


When it is:
 
  
 
 
 
I get the below error:




> cordova-plugin-vibration not installing on PhoneGap Build cli-6.3.0
> ---
>
> Key: CB-11634
> URL: https://issues.apache.org/jira/browse/CB-11634
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Vibration
>Affects Versions: 2.1.1
> Environment: PhoneGap Build
>Reporter: Benjamin Omasanuwa
>  Labels: build, phonegap, phonegap-build, windows
>
> When I have my config.xml file set up as:
>  
>   
>  
>  
> I get the below error:
> Installing "cordova-plugin-vibration" at "2.1.1" for windows
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-vibration':Error: Uh oh!
> ENOENT: no such file or directory, open 
> 'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
> at Error (native)
> at Object.fs.openSync (fs.js:549:18)
> at Object.fs.readFileSync (fs.js:397:15)
> at Object.module.exports.parseElementtreeSync 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
> at Object.jsprojManager.addProjectReference 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
> at handlers.framework.install 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
> at Object.ActionStack.process 
> (C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
> at

[jira] [Created] (CB-11634) cordova-plugin-vibration not installing on PhoneGap Build cli-6.3.0

2016-07-27 Thread Benjamin Omasanuwa (JIRA)

Benjamin Omasanuwa created CB-11634:
---

 Summary: cordova-plugin-vibration not installing on PhoneGap Build 
cli-6.3.0
 Key: CB-11634
 URL: https://issues.apache.org/jira/browse/CB-11634
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Vibration
Affects Versions: 2.1.1
 Environment: PhoneGap Build
Reporter: Benjamin Omasanuwa


When I have my config.xml file set up as:
 
  
 
 

I get the below error:
Installing "cordova-plugin-vibration" at "2.1.1" for windows
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\util\xml-helpers.js:118:27)
at Object.jsprojManager.addProjectReference 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\JsprojManager.js:187:44)
at handlers.framework.install 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\lib\PluginHandler.js:92:25)
at Object.ActionStack.process 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\ActionStack.js:56:25)
at PluginManager.doOperation 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:117:20)
at PluginManager.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\node_modules\cordova-common\src\PluginManager.js:147:17)
at Api.addPlugin 
(C:\cygwin\tmp\gimlet\2149308\project\cordova\Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'C:\cygwin\home\Administrator\gimlet\plugins\cordova-plugin-vibration\src\windows\Vibration\Vibration.csproj'


When it is:
 
  
 
 
 
I get the below error:





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396665#comment-15396665
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72543969
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
--- End diff --

Correction: Not needed for Podfile. Thanks!


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project:

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396664#comment-15396664
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72543906
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+
+
expect(podfileContent.includes(CWStatusBarNotification)).toBe(false);
+expect(podfileContent.includes(AFNetworking));
+  
+delete require.cache[require.resolve(podsJSON)];
+

[jira] [Commented] (CB-8978) Adding New Image Element to config.xml

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396657#comment-15396657
 ] 

ASF GitHub Bot commented on CB-8978:


GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-lib/pull/468

CB-8978 Add resource-file parsing to config.xml

Original JIRA issue https://issues.apache.org/jira/browse/CB-8978
Related to/replaces https://github.com/apache/cordova-lib/pull/214
See also https://github.com/cordova/cordova-discuss/issues/6

This is just the first pass, we'll also need to update the platform API in 
each platform to actually copy the resource files around on prepare.

This returns the same data structure as the PluginInfo class. To be 
determined if we think having top-level `resource-file` elements makes sense, 
it appears that plugin.xml does not support them.

/cc @ktop @jcesarmobile

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-lib resource-file

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #468


commit 552ce1da2932ccf43b2a137c641fcb90a4bfc27b
Author: Darryl Pogue 
Date:   2016-07-27T23:28:08Z

CB-8978 Add resource-file parsing to config.xml




> Adding New Image Element to config.xml
> --
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CLI, CordovaLib
>Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that 
> handles copying images from a source to destination in the config.xml. These 
> elements also only handle copying 1 image only and replacing what was 
> previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could 
> be notification icons, button icons, custom image text, etc. and not limited 
> to just 1 image. 
> Example:
> 
>  density="mdpi" />
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and 
> height attribute may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396650#comment-15396650
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72542674
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+
+
expect(podfileContent.includes(CWStatusBarNotification)).toBe(false);
+expect(podfileContent.includes(AFNetworking));
+  
+delete require.cache[require.resolve(podsJSON)];
+

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396626#comment-15396626
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72541227
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+
+
expect(podfileContent.includes(CWStatusBarNotification)).toBe(false);
+expect(podfileContent.includes(AFNetworking));
+  
+delete require.cache[require.resolve(podsJSON)];
+

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396624#comment-15396624
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72541191
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
--- End diff --

The Podfile and pods.json should change after the removal and adding of a 
plugin. I believe the deletion of cache is necessary here. 


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
>

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396587#comment-15396587
 ] 

ASF GitHub Bot commented on CB-9825:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/467
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/467?src=pr) is 80.71% 
(diff: 100%)
> Merging [#467](https://codecov.io/gh/apache/cordova-lib/pull/467?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will increase coverage by **0.09%**

```diff
@@ master   #467   diff @@
==
  Files68 68  
  Lines  5394   5394  
  Methods 855855  
  Messages  0  0  
  Branches   1040   1040  
==
+ Hits   4349   4354 +5   
+ Misses 1045   1040 -5   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[29382ca...cb05c60](https://codecov.io/gh/apache/cordova-lib/compare/29382ca2bf67e17337845feb4360980df99fe3d2...cb05c601708633c37e3925c3744e9fcb0448e246?src=pr)


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396571#comment-15396571
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/467
  
This looks good! Aside from the minor comments I left, I think it might be 
good to go. 

Travis hasn't run yet. Queued up. 

@shazron any comments?


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396569#comment-15396569
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72538340
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+var numberOfTimesAFNetworkingIsInPodfile = 
podfileContent.match(/AFNetworking/g || []).length;
+
+expect(podfileContent.includes(CWStatusBarNotification));
+expect(numberOfTimesAFNetworkingIsInPodfile).toEqual(1); 
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+var countPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].count;
+var specPropertyOfAFNetworkingInPodsJSON = 
podsJSONContent[AFNetworking].spec;
+
+expect(countPropertyOfAFNetworkingInPodsJSON).toEqual(2);
+//spec property should not be changed because of overlapping 
dependency
+expect(specPropertyOfAFNetworkingInPodsJSON).toEqual('~> 3.0');
+
+return 
cordova.raw.plugin('rm','sample-cocoapod-plugin-overlapping-dependency');
+})
+.then(function() {
+//expect only AFNetworking
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'}); 
+
+
expect(podfileContent.includes(CWStatusBarNotification)).toBe(false);
+expect(podfileContent.includes(AFNetworking));
+  
+delete require.cache[require.resolve(podsJSON)];
+

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396557#comment-15396557
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72538178
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
+var podfileContent = fs.readFileSync(podfile, {'encoding' : 
'utf8'});
+
+expect(podfileContent.includes(AFNetworking));
+
+delete require.cache[require.resolve(podsJSON)];
+var podsJSONContent = require(podsJSON);
+
+expect(podsJSONContent[AFNetworking] !== null);
+return cordova.raw.plugin('add', overlappingDependencyPlugin);
+})
+.then(function() {
+delete require.cache[require.resolve(podfile)];
--- End diff --

not needed for same reason as before


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396554#comment-15396554
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72538082
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
+})
+.then(function() {
+return cordova.raw.plugin('add', samplePlugin);
+})
+.then(function() {
+podfile = path.resolve('./platforms/ios/Podfile');
+podsJSON = path.resolve('./platforms/ios/pods.json');
+workspace = 
path.resolve('./platforms/ios/HelloCordova.xcworkspace');
+
+//podfile should have been created
+fs.exists(podfile, function(podfileExists){
+expect(podfileExists);
+});
+
+//pods.json should have been created
+fs.exists(podsJSON, function(podsJSONExists){
+expect(podsJSONExists);
+});
+
+//workspace should have been created
+fs.exists(workspace, function(workspaceCreated){
+expect(workspaceCreated);
+});
+
+delete require.cache[require.resolve(podfile)];
--- End diff --

You don't need to do this delete for podfile since you don't 
require('podfile')


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396550#comment-15396550
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72537902
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
+process.chdir(tmpDir);
+});
+
+afterEach(function() {
+process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+shell.rm('-rf', tmpDir);
+});
+
+it('installs and uninstalls plugin depending on new pod and existing 
pod', function(done) {
+
+cordova.raw.create('hello4')
+.then(function() {
+process.chdir(project);
+//TODO: change this to cordova-ios on npm 
+return cordova.raw.platform('add', 
'https://github.com/juliascript/cordova-ios.git#CB-9825');
--- End diff --

Todo: change this to cordova-ios on npm once new cordova-ios is published 
with this pr. 

Thought I would add your todo to the pr comments


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396521#comment-15396521
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72535870
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', 
function () {
 .fin(done);
 }, 6);
 });
+
+describe('cocoapod plugin add and rm end-to-end', function () {
+
+var tmpDir = helpers.tmpDir('cocoapod_plugin_test');
+var project = path.join(tmpDir, 'hello4');
+
+var samplePlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent');
+var overlappingDependencyPlugin = 
path.resolve('./spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency');
+var AFNetworking = 'AFNetworking',
+CWStatusBarNotification = 'CWStatusBarNotification';
+var podfile, podsJSON, workspace;
+
+beforeEach(function() {
+shell.exec('pwd');
--- End diff --

I think you can remove this pwd


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11178) Can't open other apps with custom url scheme in iOS 9.3.1

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396497#comment-15396497
 ] 

ASF GitHub Bot commented on CB-11178:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/177


> Can't open other apps with custom url scheme in iOS 9.3.1
> -
>
> Key: CB-11178
> URL: https://issues.apache.org/jira/browse/CB-11178
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: iPhone 6, iOS 9.3.1, Cordova 6.1.1, Ionic 1.7.14, 
> InAppBrowser 1.4.0
>Reporter: Björn Bur
>Assignee: jcesarmobile
>  Labels: iOS, triaged
>
> Hi,
> First of all I'm not sure if this is a bug or not, but I have the following 
> problem:
> I try to open another app with the following code:
> cordova.InAppBrowser.open('fb://', '_system');
> This works on a iPad with iOS 8.4.1 but when I use the same code on my iPhone 
> with iOS 9.3.1 nothing happens.
> Am I doing something wrong or is this really a bug?
> Thanks
> Björn



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11178) Can't open other apps with custom url scheme in iOS 9.3.1

2016-07-27 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396496#comment-15396496
 ] 

ASF subversion and git services commented on CB-11178:
--

Commit 3f63aaee583f85a8ed603fc15cc83127919f8320 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~jcesarmobile]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3f63aae
 ]

CB-11178 allow to open other apps on iOS 9

 This closes #177


> Can't open other apps with custom url scheme in iOS 9.3.1
> -
>
> Key: CB-11178
> URL: https://issues.apache.org/jira/browse/CB-11178
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: iPhone 6, iOS 9.3.1, Cordova 6.1.1, Ionic 1.7.14, 
> InAppBrowser 1.4.0
>Reporter: Björn Bur
>Assignee: jcesarmobile
>  Labels: iOS, triaged
>
> Hi,
> First of all I'm not sure if this is a bug or not, but I have the following 
> problem:
> I try to open another app with the following code:
> cordova.InAppBrowser.open('fb://', '_system');
> This works on a iPad with iOS 8.4.1 but when I use the same code on my iPhone 
> with iOS 9.3.1 nothing happens.
> Am I doing something wrong or is this really a bug?
> Thanks
> Björn



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11178) Can't open other apps with custom url scheme in iOS 9.3.1

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396488#comment-15396488
 ] 

ASF GitHub Bot commented on CB-11178:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/177
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/177/commits/9bbdf2dd710d3f0d942ab3344f06a6815a48a39b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/56//PLATFORM=android/artifact/)
 |
 



> Can't open other apps with custom url scheme in iOS 9.3.1
> -
>
> Key: CB-11178
> URL: https://issues.apache.org/jira/browse/CB-11178
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: iPhone 6, iOS 9.3.1, Cordova 6.1.1, Ionic 1.7.14, 
> InAppBrowser 1.4.0
>Reporter: Björn Bur
>Assignee: jcesarmobile
>  Labels: iOS, triaged
>
> Hi,
> First of all I'm not sure if this is a bug or not, but I have the following 
> problem:
> I try to open another app with the following code:
> cordova.InAppBrowser.open('fb://', '_system');
> This works on a iPad with iOS 8.4.1 but when I use the same code on my iPhone 
> with iOS 9.3.1 nothing happens.
> Am I doing something wrong or is this really a bug?
> Thanks
> Björn



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11178) Can't open other apps with custom url scheme in iOS 9.3.1

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396451#comment-15396451
 ] 

ASF GitHub Bot commented on CB-11178:
-

GitHub user jcesarmobile opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/177

CB-11178 allow to open other apps on iOS 9



### Platforms affected
iOS 9

### What does this PR do?
Removes the canOpenURL check and just call openURL as on iOS you can't call 
canOpenURL without adding the schemes you want to query in the info.plist

### What testing has been done on this change?
Tested on iOs 9 devices

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser 
CB-11178-cant-open-other-apps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #177


commit 9bbdf2dd710d3f0d942ab3344f06a6815a48a39b
Author: Julio César 
Date:   2016-07-27T21:38:43Z

CB-11178 allow to open other apps on iOS 9




> Can't open other apps with custom url scheme in iOS 9.3.1
> -
>
> Key: CB-11178
> URL: https://issues.apache.org/jira/browse/CB-11178
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: iPhone 6, iOS 9.3.1, Cordova 6.1.1, Ionic 1.7.14, 
> InAppBrowser 1.4.0
>Reporter: Björn Bur
>Assignee: jcesarmobile
>  Labels: iOS, triaged
>
> Hi,
> First of all I'm not sure if this is a bug or not, but I have the following 
> problem:
> I try to open another app with the following code:
> cordova.InAppBrowser.open('fb://', '_system');
> This works on a iPad with iOS 8.4.1 but when I use the same code on my iPhone 
> with iOS 9.3.1 nothing happens.
> Am I doing something wrong or is this really a bug?
> Thanks
> Björn



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396420#comment-15396420
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72528666
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent/plugin.xml
 ---
@@ -0,0 +1,15 @@
+
+http://www.phonegap.com/ns/plugins/1.0;
+xmlns:android="http://schemas.android.com/apk/res/android;
+id="sample-cordova-plugin-cocoapod-dependent"
+version="3.0.0">
+
+Test Plugin
+
+
+
+
--- End diff --

you can remove the plugin-plist line since this was tested by a different 
test.


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396421#comment-15396421
 ] 

ASF GitHub Bot commented on CB-9825:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72528694
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/plugin.xml
 ---
@@ -0,0 +1,16 @@
+
+http://www.phonegap.com/ns/plugins/1.0;
+xmlns:android="http://schemas.android.com/apk/res/android;
+id="sample-cocoapod-plugin-overlapping-dependency"
+version="3.0.0">
+
+Test Plugin
+
+
+
+
--- End diff --

same here, remove plugin-plist line


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11633) Screen is cutting when changing portrait mode to landscape mode on iphone 5

2016-07-27 Thread fahad (JIRA)

fahad created CB-11633:
--

 Summary: Screen is cutting when changing portrait mode to 
landscape mode on iphone 5
 Key: CB-11633
 URL: https://issues.apache.org/jira/browse/CB-11633
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Screen Orientation
Reporter: fahad


We are experiencing following issue
Screen width is not updating and remain the same as it was in portrait mode we 
also changed view-port meta tag also when we go from  potrait mode to landscape 
mode and made width=device-height but no success.

Screen image link is below:
https://cloud.githubusercontent.com/assets/17248413/17167134/44cd6698-5390-11e6-8197-54a5e514e6ca.png

Please let us know about its solution

Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11423) Web view shrinks after locking screen orientation

2016-07-27 Thread Tony Homer (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396281#comment-15396281
 ] 

Tony Homer commented on CB-11423:
-

Hi [~rbarriuso], sorry about the auto-response in the comment below!  As it 
states, I was out of the office for the past week!  No progress yet, thanks for 
following up, I'll provide an update ASAP.

> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11632) setVoulme issue on iOS

2016-07-27 Thread KULDIP D PIPALIYA (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KULDIP D PIPALIYA  updated CB-11632:

Priority: Minor  (was: Major)

> setVoulme issue on  iOS
> ---
>
> Key: CB-11632
> URL: https://issues.apache.org/jira/browse/CB-11632
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
>Reporter: KULDIP D PIPALIYA 
>Priority: Minor
>
> I am facing issue to setVolume()  method using  input[type=range]  controller.
> I have created a gist for it  
> https://gist.github.com/kuldipem/2174c53725f77e4c7db10e7b2359ca69
> For FullPlayer setVolume() works fine but with other FreePlayer, it doesn't 
> work



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11632) setVoulme issue on iOS

2016-07-27 Thread KULDIP D PIPALIYA (JIRA)

KULDIP D PIPALIYA  created CB-11632:
---

 Summary: setVoulme issue on  iOS
 Key: CB-11632
 URL: https://issues.apache.org/jira/browse/CB-11632
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Media
Reporter: KULDIP D PIPALIYA 


I am facing issue to setVolume()  method using  input[type=range]  controller.

I have created a gist for it  
https://gist.github.com/kuldipem/2174c53725f77e4c7db10e7b2359ca69

For FullPlayer setVolume() works fine but with other FreePlayer, it doesn't work



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11623) --link-to no longer seems to be working

2016-07-27 Thread Kyle Kirbatski (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396217#comment-15396217
 ] 

Kyle Kirbatski commented on CB-11623:
-

This is a huge breaking change for me and the company I work for. Something 
like this should not of been put into a minor release but a major release.

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>Assignee: Steve Gill
>  Labels: triaged
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396102#comment-15396102
 ] 

ASF GitHub Bot commented on CB-11621:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-docs/pull/623
  
LGTM


> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11577) Add special treatment for iTunesArtwork icons

2016-07-27 Thread Kerri Shotts (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396080#comment-15396080
 ] 

Kerri Shotts commented on CB-11577:
---

Are you distributing via the app store or ad-hoc? My app store apps have never 
needed this (they get their icon from the one I give to itunes connect).

> Add special treatment for iTunesArtwork icons
> -
>
> Key: CB-11577
> URL: https://issues.apache.org/jira/browse/CB-11577
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Affects Versions: 4.1.1
> Environment: % cordova --version
> 6.2.0
> % cordova platform ls
> Installed platforms:
>   ios 4.1.1
>Reporter: Ricardo Panaggio
>  Labels: icons
>
> If you want icons show up on iTunes, you need to add at the root of the Xcode 
> project png files with these names and sizes:
> *  iTunesArtwork (512x512)
> *  iTunesArtwork@2x (1024x1024)
> (yep, no file extension)
> Related docs: https://developer.apple.com/library/ios/qa/qa1686/_index.html
> If you don't, you get this on iTunes: http://imgur.com/6hyAxLU
> My suggestion would be to get icons of those sizes from config.xml and add 
> these files on the root of the project automatically, as a part of the icons 
> processing.
> Crappy iOS :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11596) Resources cannot be loaded sometimes

2016-07-27 Thread Kerri Shotts (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396055#comment-15396055
 ] 

Kerri Shotts commented on CB-11596:
---

Please be more clear as to what you mean by "sometimes" -- is it that:

 - some files always fail to be loaded (but others load fine)
 - individual files will load correctly, say 50% of the time, but then fail to 
load the other times?

I'd expect a reference like {{file:///cordova.js}} to fail, because that's 
going to try to load something from the device root, and obviously there is no 
file named {{/cordova.js}} on iOS. Please double check your code to ensure that 
you're using relative references instead of absolute references when referring 
to scripts.

> Resources cannot be loaded sometimes
> 
>
> Key: CB-11596
> URL: https://issues.apache.org/jira/browse/CB-11596
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.2.0
> Environment: Node version: v6.3.0
> Cordova version: 6.2.0
> OS: OSX El Captain 10.11.5
> Plugins: 
> cordova-plugin-console,cordova-plugin-device,cordova-plugin-splashscreen,cordova-plugin-statusbar,cordova-plugin-whitelist,ionic-plugin-keyboard
> Android platform:
> Available Android targets:
> --
> id: 1 or "android-22"
>  Name: Android 5.1.1
>  Type: Platform
>  API level: 22
>  Revision: 2
>  Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, WVGA800 (default), 
> WVGA854, WXGA720, WXGA800, WXGA800-7in
>  Tag/ABIs : default/x86_64
> --
> id: 2 or "android-23"
>  Name: Android 6.0
>  Type: Platform
>  API level: 23
>  Revision: 3
>  Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, WVGA800 (default), 
> WVGA854, WXGA720, WXGA800, WXGA800-7in
>  Tag/ABIs : default/x86, default/x86_64
> iOS platform:
> Xcode 7.3.1
> Build version 7D1014
>Reporter: Attila
>
> Althought the files are copied to the device: 
> [ 21%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/app.bundle.js
>  to device
> [ 28%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/app.bundle.js.map
>  to device
> [ 36%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/es6-shim.map
>  to device
> [ 36%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/es6-shim.min.js
>  to device
> [ 36%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/Reflect.js
>  to device
> [ 36%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/Reflect.js.map
>  to device
> [ 37%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/build/js/zone.js
>  to device
> ...
> [ 48%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/cordova.js
>  to device
>  48%] Copying 
> /Users/attila/x/any-plan/platforms/ios/build/device/any-plan.app/www/cordova_plugins.js
>  to device
> Also inspecting the content of the builded package shows that the files are 
> there but on a device they cannot be loaded. It says `Failed to load 
> resource: The requested URL was not found on this server.`. The paths it try 
> to loads are: 
> ```
> file:///cordova.js
> file:///build/js/es6-shim.min.js
> // etc.. 
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396050#comment-15396050
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72488127
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/RELEASENOTES.md
 ---
@@ -0,0 +1,141 @@
+
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11603) captureAudio on iOS 9.2+ can't record more than 2 seconds

2016-07-27 Thread Kerri Shotts (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396040#comment-15396040
 ] 

Kerri Shotts commented on CB-11603:
---

You're conflating an upload problem vs a recording problem. I'm assuming you 
can indeed record audio for longer than 2 seconds, just that the upload of that 
recording fails. If this is not the case, please let us know.

Assuming the problem is with uploading:

All you post is how you are reading the file contents into a variable. You 
don't share how you're sending that information to your server. Without that, 
it's going to be hard to help. Furthermore, base64 is increasing the recording 
size by 33%, which, for a long recording, could be straining device resources.

My suggestion would be to use the File Transfer plugin instead, because I'm 
guessing you're running into a memory limit somewhere. The FT plugin uses 
native code to perform the transfer, and shouldn't incur the hit of 
transferring large files over the native bridge. 

> captureAudio on iOS 9.2+ can't record more than 2 seconds
> -
>
> Key: CB-11603
> URL: https://issues.apache.org/jira/browse/CB-11603
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
> Environment: Cordova CLI: 6.1.1
> Gulp version:  CLI version 3.9.1
> Gulp local:
> Ionic Framework Version: 1.3.1-nightly-3792
> Ionic CLI Version: 1.7.16
> Ionic App Lib Version: 0.7.3
> ios-deploy version: 1.8.2
> ios-sim version: 5.0.8
> OS: Mac OS X El Capitan
> Node Version: v5.0.0
> Xcode version: Xcode 7.3.1 Build version 7D1014
>Reporter: James Manlapid
>Priority: Critical
>
> I'm using 
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media-capture/
>  and on iOS v. 9.2+ it won't allow me to upload recordings greater than 2 
> seconds. The same code works for Android and can capture audio for more than 
> 2 seconds. I'm using a file reader to get the base64 string of the whole 
> recording and uploading it to a server.
>  var audioFile = audioFiles[0],
> fileReader = new FileReader(),
> file;
> fileReader.onload = function (readerEvt) {
> var base64 = readerEvt.target.result;
> saveRecording(base64);
> };
> file = new window.File(audioFile.name, audioFile.localURL, 
>audioFile.type, 
> audioFile.lastModifiedDate, audioFile.size);
> fileReader.readAsDataURL(file);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396046#comment-15396046
 ] 

ASF GitHub Bot commented on CB-9825:


Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/467#discussion_r72487562
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -33,326 +33,453 @@ var helpers = require('./helpers'),
 var projectRoot = 'C:\\Projects\\cordova-projects\\move-tracker';
 var pluginsDir = path.join(__dirname, 'fixtures', 'plugins');
 
-describe('platform end-to-end', function () {
 
-var tmpDir = helpers.tmpDir('platform_test');
-var project = path.join(tmpDir, 'project');
+// describe('platform end-to-end', function () {
+
+// var tmpDir = helpers.tmpDir('platform_test');
+// var project = path.join(tmpDir, 'project');
+
+// var results;
+
+// beforeEach(function() {
+// shell.rm('-rf', tmpDir);
+
+// // cp then mv because we need to copy everything, but that 
means it'll copy the whole directory.
+// // Using /* doesn't work because of hidden files.
+// shell.cp('-R', path.join(__dirname, 'fixtures', 'base'), 
tmpDir);
+// shell.mv(path.join(tmpDir, 'base'), project);
+// process.chdir(project);
+
+// // Now we load the config.json in the newly created project and 
edit the target platform's lib entry
+// // to point at the fixture version. This is necessary so that 
cordova.prepare can find cordova.js there.
+// var c = config.read(project);
+// c.lib[helpers.testPlatform].url = path.join(__dirname, 
'fixtures', 'platforms', helpers.testPlatform + '-lib');
+// config.write(project, c);
+
+// // The config.json in the fixture project points at fake 
"local" paths.
+// // Since it's not a URL, the lazy-loader will just return the 
junk path.
+// spyOn(superspawn, 'spawn').andCallFake(function(cmd, args) {
+// if (cmd.match(/create\b/)) {
+// // This is a call to the bin/create script, so do the 
copy ourselves.
+// shell.cp('-R', path.join(__dirname, 'fixtures', 
'platforms', 'android'), path.join(project, 'platforms'));
+// } else if(cmd.match(/version\b/)) {
+// return Q('3.3.0');
+// } else if(cmd.match(/update\b/)) {
+// fs.writeFileSync(path.join(project, 'platforms', 
helpers.testPlatform, 'updated'), 'I was updated!', 'utf-8');
+// }
+// return Q();
+// });
+
+// events.on('results', function(res) { results = res; });
+// });
+
+// afterEach(function() {
+// process.chdir(path.join(__dirname, '..'));  // Needed to rm the 
dir on Windows.
+// shell.rm('-rf', tmpDir);
+// });
+
+// // Factoring out some repeated checks.
+// function emptyPlatformList() {
+// return cordova.raw.platform('list').then(function() {
+// var installed = results.match(/Installed platforms:\n  
(.*)/);
+// expect(installed).toBeDefined();
+// expect(installed[1].indexOf(helpers.testPlatform)).toBe(-1);
+// });
+// }
+// function fullPlatformList() {
+// return cordova.raw.platform('list').then(function() {
+// var installed = results.match(/Installed platforms:\n  
(.*)/);
+// expect(installed).toBeDefined();
+// 
expect(installed[1].indexOf(helpers.testPlatform)).toBeGreaterThan(-1);
+// });
+// }
+
+// // The flows we want to test are add, rm, list, and upgrade.
+// // They should run the appropriate hooks.
+// // They should fail when not inside a Cordova project.
+// // These tests deliberately have no beforeEach and afterEach that 
are cleaning things up.
+// it('should successfully run', function(done) {
+
+// // Check there are no platforms yet.
+// emptyPlatformList().then(function() {
+// // Add the testing platform.
+// return cordova.raw.platform('add', [helpers.testPlatform]);
+// }).then(function() {
+// // Check the platform add was successful.
+// expect(path.join(project, 'platforms', 
helpers.testPlatform)).toExist();
+// expect(path.join(project, 'platforms', 
helpers.testPlatform, 'cordova')).toExist();
+// }).then(fullPlatformList) // Check for it in platform ls.
+// .then(function() {
+// // Try to update the platform.
+//

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396022#comment-15396022
 ] 

ASF GitHub Bot commented on CB-11621:
-

Github user TimBarham commented on the issue:

https://github.com/apache/cordova-docs/pull/623
  
Couple of comments. Other than that looks good to me.


> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396020#comment-15396020
 ] 

ASF GitHub Bot commented on CB-11621:
-

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/623#discussion_r72483583
  
--- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md ---
@@ -0,0 +1,33 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
+url: https://github.com/vladimir-kotikov
+title:  "Apache Cordova Windows 4.4.2"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that `Cordova Windows 4.4.2` has been released!
+
+This release fixes some issues we've missed in 4.4.1. In particular, we've 
completely fixed all build issues with
+new VS build tools. For the rest of changes see release notes below.
+
+Cordova CLI 6.3.0 will automatically start using this version of 
**Cordova-Windows** when creating new projects.
--- End diff --

I think this should be "cordova-windows" (no uppercase).


> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396019#comment-15396019
 ] 

ASF GitHub Bot commented on CB-11621:
-

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/623#discussion_r72483527
  
--- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md ---
@@ -0,0 +1,33 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
+url: https://github.com/vladimir-kotikov
+title:  "Apache Cordova Windows 4.4.2"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that `Cordova Windows 4.4.2` has been released!
+
+This release fixes some issues we've missed in 4.4.1. In particular, we've 
completely fixed all build issues with
+new VS build tools. For the rest of changes see release notes below.
--- End diff --

I'm wondering how best to express this. Maybe something like 'In 
particular, we have fixed build issues experienced with the new install 
experience in Visual Studio "15" previews'. Do you have any thoughts @mbraude?


> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10532) jQuery.load() - Origin null is not allowed by Access-Control-Allow-Origin.

2016-07-27 Thread Amir (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395964#comment-15395964
 ] 

Amir commented on CB-10532:
---

These are well known issues here are some links to get used to it.
http://downloadgooglechromeall.blogspot.com/2016/07/chrome-error-origin-null-is-not-allowed.html
http://forums.asp.net/t/2072044.aspx?Access+Control+Allow+Origin+issue+in+chrome+and+firefox
http://community.dreamfactory.com/t/no-access-control-allow-origin-header-is-present/1246
http://stackoverflow.com/questions/3595515/xmlhttprequest-error-origin-null-is-not-allowed-by-access-control-allow-origin

> jQuery.load() - Origin null is not allowed by Access-Control-Allow-Origin.
> --
>
> Key: CB-10532
> URL: https://issues.apache.org/jira/browse/CB-10532
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 4.0.0, 6.0.0
> Environment: iOS
>Reporter: Adrian Florin Florescu
>Assignee: jcesarmobile
> Attachments: screenshot-1.png
>
>
> Trying to load a HTML file with jQuery from the root of the www folder gives 
> me an error, even if allow origin is set to * in the config.xml
> XMLHttpRequest cannot load 
> file:///var/mobile/Containers/Bundle/Application/ECC92D3C-4C93-477E-A1FB-8450F6B3A913/Vivre.app/www/images/icons/dest/index.html?_=1454600799619.
>  Origin null is not allowed by Access-Control-Allow-Origin.
> `$( "#js-svg-inline" ).load( "./images/icons/dest/index.html #svg", 
> function(){});`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Ilya Kirichek (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395857#comment-15395857
 ] 

Ilya Kirichek commented on CB-11612:


Latest plugin version, any android.

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Assignee: Sergey Shakhnazarov
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> {noformat}
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> {noformat}
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395747#comment-15395747
 ] 

ASF GitHub Bot commented on CB-11621:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-docs/pull/623
  
@sgrebnov, @TimBarham, could you please take a look


> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11621) Cordova-windows platform release July 25, 2016

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395745#comment-15395745
 ] 

ASF GitHub Bot commented on CB-11621:
-

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/623

CB-11621 Add windows@4.4.2 release blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-docs CB-11621

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #623


commit 3c8f2a127a03f61915e7d696723c1976d354
Author: Vladimir Kotikov 
Date:   2016-07-27T14:17:49Z

CB-11621 Add windows@4.4.2 release blog post




> Cordova-windows platform release July 25, 2016
> --
>
> Key: CB-11621
> URL: https://issues.apache.org/jira/browse/CB-11621
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: release, windows
> Fix For: 4.4.2
>
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11477) Add a note about nightly builds to Cordova website

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395717#comment-15395717
 ] 

ASF GitHub Bot commented on CB-11477:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-docs/pull/613
  
@stevengill, ping


> Add a note about nightly builds to Cordova website
> --
>
> Key: CB-11477
> URL: https://issues.apache.org/jira/browse/CB-11477
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Website
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: docs, nightly
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11368) resolveLocalFileSystemURL cannot handle url returned by contacts plugin

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11368:
--
Assignee: (was: Vladimir Kotikov)

> resolveLocalFileSystemURL cannot handle url returned by contacts plugin
> ---
>
> Key: CB-11368
> URL: https://issues.apache.org/jira/browse/CB-11368
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File
>Reporter: zhuisui
>  Labels: triaged
>
> navigator.contacts.pickContact returns photo url like 
> {{content://com.android.contacts/contacts/1/photo}}, which cannot be resolved 
> by resolveLocalFileSystemURL with {{FileError code: 1000}}. I inspect code in 
> the {{ContentFileSystem.java}}, and find the method {{resourceSizeForCursor}} 
> cannot return correct value. The problem is, that cursor doesn't have a 
> column named _size. I have given permission of File and Contacts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11367) cordova-plugin-camera retuns NULL file url on success when mediaType : AllMedia (2) (only on Android)

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11367.
-
Resolution: Duplicate

Closing as duplicate

> cordova-plugin-camera retuns NULL file url on success when mediaType : 
> AllMedia (2) (only on Android)
> -
>
> Key: CB-11367
> URL: https://issues.apache.org/jira/browse/CB-11367
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 2.1.0
> Environment: Cordova CLI, Android
>Reporter: Samir
>Assignee: Vladimir Kotikov
>  Labels: Android, reproduced, triaged, wfc
>
> Hi 
> Not sure if I am doing anything wrong or it's a bug.
> I am using Phonegap / cordova CLI
> Plugin: cordova-plugin-camera (latest version 2.2.0)
> ---
> This is my code sample:
> 
> var pictureSource;
> var destinationType;
> document.addEventListener("deviceready",onDeviceReady,false);
> function onDeviceReady() {
>   pictureSource=navigator.camera.PictureSourceType;
>   destinationType=navigator.camera.DestinationType;
> }
> function getMedia() {
>   var gallery_options = { quality: 50, destinationType: 
> destinationType.FILE_URI, sourceType: PictureSourceType.PHOTOLIBRARY, 
> mediaType: 2 };
>   navigator.camera.getPicture(onSuccess, onFail, gallery_options);
> }
> function onSuccess(url) {
>   alert(url); // getting NULL here
> }
> =
> As you can see, I am getting photos and videos from Gallery and destination 
> type is file Url.
> MediaType is set to 2 which means both photos and videos.
> If mediaType is 0 > then no problem. It returns image url
> If it is 1 (video only) returns NULL
> if it is 2, returns NULL on both images and videos.
> It seems to be working only when mediaType is 0 !! (but I need both photos 
> and videos!)
> This only happens on Android !!
> on iOS device, no issue.
> I have tried on Developers app, emulator, real device...same result!
> Any help would be much appreciated!
> S



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11613) in WindowsStorePublisherName leads to "Invalid attribute predicate"

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov reassigned CB-11613:
-

Assignee: Vladimir Kotikov

>  in WindowsStorePublisherName leads to "Invalid attribute predicate"
> ---
>
> Key: CB-11613
> URL: https://issues.apache.org/jira/browse/CB-11613
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
> Environment: $ cordova platform ls
> Installed platforms:
>   android 5.2.1
>   ios 4.2.0
>   windows 4.4.1
> $ cordova plugin ls
> cordova-ios-requires-fullscreen 0.0.2 "IOS UIRequiresFullScreen"
> cordova-plugin-device 1.1.1 "Device"
> cordova-plugin-geolocation 2.1.0 "Geolocation"
> cordova-plugin-inappbrowser 1.4.0 "InAppBrowser"
> cordova-plugin-statusbar 2.1.0 "StatusBar"
> cordova-plugin-whitelist 1.2.1 "Whitelist"
> phonegap-plugin-push 1.5.3 "PushPlugin"
> $ cordova --version
> 6.3.0
> Microsoft Visual Studio Community 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Community
> Visual Basic 2015   00322-2-0-AA568
> Microsoft Visual Basic 2015
> Visual C# 2015   00322-2-0-AA568
> Microsoft Visual C# 2015
> Visual C++ 2015   00322-2-0-AA568
> Microsoft Visual C++ 2015
> Windows Phone SDK 8.0 - ENU   00322-2-0-AA568
> Windows Phone SDK 8.0 - ENU
> Application Insights Tools for Visual Studio Package   5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8)   14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
> For additional information, visit 
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools   1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure 
> Tools.
> JavaScript Language Service   2.0
> JavaScript Language Service
> JavaScript Project System   2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools   1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager   3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet, 
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer   1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the 
> PreEmptive Analytics product.
> SQL Server Data Tools   14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript   1.8.31.0
> TypeScript tools for Visual Studio
> Visual Studio Tools for Apache Cordova   Update 10
> Visual Studio Tools for Apache Cordova
> Visual Studio Tools for Universal Windows Apps   14.0.25219.00
> The Visual Studio Tools for Universal Windows apps allow you to build a 
> single universal app experience that can reach every device running Windows 
> 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 
> Software Development Kit.
>Reporter: Andrey Sharapov
>Assignee: Vladimir Kotikov
>Priority: Blocker
>  Labels: reproduced, triaged, windows, xml
>
> The next code:
> {{}}
> automatically added to "config.xml" by Visual Studio (value is taken from 
> microsoft developer account) before it build the package for Windows Store.
> I have no way to change my Publisher display name in Microsoft Developer 
> Account, also i can't change this code locally, and i can't build the package 
> now, because i get an error: Invalid attribute predicate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11623) --link-to no longer seems to be working

2016-07-27 Thread Graham Harper (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395594#comment-15395594
 ] 

Graham Harper edited comment on CB-11623 at 7/27/16 12:50 PM:
--

Appreciate you guys looking at this - this was a major breaking feature change 
for us and looking at the discussion history it seems to have been rolled in 
with the inclusion of '--template' updates. Was the change documented anywhere 
in the release notes for this version and we've missed it, or was it a simple 
oversight?

Symlinking is a major boon for us and our development and deployment workflow; 
would be happy to see it reinstated if possible.


was (Author: harper84):
Appreciate you guys looking at this - this was a major breaking feature change 
for us and looking at the discussion history it seems to have been rolled in 
with the inclusion of '--template' updates. Was the change documented anywhere 
in the release notes for this version and we've missed it, or was it a simple 
oversight?

Simlinking is a major boon for us and our development and deployment workflow; 
would be happy to see it reinstated if possible.

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>Assignee: Steve Gill
>  Labels: triaged
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11613) in WindowsStorePublisherName leads to "Invalid attribute predicate"

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11613:
--
Description: 
The next code:
{{}}
automatically added to "config.xml" by Visual Studio (value is taken from 
microsoft developer account) before it build the package for Windows Store.

I have no way to change my Publisher display name in Microsoft Developer 
Account, also i can't change this code locally, and i can't build the package 
now, because i get an error: Invalid attribute predicate.

  was:
The next code:

automatically added to "config.xml" by Visual Studio (value is taken from 
microsoft developer account) before it build the package for Windows Store.

I have no way to change my Publisher display name in Microsoft Developer 
Account, also i can't change this code locally, and i can't build the package 
now, because i get an error: Invalid attribute predicate.


>  in WindowsStorePublisherName leads to "Invalid attribute predicate"
> ---
>
> Key: CB-11613
> URL: https://issues.apache.org/jira/browse/CB-11613
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
> Environment: $ cordova platform ls
> Installed platforms:
>   android 5.2.1
>   ios 4.2.0
>   windows 4.4.1
> $ cordova plugin ls
> cordova-ios-requires-fullscreen 0.0.2 "IOS UIRequiresFullScreen"
> cordova-plugin-device 1.1.1 "Device"
> cordova-plugin-geolocation 2.1.0 "Geolocation"
> cordova-plugin-inappbrowser 1.4.0 "InAppBrowser"
> cordova-plugin-statusbar 2.1.0 "StatusBar"
> cordova-plugin-whitelist 1.2.1 "Whitelist"
> phonegap-plugin-push 1.5.3 "PushPlugin"
> $ cordova --version
> 6.3.0
> Microsoft Visual Studio Community 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Community
> Visual Basic 2015   00322-2-0-AA568
> Microsoft Visual Basic 2015
> Visual C# 2015   00322-2-0-AA568
> Microsoft Visual C# 2015
> Visual C++ 2015   00322-2-0-AA568
> Microsoft Visual C++ 2015
> Windows Phone SDK 8.0 - ENU   00322-2-0-AA568
> Windows Phone SDK 8.0 - ENU
> Application Insights Tools for Visual Studio Package   5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8)   14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
> For additional information, visit 
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools   1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure 
> Tools.
> JavaScript Language Service   2.0
> JavaScript Language Service
> JavaScript Project System   2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools   1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager   3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet, 
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer   1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the 
> PreEmptive Analytics product.
> SQL Server Data Tools   14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript   1.8.31.0
> TypeScript tools for Visual Studio
> Visual Studio Tools for Apache Cordova   Update 10
> Visual Studio Tools for Apache Cordova
> Visual Studio Tools for Universal Windows Apps   14.0.25219.00
> The Visual Studio Tools for Universal Windows apps allow you to build a 
> single universal app experience that can reach every device running Windows 
> 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 
> Software Development Kit.
>Reporter: Andrey Sharapov
>Priority: Blocker
>  Labels: reproduced, triaged, windows, xml
>
> The next code:
> {{}}
> automatically added to "config.xml" by Visual Studio (value is taken from 
> microsoft developer account) before it build the package for Windows Store.
> I have no way to change my Publisher display name in Microsoft Developer 
> Account, also i can't change this code locally, and i can't build the package 
> now, because i get an error: Invalid attribute predicate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11613) in WindowsStorePublisherName leads to "Invalid attribute predicate"

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11613:
--
Labels: reproduced triaged windows xml  (was: repro windows xml)

>  in WindowsStorePublisherName leads to "Invalid attribute predicate"
> ---
>
> Key: CB-11613
> URL: https://issues.apache.org/jira/browse/CB-11613
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
> Environment: $ cordova platform ls
> Installed platforms:
>   android 5.2.1
>   ios 4.2.0
>   windows 4.4.1
> $ cordova plugin ls
> cordova-ios-requires-fullscreen 0.0.2 "IOS UIRequiresFullScreen"
> cordova-plugin-device 1.1.1 "Device"
> cordova-plugin-geolocation 2.1.0 "Geolocation"
> cordova-plugin-inappbrowser 1.4.0 "InAppBrowser"
> cordova-plugin-statusbar 2.1.0 "StatusBar"
> cordova-plugin-whitelist 1.2.1 "Whitelist"
> phonegap-plugin-push 1.5.3 "PushPlugin"
> $ cordova --version
> 6.3.0
> Microsoft Visual Studio Community 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Community
> Visual Basic 2015   00322-2-0-AA568
> Microsoft Visual Basic 2015
> Visual C# 2015   00322-2-0-AA568
> Microsoft Visual C# 2015
> Visual C++ 2015   00322-2-0-AA568
> Microsoft Visual C++ 2015
> Windows Phone SDK 8.0 - ENU   00322-2-0-AA568
> Windows Phone SDK 8.0 - ENU
> Application Insights Tools for Visual Studio Package   5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8)   14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
> For additional information, visit 
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools   1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure 
> Tools.
> JavaScript Language Service   2.0
> JavaScript Language Service
> JavaScript Project System   2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools   1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager   3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet, 
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer   1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the 
> PreEmptive Analytics product.
> SQL Server Data Tools   14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript   1.8.31.0
> TypeScript tools for Visual Studio
> Visual Studio Tools for Apache Cordova   Update 10
> Visual Studio Tools for Apache Cordova
> Visual Studio Tools for Universal Windows Apps   14.0.25219.00
> The Visual Studio Tools for Universal Windows apps allow you to build a 
> single universal app experience that can reach every device running Windows 
> 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 
> Software Development Kit.
>Reporter: Andrey Sharapov
>Priority: Blocker
>  Labels: reproduced, triaged, windows, xml
>
> The next code:
> 
> automatically added to "config.xml" by Visual Studio (value is taken from 
> microsoft developer account) before it build the package for Windows Store.
> I have no way to change my Publisher display name in Microsoft Developer 
> Account, also i can't change this code locally, and i can't build the package 
> now, because i get an error: Invalid attribute predicate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11613) in WindowsStorePublisherName leads to "Invalid attribute predicate"

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11613:
--
Affects Version/s: (was: 6.3.0)
   4.4.1

>  in WindowsStorePublisherName leads to "Invalid attribute predicate"
> ---
>
> Key: CB-11613
> URL: https://issues.apache.org/jira/browse/CB-11613
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
> Environment: $ cordova platform ls
> Installed platforms:
>   android 5.2.1
>   ios 4.2.0
>   windows 4.4.1
> $ cordova plugin ls
> cordova-ios-requires-fullscreen 0.0.2 "IOS UIRequiresFullScreen"
> cordova-plugin-device 1.1.1 "Device"
> cordova-plugin-geolocation 2.1.0 "Geolocation"
> cordova-plugin-inappbrowser 1.4.0 "InAppBrowser"
> cordova-plugin-statusbar 2.1.0 "StatusBar"
> cordova-plugin-whitelist 1.2.1 "Whitelist"
> phonegap-plugin-push 1.5.3 "PushPlugin"
> $ cordova --version
> 6.3.0
> Microsoft Visual Studio Community 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Community
> Visual Basic 2015   00322-2-0-AA568
> Microsoft Visual Basic 2015
> Visual C# 2015   00322-2-0-AA568
> Microsoft Visual C# 2015
> Visual C++ 2015   00322-2-0-AA568
> Microsoft Visual C++ 2015
> Windows Phone SDK 8.0 - ENU   00322-2-0-AA568
> Windows Phone SDK 8.0 - ENU
> Application Insights Tools for Visual Studio Package   5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8)   14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2   4.1.41102.0
> For additional information, visit 
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013   5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools   1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure 
> Tools.
> JavaScript Language Service   2.0
> JavaScript Language Service
> JavaScript Project System   2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools   1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager   3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet, 
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer   1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the 
> PreEmptive Analytics product.
> SQL Server Data Tools   14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript   1.8.31.0
> TypeScript tools for Visual Studio
> Visual Studio Tools for Apache Cordova   Update 10
> Visual Studio Tools for Apache Cordova
> Visual Studio Tools for Universal Windows Apps   14.0.25219.00
> The Visual Studio Tools for Universal Windows apps allow you to build a 
> single universal app experience that can reach every device running Windows 
> 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 
> Software Development Kit.
>Reporter: Andrey Sharapov
>Priority: Blocker
>  Labels: repro, windows, xml
>
> The next code:
> 
> automatically added to "config.xml" by Visual Studio (value is taken from 
> microsoft developer account) before it build the package for Windows Store.
> I have no way to change my Publisher display name in Microsoft Developer 
> Account, also i can't change this code locally, and i can't build the package 
> now, because i get an error: Invalid attribute predicate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11612:
--
Assignee: Sergey Shakhnazarov  (was: Vladimir Kotikov)

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Assignee: Sergey Shakhnazarov
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> {noformat}
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> {noformat}
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov reassigned CB-11612:
-

Assignee: Vladimir Kotikov

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Assignee: Vladimir Kotikov
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> {noformat}
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> {noformat}
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395582#comment-15395582
 ] 

Vladimir Kotikov commented on CB-11612:
---

[~daserge], could you please take a look at this

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> {noformat}
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> {noformat}
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11612:
--
Description: 
Hi there,
I use splashscreen with my cordova updater plugin and update can take a several 
time. 

Splashscreen auto hided on screen lock, in plugin code we have:
{noformat}
public void onPause(boolean multitasking) {
if (HAS_BUILT_IN_SPLASH_SCREEN) {
return;
}
// hide the splash screen to avoid leaking a window
this.removeSplashScreen(true);
}
{noformat}
What kind of leaking?
If I comment those line, all seems to work fine.

Thanks,
Ilya K.



  was:
Hi there,
I use splashscreen with my cordova updater plugin and update can take a several 
time. 

Splashscreen auto hided on screen lock, in plugin code we have:

public void onPause(boolean multitasking) {
if (HAS_BUILT_IN_SPLASH_SCREEN) {
return;
}
// hide the splash screen to avoid leaking a window
this.removeSplashScreen(true);
}

What kind of leaking?
If I comment those line, all seems to work fine.

Thanks,
Ilya K.




> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> {noformat}
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> {noformat}
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395580#comment-15395580
 ] 

Vladimir Kotikov edited comment on CB-11612 at 7/27/16 12:31 PM:
-

[~Mnill], could you please add some details about plugin and platform version.


was (Author: vladimir.kotikov):
[~Mnill], could you please add some details about plugin and platform version?

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395580#comment-15395580
 ] 

Vladimir Kotikov commented on CB-11612:
---

[~Mnill], could you please add some details about plugin and platform version?

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11612) Splashscreen android - Auto hide on OnPause.

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11612:
--
Labels: triaged wfc  (was: )

> Splashscreen android - Auto hide on OnPause.
> 
>
> Key: CB-11612
> URL: https://issues.apache.org/jira/browse/CB-11612
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen
>Reporter: Ilya Kirichek
>Priority: Trivial
>  Labels: triaged, wfc
>
> Hi there,
> I use splashscreen with my cordova updater plugin and update can take a 
> several time. 
> Splashscreen auto hided on screen lock, in plugin code we have:
> public void onPause(boolean multitasking) {
> if (HAS_BUILT_IN_SPLASH_SCREEN) {
> return;
> }
> // hide the splash screen to avoid leaking a window
> this.removeSplashScreen(true);
> }
> What kind of leaking?
> If I comment those line, all seems to work fine.
> Thanks,
> Ilya K.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11619) prepare android keeps getting Hello Cordova name and description

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11619:
--
Labels: android cannot-reproduce triaged wfc  (was: android triaged)

> prepare android keeps getting Hello Cordova name and description
> 
>
> Key: CB-11619
> URL: https://issues.apache.org/jira/browse/CB-11619
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
> Environment: Windows Android studio 2.1.2
>Reporter: Bart Besseling
>  Labels: android, cannot-reproduce, triaged, wfc
>
> In a cordova project where the android platform is not in version control (as 
> the cordova create command instructions recommend) each new build has "Hello 
> Cordova" name and description in android config.xml and strings.xml files. 
> This requires manual fixing and complicates automated builds. Are the 
> instructions incorrect or is prepare incorrect?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11619) prepare android keeps getting Hello Cordova name and description

2016-07-27 Thread Vladimir Kotikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395547#comment-15395547
 ] 

Vladimir Kotikov commented on CB-11619:
---

This doesn't repro form me neither wirn 5.1.1 nor with latest 5.2.1 
cordova-android version. Also, [~bbesseling], how are you building the project? 
Are you using Android studio for that?
Can you also provide exact repro steps?

> prepare android keeps getting Hello Cordova name and description
> 
>
> Key: CB-11619
> URL: https://issues.apache.org/jira/browse/CB-11619
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
> Environment: Windows Android studio 2.1.2
>Reporter: Bart Besseling
>  Labels: android, cannot-reproduce, triaged, wfc
>
> In a cordova project where the android platform is not in version control (as 
> the cordova create command instructions recommend) each new build has "Hello 
> Cordova" name and description in android config.xml and strings.xml files. 
> This requires manual fixing and complicates automated builds. Are the 
> instructions incorrect or is prepare incorrect?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11619) prepare android keeps getting Hello Cordova name and description

2016-07-27 Thread Vladimir Kotikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395547#comment-15395547
 ] 

Vladimir Kotikov edited comment on CB-11619 at 7/27/16 12:17 PM:
-

This doesn't repro form me neither with 5.1.1 nor with latest 5.2.1 
cordova-android version. Also, [~bbesseling], how are you building the project? 
Are you using Android studio for that?
Can you also provide exact repro steps?


was (Author: vladimir.kotikov):
This doesn't repro form me neither wirn 5.1.1 nor with latest 5.2.1 
cordova-android version. Also, [~bbesseling], how are you building the project? 
Are you using Android studio for that?
Can you also provide exact repro steps?

> prepare android keeps getting Hello Cordova name and description
> 
>
> Key: CB-11619
> URL: https://issues.apache.org/jira/browse/CB-11619
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
> Environment: Windows Android studio 2.1.2
>Reporter: Bart Besseling
>  Labels: android, cannot-reproduce, triaged, wfc
>
> In a cordova project where the android platform is not in version control (as 
> the cordova create command instructions recommend) each new build has "Hello 
> Cordova" name and description in android config.xml and strings.xml files. 
> This requires manual fixing and complicates automated builds. Are the 
> instructions incorrect or is prepare incorrect?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11619) prepare android keeps getting Hello Cordova name and description

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11619:
--
Labels: android triaged  (was: )

> prepare android keeps getting Hello Cordova name and description
> 
>
> Key: CB-11619
> URL: https://issues.apache.org/jira/browse/CB-11619
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.1.1
> Environment: Windows Android studio 2.1.2
>Reporter: Bart Besseling
>  Labels: android, triaged
>
> In a cordova project where the android platform is not in version control (as 
> the cordova create command instructions recommend) each new build has "Hello 
> Cordova" name and description in android config.xml and strings.xml files. 
> This requires manual fixing and complicates automated builds. Are the 
> instructions incorrect or is prepare incorrect?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11623) --link-to no longer seems to be working

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11623:
--
Labels: triaged  (was: )

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>Assignee: Steve Gill
>  Labels: triaged
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11623) --link-to no longer seems to be working

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11623:
--
Component/s: CordovaLib

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11625) Camera crashes due to FileUriExposedException issues

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11625:
--
Labels: android nougat triaged  (was: )

> Camera crashes due to FileUriExposedException issues
> 
>
> Key: CB-11625
> URL: https://issues.apache.org/jira/browse/CB-11625
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: Joe Bowser
>  Labels: android, nougat, triaged
>
> There is a new URI that checks if the File URI is exposed.  It seems the 
> Android team wants to make our lives awful by using their content providers 
> that don't work with the web.  This is related to CB-11592



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11631) Android camera tests fails on Saucelabs with 'Selection cancelled' error

2016-07-27 Thread Vladimir Kotikov (JIRA)

Vladimir Kotikov created CB-11631:
-

 Summary: Android camera tests fails on Saucelabs with 'Selection 
cancelled' error
 Key: CB-11631
 URL: https://issues.apache.org/jira/browse/CB-11631
 Project: Apache Cordova
  Issue Type: Test
  Components: Plugin Camera
Affects Versions: Master
Reporter: Vladimir Kotikov
Assignee: Alexander Sorokin


Error Message
Failed: ERROR: Selection cancelled.
Stacktrace
{noformat}
Error: Failed: ERROR: Selection cancelled.
at stack 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1577:17)
at buildExpectationResult 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1547:14)
at Spec.Env.expectationResultFactory 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:638:18)
at Spec.addExpectationResult 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:330:34)
at Env.fail 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:987:25)
at jasmineInterface.fail 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3423:23)
at 
/private/var/folders/nd/5vd2nqsn3tlc6kljds0c9520gp/T/tmp-20533OwboGjVf9NpY/plugins/cordova-plugin-camera/appium-tests/android/android.spec.js:194:25
at _fulfilled 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/q/q.js:834:54)
at self.promiseDispatch.done 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/q/q.js:863:30)
at Promise.promise.promiseDispatch 
(/Users/jenkins/jenkins/workspace/cordova-periodic-build/cordova-paramedic/node_modules/q/q.js:796:13)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11630) implement property 'quality' in captureImage() to set JPEG compression

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395440#comment-15395440
 ] 

ASF GitHub Bot commented on CB-11630:
-

GitHub user ryanwilliams83 opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/66

CB-11630: (iOS) Implement property 'quality' in captureImage()

### Platforms affected
iOS

### What does this PR do?
Allows developers to set JPEG compression quality

### What testing has been done on this change?
captureImage()
  'quality' omitted / 0 / 0.0 / 0.1 / 0.3 / 0.5 / 0.96 / 0.99 / 1 / 100

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buzzcard/cordova-plugin-media-capture 
jpegquality

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 299509b7fd1cab4c371228d70f27ca3ce6c3572d
Author: Ryan Williams 
Date:   2016-07-27T10:38:51Z

CB-11630: (iOS) Implement property 'quality' in captureImage() to set JPEG 
compression quality




> implement property 'quality' in captureImage() to set JPEG compression
> --
>
> Key: CB-11630
> URL: https://issues.apache.org/jira/browse/CB-11630
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media Capture
>Reporter: Ryan Williams
>Priority: Minor
>
> Allow developers to specify the level of JPEG compression



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11616) File Transfer spec.29 "(compatibility) should be able to upload a file using local paths" Fails on iOS

2016-07-27 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11616.
-
Resolution: Cannot Reproduce

> File Transfer spec.29 "(compatibility) should be able to upload a file using 
> local paths" Fails on iOS
> --
>
> Key: CB-11616
> URL: https://issues.apache.org/jira/browse/CB-11616
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File Transfer
>Reporter: Vladimir Kotikov
>  Labels: android, flaky, found-by-ci, triaged
>
> Test fails on timeout. The test is possibly flakey 
> {noformat}
> 1) cordova-plugin-file-transfer-tests.tests >> FileTransfer methods upload 
> filetransfer.spec.29 (compatibility) should be able to upload a file using 
> local paths
>   - Error: Timeout - Async callback was not invoked within timeout specified 
> by jasmine.DEFAULT_TIMEOUT_INTERVAL.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11447) Wrong file encoding when taking a picture with the following parameters sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, allowEdit: true, correctOr

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395436#comment-15395436
 ] 

ASF GitHub Bot commented on CB-11447:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/223
  
Looks like previous test run failure was caused by some Appium/Saucelabs 
problems. All tests are passing now.


> Wrong file encoding when taking a picture with the following parameters 
> sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, 
> allowEdit: true, correctOrientation: false
> --
>
> Key: CB-11447
> URL: https://issues.apache.org/jira/browse/CB-11447
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: android, found-by-ci, iOS, triaged
>
> This is found by Appium tests:
> https://ci.apache.org/builders/cordova-android-osx/builds/2832/steps/running-appium-tests/logs/stdio
> {noformat}
> 1) 
> Camera tests Android. Specs. camera.ui.spec.11.30 Combining options. 
> sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, 
> allowEdit: true, correctOrientation: false
>   Message:
> Failed: ERROR: File type mismatch. Expected PNG, got JPEG
>   Stack:
> Error: Failed: ERROR: File type mismatch. Expected PNG, got JPEG
> at stack 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1577:17)
> at buildExpectationResult 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1547:14)
> at Spec.Env.expectationResultFactory 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:638:18)
> at Spec.addExpectationResult 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:330:34)
> at Env.fail 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:987:25)
> at jasmineInterface.fail 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3423:23)
> at 
> /Users/buildbot/slaves/apache/cordova-android-osx/mobilespec/plugins/cordova-plugin-camera/appium-tests/android/android.spec.js:190:25
> at _fulfilled 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/wd/node_modules/q/q.js:834:54)
> at self.promiseDispatch.done 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/wd/node_modules/q/q.js:863:30)
> at Promise.promise.promiseDispatch 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/wd/node_modules/q/q.js:796:13)
> 2) 
> Camera tests Android. Specs. camera.ui.spec.11.32 Combining options. 
> sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, 
> allowEdit: false, correctOrientation: false
>   Message:
> Failed: ERROR: File type mismatch. Expected PNG, got JPEG
>   Stack:
> Error: Failed: ERROR: File type mismatch. Expected PNG, got JPEG
> at stack 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1577:17)
> at buildExpectationResult 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1547:14)
> at Spec.Env.expectationResultFactory 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:638:18)
> at Spec.addExpectationResult 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:330:34)
> at Env.fail 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:987:25)
> at jasmineInterface.fail 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3423:23)
> at 
>

[jira] [Commented] (CB-11447) Wrong file encoding when taking a picture with the following parameters sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, allowEdit: true, correctOr

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395411#comment-15395411
 ] 

ASF GitHub Bot commented on CB-11447:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/223
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/223/commits/fed798e6c7f56e23bff994ab2c11d316c8257a78)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/46//PLATFORM=android/artifact/)
 |
 



> Wrong file encoding when taking a picture with the following parameters 
> sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, 
> allowEdit: true, correctOrientation: false
> --
>
> Key: CB-11447
> URL: https://issues.apache.org/jira/browse/CB-11447
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: Master
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: android, found-by-ci, iOS, triaged
>
> This is found by Appium tests:
> https://ci.apache.org/builders/cordova-android-osx/builds/2832/steps/running-appium-tests/logs/stdio
> {noformat}
> 1) 
> Camera tests Android. Specs. camera.ui.spec.11.30 Combining options. 
> sourceType: PHOTOLIBRARY, destinationType: FILE_URI, encodingType: PNG, 
> allowEdit: true, correctOrientation: false
>   Message:
> Failed: ERROR: File type mismatch. Expected PNG, got JPEG
>   Stack:
> Error: Failed: ERROR: File type mismatch. Expected PNG, got JPEG
> at stack 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1577:17)
> at buildExpectationResult 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1547:14)
> at Spec.Env.expectationResultFactory 
> (/Users/buildbot/slaves/apache/cordova-android-osx/cordova-medic/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:638:18)
> at Spec.addExpectationResult 
>

[jira] [Created] (CB-11630) implement property 'quality' in captureImage() to set JPEG compression

2016-07-27 Thread Ryan Williams (JIRA)

Ryan Williams created CB-11630:
--

 Summary: implement property 'quality' in captureImage() to set 
JPEG compression
 Key: CB-11630
 URL: https://issues.apache.org/jira/browse/CB-11630
 Project: Apache Cordova
  Issue Type: Improvement
  Components: Plugin Media Capture
Reporter: Ryan Williams
Priority: Minor


Allow developers to specify the level of JPEG compression



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395405#comment-15395405
 ] 

ASF GitHub Bot commented on CB-11579:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/189
  
## [Current coverage][cc-pull] is 73.30% (diff: 100%)
> Merging [#189][cc-pull] into [master][cc-base-branch] will increase 
coverage by **0.25%**

```diff
@@ master   #189   diff @@
==
  Files14 14  
  Lines  1937   1937  
  Methods 360360  
  Messages  0  0  
  Branches390390  
==
+ Hits   1415   1420 +5   
+ Misses  522517 -5   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[7f379ff...6a60c60][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-windows/compare/7f379ff33494ed40ba2315178f31dc973d0f958d...6a60c6060b1a09f98260d48bc707dbecd0d2ad0d?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/189?src=pr


> Windows: "cordova clean windows" command fails due to undefined variable
> 
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
>  Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform 
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
>   at cleanImages 
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed 
> the *locations* parameter on line 484.  
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to 
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395388#comment-15395388
 ] 

ASF GitHub Bot commented on CB-11579:
-

GitHub user matrosovN opened a pull request:

https://github.com/apache/cordova-windows/pull/189

CB-11579 windows: fix bug with 'cordova clean windows' command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosovN/cordova-windows master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #189






> Windows: "cordova clean windows" command fails due to undefined variable
> 
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
>  Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform 
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
>   at cleanImages 
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed 
> the *locations* parameter on line 484.  
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to 
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10180) Add support for video capture quality on iOS

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395329#comment-15395329
 ] 

ASF GitHub Bot commented on CB-10180:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/65
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/65/commits/8ba8142ffdc591802cd42ffef675c3995537941c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/20//PLATFORM=android/artifact/)
 |
 



> Add support for video capture quality on iOS
> 
>
> Key: CB-10180
> URL: https://issues.apache.org/jira/browse/CB-10180
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media Capture
>Affects Versions: 1.1.0
> Environment: iOS
>Reporter: Nicolas Leclerc
>  Labels: iOS, triaged
>
> iOS does not support the new {{quality}} option.
> Adding it would be great.
> I submitted a PR some time ago but rebased it to v1.1.0.
> https://github.com/apache/cordova-plugin-media-capture/pull/48



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10180) Add support for video capture quality on iOS

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395313#comment-15395313
 ] 

ASF GitHub Bot commented on CB-10180:
-

GitHub user ryanwilliams83 opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/65

CB-10180: (iOS) implement the 'quality' property in captureVideo()

### Platforms affected
iOS

### What does this PR do?
implement quality property for video capture.

### What testing has been done on this change?
captureVideo()
  'quality' omitted / 1 / 0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buzzcard/cordova-plugin-media-capture quality

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit 8ba8142ffdc591802cd42ffef675c3995537941c
Author: Ryan Williams 
Date:   2016-07-27T08:59:14Z

CB-10180: (iOS) implement the 'quality' property in captureVideo()




> Add support for video capture quality on iOS
> 
>
> Key: CB-10180
> URL: https://issues.apache.org/jira/browse/CB-10180
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media Capture
>Affects Versions: 1.1.0
> Environment: iOS
>Reporter: Nicolas Leclerc
>  Labels: iOS, triaged
>
> iOS does not support the new {{quality}} option.
> Adding it would be great.
> I submitted a PR some time ago but rebased it to v1.1.0.
> https://github.com/apache/cordova-plugin-media-capture/pull/48



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11629) Optionally disable ViewController animations

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395236#comment-15395236
 ] 

ASF GitHub Bot commented on CB-11629:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/64
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/64/commits/ce90273868015238e8fcc79af55b07a517c85e56)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/19//PLATFORM=android/artifact/)
 |
 



> Optionally disable ViewController animations
> 
>
> Key: CB-11629
> URL: https://issues.apache.org/jira/browse/CB-11629
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media Capture
> Environment: iOS
>Reporter: Ryan Williams
>Priority: Minor
>
> Implement property to allow animations to be disabled when loading and 
> unloading native screens.
> Predominately iOS UIViewController animations as iOS does not support the 
> 'limit' property so some developers may call the plugin multiple times in a 
> loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11629) Optionally disable ViewController animations

2016-07-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395214#comment-15395214
 ] 

ASF GitHub Bot commented on CB-11629:
-

GitHub user ryanwilliams83 opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/64

CB-11629: (iOS) Implement 'animated' property and updated English docs

### Platforms affected
iOS

### What does this PR do?
Add property 'animated' to optionally disable native screen animations.
As iOS does not support the limit flag; capturing multiple images by calling
this plugin in a loop can be quite slow for end users.

### What testing has been done on this change?
captureImage()
  'animated' omitted / true / false

captureVideo()
  'animated' omitted / true / false

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buzzcard/cordova-plugin-media-capture animated

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit ce90273868015238e8fcc79af55b07a517c85e56
Author: Ryan Williams 
Date:   2016-07-27T07:59:55Z

CB-11629: (iOS) Implement 'animated' property and updated English docs




> Optionally disable ViewController animations
> 
>
> Key: CB-11629
> URL: https://issues.apache.org/jira/browse/CB-11629
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Media Capture
> Environment: iOS
>Reporter: Ryan Williams
>Priority: Minor
>
> Implement property to allow animations to be disabled when loading and 
> unloading native screens.
> Predominately iOS UIViewController animations as iOS does not support the 
> 'limit' property so some developers may call the plugin multiple times in a 
> loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11629) Optionally disable ViewController animations

2016-07-27 Thread Ryan Williams (JIRA)

Ryan Williams created CB-11629:
--

 Summary: Optionally disable ViewController animations
 Key: CB-11629
 URL: https://issues.apache.org/jira/browse/CB-11629
 Project: Apache Cordova
  Issue Type: Improvement
  Components: Plugin Media Capture
 Environment: iOS
Reporter: Ryan Williams
Priority: Minor


Implement property to allow animations to be disabled when loading and 
unloading native screens.

Predominately iOS UIViewController animations as iOS does not support the 
'limit' property so some developers may call the plugin multiple times in a 
loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

79 matches

Mail list logo