[jira] [Commented] (CB-11667) Memory leak in CDVContact for CoreFoundation ABRecordRef

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406943#comment-15406943
 ] 

ASF GitHub Bot commented on CB-11667:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/132
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/132/commits/226a7f1041fc3517f556d6cc5eb9068d49bc5fcf)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/artifact/)
 |
 



> Memory leak in CDVContact for CoreFoundation ABRecordRef
> 
>
> Key: CB-11667
> URL: https://issues.apache.org/jira/browse/CB-11667
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> See https://github.com/apache/cordova-plugin-contacts/pull/35
> Fix:
> 1. create a dealloc method
> 2. Add the CFRelease there



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406914#comment-15406914
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
I'm afraid this PR needs to be re-based with master. I had to pull in other 
pull requests that probably touched part of the code you were working on.


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11667) Memory leak in CDVContact for CoreFoundation ABRecordRef

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah reassigned CB-11667:
-

Assignee: Shazron Abdullah

> Memory leak in CDVContact for CoreFoundation ABRecordRef
> 
>
> Key: CB-11667
> URL: https://issues.apache.org/jira/browse/CB-11667
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> See https://github.com/apache/cordova-plugin-contacts/pull/35
> Fix:
> 1. create a dealloc method
> 2. Add the CFRelease there



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11667) Memory leak in CDVContact for CoreFoundation ABRecordRef

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406912#comment-15406912
 ] 

ASF GitHub Bot commented on CB-11667:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/132

CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef

Related to https://github.com/apache/cordova-plugin-contacts/pull/35

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-plugin-contacts CB-11667

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 226a7f1041fc3517f556d6cc5eb9068d49bc5fcf
Author: Shazron Abdullah 
Date:   2016-08-04T00:49:40Z

CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef




> Memory leak in CDVContact for CoreFoundation ABRecordRef
> 
>
> Key: CB-11667
> URL: https://issues.apache.org/jira/browse/CB-11667
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Shazron Abdullah
>
> See https://github.com/apache/cordova-plugin-contacts/pull/35
> Fix:
> 1. create a dealloc method
> 2. Add the CFRelease there



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11667) Memory leak in CDVContact for CoreFoundation ABRecordRef

[Shazron Abdullah (JIRA)]

Shazron Abdullah created CB-11667:
-

 Summary: Memory leak in CDVContact for CoreFoundation ABRecordRef
 Key: CB-11667
 URL: https://issues.apache.org/jira/browse/CB-11667
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
 Environment: iOS
Reporter: Shazron Abdullah


See https://github.com/apache/cordova-plugin-contacts/pull/35

Fix:
1. create a dealloc method
2. Add the CFRelease there





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11554) too "brutal" app reload when title is empty

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406884#comment-15406884
 ] 

Shazron Abdullah commented on CB-11554:
---

Note: write unit tests that test CB-9888 reload condition and an empty document 
title (no reload).

> too "brutal" app reload when title is empty
> ---
>
> Key: CB-11554
> URL: https://issues.apache.org/jira/browse/CB-11554
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 1.0.4-dev
>Reporter: Philippe Wang
>Assignee: Shazron Abdullah
>  Labels: iOS, ios, regression, triaged
>
> This patch 
> https://github.com/apache/cordova-plugin-wkwebview-engine/commit/815ed0741b9ae30b343d6429bd8ff2ad37ec5790
> introduces {if title is empty then reload the app}.
> It was really hard for me to find the reason why the app I'm working on kept 
> reloading on each resume, while I had an older build of my app not having 
> this bad feature. Shouldn't there be at least a warning message explaining 
> why the app reloads? It'd be even better to find some better criteria.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11074) WKWebView configuration is not considered

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406792#comment-15406792
 ] 

ASF GitHub Bot commented on CB-11074:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
  
I have failing unit tests that do objectively verify that as others have 
shown, yes, we can't update the configuration dynamically (I've tried all sorts 
of clever runtime tricks, to no avail).

 The WKWebViewConfiguration.preferences (WKPreferences) *can* however be 
updated dynamically. I will update 
https://issues.apache.org/jira/browse/CB-11496 with the unit tests to reflect 
this, as well as document this. After doing so, I will re-review this pull 
request with that in mind.




> WKWebView configuration is not considered
> -
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
> Environment: ios
>Reporter: Alexis Kofman
>Assignee: Shazron Abdullah
>Priority: Critical
>  Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a 
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after 
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406776#comment-15406776
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/232#discussion_r73437041
  
--- Diff: tests/CordovaLibTests/CDVWhitelistTests.m ---
@@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations
 XCTAssertEqual([CDVIntentAndNavigationFilter filterUrl:[NSURL 
URLWithString:@"https://google.com;] intentsWhitelist:intentsWhitelist 
navigationsWhitelist:navigationsWhitelist], 
CDVIntentAndNavigationFilterValueIntentAllowed);
 // Test http (not allowed in either)
 XCTAssertEqual([CDVIntentAndNavigationFilter filterUrl:[NSURL 
URLWithString:@"http://google.com;] intentsWhitelist:intentsWhitelist 
navigationsWhitelist:navigationsWhitelist], 
CDVIntentAndNavigationFilterValueNoneAllowed);
+
+
+NSURL* telUrl = [NSURL URLWithString:@"tel:555"];
+NSMutableURLRequest* telRequest = [NSMutableURLRequest 
requestWithURL:telUrl];
+telRequest.mainDocumentURL = telUrl;
+
+// mainDocumentURL and URL are the same in the NSURLRequest
+// Only UIWebViewNavigationTypeLinkClicked and 
UIWebViewNavigationTypeOther should return YES
+XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeLinkClicked]);
+XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest navigationType:UIWebViewNavigationTypeOther]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest navigationType:UIWebViewNavigationTypeReload]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeBackForward]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeFormSubmitted]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeFormResubmitted]);
+
--- End diff --

See my comment on that note. The operative test here is for 
"shouldOverrideLoadWithRequest" -- if the intent is allowed, it should return 
NO, as in it shouldn't override the load with the request (since it is opened 
externally).


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11592) Crashes due to android 7.0 "file://" Handling "android.os.FileUriExposedException"

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406739#comment-15406739
 ] 

Joe Bowser commented on CB-11592:
-

[~bored...@gmail.com] So, have you actually encountered this issue on File or 
InAppBrowser?  Or is this just an issue in Camera.  We've covered the issue in 
Camera, but we need solid repro steps for this before we can really move on the 
rest of this issue.

> Crashes due to android 7.0 "file://" Handling 
> "android.os.FileUriExposedException"
> --
>
> Key: CB-11592
> URL: https://issues.apache.org/jira/browse/CB-11592
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin Camera, Plugin File, Plugin InAppBrowser
> Environment: all Environemnts with android 7.0
>Reporter: Christoph Brosdau
>Assignee: Joe Bowser
>Priority: Blocker
>
> Android 7.0 removes the "file://" Protocol or to be more precise, removes the 
> possibility to share URIs with "file://" Protocol outside the Scope of the 
> own App. If some Code tries this, the result is 
> "android.os.FileUriExposedException".
> This affects a variety of Plugins:
> - inAppBrowser: opening a file:// URI (e.g. to show a downloaded PDF) crasehs 
> the app, 
> - Camera crashes immediately: opening a cached File by 
> "ClipData.Item.getUri()"
> - possible a couple of the File Plugin Methods



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406722#comment-15406722
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/232#discussion_r73432421
  
--- Diff: 
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
 ---
@@ -95,23 +95,33 @@ - (CDVIntentAndNavigationFilterValue) 
filterUrl:(NSURL*)url
 return [[self class] filterUrl:url 
intentsWhitelist:self.allowIntentsWhitelist 
navigationsWhitelist:self.allowNavigationsWhitelist];
 }
 
-- (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
++ (BOOL)shouldOpenURLRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
+{
+return (UIWebViewNavigationTypeLinkClicked == navigationType ||
+(UIWebViewNavigationTypeOther == navigationType &&
+ [[request.mainDocumentURL absoluteString] 
isEqualToString:[request.URL absoluteString]]
+ )
+);
+}
+
++ (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType 
filterValue:(CDVIntentAndNavigationFilterValue)filterValue
 {
 NSString* allowIntents_whitelistRejectionFormatString = @"ERROR 
External navigation rejected -  not set for url='%@'";
 NSString* allowNavigations_whitelistRejectionFormatString = @"ERROR 
Internal navigation rejected -  not set for url='%@'";
 
 NSURL* url = [request URL];
-CDVIntentAndNavigationFilterValue filterValue = [self filterUrl:url];
 
 switch (filterValue) {
 case CDVIntentAndNavigationFilterValueNavigationAllowed:
 return YES;
 case CDVIntentAndNavigationFilterValueIntentAllowed:
-// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag)
-if (UIWebViewNavigationTypeLinkClicked == navigationType) {
+// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag) OR
+// it's a UIWebViewNavigationTypeOther, and it's an internal 
link
+if ([[self class] shouldOpenURLRequest:request 
navigationType:navigationType]){
 [[UIApplication sharedApplication] openURL:url];
 }
-// consume the request (i.e. no error) if it wasn't a 
UIWebViewNavigationTypeLinkClicked
+
--- End diff --

returning NO here signals to the WebView that it should not load the URL 
inside itself, so it is correct in this context since we open the url 
externally.


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11623) --link-to no longer seems to be working

[Kyle Kirbatski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406709#comment-15406709
 ] 

Kyle Kirbatski commented on CB-11623:
-

Me personally, it's just www contents. config.xml resides in the root cordova 
project directory.

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>Assignee: Caryn Tran
>  Labels: triaged
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11623) --link-to no longer seems to be working

[Steve Gill (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406689#comment-15406689
 ] 

Steve Gill commented on CB-11623:
-

Hey Graham, 

Do you guys link-to a www folder or a folder that contains www and config.xml? 
Or does your linked www include a config.xml inside of it? Or do you not worry 
about config.xml in the linked-to folder?

> --link-to no longer seems to be working
> ---
>
> Key: CB-11623
> URL: https://issues.apache.org/jira/browse/CB-11623
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI, CordovaLib
>Affects Versions: 6.3.0
> Environment: Windows 10, Windows Command Prompt
>Reporter: Graham Harper
>Assignee: Caryn Tran
>  Labels: triaged
>
> We have a build script for installing and building Cordova from source 
> control that begins with the line:
> cordova create bin com.example.domain APPNAME --link-to=www
> Where www is our existing app code (html, css, js etc.)
> We've been running this build script on new deployments just fine for 6 
> months or so, and its behaviour until this version has been to create a 
> simlink in the newly-created 'bin' folder to our existing app in 'www'; 
> however, as of 6.3.0 this is no longer working. The command creates the bin 
> folder, but it only contains the default 'Hello Cordova' application.
> --copy-from still seems to be working (although is marked as deprecated), so 
> we can work around this issue, but it's not appropriate for our deployment 
> and development process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11666) Bug "Cordova Capture Video"

[Fernando Jose Torres Bermudez (JIRA)]

Fernando Jose Torres Bermudez created CB-11666:
--

 Summary: Bug "Cordova Capture Video"
 Key: CB-11666
 URL: https://issues.apache.org/jira/browse/CB-11666
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android, Plugin Media Capture
Affects Versions: 3.5.0
Reporter: Fernando Jose Torres Bermudez


By capturing a video and do a preview a video tag, the video leaves me 90 
rotated only happens in portrait, the code is as follows:

var options = {
quality: 50,
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
mediaType: Camera.MediaType.ALLMEDIA,
destinationType: Camera.DestinationType.FILE_URI,
  correctOrientation: true,
  allowEdit : true
};

$cordovaCamera.getPicture(options).then(function(video) {

 
  $('#previewVideo')[0].pause();

  $scope.videoInfo.localURL = video;

console.log(err);
  });


}, function(err) {
  console.log(err);
  if($scope.step == 1){
$state.go('app.asiSomos');
  }
});
  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11423) Web view shrinks after locking screen orientation

[Joe Meeks (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406584#comment-15406584
 ] 

Joe Meeks edited comment on CB-11423 at 8/3/16 8:42 PM:


[~tony--] are you using a WKWebView? Version 0.6.9 of the Telerik WKWebView 
Polyfill is in use in my app that exhibits this behavior.

https://github.com/Telerik-Verified-Plugins/WKWebView

My guess is that [~rbarriuso] is using this or Shazron's Cordova WKWebView also.

http://plugins.telerik.com/cordova/plugin/cordova-wkwebview-engine




was (Author: taekwonjoe):
[~tony--] are you using a WKWebView? version 0.6.9 of the Telerik WKWebView 
Polyfill is in use in my app that exhibits this behavior.

https://github.com/Telerik-Verified-Plugins/WKWebView

My guess is that [~rbarriuso] is using this or Shazron's Cordova WKWebView also.

http://plugins.telerik.com/cordova/plugin/cordova-wkwebview-engine



> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11423) Web view shrinks after locking screen orientation

[Joe Meeks (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406584#comment-15406584
 ] 

Joe Meeks commented on CB-11423:


[~tony--] are you using a WKWebView? version 0.6.9 of the Telerik WKWebView 
Polyfill is in use in my app that exhibits this behavior.

https://github.com/Telerik-Verified-Plugins/WKWebView

My guess is that [~rbarriuso] is using this or Shazron's Cordova WKWebView also.

http://plugins.telerik.com/cordova/plugin/cordova-wkwebview-engine



> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11281) Prompt dialog: defaultText is not taken as input if no input by user

[Deshan Kalupahana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deshan Kalupahana reassigned CB-11281:
--

Assignee: Deshan Kalupahana

> Prompt dialog: defaultText is not taken as input if no input by user
> 
>
> Key: CB-11281
> URL: https://issues.apache.org/jira/browse/CB-11281
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs
>Affects Versions: 3.5.0
> Environment: Windows 10
>Reporter: Kai Schätzl
>Assignee: Deshan Kalupahana
>Priority: Minor
>  Labels: Windows, easy, easyfix, triaged, windows-universal
> Fix For: Master
>
>
> Consider the case where you have a defaultText for 
> navigator.notification.prompt, the user sees it and then hits enter.
> With the original Javascript prompt dialog you get whatever's in the field as 
> output. var result = prompt ("Description", "Default Value");
> So, if the user enters nothing you get the default value given as your value 
> in result.
> This is the expected behavior when mimicking this dialog.
> To my surprise, this is not what happens with navigator.notification.prompt. 
> If the user enters nothing then nothing is returned via results.input1. 
> Although it looks like something is already "sitting" there and waiting for 
> submit.
> I think this behavior should be changed according to what the Javascript 
> prompt dialog does. That makes it consistent with browser behavior and what 
> most people expect.
> This bug might be related to https://issues.apache.org/jira/browse/CB-11214, 
> where the reporter seems to expect the opposite (not sure about that).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11423) Web view shrinks after locking screen orientation

[Tony Homer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406390#comment-15406390
 ] 

Tony Homer edited comment on CB-11423 at 8/3/16 8:15 PM:
-

[~rbarriuso], I tried to reproduce this today, but when I follow the steps I am 
unable to reproduce.
When I do step 5 in simulator, the view does not rotate.
I'm not sure why it does not work for me in the simulator :(
I'll try some different things but if you have any ideas, please let me know!

If I do the same steps on a physical iPhone 6, the view does not shrink (see 
[my response to the first 
comment|https://issues.apache.org/jira/browse/CB-11423?focusedCommentId=15406380=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15406380]).
Update: -I'll try to find an iPhone 6+ to test with.-
I found an iPhone 6+ and the results were the same as on iPhone 6 (see above).



was (Author: tony--):
[~rbarriuso], I tried to reproduce this today, but when I follow the steps I am 
unable to reproduce.
When I do step 5 in simulator, the view does not rotate.
I'm not sure why it does not work for me in the simulator :(
I'll try some different things but if you have any ideas, please let me know!

If I do the same steps on a physical iPhone 6, the view does not shrink (see 
[my response to the first 
comment|https://issues.apache.org/jira/browse/CB-11423?focusedCommentId=15406380=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15406380]).
I'll try to find an iPhone 6+ to test with.

> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11665) Navigation to Fragment locations within Webview are parsed as an error

[Brian Anderson (JIRA)]

Brian Anderson created CB-11665:
---

 Summary: Navigation to Fragment locations within Webview are 
parsed as an error
 Key: CB-11665
 URL: https://issues.apache.org/jira/browse/CB-11665
 Project: Apache Cordova
  Issue Type: Bug
  Components: iOS
 Environment: cordova-ios
Reporter: Brian Anderson


In the CDVUIWebviewDelegate if a fragment is loaded on a url the 
shouldStartLoadWithRequest gets called and sets the _state to 
STATE_WAITING_FOR_LOAD_START. Being that when a fragment is loaded the 
didStartLoading and didFinishLoading callbacks are not called, the next time a 
link is clicked within our WebView the _state doesn't match any cases, falls 
into the default case which then handles the request as an error by explicitly 
calling didFailLoadWithError. I am curious if this is by design as I do notice 
that STATE_IOS5_POLLING_FOR_LOAD_START is handled in 
shouldStartLoadWithRequest. Is there a specific case that we would actually 
want to throw an error?

My suggestion for fixing this would be to add STATE_WAITING_FOR_LOAD_START to 
the same fall through case as STATE_IDLE, STATE_IOS5_POLLING_FOR_LOAD_START, 
STATE_CANCELLED. Which would basically just reset the state and loadCount 
seeing as we have essentially 'cancelled' that pending request from the eyes of 
cordova. 

Hoping to get more information about these decisions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11423) Web view shrinks after locking screen orientation

[Tony Homer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406390#comment-15406390
 ] 

Tony Homer commented on CB-11423:
-

[~rbarriuso], I tried to reproduce this today, but when I follow the steps I am 
unable to reproduce.
When I do step 5 in simulator, the view does not rotate.
I'm not sure why it does not work for me in the simulator :(
I'll try some different things but if you have any ideas, please let me know!

If I do the same steps on a physical iPhone 6, the view does not shrink (see 
[my response to the first 
comment|https://issues.apache.org/jira/browse/CB-11423?focusedCommentId=15406380=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15406380]).
I'll try to find an iPhone 6+ to test with.

> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11423) Web view shrinks after locking screen orientation

[Tony Homer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406380#comment-15406380
 ] 

Tony Homer commented on CB-11423:
-

[~TaeKwonJoe] - thanks for providing these steps.  I must be doing something 
wrong, because I can't get the issue to occur.

I'm on an iPhone 6 with iOS 9.3.2 and I built my app with cordova-ios 3.8.0.
I added cordova-plugin-screen-orientation.
In order to allow landscape on startup, I edited config.xml, adding:
{code}

{code}
(1) I start my app while holding the phone sideways and wait for the 
splashscreen to disappear.
!cb-11423-joe1.png!
(2) After splashscreen hides, I rotate the phone to portrait
(3) the view looks normal
!cb-11423-joe2.png!

> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11423) Web view shrinks after locking screen orientation

[Tony Homer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tony Homer updated CB-11423:

Attachment: cb-11423-joe1.png
cb-11423-joe2.png

> Web view shrinks after locking screen orientation
> -
>
> Key: CB-11423
> URL: https://issues.apache.org/jira/browse/CB-11423
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Screen Orientation
>Affects Versions: 1.4.2
> Environment: Using:
> - Cordova CLI 6.2.0
> - cordova-ios 4.1.1
> - Xcode 7.3
> - OSX 10.11.5
> Best reproduced on an iOS simulator with iPhone 6s Plus and iOS 9.3.
>Reporter: Rafael Barriuso
>Assignee: Tony Homer
> Attachments: cb-11423-joe1.png, cb-11423-joe2.png
>
>
> Since version 1.4.2 "screen.lockOrientation" works on iOS 9, but for some 
> reason, in some phones the dimensions of the web view are wrong after 
> changing to the new orientation.
> Before locking:
> !https://www.dropbox.com/s/t2jcqqmg1hni22t/Sim-screenshot2.png?dl=1!
> After locking:
> !https://www.dropbox.com/s/p64324riwqzepzz/Sim-screenshot1.png?dl=1!
> Steps to reproduce:
> 1) Prepare a cordova app including cordova-plugin-screen-orientation.
> 2) Run the application on a Xcode simulator for iPhone 6s Plus and iOS 9.3.
> 3) Rotate the simulator to the left (menu -> Hardware -> Rotate left).
> 4) Open the Safari web inspector connected to the app running on the 
> simulator.
> 5) In the console, run: window.screen.lockOrientation("portrait-primary")
> 6) The width of the resulting "" is shrink, as reported by the Safari 
> web inspector (e.g. in my case to 92px whereas it should be 414px).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11653) Copy findProjectRoot from CordovaLib to CordovaCommon

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406210#comment-15406210
 ] 

ASF GitHub Bot commented on CB-11653:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/474


> Copy findProjectRoot from CordovaLib to CordovaCommon
> -
>
> Key: CB-11653
> URL: https://issues.apache.org/jira/browse/CB-11653
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Caryn Tran
>Assignee: Caryn Tran
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11653) Copy findProjectRoot from CordovaLib to CordovaCommon

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406208#comment-15406208
 ] 

ASF subversion and git services commented on CB-11653:
--

Commit a429358eb76fef6597c35d4fdf69df7db79af31c in cordova-lib's branch 
refs/heads/master from [~carynbear]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a429358 ]

CB-11653 copied findProjectRoot from cordova-lib

 This closes #474


> Copy findProjectRoot from CordovaLib to CordovaCommon
> -
>
> Key: CB-11653
> URL: https://issues.apache.org/jira/browse/CB-11653
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Caryn Tran
>Assignee: Caryn Tran
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11074) WKWebView configuration is not considered

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406170#comment-15406170
 ] 

ASF GitHub Bot commented on CB-11074:
-

Github user macrozone commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
  
Any update on this? In my opinion, this is a very severe issue with 
WKWebview.


> WKWebView configuration is not considered
> -
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
> Environment: ios
>Reporter: Alexis Kofman
>Assignee: Shazron Abdullah
>Priority: Critical
>  Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a 
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after 
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406057#comment-15406057
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user tony-- commented on the issue:

https://github.com/apache/cordova-ios/pull/232
  
I ran the tests - they passed.

I wrote a manual test with an index.html that has a javascript tel: link 
and an iframe with the same javascript tel: link.  The index.html tel:link 
works, the iframe tel:link does not work - this is what we want, I think.

Please see the inline comments on the "Files changed" tab.


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406055#comment-15406055
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user tony-- commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/232#discussion_r73358461
  
--- Diff: 
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
 ---
@@ -95,23 +95,33 @@ - (CDVIntentAndNavigationFilterValue) 
filterUrl:(NSURL*)url
 return [[self class] filterUrl:url 
intentsWhitelist:self.allowIntentsWhitelist 
navigationsWhitelist:self.allowNavigationsWhitelist];
 }
 
-- (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
++ (BOOL)shouldOpenURLRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
+{
+return (UIWebViewNavigationTypeLinkClicked == navigationType ||
+(UIWebViewNavigationTypeOther == navigationType &&
+ [[request.mainDocumentURL absoluteString] 
isEqualToString:[request.URL absoluteString]]
+ )
+);
+}
+
++ (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType 
filterValue:(CDVIntentAndNavigationFilterValue)filterValue
 {
 NSString* allowIntents_whitelistRejectionFormatString = @"ERROR 
External navigation rejected -  not set for url='%@'";
 NSString* allowNavigations_whitelistRejectionFormatString = @"ERROR 
Internal navigation rejected -  not set for url='%@'";
 
 NSURL* url = [request URL];
-CDVIntentAndNavigationFilterValue filterValue = [self filterUrl:url];
 
 switch (filterValue) {
 case CDVIntentAndNavigationFilterValueNavigationAllowed:
 return YES;
 case CDVIntentAndNavigationFilterValueIntentAllowed:
-// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag)
-if (UIWebViewNavigationTypeLinkClicked == navigationType) {
+// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag) OR
+// it's a UIWebViewNavigationTypeOther, and it's an internal 
link
+if ([[self class] shouldOpenURLRequest:request 
navigationType:navigationType]){
 [[UIApplication sharedApplication] openURL:url];
 }
-// consume the request (i.e. no error) if it wasn't a 
UIWebViewNavigationTypeLinkClicked
+
--- End diff --

Currently if we make it in to openURL, we'll still fall through to return 
NO.
Since we handled it (by sending it to openURL), should we return YES from 
inside the if clause?


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406054#comment-15406054
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user tony-- commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/232#discussion_r73358362
  
--- Diff: tests/CordovaLibTests/CDVWhitelistTests.m ---
@@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations
 XCTAssertEqual([CDVIntentAndNavigationFilter filterUrl:[NSURL 
URLWithString:@"https://google.com;] intentsWhitelist:intentsWhitelist 
navigationsWhitelist:navigationsWhitelist], 
CDVIntentAndNavigationFilterValueIntentAllowed);
 // Test http (not allowed in either)
 XCTAssertEqual([CDVIntentAndNavigationFilter filterUrl:[NSURL 
URLWithString:@"http://google.com;] intentsWhitelist:intentsWhitelist 
navigationsWhitelist:navigationsWhitelist], 
CDVIntentAndNavigationFilterValueNoneAllowed);
+
+
+NSURL* telUrl = [NSURL URLWithString:@"tel:555"];
+NSMutableURLRequest* telRequest = [NSMutableURLRequest 
requestWithURL:telUrl];
+telRequest.mainDocumentURL = telUrl;
+
+// mainDocumentURL and URL are the same in the NSURLRequest
+// Only UIWebViewNavigationTypeLinkClicked and 
UIWebViewNavigationTypeOther should return YES
+XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeLinkClicked]);
+XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest navigationType:UIWebViewNavigationTypeOther]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest navigationType:UIWebViewNavigationTypeReload]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeBackForward]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeFormSubmitted]);
+XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOpenURLRequest:telRequest 
navigationType:UIWebViewNavigationTypeFormResubmitted]);
+
--- End diff --

Would it make sense to test the intent-allowed case?  This currently fails 
- see comment in comments section.
```
// Only CDVIntentAndNavigationFilterValueIntentAllowed and 
CDVIntentAndNavigationFilterValueNavigationAllowed should return YES
XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOverrideLoadWithRequest:telRequest 
navigationType:UIWebViewNavigationTypeOther 
filterValue:CDVIntentAndNavigationFilterValueNavigationAllowed]);
XCTAssertTrue([CDVIntentAndNavigationFilter 
shouldOverrideLoadWithRequest:telRequest 
navigationType:UIWebViewNavigationTypeOther 
filterValue:CDVIntentAndNavigationFilterValueIntentAllowed]);
XCTAssertFalse([CDVIntentAndNavigationFilter 
shouldOverrideLoadWithRequest:telRequest 
navigationType:UIWebViewNavigationTypeOther 
filterValue:CDVIntentAndNavigationFilterValueNoneAllowed]);

```


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11270) [QUESTION] Is whitelist intent filter working as intended?

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406041#comment-15406041
 ] 

ASF GitHub Bot commented on CB-11270:
-

Github user tony-- commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/232#discussion_r73356143
  
--- Diff: 
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
 ---
@@ -95,23 +95,33 @@ - (CDVIntentAndNavigationFilterValue) 
filterUrl:(NSURL*)url
 return [[self class] filterUrl:url 
intentsWhitelist:self.allowIntentsWhitelist 
navigationsWhitelist:self.allowNavigationsWhitelist];
 }
 
-- (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
++ (BOOL)shouldOpenURLRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType
+{
+return (UIWebViewNavigationTypeLinkClicked == navigationType ||
+(UIWebViewNavigationTypeOther == navigationType &&
+ [[request.mainDocumentURL absoluteString] 
isEqualToString:[request.URL absoluteString]]
+ )
+);
+}
+
++ (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request 
navigationType:(UIWebViewNavigationType)navigationType 
filterValue:(CDVIntentAndNavigationFilterValue)filterValue
 {
 NSString* allowIntents_whitelistRejectionFormatString = @"ERROR 
External navigation rejected -  not set for url='%@'";
 NSString* allowNavigations_whitelistRejectionFormatString = @"ERROR 
Internal navigation rejected -  not set for url='%@'";
 
 NSURL* url = [request URL];
-CDVIntentAndNavigationFilterValue filterValue = [self filterUrl:url];
 
 switch (filterValue) {
 case CDVIntentAndNavigationFilterValueNavigationAllowed:
 return YES;
 case CDVIntentAndNavigationFilterValueIntentAllowed:
-// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag)
-if (UIWebViewNavigationTypeLinkClicked == navigationType) {
+// only allow-intent if it's a 
UIWebViewNavigationTypeLinkClicked (anchor tag) OR
+// it's a UIWebViewNavigationTypeOther, and it's an internal 
link
+if ([[self class] shouldOpenURLRequest:request 
navigationType:navigationType]){
 [[UIApplication sharedApplication] openURL:url];
--- End diff --

Currently if we make it in to openURL, we'll still fall through to return 
NO.
Since we handled it (by sending it to openURL), should we return YES from 
inside the if clause?


> [QUESTION] Is whitelist intent filter working as intended?
> --
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Tony Homer
>Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like 
> {code}
> 
> {code}
> , interacting with any of the following elements would result in tel: 
> requests that would all be allowed:
> {code}
> do tel with a.href
> do 
> tel with a.onclick
> do 
> tel with button.onclick
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the 
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the 
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as 
> intended or, if working as intended, the documentation should be improved to 
> spell out this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11664) Give plugins the ability to add classpath entries to buildscript dependencies.

[Carlos Lawton (JIRA)]

Carlos Lawton created CB-11664:
--

 Summary: Give plugins the ability to add classpath entries to 
buildscript dependencies.
 Key: CB-11664
 URL: https://issues.apache.org/jira/browse/CB-11664
 Project: Apache Cordova
  Issue Type: New Feature
  Components: Plugins
Reporter: Carlos Lawton


Plugins should have the ability to add classpath entries to the buildscript 
dependencies.  This would allow the use of gradle plugins like google-services.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11663) doesn't render MediaStream from getUserMedia

[Rafal Pastuszak (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafal Pastuszak updated CB-11663:
-
Priority: Critical  (was: Major)

>  doesn't render MediaStream from getUserMedia
> 
>
> Key: CB-11663
> URL: https://issues.apache.org/jira/browse/CB-11663
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 6.3.0
> Environment: Android 4.4-6.0, Crosswalk,
> Testing done mostly with Nexus6P, but run on some older devices too.
>Reporter: Rafal Pastuszak
>Priority: Critical
>
> Previewing camera input in a video element using getUserMedia works perfectly 
> fine in Chrome, but breaks as soon as we open the same view within a cordova 
> app.
> Added an example using Mozilla gUM polyfill here: 
> https://s3-eu-west-1.amazonaws.com/rafal-temp/index.html
> (note that both new and deprecated gUM APIs don't work).
> This results in an empty, black  element. No errors are fired.
> Initially I thought, that this issue was related to AndroidManifest.xml 
> permissions and CSP, but fixing them makes no difference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11663) doesn't render MediaStream from getUserMedia

[Rafal Pastuszak (JIRA)]

Rafal Pastuszak created CB-11663:


 Summary:  doesn't render MediaStream from getUserMedia
 Key: CB-11663
 URL: https://issues.apache.org/jira/browse/CB-11663
 Project: Apache Cordova
  Issue Type: Bug
Affects Versions: 6.3.0
 Environment: Android 4.4-6.0, Crosswalk,

Testing done mostly with Nexus6P, but run on some older devices too.
Reporter: Rafal Pastuszak


Previewing camera input in a video element using getUserMedia works perfectly 
fine in Chrome, but breaks as soon as we open the same view within a cordova 
app.

Added an example using Mozilla gUM polyfill here: 
https://s3-eu-west-1.amazonaws.com/rafal-temp/index.html

(note that both new and deprecated gUM APIs don't work).

This results in an empty, black  element. No errors are fired.

Initially I thought, that this issue was related to AndroidManifest.xml 
permissions and CSP, but fixing them makes no difference.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11649) Unable to validate app through WACK built for store using Visual Studio 2015 for Windows 10 UWP

[Lal Kishor (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405737#comment-15405737
 ] 

Lal Kishor commented on CB-11649:
-

I also want to add that, while the WACK test is running, the app is launched 
multiple times, the splashscreen shows up and is followed by a complete 
whitescreen. That is what supposedly is the hang...

> Unable to validate app through WACK built for store using Visual Studio 2015 
> for Windows 10 UWP
> ---
>
> Key: CB-11649
> URL: https://issues.apache.org/jira/browse/CB-11649
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: Windows 10 Pro x64 Build 1511 (586.494)
> Visual Studio 2015 Community Update 1
> Node JS 6.3.1 (x64)
> Cordova 6.3.0
> Windows Platform 4.4.2
>Reporter: Lal Kishor
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: build, windows
>
> Create a blank cordova project:
>  cordova create dumbApp com.testing.dumbapp "Dumb App"
> Add windows platform to it:
>  cordova platform add windows
> Now open the CordovaApp.sln in Visual Studio 2015
>  Set windows 10 as startup project (I need to build for this only)
> Now if I run it on a windows 10 phone (Lumia 730) in debug mode it runs fine.
>(App loads and "Device is Ready" message shows up)
> So now if I need to publish this app:
> I Right click on CordovaApp.Windows10(Universal Windows) -> Store -> Create 
> App Packages
> Select Yes in Build for Store.
> Click Next
> I Login with my store credentials.
> Select an app from the list & click Next
> on Select and Configure packages page:
> Generate App Bundle -> always
> I Select all (i.e- x86, x64, ARM) in architecture
> & then Create.
> Now, in Package Creation Completed window, it says Launch WACK on local 
> machine. (Also No appxupload file was created)
> Click Launch WACK.
> Select all tests (after admin privilege prompt & a cmd window)
> Click Next.
> & now the result shows as FAILED
> the Report shows following Error in Crashes and hangs:
> Application 3982*._1.1.0.0_x64__0avdcyp53wg40 was 
> detected by Windows Error Reporting and experienced a crash or hang.
> That's a bare minimum application with no extra code, or plugin.
> This behavior is really bad, I had to pubish an app and this issue showed up 
> with no solution I am two weeks past the deadline.
> Guys developing windows platform please look through the issue and provide a 
> fix.
> also, a workaround will be very helpful for my current project, if any.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11649) Unable to validate app through WACK built for store using Visual Studio 2015 for Windows 10 UWP

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405676#comment-15405676
 ] 

Vladimir Kotikov commented on CB-11649:
---

[~daserge] to see if it related somehow to activation event issue. Also can you 
add a link to that issue here?

> Unable to validate app through WACK built for store using Visual Studio 2015 
> for Windows 10 UWP
> ---
>
> Key: CB-11649
> URL: https://issues.apache.org/jira/browse/CB-11649
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: Windows 10 Pro x64 Build 1511 (586.494)
> Visual Studio 2015 Community Update 1
> Node JS 6.3.1 (x64)
> Cordova 6.3.0
> Windows Platform 4.4.2
>Reporter: Lal Kishor
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: build, windows
>
> Create a blank cordova project:
>  cordova create dumbApp com.testing.dumbapp "Dumb App"
> Add windows platform to it:
>  cordova platform add windows
> Now open the CordovaApp.sln in Visual Studio 2015
>  Set windows 10 as startup project (I need to build for this only)
> Now if I run it on a windows 10 phone (Lumia 730) in debug mode it runs fine.
>(App loads and "Device is Ready" message shows up)
> So now if I need to publish this app:
> I Right click on CordovaApp.Windows10(Universal Windows) -> Store -> Create 
> App Packages
> Select Yes in Build for Store.
> Click Next
> I Login with my store credentials.
> Select an app from the list & click Next
> on Select and Configure packages page:
> Generate App Bundle -> always
> I Select all (i.e- x86, x64, ARM) in architecture
> & then Create.
> Now, in Package Creation Completed window, it says Launch WACK on local 
> machine. (Also No appxupload file was created)
> Click Launch WACK.
> Select all tests (after admin privilege prompt & a cmd window)
> Click Next.
> & now the result shows as FAILED
> the Report shows following Error in Crashes and hangs:
> Application 3982*._1.1.0.0_x64__0avdcyp53wg40 was 
> detected by Windows Error Reporting and experienced a crash or hang.
> That's a bare minimum application with no extra code, or plugin.
> This behavior is really bad, I had to pubish an app and this issue showed up 
> with no solution I am two weeks past the deadline.
> Guys developing windows platform please look through the issue and provide a 
> fix.
> also, a workaround will be very helpful for my current project, if any.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405672#comment-15405672
 ] 

Vladimir Kotikov commented on CB-11657:
---

[~daserge], please disregard my previous comment

> Windows app fails WACK test due to missing UTF BOM
> --
>
> Key: CB-11657
> URL: https://issues.apache.org/jira/browse/CB-11657
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 4.4.3
>
>
> After building app for store and running WACK it fails with the following 
> error:
> File encoding test
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11649) Unable to validate app through WACK built for store using Visual Studio 2015 for Windows 10 UWP

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405676#comment-15405676
 ] 

Vladimir Kotikov edited comment on CB-11649 at 8/3/16 10:16 AM:


[~daserge] to see if it related somehow to activation event issue. Also can you 
add a link to that issue (if it is posted on JIRA) here?


was (Author: vladimir.kotikov):
[~daserge] to see if it related somehow to activation event issue. Also can you 
add a link to that issue here?

> Unable to validate app through WACK built for store using Visual Studio 2015 
> for Windows 10 UWP
> ---
>
> Key: CB-11649
> URL: https://issues.apache.org/jira/browse/CB-11649
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: Windows 10 Pro x64 Build 1511 (586.494)
> Visual Studio 2015 Community Update 1
> Node JS 6.3.1 (x64)
> Cordova 6.3.0
> Windows Platform 4.4.2
>Reporter: Lal Kishor
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: build, windows
>
> Create a blank cordova project:
>  cordova create dumbApp com.testing.dumbapp "Dumb App"
> Add windows platform to it:
>  cordova platform add windows
> Now open the CordovaApp.sln in Visual Studio 2015
>  Set windows 10 as startup project (I need to build for this only)
> Now if I run it on a windows 10 phone (Lumia 730) in debug mode it runs fine.
>(App loads and "Device is Ready" message shows up)
> So now if I need to publish this app:
> I Right click on CordovaApp.Windows10(Universal Windows) -> Store -> Create 
> App Packages
> Select Yes in Build for Store.
> Click Next
> I Login with my store credentials.
> Select an app from the list & click Next
> on Select and Configure packages page:
> Generate App Bundle -> always
> I Select all (i.e- x86, x64, ARM) in architecture
> & then Create.
> Now, in Package Creation Completed window, it says Launch WACK on local 
> machine. (Also No appxupload file was created)
> Click Launch WACK.
> Select all tests (after admin privilege prompt & a cmd window)
> Click Next.
> & now the result shows as FAILED
> the Report shows following Error in Crashes and hangs:
> Application 3982*._1.1.0.0_x64__0avdcyp53wg40 was 
> detected by Windows Error Reporting and experienced a crash or hang.
> That's a bare minimum application with no extra code, or plugin.
> This behavior is really bad, I had to pubish an app and this issue showed up 
> with no solution I am two weeks past the deadline.
> Guys developing windows platform please look through the issue and provide a 
> fix.
> also, a workaround will be very helpful for my current project, if any.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-11657) Windows app fails WACK test due to missing UTF BOM

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-11657:
--
Comment: was deleted

(was: [~daserge] to see if it related somehow to activation event issue. Also 
can you add a link to that issue here?)

> Windows app fails WACK test due to missing UTF BOM
> --
>
> Key: CB-11657
> URL: https://issues.apache.org/jira/browse/CB-11657
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 4.4.3
>
>
> After building app for store and running WACK it fails with the following 
> error:
> File encoding test
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405670#comment-15405670
 ] 

Vladimir Kotikov commented on CB-11657:
---

[~daserge] to see if it related somehow to activation event issue. Also can you 
add a link to that issue here?

> Windows app fails WACK test due to missing UTF BOM
> --
>
> Key: CB-11657
> URL: https://issues.apache.org/jira/browse/CB-11657
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.2
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 4.4.3
>
>
> After building app for store and running WACK it fails with the following 
> error:
> File encoding test
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the 
> File menu in Visual Studio. Select the drop-down control next to the Save 
> button and select "Save with Encoding..." option. From the Advanced save 
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click 
> the OK button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11652) cordova run ignores --nobuild option

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov resolved CB-11652.
---
Resolution: Fixed

> cordova run ignores --nobuild option
> 
>
> Key: CB-11652
> URL: https://issues.apache.org/jira/browse/CB-11652
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 6.3.1
>
>
> Since 6.3.0 {{cordova run windows --nobuild}} ignores {{-nobuild}} option and 
> always builds the project. Please note that this is actual for other 
> platforms too.
> {noformat}
> cordova run windows --nobuild
> Warning: using prerelease version 6.3.1-dev (cordova-lib@6.3.1-dev)
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug_Test\CordovaApp.Phone_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Deploying windows package to device:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Attempting to uninstall previous application version...
> Attempting to install application...
> Found package: 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Installing app...
> Found dependency package(s):
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\Dependencies\Microsoft.WinJS.2.0.appx
> Success: Your app was successfully installed.
> Starting application...
> ActivateApplication:  
> io.cordova.hellocordova_h35559jr9hy9m!io.cordova.hellocordova
> {noformat}
> This was introduced by CB-11491



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11652) cordova run ignores --nobuild option

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405667#comment-15405667
 ] 

ASF GitHub Bot commented on CB-11652:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/475


> cordova run ignores --nobuild option
> 
>
> Key: CB-11652
> URL: https://issues.apache.org/jira/browse/CB-11652
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 6.3.1
>
>
> Since 6.3.0 {{cordova run windows --nobuild}} ignores {{-nobuild}} option and 
> always builds the project. Please note that this is actual for other 
> platforms too.
> {noformat}
> cordova run windows --nobuild
> Warning: using prerelease version 6.3.1-dev (cordova-lib@6.3.1-dev)
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug_Test\CordovaApp.Phone_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Deploying windows package to device:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Attempting to uninstall previous application version...
> Attempting to install application...
> Found package: 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Installing app...
> Found dependency package(s):
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\Dependencies\Microsoft.WinJS.2.0.appx
> Success: Your app was successfully installed.
> Starting application...
> ActivateApplication:  
> io.cordova.hellocordova_h35559jr9hy9m!io.cordova.hellocordova
> {noformat}
> This was introduced by CB-11491



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11652) cordova run ignores --nobuild option

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405666#comment-15405666
 ] 

ASF subversion and git services commented on CB-11652:
--

Commit 3e1a5cdb3eb4331de81342aae47131d5a4ddc061 in cordova-lib's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3e1a5cd ]

CB-11652 Update run and emulate to skip build

We need to add this conditional logic to cordova's `run` and
`emulate` methods to skip build when `--nobuild` option is
specified. CLI previously has delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call
platform's `build` and `run` separately and so we need to handle
this option in CLI


> cordova run ignores --nobuild option
> 
>
> Key: CB-11652
> URL: https://issues.apache.org/jira/browse/CB-11652
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: reproduced, triaged
> Fix For: 6.3.1
>
>
> Since 6.3.0 {{cordova run windows --nobuild}} ignores {{-nobuild}} option and 
> always builds the project. Please note that this is actual for other 
> platforms too.
> {noformat}
> cordova run windows --nobuild
> Warning: using prerelease version 6.3.1-dev (cordova-lib@6.3.1-dev)
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Windows -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Building project: 
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform  : anycpu
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug_Test\CordovaApp.Phone_1.0.0.0_anycpu_debug.appx
>   CordovaApp.Phone -> 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug.appxupload
>   Your package has been successfully created.
> Deploying windows package to device:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Attempting to uninstall previous application version...
> Attempting to install application...
> Found package: 
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Installing app...
> Found dependency package(s):
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\Dependencies\Microsoft.WinJS.2.0.appx
> Success: Your app was successfully installed.
> Starting application...
> ActivateApplication:  
> io.cordova.hellocordova_h35559jr9hy9m!io.cordova.hellocordova
> {noformat}
> This was introduced by CB-11491



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11398) .appxbundle file is not generated with '--bundle' command

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov reassigned CB-11398:
-

Assignee: Vladimir Kotikov

> .appxbundle file is not generated with '--bundle' command
> -
>
> Key: CB-11398
> URL: https://issues.apache.org/jira/browse/CB-11398
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.1.1
> Environment: cordova 6.1.1
> windows 4.3.2
>Reporter: Michael Schmidt
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: windows
>
> *situation*
> - build.json built up as described in 
> http://cordova.apache.org/docs/en/latest/guide/platforms/win8/index.html#signing-an-app
> - windows 10 universal app
> - goal: create an .appxbundle file as described in 
> https://github.com/apache/cordova-windows/commit/eeda3df0711cee0ff7beb761aac33e18b534b5f0
> *problem: .appxbundle file is not generated*
> the command 
> {code}
> cordova build windows -- --archs="x86 x64 arm" --bundle
> {code}
> doesn't create an .appxbundle file
> same problem exists with release command
> {code}
> cordova build windows --release -- --archs="x86 x64 arm" 
> --buildConfig="build.json" --bundle
> {code}
> I want to upload to the store - what alternatives are there from the CLI?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11653) Copy findProjectRoot from CordovaLib to CordovaCommon

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405658#comment-15405658
 ] 

ASF GitHub Bot commented on CB-11653:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/474
  
Ah, I see, thanks!


> Copy findProjectRoot from CordovaLib to CordovaCommon
> -
>
> Key: CB-11653
> URL: https://issues.apache.org/jira/browse/CB-11653
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Caryn Tran
>Assignee: Caryn Tran
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11193) Improve performance of `cordova build android`

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11193.
-

> Improve performance of `cordova build android`
> --
>
> Key: CB-11193
> URL: https://issues.apache.org/jira/browse/CB-11193
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> For a helloworld project, we want to improve the performance of cordova buid 
> android.
> Here's the breakdown on warm builds on my Macbook Pro:
> -  Node loading time + module loading and global code – 800 ms
> - Time for prepare 700ms - 1 second
> - Time to check requirements - 1-2 seconds
> - Gradle build time: 1.2 seconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11198) Skip checking android target installed

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11198.
-

> Skip checking android target installed
> --
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the 
> message later.
> This saves a good 1 second on my Macbook pro.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11194) Improve cordova load time

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11194.
-

> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8151) --copy-from cannot work w/ remote urls on the cli (but can programatically)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405652#comment-15405652
 ] 

ASF GitHub Bot commented on CB-8151:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/462


> --copy-from cannot work w/ remote urls on the cli (but can programatically)
> ---
>
> Key: CB-8151
> URL: https://issues.apache.org/jira/browse/CB-8151
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Brian LeRoux
>
>  It's this code in cli.js - 
> ```var customWww = args['copy-from'] || args['link-to'];
>if (customWww) {
>if (customWww.indexOf('http') === 0) {
>throw new CordovaError(
>'Only local paths for custom www assets are supported.'
>);
>}
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11194) Improve cordova load time

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405651#comment-15405651
 ] 

ASF subversion and git services commented on CB-11194:
--

Commit 68af465ca7906c47bebfa9428124e83855dda6f6 in cordova-lib's branch 
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=68af465 ]

CB-11194 Defer creating of libDir folder until something actually requests it

This closes #462


> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8151) --copy-from cannot work w/ remote urls on the cli (but can programatically)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405644#comment-15405644
 ] 

ASF GitHub Bot commented on CB-8151:


Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/462
  
LGTM


> --copy-from cannot work w/ remote urls on the cli (but can programatically)
> ---
>
> Key: CB-8151
> URL: https://issues.apache.org/jira/browse/CB-8151
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Brian LeRoux
>
>  It's this code in cli.js - 
> ```var customWww = args['copy-from'] || args['link-to'];
>if (customWww) {
>if (customWww.indexOf('http') === 0) {
>throw new CordovaError(
>'Only local paths for custom www assets are supported.'
>);
>}
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11078) Empty string for BackgroundColor preference crashes application

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile resolved CB-11078.
---
Resolution: Fixed

Fixed in cordova-android 5.3.0-dev

> Empty string for BackgroundColor preference crashes application
> ---
>
> Key: CB-11078
> URL: https://issues.apache.org/jira/browse/CB-11078
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: HTC One
> Android 6.0
> Cordova-Android 5.1.0
>Reporter: Ryan Willoughby
>Assignee: Jesse MacFadyen
>Priority: Minor
>  Labels: easyfix, triaged
>
> A preference of 
> {{}}
> will cause an a cordova application to crash on startup with a 
> NumberFormatException:
> {color:red}
> 04-13 11:18:29.894: E/AndroidRuntime(20224): java.lang.RuntimeException: 
> Unable to start activity 
> ComponentInfo{com.whatever.whatever/com.whatever.whatever.ClassName}: 
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2484)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2544)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.access$900(ActivityThread.java:150)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread$H.handleMessage(ActivityThread.java:1394)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.os.Handler.dispatchMessage(Handler.java:102)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.os.Looper.loop(Looper.java:168)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.main(ActivityThread.java:5845)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.reflect.Method.invoke(Native Method)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:797)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:687)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): Caused by: 
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.Long.invalidLong(Long.java:124)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.Long.decode(Long.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaPreferences.getInteger(CordovaPreferences.java:78)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.createViews(CordovaActivity.java:178)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.init(CordovaActivity.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.loadUrl(CordovaActivity.java:214)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> uk.directpath.staffssmartalert2.StaffsSmartAlertv2.onCreate(StaffsSmartAlertv2.java:32)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.Activity.performCreate(Activity.java:6248)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1125)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2437)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  ... 9 more
> {color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11662) plugman fails when installing plugins with windows framework references

[Ryan Willoughby (JIRA)]

Ryan Willoughby created CB-11662:


 Summary: plugman fails when installing plugins with windows 
framework references
 Key: CB-11662
 URL: https://issues.apache.org/jira/browse/CB-11662
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Vibration, Plugman
Affects Versions: 1.3.0
 Environment: Node 4.4.7, cordova 6.3.0, reproduce on Cygwin/Windows 
and Bash/OSX.
Reporter: Ryan Willoughby


When installing a plugin for cordova-windows with a framework reference, the 
command errors out. Reproduction steps and output below.

{code}
npm install -g plugman
cordova create myapp
cd myapp
cordova platform add windows
cd ..
[ryan-testapp]plugman install --plugin cordova-plugin-vibration --project 
platforms/windows --platform windows
Fetching plugin "cordova-plugin-vibration" via npm
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-vibration':Error: Uh oh!
ENOENT: no such file or directory, open 
'plugins/cordova-plugin-vibration/src/windows/Vibration/Vibration.csproj'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object.module.exports.parseElementtreeSync 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/node_modules/cordova-common/src/util/xml-helpers.js:179:27)
at Object.jsprojManager.addProjectReference 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/lib/JsprojManager.js:187:44)
at handlers.framework.install 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/lib/PluginHandler.js:92:25)
at Object.ActionStack.process 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
at PluginManager.doOperation 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/node_modules/cordova-common/src/PluginManager.js:117:20)
at PluginManager.addPlugin 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/node_modules/cordova-common/src/PluginManager.js:147:17)
at Api.addPlugin 
(/Users/ryanw/dev/sandbox/testapp/platforms/windows/cordova/Api.js:191:10)
Uh oh!
ENOENT: no such file or directory, open 
'plugins/cordova-plugin-vibration/src/windows/Vibration/Vibration.csproj'
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11398) .appxbundle file is not generated with '--bundle' command

[Michael Schmidt (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405447#comment-15405447
 ] 

Michael Schmidt commented on CB-11398:
--

[~vladimir.kotikov] can you please check as well the "--bundle" option - it 
seems to have no effect. probably this got better due to the --archs parsing in 
CB-11478

> .appxbundle file is not generated with '--bundle' command
> -
>
> Key: CB-11398
> URL: https://issues.apache.org/jira/browse/CB-11398
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.1.1
> Environment: cordova 6.1.1
> windows 4.3.2
>Reporter: Michael Schmidt
>Priority: Critical
>  Labels: windows
>
> *situation*
> - build.json built up as described in 
> http://cordova.apache.org/docs/en/latest/guide/platforms/win8/index.html#signing-an-app
> - windows 10 universal app
> - goal: create an .appxbundle file as described in 
> https://github.com/apache/cordova-windows/commit/eeda3df0711cee0ff7beb761aac33e18b534b5f0
> *problem: .appxbundle file is not generated*
> the command 
> {code}
> cordova build windows -- --archs="x86 x64 arm" --bundle
> {code}
> doesn't create an .appxbundle file
> same problem exists with release command
> {code}
> cordova build windows --release -- --archs="x86 x64 arm" 
> --buildConfig="build.json" --bundle
> {code}
> I want to upload to the store - what alternatives are there from the CLI?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11078) Empty string for BackgroundColor preference crashes application

[Akila Wickramarachchi (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405381#comment-15405381
 ] 

Akila Wickramarachchi commented on CB-11078:


This has been fixed can you change the In progress tag

> Empty string for BackgroundColor preference crashes application
> ---
>
> Key: CB-11078
> URL: https://issues.apache.org/jira/browse/CB-11078
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
> Environment: HTC One
> Android 6.0
> Cordova-Android 5.1.0
>Reporter: Ryan Willoughby
>Assignee: Jesse MacFadyen
>Priority: Minor
>  Labels: easyfix, triaged
>
> A preference of 
> {{}}
> will cause an a cordova application to crash on startup with a 
> NumberFormatException:
> {color:red}
> 04-13 11:18:29.894: E/AndroidRuntime(20224): java.lang.RuntimeException: 
> Unable to start activity 
> ComponentInfo{com.whatever.whatever/com.whatever.whatever.ClassName}: 
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2484)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2544)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.access$900(ActivityThread.java:150)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread$H.handleMessage(ActivityThread.java:1394)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.os.Handler.dispatchMessage(Handler.java:102)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.os.Looper.loop(Looper.java:168)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.main(ActivityThread.java:5845)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.reflect.Method.invoke(Native Method)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:797)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:687)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): Caused by: 
> java.lang.NumberFormatException: Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.Long.invalidLong(Long.java:124)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> java.lang.Long.decode(Long.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaPreferences.getInteger(CordovaPreferences.java:78)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.createViews(CordovaActivity.java:178)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.init(CordovaActivity.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> org.apache.cordova.CordovaActivity.loadUrl(CordovaActivity.java:214)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> uk.directpath.staffssmartalert2.StaffsSmartAlertv2.onCreate(StaffsSmartAlertv2.java:32)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.Activity.performCreate(Activity.java:6248)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1125)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  at 
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2437)
> 04-13 11:18:29.894: E/AndroidRuntime(20224):  ... 9 more
> {color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org