[jira] [Commented] (CB-12882) captureVideo doesn't close camera picker and doesn't show alert message about prohibited camera usage
[ https://issues.apache.org/jira/browse/CB-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045418#comment-16045418 ] ASF GitHub Bot commented on CB-12882: - Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/79 @filmaj could you please merge this if everything looks good? > captureVideo doesn't close camera picker and doesn't show alert message about > prohibited camera usage > - > > Key: CB-12882 > URL: https://issues.apache.org/jira/browse/CB-12882 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture >Affects Versions: 1.4.2 >Reporter: Sergii Stotskyi > Labels: ios > > *Steps to reproduce*: > # Create a simple application which calls `captureVideo()` method > # Deploy application to real device > # Click on button which starts video capturing > # Click "No" when it asks permissions for camera > *Expected result*: > camera picker is animated out. And every time when user clicks on capture > video alert is shown as in `cordova-plugin-camera`: Access to the camera has > been prohibited, please enable it in the Settings app to continue. And 2 > buttons are shown: OK, Settings > *Actual result*: > camera picker is not hidden. It's possible to click on record button and > record black screen. Eventually video is saved and viewed -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12908) Dismiss cordova native prompt on click of done button in the native keyboard
Kristian Tran created CB-12908: -- Summary: Dismiss cordova native prompt on click of done button in the native keyboard Key: CB-12908 URL: https://issues.apache.org/jira/browse/CB-12908 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-dialogs Environment: Android Reporter: Kristian Tran Priority: Minor Description - After entering a value in the cordova native dialog plugin prompt for android, when clicking on Go or Done or Enter button of the keyboard, instead of closing the native prompt, the cursor of the prompt field enters a new line. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11980) breakout modules in cordova-lib into their own repos
[ https://issues.apache.org/jira/browse/CB-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045211#comment-16045211 ] ASF subversion and git services commented on CB-11980: -- Commit d6c2a336af8fba85e65bbbde623f9eb0b021744f in cordova-coho's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=d6c2a33 ] CB-11980: updated path to cordova-lib > breakout modules in cordova-lib into their own repos > > > Key: CB-11980 > URL: https://issues.apache.org/jira/browse/CB-11980 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-common, cordova-fetch, cordova-lib, cordova-serve >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > This issue needs a cordova-discuss PR still. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10376) autofocus doesn't work with WKWebView engine plugin
[
https://issues.apache.org/jira/browse/CB-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045196#comment-16045196
]
ASF GitHub Bot commented on CB-10376:
-
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37/commits/e994874583d7e5f4ae1713643dbd8e01c60a0a03)
**Dashboard** -
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/23/)
2 tests run, 0 skipped, 0 failed.
> autofocus doesn't work with WKWebView engine plugin
> ---
>
> Key: CB-10376
> URL: https://issues.apache.org/jira/browse/CB-10376
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-wkwebview-engine
>Affects Versions: 5.4.1
> Environment: Tested on iPhone 6 plus and iPhone 5S both running iOS
> 9.2
>Reporter: David Douglas
>Assignee: Shazron Abdullah
>Priority: Minor
> Labels: iOS, triaged
>
> When using WKWebView engine the iOS Soft Keyboard fails to automatically open
> when the 'autofocus' attribute is set.
> How to recreate:
> 1. Add platform and keyboard plugin
> {code}
> cordova platform add ios@4.0.1
> cordova plugin add cordova-plugin-keyboard@1.1.3 --save
> {code}
> 2. Update iOS keyboard to enable focus commands in 'config.xml':
> {code}
>
> {code}
> 3. Add textarea to test with autofocus attribute.
> {code}
>
> {code}
> (Note: Before adding the WKWebView engine plugin the UIWebView will
> automatically open the Soft Keyboard.)
> 4. Add the WKWebView engine plugin
> {code}
> cordova plugin add cordova-plugin-wkwebview-engine@1.0.1 --save
> {code}
> What happens:
> Nothing.
> What should happen:
> The soft keyboard should open automatically (the same a UIWebView)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12883) Log invalid process object returned.
[ https://issues.apache.org/jira/browse/CB-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-12883. --- Resolution: Fixed > Log invalid process object returned. > > > Key: CB-12883 > URL: https://issues.apache.org/jira/browse/CB-12883 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: Master > Environment: iOS >Reporter: Rafael Gutierrez >Assignee: Shazron Abdullah >Priority: Trivial > Labels: patch > Fix For: cordova-ios@4.4.1 > > Original Estimate: 0h > Remaining Estimate: 0h > > Add additional logging when WKWebView && UIWebview evaulateJavascript process > fails to return valid json. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-12883) Log invalid process object returned.
[ https://issues.apache.org/jira/browse/CB-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah reassigned CB-12883: - Assignee: Shazron Abdullah > Log invalid process object returned. > > > Key: CB-12883 > URL: https://issues.apache.org/jira/browse/CB-12883 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: Master > Environment: iOS >Reporter: Rafael Gutierrez >Assignee: Shazron Abdullah >Priority: Trivial > Labels: patch > Fix For: cordova-ios@4.4.1 > > Original Estimate: 0h > Remaining Estimate: 0h > > Add additional logging when WKWebView && UIWebview evaulateJavascript process > fails to return valid json. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12887) cordova run --list does not show virtual devices in iOS 11
[
https://issues.apache.org/jira/browse/CB-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah resolved CB-12887.
---
Resolution: Fixed
> cordova run --list does not show virtual devices in iOS 11
> --
>
> Key: CB-12887
> URL: https://issues.apache.org/jira/browse/CB-12887
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: ios11
> Fix For: cordova-ios@4.4.1
>
>
> {code}
> $ cordova run --list
> Available ios devices:
> Available ios virtual devices:
> {code}
> I confirmed there are sims in Xcode 9 beta -> Window -> Devices and
> Simulators and {{xcrun simctl list}} showed devices.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12883) Log invalid process object returned.
[ https://issues.apache.org/jira/browse/CB-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045187#comment-16045187 ] ASF GitHub Bot commented on CB-12883: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/317 > Log invalid process object returned. > > > Key: CB-12883 > URL: https://issues.apache.org/jira/browse/CB-12883 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: Master > Environment: iOS >Reporter: Rafael Gutierrez >Assignee: Shazron Abdullah >Priority: Trivial > Labels: patch > Fix For: cordova-ios@4.4.1 > > Original Estimate: 0h > Remaining Estimate: 0h > > Add additional logging when WKWebView && UIWebview evaulateJavascript process > fails to return valid json. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12887) cordova run --list does not show virtual devices in iOS 11
[
https://issues.apache.org/jira/browse/CB-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045183#comment-16045183
]
ASF GitHub Bot commented on CB-12887:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/318
> cordova run --list does not show virtual devices in iOS 11
> --
>
> Key: CB-12887
> URL: https://issues.apache.org/jira/browse/CB-12887
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: ios11
> Fix For: cordova-ios@4.4.1
>
>
> {code}
> $ cordova run --list
> Available ios devices:
> Available ios virtual devices:
> {code}
> I confirmed there are sims in Xcode 9 beta -> Window -> Devices and
> Simulators and {{xcrun simctl list}} showed devices.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12887) cordova run --list does not show virtual devices in iOS 11
[
https://issues.apache.org/jira/browse/CB-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045182#comment-16045182
]
ASF subversion and git services commented on CB-12887:
--
Commit 8e74760abc5b9cd76ab5306f951eb3baf196b49e in cordova-ios's branch
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=8e74760 ]
CB-12887 - cordova run --list does not show virtual devices in iOS 11
This closes #318
> cordova run --list does not show virtual devices in iOS 11
> --
>
> Key: CB-12887
> URL: https://issues.apache.org/jira/browse/CB-12887
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: ios11
> Fix For: cordova-ios@4.4.1
>
>
> {code}
> $ cordova run --list
> Available ios devices:
> Available ios virtual devices:
> {code}
> I confirmed there are sims in Xcode 9 beta -> Window -> Devices and
> Simulators and {{xcrun simctl list}} showed devices.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10376) autofocus doesn't work with WKWebView engine plugin
[
https://issues.apache.org/jira/browse/CB-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045177#comment-16045177
]
ASF GitHub Bot commented on CB-10376:
-
GitHub user ccorcos opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
CB-10376: (ios) Fix bug where WKWebView doesnt respect the
KeyboardDisplayRequiresUserAction setting
### Platforms affected
- iOS
### What does this PR do?
This PR does some magic to allow `.focus()` to bring up the keyboard in
WKWebView. I read about this approach in a few places and saw [this
commit](https://github.com/Telerik-Verified-Plugins/WKWebView/commit/04e8296adeb61f289f9c698045c19b62d080c7e3)
in another plugin. From what I understand, its basically accessing a private
method in WKWebView.
### What testing has been done on this change?
Using it on my iPhone 7 and in the Simulator and it definitely works :) I'm
not a native developer so I could use some guidance getting this PR to the
point where its mergeable. But its definitely useful and absolutely necessary
for [the app I'm building](www.notion.so).
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
commit e994874583d7e5f4ae1713643dbd8e01c60a0a03
Author: Chet Corcos
Date: 2017-06-09T22:42:25Z
Patch KeyboardDisplayRequiresUserAction
> autofocus doesn't work with WKWebView engine plugin
> ---
>
> Key: CB-10376
> URL: https://issues.apache.org/jira/browse/CB-10376
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-wkwebview-engine
>Affects Versions: 5.4.1
> Environment: Tested on iPhone 6 plus and iPhone 5S both running iOS
> 9.2
>Reporter: David Douglas
>Assignee: Shazron Abdullah
>Priority: Minor
> Labels: iOS, triaged
>
> When using WKWebView engine the iOS Soft Keyboard fails to automatically open
> when the 'autofocus' attribute is set.
> How to recreate:
> 1. Add platform and keyboard plugin
> {code}
> cordova platform add ios@4.0.1
> cordova plugin add cordova-plugin-keyboard@1.1.3 --save
> {code}
> 2. Update iOS keyboard to enable focus commands in 'config.xml':
> {code}
>
> {code}
> 3. Add textarea to test with autofocus attribute.
> {code}
>
> {code}
> (Note: Before adding the WKWebView engine plugin the UIWebView will
> automatically open the Soft Keyboard.)
> 4. Add the WKWebView engine plugin
> {code}
> cordova plugin add cordova-plugin-wkwebview-engine@1.0.1 --save
> {code}
> What happens:
> Nothing.
> What should happen:
> The soft keyboard should open automatically (the same a UIWebView)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio
[ https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045130#comment-16045130 ] ASF GitHub Bot commented on CB-11244: - GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/384 CB-11244: Studio project cleanup ### Platforms affected Android ### What does this PR do? Modernizes Android and makes it so we can do Modern Android Development ### What testing has been done on this change? * Manual Testing with Plugman * Dev against e2e tests (upgrade still fails, help plz) * Talked to Fil regarding JUnit Test running ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android StudioProjectCleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #384 commit 6167130bac0630f8a8359ed491381caa7da45871 Author: Joe Bowser Date: 2017-03-30T19:41:44Z Adding the Studio Builder to build a project based on Android Studio, and deleting Ant, since Google does not support Ant Builds anymore. Sorry guys! commit 2ef15bd2172f265c44b8447a8e2f119d1590fda3 Author: Joe Bowser Date: 2017-03-30T20:38:18Z Moving Android Manifest finding to the Gradle and Studio builders. commit 09a4ed45ec2c959a5424c85d1e3df04f344eb664 Author: Joe Bowser Date: 2017-04-03T22:21:48Z Changing this so we pass lint commit 5a40dcd86ed8bd21ca611a66ee13170bed099739 Author: Joe Bowser Date: 2017-04-04T20:38:40Z Fixing linting issues commit 3795b65bced7c8634cade5f00bfe2d42349250c9 Author: Joe Bowser Date: 2017-04-04T22:18:46Z Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle commit f2396de53e250cd0ad9b8bb2020ce11eaef16ffe Author: Joe Bowser Date: 2017-04-04T22:34:42Z Updating gradle version in the build file commit 02c07de746b39a587613b531e3fbdcb833d442e9 Author: Joe Bowser Date: 2017-04-04T22:42:58Z Managed to get the project to mostly compile, still need to re-work the build command to add the app project commit c8f328fe2a9b6d05ad543b32989182bb612e9d0a Author: Joe Bowser Date: 2017-04-11T20:47:40Z Made changes so cordova/build builds with the new project. Need to work on plugin installation. commit 7db18f8b361369d10237f5159154dbae3f0c3f4d Author: Joe Bowser Date: 2017-04-11T21:41:27Z Fix the overwriting of Fil's fix, blargh commit cc2d1fd9ae59e5aca10ff5271ef637b6b6897eee Author: Joe Bowser Date: 2017-01-04T19:48:18Z CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback commit 844dc7f3df7f830cf562535ef9f5f5fc15471ca1 Author: Joe Bowser Date: 2017-04-18T21:29:02Z Changing the project to add the app directory as a dependency commit 2df146df4f918067eb325ca1d50639045f5003ed Author: Joe Bowser Date: 2017-04-18T21:48:56Z JsHint Fixes, deleting unused methods commit c1ea8ec88576586a7385dd06d5d62897f9142b4e Author: Joe Bowser Date: 2017-04-19T18:50:55Z Fixed the specification of the builders in the run command by getting build to check what was being passed from run commit 17416dfd1df16da9b4c0715ec6280961c7b9d91b Author: Joe Bowser Date: 2017-04-21T23:27:26Z Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova commit e30968e15a8aadbc6cc20d4b483f27f1c580ac15 Author: Joe Bowser Date: 2017-04-22T00:02:27Z Updated AndroidStudio to only look for the app directory to determine studio status commit a17a5b891f98417d149bacbf8307412fa8c03a34 Author: Joe Bowser Date: 2017-05-31T17:23:35Z CB-11244: Setup Api.js to support multiple builders based on project structure commit a5ca7089eaa2e8825dca9f7c2140c2f62b5d618c Author: Joe Bowser Date: 2017-05-31T17:37:47Z Fixing lint errors > Update Android Project Structure to be more compatible with Android Studio > -- > > Key: CB-11244 > URL: https://issues.apache.org/jira/browse/CB-11244 >
[jira] [Created] (CB-12907) Camera plugin does not work after Android 7 update
Joseph Chavarria created CB-12907: - Summary: Camera plugin does not work after Android 7 update Key: CB-12907 URL: https://issues.apache.org/jira/browse/CB-12907 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Reporter: Joseph Chavarria Priority: Critical I had an app that use the cam, it was working correctly but the users updated their celphone to android 7 and the app crashed in the moment when the cam is going to be opened. Could you help me please?, it is urgent for me. Thanks. Joseph Chavarria -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12728) Device Orientation - SUNSET
[ https://issues.apache.org/jira/browse/CB-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045018#comment-16045018 ] ASF GitHub Bot commented on CB-12728: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/36 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-device-orientation/pull/36/commits/d9e90ca870ec9a12e2d8fd1cedfea8c5f025e4de) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/26/) 66 tests run, 9 skipped, 0 failed. > Device Orientation - SUNSET > --- > > Key: CB-12728 > URL: https://issues.apache.org/jira/browse/CB-12728 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-orientation >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12726) Device Motion - SUNSET
[ https://issues.apache.org/jira/browse/CB-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045014#comment-16045014 ] ASF GitHub Bot commented on CB-12726: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-motion/pull/53 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-device-motion/pull/53/commits/dfcddf0ff2788e39c31df46ba0554bd201e2b405) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-motion-pr/34/) 72 tests run, 22 skipped, 0 failed. > Device Motion - SUNSET > -- > > Key: CB-12726 > URL: https://issues.apache.org/jira/browse/CB-12726 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-motion >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12726) Device Motion - SUNSET
[ https://issues.apache.org/jira/browse/CB-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045000#comment-16045000 ] ASF GitHub Bot commented on CB-12726: - Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-device-motion/pull/53 lgtm When we publish it next, we should also deprecate it in npm land. https://docs.npmjs.com/cli/deprecate > Device Motion - SUNSET > -- > > Key: CB-12726 > URL: https://issues.apache.org/jira/browse/CB-12726 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-motion >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12728) Device Orientation - SUNSET
[ https://issues.apache.org/jira/browse/CB-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044999#comment-16044999 ] ASF GitHub Bot commented on CB-12728: - Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/36 lgtm When we publish it next, we should also deprecate it in npm land. https://docs.npmjs.com/cli/deprecate > Device Orientation - SUNSET > --- > > Key: CB-12728 > URL: https://issues.apache.org/jira/browse/CB-12728 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-orientation >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12728) Device Orientation - SUNSET
[ https://issues.apache.org/jira/browse/CB-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044971#comment-16044971 ] ASF GitHub Bot commented on CB-12728: - GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/36 CB-12728: Device Orientation - SUNSET ### Platforms affected All ### What does this PR do? Add's deprecation notice to the repo ### What testing has been done on this change? n/a ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/macdonst/cordova-plugin-device-orientation deprecated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-orientation/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit d9e90ca870ec9a12e2d8fd1cedfea8c5f025e4de Author: Simon MacDonald Date: 2017-06-09T20:13:42Z CB-12728: Device Orientation - SUNSET > Device Orientation - SUNSET > --- > > Key: CB-12728 > URL: https://issues.apache.org/jira/browse/CB-12728 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-orientation >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12726) Device Motion - SUNSET
[ https://issues.apache.org/jira/browse/CB-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044972#comment-16044972 ] ASF GitHub Bot commented on CB-12726: - GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/53 CB-12726: Device Motion - SUNSET ### Platforms affected All ### What does this PR do? Add's deprecation notice to the repo ### What testing has been done on this change? n/a ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/macdonst/cordova-plugin-device-motion deprecated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit dfcddf0ff2788e39c31df46ba0554bd201e2b405 Author: Simon MacDonald Date: 2017-06-09T20:22:53Z CB-12726: Device Motion - SUNSET > Device Motion - SUNSET > -- > > Key: CB-12726 > URL: https://issues.apache.org/jira/browse/CB-12726 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-motion >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-11373) config.xml options not documented: android-packageName, android-activityName, ios-CFBundleIdentifier
[ https://issues.apache.org/jira/browse/CB-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044940#comment-16044940 ] Shazron Abdullah edited comment on CB-11373 at 6/9/17 8:09 PM: --- https://github.com/apache/cordova-ios/blob/a9532aed061ede7f322ab4d6843dcb8e235fce9e/bin/templates/scripts/cordova/lib/prepare.js#L194-L202 ios-CFBundleIdentifier is an alias for "id" but would override id if set, for the reasons you outlined above. It would be more clear if it was "ios-packageName" here, like android. was (Author: shazron): https://github.com/apache/cordova-ios/blob/a9532aed061ede7f322ab4d6843dcb8e235fce9e/bin/templates/scripts/cordova/lib/prepare.js#L194-L202 ios-CFBundleIdentifier is an alias for "id" but would override id if set, for the reasons you outlined above. > config.xml options not documented: android-packageName, android-activityName, > ios-CFBundleIdentifier > > > Key: CB-11373 > URL: https://issues.apache.org/jira/browse/CB-11373 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Affects Versions: 6.2.0 >Reporter: Frederico Costa Galvão > Labels: Android, documentation, iOS, triaged > > None of these options \[1\] are currently documented \[2\]. > I wonder how many of those hidden settings are there. > \[1\] > https://github.com/apache/cordova-lib/blob/9f630271d9c02824c0031ea4cdc0e4955b53d9e2/cordova-common/src/ConfigParser/ConfigParser.js#L99-L107 > \[2\] https://cordova.apache.org/docs/en/latest/config_ref/index.html > (visited @ 03/06/2016 23:00:00 UTC) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11373) config.xml options not documented: android-packageName, android-activityName, ios-CFBundleIdentifier
[ https://issues.apache.org/jira/browse/CB-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044940#comment-16044940 ] Shazron Abdullah commented on CB-11373: --- https://github.com/apache/cordova-ios/blob/a9532aed061ede7f322ab4d6843dcb8e235fce9e/bin/templates/scripts/cordova/lib/prepare.js#L194-L202 ios-CFBundleIdentifier is an alias for "id" but would override id if set, for the reasons you outlined above. > config.xml options not documented: android-packageName, android-activityName, > ios-CFBundleIdentifier > > > Key: CB-11373 > URL: https://issues.apache.org/jira/browse/CB-11373 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Affects Versions: 6.2.0 >Reporter: Frederico Costa Galvão > Labels: Android, documentation, iOS, triaged > > None of these options \[1\] are currently documented \[2\]. > I wonder how many of those hidden settings are there. > \[1\] > https://github.com/apache/cordova-lib/blob/9f630271d9c02824c0031ea4cdc0e4955b53d9e2/cordova-common/src/ConfigParser/ConfigParser.js#L99-L107 > \[2\] https://cordova.apache.org/docs/en/latest/config_ref/index.html > (visited @ 03/06/2016 23:00:00 UTC) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11373) config.xml options not documented: android-packageName, android-activityName, ios-CFBundleIdentifier
[ https://issues.apache.org/jira/browse/CB-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-11373: -- Component/s: cordova-docs > config.xml options not documented: android-packageName, android-activityName, > ios-CFBundleIdentifier > > > Key: CB-11373 > URL: https://issues.apache.org/jira/browse/CB-11373 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Affects Versions: 6.2.0 >Reporter: Frederico Costa Galvão > Labels: Android, documentation, iOS, triaged > > None of these options \[1\] are currently documented \[2\]. > I wonder how many of those hidden settings are there. > \[1\] > https://github.com/apache/cordova-lib/blob/9f630271d9c02824c0031ea4cdc0e4955b53d9e2/cordova-common/src/ConfigParser/ConfigParser.js#L99-L107 > \[2\] https://cordova.apache.org/docs/en/latest/config_ref/index.html > (visited @ 03/06/2016 23:00:00 UTC) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12906) Embed Youtube iFrames - fullscreen no video on Android.
Shawn Lan created CB-12906: -- Summary: Embed Youtube iFrames - fullscreen no video on Android. Key: CB-12906 URL: https://issues.apache.org/jira/browse/CB-12906 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova@7.0.0 Environment: Cordova Android 6.2.3 Android 7 Reporter: Shawn Lan With the iFrame embed code of a Youtube video: https://www.youtube.com/embed/cuLprHh_BRg"; frameborder="0" allowfullscreen> On iOS, going fullscreen is not a problem. However, on Android, the screen becomes black. No video. Only audio. Only very few times it worked (not sure how), but most of the time it was a black screen. Tested on a real device. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12869) Update bundled ios-sim to 5.0.13
[ https://issues.apache.org/jira/browse/CB-12869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044854#comment-16044854 ] ASF subversion and git services commented on CB-12869: -- Commit 2d405c49e63b1ba4be05719ce51c489d097cf172 in cordova-ios's branch refs/heads/4.4.0-ios-sim from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=2d405c4 ] CB-12869 - Update bundled ios-sim to 5.0.13 This closes #314 > Update bundled ios-sim to 5.0.13 > > > Key: CB-12869 > URL: https://issues.apache.org/jira/browse/CB-12869 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.1 > > > To fix this issue https://github.com/phonegap/ios-sim/issues/203 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11373) config.xml options not documented: android-packageName, android-activityName, ios-CFBundleIdentifier
[
https://issues.apache.org/jira/browse/CB-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044817#comment-16044817
]
Jacob Weber commented on CB-11373:
--
Possibly related: are these options actually used everywhere they should be?
For example, when you run {{cordova prepare}}, it prints:
{code}
Creating Cordova project for the Android platform:
Path: platforms/android
Package: foo
...
Creating Cordova project for the Android platform:
Path: platforms/ios
Package: foo
{code}
where "foo" is the "id" value, even if there's a different value for
"ios-CFBundleIdentifier" and "android-packageName". Maybe this is just an issue
with the debug output, though.
> config.xml options not documented: android-packageName, android-activityName,
> ios-CFBundleIdentifier
>
>
> Key: CB-11373
> URL: https://issues.apache.org/jira/browse/CB-11373
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: 6.2.0
>Reporter: Frederico Costa Galvão
> Labels: Android, documentation, iOS, triaged
>
> None of these options \[1\] are currently documented \[2\].
> I wonder how many of those hidden settings are there.
> \[1\]
> https://github.com/apache/cordova-lib/blob/9f630271d9c02824c0031ea4cdc0e4955b53d9e2/cordova-common/src/ConfigParser/ConfigParser.js#L99-L107
> \[2\] https://cordova.apache.org/docs/en/latest/config_ref/index.html
> (visited @ 03/06/2016 23:00:00 UTC)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[ https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044708#comment-16044708 ] ASF GitHub Bot commented on CB-12905: - Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-browser/pull/31 Also, I think you need to send this PR in the cordova-serve (https://github.com/apache/cordova-serve) > LaunchBrowser promise in linux, not resolved until the browser process > terminates. > -- > > Key: CB-12905 > URL: https://issues.apache.org/jira/browse/CB-12905 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser, cordova-serve >Affects Versions: 6.5.0, 7.0.1 > Environment: OS: Ubuntu 16.04.2 LTS > cordova: 6.5.0 > simulate: 0.3.12 > node: v7.10.0 > npm: 4.6.1 >Reporter: Pavel Yakovlev >Priority: Minor > > LaunchBrowser promise in linux, not resolved until the browser process > terminates. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[
https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044666#comment-16044666
]
ASF GitHub Bot commented on CB-12905:
-
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171981
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports = function (cmd, opt_cwd) {
var d = Q.defer();
try {
+// In Linux, the callback is not called until the process
terminates.
+// If the error is not caused within 2 seconds, then the promise
will be resolved.
+var timer = setTimeout(() => {
+if (process.platform == 'linux') {
+d.resolve('timeout');
+}
+}, 2000);
child_process.exec(cmd, {cwd: opt_cwd, maxBuffer: 1024000},
function (err, stdout, stderr) {
--- End diff --
Were you able to figure out why callback is not called?
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
> --
>
> Key: CB-12905
> URL: https://issues.apache.org/jira/browse/CB-12905
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-serve
>Affects Versions: 6.5.0, 7.0.1
> Environment: OS: Ubuntu 16.04.2 LTS
> cordova: 6.5.0
> simulate: 0.3.12
> node: v7.10.0
> npm: 4.6.1
>Reporter: Pavel Yakovlev
>Priority: Minor
>
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[
https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044663#comment-16044663
]
ASF GitHub Bot commented on CB-12905:
-
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171609
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports = function (cmd, opt_cwd) {
var d = Q.defer();
try {
+// In Linux, the callback is not called until the process
terminates.
+// If the error is not caused within 2 seconds, then the promise
will be resolved.
+var timer = setTimeout(() => {
+if (process.platform == 'linux') {
--- End diff --
use `===` instead of `==`
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
> --
>
> Key: CB-12905
> URL: https://issues.apache.org/jira/browse/CB-12905
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-serve
>Affects Versions: 6.5.0, 7.0.1
> Environment: OS: Ubuntu 16.04.2 LTS
> cordova: 6.5.0
> simulate: 0.3.12
> node: v7.10.0
> npm: 4.6.1
>Reporter: Pavel Yakovlev
>Priority: Minor
>
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[
https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044660#comment-16044660
]
ASF GitHub Bot commented on CB-12905:
-
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171521
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports = function (cmd, opt_cwd) {
var d = Q.defer();
try {
+// In Linux, the callback is not called until the process
terminates.
+// If the error is not caused within 2 seconds, then the promise
will be resolved.
+var timer = setTimeout(() => {
--- End diff --
Should we call `setTimeout` for Windows and OSX?
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
> --
>
> Key: CB-12905
> URL: https://issues.apache.org/jira/browse/CB-12905
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-serve
>Affects Versions: 6.5.0, 7.0.1
> Environment: OS: Ubuntu 16.04.2 LTS
> cordova: 6.5.0
> simulate: 0.3.12
> node: v7.10.0
> npm: 4.6.1
>Reporter: Pavel Yakovlev
>Priority: Minor
>
> LaunchBrowser promise in linux, not resolved until the browser process
> terminates.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
[ https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044463#comment-16044463 ] ASF GitHub Bot commented on CB-12905: - GitHub user paymicro opened a pull request: https://github.com/apache/cordova-browser/pull/31 CB-12905: (linux) Fix issue with freezing after launching the browser In Linux, the callback is not called until the process terminates. If the error is not caused within 2 seconds, then the promise will be resolved. ### Platforms affected - Linux ### What does this PR do? - If the [error after launching the browser](https://github.com/Microsoft/cordova-simulate/issues/245) is not caused within 2 seconds, then the promise will be resolved. ### What testing has been done on this change? - manual testing launching browsers in Linux, Windows and MacOs ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/paymicro/cordova-browser Bugs/bug446896-simulate-in-linux Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit 17ca6c585afab25b68e868ecc0a13e55e803dc40 Author: Pavel Yakovlev (Akvelon) Date: 2017-06-09T13:13:19Z In Linux, the callback is not called until the process terminates. If the error is not caused within 2 seconds, then the promise will be resolved. > LaunchBrowser promise in linux, not resolved until the browser process > terminates. > -- > > Key: CB-12905 > URL: https://issues.apache.org/jira/browse/CB-12905 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser, cordova-serve >Affects Versions: 6.5.0, 7.0.1 > Environment: OS: Ubuntu 16.04.2 LTS > cordova: 6.5.0 > simulate: 0.3.12 > node: v7.10.0 > npm: 4.6.1 >Reporter: Pavel Yakovlev >Priority: Minor > > LaunchBrowser promise in linux, not resolved until the browser process > terminates. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12901) Remove lazy loading of node modules from cordova tooling
[
https://issues.apache.org/jira/browse/CB-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044462#comment-16044462
]
Filip Maj commented on CB-12901:
FYI I have a branch with this in progress here:
https://github.com/filmaj/cordova-lib/tree/no-lazy-load
> Remove lazy loading of node modules from cordova tooling
>
>
> Key: CB-12901
> URL: https://issues.apache.org/jira/browse/CB-12901
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-common, cordova-lib
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> There are various {{addProperty*}} methods that execute {{require}} at
> runtime. While this improves load time and only loads modules that are
> necessary, it also makes it harder to test, as spying and mocking is more
> difficult.
> The 300ms load time improvement, in the best case, is not worth the
> difficulty in writing unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
Pavel Yakovlev created CB-12905: --- Summary: LaunchBrowser promise in linux, not resolved until the browser process terminates. Key: CB-12905 URL: https://issues.apache.org/jira/browse/CB-12905 Project: Apache Cordova Issue Type: Bug Components: cordova-browser, cordova-serve Affects Versions: 6.5.0, 7.0.1 Environment: OS: Ubuntu 16.04.2 LTS cordova: 6.5.0 simulate: 0.3.12 node: v7.10.0 npm: 4.6.1 Reporter: Pavel Yakovlev Priority: Minor LaunchBrowser promise in linux, not resolved until the browser process terminates. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
