[jira] [Commented] (CB-12886) white area where status bar is in iOS 11

2017-07-04 Thread Darryl Pogue (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074168#comment-16074168
 ] 

Darryl Pogue commented on CB-12886:
---

See also 
https://github.com/WebKit/webkit/commit/52ec9f74f64da8fde4b21783b0b457d30897e3db
 (unreleased in a beta so far)

> white area where status bar is in iOS 11
> 
>
> Key: CB-12886
> URL: https://issues.apache.org/jira/browse/CB-12886
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>  Labels: ios11
> Fix For: cordova-ios@5.0.0
>
> Attachments: ios11.png
>
>
> See attached screenshot. Using WKWebView plugin, new app.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12985) Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string

2017-07-04 Thread Jan Piotrowski (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski updated CB-12985:

Description: 
`InAppBrowser.open(url, target, options)` currently expects `options` to be a 
string, formatted in a special way (no spaces).
It would be much easier to maintain this if `options` would be a plain 
Javascript object.

The yes|no values could be changed to true|false of course.

(During this change all options should probably also be unified to use 
camelCase)

  was:
`InAppBrowser.open(url, target, options)` currently expects `options` to be a 
string, formatted in a special way (no spaces). It would be much easier to 
maintain this if `options` would be a plain Javascript object.

The yes|no values could be changed to true|false of course.

(During this change all options should probably also be unified to use 
camelCase)


> Change `InAppBrowser.open(url, target, options)` to get `options` as object, 
> not string
> ---
>
> Key: CB-12985
> URL: https://issues.apache.org/jira/browse/CB-12985
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Jan Piotrowski
>
> `InAppBrowser.open(url, target, options)` currently expects `options` to be a 
> string, formatted in a special way (no spaces).
> It would be much easier to maintain this if `options` would be a plain 
> Javascript object.
> The yes|no values could be changed to true|false of course.
> (During this change all options should probably also be unified to use 
> camelCase)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-12985) Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string

2017-07-04 Thread Jan Piotrowski (JIRA)
Jan Piotrowski created CB-12985:
---

 Summary: Change `InAppBrowser.open(url, target, options)` to get 
`options` as object, not string
 Key: CB-12985
 URL: https://issues.apache.org/jira/browse/CB-12985
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-inappbrowser
Reporter: Jan Piotrowski


`InAppBrowser.open(url, target, options)` currently expects `options` to be a 
string, formatted in a special way (no spaces). It would be much easier to 
maintain this if `options` would be a plain Javascript object.

The yes|no values could be changed to true|false of course.

(During this change all options should probably also be unified to use 
camelCase)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12636) Support of Visual Studio 2017

2017-07-04 Thread Stephan Wolf (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073776#comment-16073776
 ] 

Stephan Wolf commented on CB-12636:
---

Hello,

cordova-windows should use one of the solution described here: 
https://blogs.msdn.microsoft.com/heaths/2016/09/15/changes-to-visual-studio-15-setup/

from my point of view a solution using the vswhere.exe should be enough.

Regards,
Stephan

> Support of Visual Studio 2017
> -
>
> Key: CB-12636
> URL: https://issues.apache.org/jira/browse/CB-12636
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-windows
>Affects Versions: 6.5.0
> Environment: Windows 10
>Reporter: Marco Paland
>
> Please add support for Visual Studio 2017.
> On a Windows 10 machine I installed VS2017 (no other VS). Upon compiling a 
> cordova project I get:
> {code}
> > cordova build windows --verbose
> No scripts found for hook "before_build".
> No scripts found for hook "before_prepare".
> Checking config.xml for saved platforms that haven't been added to the project
> Checking for any plugins added to the project that have not been installed in 
> windows platform
> No differences found between plugins added to project and installed in 
> windows platform. Continuing...
> Generating platform-specific config.xml from defaults for windows at 
> C:\Users\Marco\Documents\Visual Studio 
> 2017\Projects\BlankCordovaApp1\BlankCordovaApp1\platforms\windows\config.xml
> Merging project's config.xml into platform-specific windows config.xml
> Found "merges/windows" folder. Copying its contents into the windows project.
> Merging and updating files from [www, platforms\windows\platform_www, 
> merges\windows] to platforms\windows\www
>   copy  platforms\windows\platform_www\cordova-js-src\confighelper.js 
> platforms\windows\www\cordova-js-src\confighelper.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\exec.js 
> platforms\windows\www\cordova-js-src\exec.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\platform.js 
> platforms\windows\www\cordova-js-src\platform.js (updated file)
>   copy  platforms\windows\platform_www\cordova-js-src\splashscreen.js 
> platforms\windows\www\cordova-js-src\splashscreen.js (updated file)
>   copy  platforms\windows\platform_www\cordova_plugins.js 
> platforms\windows\www\cordova_plugins.js (updated file)
>   copy  www\css\index.css platforms\windows\www\css\index.css (updated file)
>   copy  www\index.html platforms\windows\www\index.html (updated file)
> Updating icons and splash screens at platforms\windows\images
> Prepared windows project successfully
> No scripts found for hook "pre_package".
> No scripts found for hook "after_prepare".
> Checking config.xml for saved plugins that haven't been added to the project
> No scripts found for hook "before_compile".
> Reading build config file: C:\Users\Marco\Documents\Visual Studio 
> 2017\Projects\BlankCordovaApp1\BlankCordovaApp1\build.json
> Searching for available MSBuild versions...
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\15.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\14.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\12.0 /v MSBuildToolsPath
> Running command: C:\WINDOWS\system32\reg.exe query 
> HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0 /v MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\12.0,/v,MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\14.0,/v,MSBuildToolsPath
> Command finished with error code 1: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\15.0,/v,MSBuildToolsPath
> Command finished with error code 0: C:\WINDOWS\system32\reg.exe 
> query,HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0,/v,MSBuildToolsPath
> Found MSBuild v4.0 at C:\Windows\Microsoft.NET\Framework64\v4.0.30319\
> MSBuild v4.0 is not supported, aborting.
> Error: Package with specified parameters not found in AppPackages folder
> {code}
> The requirement check shows:
> {code}
> > cordova requirements windows
> Requirements check results for windows:
> Windows OS: installed Windows 10
> MSBuild Tools: not installed
> MSBuild tools v.14.0 not found. Please install Visual Studio 2015 Community 
> from https://www.visualstudio.com/downloads/download-visual-studio-vs
> Visual Studio: not installed
> Required version of Visual Studio not found. Please install Visual Studio 
> 2015 Community from 
> https://www.visualst

[jira] [Commented] (CB-12984) Add Android versions to "supported" table in cordova-android docs

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073683#comment-16073683
 ] 

ASF GitHub Bot commented on CB-12984:
-

GitHub user janpio opened a pull request:

https://github.com/apache/cordova-docs/pull/714

CB-12984: (docs) Add Android versions to "supported" table in 
cordova-android docs

### Platforms affected
n/a, docs only change

### What does this PR do?
I added the supported Android versions to the ordova-android table. Source 
for API Level <-> Android Version was 
https://developer.android.com/guide/topics/manifest/uses-sdk-element.html#api-level-table
 and should be pretty solid.

### What testing has been done on this change?
n/a

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- n/a Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/janpio/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #714


commit 139a0427b1e2a2fb0295177143bd60b0dcfb0c19
Author: Jan Piotrowski 
Date:   2017-07-04T13:45:51Z

add supported Android versions to cordova-android table

Source for API Level <-> Android Version: 
https://developer.android.com/guide/topics/manifest/uses-sdk-element.html#api-level-table




> Add Android versions to "supported" table in cordova-android docs
> -
>
> Key: CB-12984
> URL: https://issues.apache.org/jira/browse/CB-12984
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-docs
>Reporter: Jan Piotrowski
>Assignee: Joe Bowser
>Priority: Minor
>
> Right now the docs only list cordova-android versions and their supporter API 
> level. Most users are interested in for which Android version the can 
> actually build with their cordova-android version, so I added this 
> information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-12984) Add Android versions to "supported" table in cordova-android docs

2017-07-04 Thread Jan Piotrowski (JIRA)
Jan Piotrowski created CB-12984:
---

 Summary: Add Android versions to "supported" table in 
cordova-android docs
 Key: CB-12984
 URL: https://issues.apache.org/jira/browse/CB-12984
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-android, cordova-docs
Reporter: Jan Piotrowski
Assignee: Joe Bowser
Priority: Minor


Right now the docs only list cordova-android versions and their supporter API 
level. Most users are interested in for which Android version the can actually 
build with their cordova-android version, so I added this information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12888) cordova emulate ios doesn't work in iOS 11

2017-07-04 Thread Jan Piotrowski (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073277#comment-16073277
 ] 

Jan Piotrowski edited comment on CB-12888 at 7/4/17 11:50 AM:
--

There are multiple reports of this happening with Xcode 8.x:
https://forum.ionicframework.com/t/no-target-specified-for-emulator-deploying-to-iphone-se-10-3-simulator/96588
https://forum.ionicframework.com/t/ionic-emulate-ios-target-device-errors/96278
https://forum.ionicframework.com/t/ionic-xcode-version-8-3-3-change-default-simulator/95966
https://github.com/ionic-team/ionic-cli/issues/2487

Same problem or unrelated?


was (Author: sujan12):
There are multiple reports of this happening with Xcode 8.x:
https://forum.ionicframework.com/t/no-target-specified-for-emulator-deploying-to-iphone-se-10-3-simulator/96588
https://forum.ionicframework.com/t/ionic-emulate-ios-target-device-errors/96278
https://forum.ionicframework.com/t/ionic-xcode-version-8-3-3-change-default-simulator/95966
https://github.com/ionic-team/ionic-cli/issues/2487

Same problem?

> cordova emulate ios doesn't work in iOS 11
> --
>
> Key: CB-12888
> URL: https://issues.apache.org/jira/browse/CB-12888
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>  Labels: ios11
> Fix For: cordova-ios@5.0.0
>
>
> Even with target:
> {code}
> $ cordova emulate ios --target="iPhone 6"
> Error: Cannot read property 'name' of undefined
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12593) FileProvider conflict in the camera plugin

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073520#comment-16073520
 ] 

ASF GitHub Bot commented on CB-12593:
-

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/275
  
Can you please rebase or just close/reopen the PR so the tests would 
restart?

We are not able to restart them manually at the moment.


> FileProvider conflict in the camera plugin
> --
>
> Key: CB-12593
> URL: https://issues.apache.org/jira/browse/CB-12593
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: Connor Pearson
>
> Version 2.3.1 of the camera plugin adds a FileProvider to the 
> AndroidManifest. I already have a plugin that is doing this, so the duplicate 
> entries cause a build error.
> {code}
> Element provider#android.support.v4.content.FileProvider at 
> AndroidManifest.xml:19:9-21:20 duplicated with element declared at 
> AndroidManifest.xml:16:9-18:20
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-12964) When Pictures folder does not exist, plugin cannot take a photo.

2017-07-04 Thread Alexander Sorokin (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin closed CB-12964.
--
Resolution: Fixed

> When Pictures folder does not exist, plugin cannot take a photo.
> 
>
> Key: CB-12964
> URL: https://issues.apache.org/jira/browse/CB-12964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android
>Reporter: José Luis Ballesteros del Val
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If someone has removed Pictures folder in android, plugin fails trying to 
> move there the new photo. This happens because plugin does not check the 
> existence of this folder, and if not, it does not complete the folder tree.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12964) When Pictures folder does not exist, plugin cannot take a photo.

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073482#comment-16073482
 ] 

ASF GitHub Bot commented on CB-12964:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/273


> When Pictures folder does not exist, plugin cannot take a photo.
> 
>
> Key: CB-12964
> URL: https://issues.apache.org/jira/browse/CB-12964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android
>Reporter: José Luis Ballesteros del Val
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If someone has removed Pictures folder in android, plugin fails trying to 
> move there the new photo. This happens because plugin does not check the 
> existence of this folder, and if not, it does not complete the folder tree.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12964) When Pictures folder does not exist, plugin cannot take a photo.

2017-07-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073481#comment-16073481
 ] 

ASF subversion and git services commented on CB-12964:
--

Commit 3b8f64e330df7f1b9d5088fd1a3f7f3e6193c83c in cordova-plugin-camera's 
branch refs/heads/master from [~joseluisballesterosdelval]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=3b8f64e 
]

CB-12964: (android) Fix of bug when Pictures folder did not exist.

If someone had removed Pictures folder in android, plugin failed trying to move 
there the new photo. This happened because plugin did not check the existence 
of this folder, and if not, it did not complete the folder tree.

This closes #273


> When Pictures folder does not exist, plugin cannot take a photo.
> 
>
> Key: CB-12964
> URL: https://issues.apache.org/jira/browse/CB-12964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android
>Reporter: José Luis Ballesteros del Val
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If someone has removed Pictures folder in android, plugin fails trying to 
> move there the new photo. This happens because plugin does not check the 
> existence of this folder, and if not, it does not complete the folder tree.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073472#comment-16073472
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user adamgalmor opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/226

Added implementation for iOS clearSharedUrlCache()



### Platforms affected
iOS

### What does this PR do?
clear iOS URL caching

### What testing has been done on this change?
non

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adamgalmor/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit 34011d493f72a506ed37b8c4356bb7efc630c8b2
Author: adam_g 
Date:   2017-07-04T10:54:11Z

Added implementation for iOS clearSharedUrlCache()




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-blackberry (DEPRECATED), cordova-cli
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12950) test-build e2e tests in cordova-android not running in CI

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073305#comment-16073305
 ] 

ASF GitHub Bot commented on CB-12950:
-

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-android/pull/391
  
Here's a JIRA issue:
https://issues.apache.org/jira/browse/CB-12960


> test-build e2e tests in cordova-android not running in CI
> -
>
> Key: CB-12950
> URL: https://issues.apache.org/jira/browse/CB-12950
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> Looks like because jasmine removed support for the CLI flag 
> {{--captureExceptions}} in a minor version bump, the CI is no longer 
> executing the {{test-build}} npm task, which runs e2e tests.
> Should probably:
> - fix this, but probably more importantly
> - look at whether these tests are needed? Running them is in the travis job 
> description, but not in the appveyor one, which means we are not getting this 
> test coverage on Windows in CI anyways.
> - perhaps the test coverage here can be provided by unit testing the CLI 
> scripts more fully, rather than relying on e2e tests?
> Ping [~bowserj].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Assigned] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread Alexander Sorokin (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin reassigned CB-12960:
--

Assignee: Alexander Sorokin

> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073296#comment-16073296
 ] 

ASF GitHub Bot commented on CB-12960:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/325


> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073295#comment-16073295
 ] 

ASF subversion and git services commented on CB-12960:
--

Commit 26beb94e2d454917db0bb024ab75e8dd9759c028 in cordova-ios's branch 
refs/heads/master from [~alsorokin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=26beb94 ]

CB-12960 Run tests on Node 4.x and 6.x
This closes #323


> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073297#comment-16073297
 ] 

ASF GitHub Bot commented on CB-12960:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/323


> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12888) cordova emulate ios doesn't work in iOS 11

2017-07-04 Thread Jan Piotrowski (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073277#comment-16073277
 ] 

Jan Piotrowski commented on CB-12888:
-

There are multiple reports of this happening with Xcode 8.x:
https://forum.ionicframework.com/t/no-target-specified-for-emulator-deploying-to-iphone-se-10-3-simulator/96588
https://forum.ionicframework.com/t/ionic-emulate-ios-target-device-errors/96278
https://forum.ionicframework.com/t/ionic-xcode-version-8-3-3-change-default-simulator/95966
https://github.com/ionic-team/ionic-cli/issues/2487

Same problem?

> cordova emulate ios doesn't work in iOS 11
> --
>
> Key: CB-12888
> URL: https://issues.apache.org/jira/browse/CB-12888
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>  Labels: ios11
> Fix For: cordova-ios@5.0.0
>
>
> Even with target:
> {code}
> $ cordova emulate ios --target="iPhone 6"
> Error: Cannot read property 'name' of undefined
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073270#comment-16073270
 ] 

ASF GitHub Bot commented on CB-12960:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/325
  
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=h1) 
Report
> Merging 
[#325](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/17d6b8344a8defc749b68e892fd7cb79b61f5752?src=pr&el=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/325/graphs/tree.svg?src=pr&token=WomDD5jInz&width=650&height=150)](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=tree)

```diff
@@   Coverage Diff   @@
##   master #325   +/-   ##
===
  Coverage   63.77%   63.77%   
===
  Files  14   14   
  Lines1623 1623   
  Branches  277  277   
===
  Hits 1035 1035   
  Misses588  588
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=footer). 
Last update 
[17d6b83...26beb94](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073256#comment-16073256
 ] 

ASF GitHub Bot commented on CB-12960:
-

Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-ios/pull/325


> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073257#comment-16073257
 ] 

ASF GitHub Bot commented on CB-12960:
-

GitHub user alsorokin reopened a pull request:

https://github.com/apache/cordova-ios/pull/325

CB-12960 Run tests on Node 4.x and 6.x

This closes #323

### Platforms affected
iOS

### What does this PR do?
Adds node 4.x and 6.x run to Travis CI

### What testing has been done on this change?
See Travis build just under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-ios CB-12960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #325


commit 26beb94e2d454917db0bb024ab75e8dd9759c028
Author: Alexander Sorokin 
Date:   2017-07-04T07:32:48Z

CB-12960 Run tests on Node 4.x and 6.x
This closes #323




> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12960) Run platform travis tests on node 4 + 6

2017-07-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073239#comment-16073239
 ] 

ASF GitHub Bot commented on CB-12960:
-

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-ios/pull/325

CB-12960 Run tests on Node 4.x and 6.x

This closes #323

### Platforms affected
iOS

### What does this PR do?
Adds node 4.x and 6.x run to Travis CI

### What testing has been done on this change?
See Travis build just under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-ios CB-12960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #325


commit 26beb94e2d454917db0bb024ab75e8dd9759c028
Author: Alexander Sorokin 
Date:   2017-07-04T07:32:48Z

CB-12960 Run tests on Node 4.x and 6.x
This closes #323




> Run platform travis tests on node 4 + 6 
> 
>
> Key: CB-12960
> URL: https://issues.apache.org/jira/browse/CB-12960
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-ios
>Reporter: Jesse MacFadyen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org