[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104285#comment-16104285
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129996355
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

yup


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, 

[jira] [Closed] (CB-12996) Android Splashscreen: 9 Patch images not displayed correctly

[Shawn Lan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-12996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shawn Lan closed CB-12996.
--
Resolution: Invalid

> Android Splashscreen: 9 Patch images not displayed correctly
> 
>
> Key: CB-12996
> URL: https://issues.apache.org/jira/browse/CB-12996
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
>Reporter: Shawn Lan
> Attachments: splash-hdpi.9.png, splash-mdpi.9.png, 
> splash-xhdpi.9.png, splash-xxhdpi.9.png
>
>
> I have something like this for Android:
> {code:java}
> 
> 
> 
> 
> {code}
> Instead of stretching just the stretchable area. the images are just scaled 
> to the entire screen, treated as regular images.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12996) Android Splashscreen: 9 Patch images not displayed correctly

[Shawn Lan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104155#comment-16104155
 ] 

Shawn Lan commented on CB-12996:


Sorry the problem is I have this 
{code:java}

{code}


> Android Splashscreen: 9 Patch images not displayed correctly
> 
>
> Key: CB-12996
> URL: https://issues.apache.org/jira/browse/CB-12996
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
>Reporter: Shawn Lan
> Attachments: splash-hdpi.9.png, splash-mdpi.9.png, 
> splash-xhdpi.9.png, splash-xxhdpi.9.png
>
>
> I have something like this for Android:
> {code:java}
> 
> 
> 
> 
> {code}
> Instead of stretching just the stretchable area. the images are just scaled 
> to the entire screen, treated as regular images.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104075#comment-16104075
 ] 

ASF GitHub Bot commented on CB-12895:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/580
  
Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for 
the most part. A few unused vars that you added exceptions for. 

Merge it


> Replace jshint with eslint in our tools + platforms
> ---
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: AllComponents
>Reporter: Steve Gill
>Assignee: Audrey So
>Priority: Minor
>  Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
>  +
>  +I suggest to replace the current style checkers with ESLint. This allows to 
> set much more strict styling rules than at at this moment.
>  +
>  +I recommend using a popular preset, such as 
> [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). 
> Example configuration:
>  +
>  +```yaml
>  +root: true
>  +
>  +extends: airbnb-base
>  +```
>  +
>  +Many styling issues could be fixed by simply running:
>  +
>  +```
>  +./node_modules/.bin/eslint --fix .
>  +```
>  +
>  +
>  +
>  +Optionally the indent could be set to 4 instead of 2, because that's used 
> in the current code base.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104069#comment-16104069
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/579#discussion_r129981726
  
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q');
+var rewire = require('rewire');
+var platform_save = rewire('../../../src/cordova/platform/save');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var fail;
+var semver = require('semver');
+
+describe('cordova/platform/save', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+
+beforeEach(function () {
+spyOn(semver, 'valid');
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine', 'addEngine','getEngines']);
+cfg_parser_revert_mock = platform_save.__set__('ConfigParser', 
cfg_parser_mock);
+cfg_parser_mock.prototype.getEngines.and.returnValue(['android']);
+});
+
+afterEach(function () {
+cfg_parser_revert_mock();
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(res){
+
expect(cfg_parser_mock.prototype.getEngines).toHaveBeenCalled();
+
expect(cfg_parser_mock.prototype.removeEngine).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('add and write to config.xml', function (done) {
+spyOn(platform_metadata, 
'getPlatformVersions').and.returnValue(Q(['6.3.0']));
+semver.valid.and.returnValue('6.0.0');
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(result) {
+
expect(cfg_parser_mock.prototype.addEngine).toHaveBeenCalledWith(undefined, 
'~6.0.0');
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
--- End diff --

I think you forgot to update the description here when you copied the first 
test :)


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104070#comment-16104070
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/579#discussion_r129981636
  
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q');
+var rewire = require('rewire');
+var platform_save = rewire('../../../src/cordova/platform/save');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var fail;
+var semver = require('semver');
+
+describe('cordova/platform/save', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+var cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+
+beforeEach(function () {
+spyOn(semver, 'valid');
+cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
mock', ['write', 'removeEngine', 'addEngine','getEngines']);
+cfg_parser_revert_mock = platform_save.__set__('ConfigParser', 
cfg_parser_mock);
+cfg_parser_mock.prototype.getEngines.and.returnValue(['android']);
+});
+
+afterEach(function () {
+cfg_parser_revert_mock();
+});
+
+it('should first remove platforms already in config.xml', function 
(done) {
+platform_save(hooks_mock, projectRoot, {save : true})
+.then(function(res){
+
expect(cfg_parser_mock.prototype.getEngines).toHaveBeenCalled();
+
expect(cfg_parser_mock.prototype.removeEngine).toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('add and write to config.xml', function (done) {
+spyOn(platform_metadata, 
'getPlatformVersions').and.returnValue(Q(['6.3.0']));
--- End diff --

so getPlatformVersions returns in the format of `{platform: platform, 
version: version}`. So instead of returning `Q([6.3.0])`, you could return 
`Q({platform: 'android', version: 6.3.0})`. That way the first argument for 
line 58 won't be undefined. 


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13127) Fix/Update broken build badges on cordova-docs (plugin docs) to reflect new platforms/versions from actual repo readme

[Filip Maj (JIRA)]

Filip Maj created CB-13127:
--

 Summary: Fix/Update broken build badges on cordova-docs (plugin 
docs) to reflect new platforms/versions from actual repo readme
 Key: CB-13127
 URL: https://issues.apache.org/jira/browse/CB-13127
 Project: Apache Cordova
  Issue Type: Task
  Components: cordova-docs
Reporter: Filip Maj


See the top of e.g. 
https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html

We now test on iOS 9.3 and 10, and Android 4.4, 5.1, 6.0 and 7.0, as well as 
desktop browsers - let's make that visible on the docs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12727) Console - INTEGRATE

[Filip Maj (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104011#comment-16104011
 ] 

Filip Maj commented on CB-12727:


Looks like the main work to be done here is for cordova-ios and 
cordova-windows. There are also ubuntu, wp7, wp8 and win8 platfor 
implementations in this plugin, but these are all deprecated platforms 
(right?), so I would ignore those. I believe next steps are:

- integrate the plugin's {{{www/logger.js}} and {{www/console-via-logger.js}} 
into cordova-ios and cordova-windows. How? It's been a while for me... or does 
this land in cordova-js?
- integrate plugin's {{src/ios/*}} into cordova-ios
- update README for plugin
- add an {{}} (and {{cordovaDependencies}} ?) constraint to plugin, 
capping cordova-ios and cordova-windows support
- deprecate component in JIRA
- remove cordova-plugin-console from cordova-docs
- do a final release of cordova-plugin-compat
- deprecate the plugin in npm

That look good? What am I missing?

> Console - INTEGRATE
> ---
>
> Key: CB-12727
> URL: https://issues.apache.org/jira/browse/CB-12727
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-console
>Reporter: Shazron Abdullah
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13106) How to detect uninstall event in Cordova

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13106.
-
Resolution: Invalid
  Assignee: jcesarmobile

This is a question, not a real issue, closing as invalid.


There is no such event, the OS should handle those things, at least on iOS it 
deletes the app and all the files. 

> How to detect uninstall event in Cordova
> 
>
> Key: CB-13106
> URL: https://issues.apache.org/jira/browse/CB-13106
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: AllPlatforms
>Affects Versions: cordova@7.0.0
>Reporter: Divyanshu
>Assignee: jcesarmobile
>Priority: Minor
>  Labels: newbie, performance
>
> I want to clear cache of my application when App is uninstall from any device 
> (android or IOS).
> Is there any way to do this? Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13026) java.lang.NoSuchMethodError: No virtual method requestPermissions([Ljava/lang/String;I)V in class Landroid/app/Activity

[Filip Maj (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103988#comment-16103988
 ] 

Filip Maj commented on CB-13026:


Linking this up to CB-12730, as we are looking at integrating 
cordova-plugin-compat into cordova-android anyways. It looks like there may be 
some additional work to consolidate the way plugins request permissions in 
cordova-android.

> java.lang.NoSuchMethodError: No virtual method 
> requestPermissions([Ljava/lang/String;I)V in class Landroid/app/Activity
> ---
>
> Key: CB-13026
> URL: https://issues.apache.org/jira/browse/CB-13026
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova@7.0.0
>Reporter: Alex B.
>Assignee: Joe Bowser
>  Labels: bug
> Fix For: 7.0.0
>
>
> h3. The problem
> Problem reproduced on Android 5.1.1 (API level 22), on all my devices which 
> below API level 23 
> Problematic part of code
> {code:java}
> public class HelloWorldBridge extends CordovaPlugin {
> String [] permissions = {
> Manifest.permission.CALL_PHONE,
> Manifest.permission.INSTALL_SHORTCUT };
> private static int REQUEST_CODE_PERMISSION = 0;
> @Override protected void pluginInitialize() {
> onStart();
> }
> @Override public void onStart() {
> cordova.requestPermissions(this, REQUEST_CODE_PERMISSION, 
> permissions);
> }
> @Override public void onNewIntent(Intent intent) {
> cordova.getActivity().setIntent(intent);
> }
> @Override
> public void onRequestPermissionResult(int requestCode, String[] 
> permissions, int[] grantResults) throws JSONException {
> super.onRequestPermissionResult(requestCode, permissions, 
> grantResults);
> if (requestCode == REQUEST_CODE_PERMISSION) {
> for (int r : grantResults) {
> if (r == PackageManager.PERMISSION_DENIED) {
> return;
> }
> }
> cordova.getActivity().runOnUiThread(new Runnable() {
> @Override
> public void run() {
>Log.d(TAG, "Granted!");
> }
> });
> }
> }
> }
> {code}
> Stack trace:
> {code:java}
> java.lang.NoSuchMethodError: No virtual method 
> requestPermissions([Ljava/lang/String;I)V in class Landroid/app/Activity; or 
> its super classes (declaration of 'android.app.Activity' appears in 
> /system/framework/framework.jar)
>   at 
> org.apache.cordova.CordovaInterfaceImpl.requestPermissions(CordovaInterfaceImpl.java:226)
>   at org.mysample.HelloWorldBridge.initDialOnce(DialOnceBridge.java:40)
>   at 
> org.mysample.HelloWorldBridge.pluginInitialize(DialOnceBridge.java:27)
>   at 
> org.apache.cordova.CordovaPlugin.privateInitialize(CordovaPlugin.java:58)
>   at org.apache.cordova.PluginManager.getPlugin(PluginManager.java:171)
>   at 
> org.apache.cordova.PluginManager.startupPlugins(PluginManager.java:97)
>   at org.apache.cordova.PluginManager.init(PluginManager.java:86)
>   at 
> org.apache.cordova.CordovaWebViewImpl.init(CordovaWebViewImpl.java:115)
>   at org.apache.cordova.CordovaActivity.init(CordovaActivity.java:149)
>   at org.apache.cordova.CordovaActivity.loadUrl(CordovaActivity.java:224)
>   at 
> com.dialonce.cordova.sample.MainActivity.onCreate(MainActivity.java:39)
>   at android.app.Activity.performCreate(Activity.java:6092)
>   at 
> android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1112)
>   at 
> android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2468)
>   at 
> android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2595)
>   at android.app.ActivityThread.access$800(ActivityThread.java:178)
>   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1470)
>   at android.os.Handler.dispatchMessage(Handler.java:111)
>   at android.os.Looper.loop(Looper.java:194)
>   at android.app.ActivityThread.main(ActivityThread.java:5631)
>   at java.lang.reflect.Method.invoke(Native Method)
>   at java.lang.reflect.Method.invoke(Method.java:372)
>   at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:963)
>   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:758)
> {code}
> h3. Investigation
> According docs [Activity.requestPermissions | 
> https://developer.android.com/reference/android/app/Activity.html#requestPermissions(java.lang.String[],
>  int)] this method require Android API 23
> h3. Workaround
> Wrap `requestPermissions` code with `if (Build.VERSION.SDK_INT >= 
> Build.VERSION_CODES.M) { 

[jira] [Commented] (CB-12730) Compat - INTEGRATE

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103978#comment-16103978
 ] 

jcesarmobile commented on CB-12730:
---

As we are integrating compat plugin, it would be a good moment to look into 
what I commented on https://issues.apache.org/jira/browse/CB-13026.


> Compat - INTEGRATE
> --
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-compat
>Reporter: Shazron Abdullah
>Assignee: Simon MacDonald
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103976#comment-16103976
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129969368
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

ohh okay do you mean just like this?

```
 it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {

expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
done();
});
```


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>   

[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103971#comment-16103971
 ] 

ASF GitHub Bot commented on CB-11244:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
Hey @infil00p, latest master has a tiny tweak to the appveyor build file 
that works around some troubles appveyor is experiencing with one of their VM 
images. I think if you rebase this, you'll find that'll clear up the appveyor 
failures.


> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>  Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project 
> structure created by default, even for new projects, which makes no sense 
> since we no longer support Eclipse as the default project editor and have 
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for 
> projects and dependencies to work more like how modern Android projects work 
> and to remove as much custom Gradle code as possible.  This would also allow 
> us in the future to move towards having Android Plugin code work as Android 
> Libraries with Resources instead of just copying things across, which gives 
> us the ability to add JUnit tests and bundled resources.  This would 
> dramatically increase the quality of plugins such as InAppBrowser, and third 
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would 
> be tricky to do.  However, the benefits at this point would greatly outweigh 
> the costs of maintaining the old project structure.  The old cordova-common 
> code in Cordova-Android 5.0.x would allow for plugins in the short term to 
> work with both projects until we get the new project structure ready.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13031) config.xml: android-packageName case-sensitivity

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103970#comment-16103970
 ] 

ASF GitHub Bot commented on CB-13031:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/397
  
Hey @matrosov-nikita, rebase w/ latest master, I should have a fix 
(workaround) in for appveyor troubles.


> config.xml: android-packageName case-sensitivity
> 
>
> Key: CB-13031
> URL: https://issues.apache.org/jira/browse/CB-13031
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 7.0.1
>Reporter: Ronald Klip
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: osx, windows
>
> In config.xml, setting {{android-packageName}} to a value that only differs 
> from {{id}} in capitalization causes an error with {{platform add android}} .
> *Example:*
> {{cordova create testapp com.example.testapp testapp}}
> {{cd testapp}}
> (edit config.xml, add android-packageName="com.example.Testapp" to )
> {{cordova platform add android}}
> *Output:*
> Using cordova-fetch for cordova-android@~6.2.2
> Adding android project...
> Creating Cordova project for the Android platform:
>   Path: platforms/android
>   Package: com.example.testapp
>   Name: testapp
>   Activity: MainActivity
>   Android target: android-25
> Subproject Path: CordovaLib
> Android project created with cordova-android@6.2.3
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
>This plugin is only applicable for versions of cordova-android 
> greater than 4.0. If you have a previous platform version, you do *not* need 
> this plugin since the whitelist will be built in.
>   
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> ls: no such file or directory: 
> /Users/ronald987/dev/apps/testapp/platforms/android/src/com/example/Testapp/*.java
> {color:red}Error: No Java files found that extend CordovaActivity.{color}
> 
> The directory and the .java indeed don't exist. In platforms/android/src 
> there's only an org directory. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12730) Compat - INTEGRATE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103969#comment-16103969
 ] 

ASF GitHub Bot commented on CB-12730:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/399
  
Hey @macdonst if you rebase w/ latest master, I think we can clear up the 
appveyor failure we're seeing in here.


> Compat - INTEGRATE
> --
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-compat
>Reporter: Shazron Abdullah
>Assignee: Simon MacDonald
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-12730) Compat - INTEGRATE

[Filip Maj (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103927#comment-16103927
 ] 

Filip Maj edited comment on CB-12730 at 7/27/17 9:38 PM:
-

It sounds like CB-12122, if we do decide to change the behaviour of how our 
tools install and handle dependent plugin install failures, would require a 
major version bump. So I don't think it has an impact on changes here. We can 
move ahead, I believe.

cordova-android changes:
- [~macdonst] has [a PR up to integrate the compat code into 
cordova-android|https://github.com/apache/cordova-android/pull/399] all ready.

cordova-plugin-compat changes:
- cordova-plugin-compat needs its {{}} tag updated to cap at requiring 
cordova-android below 7.0.0.
- do we need to update the {{cordovaDependencies}} section of package.json as 
well? cap cordova-android to below 7.0.0?

cordova-docs changes:
- probably need to review the android plugin guide around handling permissions? 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions

cordova-coho changes
- remove references to cordova-plugin-compat

release stuff:
- after all the above is done, do a final (patch/minor) release of the plugin, 
and deprecate the plugin in npm.

Anything else I'm missing?


was (Author: filmaj):
It sounds like CB-12122, if we do decide to change the behaviour of how our 
tools install and handle dependent plugin install failures, would require a 
major version bump. So I don't think it has an impact on changes here. We can 
move ahead, I believe.

cordova-android changes:
- [~macdonst] has [a PR up to integrate the compat code into 
cordova-android|https://github.com/apache/cordova-android/pull/399] all ready.

cordova-plugin-compat changes:
- cordova-plugin-compat needs its {{}} tag updated to cap at requiring 
cordova-android below 7.0.0.
- do we need to update the {{cordovaDependencies}} section of package.json as 
well? cap cordova-android to below 7.0.0?

cordova-docs changes:
- probably need to review the android plugin guide around handling permissions? 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions

cordova-coho changes
- remove references to cordova-plugin-compat

Anything else I'm missing?

> Compat - INTEGRATE
> --
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-compat
>Reporter: Shazron Abdullah
>Assignee: Simon MacDonald
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-12730) Compat - INTEGRATE

[Filip Maj (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103927#comment-16103927
 ] 

Filip Maj edited comment on CB-12730 at 7/27/17 9:15 PM:
-

It sounds like CB-12122, if we do decide to change the behaviour of how our 
tools install and handle dependent plugin install failures, would require a 
major version bump. So I don't think it has an impact on changes here. We can 
move ahead, I believe.

cordova-android changes:
- [~macdonst] has [a PR up to integrate the compat code into 
cordova-android|https://github.com/apache/cordova-android/pull/399] all ready.

cordova-plugin-compat changes:
- cordova-plugin-compat needs its {{}} tag updated to cap at requiring 
cordova-android below 7.0.0.
- do we need to update the {{cordovaDependencies}} section of package.json as 
well? cap cordova-android to below 7.0.0?

cordova-docs changes:
- probably need to review the android plugin guide around handling permissions? 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions

cordova-coho changes
- remove references to cordova-plugin-compat

Anything else I'm missing?


was (Author: filmaj):
It sounds like CB-12122, if we do decide to change the behaviour of how our 
tools install and handle dependent plugin install failures, would require a 
major version bump. So I don't think it has an impact on changes here. We can 
move ahead, I believe.

cordova-android changes:
- [~macdonst] has [a PR up to integrate the compat code into 
cordova-android|https://github.com/apache/cordova-android/pull/399] all ready.
cordova-plugin-compat changes:
- cordova-plugin-compat needs its {{}} tag updated to cap at requiring 
cordova-android below 7.0.0.
- do we need to update the {{cordovaDependencies}} section of package.json as 
well? cap cordova-android to below 7.0.0?
cordova-docs changes:
- probably need to review the android plugin guide around handling permissions? 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions
cordova-coho changes
- remove references to cordova-plugin-compat

Anything else I'm missing?

> Compat - INTEGRATE
> --
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-compat
>Reporter: Shazron Abdullah
>Assignee: Simon MacDonald
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12730) Compat - INTEGRATE

[Filip Maj (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103927#comment-16103927
 ] 

Filip Maj commented on CB-12730:


It sounds like CB-12122, if we do decide to change the behaviour of how our 
tools install and handle dependent plugin install failures, would require a 
major version bump. So I don't think it has an impact on changes here. We can 
move ahead, I believe.

cordova-android changes:
- [~macdonst] has [a PR up to integrate the compat code into 
cordova-android|https://github.com/apache/cordova-android/pull/399] all ready.
cordova-plugin-compat changes:
- cordova-plugin-compat needs its {{}} tag updated to cap at requiring 
cordova-android below 7.0.0.
- do we need to update the {{cordovaDependencies}} section of package.json as 
well? cap cordova-android to below 7.0.0?
cordova-docs changes:
- probably need to review the android plugin guide around handling permissions? 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions
cordova-coho changes
- remove references to cordova-plugin-compat

Anything else I'm missing?

> Compat - INTEGRATE
> --
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-compat
>Reporter: Shazron Abdullah
>Assignee: Simon MacDonald
>
> See parent issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13126) Remove the app showcase

[Steve Gill (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-13126:

Labels: backlog  (was: )

> Remove the app showcase
> ---
>
> Key: CB-13126
> URL: https://issues.apache.org/jira/browse/CB-13126
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-website
>Reporter: Filip Maj
>  Labels: backlog
>
> Per http://markmail.org/message/bgwiehbg6kl3okl2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13126) Remove the app showcase

[Filip Maj (JIRA)]

Filip Maj created CB-13126:
--

 Summary: Remove the app showcase
 Key: CB-13126
 URL: https://issues.apache.org/jira/browse/CB-13126
 Project: Apache Cordova
  Issue Type: Task
  Components: cordova-website
Reporter: Filip Maj


Per http://markmail.org/message/bgwiehbg6kl3okl2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103714#comment-16103714
 ] 

ASF GitHub Bot commented on CB-3232:


Github user bernatch closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-blackberry (DEPRECATED), cordova-cli
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103711#comment-16103711
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user bernatch opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232

InAppBrowser



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adriantodorov/cordova-plugin-inappbrowser 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 571cfb5c2960a54c3d6e5762bb894030c8b0d392
Author: Adrian Todorov 
Date:   2016-01-14T16:51:53Z

Update InAppBrowser.java

commit bd1d494c0fef94add21316454757afd18307aa46
Author: Adrian Todorov 
Date:   2016-01-14T16:59:35Z

Update InAppBrowser.java

commit cca43163927b94bc0c3a1d7a5e640b7d6d8ffae1
Author: Adrian Todorov 
Date:   2016-01-14T17:02:40Z

Update InAppBrowser.java

commit 98714b08f26c5279900222367ec2c0ee5656be47
Author: Adrian Todorov 
Date:   2016-04-28T14:08:41Z

Hide the status bar

Hide the status Bar in InAppBrowser

commit 51207f4a643a07858f350f4ba0a847b7fe7c7891
Author: Adrian Todorov 
Date:   2016-04-28T14:28:09Z

Update InAppBrowser.java




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-blackberry (DEPRECATED), cordova-cli
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103681#comment-16103681
 ] 

ASF GitHub Bot commented on CB-12361:
-

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/578#discussion_r129926425
  
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var path = require('path');
+var fs = require('fs');
+var Q = require('q');
+var rewire = require('rewire');
+var cordova_util = require('../../../src/cordova/util');
+var platform_getPlatformDetails = 
rewire('../../../src/cordova/platform/getPlatformDetailsFromDir');
+var events = require('cordova-common').events;
+var fail;
+
+describe('cordova/platform/getPlatformDetailsFromDir', function () {
+var package_json_mock;
+package_json_mock = jasmine.createSpyObj('package json mock', 
['cordova', 'dependencies']);
+package_json_mock.name = 'io.cordova.hellocordova';
+package_json_mock.version = '1.0.0';
+
+beforeEach(function () {
+spyOn(Q, 'reject');
+spyOn(fs, 'existsSync');
+spyOn(cordova_util, 'requireNoCache');
+spyOn(events, 'emit');
+});
+
+it('should throw if no config.xml or pkgJson', function (done) {
+platform_getPlatformDetails('dir', ['ios']);
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a valid package.json or a valid Cordova platform/));
+done();
+});
+
+it('should throw if no platform is provided', function (done) {
+cordova_util.requireNoCache.and.returnValue({});
+platform_getPlatformDetails('dir');
+expect(Q.reject).toHaveBeenCalledWith(jasmine.stringMatching(/does 
not seem to contain a Cordova platform:/));
+done();
+});
+
+it('should return a promise with platform and version', function 
(done) {
+fs.existsSync.and.callFake(function(filePath) {
+if(path.basename(filePath) === 'package.json') {
+return true;
+} else {
+return false;
+}
+});
+cordova_util.requireNoCache.and.returnValue(package_json_mock);
+platform_getPlatformDetails('dir', ['cordova-android'])
+.then(function(result) {
+expect(result.platform).toBe('io.cordova.hellocordova');
+expect(result.version).toBe('1.0.0');
+expect(Q.reject).not.toHaveBeenCalled();
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('should remove the cordova- prefix from the platform name for known 
platforms', function (done) {
+platform_getPlatformDetails.platformFromName('cordova-ios');
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching(/Removing "cordova-" prefix/));
+
expect(platform_getPlatformDetails.platformFromName('cordova-ios')).toBe('ios');
--- End diff --

You can take the expect from line 76 and combine it with line 74 and delete 
76. So line 74 gets replaced by line 76. Line 75 should still pass


> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CB-12361) Speed up cordova-lib tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103655#comment-16103655
 ] 

ASF GitHub Bot commented on CB-12361:
-

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/584

CB-12361 : added tests for plugin/save.js



### Platforms affected


### What does this PR do?

 added tests for plugin/save.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-16-plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #584






> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13104) "Error: Cannot read property 'length' of undefined" when executing "cordova run android"

[Nikita Matrosov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103317#comment-16103317
 ] 

Nikita Matrosov commented on CB-13104:
--

[~bowserj], I've tried to install a new instance of AS and update existing one, 
but not noticed changes regarding Gradle location.
But anyway, I think, it's better to continue search or at least output more 
descriptive message if Gradle not found in AS.

> "Error: Cannot read property 'length' of undefined" when executing "cordova 
> run android"
> 
>
> Key: CB-13104
> URL: https://issues.apache.org/jira/browse/CB-13104
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
> Environment: Windows 7 Professional x64
> Java SDK 8u131
> npm 5.2.0
> phonegap 6.5.2
> cordova 6.5.0
> cordova android platform 6.2.3
> android studio 2.3.3
> android sdk build-tools 26
> android sdk tools 26.0.2
> android sdk platform-tools 26.0.0
> android emulator 26.1.2
> android support repository 47.0.0
>Reporter: Bryan Bale
>Assignee: Joe Bowser
>
> I've searched for solutions to this problem, and found several reports of it, 
> but no solutions.  Based on my many attempts to get something to work (I've 
> tried phonegap, ionic, and just plain cordova), I started suspecting that 
> there's a bug in the cordova android platform.  All my build attempts have 
> been halted at this error message:
> {{Error: Cannot read property 'length' of undefined}}
> *Replicating this issue with phonegap:*
> _I'm starting with phonegap because this is how I first encountered the 
> error, and it seems to give me the most useful information with regard to 
> where the error is happening._
> $ npm install -g phonegap
> npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing 
> Set-Cookie https://nodesecurity.io/advisories/130  
> npm WARN deprecated node-uuid@1.4.8: Use uuid module instead  
>  
> C:\Users\bbale\AppData\Roaming\npm\phonegap -> 
> C:\Users\bbale\AppData\Roaming\npm\node_modules\phonegap\bin\phonegap.js
> + phonegap@6.5.2  
>  
> added 873 packages in 146.435s
>  
> $ phonegap create pgHello --id "com.pghello.app" --name "pgHello" --template 
> hello-world
> Creating a new cordova project.
> $ cd pgHello
> $ phonegap run android --verbose
> [phonegap] executing 'cordova platform add --save android ' ...   
>   
> 
> Adding android project... 
>   
> 
>   
>   
> 
> Creating Cordova project for the Android platform:
>   
> 
> Path: platforms\android   
>   
> 
> Package: com.pghello.app  
>   
> 
> Name: pgHello 
>   
> 
> Activity: MainActivity
>   
> 
> Android target: android-25
>   
> 
>   
>   
> 
> Subproject Path: CordovaLib   
>   
>   

[jira] [Commented] (CB-13031) config.xml: android-packageName case-sensitivity

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103269#comment-16103269
 ] 

ASF GitHub Bot commented on CB-13031:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-android/pull/397
  
@filmaj, thanks for the information, I'm planning to merge in once Appveyor 
is fixed.


> config.xml: android-packageName case-sensitivity
> 
>
> Key: CB-13031
> URL: https://issues.apache.org/jira/browse/CB-13031
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 7.0.1
>Reporter: Ronald Klip
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: osx, windows
>
> In config.xml, setting {{android-packageName}} to a value that only differs 
> from {{id}} in capitalization causes an error with {{platform add android}} .
> *Example:*
> {{cordova create testapp com.example.testapp testapp}}
> {{cd testapp}}
> (edit config.xml, add android-packageName="com.example.Testapp" to )
> {{cordova platform add android}}
> *Output:*
> Using cordova-fetch for cordova-android@~6.2.2
> Adding android project...
> Creating Cordova project for the Android platform:
>   Path: platforms/android
>   Package: com.example.testapp
>   Name: testapp
>   Activity: MainActivity
>   Android target: android-25
> Subproject Path: CordovaLib
> Android project created with cordova-android@6.2.3
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
>This plugin is only applicable for versions of cordova-android 
> greater than 4.0. If you have a previous platform version, you do *not* need 
> this plugin since the whitelist will be built in.
>   
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> ls: no such file or directory: 
> /Users/ronald987/dev/apps/testapp/platforms/android/src/com/example/Testapp/*.java
> {color:red}Error: No Java files found that extend CordovaActivity.{color}
> 
> The directory and the .java indeed don't exist. In platforms/android/src 
> there's only an org directory. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12969) InAppBrowser - Cannot open data URLs in system browser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103264#comment-16103264
 ] 

ASF GitHub Bot commented on CB-12969:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/227
  
@filmaj, I would expand this section 
(https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by 
adding samples with Data URIs.

But, for now, I found that this patch doesn't work on windows with data URI 
in case of using `_blank` target. Not sure, whether it supposed to work.


> InAppBrowser - Cannot open data URLs in system browser
> --
>
> Key: CB-12969
> URL: https://issues.apache.org/jira/browse/CB-12969
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
> Environment: iOS, Android
>Reporter: Sachitra Malwatte
>Assignee: Nikita Matrosov
>Priority: Critical
>
> I want to open data URLs in system browser. So I did this,
> {code:java}
> window.open('data:text/html, Hello', 
> '_system');
> {code}
> But nothing happens (browser won't open).
> It works with normal URLs. e.g. 
> window.open('https://github.com/apache/cordova-plugin-inappbrowser', 
> '_system'); But not with data URIs.
> inappbrowser version: 1.7.1
> Please help.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13093) Infinite looping when stressing navigation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103198#comment-16103198
 ] 

ASF GitHub Bot commented on CB-13093:
-

Github user luissilvaos commented on the issue:

https://github.com/apache/cordova-ios/pull/328
  
Yes, it is. Please check my last commit.


> Infinite looping when stressing navigation
> --
>
> Key: CB-13093
> URL: https://issues.apache.org/jira/browse/CB-13093
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Luis Silva
>Assignee: Shazron Abdullah
>
> An infinite loop is caused by the shouldStartLoadWithRequest method of 
> CDVUIWebViewDelegate when a navigation starts with the 
> STATE_WAITING_FOR_LOAD_START and the ErrorUrl page is defined.
> I already have a fix for this issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13028) Paramedic should be able to run tests for browser platform.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103175#comment-16103175
 ] 

ASF GitHub Bot commented on CB-13028:
-

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/231

CB-13028 (CI) Browser builds on Travis and AppVeyor, Fixes tests on b…

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-inappbrowser CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #231


commit 72ac4d7eca06562193f89b42aa542f546ec22f16
Author: Alexander Sorokin 
Date:   2017-07-27T12:55:11Z

CB-13028 (CI) Browser builds on Travis and AppVeyor, Fixes tests on browser 
and browser implementation




> Paramedic should be able to run tests for browser platform.
> ---
>
> Key: CB-13028
> URL: https://issues.apache.org/jira/browse/CB-13028
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-paramedic
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: ci
>
> Currently paramedic can't run tests for browser. For example, it constantly 
> waits for "cordova run" to finish, but with browser platform it never does.
> Ultimately we should aim to test browser platform on Sauce Labs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-13125) Cordova ios build not working

[Mazen Debe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mazen Debe resolved CB-13125.
-
Resolution: Fixed

Just Update Cordova -_-

> Cordova ios build not working
> -
>
> Key: CB-13125
> URL: https://issues.apache.org/jira/browse/CB-13125
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0
>Reporter: Mazen Debe
>Assignee: Shazron Abdullah
>  Labels: cordova, ios
>
> I am trying to create a new ios application. After adding the ios platform to 
> the project, I try to build it, it does not build giving me this error. 
> (node:3047) fs: re-evaluating native module sources is not supported. If you 
> are using the graceful-fs module, please update it to a more recent version.
> I am suspecting a problem with the npm but cannot quite figure it out.
> P.S. the root folder of my project does not include the package.json or the 
> node_modules folder



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-13125) Cordova ios build not working

[Mazen Debe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mazen Debe updated CB-13125:

Comment: was deleted

(was: Just update cordova -_-)

> Cordova ios build not working
> -
>
> Key: CB-13125
> URL: https://issues.apache.org/jira/browse/CB-13125
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0
>Reporter: Mazen Debe
>Assignee: Shazron Abdullah
>  Labels: cordova, ios
>
> I am trying to create a new ios application. After adding the ios platform to 
> the project, I try to build it, it does not build giving me this error. 
> (node:3047) fs: re-evaluating native module sources is not supported. If you 
> are using the graceful-fs module, please update it to a more recent version.
> I am suspecting a problem with the npm but cannot quite figure it out.
> P.S. the root folder of my project does not include the package.json or the 
> node_modules folder



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13125) Cordova ios build not working

[Mazen Debe (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102920#comment-16102920
 ] 

Mazen Debe commented on CB-13125:
-

Just update cordova -_-

> Cordova ios build not working
> -
>
> Key: CB-13125
> URL: https://issues.apache.org/jira/browse/CB-13125
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0
>Reporter: Mazen Debe
>Assignee: Shazron Abdullah
>  Labels: cordova, ios
>
> I am trying to create a new ios application. After adding the ios platform to 
> the project, I try to build it, it does not build giving me this error. 
> (node:3047) fs: re-evaluating native module sources is not supported. If you 
> are using the graceful-fs module, please update it to a more recent version.
> I am suspecting a problem with the npm but cannot quite figure it out.
> P.S. the root folder of my project does not include the package.json or the 
> node_modules folder



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-13092) Plugin addition fails | Uncaught TypeError: undefined is not a function

[Dawid (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101616#comment-16101616
 ] 

Dawid edited comment on CB-13092 at 7/27/17 7:55 AM:
-

I am sure I could, but I would like to do things right if I do them and this 
would take a lot of time, which I don't have atm as an computer science student 
with two jobs :/

interesting, do I have to wait for deviceready? Here is the link to the project 
on an github repo. Take a look if you have time 
[github dummy repo  | https://github.com/Fakerinc/cordova-test]

(edit 27.07.2017: As I learned waiting for the device ready event is essential 
for every cordova application. Somehow I overread that part in the 
documentation)


was (Author: *_dave_*):
I am sure I could, but I would like to do things right if I do them and this 
would take a lot of time, which I don't have atm as an computer science student 
with two jobs :/

interesting, do I have to wait for deviceready? Here is the link to the project 
on an github repo. Take a look if you have time 
[github dummy repo  | https://github.com/Fakerinc/cordova-test]

> Plugin addition fails | Uncaught TypeError: undefined is not a function
> ---
>
> Key: CB-13092
> URL: https://issues.apache.org/jira/browse/CB-13092
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlugins
>Affects Versions: 7.0.1
> Environment: Windows 8 64 bit Enterprise 
> Android Studio 2.3.3
> {code:java}
> $ cordova -v
> You have been opted out of telemetry. To change this, run: cordova telemetry 
> on.
> 7.0.1
> $ npm --version
> 3.10.10
> $ git --version
> git version 2.13.2.windows.1
> $ grunt --version
> grunt-cli v1.2.0
> $ bower --version
> 1.8.0
> {code}
>Reporter: Dawid
>Priority: Minor
>
> Hey guys, 
> For a few days now, I am trying to add a plugin myself based on the 
> documentation on the cordova homepage. 
> [https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html]
> I started with the German version (because I am from Germany) and was 
> disappointed. It is written terribly. Just the quality of the text itself is 
> bad. I didn't go far enough to evaluate the content.
> I switched to the English version which is good, and I think I followed every 
> step and have everything set up as it should be, but when I try to run my 
> project (or a blank project for that matter) with the plugin added, I get the 
> following error: 
> {code:java}
> 07-24 03:51:15.036 29983-29983/? D/CordovaWebViewImpl: 
> onPageDidNavigate(file:///android_asset/www/index.html)
> 07-24 03:51:15.247 29983-29983/io.cordova.hellocordova D/JsMessageQueue: Set 
> native->JS mode to EvalBridgeMode
> 07-24 03:51:15.286 29983-29983/io.cordova.hellocordova 
> D/SystemWebChromeClient: 
> file:///android_asset/www/plugins/cordova-plugin-echo-js/www/echo.js: Line 28 
> : Uncaught TypeError: undefined is not a function
> 07-24 03:51:15.286 29983-29983/io.cordova.hellocordova I/chromium: 
> [INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: 
> file:///android_asset/www/plugins/cordova-plugin-echo-js/www/echo.js (28)
> 07-24 03:51:15.290 29983-29983/io.cordova.hellocordova D/CordovaWebViewImpl: 
> onPageFinished(file:///android_asset/www/index.html)
> 07-24 03:51:15.384 29983-29983/io.cordova.hellocordova 
> D/SystemWebChromeClient: file:///android_asset/www/js/index.js: Line 36 : 
> Uncaught TypeError: Cannot read property 'querySelector' of null
> 07-24 03:51:15.384 29983-29983/io.cordova.hellocordova I/chromium: 
> [INFO:CONSOLE(36)] "Uncaught TypeError: Cannot read property 'querySelector' 
> of null", source: file:///android_asset/www/js/index.js (36)
> {code}
> line 28 is the first line from following code: 
> {code:java}
>   window.echo("echome", function(echoValue){
>   alert(echoValue == "echome");
>   });
> {code}
> I googled a bit of course and tried various "solutions". Removing the 
> plugins, removing the platforms adding them back up. Starting a project from 
> scratch. Adding the plugins in different ways and other stuff that I am 
> missing now for sure. 
> I appreciate any kind of help. This problem is really annoying me. 
> Best regards
> Dawid



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13028) Paramedic should be able to run tests for browser platform.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102816#comment-16102816
 ] 

ASF GitHub Bot commented on CB-13028:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/59


> Paramedic should be able to run tests for browser platform.
> ---
>
> Key: CB-13028
> URL: https://issues.apache.org/jira/browse/CB-13028
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-paramedic
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: ci
>
> Currently paramedic can't run tests for browser. For example, it constantly 
> waits for "cordova run" to finish, but with browser platform it never does.
> Ultimately we should aim to test browser platform on Sauce Labs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13028) Paramedic should be able to run tests for browser platform.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102815#comment-16102815
 ] 

ASF subversion and git services commented on CB-13028:
--

Commit e9a2b1771549ef7e30ccb5edc424daa31d32aa70 in 
cordova-plugin-globalization's branch refs/heads/master from [~alsorokin]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=e9a2b17
 ]

CB-13028 (CI) Browser builds on Travis and AppVeyor


> Paramedic should be able to run tests for browser platform.
> ---
>
> Key: CB-13028
> URL: https://issues.apache.org/jira/browse/CB-13028
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-paramedic
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: ci
>
> Currently paramedic can't run tests for browser. For example, it constantly 
> waits for "cordova run" to finish, but with browser platform it never does.
> Ultimately we should aim to test browser platform on Sauce Labs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13125) Cordova ios build not working

[Mazen Debe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mazen Debe updated CB-13125:

Description: 
I am trying to create a new ios application. After adding the ios platform to 
the project, I try to build it, it does not build giving me this error. 
(node:3047) fs: re-evaluating native module sources is not supported. If you 
are using the graceful-fs module, please update it to a more recent version.
I am suspecting a problem with the npm but cannot quite figure it out.
P.S. the root folder of my project does not include the package.json or the 
node_modules folder

  was:
I am trying to create a new ios application. After adding the ios platform to 
the project, I try to build it, it does not build giving me this error. 
(node:3047) fs: re-evaluating native module sources is not supported. If you 
are using the graceful-fs module, please update it to a more recent version.

P.S. the root folder of my project does not include the package.json or the 
node_modules folder


> Cordova ios build not working
> -
>
> Key: CB-13125
> URL: https://issues.apache.org/jira/browse/CB-13125
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0
>Reporter: Mazen Debe
>Assignee: Shazron Abdullah
>  Labels: cordova, ios
>
> I am trying to create a new ios application. After adding the ios platform to 
> the project, I try to build it, it does not build giving me this error. 
> (node:3047) fs: re-evaluating native module sources is not supported. If you 
> are using the graceful-fs module, please update it to a more recent version.
> I am suspecting a problem with the npm but cannot quite figure it out.
> P.S. the root folder of my project does not include the package.json or the 
> node_modules folder



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13125) Cordova ios build not working

[Mazen Debe (JIRA)]

Mazen Debe created CB-13125:
---

 Summary: Cordova ios build not working
 Key: CB-13125
 URL: https://issues.apache.org/jira/browse/CB-13125
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Affects Versions: cordova@7.0.0
Reporter: Mazen Debe
Assignee: Shazron Abdullah


I am trying to create a new ios application. After adding the ios platform to 
the project, I try to build it, it does not build giving me this error. 
(node:3047) fs: re-evaluating native module sources is not supported. If you 
are using the graceful-fs module, please update it to a more recent version.

P.S. the root folder of my project does not include the package.json or the 
node_modules folder



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13028) Paramedic should be able to run tests for browser platform.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102793#comment-16102793
 ] 

ASF GitHub Bot commented on CB-13028:
-

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/59

CB-13028 (CI) Browser builds on Travis and AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor and Travis to run tests on browser platform

### What testing has been done on this change?
See AppVeyor and Travis results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-globalization 
CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit e9a2b1771549ef7e30ccb5edc424daa31d32aa70
Author: Alexander Sorokin 
Date:   2017-07-27T06:41:37Z

CB-13028 (CI) Browser builds on Travis and AppVeyor




> Paramedic should be able to run tests for browser platform.
> ---
>
> Key: CB-13028
> URL: https://issues.apache.org/jira/browse/CB-13028
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-paramedic
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: ci
>
> Currently paramedic can't run tests for browser. For example, it constantly 
> waits for "cordova run" to finish, but with browser platform it never does.
> Ultimately we should aim to test browser platform on Sauce Labs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13093) Infinite looping when stressing navigation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102794#comment-16102794
 ] 

ASF GitHub Bot commented on CB-13093:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/328
  
Thanks for the PR. Is this issue reproducible by a unit test? See 
https://github.com/apache/cordova-ios/blob/master/tests/CordovaLibTests/CDVWebViewDelegateTests.m


> Infinite looping when stressing navigation
> --
>
> Key: CB-13093
> URL: https://issues.apache.org/jira/browse/CB-13093
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Luis Silva
>Assignee: Shazron Abdullah
>
> An infinite loop is caused by the shouldStartLoadWithRequest method of 
> CDVUIWebViewDelegate when a navigation starts with the 
> STATE_WAITING_FOR_LOAD_START and the ErrorUrl page is defined.
> I already have a fix for this issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12980) Improve instruction and add detail steps for plugins in cordova project.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102781#comment-16102781
 ] 

ASF GitHub Bot commented on CB-12980:
-

Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/713#discussion_r129762417
  
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with 
the **"Using CDVViewContr
 */
 viewController.wwwFolderName = @"myfolder";
 viewController.startPage = @"mypage.html"
-```
+    ```
+## Adding Plugins files used in you cordova project
--- End diff --

It's just that you skipped over all the parts of how they get the plugin 
source in the first place. That part is missing, since your steps assume a CLI 
workflow (assuming a Plugins folder and such).

In a CLI workflow, they just do "cordova plugin add". In an embedded 
webview workflow, how do they get it in without the CLI? This is the thing we 
haven't solved yet. By the way, just adding plugin source does not solve the 
problem totally, they have to add entries in config.xml, etc. It is not a 
trivial problem.


> Improve instruction and add detail steps for plugins in cordova project.
> 
>
> Key: CB-12980
> URL: https://issues.apache.org/jira/browse/CB-12980
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-docs
>Affects Versions: cordova@7.0.0
> Environment: iOS
>Reporter: sudotamm
>Assignee: Shazron Abdullah
>
> 1. Dynamic framework should be embed in app for launch pre-main loading.
> 2. Add steps to show how integrate cordova in xcode which used in cordova 
> project.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13033) after_plugin_install hook's project.pbxproj modification is overwritten.

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102778#comment-16102778
 ] 

Shazron Abdullah commented on CB-13033:
---

Not sure of the source of the bug. However, if you are trying to set a build 
property for Xcode, you should use the buildFlag flag or build.json buildFlag 
property now: 
https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#xcode-build-flags

> after_plugin_install hook's project.pbxproj modification is overwritten.
> 
>
> Key: CB-13033
> URL: https://issues.apache.org/jira/browse/CB-13033
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: cordova cli version: 7.0.1
> cordova-ios@4.4.0
> cordova-plugin-statusbar: 2.2.3
> cordova-plugin-whitelist: 1.3.2
>Reporter: Jongmin Ye
>Assignee: Shazron Abdullah
>
> Hello.
> I found this issue(https://issues.apache.org/jira/browse/CB-11258) on google, 
> so I joined to let you know this is reproducible.
> I am doubting what I did is correct way because I am newbie, so I wrote all I 
> did.
> # create project.
> {code:none}
> $cordova create testProject ...
> {code}
> # add plugins and ios platform
> {code:none}
> $cordova plugin add cordova-plugin-statusbar
> $cordova plugin add cordova-plugin-whitelist
> $cordova platform add ios
> {code}
> # add after_plugin_install hook to cordova-plugin-statusbar
> {code:XML}
> //add following line to 
> {PROJ_HOME}/plugins/cordova-plugin-statusbar/plugin.xml
> 
> {code}
> {code:JavaScript}
> //open 
> {PROJ_HOME}/plugins/cordova-plugin-statusbar/hooks/after_plugin_install.js 
> file and paste below codes.
> module.exports = function(context)
> {
> var fs = require('fs');
> var xcode = context.requireCordovaModule('xcode');
> var util = context.requireCordovaModule('cordova-lib/src/cordova/util');
> var ConfigParser = 
> context.requireCordovaModule('cordova-lib/src/configparser/ConfigParser');
> var projectName = new 
> ConfigParser(util.projectConfig(util.isCordova())).name();
> var projectPath = './platforms/ios/' + projectName + 
> '.xcodeproj/project.pbxproj';
> var myProj = xcode.project(projectPath);
> myProj.parseSync(); myProj.updateBuildProperty('ENABLE_BITCODE', 'NO'); 
> fs.writeFileSync(projectPath, myProj.writeSync());
> console.log('✔ BITCODE disable');
> };
> {code}
> # remove and add ios platform
> {code:none}
> $cordova platform rm ios
> $cordova platform add ios
> {code}
> Then, you will find there is no *ENABLE_BITCODE* in the project.pbxproj file.
> I think only the last installed plugin's project.pbxproj modification is not 
> overwritten.
> If I move above hook to cordova-plugin-whitelist, it works.
> If you need further info or I am doing wrong, please let me know.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org